e56457f7fe
Taxonomy: Correct the accetped types for the `taxonomy` element in the arguments passed to `wp_dropdown_categories()`.
...
Props grapplerulrich
Fixes #35446
Built from https://develop.svn.wordpress.org/trunk@36289
git-svn-id: http://core.svn.wordpress.org/trunk@36256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 20:16:29 +00:00
9cd5b76fbd
jQuery: Replace `$( document ).on( 'ready', fn )` with `$( fn )`.
...
The 'ready' event is deprecated since jQuery 1.8.
See https://github.com/jquery/jquery-migrate/blob/1.3.0/warnings.md#jqmigrate-ready-event-is-deprecated .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36288
git-svn-id: http://core.svn.wordpress.org/trunk@36255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 17:39:25 +00:00
b7df807589
jQuery: Replace use of the `.load()` method for the "load" event with `.on( 'load', handler )`.
...
The shortcut is deprecated since jQuery 1.8.
See http://api.jquery.com/load-event/ .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36287
git-svn-id: http://core.svn.wordpress.org/trunk@36254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 17:22:27 +00:00
b3d8732c17
jQuery: Replace the use of the `.size()` method with the `.length` property.
...
The `.size()` method is deprecated since jQuery 1.8. The `.length` property is preferred because it doesn't have the overhead of a function call.
See https://api.jquery.com/size/ .
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36286
git-svn-id: http://core.svn.wordpress.org/trunk@36253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 16:17:27 +00:00
b1a9983584
External Libraries: Update jQuery to 1.12.0 and jQuery Migrate to 1.3.0.
...
jQuery:
* Release post: http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
* Changes: https://github.com/jquery/jquery/compare/1.11.3...1.12.0
jQuery Migrate:
* Release post: http://blog.jquery.com/2016/01/13/jquery-migrate-1-3-0-released/
* Changes: https://github.com/jquery/jquery-migrate/compare/1.2.1...1.3.0
See #35380 .
Built from https://develop.svn.wordpress.org/trunk@36285
git-svn-id: http://core.svn.wordpress.org/trunk@36252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 15:52:26 +00:00
b8f2a138e7
Set `svn:eol-style` to native on "jquery-migrate.js" and "jquery-migrate.min.js".
...
Built from https://develop.svn.wordpress.org/trunk@36284
git-svn-id: http://core.svn.wordpress.org/trunk@36251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 15:45:28 +00:00
0a6f311922
Plugins: In `_get_plugin_data_markup_translate()` remove the fallback to the "default" textdomain for Akismet.
...
Akismet has its own language files since WordPress 3.9.
Props jrf.
Fixes #35436 .
Built from https://develop.svn.wordpress.org/trunk@36283
git-svn-id: http://core.svn.wordpress.org/trunk@36250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 13:56:26 +00:00
a51129c2a6
Plugins: In `_get_plugin_data_markup_translate()` don't reload translations if they're already loaded.
...
Props jrf.
Fixes #35439 .
Built from https://develop.svn.wordpress.org/trunk@36282
git-svn-id: http://core.svn.wordpress.org/trunk@36249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 13:04:27 +00:00
2d136ce421
Use `assertEqualSets()` in `comment_author` test.
...
The previous assertion was too specific, resulting in race conditions.
See #35377 .
Built from https://develop.svn.wordpress.org/trunk@36279
git-svn-id: http://core.svn.wordpress.org/trunk@36246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 04:43:26 +00:00
2d74b18bea
Support searching for `'0'` in `WP_Query`.
...
Props swissspidy.
See #31025 .
Built from https://develop.svn.wordpress.org/trunk@36278
git-svn-id: http://core.svn.wordpress.org/trunk@36245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 04:37:25 +00:00
98fb5f0bdb
Use the post-filter WHERE clause when querying for comment descendants.
...
The descendant query in `WP_Comment_Query::fill_descendants()` uses the clauses
of the main `get_comment_ids()` query as a basis, discarding the `parent`,
`parent__in`, and `parent__not_in` clauses. As implemented in WP 4.4 [34546],
the WHERE clause was assembled in such a way that any modifications applied
using the `comments_clauses` filter were not inherited by `fill_descendants()`.
This resulted in descendant queries that did not always properly filter
results, and sometimes contained syntax errors.
The current changeset fixes the problem by using the post-filter WHERE clause
as the basis for the `fill_descendants()` query. This change requires a new
approach for eliminating the unneeded parent-related clauses: instead of
eliminating values in an associative array, we must use regular expressions.
Props boonebgorges, firebird75.
Fixes #35192 .
Built from https://develop.svn.wordpress.org/trunk@36277
git-svn-id: http://core.svn.wordpress.org/trunk@36244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 04:01:26 +00:00
4ac35f5713
Always respect `$comments` array passed to `wp_list_comments()`.
...
[36157] fixed a bug whereby `wp_list_comments()` would not properly recognize
custom pagination arguments. See #35175 . However, it inadvertently introduced
a bug that caused any `$comments` array explicitly passed to the function to be
ignored, when that array was accompanied by pagination arguments that differ
from those in `$wp_query`. We address this bug by moving the logic introduced
in [36157] inside a block that only fires when no `$comments` array has been
provided to the function.
Props ivankristianto.
Fixes #35356 .
Built from https://develop.svn.wordpress.org/trunk@36276
git-svn-id: http://core.svn.wordpress.org/trunk@36243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 03:27:27 +00:00
294a164b15
Ignore hierarchy in pagination calculation when comment threading is disabled.
...
In order to calculate comment pagination when newest comments are displayed
first, `comments_template()` must perform a separate query to determine the
total number of paginating comments available on a post. See [34729], #8071 ,
pagination calculation - can be defined as a top-level comment, or a comment
with `parent=0`. However, when comment threading is disabled, yet comments
exist in the database that have parents, all comments - even those with a
parent - are "paginating". (This typically happens when comments threading was
once enabled, but has since been turned off.) As such, the total-paginating-
comments query should only be limited to top-level comments when
'thread_comments' is disabled.
Props jmdodd.
Fixes #35419 .
Built from https://develop.svn.wordpress.org/trunk@36275
git-svn-id: http://core.svn.wordpress.org/trunk@36242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 03:13:25 +00:00
5036a79e73
Add missing HTTP status code descriptions (specifically 308 and 421.)
...
Props kraftbj.
Fixes 35336.
Built from https://develop.svn.wordpress.org/trunk@36274
git-svn-id: http://core.svn.wordpress.org/trunk@36241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 02:55:26 +00:00
dea447f04c
Add support for 451 http status code (Unavailable For Legal Reasons.)
...
Though this is technically still in the proposal stage, there is support from the core team and precedent in #16914
Props andizer.
Fixes #35333 .
Built from https://develop.svn.wordpress.org/trunk@36273
git-svn-id: http://core.svn.wordpress.org/trunk@36240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 02:49:25 +00:00
87e7b4455d
Comments: Restrict the maximum characters for input fields within the comments template.
...
Added hardcoded maxlength attributes on the author, author_email, author_url, and comment_field input markup. These can be modified via the comment_form_defaults filter. Added logic in wp_handle_comment_submission() to return a WP_Error when the comment_author, comment_author_url, or comment_content values exceed the max length of their columns. Introduces wp_get_comment_column_max_length() which returns the max column length for a given column name, and is filterable. Unit tests included for the error conditions in wp_handle_comment_submission()
Fixes #10377 .
Props westonruter rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@36272
git-svn-id: http://core.svn.wordpress.org/trunk@36239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 01:25:26 +00:00
6bd2399382
Docs: Fix typo in wp-admin/admin.php.
...
Props sebastian.pisula
Fixes #35423 .
Built from https://develop.svn.wordpress.org/trunk@36271
git-svn-id: http://core.svn.wordpress.org/trunk@36238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 20:43:28 +00:00
c0e903a040
Themes: Clear floated theme cards on Themes page.
...
Also maintains visual separation for Broken Themes table on searches that
return no results.
See [36171] for `.wp-clearfix`.
Props 5um17, obenland, valendesigns, afercia.
Fixes #26646 .
Built from https://develop.svn.wordpress.org/trunk@36270
git-svn-id: http://core.svn.wordpress.org/trunk@36237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 17:13:29 +00:00
d0c1f44d21
Docs: Revert [36268] as the global is indeed used, just via the superglobal.
...
Fixes #35413 .
Built from https://develop.svn.wordpress.org/trunk@36269
git-svn-id: http://core.svn.wordpress.org/trunk@36236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 12:26:27 +00:00
14f073a154
Docs: Fix incorrect DocBlock for `wp_get_attachment_url()`.
...
The documented `$pagenow` global isn't used in the function.
Props sebastian.pisula.
Fixes #35413 .
Built from https://develop.svn.wordpress.org/trunk@36268
git-svn-id: http://core.svn.wordpress.org/trunk@36235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 12:08:26 +00:00
44ad0964b0
After [36263] escape filterable HTML output.
...
Props adamsilverstein.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36267
git-svn-id: http://core.svn.wordpress.org/trunk@36234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 08:58:26 +00:00
e7660a104d
Introduce `wp_get_raw_referer()` to retrieve unvalidated referer.
...
For things like redirects `wp_get_referer()` should be used instead.
Props voldemortensen for initial patch.
Fixes #27152 .
Built from https://develop.svn.wordpress.org/trunk@36266
git-svn-id: http://core.svn.wordpress.org/trunk@36233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 08:32:28 +00:00
5bd888497d
Accessibility: Remove title attributes from the Terms list table.
...
Fixes #35187 .
Built from https://develop.svn.wordpress.org/trunk@36265
git-svn-id: http://core.svn.wordpress.org/trunk@36232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 23:30:26 +00:00
876ab5c293
Menus screen: improve responsiveness of select elements.
...
Props Luan-Ramos, sagarjadhav.
Fixes #31826 .
Built from https://develop.svn.wordpress.org/trunk@36264
git-svn-id: http://core.svn.wordpress.org/trunk@36231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 23:05:26 +00:00
057ec3cec0
Accessibility: Remove title attributes from the General Settings screen.
...
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.
Props afercia, perezlabs.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36263
git-svn-id: http://core.svn.wordpress.org/trunk@36230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 22:54:28 +00:00
dd123ab2c0
Customizer: Re-use list of components to eliminate code duplication.
...
Introduces protected `WP_Customize_Manager::$components` to store list of loaded core components filtered by `customize_loaded_components`.
Props DrewAPicture.
See #35242
See #33552 .
Fixes #35354 .
Built from https://develop.svn.wordpress.org/trunk@36262
git-svn-id: http://core.svn.wordpress.org/trunk@36229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 20:28:28 +00:00
3e35a7157f
Customizer: Prevent erroneously directing user to login screen when closing.
...
Fixes issue where user gets stuck at login screen after trying to close the app if previously they had to first login to access the Customizer. Prevents `WP_Customize_Manager::get_return_url()` from using `wp-login.php` as a referer.
Props chandrapatel.
See #32637 .
Fixes #35355 .
Built from https://develop.svn.wordpress.org/trunk@36261
git-svn-id: http://core.svn.wordpress.org/trunk@36228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 18:51:28 +00:00
9b486acb9b
Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.
...
Fixes #35401 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36260
git-svn-id: http://core.svn.wordpress.org/trunk@36227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 13:15:29 +00:00
abbcc01542
Multisite: The `networks` group should be global.
...
Fixes #35251 .
Built from https://develop.svn.wordpress.org/trunk@36258
git-svn-id: http://core.svn.wordpress.org/trunk@36225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 05:04:26 +00:00
2c96c289cf
Add missing param to 'comments_template_query_args'.
...
As introduced in [36235].
Props birgire.
See #34442 .
Built from https://develop.svn.wordpress.org/trunk@36256
git-svn-id: http://core.svn.wordpress.org/trunk@36223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 02:28:27 +00:00
d63ae29fac
After [36254], commit all the necessary files and not just the unit test.
...
Built from https://develop.svn.wordpress.org/trunk@36255
git-svn-id: http://core.svn.wordpress.org/trunk@36222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 19:07:26 +00:00
34dfb47c4b
Rewrite: Ensure `WP_Rewrite::flush_rules()` does not delete the 'rewrite_rules' option.
...
Instead, the option gets updated to an empty string.
Adds unit tests.
Props SergeyBiryukov, jesin, voldemortensen.
Fixes #29107 .
Built from https://develop.svn.wordpress.org/trunk@36254
git-svn-id: http://core.svn.wordpress.org/trunk@36221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 19:02:26 +00:00
73317a33b6
Permalinks: Ensure the page hierarchy is correct for sample permalinks.
...
Fixes #35368 .
Built from https://develop.svn.wordpress.org/trunk@36253
git-svn-id: http://core.svn.wordpress.org/trunk@36220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 18:28:28 +00:00
909470db67
Don't reset index keys when trimming results of term queries.
...
`array_slice()` must be told to preserve keys when the query results exceed the
limit specified the 'number' parameter, so that `id=>parent` and other
id-indexed return value formats don't get mangled.
Props fantasyworld, wpdelighter.
Fixes #35382 .
Built from https://develop.svn.wordpress.org/trunk@36252
git-svn-id: http://core.svn.wordpress.org/trunk@36219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 04:06:25 +00:00
cfae56d2c2
Avoid invalid SQL when building ORDER BY clause using long search strings.
...
The introduction of negative search terms in 4.4 [34934] introduced the
possibility that the ORDER BY clause of a search query could be assembled in
such a way as to create invalid syntax. The current changeset fixes this by
ensuring that the ORDER BY clause corresponding to the search terms is
excluded when it would otherwise be empty.
Props salvoaranzulla.
Fixes #35361 .
Built from https://develop.svn.wordpress.org/trunk@36251
git-svn-id: http://core.svn.wordpress.org/trunk@36218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 03:26:26 +00:00
a4facedfee
Docs: Various docblock corrections.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36250
git-svn-id: http://core.svn.wordpress.org/trunk@36217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:26:25 +00:00
877d14883e
Emoji: Explictly use `https` as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway.
...
Fixes #35376
Props ocean90
Built from https://develop.svn.wordpress.org/trunk@36249
git-svn-id: http://core.svn.wordpress.org/trunk@36216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:24:26 +00:00
f63dc802cb
Comments: Correct the docblocks for various methods in the comment list table class.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36248
git-svn-id: http://core.svn.wordpress.org/trunk@36215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 00:52:25 +00:00
16fe7012dd
Taxonomy: More tests for `unregister_taxonomy()`.
...
See #35227
Built from https://develop.svn.wordpress.org/trunk@36247
git-svn-id: http://core.svn.wordpress.org/trunk@36214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 23:35:26 +00:00
c52af7470b
Login is not a verb, change "login" to "log in".
...
See #35387
Built from https://develop.svn.wordpress.org/trunk@36246
git-svn-id: http://core.svn.wordpress.org/trunk@36213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 21:08:26 +00:00
2f41867519
Users: Fix incorrect docs for user authentication and login functions.
...
Fixes #35387
Built from https://develop.svn.wordpress.org/trunk@36245
git-svn-id: http://core.svn.wordpress.org/trunk@36212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 20:52:27 +00:00
2e4210e209
Taxonomy: Use `Invalid taxonomy` instead of `Invalid Taxonomy` for error strings.
...
Built from https://develop.svn.wordpress.org/trunk@36244
git-svn-id: http://core.svn.wordpress.org/trunk@36211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 15:16:25 +00:00
710501dc53
Taxonomy: Introduce `unregister_taxonomy()`.
...
This new function can be used to completely unregister non built-in taxonomies.
Fixes #35227 .
Built from https://develop.svn.wordpress.org/trunk@36243
git-svn-id: http://core.svn.wordpress.org/trunk@36210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:58:26 +00:00
d591f26ce7
Ensure `wp_get_referer()` returns `false` when the referrer URL is the current URL.
...
Adds unit tests.
Fixes #19856 .
Built from https://develop.svn.wordpress.org/trunk@36242
git-svn-id: http://core.svn.wordpress.org/trunk@36209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:36:26 +00:00
fdb6bbfa10
Media: After [36240], remove some unneeded whitespace.
...
Props ocean90.
See #35367 .
Built from https://develop.svn.wordpress.org/trunk@36241
git-svn-id: http://core.svn.wordpress.org/trunk@36208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:29:26 +00:00
8ee945d82f
Media: Fix `wp_audio_shortcode` and `wp_video_shortcode` attributes handling.
...
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.
Fixes #35367 .
Built from https://develop.svn.wordpress.org/trunk@36240
git-svn-id: http://core.svn.wordpress.org/trunk@36207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:18:27 +00:00
43d8a30d0c
Tests: Add more paged canonical tests for page_on_front.
...
See #35344 .
Built from https://develop.svn.wordpress.org/trunk@36238
git-svn-id: http://core.svn.wordpress.org/trunk@36205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 08:09:26 +00:00
84a3b4407f
Canonical: Generate the correct canonical url for paged posts/pages when they're used as the page_on_front.
...
This fixes an issue where pages become inacessible on a front page post.
Fixes #35344 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36237
git-svn-id: http://core.svn.wordpress.org/trunk@36204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 07:33:27 +00:00
d57776b108
Tests: Remove some debug that's slipped in at some point.
...
Built from https://develop.svn.wordpress.org/trunk@36236
git-svn-id: http://core.svn.wordpress.org/trunk@36203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 06:12:27 +00:00
72265e4a98
Introduce `comments_template_query_args` filter.
...
This new filter gives developers a way to target the arguments used for comment
queries specifically when populating the main comment template.
Props birgire.
Fixes #34442 .
Built from https://develop.svn.wordpress.org/trunk@36235
git-svn-id: http://core.svn.wordpress.org/trunk@36202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 04:44:26 +00:00
John Blackbourn
Dominik Schilling
Boone Gorges
Joe Hoyle
Rachel Baker
Eric Lewis
Konstantin Obenland
Pascal Birchler
Andrea Fercia
Weston Ruter
Dion Hulse