Commit Graph

31 Commits

Author SHA1 Message Date
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Weston Ruter f78775a6db Customize: Use selective refresh to preview changes to site title and tagline in core themes.
Fixes issue where `wptexturize` and other filters fail to apply when previewing changes via `postMessage` transport.

See #27355.
Fixes #33738.

Built from https://develop.svn.wordpress.org/trunk@36797


git-svn-id: http://core.svn.wordpress.org/trunk@36764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-01 22:18:26 +00:00
Sergey Biryukov 1137b70ef3 Twenty Fifteen: Document the `'twentyfifteen_color_schemes'` filter.
Props DrewAPicture.
Fixes #34119.
Built from https://develop.svn.wordpress.org/trunk@34791


git-svn-id: http://core.svn.wordpress.org/trunk@34756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 01:10:26 +00:00
Lance Willett 9917758155 Twenty Fifteen: more styles for multi-site forms.
Props iamtakashi, closes #30776.
Built from https://develop.svn.wordpress.org/trunk@31001


git-svn-id: http://core.svn.wordpress.org/trunk@30983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-30 10:30:22 +00:00
Dominik Schilling 289f29ac0b Twenty Fifteen: Don't escape translated strings.
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30896


git-svn-id: http://core.svn.wordpress.org/trunk@30886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:00:22 +00:00
Dominik Schilling 7e98a6647e Twenty Fifteen: Don't save unfiltered CSS in a setting.
Introduce `twentyfifteen_get_color_scheme_css( $colors )` which will be used for Underscore/Backbone and the PHP side. Let `twentyfifteen_color_scheme_css()` handle the color calculation on PHP side.

see #30409.
Built from https://develop.svn.wordpress.org/trunk@30893


git-svn-id: http://core.svn.wordpress.org/trunk@30883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 12:27:26 +00:00
Ian Stewart 8feb6cfcf3 Twenty Fifteen: we should be checking for twentyfifteen_get_color_scheme_choices here not twentyfifteen_get_color_scheme_control_options
Props iamtakashi, fixes #30652


Built from https://develop.svn.wordpress.org/trunk@30802


git-svn-id: http://core.svn.wordpress.org/trunk@30792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-10 13:21:23 +00:00
Andrew Ozz adf4f440f5 Twenty Fifteen: clean up of `twentyfifteen_color_scheme_css_template()` in customizer.php. Props iamtakashi. Fixes #30601.
Built from https://develop.svn.wordpress.org/trunk@30763


git-svn-id: http://core.svn.wordpress.org/trunk@30753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 02:40:21 +00:00
Ian Stewart a83fdf7b17 Twenty Fifteen: updating customizer label text for more clarity.
Props iamtakashi, fixes #30545.


Built from https://develop.svn.wordpress.org/trunk@30741


git-svn-id: http://core.svn.wordpress.org/trunk@30731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 22:57:22 +00:00
Ian Stewart 20ea28b289 Twenty Fifteen: removing unused styles.
Props iamtakashi, fixes #30578.


Built from https://develop.svn.wordpress.org/trunk@30728


git-svn-id: http://core.svn.wordpress.org/trunk@30718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:03:23 +00:00
Ian Stewart 2e123ad458 Twenty Fifteen: minor corrections to borders and post title colors in custom color schemes.
Props iamtakashi, fixes #30521.



Built from https://develop.svn.wordpress.org/trunk@30588


git-svn-id: http://core.svn.wordpress.org/trunk@30578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 20:34:24 +00:00
Ian Stewart e11418abdc Twenty Fifteen: docs correction and cleanup.
Props DrewAPicture, see #30149.


Built from https://develop.svn.wordpress.org/trunk@30569


git-svn-id: http://core.svn.wordpress.org/trunk@30559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 20:57:24 +00:00
Ian Stewart de060dcfee Twenty Fifteen: escaping here breaks color schemes.
Props celloexpressions, iamtakashi, fixes #30409.



Built from https://develop.svn.wordpress.org/trunk@30398


git-svn-id: http://core.svn.wordpress.org/trunk@30394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 01:35:24 +00:00
Ian Stewart 99a35f20e6 Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes.
Props celloexpressions, iandstewart, fixes #30316


Built from https://develop.svn.wordpress.org/trunk@30315


git-svn-id: http://core.svn.wordpress.org/trunk@30314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:01:21 +00:00
Ian Stewart 1317409eda Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.
Props celloexpressions, see #29988


Built from https://develop.svn.wordpress.org/trunk@30305


git-svn-id: http://core.svn.wordpress.org/trunk@30304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:36:23 +00:00
Ian Stewart fa81522cb2 Twenty Fifteen: add instant updating of color schemes to the customizer with postMessage.
Props celloexpressions, bradyvercher, westonruter, fixes #29988.



Built from https://develop.svn.wordpress.org/trunk@30274


git-svn-id: http://core.svn.wordpress.org/trunk@30274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 20:55:23 +00:00
Ian Stewart c3ec04c532 Twenty Fifteen: adding help text to explain how color changes to header and sidebar are affected by responsive design.
Props iamtakashi, iandstewart, fixes #30165.


Built from https://develop.svn.wordpress.org/trunk@30272


git-svn-id: http://core.svn.wordpress.org/trunk@30272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:31:22 +00:00
Ian Stewart 78c26017c6 Twenty Fifteen: improve naming and documentation of customizer js files to match core filenaming conventions.
Props celloexpressions, fixes #30160.


Built from https://develop.svn.wordpress.org/trunk@30271


git-svn-id: http://core.svn.wordpress.org/trunk@30271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:20:22 +00:00
Ian Stewart d21ea0a251 Twenty Fifteen: Formatting cleanup for documentation, crossing eyes, dotting tees.
Props lancewillett, MikeHansenMe, fixes #30149.

Built from https://develop.svn.wordpress.org/trunk@30233


git-svn-id: http://core.svn.wordpress.org/trunk@30233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:26:23 +00:00
Ian Stewart 17dbe26df9 Twenty Fifteen: Simplify the header, sidebar, background controls and make customization faster for users to do. This has the added benefit of fixing our bug where hidden header text wasn't being updated on color scheme switch. Nice.
Props celloexpressions, iamtakashi, fixes #30164 and #29980.

Built from https://develop.svn.wordpress.org/trunk@30230


git-svn-id: http://core.svn.wordpress.org/trunk@30230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:42:22 +00:00
Ian Stewart a46c99cf78 Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus
Props morganestes, iamtakashi, fixes #30108


Built from https://develop.svn.wordpress.org/trunk@30208


git-svn-id: http://core.svn.wordpress.org/trunk@30208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 17:01:23 +00:00
Lance Willett 29328f2512 Twenty Fifteen: minor code style for variable within array notation. See #30133.
Built from https://develop.svn.wordpress.org/trunk@30048


git-svn-id: http://core.svn.wordpress.org/trunk@30048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 16:40:19 +00:00
Lance Willett f02161b05b Twenty Fifteen: spacing and code style cleanup. See #30133.
Built from https://develop.svn.wordpress.org/trunk@30045


git-svn-id: http://core.svn.wordpress.org/trunk@30045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 16:27:19 +00:00
Sergey Biryukov 85c824218f Twenty Fifteen: Isolate :not selectors from CSS2 selectors.
props peterwilsoncc, iamtakashi.
fixes #30014.
Built from https://develop.svn.wordpress.org/trunk@29996


git-svn-id: http://core.svn.wordpress.org/trunk@29737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-23 11:44:19 +00:00
Ian Stewart 5d4f0ac993 Twenty Fifteen: correct styles for color schemes
Props iamtakashi, fixes #29976.


Built from https://develop.svn.wordpress.org/trunk@29971


git-svn-id: http://core.svn.wordpress.org/trunk@29717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-20 18:57:26 +00:00
Ian Stewart 9ed425438f Twenty Fifteen: Removing unused custom color controls.
Props cainm, fixes #29982 and #29959.


Built from https://develop.svn.wordpress.org/trunk@29944


git-svn-id: http://core.svn.wordpress.org/trunk@29694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:52:19 +00:00
Ian Stewart 507fee2825 Twenty Fifteen: Fix hover and focus style for links in content with custom color schemes.
Props iamtakashi, fixes #29978.

Built from https://develop.svn.wordpress.org/trunk@29942


git-svn-id: http://core.svn.wordpress.org/trunk@29693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:32:21 +00:00
Ian Stewart 31c0fa1c6e Twenty Fifteen: readable comment details in the dark colour scheme.
Props NikV, fixes #29970.


Built from https://develop.svn.wordpress.org/trunk@29930


git-svn-id: http://core.svn.wordpress.org/trunk@29682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 22:01:18 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Ian Stewart affa411402 Importing Twenty Fifteen, first pass at our new default theme for 2015, set for 4.1.
It's good for posts, it's good for pages, it might be good for you. Development will occur in trunk. Have at it.

Props matt, iandstewart, iamtakashi, obenland, cainm, kristastevens, karmatosed, chellycat, lancewillett, kwight, davidakennedy. See #29799


Built from https://develop.svn.wordpress.org/trunk@29892


git-svn-id: http://core.svn.wordpress.org/trunk@29648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 19:28:18 +00:00