Commit Graph

28 Commits

Author SHA1 Message Date
Andrew Nacin 5cb01f0b9b Stop using get_blogaddress_by_domain() when updating the siteurl/homeurl from the network admin.
props jeremyfelt, SergeyBiryukov.
fixes #18242. see #25235.

Built from https://develop.svn.wordpress.org/trunk@25261


git-svn-id: http://core.svn.wordpress.org/trunk@25229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 18:49:09 +00:00
Ryan Boren f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
ryan 5ca54e7d2f Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option().
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.

Group multiple operations within a single switch where possible.

fixes #21432


git-svn-id: http://core.svn.wordpress.org/trunk@21414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 17:51:42 +00:00
nacin eb8e069932 Correct the link to http://codex.wordpress.org/Network_Admin_Sites_Screen in the network admin help sidebars. props Nao. fixes #20607.
git-svn-id: http://core.svn.wordpress.org/trunk@20713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 13:34:33 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan 8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:22:07 +00:00
nacin e62b1ce3c9 More help sidebars. see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:54:56 +00:00
ryan f938faa814 Link to site being edited. Props lloydbudd. fixes #17257
git-svn-id: http://svn.automattic.com/wordpress/trunk@18129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-03 15:35:45 +00:00
nacin b1c557fa4b D'oh. Use the proper URL to the multisite support forum. see #15880.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-25 19:21:00 +00:00
nacin 0f2672e53d Move to what will be the new Network Admin Codex page URLs. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-18 18:27:12 +00:00
nacin 661ff40dfe Merge the help strings across the network/site- pages. see #15880.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-18 18:02:11 +00:00
nacin 5fa861493b Network admin contextual help fixes. props SergeyBiryukov, fixes #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-17 23:34:10 +00:00
nacin 31b4959b1b Minor cleanups.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:41:38 +00:00
nacin f32e4cb961 Network Admin: Rename Options to Settings. Kick the tab to the end as well. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:13:01 +00:00
nacin 9417d79543 Move to 'Documentation on XY' in the network admin. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:07:42 +00:00
nacin d0e27b0935 Network Admin contextual help. props andrea_r (!), see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:52:47 +00:00
nacin a717edca97 Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 18:02:54 +00:00
nacin 8d00b7b63b s/can_edit_site/can_edit_network/g. see #15720.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 12:36:39 +00:00
westi 381a4f7750 Introduce can_edit_site to replace inline checks on whether or not the site_id is for the current Network. See #15716.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 14:28:40 +00:00
PeteMall 0ce36a9d29 Add missign hooks in site-options. Fixes #15593
git-svn-id: http://svn.automattic.com/wordpress/trunk@16627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-30 20:29:02 +00:00
ryan f721d88eda Whitespace cleanup. Props sorich87. see #14147
git-svn-id: http://svn.automattic.com/wordpress/trunk@16306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 16:57:22 +00:00
nacin f269b75d7b Network admin multisite checks and docs. see #14435.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 14:27:15 +00:00
ryan da54089621 Generalize seletion for h2 and h3 tabs. Props chrisbliss18 fixes #15154
git-svn-id: http://svn.automattic.com/wordpress/trunk@15962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 20:45:58 +00:00
nacin c93f639f1e Use correct network admin icon. props PeteMall, see #15174.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 20:24:54 +00:00
nacin 1e640c7b0a Checkboxes over radio buttons for site info tab. Values outside of 0/1 won't be changed, see #12832 for previous discussion. see #15174.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 20:23:54 +00:00
ryan 012bb5278c Tabbed interface for site editing. see #15174
git-svn-id: http://svn.automattic.com/wordpress/trunk@15903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 18:35:52 +00:00