* Skips validation where there is no attribute definition, but keeps the attribute value. Previously, the attribute would be omitted from the attributes passed to `render_callback`. Notably, this resolves an issue where `render_callback` cannot receive a block's `align` and `customClassName` attribute values, since these are defined as a client-side filter.
* Validates `null` as a proper value in its own right. Previously, a client implementation of a block could track `{"attribute":null}` as an explicitly empty value, and the server would wrongly initiate defaulting behavior. The new behavior will now only populate a default value if the attribute is not defined at all, including when unset in its being invalid per the attribute schema.
Props aduth, noisysocks, youknowriad.
See #45145 for the patch, #45098 for the original ticket.
Built from https://develop.svn.wordpress.org/branches/5.0@43918
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This update changes the following:
- Fix JS errors in customizer caused by menu scripts
- Fix footer menu spacing
- Fix pullquote block borders to follow Gutenberg’s described style
- Fix editor-only styles so they don't appear on the frontend when not needed
- Fix search field widget width on mobile
- Fix :visited .button link colors
- Fix Block toolbar position in the editor
- Fix off-canvas mobile menu to prevent text from overflowing
- Improve column block formatting for the editor and frontend
- Improve CSS optimization for selectors that add `dashes` to multi-level lists
- Improve editor font sizes to use pixels over ems
- Improve styles for galleries in the Classic Editor block
- Improve priority+ more-menu threshold to allow more space for menu-items
- Improve logo size on mobile devices
- Improve customizer color options to present a single, unified color option
- Improve print stylesheet for better spacing and colors
- Add more color options to Gutenberg editor
Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen
Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, jorbin, netweb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins, peterwilsoncc, dannycooper, iCaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, grapplerulrich, ocean90, joshfeck, frankew, AbdulWahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, nao, mayukojpn, enodekciw, ketuchetan, atanasangelovdev, poena, sharaz, artisticasad, mukesh27, burhandodhy, crunnells, aprakasa, themeroots, imonly_ik, tlxo, youthkee, brentswisher, smyoon315, mrahmadawais, desideveloper, Kau-Boy, mor10, mikeyarce, dingo_bastard
Built from https://develop.svn.wordpress.org/branches/5.0@43909
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In [43736], we prevented rendering fields when not present in `?_fields=`. However, because `get_fields_for_response()` is dependent on `get_item_schema()`, any custom fields registered with a null schema would be incorrectly excluded from the response. Because the REST API permits a null schema for `register_rest_field()`, those fields should be included in the available fields for a response.
Fixes#45220.
Built from https://develop.svn.wordpress.org/branches/5.0@43908
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This update changes the following:
- Improve menu UI to support keyboard navigation in both directions
- Improve more-menu-link visibility when no menu items are hidden
- Improve text-selection custom colors for better contrast and legibility
- Improve support for sticky toolbars in the editor
- Improve table element fonts
- Add .button class support
- Remove translation escaping
- Fix menu JS to prevent unused touched event listeners
- Fix duplicate more-menu-link issue on selective refresh in the customizer
- Fix editor font-weights for headings
- Fix search form input style
- Fix nested blockquote styles
- Fix download block button style when download text stretches more than one line
- Fix audio block centering issue
- Fix align-full blocks in the editor so they don’t create horizontal scrollbars
- Fix editor to prevent Gutenberg's meta boxes area from overlapping the content
Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen
Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, ntwb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins12, peterwilsoncc, DannyCooper, WPprodigy, siriokun, briannaorg, 00travelgirl00, shahjehanali1, ianbelanger79, nadim1992, Ismail-elkorchi, nativeinside, iamchetanp, grappler, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, jasmussen, laurelfulford, mdawaffe, kraftbj, dereksmart, naokomc, mayukojpn, enodekciw, chetansatasiya, ketuchetan, atanas-angelov-dev, carolinan, sharazghouri, artisan-asad, mukeshpanchal27, mukesh27, burhandodhy, @crunnells, aryaprakasa, tlxo, themeroots, whizbangik, yingles, tlxo, youthkee, brentswisher, smy315, ahmadawais, desi-developer, 2ndkauboy, mor10.
Built from https://develop.svn.wordpress.org/branches/5.0@43904
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, the TinyMCE inline scripts were added on the `init` action in the block editor. In the classic editor, however, these scripts are loaded when the TinyMCE window is printed, and some plugins rely on them being loaded later, so they can attach to the appropriate filters.
See #45338.
Built from https://develop.svn.wordpress.org/branches/5.0@43901
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
I'm sorry, Hello Dolly. You're my favourite plugin, but the way you output your lyrics doesn't play nicely with the block editor, particuarly on mobile devices.
This isn't Farewell Dolly, you're still on every other admin page, and I know you'll come back better and stronger.
Props joen.
See #45345.
Built from https://develop.svn.wordpress.org/branches/5.0@43900
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When switching themes, `wp_map_nav_menu_locations()` is used to ensure nav menus are placed in the relevant menu location. Occasionally, menus are registered to locations with numeric slugs, rather than strings. `wp_map_nav_menu_locations()` assumed it would be the latter, and ran `stripos()` on those numeric slugs. This behaviour is deprecated in PHP 7.3.
As this is the last known PHP 7.3 incompatibility, this commit also removes PHP 7.3 from Travis' `allowed_failures` list.
Props desrosj, jorbin.
See #45018.
Built from https://develop.svn.wordpress.org/branches/5.0@43899
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When 'parent' is set as the path argument name, it gets passed down through to the `create_item()` method and can erroneously reset the 'parent' value on the post itself. Instead, we rename the argument to 'id' and replicate the revision controller's `get_items_permissions_check()` to instead reference 'id'.
Also ensures revision query params (of which there are many) aren't exposed as the query params for autosaves (of which there are two).
Props TimothyBlynJacobs.
See #43316.
Built from https://develop.svn.wordpress.org/branches/5.0@43897
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When making an ajax request, `wp_enqueue_registered_block_scripts_and_styles()` checked if `is_admin()` was true before accessing `$current_screen`, rather than checking if `$current_screen` was defined. This is usually fine, execept for in ajax requests.
Props ocean90, foreverpinetree, pento.
See #45203.
Built from https://develop.svn.wordpress.org/branches/5.0@43893
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This update applies the following changes:
- Improve menu UI to support keyboard, click and touch interactions
- Improve variable scoping and js performance in menu interaction javascript
- Improve custom-colors for selected text, buttons and menu hover styles
- Improve margins structure for more consistency between editor and frontend
- Improve discussion avatars for simpler wording and better performance
- Improve fonts in list widgets and list blocks
- Improve comment responsive spacing and avatar display
- Improve various block styles to make them consistent between the editor and frontend
- Add tabbed browsing support for ie11
- Add backwards compatibility support for older versions of WordPress
- Add fallback styles for older versions of WP where Gutenberg is activated and then deactivated (backwards compatibility)
- Add `sizes` attribute for featured images to improve responsive performance
- Add focus-within polyfill
- Add a footer menu for secondary page links
- Fix editor styles to prevent conflicts with plugins that add meta boxes to the editor
- Fix columns block issues on small screens
- Fix empty-space font text cursor issue in Gutenberg editor
- Fix RTL floating styles so that left/right floats are honored
- Fix cover image block margins/padding
- Fix invalid rgba style
- Fix php warning when returning attributes
- Fix gallery widget margins to improve gallery grids
- Fix .entry-content selectors to prevent shortcodes, plugins and other unknown content from breaking the layout
- Remove translation escaping to follow code standards in previous default themes
- Remove custom color output in the fronten header when default color is selected
- Remove fly-out sub-sub-sub-menu behavior on desktop to prevent sub-menus from falling off the screen
- General code clean up and coding standards improvements
Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen
Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa, @tlxo, @themeroots, @whizbangik, @yingles, @youthkee, @brentswisher, @smy315, @ahmadawais, @desi-developer.
Built from https://develop.svn.wordpress.org/branches/5.0@43892
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Some plugins remove the Custom Fields meta box, particularly when they provide functionality that replaces it. The block editor would correctly not display this meta box in these circumstances, but it still showed the option to display or hide it.
Props pento, noisysocks.
See #45282.
Built from https://develop.svn.wordpress.org/branches/5.0@43885
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Changes of note:
- Includes the new Annotations API package.
- `wp-polyfill-ecmascript.js` is renamed to `wp-polyfill.js`.
- `strip_dynamic_blocks()` has been removed in favour of `excerpt_remove_blocks()`.
- The PHP block parser is now syncing from the `block-serialization-default-parser` package.
- `do_blocks()` uses the new parser.
- The `do_block` filter has been removed from `do_blocks()`, in favour of a `render_block` filter in `render_block()`.
See #45145, #45190, #45264, #45282.
Built from https://develop.svn.wordpress.org/branches/5.0@43884
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Lacking an appropriate action in the classic editor, plugins that add meta boxes have historically hooked into various actions in order to add hidden input fields.
This change also adds backwards compatibility for two of the most common: `edit_form_after_title`, and `edit_form_advanced`.
Props pento, danielbachhuber.
See #45283.
Built from https://develop.svn.wordpress.org/branches/5.0@43882
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As `do_blocks()` is run before `wpautop()` in `the_content` filter, we can remove in a Just In Time fashion, before that filter is run.
After `wpautop()`s original priority has passed, we can re-add it in a Just Too Late fashion, to ensure it's available if `the_content` filter is run multiple times on a page load.
Props pento, nerrad.
Fixes#45290.
Built from https://develop.svn.wordpress.org/branches/5.0@43879
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A handful of issues were missed in Twenty Seventeen's Gutenberg support, added in #45045. This commit includes the following fixes:
* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment.
Props pento, davidakennedy.
Fixes#45246.
Built from https://develop.svn.wordpress.org/branches/5.0@43876
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A handful of issues were missed in Twenty Sixteen's Gutenberg support, added in #45044. This commit includes the following fixes:
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Correct styles for the editor placeholder text, so it's not inheriting a darker gray from the theme's CSS.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Reset Cover blocks as `display: flex` when they are centered, to maintain their original appearance.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment.
Props pento, davidakennedy.
Fixes#45245.
Built from https://develop.svn.wordpress.org/branches/5.0@43875
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A handful of issues were missed in Twenty Fifteen's Gutenberg support, added in #45043. This commit includes the following fixes:
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Add a margin to blocks that are aligned to the left or to the right, to create space.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
* Prevent margin from theme's editor-style.css from interfering with editor alignment.
Props pento, davidakennedy.
Fixes#45244.
Built from https://develop.svn.wordpress.org/branches/5.0@43874
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A handful of issues were missed in Twenty Fourteen's Gutenberg support, added in #45042. This commit includes the following fixes:
* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Remove unnecessary spacing from the Columns block.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Simplify selectors used to set editor width to just `.wp-block`.
Props pento, davidakennedy.
Fixes#45243.
Built from https://develop.svn.wordpress.org/branches/5.0@43873
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A handful of issues were missed in Twenty Thirteen's Gutenberg support, added in #45041. This commit includes the following fixes:
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Prevent full and wide aligned blocks from getting wider than Twenty Thirteen's design.
* Prevent wide aligned blocks from getting too wide, as they can seem out of proportion with the full aligned blocks.
* Make sure full and wide blocks display at the correct width in the editor.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Make sure wide and full aligned Table blocks span the available width on the front end.
* Add spacing underneath the Media & Text block, but make sure the final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
Props pento, davidakennedy.
Fixes#45242.
Built from https://develop.svn.wordpress.org/branches/5.0@43872
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A handful of issues were missed in Twenty Twelve's Gutenberg support, added in #45040. This commit includes the following fixes:
* Update editor placeholder text to use the correct font family.
* Center text and bullets in list-based widget blocks, when block itself is centered.
* Include non "image" variations of the Cover block classes `.wp-block-cover` and `.wp-block-cover-text` in the styles.
* Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
* Simplify selectors used to set editor width to just `.wp-block`.
Props pento, davidakennedy.
Fixes#45240.
Built from https://develop.svn.wordpress.org/branches/5.0@43871
git-svn-id: http://core.svn.wordpress.org/branches/5.0@43700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
danielbachhuber
Andrew Ozz
Mel Choyce
Gary Pendergast
laurelfulford
allancole
aduth
herregroen
Dion Hulse
youknowriad
Dominik Schilling