Weston Ruter
509e706c13
Customize: Run a partial's fallback behavior (full refresh) when selective refresh fails due to a script error.
...
This ensures that 3rd-party scripts that users paste into Text widgets will gracefully recover and result in the expected preview.
See #27355 .
Fixes #40658 .
Built from https://develop.svn.wordpress.org/trunk@40771
git-svn-id: http://core.svn.wordpress.org/trunk@40629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-17 00:01:40 +00:00
Pascal Birchler
8c7ea71edb
Media: Simplify upload error message construction.
...
Built from https://develop.svn.wordpress.org/trunk@40736
git-svn-id: http://core.svn.wordpress.org/trunk@40594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 17:58:41 +00:00
Aaron Campbell
38347d7c58
Add nonce for updating file system credentials.
...
Built from https://develop.svn.wordpress.org/trunk@40723
git-svn-id: http://core.svn.wordpress.org/trunk@40581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 14:48:44 +00:00
Weston Ruter
4eb107cd52
Customize: Fix phpunit tests after [40704] due to logic inversion error.
...
Built from https://develop.svn.wordpress.org/trunk@40716
git-svn-id: http://core.svn.wordpress.org/trunk@40579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 14:34:42 +00:00
Dominik Schilling
3d10fef22d
Customize: Igore invalid customization sessions.
...
Built from https://develop.svn.wordpress.org/trunk@40704
git-svn-id: http://core.svn.wordpress.org/trunk@40567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 12:07:43 +00:00
Pascal Birchler
3d95e3ae81
Adjust post meta checks
...
Built from https://develop.svn.wordpress.org/trunk@40692
git-svn-id: http://core.svn.wordpress.org/trunk@40555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:46:42 +00:00
Pascal Birchler
76d77e927b
Improve redirect handling
...
Built from https://develop.svn.wordpress.org/trunk@40689
git-svn-id: http://core.svn.wordpress.org/trunk@40552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:38:42 +00:00
Pascal Birchler
e88a48a066
Whitelist post arguments in XML-RPC
...
Built from https://develop.svn.wordpress.org/trunk@40677
git-svn-id: http://core.svn.wordpress.org/trunk@40540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:09:42 +00:00
Weston Ruter
d8f94986b2
Customize: Keep alive auto-drafts created for page/post stubs when parent changeset is updated, and delete when changeset is garbage-collected.
...
Props utkarshpatel, westonruter.
See #31089 .
Fixes #39715 .
Built from https://develop.svn.wordpress.org/trunk@40676
git-svn-id: http://core.svn.wordpress.org/trunk@40539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 05:37:44 +00:00
Weston Ruter
7f008a21de
Widgets: Add missing `wp-editor-area` CSS class for `textarea` in the TinyMCE-extended Text widget to ensure proper styles are applied.
...
Removes extra border around TinyMCE-wrapped `textarea` and removes gap at bottom due to lack of `display:block`.
Props johnjamesjacoby, westonruter.
See #35243 .
Fixes #40755 .
Built from https://develop.svn.wordpress.org/trunk@40675
git-svn-id: http://core.svn.wordpress.org/trunk@40538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 00:11:41 +00:00
Weston Ruter
5e67d6d81f
Widgets: Remove image sizes generated during media widget phpunit tests from being version controlled.
...
Amends [40640].
See #32417 .
Built from https://develop.svn.wordpress.org/trunk@40674
git-svn-id: http://core.svn.wordpress.org/trunk@40537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 22:59:42 +00:00
Weston Ruter
97e376ca39
Widgets: Ensure return value of `widget_text` filter is not dropped but passed into `widget_text_content` filter for rendering.
...
Amends [40631].
Props vijustin, swissspidy, westonruter.
See #35243 .
Fixes #40772 .
Built from https://develop.svn.wordpress.org/trunk@40673
git-svn-id: http://core.svn.wordpress.org/trunk@40536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 22:36:41 +00:00
Mel Choyce
66d3a486f6
Plugins: Fix plugin name display on Chrome 58 and above.
...
On Chrome 58 and above, plugin names within the plugin details modal were collapsed down into an ellipsis. This fix rewrites the CSS to make sure the titles are always shown.
Props mrwweb, afercia, Presskopp.
Fixes #40579 .
Built from https://develop.svn.wordpress.org/trunk@40672
git-svn-id: http://core.svn.wordpress.org/trunk@40535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 20:13:42 +00:00
Weston Ruter
9cb2cbc26f
Customize: Fix alignment of natural-width media buttons in site icon control.
...
Amends [40653].
Props afercia.
Fixes #40220 .
Built from https://develop.svn.wordpress.org/trunk@40671
git-svn-id: http://core.svn.wordpress.org/trunk@40534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 18:51:41 +00:00
Weston Ruter
8a29b28a98
Widgets: Prevent image `title` attribute from being populated from attachment `title` by default upon selection.
...
Props westonruter, timmydcrawford.
See #39993 .
Built from https://develop.svn.wordpress.org/trunk@40670
git-svn-id: http://core.svn.wordpress.org/trunk@40533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 18:42:44 +00:00
Konstantin Obenland
68588821c3
Dashboard: Community events formatting improvements
...
Props Soean.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40669
git-svn-id: http://core.svn.wordpress.org/trunk@40532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 09:44:43 +00:00
Rachel Baker
580cf33c81
Taxonomy: Remove extraneous `'` included in Term delete markup.
...
Unmatched single quotation mark after the delete link href was introduced in r40655.
Props Chouby.
Fixes #9777 .
Built from https://develop.svn.wordpress.org/trunk@40668
git-svn-id: http://core.svn.wordpress.org/trunk@40531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 19:50:44 +00:00
Rachel Baker
195b227357
Formatting: Increase minimum characters allowed in `is_email()` to 6.
...
Brings the minimum characters expected for a valid email address to six, which matches the expectations in `wp_handle_comment_submission()` and REST API email arguments.
Props rmccue, lukecavanagh, rachelbaker, desrosj, sudar.
Fixes #38708 .
Built from https://develop.svn.wordpress.org/trunk@40667
git-svn-id: http://core.svn.wordpress.org/trunk@40530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 04:20:43 +00:00
Rachel Baker
9c2f5c18ce
Comments: Correct the $post_id parameter passed to the 'comments_open' and 'pings_open' filters.
...
Fixes bug where previously the `$post_id` function argument was passed to the '_open' filters, instead of the result of the `get_post()` call. If the current post is not found, the `$post_id` filter parameter will be 0.
Props johnbillion, shulard, rachelbaker.
Fixes #40286 .
Built from https://develop.svn.wordpress.org/trunk@40666
git-svn-id: http://core.svn.wordpress.org/trunk@40529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 03:50:42 +00:00
Peter Wilson
62de6cc7ec
Menus: Prevent empty class attribute following [40537].
...
Prevents an empty class attribute, `class=""`, from appearing in the HTML if a developer removes all classes using the `nav_menu_submenu_css_class` filter.
Props Kopepasah.
Fixes #36163 .
Built from https://develop.svn.wordpress.org/trunk@40665
git-svn-id: http://core.svn.wordpress.org/trunk@40528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 03:38:48 +00:00
Rachel Baker
868312d995
Comments: Update arguments passed to the 'comment_text' filter in `check_comment()`.
...
Pass null or empty values for the missing $comment and $args parameters of the 'check_comment' filter in `check_comment()`.
Props boonebgorges, vaishu.agola27, SergeyBiryukov.
Fixes #38314 .
Built from https://develop.svn.wordpress.org/trunk@40664
git-svn-id: http://core.svn.wordpress.org/trunk@40527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 03:06:45 +00:00
Andrew Ozz
48339ed3d2
Bump version after beta-1
...
Built from https://develop.svn.wordpress.org/trunk@40663
git-svn-id: http://core.svn.wordpress.org/trunk@40526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-13 00:21:41 +00:00
Andrew Ozz
28f2840bcb
Bump version, beta-1
...
Built from https://develop.svn.wordpress.org/trunk@40662
git-svn-id: http://core.svn.wordpress.org/trunk@40525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 23:17:45 +00:00
Andrew Ozz
964c0710f0
Revert [40256] for now as some tests are failing in some environments.
...
See #20383 .
Built from https://develop.svn.wordpress.org/trunk@40661
git-svn-id: http://core.svn.wordpress.org/trunk@40524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 22:50:41 +00:00
Weston Ruter
3ce794812d
Widgets: Fix deferred rendering of controls for media widgets until container element fully expands.
...
Adds omitted call to `renderWhenAnimationDone()` which was missed when this code was copied from the Text widget.
Amends [40656].
See #40750 .
Built from https://develop.svn.wordpress.org/trunk@40660
git-svn-id: http://core.svn.wordpress.org/trunk@40523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 22:01:42 +00:00
Adam Silverstein
498613ccd7
Media: Fix improper use of jQuery `hasClass` method.
...
The jQuery `hasClass` method accepts a class name without a prefix '.' (period). Remove an errant class name with a '.' in `wp-mediaelement.js` that broke the selector in certain circumstances.
Props kostasx, Presskopp.
Fixes #40354 .
Built from https://develop.svn.wordpress.org/trunk@40659
git-svn-id: http://core.svn.wordpress.org/trunk@40522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 20:53:45 +00:00
Adam Silverstein
8b60430aee
Customizer: Fix an issue with menu classes in the customizer preview.
...
In customizer preview, strip changeset uuid in menu urls before comparing with current url to determine menu item classes.
In the customizer, menu items now contain a changeset uuid as part of their urls. Strip the changeset uuid off the url before comparing with current url (which lacks the changeset uuid).
Props priyankabehera155, jipmoors.
Fixes #39758 .
Built from https://develop.svn.wordpress.org/trunk@40658
git-svn-id: http://core.svn.wordpress.org/trunk@40521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 20:35:43 +00:00
Adam Silverstein
cb2eac9e06
Users: Update name in toolbar when changing user display name.
...
When changing the user name in Users -> Your Profile, update the name displayed in the toolbar dynamically using JavaScript.
Props menakas, lukecavanagh, maguiar.
Fixes #40342 .
Built from https://develop.svn.wordpress.org/trunk@40657
git-svn-id: http://core.svn.wordpress.org/trunk@40520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 20:06:42 +00:00
Weston Ruter
020ffded1a
Widgets: Defer rendering controls for media widgets until container element fully expands.
...
Fixes issue with MediaElement.js failing to build the player in an animating container that doesn't have established dimensions.
Also utilizes MediaElement.js for the video widget instead of using a native player.
See #32417 .
Fixes #40750 .
Built from https://develop.svn.wordpress.org/trunk@40656
git-svn-id: http://core.svn.wordpress.org/trunk@40519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 19:56:43 +00:00
Adam Silverstein
d1ec180619
Taxonomy: Add a "delete" button on term edit page.
...
Add a 'delete' link next to the update button on the term edit screen so you can delete a term while you are reviewing it's details.
Props cklosows, bradt, ocean90, johnbillion, DrewAPicture, ryan, MatheusGimenez, maguiar.
Fixes #9777 .
Built from https://develop.svn.wordpress.org/trunk@40655
git-svn-id: http://core.svn.wordpress.org/trunk@40518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 19:26:41 +00:00
Andrew Ozz
6f4a1049a8
TinyMCE: do not override `line-height` for paragraphs and headings in 4.6+, makes them hard to read.
...
Fixes #40743 .
Built from https://develop.svn.wordpress.org/trunk@40654
git-svn-id: http://core.svn.wordpress.org/trunk@40517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 18:06:40 +00:00
Andrea Fercia
705ecf3312
Customize: Make the media control buttons natural-width.
...
Natural-width buttons are better for translations, and don't feel as
overpowering as the half-width (and full-width) buttons.
Props melchoyce, timmydcrawford, afercia.
Fixes #40220 .
Built from https://develop.svn.wordpress.org/trunk@40653
git-svn-id: http://core.svn.wordpress.org/trunk@40516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 17:50:44 +00:00
Andrea Fercia
430422b0b7
Login and Registration: Add a filter to disable the initial auto-focus on the login screen.
...
Fixes #40301 .
Built from https://develop.svn.wordpress.org/trunk@40652
git-svn-id: http://core.svn.wordpress.org/trunk@40515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 17:12:46 +00:00
Konstantin Obenland
7328d561b1
Dashboard: Persist location for community events
...
Fixes a bug where cached events & location data was not accessible because the
cache key could not be regenerated without latitude and longitude information.
Discovered and fixed during #wcber contributor day.
Props soean, kubik-rubik, obenland.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40651
git-svn-id: http://core.svn.wordpress.org/trunk@40514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 15:53:46 +00:00
Joe McGill
2b206fa18d
Improve wording of the AYS warning when permanently deleting uploads, tags, posts.
...
This is a follow up on [40283], which cleans up the wording.
Props azaozz, swissspidy, ocean90.
Fixes #39712 .
Built from https://develop.svn.wordpress.org/trunk@40650
git-svn-id: http://core.svn.wordpress.org/trunk@40513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 12:50:42 +00:00
Dominik Schilling
b43250116f
Import: Replace `assert()` calls with PHPUnit's `assertTrue()` method.
...
Calling `assert()` with a string argument will be deprecated in PHP 7.2.
See #40109 .
Built from https://develop.svn.wordpress.org/trunk@40649
git-svn-id: http://core.svn.wordpress.org/trunk@40512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 07:38:41 +00:00
Andrea Fercia
8a07db035d
Add missing semicolons after [40646].
...
See #40453 .
Built from https://develop.svn.wordpress.org/trunk@40648
git-svn-id: http://core.svn.wordpress.org/trunk@40511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 07:05:41 +00:00
Andrea Fercia
55b6ee7e56
Media: Clean-up some MediaElementJS CSS: no more needed after [40642].
...
See #40707 , #32417 , #39994 , #39995 , #30281 .
Built from https://develop.svn.wordpress.org/trunk@40647
git-svn-id: http://core.svn.wordpress.org/trunk@40510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 07:00:45 +00:00
Dion Hulse
6a525dd831
Bump Akismet external to 3.3.2
...
See #40002
git-svn-id: http://core.svn.wordpress.org/trunk@40509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 04:09:13 +00:00
Andrea Fercia
bab7eb143e
Accessibility: Change the "Show details" links in the update core screen to buttons.
...
These controls toggle the visibility of the update progress: they perform an action
therefore they should be buttons. Also:
- uses `aria-expanded` to communicate the toggle button state
- removes some inline JavaScript
- when clicking the toggle buttons, the progress details get moved with JavaScript after the button: this helps users of assistive technologies in finding them and makes the UI a bit more intuitive
Props Cheffheid, afercia.
See #26504 .
Fixes #40453 .
Built from https://develop.svn.wordpress.org/trunk@40646
git-svn-id: http://core.svn.wordpress.org/trunk@40507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 23:50:41 +00:00
Andrew Ozz
8c46657c9d
TinyMCE: update to 4.6.1. Changelog: https://www.tinymce.com/docs/changelog/#version461-may102017
...
Fixes #40727 .
Built from https://develop.svn.wordpress.org/trunk@40645
git-svn-id: http://core.svn.wordpress.org/trunk@40506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 23:12:40 +00:00
Andrew Ozz
da92cce494
TinyMCE: prevent removing of the temp link element when opening the advanced link dialog to insert new link.
...
Part props figureone for finding the cause.
Fixes #40558 .
Built from https://develop.svn.wordpress.org/trunk@40644
git-svn-id: http://core.svn.wordpress.org/trunk@40505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 23:04:40 +00:00
Andrea Fercia
274596b8ef
Accessibility: Add "(opens in a new window)" screen reader text to the "News-Nearby Events" dashboard widget footer links.
...
- standardizes similar messages in core to always use `(opens in a new window)`
- adds translators comments
- hides the dashicons with `aria-hidden="true"`, see #40428
Fixes #40733 .
Built from https://develop.svn.wordpress.org/trunk@40643
git-svn-id: http://core.svn.wordpress.org/trunk@40504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 22:47:41 +00:00
Andrea Fercia
691d649329
Media: Remove the custom styling for the MediaElementJS controls offscreen text.
...
This offscreen text is not meant to be revealed on focus and just acts as fallback
for assistive technologies that don't support `aria-label` and `role="slider"`.
Also, revealing it on focus has proven over time to be very fragile and to cause
unexpected layout issues.
See #30281 .
Fixes #40707 .
Built from https://develop.svn.wordpress.org/trunk@40642
git-svn-id: http://core.svn.wordpress.org/trunk@40503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 22:29:42 +00:00
Weston Ruter
26a5058f43
Widgets: Utilize WP REST API oEmbed proxy endpoint in media widgets.
...
Props timmydcrawford.
See #32417 , #40450 .
Built from https://develop.svn.wordpress.org/trunk@40641
git-svn-id: http://core.svn.wordpress.org/trunk@40502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 21:24:42 +00:00
Weston Ruter
31d4d81039
Widgets: Introduce media widgets for images, audio, and video with extensible base for additional media widgets in the future.
...
The last time a new widget was introduced, Vuvuzelas were a thing, Angry Birds started taking over phones, and WordPress stopped shipping with Kubrick. Seven years and 17 releases without new widgets have been enough, time to spice up your sidebar!
Props westonruter, melchoyce, obenland, timmydcrawford, adamsilverstein, gonom9, wonderboymusic, Fab1en, DrewAPicture, sirbrillig, joen, matias, samikeijonen, afercia, celloexpressions, designsimply, michelleweber, ranh, kjellr, karmatosed.
Fixes #32417 , #39993 , #39994 , #39995 .
Built from https://develop.svn.wordpress.org/trunk@40640
git-svn-id: http://core.svn.wordpress.org/trunk@40501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 21:11:44 +00:00
Pascal Birchler
763f09fb7e
Upgrade/Install: After [40638], make sure `wp_is_file_mod_allowed()` actually returns the right value.
...
See #38673 .
Built from https://develop.svn.wordpress.org/trunk@40639
git-svn-id: http://core.svn.wordpress.org/trunk@40500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:54:43 +00:00
Pascal Birchler
33047ba14e
Upgrade/Install: After [40394], rename `wp_disallow_file_mods()` to `wp_is_file_mod_allowed()`.
...
This makes it more clear what this function is about.
Props Mte90.
Fixes #38673 .
Built from https://develop.svn.wordpress.org/trunk@40638
git-svn-id: http://core.svn.wordpress.org/trunk@40499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:24:41 +00:00
Dominik Schilling
77858f4b92
KSES: Support `'tag' => true` as a shorthand for `'tag' => array()` in `wp_kses_attr()`.
...
`Automatic_Upgrader_Skin::feedback()` had always assumed that this is already the case, now it is.
See #20017 .
Fixes #40680 .
Built from https://develop.svn.wordpress.org/trunk@40637
git-svn-id: http://core.svn.wordpress.org/trunk@40498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:23:43 +00:00
Pascal Birchler
9af735e863
Themes: Avoid PHP warnings in the admin when no theme directory exists.
...
Props iseulde, chris_dev, swissspidy.
Fixes #35521 .
Built from https://develop.svn.wordpress.org/trunk@40636
git-svn-id: http://core.svn.wordpress.org/trunk@40497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:21:44 +00:00