Commit Graph

34 Commits

Author SHA1 Message Date
hellofromTonya fcf096f4b9 Bundled Themes: Remove the "role" attribute on HTML elements with a default landmark role.
With IE11 no longer supported, the primary problem with assistive technology support for native HTML5 elements no longer applies.

This commit removes the `role` attribute from the following HTML5 elements with default landmark roles, per formerly required role attributes and W3C.

Follow-up to [17669], [21261], [23452], [24832], [29892], [38833], [40851], [43842], [46271], [49216].

Props costdev, craigfrancis, joedolson, mukesh27, ryokuhi, sabernhardt.
Fixes #54079.
Built from https://develop.svn.wordpress.org/trunk@52013


git-svn-id: http://core.svn.wordpress.org/trunk@51604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-04 18:18:01 +00:00
joedolson a3a61c5a3e General: Remove role="navigation" from nav elements.
Role="navigation" was required for assistive technology to recognize HTML5 element's native ARIA roles while HTML5 and ARIA were being introduced. With the deprecation of IE11, the role attribute is only required when mapping elements that don't have native role.

Props costdev, mukesh27.
Fixes #54054.
Built from https://develop.svn.wordpress.org/trunk@51967


git-svn-id: http://core.svn.wordpress.org/trunk@51556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-01 21:47:13 +00:00
Sergey Biryukov 0be77d4ebf Bundled Themes: Add `/` character to `<img>` tags.
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51473].

Props shital-patel, akabarikalpesh.
See #53870.
Built from https://develop.svn.wordpress.org/trunk@51541


git-svn-id: http://core.svn.wordpress.org/trunk@51152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-04 14:24:02 +00:00
Sergey Biryukov 953868b3a3 Bundled Themes: Use HTTPS for XHTML Friends Network URL.
Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
See #48002.
Built from https://develop.svn.wordpress.org/trunk@48290


git-svn-id: http://core.svn.wordpress.org/trunk@48059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 23:42:01 +00:00
Sergey Biryukov 83187125e4 Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting.
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981.
Built from https://develop.svn.wordpress.org/trunk@45768


git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Adam Silverstein 418afaa938 Bundled Theme: trigger a new `wp_body_open` action immediately after the opening `body` tag.
* Enables inserting (asynchronous) JavaScript right after the opening `body` tag.
* Add a `wp_body_open` helper function that triggers the `wp_body_open` action.
* Call `wp_body_open` in core themes immediately after the opening `body` tag.

Props joostdevalk, valendesigns, nacin, saracup, jorbin, mikeschinkel, jonnybojangles, lgedeon, Willscrlt, Denis-de-Bernardy, lexiqueen, sky_76, welcher, westonruter, ramiy, joyously.
Fixes #12563.

Built from https://develop.svn.wordpress.org/trunk@45042


git-svn-id: http://core.svn.wordpress.org/trunk@44851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 21:59:52 +00:00
Gary Pendergast be127956e0 Bundled Themes: Run the `pingback_url` through `esc_url()`.
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.

Props soulseekah, sharaz.
Fixes #43717.


Built from https://develop.svn.wordpress.org/trunk@44500


git-svn-id: http://core.svn.wordpress.org/trunk@44331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:11:51 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Tammie Lister 9ef40ced2f Twenty Fourteen: Removes video header support
Support was added to test implementation but never completed. This removes the test implementation.

Props davidakennedy
Fixes #38783

Built from https://develop.svn.wordpress.org/trunk@39226


git-svn-id: http://core.svn.wordpress.org/trunk@39166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-14 17:17:31 +00:00
Joe McGill 030bc377dd Themes: Enable video in custom headers.
This adds the ability for themes to add support for videos in custom headers
by passing `'video' => true` as an argument when adding theme support for
custom headers.

Custom video headers are managed through the “Header Visuals” (i.e. “Header Image”)
panel in the Customizer where you can select a video from the media library or set a
URL to an external video (YouTube for now) for use in custom headers.

This introduces several new functions:

`has_header_video()` – Check whether a header video is set or not.
`get_header_video_url()` – Retrieve header video URL for custom header.
`the_header_video_url()` – Display header video URL.
`get_header_video_settings()` – Retrieve header video settings.
`has_custom_header()` – Check whether a custom header is set or not.
`get_custom_header_markup()` – Retrieve the markup for a custom header.
`the_custom_header_markup()` – Print the markup for a custom header.

And a new file, `wp-includes/js/wp-custom-header.js` that handles loading videos
in custom headers.

This also enables video headers in the Twenty Seventeen and Twenty Fourteen themes.

Props davidakennedy, celloexpressions, bradyvercher, laurelfulford, joemcgill.
Fixes #38172.
Built from https://develop.svn.wordpress.org/trunk@38985


git-svn-id: http://core.svn.wordpress.org/trunk@38928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-27 21:51:31 +00:00
Lance Willett 913c4cd69c Twenty Fourteen: add ARIA attributes to search toggle. See #31527.
Built from https://develop.svn.wordpress.org/trunk@31794


git-svn-id: http://core.svn.wordpress.org/trunk@31776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 18:51:29 +00:00
Lance Willett f81f253434 Twenty Fourteen: add ARIA attributes to menu toggle. See #31527.
Built from https://develop.svn.wordpress.org/trunk@31784


git-svn-id: http://core.svn.wordpress.org/trunk@31764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-15 20:00:27 +00:00
Sergey Biryukov 75484f9c20 Bundled themes: Add an alt attribute with the site title for header images linked to the home page.
props rianrietveld.
fixes #15926.
Built from https://develop.svn.wordpress.org/trunk@29842


git-svn-id: http://core.svn.wordpress.org/trunk@29606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-06 12:44:17 +00:00
Lance Willett 42d2f4fc21 Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151.
Built from https://develop.svn.wordpress.org/trunk@28341


git-svn-id: http://core.svn.wordpress.org/trunk@28169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 04:27:15 +00:00
Lance Willett ab92971817 Twenty Fourteen: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable `button` element rather than `h1` for the toggle element. Fixes #27147, props jartes and joedolson.
Built from https://develop.svn.wordpress.org/trunk@27594


git-svn-id: http://core.svn.wordpress.org/trunk@27437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:37:15 +00:00
Lance Willett 3dc744d0cb Twenty Fourteen: minor spacing and CSS formatting fixes. See #25946.
Built from https://develop.svn.wordpress.org/trunk@26810


git-svn-id: http://core.svn.wordpress.org/trunk@26697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 23:11:10 +00:00
Andrew Nacin 2f2b86270e Twenty Fourteen: Remove unused and untoggled no-js class.
props johnbillion.
fixes #26453.

Built from https://develop.svn.wordpress.org/trunk@26729


git-svn-id: http://core.svn.wordpress.org/trunk@26618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 17:16:11 +00:00
Lance Willett dd6d39ba9d Twenty Fourteen: remove trailing slashes on void elements such as meta and link, and remove type attribute from script element. See #24499.
Built from https://develop.svn.wordpress.org/trunk@26672


git-svn-id: http://core.svn.wordpress.org/trunk@26562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 17:54:09 +00:00
Lance Willett 3c0f497fad Twenty Fourteen: general cleanup for spacing, inline comments. Props obenland, see #25946.
Built from https://develop.svn.wordpress.org/trunk@26227


git-svn-id: http://core.svn.wordpress.org/trunk@26134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 21:20:09 +00:00
Lance Willett 323b7c4627 Twenty Fourteen: first pass at older Internet Explorer browser support. Props iamtakashi, see #25036.
Built from https://develop.svn.wordpress.org/trunk@26097


git-svn-id: http://core.svn.wordpress.org/trunk@26012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 04:18:11 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Lance Willett d8ba6cde31 Twenty Fourteen: further revise primary navigation functionality, simplify mobile navigation, and clean up the main JS file. Props obenland, iamtakashi. See #25554.
Built from https://develop.svn.wordpress.org/trunk@25864


git-svn-id: http://core.svn.wordpress.org/trunk@25864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:48 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Lance Willett a9cab6f3fb Twenty Fourteen: further revise primary navigation functionality, simplify mobile navigation, and clean up the main JS file. Props obenland, iamtakashi. See #25554.
Built from https://develop.svn.wordpress.org/trunk@25864


git-svn-id: http://core.svn.wordpress.org/trunk@25776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 16:37:12 +00:00
Lance Willett eaf78d3f7c Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257.
Built from https://develop.svn.wordpress.org/trunk@25769


git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 22:02:11 +00:00
Lance Willett 66be5edfb5 Twenty Fourteen: remove title attributes for better accessibility. Props sabreuse for original patch, see #25054.
Built from https://develop.svn.wordpress.org/trunk@25743


git-svn-id: http://core.svn.wordpress.org/trunk@25656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:09 +00:00
Lance Willett ffd47afa4b Twenty Fourteen: a11y fix for keyboard navigation and Skip Content link, see #25054.
Built from https://develop.svn.wordpress.org/trunk@25742


git-svn-id: http://core.svn.wordpress.org/trunk@25655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 18:52:10 +00:00
Lance Willett 13c80a9951 Twenty Fourteen: accessibility fix for allowing the search button in the toolbar to be focused with the keyboard. Props joedolson and sabreuse, see #25054.
Built from https://develop.svn.wordpress.org/trunk@25613


git-svn-id: http://core.svn.wordpress.org/trunk@25530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 23:04:10 +00:00
Lance Willett 288482e862 Twenty Fourteen: simplify header image check, props obenland. See #25400.
Built from https://develop.svn.wordpress.org/trunk@25604


git-svn-id: http://core.svn.wordpress.org/trunk@25521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 17:07:10 +00:00
Lance Willett be1ff0f752 Twenty Fourteen: more Genericons fixes, merging exact files with latest Genericons 3.0 files for consistency and future ease of merging. Props obenland and georgestephanis, fixes #25085.
Built from https://develop.svn.wordpress.org/trunk@25506


git-svn-id: http://core.svn.wordpress.org/trunk@25427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 18:05:12 +00:00
Lance Willett cb7b1af550 Twenty Fourteen: remove Social Links integration. Props obenland, see #25094.
Built from https://develop.svn.wordpress.org/trunk@25214


git-svn-id: http://core.svn.wordpress.org/trunk@25185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 21:25:10 +00:00
Lance Willett e5c55b09e9 Twenty Fourteen: first pass at matching code standards achieved with Twenty Thirteen development. See #24858, props obenland.
Built from https://develop.svn.wordpress.org/trunk@25021


git-svn-id: http://core.svn.wordpress.org/trunk@25012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:29 +00:00
Lance Willett 7d35419e62 Importing the Further theme, first pass at the new default theme for 2014.
A magazine theme with clean, responsive design focused on highlighting featured content prominently on home page.

This is slated for 3.8. Development will occur in trunk for the theme, and in plugins for the nice-to-have features.

Nice-to-have improvements include:

- Add a Contributors page template to highlight authors.
- Easy-to-manage featured content.
- Add support for an Authors widget to highlight authors.

Welcome, Twenty Fourteen né Further. Props iamtakashi, see #24858.


git-svn-id: http://core.svn.wordpress.org/trunk@24832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:55:10 +00:00