Commit Graph

204 Commits

Author SHA1 Message Date
John Blackbourn b13e73d05c Docs: Document more parameters and properties using typed array notation.
See #41756

Built from https://develop.svn.wordpress.org/trunk@42875


git-svn-id: http://core.svn.wordpress.org/trunk@42705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-25 18:10:32 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Gary Pendergast c90cfa3b50 General: Fix some precision alignment formatting warnings.
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42228


git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 23:57:55 +00:00
Sergey Biryukov 6b3b489a5d Permalinks: Change mention of URI to URL in the description of `%category%` tag.
Props danieltj, tobifjellner.
Fixes #42147.
Built from https://develop.svn.wordpress.org/trunk@42023


git-svn-id: http://core.svn.wordpress.org/trunk@41857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-25 11:11:45 +00:00
Sergey Biryukov ffddfb573b I18N: Remove `<code>` and `<kbd>` tags from translatable strings on Settings screens.
Move URLs to separate strings.

Props ramiy.
Fixes #40763.
Built from https://develop.svn.wordpress.org/trunk@41986


git-svn-id: http://core.svn.wordpress.org/trunk@41820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-24 10:51:52 +00:00
Pascal Birchler fce70235f2 Permalinks: Change structure tag button state more reliably.
Changes the highlighted tag buttons accordingly when selecting one of the commong permalink settings.

Deprecates `options_permalink_add_js()` as that JavaScript isn't added inline anymore.

Fixes #29872.

Built from https://develop.svn.wordpress.org/trunk@41598


git-svn-id: http://core.svn.wordpress.org/trunk@41433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-26 08:24:46 +00:00
Pascal Birchler fd07b2254d Permalinks: Add buttons for the available structure tags to the admin UI.
Often times, it can be confusing to set a custom permalink structure. One has to double-check the documentation, make 
sure to correctly insert the structure tag, and hope not to break their site.

With this addition, the available structure tags are being displayed as a list of easily clickable buttons that can be 
used to insert tags to the custom structure input field and to remove them again.

Props kpdesign, swissspidy, joedolson, afercia.
Fixes #29872.

Built from https://develop.svn.wordpress.org/trunk@41182


git-svn-id: http://core.svn.wordpress.org/trunk@41022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-28 17:43:45 +00:00
Andrea Fercia f5b1f4ceba Accessibility: Remove target=_blank from the Settings screens help tabs links.
Stop taking control of users' browsers.

Props rianrietveld.
Fixes #38143. See #23432.

Built from https://develop.svn.wordpress.org/trunk@38720


git-svn-id: http://core.svn.wordpress.org/trunk@38663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-04 06:59:29 +00:00
Sergey Biryukov 5cce706f3d Permalinks: Rename `$usingpi` to `$using_index_permalinks` for clarity.
See #37380.
Built from https://develop.svn.wordpress.org/trunk@38067


git-svn-id: http://core.svn.wordpress.org/trunk@38008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 12:46:29 +00:00
Sergey Biryukov 07c9671cac Permalinks: After [37747], make sure `$usingpi`, `$writable`, and `$update_required` are defined before checking them on permalinks update.
Props Clorith.
Fixes #37380.
Built from https://develop.svn.wordpress.org/trunk@38066


git-svn-id: http://core.svn.wordpress.org/trunk@38007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 12:44:32 +00:00
Dominik Schilling 25e66e4f1e Text Changes: Unify permission error messages.
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.
Built from https://develop.svn.wordpress.org/trunk@37914


git-svn-id: http://core.svn.wordpress.org/trunk@37855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-29 15:16:29 +00:00
Pascal Birchler a97f0a2c19 Permalinks: Validate custom permalink structures.
Custom permalink structures require at least one valid structure tag, e.g. `%postname%`. If none is included, it would leave users with broken permalinks.
Let's make sure this won't happen by validating the permalink structure.

Adds unit tests.

Props rockwell15 for initial patch.
Fixes #35936.
Built from https://develop.svn.wordpress.org/trunk@37747


git-svn-id: http://core.svn.wordpress.org/trunk@37712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-19 12:02:29 +00:00
Andrea Fercia 78e6aa46c1 Accessibility: Don't mark up "URL" as an abbreviation.
"URL" has essentially entered language as a self-contained concept, there's
no more need to expand it with an `<abbr>` element and a title attribute.

Fixes #35174.
Built from https://develop.svn.wordpress.org/trunk@36142


git-svn-id: http://core.svn.wordpress.org/trunk@36108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 12:10:26 +00:00
Drew Jaynes eba05b2c98 Permalinks: Use "Plain" instead of "None" for the `?p-###`, which is still a valid permalink structure, just not a "pretty" one.
Permalinks are enabled by default (where supported) since in 4.2. When that change was made, it rended the "Default" label (previous to [35599]) inaccurate.

Props Ankit-K-Gupta.
Fixes #34509.

Built from https://develop.svn.wordpress.org/trunk@35604


git-svn-id: http://core.svn.wordpress.org/trunk@35568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 22:19:27 +00:00
Drew Jaynes c5a8c3aa86 Permalinks: Rename the "Default" permalink structure to "None" as permalinks have been enabled by default (where supported) since 4.2.
Updates help tabs and contextual text to match.

Props johnbillion, DrewAPicture.
Fixes #34509.

Built from https://develop.svn.wordpress.org/trunk@35599


git-svn-id: http://core.svn.wordpress.org/trunk@35563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 06:58:25 +00:00
Jeremy Felt f69396c229 MS: Provide better UI when a main site's `/blog` prefix is changed.
The main site on a new network is forced by default into using `/blog` as the prefix for its permalink structure. This can be changed easily through the network admin, though the `options-permalink.php` screen is then unusable to make further changes to the structure.

Now, if `/blog/` is not at the beginning of the `permalink_structure` option, we do not force `/blog` as a prefix in the UI.

Fixes #12002.

Built from https://develop.svn.wordpress.org/trunk@34749


git-svn-id: http://core.svn.wordpress.org/trunk@34714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 20:39:24 +00:00
John Blackbourn 4d377dd4a1 On the Permalink Settings screen, add a link to the Nginx documentation when the current site is running Nginx. This is in lieu of showing actual Nginx configuration like we do for mod_rewrite or IIS.
Fixes #18852

Built from https://develop.svn.wordpress.org/trunk@34691


git-svn-id: http://core.svn.wordpress.org/trunk@34655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 11:15:26 +00:00
Scott Taylor 1d68ccec25 Move ad hoc Options functions to `wp-admin/includes/options.php`:
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.

Built from https://develop.svn.wordpress.org/trunk@34022


git-svn-id: http://core.svn.wordpress.org/trunk@33991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 21:45:24 +00:00
Sergey Biryukov 48c82ef14d Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
props Cheffheid.
fixes #33611.
Built from https://develop.svn.wordpress.org/trunk@33818


git-svn-id: http://core.svn.wordpress.org/trunk@33786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:29:21 +00:00
Konstantin Obenland 7dc1d06e64 Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Scott Taylor af0e5cc851 Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments.
Props tw2113 for the initial patch.
See #18788.

Built from https://develop.svn.wordpress.org/trunk@31034


git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
Sergey Biryukov 62d51238ee Use home URL instead of example.org on Permalink Settings screen.
props voldemortensen, jesin.
fixes #29509.
Built from https://develop.svn.wordpress.org/trunk@29716


git-svn-id: http://core.svn.wordpress.org/trunk@29490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-07 09:44:15 +00:00
Andrew Nacin 5803e838e4 Permalink Settings: Don't show "update your .htaccess now" if nothing needs to change.
props ldebrouwer, MikeHansenMe.
fixes #19268.

Built from https://develop.svn.wordpress.org/trunk@27549


git-svn-id: http://core.svn.wordpress.org/trunk@27392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 04:35:16 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Andrew Ozz 8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin d3b89d43fc Add nginx detection to the Permalink Settings screen.
Introduces got_url_rewrite() and a corresponding filter, which should now be used in lieu of the got_rewrite filter in got_mod_rewrite().

This does not write or even suggest nginx configuration; rather, it prevents nginx from being considered as either Apache or as an unrecognized server.

props johnbillion.
fixes #25098.

Built from https://develop.svn.wordpress.org/trunk@25456


git-svn-id: http://core.svn.wordpress.org/trunk@25377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 20:07:09 +00:00
Sergey Biryukov 5a8dc364d1 Fix a grammar error on Permalink Settings screen. props celloexpressions. fixes #25210.
Built from https://develop.svn.wordpress.org/trunk@25206


git-svn-id: http://core.svn.wordpress.org/trunk@25178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 10:04:10 +00:00
Dominik Schilling 6ad78a3d4d Some more RTL improvements for permalink settings. props SergeyBiryukov. fixes #16834.
git-svn-id: http://core.svn.wordpress.org/trunk@24315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 17:58:10 +00:00
Dominik Schilling 580e1729c1 Improve the permalink settings UI for RTL.
props yoavf, SergeyBiryukov, DrewAPicture. fixes #16834.

git-svn-id: http://core.svn.wordpress.org/trunk@24283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-17 17:55:39 +00:00
Andrew Nacin cd2b1cffbf Redirect after save on options-permalink.php to ensure permalinks are fully flushed. fixes #9296. see #14345 for more.
git-svn-id: http://core.svn.wordpress.org/trunk@24060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:57:34 +00:00
Mark Jaquith 755bece0bb Consistently apply class="title" to our options page h3 tags.
props norcross. fixes #24080.

git-svn-id: http://core.svn.wordpress.org/trunk@24002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 20:19:29 +00:00
Mark Jaquith a24c40fb00 Consistently use $wp_rewrite->index instead of hardcoding "index.php".
props wonderboymusic. fixes #7337

git-svn-id: http://core.svn.wordpress.org/trunk@23305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-18 13:44:22 +00:00
Ryan Boren 4c22897819 Update permalink structure input when selecting a structure with the radio buttons.
Props nacin
fixes #22645


git-svn-id: http://core.svn.wordpress.org/trunk@22931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 00:01:26 +00:00
Andrew Nacin b8f1b7902f Remove unnecessary .tog class from checkboxes on the Permalink Settings screen. Designed originally for the admin color scheme choice (see [7259]), it causes vertical misalignment and lack of spacing between the checkbox and corresponding label. see #16379.
git-svn-id: http://core.svn.wordpress.org/trunk@22122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 14:36:46 +00:00
Andrew Nacin 40bd91c86f @since for some internal functions. props SergeyBiryukov, fixes #21886.
git-svn-id: http://core.svn.wordpress.org/trunk@21994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 02:24:58 +00:00
Andrew Nacin 2a5f553345 Include the home URL before the custom permalink structure input, so it is clear we only care about the path. props solarissmoke, fixes #8952.
git-svn-id: http://core.svn.wordpress.org/trunk@21891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 17:58:54 +00:00
Andrew Nacin b523c3d597 Rename duplicately defined internal functions (add_js, display_header) for documentation purposes. props bpetty, fixes #21564.
git-svn-id: http://core.svn.wordpress.org/trunk@21856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-15 19:49:21 +00:00
duck_ a395e06896 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 20:29:33 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
nacin e8b954fe7d Eliminate a string in options-permalink and end strings with full stops. fixes #19472.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-20 21:15:13 +00:00
ryan 340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
nacin 15ceab2647 Standardize some final help strings. We're done, aside from typos. props zeo, jane, duck_, fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-02 04:31:01 +00:00
ryan a6091e18e7 English, less butchering of it.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 05:03:19 +00:00
nacin 4c566cebc6 Help text tweaks for the Settings screens. props jane. see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:52:31 +00:00
koopersmith ed2c35ad0a Update help text on settings pages. props Ipstenu, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-29 16:58:58 +00:00
nacin bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00