Commit Graph

38204 Commits

Author SHA1 Message Date
Dominik Schilling 5c291d49de Pinking shears.
See #41057.
Built from https://develop.svn.wordpress.org/trunk@42843


git-svn-id: http://core.svn.wordpress.org/trunk@42673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-18 14:23:33 +00:00
Joe McGill 2cb76498ba Update unit test following r42839.
This updates the expected version number for Hello Dolly in `Tests_Ajax_Update_Plugin::test_update_plugin` following [42839].

See #43555.

Built from https://develop.svn.wordpress.org/trunk@42841


git-svn-id: http://core.svn.wordpress.org/trunk@42671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-17 20:57:30 +00:00
Joe McGill 0a02c87b48 Update Hello Dolly lyrics.
This updates the Hello Dolly plugin to remove lines which could be objectionable when shown in the admin out of context, and brings the lyrics more in line with Louis Armstrong's recording.

Props sebastienthivinfocom, birgire, audrasjb, joemcgill.
Fixes #43555.

Built from https://develop.svn.wordpress.org/trunk@42839


git-svn-id: http://core.svn.wordpress.org/trunk@42669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-17 20:23:32 +00:00
Joe McGill 06ec96a7a4 Revert max-width styles on caption shortcodes.
This is a partial revert of [41724], so image captions include an
inline `width` style instead of `max-width`.

This returns the caption shortcode to the pre-4.9.0 behavior, while
retaining the extra unit test coverage added in [41724].

Fixes #43123. See #33981.

Built from https://develop.svn.wordpress.org/trunk@42837


git-svn-id: http://core.svn.wordpress.org/trunk@42667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-16 20:07:33 +00:00
Felix Arntz 176a289050 Multisite: Introduce metadata for sites.
A new global multisite table `wp_blogmeta` is added to the database schema, and a set of `*_site_meta()` API functions are introduced.

The implementation fails gracefully when the new table is not yet available, which may happen especially shortly after the core update, before the network has been upgraded to the new database schema. The presence of the table is detected once and stored as a global setting on the main network.

Core does not yet use site metadata, but there are several use-cases to be implemented or explored in the near future, and it allows plugins to extend sites with arbitrary data, which will come in particularly handy with the upcoming REST API endpoint for sites.

Props spacedmonkey, johnjamesjacoby, jeremyfelt, flixos90.
Fixes #37923.

Built from https://develop.svn.wordpress.org/trunk@42836


git-svn-id: http://core.svn.wordpress.org/trunk@42666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-16 02:15:31 +00:00
Felix Arntz eda5ab56af Bootstrap: Load `formatting.php` and `meta.php` earlier in `wp-settings.php`.
This change is necessary to enable multisite-specific metadata functionality during the multisite bootstrap process.

See #40948.

Built from https://develop.svn.wordpress.org/trunk@42835


git-svn-id: http://core.svn.wordpress.org/trunk@42665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-16 02:01:33 +00:00
Felix Arntz 485984e82e Multisite: Add missing group annotations to tests included in [42833].
This ensures tests are skipped correctly when not using multisite.

See #43506.

Built from https://develop.svn.wordpress.org/trunk@42834


git-svn-id: http://core.svn.wordpress.org/trunk@42664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-13 17:57:30 +00:00
Felix Arntz 57fd97017e Multisite: Ensure the `{$network_id}:notoptions` array is set in cache in `get_network_option()`.
Prior to this change, the `{$network_id}:notoptions` cache would only be fetched, but not set, unless the actual database lookup would be unsuccessful. This enhancement slightly improves performance by preventing unnecessary external object cache lookups if one is used.

Fixes #43506.

Built from https://develop.svn.wordpress.org/trunk@42833


git-svn-id: http://core.svn.wordpress.org/trunk@42663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-13 15:37:33 +00:00
Felix Arntz ed1df81bba General: Introduce dashboard widget to inform administrators about outdated PHP versions.
This new dashboard widget is shown on WordPress sites which are powered by a PHP version which WordPress considers outdated, in order to inform site owners about the resulting problems and to explain how to upgrade to a supported version. An education page for that purpose has been previously created that the widget links to. The link is translatable so that localized versions of the page can be referred to as they become available.

The nag follows the example of the Browse Happy dashboard widget and is only visible for administrators, or network administrators when using multisite. To determine whether it needs to be displayed, a new wordpress.org API introduced prior is called that handles the version logic in a centralized location.

Props flixos90, hedgefield, schlessera.
Fixes #41191.

Built from https://develop.svn.wordpress.org/trunk@42832


git-svn-id: http://core.svn.wordpress.org/trunk@42662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-12 16:43:31 +00:00
John Blackbourn d7025e7787 Security: Loosen the admin referrer policy header value to allow the referring host to be sent from the admin area in all cases.
This allows referrer-restricted content from third parties (such as images and fonts) to continue working in the admin area.

Props aranwer104, qcmiao

Fixes #43285

Built from https://develop.svn.wordpress.org/trunk@42830


git-svn-id: http://core.svn.wordpress.org/trunk@42660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-12 10:57:35 +00:00
Dion Hulse 42b03122b5 Plugins: Add support for plugins having an `active_installs` value larger than 1 million.
WordPress.org currently supports up to 5 million, and with the growth of WordPress, it's expected that that upper bound will increase in the future.

Fixes #43193.

Built from https://develop.svn.wordpress.org/trunk@42829


git-svn-id: http://core.svn.wordpress.org/trunk@42659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-12 01:57:31 +00:00
Sergey Biryukov 81500e50ef Link Template: Apply `get_{$adjacent}_post_excluded_terms` filter to an empty `excluded_terms` parameter as well.
Props soulseekah, zottto.
Fixes #43521.
Built from https://develop.svn.wordpress.org/trunk@42828


git-svn-id: http://core.svn.wordpress.org/trunk@42658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 17:32:31 +00:00
Sergey Biryukov 4848a09b35 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.
Built from https://develop.svn.wordpress.org/trunk@42827


git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 16:44:34 +00:00
Sergey Biryukov fab939595d Docs: Fix typo in a comment in `WP_Community_Events::trim_events()`.
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42826


git-svn-id: http://core.svn.wordpress.org/trunk@42656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 10:35:31 +00:00
Sergey Biryukov 15e969be8d Docs: Add missing brace in `auto_update_{$type}` filter DocBlock.
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42825


git-svn-id: http://core.svn.wordpress.org/trunk@42655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 10:30:33 +00:00
Sergey Biryukov 8bab745586 General: In `wp_debug_backtrace_summary()`, check if `$call['args']` is defined to avoid a PHP notice.
Props paulschreiber.
Fixes #31215.
Built from https://develop.svn.wordpress.org/trunk@42824


git-svn-id: http://core.svn.wordpress.org/trunk@42654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 17:31:32 +00:00
Andrew Ozz ba7b8cd8a0 Accessibility improvements for the Privacy Tools screen.
Propr afercia.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@42823


git-svn-id: http://core.svn.wordpress.org/trunk@42653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 14:01:31 +00:00
Sergey Biryukov f700ac6075 Docs: Use `WP_Term` instead of generic `object` type for the `$tag` parameter in `wp-admin/edit-tag-form.php` hook docs.
Props xhezairi, ocean90.
Fixes #43507.
Built from https://develop.svn.wordpress.org/trunk@42822


git-svn-id: http://core.svn.wordpress.org/trunk@42652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 02:01:29 +00:00
Sergey Biryukov 4e9c3f916f Docs: Fix typos in `_wp_emoji_list()` description.
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42821


git-svn-id: http://core.svn.wordpress.org/trunk@42651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 01:50:30 +00:00
Sergey Biryukov 0b799bd6a7 General: In `wp_debug_backtrace_summary()`, capture hook name for `do_action_ref_array()` and `apply_filters_ref_array()` as well.
Props Rarst.
Fixes #43488.
Built from https://develop.svn.wordpress.org/trunk@42820


git-svn-id: http://core.svn.wordpress.org/trunk@42650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 00:05:31 +00:00
Sergey Biryukov c46a518330 Tests: Skip symlinked theme file tests if `symlink()` is not available, e.g. in PHP 5.2.x on Windows.
See #43508.
Built from https://develop.svn.wordpress.org/trunk@42819


git-svn-id: http://core.svn.wordpress.org/trunk@42649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:48:30 +00:00
Adam Silverstein e70caa19a1 Media: Fix image cropping on touch screen devices.
* In initCrop, handle touch events in addition to mouse events.
* In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.

Props yahil, alexgso, joemcgill.
Fixes #41242.

Built from https://develop.svn.wordpress.org/trunk@42818


git-svn-id: http://core.svn.wordpress.org/trunk@42648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:27:31 +00:00
Adam Silverstein 6751be3561 Customizer menus: correct oversized viewport after dragging menu items.
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.

Props kwonye.
Fixes #36884.

Built from https://develop.svn.wordpress.org/trunk@42817


git-svn-id: http://core.svn.wordpress.org/trunk@42647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:06:30 +00:00
John Blackbourn d1d60bb22c Themes: Revert [42788] as it breaks a lot of things.
See #43228

Built from https://develop.svn.wordpress.org/trunk@42816


git-svn-id: http://core.svn.wordpress.org/trunk@42646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:00:31 +00:00
Andrew Ozz 63dd79d908 Respect the commenter decision when they have checked the checkbox to consent to cookies, and keep it checked when they reload the page or post another comment.
See #43436.
Built from https://develop.svn.wordpress.org/trunk@42815


git-svn-id: http://core.svn.wordpress.org/trunk@42645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 15:57:30 +00:00
Andrew Ozz b93dfd3571 Add Privacy Tools admin page under the Tools menu.
Props allendav, xkon, azaozz.
See #43435.
Built from https://develop.svn.wordpress.org/trunk@42814


git-svn-id: http://core.svn.wordpress.org/trunk@42644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 15:04:33 +00:00
Sergey Biryukov 051dd178b3 Tests: Skip symlinked theme file tests if the links could not be created.
Fixes #43508.
Built from https://develop.svn.wordpress.org/trunk@42812


git-svn-id: http://core.svn.wordpress.org/trunk@42642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 01:10:31 +00:00
Andrea Fercia 127ecc530c Accessibility: Underline the links in the Plugins descriptions and update notices.
Links within blocks and lines of text should always be underlined.

Props Travel_girl, chetan200891, Shital Patel.
Fixes #42647.

Built from https://develop.svn.wordpress.org/trunk@42810


git-svn-id: http://core.svn.wordpress.org/trunk@42640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:20:30 +00:00
Sergey Biryukov eaf4f346fd Docs: Improve documentation for meta capability filters.
Remove self-references, correct parameter names and descriptions.

Props milana_cap, ocean90, SergeyBiryukov.
Fixes #43504.
Built from https://develop.svn.wordpress.org/trunk@42809


git-svn-id: http://core.svn.wordpress.org/trunk@42639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:19:30 +00:00
Andrea Fercia 320a05019a Accessibility: Themes: use `aria-current` for the `Walker_Nav_Menu` current link.
The `aria-current` attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the 
introduction in core of `aria-current` after [42440], [41683], [41359], and [41371].

Props williampatton, chetan200891, sami.keijonen.
Fixes #43191.

Built from https://develop.svn.wordpress.org/trunk@42808


git-svn-id: http://core.svn.wordpress.org/trunk@42638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 21:31:30 +00:00
Andrea Fercia 48077799d9 Accessibility: Insert Link modal: Improve keyboard interaction.
Avoids to change the selected link when using the Shift and Up/Down arrow keys
to select text in the form fields.

Fixes #43253.

Built from https://develop.svn.wordpress.org/trunk@42807


git-svn-id: http://core.svn.wordpress.org/trunk@42637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 20:58:30 +00:00
Sergey Biryukov 996efe8f6e Filesystem API: Avoid an infinite loop in `wp_mkdir_p()` when trying to determine the parent folder with `open_basedir` restriction in effect.
Props soulseekah, 1265578519-1.
Fixes #43417.
Built from https://develop.svn.wordpress.org/trunk@42801


git-svn-id: http://core.svn.wordpress.org/trunk@42631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 19:32:30 +00:00
Sergey Biryukov c1897645a2 General: In `wp_debug_backtrace_summary()`, normalize paths before replacement for better cross–platform compatibility.
Props Rarst.
Fixes #43501.
Built from https://develop.svn.wordpress.org/trunk@42800


git-svn-id: http://core.svn.wordpress.org/trunk@42630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 17:08:31 +00:00
Sergey Biryukov 902232ffec Tests: Correct assertion in `Tests_WP_Customize_Setting::test_constructor_with_args()`.
Props jipmoors.
See #30988, #43218.
Built from https://develop.svn.wordpress.org/trunk@42799


git-svn-id: http://core.svn.wordpress.org/trunk@42629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 16:38:30 +00:00
Sergey Biryukov e2707d57f9 Docs: Improve JSDoc for `wp-includes/js/media/controllers/gallery-add.js`.
Props boblinthorst, bramheijmink, manuelaugustin, ireneyoast, igorsch, nataliashitova.
Fixes #43500.
Built from https://develop.svn.wordpress.org/trunk@42798


git-svn-id: http://core.svn.wordpress.org/trunk@42628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 16:25:34 +00:00
Sergey Biryukov fdc4f68678 Docs: Remove copy/pasted default value description for `$type` in `WP_Customize_Manager::add_setting()`.
Props DannyCooper.
Fixes #43497.
Built from https://develop.svn.wordpress.org/trunk@42797


git-svn-id: http://core.svn.wordpress.org/trunk@42627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 13:06:33 +00:00
Sergey Biryukov ef33f565b1 Docs: Improve documentation for `add_meta_boxes` and `do_meta_boxes` actions.
Props danieltj, johnbillion, SergeyBiryukov.
Fixes #43229.
Built from https://develop.svn.wordpress.org/trunk@42796


git-svn-id: http://core.svn.wordpress.org/trunk@42626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 03:57:31 +00:00
Sergey Biryukov 24f43065b9 Docs: Document globals in `wp-admin/revision.php` as `@global` instead of `@param`.
See #42505.
Built from https://develop.svn.wordpress.org/trunk@42795


git-svn-id: http://core.svn.wordpress.org/trunk@42625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 03:53:34 +00:00
Andrea Fercia ffedf3d752 Accessibility: Widgets: Make the "Available Widgets" section operable with a keyboard.
For a number of years, the "Available Widgets" section has been off-limits for
keyboard users. Now it can be used also with the keyboard. This change introduces
also some improvements for assistive technologies.

- makes the widget toggles focusable and adds an `aria-expanded` attribute to indicate their state
- improves the toggles labelling to clarify context (add/edit)
- changes the controls to choose a sidebar from list items to buttons
- adds an `aria-label` attribute to the buttons to clarify their purpose
- adds an `aria-pressed` attribute to the buttons to indicate which one is selected
- improves color contrast of the selected button
- uses a `wp.a11y.speak()` message to announce to screen reader users when a widget has been added to a sidebar
- moves focus back to the toggle button when closing a widget

See #40677.

Built from https://develop.svn.wordpress.org/trunk@42794


git-svn-id: http://core.svn.wordpress.org/trunk@42624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 22:27:31 +00:00
Andrea Fercia e34999f4aa Accessibility: Networks and Sites: mark the New Site required form fields as required.
Also, adds an `aria-describedby` attribute to associate the Admin Email field with its description.

Props dipesh.kakadiya, jackreichert, rianrietveld.
Fixes #37331.

Built from https://develop.svn.wordpress.org/trunk@42793


git-svn-id: http://core.svn.wordpress.org/trunk@42623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 19:41:33 +00:00
Mike Schroder 51b0a3cd28 Media: Correctly allow changing PDF thumbnail crop value.
Corrects logic that keeping plugins from setting crop value of intermediate image sizes for rendered PDFs.

Adds test.

Props leemon, SergeyBiryukov, chetan200891, birgire.
Fixes #43226.
Built from https://develop.svn.wordpress.org/trunk@42792


git-svn-id: http://core.svn.wordpress.org/trunk@42622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 01:19:31 +00:00
Andrew Ozz 791b11bc3f Add a method to confirm user requests by email. First run.
Props mikejolley.
See #43443.
Built from https://develop.svn.wordpress.org/trunk@42791


git-svn-id: http://core.svn.wordpress.org/trunk@42621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 23:47:30 +00:00
Andrea Fercia 6a4b2a022a Accessibility: Make the Widgets screen "Enable accessibility mode" link more discoverable.
For a number of years, the link to the Widgets screen "Accessibility mode" lived
in the Screen Options panel, hidden by default. Many users, including assistive
technologies users, weren't able to find it or even aware it existed. By bringing
the link in the main screen, visible by default, this change makes the
"Accessibility mode" easily discoverable for everyone.

Props chetan200891, antonioeatgoat.
Fixes #42778.

Built from https://develop.svn.wordpress.org/trunk@42790


git-svn-id: http://core.svn.wordpress.org/trunk@42620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 17:21:33 +00:00
John Blackbourn 6c09e79cc5 Database: Add the query start time to logged query data.
This allows debugging plugins to plot the time at which queries were executed.

Props Rarst for initial patch.

Fixes #43315

Built from https://develop.svn.wordpress.org/trunk@42789


git-svn-id: http://core.svn.wordpress.org/trunk@42619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 22:54:35 +00:00
John Blackbourn ea6360b47c Themes: Ensure the theme roots cache is cleared when registering a theme directory.
Props soulseekah, johnbillion

Fixes #43228

Built from https://develop.svn.wordpress.org/trunk@42788


git-svn-id: http://core.svn.wordpress.org/trunk@42618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 22:14:30 +00:00
John Blackbourn c9b07e6411 Docs: Standardise and correct documentation relating to parameters which accept plugin names.
See #42505

Built from https://develop.svn.wordpress.org/trunk@42787


git-svn-id: http://core.svn.wordpress.org/trunk@42617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 21:50:31 +00:00
John Blackbourn 087b52dced Upgrade/Install: Fix the format of the `upgrader_process_complete` actions after [42343].
More info: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1323

See #41057, #42505

Built from https://develop.svn.wordpress.org/trunk@42786


git-svn-id: http://core.svn.wordpress.org/trunk@42616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 21:44:30 +00:00
Andrea Fercia 9842bd6d24 Accessibility: Change the "Show / Hide dismissed updates" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Also, adds an `aria-expanded` attribute to communicate the expandable panel state
and improves the buttons spacing.

Props Cheffheid, audrasjb, afercia.
Fixes #38674.

Built from https://develop.svn.wordpress.org/trunk@42785


git-svn-id: http://core.svn.wordpress.org/trunk@42615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:50:30 +00:00
Andrea Fercia 64634898c2 Accessibility: Change the media upload "Dismiss error" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffheid, audrasjb.
Fixes #38671.

Built from https://develop.svn.wordpress.org/trunk@42784


git-svn-id: http://core.svn.wordpress.org/trunk@42614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:33:33 +00:00
Sergey Biryukov 084b48e1ba Help/About: Adjust capability checks formatting in help text on Dashboard screen for readability and consistency with similar checks in other files.
See #43472.
Built from https://develop.svn.wordpress.org/trunk@42783


git-svn-id: http://core.svn.wordpress.org/trunk@42613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:32:30 +00:00