Commit Graph

278 Commits

Author SHA1 Message Date
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Gary Pendergast 55af0f0d0a Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
See #47632


Built from https://develop.svn.wordpress.org/trunk@45580


git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:01:57 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast 8244397ffb Coding Standards: Prepare for upgrading WPCS to 1.0.0.
In order to get the best result when running `phpcbf` across the codebase, there are some manual tweaks we need to make.

These fall into three categories:
- Fixing incorrectly indented code which has flow-on effects when auto-fixing.
- Tweaking the layout of inline PHP inside HTML tags.
- Moving more complex inline PHP inside HTML tags, to execute earlier.

See #44600.


Built from https://develop.svn.wordpress.org/trunk@43569


git-svn-id: http://core.svn.wordpress.org/trunk@43398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-15 06:22:26 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Gary Pendergast c90cfa3b50 General: Fix some precision alignment formatting warnings.
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42228


git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 23:57:55 +00:00
Scott Taylor a3ffebce30 Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38470


git-svn-id: http://core.svn.wordpress.org/trunk@38411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:31:29 +00:00
Scott Taylor 390ceba6c7 Bootstrap: after r38409 and r38410, revert r38402 which reverted r38399.
This fixes the paths in `wp-vendor/` that were including `src`. I want to drop this in so we can find out what else will break.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38411


git-svn-id: http://core.svn.wordpress.org/trunk@38352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 22:32:37 +00:00
Dion Hulse 0e31a46161 Bootstrap: Revert [38399] as it's broken `/build/` and subsequently core.svn.wordpress.org.
The generated classmaps reference `/src/` files and operates in the assumption that the base directory is one level above `wp-settings.php`, which it isn't after our build processes are run.

See #36335

Built from https://develop.svn.wordpress.org/trunk@38402


git-svn-id: http://core.svn.wordpress.org/trunk@38343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 14:37:32 +00:00
Scott Taylor 6a529648cf Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader.
* `wp-admin` and `wp-includes` are scanned for classes to autoload
* Several 3rd-party and Ryan McCue-shaped libraries are excluded when the classmap is generated, see `composer.json`: `autoload.exclude-from-classmap`
* `wp-vendor/autoload_52.php` is included at the top of `wp-settings.php` - no changes need to be made to unit tests to include the autoloader
* An avalanche of `require()` and `require_once()` calls that loaded class files have been removed from the codebase.

The following files have been added to `svn:ignore` - they are not 5.2-compatible and fail during pre-commit:
* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php

We favor these files instead:
* src/wp-vendor/autoload_52.php
* src/wp-vendor/composer/autoload_real_52.php
* src/wp-vendor/composer/ClassLoader52.php

When new PHP classes are added to the codebase, simply run `composer install` or `composer update` from the project root to update the autoloader.

The future is now.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38399


git-svn-id: http://core.svn.wordpress.org/trunk@38340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 09:15:29 +00:00
Sergey Biryukov 139387b7e5 Docs: Use 3-digit, x.x.x-style semantic versioning for `_doing_it_wrong()`, `_deprecated_function()`, `_deprecated_argument()`, and `_deprecated_file()` throughout core.
Props metodiew.
Fixes #36495.
Built from https://develop.svn.wordpress.org/trunk@37985


git-svn-id: http://core.svn.wordpress.org/trunk@37926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-06 12:40:29 +00:00
Drew Jaynes f82641ad0e Docs: Standardize filter docs in root folder files to use third-person singular verbs per the inline documentation standards for PHP.
Fixes #36913.

Built from https://develop.svn.wordpress.org/trunk@37535


git-svn-id: http://core.svn.wordpress.org/trunk@37503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 16:44:27 +00:00
John Blackbourn 815635548a Switch the remaining user-facing links to wordpress.org over to HTTPS.
Fixes #27115

Built from https://develop.svn.wordpress.org/trunk@34783


git-svn-id: http://core.svn.wordpress.org/trunk@34748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 22:46:28 +00:00
Drew Jaynes b407bb0936 Docs: Standardize `@deprecated` tag formatting in the DocBlock for the `logIO()` function.
Props Alphawolf.
Fixes #28806.

Built from https://develop.svn.wordpress.org/trunk@33680


git-svn-id: http://core.svn.wordpress.org/trunk@33647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:44:25 +00:00
Gary Pendergast 5d3fba37f2 XML-RPC: Don't rely on `include_path` to include files, use `dirname()` instead.
See #17092.


Built from https://develop.svn.wordpress.org/trunk@33459


git-svn-id: http://core.svn.wordpress.org/trunk@33426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 12:17:26 +00:00
Drew Jaynes c457c7856d Fixes for hooks documentation on xmlrpc.php.
Adds spacing, changes an `@see` to `@link`, adds a docs-specific variable for a parameter.

See #26869, #25229 and [25281].

Built from https://develop.svn.wordpress.org/trunk@27146


git-svn-id: http://core.svn.wordpress.org/trunk@27013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-09 20:39:12 +00:00
Andrew Nacin 70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin de7977d66c Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Drew Jaynes 4d1482cd0d Inline documentation for the `WP_Date_Query` class in wp-includes/date.php.
- Adds a complete hash notation for the `WP_Date_Query` arguments array.
- Adds missing documentation for the `date_query_valid_columns` and `get_date_sql` filter hooks.

Props aeg0125 for the incremental patches.
Fixes #25552.

Built from https://develop.svn.wordpress.org/trunk@25860


git-svn-id: http://core.svn.wordpress.org/trunk@25860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:12 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Ryan Boren b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Andrew Nacin 8b91d32f98 Inline documentation for hooks in xmlrpc.php.
The old link for RSD is dead; update to the new one.

props bftrick.
see #25229.

Built from https://develop.svn.wordpress.org/trunk@25281


git-svn-id: http://core.svn.wordpress.org/trunk@25245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 16:56:09 +00:00
Sergey Biryukov 709dd51ae6 Fix typos in phpdoc. props bradparbs. fixes #23481.
git-svn-id: http://core.svn.wordpress.org/trunk@23604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 04:23:00 +00:00
Andrew Nacin 9d204841ee Remove AtomPub from core.
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 20:11:39 +00:00
nacin aefde50081 Deprecate ancient "debugging" tools.
* logIO() and the global $xmlrpc_logging in XML-RPC.
 * log_app() and the global $app_logging in APP.
 * debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.
see #20051.



git-svn-id: http://svn.automattic.com/wordpress/trunk@19935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-17 00:02:42 +00:00
nacin acd0f7c375 Re-purpose wp_die() for ajax responses.
* Allows unit testing of core ajax actions.
 * wp_die() now has separate filters to choose a handler depending on the context (ajax, XML-RPC, else).
 * wp_die) in ajax context does not need to be called with a string. Conversion takes place before die().
props kurtpayne, see #15327.



git-svn-id: http://svn.automattic.com/wordpress/trunk@19801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-31 22:12:58 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
westi eed35967cc Introduce a special wp_die handler for XMLRPC requests to ensure we send an XML response.
Props koke for the original patch. See #16748.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-17 08:35:51 +00:00
westi 9c0a5cd498 Don't do SSL discovery for every RSD request. APP endpoint already respects the SSLness of the site. Fixes #15960.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-17 07:48:34 +00:00
westi ee291ef5a5 Remove WP_SHOW_ADMIN_BAR and go off existing and new defines on page type. See #15315
git-svn-id: http://svn.automattic.com/wordpress/trunk@16221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-06 09:41:03 +00:00
westi 2bc7106135 Rename new classes to match our coding standards. Fixes #15280.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-02 08:29:07 +00:00
westi 77aaa245c5 No Admin Bar for XML-RPC requests.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-26 14:37:50 +00:00
westi b3054b3106 Complete the move to a seperate class file for #14820 props filosofo.
Add support for replacing the class used. Fixes #14814 props filosofo.

git-svn-id: http://svn.automattic.com/wordpress/trunk@15648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-23 21:38:28 +00:00
scribu 1652fe96c1 fix wp_getAuthors in xmlrpc.php. See #14572 and [15566]
git-svn-id: http://svn.automattic.com/wordpress/trunk@15567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 14:49:52 +00:00
markjaquith 5711925db5 This file was mistakenly labeled as being GPLv2-only. fixes #14727
git-svn-id: http://svn.automattic.com/wordpress/trunk@15557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-02 04:47:57 +00:00
ryan 900c2e22d4 If category already exists, return its ID. Restores previous behavior. fixes #14067 for 3.1
git-svn-id: http://svn.automattic.com/wordpress/trunk@15425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-14 14:12:23 +00:00
nacin 248f4ab860 Provide a context to wp_handle_upload to differentiate between upload and sideload. props technosailor, fixes #12740.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 22:16:48 +00:00
nacin e64a657575 s/blog/site/ in even more places. props PeteMall, see #11644.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-30 03:17:49 +00:00
nacin b18ac8fcdb Deprecate set_current_user() in favor of wp_set_current_user().
git-svn-id: http://svn.automattic.com/wordpress/trunk@14090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-14 22:06:03 +00:00
markjaquith 58d47426cc More pedantry. "Setup" is not a verb. http://notaverb.com/setup
git-svn-id: http://svn.automattic.com/wordpress/trunk@13725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-17 04:39:50 +00:00
nacin 5a1013b8ba Don't use private wpdb vars. See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@13353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 00:18:18 +00:00
ryan aba18243f0 Fix double escaping in wp_getComments. Props josephscott. fixes #12281 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@13207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-19 00:28:23 +00:00
wpmuguru 913f639eea Call class function in xmlrpc.php, fixes #12155
git-svn-id: http://svn.automattic.com/wordpress/trunk@13004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 04:21:53 +00:00
dd32 cce3973d0e Do not use deprecated user levels in XMLRPC (s/level_8/manage_options/). Props nacin. Fixes #10806
git-svn-id: http://svn.automattic.com/wordpress/trunk@12969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-05 14:43:08 +00:00
ryan ca04c9d349 Cast length to int. Props josephscott. fixes #12046
git-svn-id: http://svn.automattic.com/wordpress/trunk@12870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-27 14:06:06 +00:00
wpmuguru 54d1dfeccf apply xmlrpc patch 2056 from MU 2.9.1.1, fixes #11999
git-svn-id: http://svn.automattic.com/wordpress/trunk@12864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-27 02:59:26 +00:00
ryan 9b79d3d516 Integrate wpmu_blogger_getUsersBlogs() directly into xmlrpc.php. see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-26 20:15:43 +00:00
ryan 8760e7da1b Coding standards, space after if
git-svn-id: http://svn.automattic.com/wordpress/trunk@12752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-18 20:34:48 +00:00
ryan 9bea527ac3 Coding style
git-svn-id: http://svn.automattic.com/wordpress/trunk@12735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 23:40:29 +00:00
ryan dea7019303 Use is_super_admin() instead of is_site_admin(). Props GIGALinux see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-08 20:29:56 +00:00