John Blackbourn
5a481ea118
Options, Meta APIs: Remove an accidental short array syntax in the tests.
...
See #43561
Built from https://develop.svn.wordpress.org/trunk@45065
git-svn-id: http://core.svn.wordpress.org/trunk@44874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 22:03:52 +00:00
John Blackbourn
8f5d82df7b
Options, Meta APIs: Ensure the `$object_id` parameter passed to the `delete_{$meta_type}_meta` and `deleted_{$meta_type}_meta` filters is always an integer.
...
Props salcode
Fixes #43561
Built from https://develop.svn.wordpress.org/trunk@45064
git-svn-id: http://core.svn.wordpress.org/trunk@44873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:59:52 +00:00
Sergey Biryukov
2bb2af2731
PHPCS: Fix WPCS violations in [45062].
...
See #46056 .
Built from https://develop.svn.wordpress.org/trunk@45063
git-svn-id: http://core.svn.wordpress.org/trunk@44872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:57:51 +00:00
Sergey Biryukov
10409c0f7c
Privacy: Ensure the personal data export email is sent in the locale of the user whose data is being exported (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale.
...
Props garrett-eclipse.
Fixes #46056 .
Built from https://develop.svn.wordpress.org/trunk@45062
git-svn-id: http://core.svn.wordpress.org/trunk@44871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:29:50 +00:00
John Blackbourn
437285dba4
Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported.
...
Props kraftbj
Fixes #46467
Built from https://develop.svn.wordpress.org/trunk@45061
git-svn-id: http://core.svn.wordpress.org/trunk@44870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:27:51 +00:00
Sergey Biryukov
459aef1fa5
Build/Test Tools: Exclude `twentynineteen/node_modules` from `jsvalidate:build` task.
...
Fixes #46706 .
Built from https://develop.svn.wordpress.org/trunk@45060
git-svn-id: http://core.svn.wordpress.org/trunk@44869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:17:52 +00:00
John Blackbourn
94e4da6aec
Themes: Introduce a generic action that's fired when a template part is loaded.
...
This action allows debugging mechanisms to perform greater introspection into which template parts are loaded for any given request. It also exposes the array of candidate template part file names for each template part instance.
Props pcfreak30, jdeeburke
Fixes #41575
Built from https://develop.svn.wordpress.org/trunk@45059
git-svn-id: http://core.svn.wordpress.org/trunk@44868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:13:54 +00:00
Aaron Jorbin
9ca5ec97b1
PHP: Finish updating PHP Minimum version
...
Previous [44982] and [44950].
This bumps the minimum version down slightly based on some research into the usage of php 5.6. This also brings the recommended version in line with https://wordpress.org/about/requirements/ .
The travis matrix is also being reduced in order to speed up builds. This is a hard break. PHP 5.2 - 5.5 we are never ever, ever, getting back together. You go talk to your friends, talk to my friends, talk to me, But we are never ever, ever, ever getting back together.
Props DD32, afergen for research.
Fixes #46594 .
Built from https://develop.svn.wordpress.org/trunk@45058
git-svn-id: http://core.svn.wordpress.org/trunk@44867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:12:52 +00:00
Sergey Biryukov
9ebc5e85fd
Twenty Nineteen: Update `Theme URI` to point to the Theme Directory instead of the archived GitHub repository.
...
Update `style.scss` and `style-rtl.css`, missed in [45032].
Props dimadin.
See #46668 .
Built from https://develop.svn.wordpress.org/trunk@45057
git-svn-id: http://core.svn.wordpress.org/trunk@44866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 20:58:51 +00:00
Sergey Biryukov
4e4e8fa110
Bootstrap/Load: Ensure the fatal error handler is registered after `WP_CONTENT_DIR` is defined, so the custom error handler drop-in could be properly loaded.
...
Props sebastian.pisula, diddledan.
Fixes #46069 .
Built from https://develop.svn.wordpress.org/trunk@45056
git-svn-id: http://core.svn.wordpress.org/trunk@44865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 19:04:51 +00:00
Sergey Biryukov
a2577854e6
Site Health: Declare `ClipboardJS` global to fix JSHint issue.
...
See #46647 .
Built from https://develop.svn.wordpress.org/trunk@45055
git-svn-id: http://core.svn.wordpress.org/trunk@44864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 18:38:51 +00:00
Sergey Biryukov
5cb984d371
Docs: Fix typo in `xmlrpc_chunk_parsing_size` filter description.
...
Props lord_viper.
Fixes #46701 .
Built from https://develop.svn.wordpress.org/trunk@45054
git-svn-id: http://core.svn.wordpress.org/trunk@44863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 16:53:51 +00:00
Sergey Biryukov
774ac73a1f
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/widgets.css`.
...
Props ianbelanger, audrasjb.
Fixes #46531 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45053
git-svn-id: http://core.svn.wordpress.org/trunk@44862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 16:39:51 +00:00
Sergey Biryukov
a02494a80f
Site Health: Add description for a successful HTTPS check.
...
Props Clorith, xkon.
Fixes #46617 .
Built from https://develop.svn.wordpress.org/trunk@45052
git-svn-id: http://core.svn.wordpress.org/trunk@44861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 16:15:51 +00:00
Sergey Biryukov
07d5eda632
Twenty Seventeen: Make `<th>` styling in table block consistent between back end and front end.
...
Props ianbelanger.
Fixes #46568 .
Built from https://develop.svn.wordpress.org/trunk@45051
git-svn-id: http://core.svn.wordpress.org/trunk@44860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 15:25:50 +00:00
Sergey Biryukov
e2115d62b6
Site Health: Use a consistent wording and response code for capability checks.
...
Props mukesh27 for initial patch.
Fixes #46691 .
Built from https://develop.svn.wordpress.org/trunk@45050
git-svn-id: http://core.svn.wordpress.org/trunk@44859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 15:11:51 +00:00
Sergey Biryukov
d69165bd3b
Site Health: Correct `wp_version_check()` existence verification by performing a request to the Site Health page instead of Dashboard.
...
Props Clorith, audrasjb.
Fixes #46616 .
Built from https://develop.svn.wordpress.org/trunk@45049
git-svn-id: http://core.svn.wordpress.org/trunk@44858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 14:31:51 +00:00
Gary Pendergast
ffc064d82d
Post WordPress 5.2 Beta 1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@45048
git-svn-id: http://core.svn.wordpress.org/trunk@44857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 23:36:52 +00:00
Gary Pendergast
d0445ead0c
WordPress 5.2 Beta 1.
...
Built from https://develop.svn.wordpress.org/trunk@45047
git-svn-id: http://core.svn.wordpress.org/trunk@44856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 23:20:51 +00:00
Gary Pendergast
0a4d431e11
Upgrades: Allow upgrades to proceed when a soft failure occurs on package signatures.
...
In particular, this allows downgrading from WordPress 5.2 to 5.1.1, if sites wish to opt out of the beta.
Props dd32.
See #46615 .
Built from https://develop.svn.wordpress.org/trunk@45046
git-svn-id: http://core.svn.wordpress.org/trunk@44855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 23:05:54 +00:00
Sergey Biryukov
d5f198676b
Plugins: In `wp_update_php_annotation()`, only display the annotation and the surrounding tags if it's not empty.
...
Props afragen.
Fixes #46678 .
Built from https://develop.svn.wordpress.org/trunk@45045
git-svn-id: http://core.svn.wordpress.org/trunk@44854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 22:37:51 +00:00
Gary Pendergast
65f7cdbce0
Site Health: Improve the "Copy to clipboard" button.
...
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.
To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.
Props pento, hedgefield, afercia.
Fixes #46647 .
Built from https://develop.svn.wordpress.org/trunk@45044
git-svn-id: http://core.svn.wordpress.org/trunk@44853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 22:31:52 +00:00
Sergey Biryukov
179c2ea230
Plugins: Disable "Update Now" button for plugins that require a higher version of PHP or WordPress.
...
This complements disabling the "Install Now" button in [43436].
Props afragen.
Fixes #46677 . See #43986 .
Built from https://develop.svn.wordpress.org/trunk@45043
git-svn-id: http://core.svn.wordpress.org/trunk@44852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 22:11:53 +00:00
Adam Silverstein
418afaa938
Bundled Theme: trigger a new `wp_body_open` action immediately after the opening `body` tag.
...
* Enables inserting (asynchronous) JavaScript right after the opening `body` tag.
* Add a `wp_body_open` helper function that triggers the `wp_body_open` action.
* Call `wp_body_open` in core themes immediately after the opening `body` tag.
Props joostdevalk, valendesigns, nacin, saracup, jorbin, mikeschinkel, jonnybojangles, lgedeon, Willscrlt, Denis-de-Bernardy, lexiqueen, sky_76, welcher, westonruter, ramiy, joyously.
Fixes #12563 .
Built from https://develop.svn.wordpress.org/trunk@45042
git-svn-id: http://core.svn.wordpress.org/trunk@44851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 21:59:52 +00:00
Andrea Fercia
9b15549b1c
Accessibility: Simplify the Site Health score indicator.
...
The Site Health score indicator isn't exactly a "progress bar" and shouldn't use ARIA roles and properties related to progress bars. Also, some browser / screen reader combinations don't announce the score properly.
- removes any ARIA
- adds a screen-reader-text "Current health score:"
- adds `role="img" aria-hidden="true" focusable="false"` to the SVG
- reduces CSS specificity simplifying unnecessary overqualified selectors
- fixes the syntax for ::after and ::before (double colon)
Fixes #46621 .
Built from https://develop.svn.wordpress.org/trunk@45041
git-svn-id: http://core.svn.wordpress.org/trunk@44850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 20:39:51 +00:00
desrosj
f9de2f860d
Administration: Fix Dashicon backwards compatibility issues.
...
In [44940], the Dashicon files in core were updated to contain the latest version of the font from the GitHub repo. This change follows that up by fixing several backwards compatibility issues caused by the new build process used to generate the font files and fixes the missing menu icon when viewing the admin on small screens.
- `buddicons-bbpress-logo (f12b)` was moved back to the correct location of `f477`.
- `editor-ltr (f129)` was moved back to the correct location of `f10c`.
- `email-alt2 (f10a)` was moved to the correct location of `f467`.
The following icons were restored to their previous locations:
- `camera-alt (f129)`
- `edit-large (f327)`
- `editor-distractionfree (f211)`
- `update-alt (f113)`
- `twitter-alt (f302)`
- `text-page (f121)`
- `plugins-checked (f485)`
- `menu-alt3 (f349)`
- `menu-alt2 (f329)`
- `menu-alt (f228)`
- Duplicate lock icon at location `f315`
- Duplicate `editor-code` icon at location `f494`
- `arrow-up` at `f143`.
The `editor-ltr` and `editor-rtl` icons had also been switched. The arrows now point in the correct directions at the correct Unicode locations (`f10c` and `f320` respectively).
And, lastly, this change also introduces the `code-standards (f13a)` icon that was not included in the previous build.
Props afercia, earnjam, oztaser, joen, cathibosco1, ianbelanger, desrosj.
See #41074 .
Fixes #46611 .
Built from https://develop.svn.wordpress.org/trunk@45040
git-svn-id: http://core.svn.wordpress.org/trunk@44849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 19:59:52 +00:00
Sergey Biryukov
b6a145ccb5
Privacy: Ensure the privacy data erase fulfillment email is sent in the locale of the user whose data is being erased (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale.
...
Props desrosj, birgire, garrett-eclipse.
Fixes #44721 .
Built from https://develop.svn.wordpress.org/trunk@45039
git-svn-id: http://core.svn.wordpress.org/trunk@44848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 19:41:53 +00:00
Andrea Fercia
7bedcf0bee
Accessibility: Improve the "Alt text" description.
...
Moves the word "Describe" within the link.
Amends [44900].
See #41612 .
Built from https://develop.svn.wordpress.org/trunk@45038
git-svn-id: http://core.svn.wordpress.org/trunk@44847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 18:47:51 +00:00
John Blackbourn
8190f1f0f8
Docs: Correct the documentation for the oEmbed HTML filtering.
...
See #46543
Built from https://develop.svn.wordpress.org/trunk@45037
git-svn-id: http://core.svn.wordpress.org/trunk@44846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 17:14:52 +00:00
John Blackbourn
c155b2a833
Docs: Improve the documentation for metadata related filter parameters.
...
See #46543
Built from https://develop.svn.wordpress.org/trunk@45036
git-svn-id: http://core.svn.wordpress.org/trunk@44845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 17:10:53 +00:00
John Blackbourn
9e67ba895d
Docs: Correct some documentation typos.
...
See #46543
Built from https://develop.svn.wordpress.org/trunk@45035
git-svn-id: http://core.svn.wordpress.org/trunk@44844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 17:09:52 +00:00
Sergey Biryukov
7807324652
Taxonomy: Initialize `$noparents` variable in `wp_ajax_add_tag()` to avoid a notice with `compact()` in PHP 7.3.
...
Props pilou69.
Fixes #46670 .
Built from https://develop.svn.wordpress.org/trunk@45034
git-svn-id: http://core.svn.wordpress.org/trunk@44843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 15:33:52 +00:00
Sergey Biryukov
06bb67be06
Docs: Correct back-compat reference to `$excluded_categories` in `get_adjacent_post()`.
...
See #46543 , #17673 .
Built from https://develop.svn.wordpress.org/trunk@45033
git-svn-id: http://core.svn.wordpress.org/trunk@44842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 14:45:51 +00:00
Sergey Biryukov
8633d837ee
Twenty Nineteen: Update `Theme URI` to point to the Theme Directory instead of the archived GitHub repository.
...
Props dimadin.
Fixes #46668 .
Built from https://develop.svn.wordpress.org/trunk@45032
git-svn-id: http://core.svn.wordpress.org/trunk@44841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 14:32:51 +00:00
Sergey Biryukov
0416de3294
General: Pass `$pagenum` argument to `get_pagenum_link` filter.
...
Props dimadin.
Fixes #46667 .
Built from https://develop.svn.wordpress.org/trunk@45031
git-svn-id: http://core.svn.wordpress.org/trunk@44840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 14:24:52 +00:00
Sergey Biryukov
b2e3f517e1
Database: Use `wp_die()` instead of `die()` in `wp_check_mysql_version()`, for more flexibility and consistency with other error messages in core.
...
Props spacedmonkey.
Fixes #45975 .
Built from https://develop.svn.wordpress.org/trunk@45030
git-svn-id: http://core.svn.wordpress.org/trunk@44839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 14:03:51 +00:00
Sergey Biryukov
577dc2326a
Bootstrap/Load: Restore `$wp_version` global check in `WP_Locale::init()`, previously replaced with `get_bloginfo( 'version' )` in [38459].
...
`wp_load_translations_early()` can be called in contexts where `get_bloginfo()` is not available yet, e.g. in `wp_check_php_mysql_versions()`.
Props shazdeh, parsmizban.
Fixes #41092 .
Built from https://develop.svn.wordpress.org/trunk@45029
git-svn-id: http://core.svn.wordpress.org/trunk@44838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 13:27:52 +00:00
Sergey Biryukov
d4d906c4d5
Themes: Remove `itemprop="url"` from `get_custom_logo()` output.
...
Making incorrect assumptions about microdata used in a theme results in invalid markup.
The attribute can still be added using the `get_custom_logo` or `wp_get_attachment_image_attributes` filter, but it should not be added by default.
Props henry.wright, tfrommen, afercia, markcallen, zodiac1978.
Fixes #37305 .
Built from https://develop.svn.wordpress.org/trunk@45028
git-svn-id: http://core.svn.wordpress.org/trunk@44837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 12:16:53 +00:00
Sergey Biryukov
6e2fb402e1
Build/Test Tools: Enable persistent object cache on a PHP 7.3 build instead of PHP 5.6.
...
Props netweb, johnbillion.
Fixes #46633 .
Built from https://develop.svn.wordpress.org/trunk@45027
git-svn-id: http://core.svn.wordpress.org/trunk@44836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 03:06:51 +00:00
Sergey Biryukov
6be19e0dab
Site Health: Update "Passed tests" button label to match both expanded and collapsed state.
...
Add `aria-controls` to declare what ID is being toggled.
Props Clorith, afercia.
Fixes #46663 . See #46573 .
Built from https://develop.svn.wordpress.org/trunk@45026
git-svn-id: http://core.svn.wordpress.org/trunk@44835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 02:57:51 +00:00
Sergey Biryukov
ada13d2ffd
PHPCS: Fix WPCS violations in [45023].
...
See #46620 .
Built from https://develop.svn.wordpress.org/trunk@45025
git-svn-id: http://core.svn.wordpress.org/trunk@44834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 00:36:50 +00:00
Sergey Biryukov
f8cfe858c9
Embeds: Scribd: Add support for `/document/` URL format, in addition to `/doc/`.
...
Props manzoorwani.jk, neobabis, swissspidy.
Fixes #46444 .
Built from https://develop.svn.wordpress.org/trunk@45024
git-svn-id: http://core.svn.wordpress.org/trunk@44833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 00:34:52 +00:00
Sergey Biryukov
455dccbc00
Bootstrap/Load: In fatal error handler, pass the error information through to error template and associated filters: `wp_php_error_message`, `wp_php_error_args`.
...
This allows the custom error handler and default error message filters to inspect the error and perform logic based on its properties.
Props johnbillion.
Fixes #46620 .
Built from https://develop.svn.wordpress.org/trunk@45023
git-svn-id: http://core.svn.wordpress.org/trunk@44832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 00:16:51 +00:00
Sergey Biryukov
b4ded564ff
PHPCS: Remove extra tab added in [45019].
...
See #45974 .
Built from https://develop.svn.wordpress.org/trunk@45022
git-svn-id: http://core.svn.wordpress.org/trunk@44831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 00:03:51 +00:00
Sergey Biryukov
6037e5ab5e
Plugins: Use correct singular for "Drop-in" in plugins list table.
...
Props tobifjellner, mukesh27.
Fixes #46592 .
Built from https://develop.svn.wordpress.org/trunk@45021
git-svn-id: http://core.svn.wordpress.org/trunk@44830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 00:00:50 +00:00
Sergey Biryukov
a5f0cd8741
Build/Test Tools: Display an error message with a recommendation to run `grunt build` when trying to run WordPress core tests without the `/build/` directory.
...
Props davidbaumwald.
Fixes #46593 .
Built from https://develop.svn.wordpress.org/trunk@45020
git-svn-id: http://core.svn.wordpress.org/trunk@44829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-26 23:53:52 +00:00
Sergey Biryukov
3e5c258b74
Bootstrap/Load: Use `wp_die()` instead of hardcoded HTML in `wp_maintenance()`, so the output can be filtered by plugins.
...
Props spacedmonkey.
Fixes #45974 .
Built from https://develop.svn.wordpress.org/trunk@45019
git-svn-id: http://core.svn.wordpress.org/trunk@44828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-26 23:39:51 +00:00
Sergey Biryukov
f6b6dc7e73
Docs: Fix typo in `wp_is_xml_request()` description.
...
See #46026 .
Built from https://develop.svn.wordpress.org/trunk@45018
git-svn-id: http://core.svn.wordpress.org/trunk@44827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-26 23:21:51 +00:00
Sergey Biryukov
65b1cbfd45
Docs: Improve documentation for `wp_die()` handlers after [45015] and [45016].
...
See #46543 , #46025 , #46026 .
Built from https://develop.svn.wordpress.org/trunk@45017
git-svn-id: http://core.svn.wordpress.org/trunk@44826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-26 23:18:53 +00:00
Sergey Biryukov
546841949f
Bootstrap/Load: Add support for XML requests to `wp_die()`.
...
In addition to AJAX, XML-RPC, JSON, and JSONP requests, `wp_die()` now handles XML requests correctly, returning information in the expected content type.
Props spacedmonkey, birgire.
Fixes #46026 . See #44458 .
Built from https://develop.svn.wordpress.org/trunk@45016
git-svn-id: http://core.svn.wordpress.org/trunk@44825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-26 23:11:52 +00:00