Dominik Schilling
15f24a7730
Customizer Theme Switcher: Fix tabbing order if section is open.
...
see #31289 .
Built from https://develop.svn.wordpress.org/trunk@32087
git-svn-id: http://core.svn.wordpress.org/trunk@32066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 19:03:25 +00:00
Dominik Schilling
79eee23a29
Customizer Theme Switcher: Don't deactivate section on empty search results.
...
props westonruter.
fixes #31889 .
Built from https://develop.svn.wordpress.org/trunk@32083
git-svn-id: http://core.svn.wordpress.org/trunk@32062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:53:28 +00:00
Aaron Jorbin
0402c0b877
Disable shiny updates from modal based on parent window
...
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal. Instead, let's use the parent window's location.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32082
git-svn-id: http://core.svn.wordpress.org/trunk@32061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:38:27 +00:00
Aaron Jorbin
7aeea37d47
Fix logic for details based shiny updates.
...
This fixes two problems. TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward. Also fixes logic error.
See #31739
Built from https://develop.svn.wordpress.org/trunk@32080
git-svn-id: http://core.svn.wordpress.org/trunk@32059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:27:26 +00:00
Aaron Jorbin
55cebbeeb6
Disable modal initiated shiny updates on wp-admin/update-core.php
...
We don't have links to update a single plugin on wp-admin/update-core.php so we can't initiate a shiny update there.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32067
git-svn-id: http://core.svn.wordpress.org/trunk@32046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 04:48:26 +00:00
Aaron Jorbin
1facff5425
Use dashes instead of dots as separator for jQuery events in shiny updates
...
`.` is used for namespaces, so better to use dashes.
see #31819
props iseulde
Built from https://develop.svn.wordpress.org/trunk@32063
git-svn-id: http://core.svn.wordpress.org/trunk@32042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:12:26 +00:00
Aaron Jorbin
99d6c67148
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32062
git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
Aaron Jorbin
1985d00886
Trigger events upon the completion of a shiny update
...
Plugins need to be able to do actions when a shiny update completes. While we don't have complete javascript actions and filters, we do have jQuery events that we can fire to assist plugin authors.
See #31819
Built from https://develop.svn.wordpress.org/trunk@32061
git-svn-id: http://core.svn.wordpress.org/trunk@32040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 02:32:26 +00:00
Dominik Schilling
6d2c70aa0d
Customizer: Refresh nonces when a session expires and the user logs in again.
...
This was broken since 4.0 and the introduction of user session tokens. The nonces are now tied to session tokens as opposed to user IDs, and thus they change with each re-login.
Custom nonces can be added through the `customize_refresh_nonces` filter. On a successful refresh request the JavaScript API will trigger a `nonce-refresh` event. See widget's update nonce as an example.
props westonruter for initial patch.
fixes #31294 .
Built from https://develop.svn.wordpress.org/trunk@32054
git-svn-id: http://core.svn.wordpress.org/trunk@32033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 15:10:27 +00:00
Aaron Jorbin
dd5b92a2fe
Remove Shiny Bulk Updates
...
Bulk updates don't need to be ajaxified so let's revert.
See #31770 , #29820 ,
Built from https://develop.svn.wordpress.org/trunk@32053
git-svn-id: http://core.svn.wordpress.org/trunk@32032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:21:26 +00:00
Aaron Jorbin
2c42b8f0b2
Conditionally add AYS to leaving shiny updates
...
When a shiny update is happening or pending, we should make sure users don't accidentally leave the page. This simple notification should help prevent users from accidentally not updating when they want to update.
See #31769
Props ericlewis and adamsilverstein for initial patch
Built from https://develop.svn.wordpress.org/trunk@32052
git-svn-id: http://core.svn.wordpress.org/trunk@32031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 01:00:26 +00:00
Helen Hou-Sandí
bfda508c18
Update more instances of default admin blues and grays.
...
props hugobaeta.
fixes #31234 .
Built from https://develop.svn.wordpress.org/trunk@32051
git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Dominik Schilling
4f3fb2315d
Customize Widgets: Improve sync logic for select[multiple] inputs.
...
The current logic doesn't account for the special case of `select[multiple]` inputs which lack a single value to synchronize: The value to synchronize is an array of zero or more values.
This change replaces `_getInputStatePropertyName()` with `_getInputState()`, which returns the state for an input depending on its type, and `_setInputState()`, which updates an input's state based on its type.
props westonruter.
fixes #31885 .
Built from https://develop.svn.wordpress.org/trunk@32012
git-svn-id: http://core.svn.wordpress.org/trunk@31991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:34:26 +00:00
Dominik Schilling
59c586e5ad
Customizer Theme Switcher: Remove "Add New" reference from customize-controls.js.
...
see #31837 .
Built from https://develop.svn.wordpress.org/trunk@32004
git-svn-id: http://core.svn.wordpress.org/trunk@31983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:14:26 +00:00
Helen Hou-Sandí
3ac1a19529
Spinners: Toggle a class instead of show/hide.
...
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.
props cdog, MikeHansenMe, valendesigns.
fixes #22839 . see #31875 , #30725 .
Built from https://develop.svn.wordpress.org/trunk@31996
git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Andrew Ozz
52db6356a1
Themes screen: remove extra debounce when searching.
...
Props evansolomon. Fixes #31812 .
Built from https://develop.svn.wordpress.org/trunk@31995
git-svn-id: http://core.svn.wordpress.org/trunk@31974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:37:32 +00:00
Andrew Ozz
2d36b8ff4a
Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
...
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600 .
Built from https://develop.svn.wordpress.org/trunk@31994
git-svn-id: http://core.svn.wordpress.org/trunk@31973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:32:28 +00:00
Andrew Ozz
05a549723c
Press This:
...
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875 .
Built from https://develop.svn.wordpress.org/trunk@31992
git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:34:26 +00:00
Andrew Ozz
b98ba09e5b
Press This: prevent pasting of HTML in the title H2. Insert the clipboard text instead.
...
Fixes #31768 .
Built from https://develop.svn.wordpress.org/trunk@31987
git-svn-id: http://core.svn.wordpress.org/trunk@31966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 21:11:30 +00:00
Dominik Schilling
942c6a9edc
Customizer: Update selector, missed in [31984].
...
see #28784 .
Built from https://develop.svn.wordpress.org/trunk@31985
git-svn-id: http://core.svn.wordpress.org/trunk@31964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 17:18:25 +00:00
Aaron Jorbin
3ac2f91922
Update aria-label when doing a shiny plugin update
...
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails
props mehulkaklotar, afercia
Fixes #31722
Built from https://develop.svn.wordpress.org/trunk@31982
git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 05:31:26 +00:00
Dominik Schilling
254b9e3264
Customizer Theme Switcher: Navigation streamlining.
...
* Detach Themes section from other controls
* Move to buttons to navigate back and forth
* Change titles based on current theme status, active/previewing
* Hide the active/previewing theme from the list of available themes
props folletto for the design concepts.
props designsimply, celloexpressions for initial patches.
props Team Gandalf.
see #31289 .
Built from https://develop.svn.wordpress.org/trunk@31975
git-svn-id: http://core.svn.wordpress.org/trunk@31954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:51:27 +00:00
Dominik Schilling
ba7f53f029
Customizer: Make the available widgets overlay closable on narrow screens.
...
see #28784 .
Built from https://develop.svn.wordpress.org/trunk@31974
git-svn-id: http://core.svn.wordpress.org/trunk@31953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:25:28 +00:00
Helen Hou-Sandí
d85f8fe326
Admin notices: Make (most) core notices dismissible.
...
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.
props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233 . see #23367 .
Built from https://develop.svn.wordpress.org/trunk@31973
git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
Aaron Jorbin
786083fd8e
Fix colors for activated and updated plugins
...
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared.
See #31608
Built from https://develop.svn.wordpress.org/trunk@31969
git-svn-id: http://core.svn.wordpress.org/trunk@31948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 21:31:26 +00:00
Dominik Schilling
8ab7c076d6
Customizer Theme Switcher: Switch the details/live preview buttons.
...
props celloexpressions, ocean90.
fixes #31791 .
Built from https://develop.svn.wordpress.org/trunk@31954
git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:36:26 +00:00
Aaron Jorbin
8f99fbeb8d
Refine UI for FTP modal and shiny updates
...
Numerous changes to make the FTP modal experience a good one. These include:
* Update HTML used by both the form here and the form on the standalone screen
* Allow users to cancel FTP install
* Focus locking in the modal
* Focus on modal form on load
* ARIA Attributes
* Style Enhancements
* Add low screen height (such as phone and some tablets) friendly experience for entering credentials
Props ericlewis, afercia
Fixes #31608
Built from https://develop.svn.wordpress.org/trunk@31949
git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
Dominik Schilling
79a29b077e
Customizer: Defer rendering theme controls until the section is displayed.
...
see #31793 .
Built from https://develop.svn.wordpress.org/trunk@31944
git-svn-id: http://core.svn.wordpress.org/trunk@31923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 22:21:25 +00:00
Sergey Biryukov
cd2e63700e
Use a more specific selector for comment moderation hotkeys after [31513].
...
props afercia.
fixes #31545 .
Built from https://develop.svn.wordpress.org/trunk@31929
git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Andrew Ozz
6cd9c9645e
Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
...
Part props afercis, joedolson. Fixes #31575 .
Built from https://develop.svn.wordpress.org/trunk@31925
git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
Dominik Schilling
b07e3e2de7
Customizer: Fix calculation of panel positions when accessing via deep-links.
...
Make sure that the parent `li` is shown before attempting to calculate its position.
Improve also the logic for focusing on a panel to prevent focusing hidden elements.
props westonruter.
fixes #31014 .
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31920
git-svn-id: http://core.svn.wordpress.org/trunk@31899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 11:17:28 +00:00
Andrew Ozz
71f48f45e0
Press This:
...
- When saving, replace emoji images with chars in the title text.
- Clean up the title text on paste.
See #31768 .
Built from https://develop.svn.wordpress.org/trunk@31919
git-svn-id: http://core.svn.wordpress.org/trunk@31898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 03:14:28 +00:00
Dominik Schilling
96b88a391b
Theme Switcher: Use the global panel back button instead of adding a new one.
...
This ensures the back button is visible on iOS devices. Same as in [29610].
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31918
git-svn-id: http://core.svn.wordpress.org/trunk@31897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 22:09:26 +00:00
Dominik Schilling
80972b7ecd
Customizer: Fix selector for container which includes the controls. Broken since [30102].
...
see #31794 , #31014 .
Built from https://develop.svn.wordpress.org/trunk@31916
git-svn-id: http://core.svn.wordpress.org/trunk@31895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-28 20:47:30 +00:00
Dominik Schilling
ee2829959a
Theme Switcher: Opening themes details modal shouldn't require two clicks on touch devices.
...
Inspired by [26838].
see #31794 .
Built from https://develop.svn.wordpress.org/trunk@31914
git-svn-id: http://core.svn.wordpress.org/trunk@31893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 22:54:29 +00:00
Helen Hou-Sandí
007665e7be
Admin menu: Revert [31720] for swipe open/closed.
...
This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.
see #31187 .
Built from https://develop.svn.wordpress.org/trunk@31910
git-svn-id: http://core.svn.wordpress.org/trunk@31889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 17:48:30 +00:00
Andrew Ozz
321b551650
Fix focusing in the plugin and theme editors. Update the help.
...
Props afercia, Cheffheid. Fixes #31415 .
Built from https://develop.svn.wordpress.org/trunk@31908
git-svn-id: http://core.svn.wordpress.org/trunk@31887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 22:35:27 +00:00
Aaron Jorbin
4c05e8c71c
More clean up from removal of Shiny Plugin Installs
...
See #31773 , #29820
Unprops Jorbin, Pento
Built from https://develop.svn.wordpress.org/trunk@31900
git-svn-id: http://core.svn.wordpress.org/trunk@31879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 16:30:27 +00:00
Aaron Jorbin
9b23faef07
Remove Shiny Plugin Installs
...
See #31773 , #29820
Built from https://develop.svn.wordpress.org/trunk@31897
git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:30:28 +00:00
Boone Gorges
bc3d8197aa
When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it.
...
Taxonomy metaboxes that are disabled for the current user are included in the
post.php markup, but do not contain the 'newtag' field, and so should be
skipped when looping through the metaboxes to avoid invoking String methods
on a variable of type `undefined`.
Props MikeNGarrett, A5hleyRich.
Fixes #30859 .
Built from https://develop.svn.wordpress.org/trunk@31895
git-svn-id: http://core.svn.wordpress.org/trunk@31874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:23:28 +00:00
Dominik Schilling
de7ecc80d3
Customizer: [31885] actually hasn't fixed the `SecurityError`s. This one does.
...
props mattwiebe.
fixes #31687 .
Built from https://develop.svn.wordpress.org/trunk@31893
git-svn-id: http://core.svn.wordpress.org/trunk@31872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 23:36:27 +00:00
Dominik Schilling
7925e4c912
Customizer: Avoid `SecurityError`s when the Customizer is embedded in an origin other than wp-admin.
...
props mattwiebe.
fixes #31687 .
Built from https://develop.svn.wordpress.org/trunk@31885
git-svn-id: http://core.svn.wordpress.org/trunk@31864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 17:26:26 +00:00
Andrew Ozz
0329852941
Press This:
...
- Fix the links on inserted images to point to the source site.
- Fix inserting of images above the blockquote when the editor has not been focused.
Fixes #31745 .
Built from https://develop.svn.wordpress.org/trunk@31868
git-svn-id: http://core.svn.wordpress.org/trunk@31847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 01:33:29 +00:00
Aaron Jorbin
a836a32fb4
Ensure that we target the correct plugin row for update updates
...
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.
Props ericlewis
Fixes #31621
Built from https://develop.svn.wordpress.org/trunk@31831
git-svn-id: http://core.svn.wordpress.org/trunk@31813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 05:26:28 +00:00
Helen Hou-Sandí
591c4b7d3b
List tables: Go back to inserting quick edit rows after, as some plugins rely on that assumption. Results are the same.
...
fixes #26060 .
Built from https://develop.svn.wordpress.org/trunk@31820
git-svn-id: http://core.svn.wordpress.org/trunk@31802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 21:50:27 +00:00
Dominik Schilling
c4a624aa22
Customizer: Remove a `throw error` call which prevents further actions, like `jqxhr.always()`.
...
props westonruter.
fixes #31501 .
Built from https://develop.svn.wordpress.org/trunk@31816
git-svn-id: http://core.svn.wordpress.org/trunk@31798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 19:29:27 +00:00
Aaron Jorbin
2d64637ff8
Request FTP and SSH credentials when needed during shiny updates
...
This is a restoration of [31749] which was reverted in [31755].
It includes a number of enhancements from the original version. Namely:
* Not doing a credential check in src/wp-includes/script-loader.php
* Add new function `wp_print_request_filesystem_credentials_modal`
* update the version number in the list table when a plugin is updated
UI still needs further work, but this basic version should enable more testing
Props ericlewis, jorbin
See #31528
Built from https://develop.svn.wordpress.org/trunk@31811
git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 03:18:27 +00:00
Andrew Ozz
441e1e6ab9
Press This: fix the header styling and add a logo.
...
Props Michael-Arestad. Fixes #31472 .
Built from https://develop.svn.wordpress.org/trunk@31807
git-svn-id: http://core.svn.wordpress.org/trunk@31789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:09:27 +00:00
Andrew Ozz
c1c29782c9
Press This:
...
- Test image sizes from JS after Press This loads, before adding them to "Suggested media".
- Clean up and simplify the HTML and JS a bit.
Fixes #31561 .
Built from https://develop.svn.wordpress.org/trunk@31797
git-svn-id: http://core.svn.wordpress.org/trunk@31779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 20:51:26 +00:00
Andrew Ozz
48ce41f15a
Press This: exclude both bookmarklet.js and bookmarklet.min.js from the main uglify task. Props stephdau. Fixes #31657 .
...
Built from https://develop.svn.wordpress.org/trunk@31796
git-svn-id: http://core.svn.wordpress.org/trunk@31778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 20:37:28 +00:00