Sergey Biryukov
5b62b44c15
Coding Standards: Use consistent formatting for error messages in `WP_Image_Editor_Imagick::write_image()` and `::strip_meta()`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49546
git-svn-id: http://core.svn.wordpress.org/trunk@49284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 15:35:05 +00:00
Sergey Biryukov
3e3328a269
General: Set `svn:eol-style` for some new files in `phpunit/includes`.
...
Follow-up to [48845], [49037], [49226], [49230].
See #51113 .
Built from https://develop.svn.wordpress.org/trunk@49545
git-svn-id: http://core.svn.wordpress.org/trunk@49283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 15:25:08 +00:00
John Blackbourn
34765ddb64
Docs: Docblock corrections relating to `WP_Post` objects.
...
See #51373 , #50768
Built from https://develop.svn.wordpress.org/trunk@49544
git-svn-id: http://core.svn.wordpress.org/trunk@49282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 15:15:08 +00:00
Sergey Biryukov
847a2e22a0
Tests: Remove empty `export` directory.
...
Follow-up to [30518], [31253], [34328].
See #51344 .
Built from https://develop.svn.wordpress.org/trunk@49543
git-svn-id: http://core.svn.wordpress.org/trunk@49281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 15:11:08 +00:00
John Blackbourn
3688a9394e
Media: Restore the ability of `WP_Image_Editor_Imagick->save()` to create a missing directory when needed.
...
Props eemitch, mikeschroder, hellofromTonya, p00ya, johnbillion
Fixes #51665
Built from https://develop.svn.wordpress.org/trunk@49542
git-svn-id: http://core.svn.wordpress.org/trunk@49280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 13:18:04 +00:00
Sergey Biryukov
2d8633bf22
I18N: Merge duplicate "Column" strings, remove unnecessary context.
...
Props ramiy, justinahinon, garrett-eclipse, audrasjb.
Fixes #47259 .
Built from https://develop.svn.wordpress.org/trunk@49541
git-svn-id: http://core.svn.wordpress.org/trunk@49279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 11:17:07 +00:00
Sergey Biryukov
2c5607307f
Coding Standards: Adjust formatting in `WP_Block::render()` for better readability.
...
Follow-up to [49310], [49539].
See #51606 .
Built from https://develop.svn.wordpress.org/trunk@49540
git-svn-id: http://core.svn.wordpress.org/trunk@49278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 11:01:05 +00:00
Sergey Biryukov
a2d42351c5
Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings.
...
Standardize on "Go to..." as a more appropriate option for most cases.
Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235 .
Built from https://develop.svn.wordpress.org/trunk@49539
git-svn-id: http://core.svn.wordpress.org/trunk@49277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 10:53:10 +00:00
Sergey Biryukov
4a18c93f42
Networks and Sites: Assign the array of site or network data returned from filters to the respective class property:
...
* The array of network data returned from the `networks_pre_query` filter is assigned to the `networks` property of the current `WP_Network_Query` instance.
* The array of site data returned from the `sites_pre_query` filter is assigned to the `sites` property of the current `WP_Site_Query` instance.
This avoids the performance overhead of calling `WP_Network_Query::get_networks()` or `WP_Site_Query::get_sites()` twice: first when creating the object instance, then to retrieve the filtered results.
This also makes the filters a bit more consistent with other similar filters, e.g. `posts_pre_query`, `terms_pre_query`, `comments_pre_query`, or `users_pre_query`.
Follow-up to [46086], [48990].
Props yakimun, spacedmonkey.
Fixes #51333 .
Built from https://develop.svn.wordpress.org/trunk@49538
git-svn-id: http://core.svn.wordpress.org/trunk@49276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-08 11:47:06 +00:00
Sergey Biryukov
5683c46277
Site Health: Validate the test result data format in JS before using it.
...
This will discard any invalid responses instead of causing fatal errors.
It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present.
Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov.
Fixes #50145 .
Built from https://develop.svn.wordpress.org/trunk@49537
git-svn-id: http://core.svn.wordpress.org/trunk@49275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-08 09:52:10 +00:00
Sergey Biryukov
c66edd0439
REST API: Use `_n()` in some error messages for proper plural forms support.
...
Follow-up to [47923], [49053].
Props audrasjb, tobifjellner, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51727 .
Built from https://develop.svn.wordpress.org/trunk@49536
git-svn-id: http://core.svn.wordpress.org/trunk@49274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-07 21:59:11 +00:00
Sergey Biryukov
ec9b010cea
Build/Test Tools: Check if all the required PHP extensions are loaded before running the test suite.
...
Add the GD extension as a hard requirement.
This improves the reliability of the test suite and ensures that if the test infrastructure changes in the future and a platform requirement such as GD accidentally gets removed, the tests fail with an appropriate error message.
Follow-up to [48592].
Props ayeshrajans, jrf, johnbillion.
Fixes #50640 .
Built from https://develop.svn.wordpress.org/trunk@49535
git-svn-id: http://core.svn.wordpress.org/trunk@49273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-07 13:20:07 +00:00
TimothyBlynJacobs
2559fb2a8d
App Passwords: Bump database version to flush rewrite rules.
...
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version so the change is applied to sites upon upgrading to 5.6.
Fixes #51723 .
Built from https://develop.svn.wordpress.org/trunk@49534
git-svn-id: http://core.svn.wordpress.org/trunk@49272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-06 22:15:09 +00:00
Sergey Biryukov
af95efdd34
Docs: Add a `@see` reference to `esc_url()` from `esc_url_raw()`.
...
Follow-up to [49512].
See #50585 .
Built from https://develop.svn.wordpress.org/trunk@49513
git-svn-id: http://core.svn.wordpress.org/trunk@49268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-06 14:16:07 +00:00
Sergey Biryukov
6dd28116a1
Docs: Improve return value description for `esc_url()`.
...
Add a reference to `esc_url()` from `esc_url_raw()` return value description.
Props stevenlinx, audrasjb, helen.
Fixes #50585 .
Built from https://develop.svn.wordpress.org/trunk@49512
git-svn-id: http://core.svn.wordpress.org/trunk@49267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-06 14:03:06 +00:00
Sergey Biryukov
3f7d705cfe
Bundled Themes: Correct list block alignment in editor styles.
...
Additionally:
* Indent nested lists in list and category blocks.
* Match ordered and unordered indentation for the classic block's lists.
This applies to:
* Twenty Ten
* Twenty Eleven
* Twenty Thirteen
* Twenty Fourteen
* Twenty Fifteen
* Twenty Sixteen
* Twenty Seventeen
Props sabernhardt, amolv, kjellr, audrasjb, francina.
Fixes #51157 .
Built from https://develop.svn.wordpress.org/trunk@49511
git-svn-id: http://core.svn.wordpress.org/trunk@49266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-06 11:53:05 +00:00
Sergey Biryukov
a3faece50b
Twenty Twenty: Correctly indent nested unordered lists in RTL editor styles.
...
Props sabernhardt.
Fixes #51574 .
Built from https://develop.svn.wordpress.org/trunk@49510
git-svn-id: http://core.svn.wordpress.org/trunk@49265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-06 11:38:09 +00:00
Sergey Biryukov
42b6ece059
Docs: Fix typo in a comment in `Walker::display_element()`.
...
Props david.binda, sabernhardt.
Fixes #51713 .
Built from https://develop.svn.wordpress.org/trunk@49509
git-svn-id: http://core.svn.wordpress.org/trunk@49264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-05 18:46:10 +00:00
Sergey Biryukov
3426581eaa
Twenty Thirteen: Correct alignment of blocks inside a `full-width` or `wide-width` group block.
...
Props sabernhardt.
Fixes #51440 .
Built from https://develop.svn.wordpress.org/trunk@49508
git-svn-id: http://core.svn.wordpress.org/trunk@49263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-05 15:05:07 +00:00
Sergey Biryukov
eb6b93f327
Twenty Twenty: Correct heading blocks alignment in editor styles.
...
This explicitly sets top and bottom margins instead of defining all four sides in shorthand notation.
Props sabernhardt, Lumne.
Fixes #51148 .
Built from https://develop.svn.wordpress.org/trunk@49507
git-svn-id: http://core.svn.wordpress.org/trunk@49262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-05 15:02:10 +00:00
Sergey Biryukov
ee7ff18b54
Docs: Improve documentation for `WP_Query::is_archive()` per the documentation standards.
...
Follow-up to [49504].
See #50545 .
Built from https://develop.svn.wordpress.org/trunk@49506
git-svn-id: http://core.svn.wordpress.org/trunk@49261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-05 09:44:05 +00:00
Sergey Biryukov
f22633f20b
Docs: Consistently place `@see` tags after `@since` in `WP_Query` methods, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@49505
git-svn-id: http://core.svn.wordpress.org/trunk@49260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-05 09:42:10 +00:00
Helen Hou-Sandí
1a2bdd7491
Improve documentation for `is_archive()`.
...
Props stevenlinx.
Fixes #50545 .
Built from https://develop.svn.wordpress.org/trunk@49504
git-svn-id: http://core.svn.wordpress.org/trunk@49259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 17:03:09 +00:00
Sergey Biryukov
87cdca8cd6
Docs: Change the `@since` entry for `template` and `template_lock` post type arguments to `5.0.0`.
...
These arguments were introduced with the initial block editor, but not documented previously.
Follow-up to [49495].
Props TimothyBlynJacobs.
See #46261 .
Built from https://develop.svn.wordpress.org/trunk@49496
git-svn-id: http://core.svn.wordpress.org/trunk@49255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 02:47:05 +00:00
Sergey Biryukov
096323d8a5
Docs: Add documentation for the `template_lock` argument to `register_post_type()`.
...
Add a `@since` entry for `template` and `template_lock` arguments.
Follow-up to [49041], [49492], [49494].
See #46261 .
Built from https://develop.svn.wordpress.org/trunk@49495
git-svn-id: http://core.svn.wordpress.org/trunk@49254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 02:32:08 +00:00
Sergey Biryukov
ec60115f2a
Docs: Adjust documentation for some `WP_Post_Type` properties:
...
* Split the summary for `$template` per the documentation standards. The summary should be a single sentence.
* Change the type for `$template_lock` to `string|false`, to clarify that `true` is not supported.
* Fix typo in `$delete_with_user` description, adjust for better readability.
Follow-up to [49041], [49492].
See #46261 .
Built from https://develop.svn.wordpress.org/trunk@49494
git-svn-id: http://core.svn.wordpress.org/trunk@49253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 02:30:09 +00:00
Sergey Biryukov
618fb979c6
Docs: Add a reference to `wp_insert_post()` for information on the arguments accepted by `wp_update_post()`.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@49493
git-svn-id: http://core.svn.wordpress.org/trunk@49252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 01:39:06 +00:00
noisysocks
4be65decb7
Editor: Add explicit template and template_lock attributes
...
Add and document the template and template_lock attributes on WP_Post_Type that
are used by the block editor.
Props metalandcoffee.
See #46261 .
Built from https://develop.svn.wordpress.org/trunk@49492
git-svn-id: http://core.svn.wordpress.org/trunk@49251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-04 01:05:10 +00:00
desrosj
107f669f15
Build/Test Tools: Disable update attempts while running unit tests.
...
This fixes an issue introduced in [49369] that causes l10n related tests to fail when the PHPUnit test suite is run multiple times without hints of the site being under version control.
[49369] removed the `.git` folder from the ZIP artifact created during the initial setup job. This ZIP file is used by the later jobs in the workflow that run the test suite. The absence of the `.git` folder in these later jobs caused the language packs initially loaded from `phpunit/data/languages` folder to be updated asynchronously, resulting in unexpected values when running the tests a second time.
This change disables all Core auto-update and asynchronous language pack update attempts when running PHPUnit tests.
Props ocean90, SergeyBiryukov.
See #50401 .
Fixes #51670 .
Built from https://develop.svn.wordpress.org/trunk@49491
git-svn-id: http://core.svn.wordpress.org/trunk@49250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-03 21:09:08 +00:00
desrosj
5392af9208
Upgrade/Install: Change the notice displayed after saving auto-update settings to `.notice-success`.
...
This better conveys the message of the notice and brings consistency with other success notices throughout Core.
Props audrasjb.
Fixes #51701 .
Built from https://develop.svn.wordpress.org/trunk@49490
git-svn-id: http://core.svn.wordpress.org/trunk@49249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-03 17:55:06 +00:00
John Blackbourn
3cee52b362
Docs: Add more information about how to use filters that run before WordPress initialises.
...
Fixes #50134
Built from https://develop.svn.wordpress.org/trunk@49489
git-svn-id: http://core.svn.wordpress.org/trunk@49248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-03 17:36:09 +00:00
John Blackbourn
238e69d9a6
Tests: Remove some useless assertions from the image editor tests.
...
In each of these instances the variable being tested is a directly instantiated object and can never be a `WP_Error`, unlike when `wp_get_image_editor()` is used.
See #51344
Built from https://develop.svn.wordpress.org/trunk@49488
git-svn-id: http://core.svn.wordpress.org/trunk@49247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-03 15:52:11 +00:00
Sergey Biryukov
a940c08357
Docs: Document the `$linkdata` parameter of `wp_insert_link()` using hash notation.
...
Props stevenlinx, peterwilsoncc.
Fixes #50853 .
Built from https://develop.svn.wordpress.org/trunk@49487
git-svn-id: http://core.svn.wordpress.org/trunk@49246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-03 03:52:10 +00:00
Helen Hou-Sandí
3b64a19eeb
Post-WordPress 5.6 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@49486
git-svn-id: http://core.svn.wordpress.org/trunk@49245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 21:22:04 +00:00
Helen Hou-Sandí
2f6286db83
WordPress 5.6 Beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@49485
git-svn-id: http://core.svn.wordpress.org/trunk@49244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 20:59:07 +00:00
Sergey Biryukov
1543954adc
Docs: Update description for the `$context` parameter of `sanitize_title()` and `sanitize_title_with_dashes()`.
...
This brings some consistency between the two DocBlocks and adjusts the latter one per the documentation standards.
Follow-up to [49482].
See #50569 .
Built from https://develop.svn.wordpress.org/trunk@49484
git-svn-id: http://core.svn.wordpress.org/trunk@49243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 20:20:07 +00:00
Helen Hou-Sandí
a3581edd84
Upgrade/Install: Update help tab text to include major WordPress updates.
...
Props audrasjb.
Fixes #51653 .
Built from https://develop.svn.wordpress.org/trunk@49483
git-svn-id: http://core.svn.wordpress.org/trunk@49242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 20:16:06 +00:00
Helen Hou-Sandí
f2875b6f7c
Formatting: Update docs for `$context` in `sanitize_title_with_dashes()`.
...
Props stevenlinx, audrasjb.
Fixes #50569 .
Built from https://develop.svn.wordpress.org/trunk@49482
git-svn-id: http://core.svn.wordpress.org/trunk@49241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 20:12:06 +00:00
desrosj
6a39c891b2
Customize: Ensure menu items expand horizontally on large screens.
...
Props clorith, garrett-eclipse.
Fixes #51647 .
Built from https://develop.svn.wordpress.org/trunk@49481
git-svn-id: http://core.svn.wordpress.org/trunk@49240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 20:07:05 +00:00
Helen Hou-Sandí
da4b76c6b3
Site Health: Site errors are for *this* site, not necessarily *your* site.
...
Props techboyg5, Clorith, audrasjb.
Fixes #51524 .
Built from https://develop.svn.wordpress.org/trunk@49480
git-svn-id: http://core.svn.wordpress.org/trunk@49239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 19:55:07 +00:00
Helen Hou-Sandí
be95ec2c27
About: Optimize freedoms sprite and add 2 column layout.
...
Props garrett-eclipse, ryelle.
Fixes #46363 .
Built from https://develop.svn.wordpress.org/trunk@49479
git-svn-id: http://core.svn.wordpress.org/trunk@49238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 19:46:14 +00:00
desrosj
e0669ddaae
Bundled Themes: Sync Twenty Twenty-One with the latest changes from GitHub.
...
For a full list of changes since [49330], see 5759e96...e7d5991
.
Props poena, luminuu, ryelle, kjellr, aristath, justinahinon, felipeelia, joostdevalk.
See #51526 .
Built from https://develop.svn.wordpress.org/trunk@49478
git-svn-id: http://core.svn.wordpress.org/trunk@49237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 19:45:07 +00:00
desrosj
e3a467a55a
Upgrade/Install: Prevent removal of additional data from plugin update info.
...
This switches to using `wp_parse_args()` instead of a combination of `array_merge()` and `array_intersect_key()` when ensuring that all expected default keys are present in the update information for a plugin.
This prevents non-default data returned by 3rd-party plugins from being unintentionally stripped out.
Props peterwilsoncc, chriscct7.
Fixes #51609 .
Built from https://develop.svn.wordpress.org/trunk@49477
git-svn-id: http://core.svn.wordpress.org/trunk@49236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 19:13:07 +00:00
Helen Hou-Sandí
409bd27659
Remove accidentally duplicated code introduced in [49475].
...
See #46536 .
Built from https://develop.svn.wordpress.org/trunk@49476
git-svn-id: http://core.svn.wordpress.org/trunk@49235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 19:09:09 +00:00
Helen Hou-Sandí
340c834fa3
Privacy: More precise checking of user request action names.
...
Props garrett-eclipse.
Fixes #46536 .
Built from https://develop.svn.wordpress.org/trunk@49475
git-svn-id: http://core.svn.wordpress.org/trunk@49234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 18:42:04 +00:00
Helen Hou-Sandí
cc74786052
General: Make some inline comments more descriptive.
...
Props jorbin.
Fixes #51683 .
Built from https://develop.svn.wordpress.org/trunk@49474
git-svn-id: http://core.svn.wordpress.org/trunk@49233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 18:04:07 +00:00
noisysocks
cfa1fb8c83
Editor: Update packages
...
@wordpress/block-directory@1.17.2
@wordpress/block-editor@5.1.2
@wordpress/block-library@2.26.2
@wordpress/edit-post@3.25.2
@wordpress/editor@9.24.2
@wordpress/format-library@1.25.2
@wordpress/reusable-blocks@1.0.2
Props isabel_brison.
See #51696 .
Built from https://develop.svn.wordpress.org/trunk@49473
git-svn-id: http://core.svn.wordpress.org/trunk@49232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 04:56:37 +00:00
Sergey Biryukov
f39fc10544
Docs: Use a consistent plural form of "status".
...
Props Collizo4sky, Presskopp, davidbaumwald.
Fixes #51690 .
Built from https://develop.svn.wordpress.org/trunk@49472
git-svn-id: http://core.svn.wordpress.org/trunk@49231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 01:38:07 +00:00
Sergey Biryukov
89ce61835d
Upgrade/Install: Switch "Check again" link on WordPress Updates screen to sentence case.
...
This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes.
Follow-up to [49150].
Props afercia.
See #51523 .
Built from https://develop.svn.wordpress.org/trunk@49471
git-svn-id: http://core.svn.wordpress.org/trunk@49230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-02 01:17:09 +00:00
Sergey Biryukov
7941c32ad3
Twenty Sixteen: Ensure the `<nav>` elements in widgets do not affect bottom margin.
...
Follow-up to [49208].
Props sabernhardt.
Fixes #51445 .
Built from https://develop.svn.wordpress.org/trunk@49470
git-svn-id: http://core.svn.wordpress.org/trunk@49229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-31 02:56:05 +00:00