Commit Graph

90 Commits

Author SHA1 Message Date
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Sergey Biryukov 203b275658 Bundled Themes: Change tag cloud format to a list (`<ul>`) for better semantics and accessibility.
List markup allows screen reader users to know in advance how many tags are within the list.

Props xkon, davidakennedy.
Fixes #40138.
Built from https://develop.svn.wordpress.org/trunk@41756


git-svn-id: http://core.svn.wordpress.org/trunk@41590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:53:47 +00:00
Peter Wilson 8db6c6c4ef Bundled theme: Add preconnect to fonts.gstatic.com in 2012-15 themes.
Add preconnect hinting for `https://fonts.gstatic.com` in the bundled themes using Google fonts. WordPress versions 4.7+ include a crossorigin attribute, earlier versions will not.

Props leobaiano, swissspidy, peterwilsoncc.
Fixes #37171.

Built from https://develop.svn.wordpress.org/trunk@38870


git-svn-id: http://core.svn.wordpress.org/trunk@38813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-23 01:56:32 +00:00
Tammie Lister ee20f7606b Remove .pot files from Default Themes
Fixes #34884
Props davidakennedy

Built from https://develop.svn.wordpress.org/trunk@38093


git-svn-id: http://core.svn.wordpress.org/trunk@38034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-18 14:33:31 +00:00
Weston Ruter f3f84d2f21 Customize: Require opt-in for selective refresh of widgets.
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.

Built from https://develop.svn.wordpress.org/trunk@37040


git-svn-id: http://core.svn.wordpress.org/trunk@37007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-21 21:59:29 +00:00
Weston Ruter f78775a6db Customize: Use selective refresh to preview changes to site title and tagline in core themes.
Fixes issue where `wptexturize` and other filters fail to apply when previewing changes via `postMessage` transport.

See #27355.
Fixes #33738.

Built from https://develop.svn.wordpress.org/trunk@36797


git-svn-id: http://core.svn.wordpress.org/trunk@36764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-01 22:18:26 +00:00
Dominik Schilling e5ea82d81a Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
Props obrienlabs, thewanderingbrit.
Fixes #34887.
Built from https://develop.svn.wordpress.org/trunk@36709


git-svn-id: http://core.svn.wordpress.org/trunk@36676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-25 12:53:27 +00:00
Konstantin Obenland 81df9bffc5 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.


Built from https://develop.svn.wordpress.org/trunk@32843


git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:51:26 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Lance Willett 078de57052 Twenty Twelve: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31261


git-svn-id: http://core.svn.wordpress.org/trunk@31242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 21:00:21 +00:00
Lance Willett 7d95c83257 Twenty Twelve and Thirteen: Use proper way to get customizer settings values.
Props obenland, kdoran. Fixes #29577.
Built from https://develop.svn.wordpress.org/trunk@30482


git-svn-id: http://core.svn.wordpress.org/trunk@30470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 17:06:23 +00:00
Lance Willett 8a0a5ce1d2 Twenty Twelve: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than `h3` for the toggle element. Fixes #28224, props rclations.
Built from https://develop.svn.wordpress.org/trunk@29095


git-svn-id: http://core.svn.wordpress.org/trunk@28881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 17:47:14 +00:00
Lance Willett 01e40fc6f7 Twenty Twelve: bump JS version after r28700 change. See #24767.
Built from https://develop.svn.wordpress.org/trunk@28702


git-svn-id: http://core.svn.wordpress.org/trunk@28519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-08 19:21:14 +00:00
Sergey Biryukov 2c97f4640b Prevent 'Page %s' from being added to page title on 404 error pages in bundled themes.
props psoluch, rob1n.
fixes #16468.
Built from https://develop.svn.wordpress.org/trunk@28250


git-svn-id: http://core.svn.wordpress.org/trunk@28078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:28 +00:00
Lance Willett 393381d3e4 Twenty Twelve: improve menu navigation for keyboard and voice-over interactions by properly focusing on submenu items when they are open. See #24839, props dannydehaan, joedolson, lancewillett.
Built from https://develop.svn.wordpress.org/trunk@27606


git-svn-id: http://core.svn.wordpress.org/trunk@27449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:29:16 +00:00
Lance Willett bba0e99688 Twenty Twelve: remove doc block comments for `@return void`. See #27098.
Built from https://develop.svn.wordpress.org/trunk@27599


git-svn-id: http://core.svn.wordpress.org/trunk@27442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:49:15 +00:00
Andrew Nacin c5802858cc Default themes: Use the 'display' filter for get_bloginfo( 'name' ) attached to the wp_title filter.
props michelwppi.
fixes #26811.

Built from https://develop.svn.wordpress.org/trunk@27091


git-svn-id: http://core.svn.wordpress.org/trunk@26963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-04 13:57:12 +00:00
Andrew Nacin 70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin 7115fa35af Translator comments are special, make sure they are parsed properly. see #25256.
Built from https://develop.svn.wordpress.org/trunk@25908


git-svn-id: http://core.svn.wordpress.org/trunk@25820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 20:29:09 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett 4a9b21226c Twenty Twelve: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25521


git-svn-id: http://core.svn.wordpress.org/trunk@25441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 19:24:09 +00:00
Lance Willett 6cd06ec784 Twenty Twelve: update post author comment markup and styles, improving hCard data parsing and simplifying styles. Fixes #23128.
git-svn-id: http://core.svn.wordpress.org/trunk@23716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 17:54:36 +00:00
Lance Willett 8415217e90 Twenty Twelve: load our special Google Font in the visual editor to improve user experience. Props to the Konstanthemes: kovshenin and obenland.
Closes #22499. See also r23672.

git-svn-id: http://core.svn.wordpress.org/trunk@23713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 17:09:12 +00:00
Lance Willett 76e80eaa86 Twenty Twelve: enable live preview for Header Text Color in Theme Customizer. Change also removes an `!important` declaration (yay) in Custom Header CSS rules.
Props SriniG, fixes #23600.

git-svn-id: http://core.svn.wordpress.org/trunk@23572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:45:59 +00:00
Lance Willett 5fb24acd2b Twenty Twelve: better handling for cases where a background color is set to white or an empty value (like first run with no `theme_mods` set) and a background image is enabled, which resulted previously in a broken layout. Fixes #23586, props obenland.
git-svn-id: http://core.svn.wordpress.org/trunk@23568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:59 +00:00
Lance Willett 62b51bff22 Twenty Twelve: remove unnecessary class values in posts navigation, fixes #23152. Props DrewAPicture.
git-svn-id: http://core.svn.wordpress.org/trunk@23427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 16:38:04 +00:00
Lance Willett 219716e101 Twenty Twelve: escape navigation ID output, props nacin. See #22690.
git-svn-id: http://core.svn.wordpress.org/trunk@22999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 20:12:22 +00:00
Lance Willett efda1483f7 Twenty Twelve: improve arrow display in comment reply text, props miqrogroove. Also consistent styles for edit link to match reply link in color and size. Closes #22468.
git-svn-id: http://core.svn.wordpress.org/trunk@22614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 21:22:17 +00:00
Lance Willett f3cfd63822 Bundled Themes: allow `show_home` argument to be overridden when using `wp_page_menu` as a fallback to a Custom Menu. Props SergeyBiryukov and kovshenin, fixes #22331.
git-svn-id: http://core.svn.wordpress.org/trunk@22359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-02 16:52:53 +00:00
Lance Willett 47cf131418 Twenty Twelve: remove invalid `pubdate` value from time elements. See #22095.
git-svn-id: http://core.svn.wordpress.org/trunk@22206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 23:39:24 +00:00
Lance Willett 46d77ee99c Twenty Twelve: implement better support for IE7 and IE8 (don't use mobile menu). See #22044.
git-svn-id: http://core.svn.wordpress.org/trunk@22201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 22:07:06 +00:00
Lance Willett 1692675bfc Twenty Twelve: better logic for on/off setting to be translated to turn off the font if translators explicitly say so. Also minor fixes to spelling and to use yoda comparison. Fixes #21751.
git-svn-id: http://core.svn.wordpress.org/trunk@22066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 17:44:54 +00:00
Andrew Nacin 584f39e365 Make a string not empty to it ends up in the POT file.
git-svn-id: http://core.svn.wordpress.org/trunk@22052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 07:38:16 +00:00
Andrew Nacin d68afd936e Simplify the Open Sans translator voodoo. see #21751.
git-svn-id: http://core.svn.wordpress.org/trunk@22049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 07:30:27 +00:00
Lance Willett 14996681b6 Twenty Twelve: allow translators to load extra character subsets for Open Sans font, props obenland. See #21751.
git-svn-id: http://core.svn.wordpress.org/trunk@22020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 20:05:12 +00:00
Lance Willett f480a3a792 Twenty Twelve: update comment blocks at top of each page template with a better explanation of use and purpose.
git-svn-id: http://core.svn.wordpress.org/trunk@22002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 19:58:33 +00:00
Lance Willett 56de945e68 Twenty Twelve: remove the word "Blog" from archive title, see #21951. Also remove from two comments in functions.php.
git-svn-id: http://core.svn.wordpress.org/trunk@21976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 18:33:09 +00:00
Lance Willett d7cbb45914 Twenty Twelve: remove `twentytwelve_frontpage_sidebar_class()` and make front page sidebar number filterable via `body_class`. Fixes #21942.
git-svn-id: http://core.svn.wordpress.org/trunk@21975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 16:57:42 +00:00
Lance Willett e538b8c697 Twenty Twelve: update navigation script to check for missing button and menu children earlier; allows an empty menu to be set without showing the button. See #21678.
git-svn-id: http://core.svn.wordpress.org/trunk@21929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 16:28:27 +00:00
Lance Willett 5f5984c491 Twenty Twelve: rename homepage template to front-page; including s/home/front-page/ in many places -- see notes in ticket. See #21909.
git-svn-id: http://core.svn.wordpress.org/trunk@21886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 17:28:36 +00:00
Lance Willett 1e33842a84 Twenty Twelve: allow Open Sans to be disabled per language, since it does not support all languages, and some odd combinations of OS and browser versions don't support any non-Latin language very well.
Props obenland and SergeyBiryukov for patches, fixes #21751.


git-svn-id: http://core.svn.wordpress.org/trunk@21882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-17 22:07:51 +00:00
Lance Willett 678847e6eb Twenty Twelve: hide author name on single author blogs, using `is_multi_author()` -- fixes #21759, props iamtakashi.
git-svn-id: http://core.svn.wordpress.org/trunk@21761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-05 04:33:55 +00:00
Lance Willett cc42ab537a Twenty Twelve: add support for Status post format. See #21743.
git-svn-id: http://core.svn.wordpress.org/trunk@21726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 05:00:19 +00:00
Lance Willett 0c8e14a3ad Twenty Twelve: move Open Sans custom font loading to a body class to allow easier overriding, fixes #21694.
* Use wp_style_is() to check for the enqueued CSS file before adding the body class value.
 * Add a sample dequeue method in the comments as documentation for child themers and their ilk.

Props viniciusmassuchetto, nacin, and obenland.


git-svn-id: http://core.svn.wordpress.org/trunk@21668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 16:59:22 +00:00
Lance Willett 8602864577 Twenty Twelve: use sidebar ID string value for sidebar checks instead of hard-coded integer, props nacin. See #21685.
git-svn-id: http://core.svn.wordpress.org/trunk@21643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 17:16:18 +00:00
Lance Willett 3922fe7686 Twenty Twelve: rename custom page templates and place in sub-directory. Closes #21715.
git-svn-id: http://core.svn.wordpress.org/trunk@21642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 17:12:10 +00:00
Lance Willett 5beee34612 Twenty Twelve: simplify custom font loading behavior, see #21694.
* Remove theme options code and support from theme.
 * Keep Open Sans font first in the stack and make it always loaded.
 * Move Customizer pieces from Theme Options out of class structure and into functions.php.


git-svn-id: http://core.svn.wordpress.org/trunk@21639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 02:18:43 +00:00
Lance Willett 61174d8cdf Twenty Twelve: consistently call sidebar areas with just the ID value, props obenland. See #21685.
git-svn-id: http://core.svn.wordpress.org/trunk@21620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 17:32:06 +00:00