Commit Graph

1600 Commits

Author SHA1 Message Date
Andrew Nacin e09094434e Restore captions for non-image attachments. see #22759.
git-svn-id: http://core.svn.wordpress.org/trunk@23087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:36:17 +00:00
Daryl Koopersmith c75dc67668 Do not alter the body's overflow attribute when the media modal is opened. Fix image insertion in the visual editor in Firefox. props azaozz. fixes #22765.
git-svn-id: http://core.svn.wordpress.org/trunk@23085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:15:39 +00:00
Bot (Assets) 4f3c1bb8f1 Compress scripts/styles: 3.5-RC3-23084.
git-svn-id: http://core.svn.wordpress.org/trunk@23084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:42:44 +00:00
Andrew Nacin 173806d7a1 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Bot (Assets) 7dab3d4538 Compress scripts/styles: 3.5-RC3-23080.
git-svn-id: http://core.svn.wordpress.org/trunk@23080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 21:22:59 +00:00
Ryan Boren 52a9a8cb81 Fix uploads in IE9
Props koopersmith
fixes #22762


git-svn-id: http://core.svn.wordpress.org/trunk@23079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 21:21:17 +00:00
Bot (Assets) 5927d8a3db Compress scripts/styles: 3.5-RC3-23078.
git-svn-id: http://core.svn.wordpress.org/trunk@23078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:22:54 +00:00
Andrew Nacin 88f61468b3 Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery".
Longer strings (such as a translation) looks excellent when it wraps to another line.

props markjaquith, fixes #22753.



git-svn-id: http://core.svn.wordpress.org/trunk@23076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:07:48 +00:00
Andrew Nacin c42ae7acb6 Media: Use '%d selected' for the selection string, and offer a comment to translators to help them find a workable solution with this would-be plural string. fixes #22749. see #22229.
git-svn-id: http://core.svn.wordpress.org/trunk@23075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:03:38 +00:00
Bot (Assets) fb433d2597 Compress scripts/styles: 3.5-RC3-23073.
git-svn-id: http://core.svn.wordpress.org/trunk@23073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:58:32 +00:00
Mark Jaquith bc8ddb3e64 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Mark Jaquith 4d35b3409b Implement tabbing between fields in the media modal. props lessbloat, koopersmith. fixes #22659
git-svn-id: http://core.svn.wordpress.org/trunk@23070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:57:58 +00:00
Mark Jaquith d8d39ff764 When setting the featured image from the dedicated meta box, only show the featured image section in the media chooser. props koopersmith. fixes #22731
* Less distracting
* Some of these sections won't apply for CPTs without an editor

git-svn-id: http://core.svn.wordpress.org/trunk@23069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:43:10 +00:00
Mark Jaquith e84a4a0c89 Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723
Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722

Both are props koopersmith

git-svn-id: http://core.svn.wordpress.org/trunk@23068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:25:17 +00:00
Mark Jaquith 98fb6e45d7 Use data on the ui.item to transport the original Sortable index for the update() function. This way extensions can set/access this info in their own custom Sortable functions. see #22696
git-svn-id: http://core.svn.wordpress.org/trunk@23067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:04:19 +00:00
Bot (Assets) 48382b4b0a Compress scripts/styles: 3.5-RC3-23066.
git-svn-id: http://core.svn.wordpress.org/trunk@23066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 04:58:33 +00:00
Ryan Boren c4d04dd476 Clear the From URL view in the media modal after inserting an image. Improve button enable checks.
Props koopersmith
fixes #22740


git-svn-id: http://core.svn.wordpress.org/trunk@23065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 04:43:51 +00:00
Mark Jaquith b6982a0804 Allow a sortable options hash to be passed in, so you can override the defaults. props koopersmith. see #22696
git-svn-id: http://core.svn.wordpress.org/trunk@23064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 04:11:49 +00:00
Bot (Assets) 1077e9ce03 Compress scripts/styles: 3.5-RC3-23059.
git-svn-id: http://core.svn.wordpress.org/trunk@23059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:58:34 +00:00
Andrew Nacin a914ab2e43 Media models: Trac and ignore deleted attachments.
Treat an admin-ajax response of 1 as successful for backwards compatibility with existing handlers.

props koopersmith. fixes #22750.



git-svn-id: http://core.svn.wordpress.org/trunk@23057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:31:41 +00:00
Andrew Nacin e1405b6f1d Media: Don't try to resize the bottom selection UI. props koopersmith. fixes #22748.
git-svn-id: http://core.svn.wordpress.org/trunk@23056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 01:38:44 +00:00
Andrew Nacin dc9e6144be Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720.
git-svn-id: http://core.svn.wordpress.org/trunk@23055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:59:25 +00:00
Bot (Assets) 87d43d7aa9 Compress scripts/styles: 3.5-RC3-23054.
git-svn-id: http://core.svn.wordpress.org/trunk@23054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:58:31 +00:00
Daryl Koopersmith 81d474cda0 Toggle display of plupload overlays when the select files button is hidden. see #22732.
git-svn-id: http://core.svn.wordpress.org/trunk@23053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:45:21 +00:00
Andrew Nacin d720772ef3 Media: Return to the library when the editing a selection and all items get de-selected. props koopersmith. fixes #22715.
git-svn-id: http://core.svn.wordpress.org/trunk@23051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:22:11 +00:00
Ryan Boren 51db7de93b When inserting an image From URL, show the fields only if it looks like we have a valid image.
Props koopersmith
fixes #22740


git-svn-id: http://core.svn.wordpress.org/trunk@23048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 23:07:41 +00:00
Bot (Assets) d3b24a0e15 Compress scripts/styles: 3.5-RC3-23047. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@23047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:44:27 +00:00
Ryan Boren c9db63ab1e When deleting an image in the editor with the delete or backspace keys, hide the edit and delete popup buttons.
Props azaozz, lessbloat
fixes #22717


git-svn-id: http://core.svn.wordpress.org/trunk@23046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:42:26 +00:00
Ryan Boren edf9769d26 In the media modal, clear attachment details when clearing the selection.
Props koopersmith
fixes #22718


git-svn-id: http://core.svn.wordpress.org/trunk@23045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:19:08 +00:00
Bot (Assets) 6cb358e0f4 Compress scripts/styles: 3.5-RC3-23043.
git-svn-id: http://core.svn.wordpress.org/trunk@23043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 20:58:33 +00:00
Andrew Nacin bd5956087a Media: When doing a multiple-insert into the editor, separate each inserted item with two line breaks. props tar.gz. see #22720.
git-svn-id: http://core.svn.wordpress.org/trunk@23042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 20:52:58 +00:00
Andrew Nacin d47267224c When adding images to a gallery, use "Images" as the filter name, rather than "All media items". props koopersmith. fixes #22722.
git-svn-id: http://core.svn.wordpress.org/trunk@23041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 20:51:37 +00:00
Bot (Assets) affabf29f4 Compress scripts/styles: 3.5-RC3-23040.
git-svn-id: http://core.svn.wordpress.org/trunk@23040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:56:16 +00:00
Andrew Ozz 48ef1a9784 RTL: properly align the demo image in the Edit Image popup, props nacin, fixes #22733
git-svn-id: http://core.svn.wordpress.org/trunk@23039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:51:35 +00:00
Andrew Nacin 1c5c724b3a Media: Properly select the select element's option in the attachment display settings. props koopersmith. fixes #22693.
git-svn-id: http://core.svn.wordpress.org/trunk@23037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:38:16 +00:00
Andrew Nacin 36554dd983 Move utils.js (cookie and user setting functions) to wp-includes to enable front-end use.
Make it a dependency of media-views (and therefore media-editor). Move its userSettings JS object from admin-header to being paired with the script in script loader.

see #22730.



git-svn-id: http://core.svn.wordpress.org/trunk@23036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:29:56 +00:00
Bot (Assets) 392ade0221 Compress scripts/styles: 3.5-RC3-23035.
git-svn-id: http://core.svn.wordpress.org/trunk@23035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:58:30 +00:00
Ryan Boren 53f5c1cdc7 Better dropdown select handling.
Props cdog, koopersmith
fixes #22693


git-svn-id: http://core.svn.wordpress.org/trunk@23033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:50:49 +00:00
Ryan Boren a200c702e0 Only show Delete in media modal if the user can delete.
Props nacin, koopersmith
fixes #22711


git-svn-id: http://core.svn.wordpress.org/trunk@23032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:33:51 +00:00
Ryan Boren 8603ed6082 Media: Hide "Edit" link in the selection view when it doesn't make sense
Props koopersmith, ocean90, nacin
fixes #22713


git-svn-id: http://core.svn.wordpress.org/trunk@23031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:23:47 +00:00
Bot (Assets) dad33047b5 Compress scripts/styles: 3.5-RC3-23030.
git-svn-id: http://core.svn.wordpress.org/trunk@23030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:13:59 +00:00
Mark Jaquith bc09152660 Fix a Firefox "scroll to bottom" bug when launching the media modal.
* Records main document scroll position when launching media modal.
* Restores position when media modal is closed.
* Also locks background document scrolling while media modal is open, preventing inadvertent scrolling there.

props koopersmith. fixes #22716

git-svn-id: http://core.svn.wordpress.org/trunk@23029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 17:58:24 +00:00
Mark Jaquith 82d51aeeef Update toolbars for Embed screen. Fixes JS error. props koopersmith. fixes #22714
git-svn-id: http://core.svn.wordpress.org/trunk@23028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 17:45:24 +00:00
Bot (Assets) 32c83140d0 Compress scripts/styles: 3.5-RC3-23025.
git-svn-id: http://core.svn.wordpress.org/trunk@23025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:25:14 +00:00
Andrew Nacin d2a9957ad8 Media: Disable 'Insert gallery' and 'Set featured image' if nothing is queued. Converts selection toolbars to use the newer view manager. props koopersmith, fixes #22714.
git-svn-id: http://core.svn.wordpress.org/trunk@23024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:21:57 +00:00
Bot (Assets) a1bb2f0054 Compress scripts/styles: 3.5-RC2-23018.
git-svn-id: http://core.svn.wordpress.org/trunk@23018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:58:31 +00:00
Mark Jaquith 55ac7a4565 Fix a typo in media-views.js that referenced frame.router.get() instead of frame.router. Fixes #22710
git-svn-id: http://core.svn.wordpress.org/trunk@23015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 05:18:21 +00:00
Bot (Assets) 6dee15c92e Compress scripts/styles: 3.5-RC2-23013.
git-svn-id: http://core.svn.wordpress.org/trunk@23013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:58:31 +00:00
Ryan Boren cbf378b601 Fix race condition in media insertion where the inserted html is invalid due to output being interleaved.
Props koopermsith
fixes #22696


git-svn-id: http://core.svn.wordpress.org/trunk@23012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:38:42 +00:00
Andrew Nacin 156c5fef0f Media: When an image does not have all image sizes available, make sure we insert the requested size into the editor. props koopersmith. fixes #22693.
git-svn-id: http://core.svn.wordpress.org/trunk@23008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:04:45 +00:00
Bot (Assets) 30cf064068 Compress scripts/styles: 3.5-RC2-23007. props koopersmith. :-)
git-svn-id: http://core.svn.wordpress.org/trunk@23007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:29:58 +00:00
Ryan Boren 61a9471024 Final round of media UX improvements.
Props koopersmith
fixes #21390 #22502


git-svn-id: http://core.svn.wordpress.org/trunk@23006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:26:03 +00:00
Andrew Nacin 9ba411d918 Alternative Text, not Alternate Text. props SergeyBiryukov. fixes #21176.
git-svn-id: http://core.svn.wordpress.org/trunk@22996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 19:21:34 +00:00
Bot (Assets) 293cfac069 Compress scripts/styles: 3.5-RC2-22995.
git-svn-id: http://core.svn.wordpress.org/trunk@22995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 08:09:10 +00:00
Ryan Boren 63662a9b7b In the QuickPress media modal, use the new post id when a post is published.
Props nacin, koopersmith
fixes #22673


git-svn-id: http://core.svn.wordpress.org/trunk@22994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:17:10 +00:00
Ryan Boren 0848a51955 When settting a featured image, move the currently selected image to the beginning of the library if it doesn't exist within the attachments loaded so far.
Props koopersmith
fixes #22494


git-svn-id: http://core.svn.wordpress.org/trunk@22993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:04:34 +00:00
Bot (Assets) 8ca0066e3a Compress scripts/styles: 3.5-RC2-22992.
git-svn-id: http://core.svn.wordpress.org/trunk@22992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 06:53:58 +00:00
Ryan Boren c06ffe745f Show a spinner when attachment details are saved.
Props koopersmith
see #22613


git-svn-id: http://core.svn.wordpress.org/trunk@22991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 06:37:49 +00:00
Ryan Boren 01adc2740e Show Select Files button the first time the media modal is opened.
Props koopermsith
fixes #22691


git-svn-id: http://core.svn.wordpress.org/trunk@22990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 06:32:25 +00:00
Bot (Assets) b8a9b78359 Compress scripts/styles: 3.5-RC2-22988.
git-svn-id: http://core.svn.wordpress.org/trunk@22988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 05:42:30 +00:00
Ryan Boren 23ed804180 Add random and reverse sorting options to gallery settings.
Props koopersmith
fixes #22637


git-svn-id: http://core.svn.wordpress.org/trunk@22987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 05:32:25 +00:00
Andrew Nacin 6d711428b4 Media: Don't add menu_order to newly uploaded attachments, to match 3.4 behavior. Reverts a bit of [22967]. props koopersmith. fixes #22607.
git-svn-id: http://core.svn.wordpress.org/trunk@22985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 04:54:03 +00:00
Ryan Boren b382901778 Update gallery editing to work with the modal changes. Add nice handling for default states.
Props koopersmith
see #21776


git-svn-id: http://core.svn.wordpress.org/trunk@22984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 04:38:10 +00:00
Andrew Nacin 5d0933d884 Bring Featured Images back into the main media dialog.
Most users don't realize that the Featured Image meta box exists; if they do, few use it.

Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.

Specific underlying changes:
 * Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
 * Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.

props koopersmith.
fixes #21776.



git-svn-id: http://core.svn.wordpress.org/trunk@22979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:38:10 +00:00
Bot (Assets) 904306e1ce Compress scripts/styles: 3.5-RC2-22975.
git-svn-id: http://core.svn.wordpress.org/trunk@22975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 19:49:31 +00:00
Andrew Nacin d8c942f26c `wp.media` instead of just `media`. props alexkingorg, see #22676.
git-svn-id: http://core.svn.wordpress.org/trunk@22974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 19:24:22 +00:00
Bot (Assets) 7677c12566 Compress scripts/styles: 3.5-RC2-22973.
git-svn-id: http://core.svn.wordpress.org/trunk@22973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:57:38 +00:00
Andrew Nacin 06e2e684dd Use wp.media, not media, in media-editor.js. see #22676.
git-svn-id: http://core.svn.wordpress.org/trunk@22972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:55:58 +00:00
Bot (Assets) cc0a122a7a Compress scripts/styles: 3.5-RC2-22971.
git-svn-id: http://core.svn.wordpress.org/trunk@22971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:50:10 +00:00
Andrew Nacin a5549c1d16 Avoid leaking the 'media' var into the global JS namespace. props koopersmith, fixes #22676.
git-svn-id: http://core.svn.wordpress.org/trunk@22968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:32:47 +00:00
Andrew Nacin 27bf82201b Allow the 'Uploaded to this post' view to be sorted, saving the resulting order as menu_order.
This functionality is designed to be backwards compatible with manual querying for attachments by menu_order.

props koopersmith.
see #22607.



git-svn-id: http://core.svn.wordpress.org/trunk@22967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:06:31 +00:00
Bot (Assets) 3cfc81b328 Compress scripts/styles: 3.5-RC2-22966.
git-svn-id: http://core.svn.wordpress.org/trunk@22966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 04:35:23 +00:00
Ryan Boren ebe9cd7395 In the media modal, show the Link To: url.
Props nacin
fixes #22662


git-svn-id: http://core.svn.wordpress.org/trunk@22965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 00:43:08 +00:00
Bot (Assets) f80e842fe6 Compress scripts/styles: 3.5-RC2-22958.
git-svn-id: http://core.svn.wordpress.org/trunk@22958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 17:41:19 +00:00
Ryan Boren af42700ebd Resolve race conditions in Attachments.more().
Props koopersmith
fixes #22656


git-svn-id: http://core.svn.wordpress.org/trunk@22957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 16:45:43 +00:00
Ryan Boren 59456a9cea Resolve race conditions in Attachments.more(). Provides for smoother refreshes when searching and properly cleans out content components.
Props koopersmith
fixes #22656


git-svn-id: http://core.svn.wordpress.org/trunk@22956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 16:41:38 +00:00
Bot (Assets) 41db8c91ff Compress scripts/styles: 3.5-RC2-22953. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:20:51 +00:00
Ryan Boren f07c7f5163 Refine media state machine methods.
* state( id ) becomes setState( id )
* get( id ) becomes state( id )
* state() stays the same
* previous() becomes lastState()

Props koopersmith
fixes #22652


git-svn-id: http://core.svn.wordpress.org/trunk@22952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:19:11 +00:00
Ryan Boren b73c43e0e2 Update the "Uploaded to this post" filter view when uploading new files.
* Add an Attachments collection filter for uploadedTo (post_parent).
* Correct an erroneous map from the non-existent parent prop to post_parent.
* Define default menuOrder and uploadedTo props for uploading attachments.
* Unify filterable props into a single method (improving validation performance for calls to set with multiple properties).

Props koopersmith
fixes #22654


git-svn-id: http://core.svn.wordpress.org/trunk@22951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:11:44 +00:00
Bot (Assets) 0924e6facd Compress scripts/styles: 3.5-RC2-22949.
git-svn-id: http://core.svn.wordpress.org/trunk@22949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:52:16 +00:00
Ryan Boren d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Andrew Nacin 5d9fcc48b6 Pressing escape now closes the media modal. props koopersmith, see #22502.
git-svn-id: http://core.svn.wordpress.org/trunk@22946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 08:37:17 +00:00
Ryan Boren e656d19a30 Improve switching between browser and upload state.
Props koopersmith
fixes #22628


git-svn-id: http://core.svn.wordpress.org/trunk@22945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 06:01:47 +00:00
Bot (Assets) 1e8f12020b Compress scripts/styles: 3.5-RC2-22944.
git-svn-id: http://core.svn.wordpress.org/trunk@22944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 05:39:13 +00:00
Ryan Boren 180476bbf8 Correctly insert images at caret position in IE8/7.
Props lessbloat
fixes #22638


git-svn-id: http://core.svn.wordpress.org/trunk@22943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 04:54:09 +00:00
Ryan Boren c9cf1508a6 In the edit image modal, move Title to the advanced section and move Caption above Alt.
Props nacin
fixes #22646


git-svn-id: http://core.svn.wordpress.org/trunk@22942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 04:09:17 +00:00
Ryan Boren a986fd1509 In the media modal, ensure modal events are always fired on its frame. This ensures restoreThickbox() and thus tbRemove() are called properly when clicking the close button of the modal.
Props koopersmith
fixes #22632


git-svn-id: http://core.svn.wordpress.org/trunk@22938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 01:55:37 +00:00
Ryan Boren fccd72a74b In the add media modal, fallback back to caption if alt is not set. Falback to title if neither caption nor alt are set.
Props koopersmith
see #18984


git-svn-id: http://core.svn.wordpress.org/trunk@22937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 01:38:41 +00:00
Bot (Assets) 626778aaf0 Compress scripts/styles: 3.5-RC2-22928.
git-svn-id: http://core.svn.wordpress.org/trunk@22928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 22:09:26 +00:00
Andrew Nacin f77c427703 Send the alt attribute when sending attachments to the editor. fixes #22640.
git-svn-id: http://core.svn.wordpress.org/trunk@22927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 21:23:55 +00:00
Bot (Assets) 688654c793 Compress scripts/styles: 3.5-RC1-22924.
git-svn-id: http://core.svn.wordpress.org/trunk@22924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 17:00:38 +00:00
Ryan Boren 5f7f9c5520 Revert accidental bits from r22919. see #22628
git-svn-id: http://core.svn.wordpress.org/trunk@22923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 16:58:08 +00:00
Bot (Assets) 53bdcd5b63 Compress scripts/styles: 3.5-RC1-22922.
git-svn-id: http://core.svn.wordpress.org/trunk@22922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 16:17:06 +00:00
Ryan Boren 7188bff165 Icons for select, deselect, and window close in the media modal.
Props JerrySarcastic, helenyhou, ocean90, lessbloat
fixes #22610


git-svn-id: http://core.svn.wordpress.org/trunk@22919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 13:33:57 +00:00
Andrew Nacin 818e2f3980 Update TinyMCE Spellchecker plugin to 2.0.6.1.
git-svn-id: http://core.svn.wordpress.org/trunk@22917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 02:45:16 +00:00
Bot (Assets) 6e073cc850 Compress scripts/styles: 3.5-RC1-22913.
git-svn-id: http://core.svn.wordpress.org/trunk@22913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 01:37:15 +00:00
Ryan Boren c71519f791 In the gallery editor, don't stomp on custom shortcode attributes.
Props koopersmith
fixes #22627


git-svn-id: http://core.svn.wordpress.org/trunk@22912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 01:06:21 +00:00
Bot (Assets) cbd32060e8 Compress scripts/styles: 3.5-RC1-22909.
git-svn-id: http://core.svn.wordpress.org/trunk@22909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:58:34 +00:00
Ryan Boren a5253fd686 Media modal: Don't fire two AJAX calls on settings update.
Props koopersmith
fixes #22611


git-svn-id: http://core.svn.wordpress.org/trunk@22907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:27:13 +00:00
Andrew Ozz 632d0a0571 Media in Internet Explorer: ensure we save the caret bookmark for IE in TinyMCE for the right instance, fixes #22446
git-svn-id: http://core.svn.wordpress.org/trunk@22905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 21:45:10 +00:00
Bot (Assets) 51b6b2189b Compress scripts/styles: 3.5-RC1-22901.
git-svn-id: http://core.svn.wordpress.org/trunk@22901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 18:58:34 +00:00
Andrew Nacin 38b46e44ea Media: Rename the dialog to 'Add Media' from 'Insert Media' to match the button. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 17:18:50 +00:00
Bot (Assets) 041ebd374c Compress scripts/styles: 3.5-RC1-22893.
git-svn-id: http://core.svn.wordpress.org/trunk@22893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 04:58:34 +00:00
Andrew Nacin bffb901334 Check if the object is empty, as objects are always truthy. props koopersmith. see #22593.
git-svn-id: http://core.svn.wordpress.org/trunk@22892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 04:41:24 +00:00
Bot (Assets) 2b4da9e635 Compress scripts/styles: 3.5-RC1-22890.
git-svn-id: http://core.svn.wordpress.org/trunk@22890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 02:33:43 +00:00
Andrew Nacin 32c57c6b6a Media: Remove the link to the browser uploader. The only need for it is large files (> 100MB) in certain browsers (IE, Opera), so we will show the link then only. fixes #22604.
git-svn-id: http://core.svn.wordpress.org/trunk@22889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 02:28:10 +00:00
Andrew Nacin b70cb2d284 Ensure attachment modal details are saved before the attachment details view is destroyed. props koopersmith. fixes #22593.
git-svn-id: http://core.svn.wordpress.org/trunk@22888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 02:03:31 +00:00
Bot (Assets) b538c8bd45 Compress scripts/styles: 3.5-RC1-22885. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 00:58:44 +00:00
Andrew Nacin c09ac0e931 Editor: When hiding gallery/image editing buttons, use Sizzle rather than TinyMCE's internal DOM object. Avoids errors in case the elements do not exist, such as in Press This. props azaozz. fixes #22463.
git-svn-id: http://core.svn.wordpress.org/trunk@22883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 23:36:07 +00:00
Andrew Nacin dd3cd96bac When editing a plain, legacy [gallery] shortcode, ensure we are sorting its contents using menu_order.
When attachments are sorted, we convert the shortcode to [gallery ids=""], as before.

props koopersmith.
fixes #22608.



git-svn-id: http://core.svn.wordpress.org/trunk@22882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 23:20:12 +00:00
Bot (Assets) f940c40302 Compress scripts/styles: 3.5-RC1-22879. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 20:58:37 +00:00
Andrew Nacin e2bc567095 Media in Internet Explorer: Properly insert attachments into the editor at the location of the cursor. props azaozz. fixes #22446.
git-svn-id: http://core.svn.wordpress.org/trunk@22877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 19:24:56 +00:00
Andrew Nacin 45ce9d2a96 Media: Introduce wp.media.editor.open(editor_id) and leverage it in distraction-free writing (fullscreen). props azaozz, koopersmith. fixes #22541.
git-svn-id: http://core.svn.wordpress.org/trunk@22875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 19:09:00 +00:00
Bot (Assets) 735c64c965 Compress scripts/styles: 3.5-RC1-22873.
git-svn-id: http://core.svn.wordpress.org/trunk@22873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:58:37 +00:00
Ryan Boren cc9b248937 Always send nocache_headers() for admin-ajax.php. This prevents iOS from caching ajax calls. http://stackoverflow.com/questions/12506897/is-safari-on-ios-6-caching-ajax-results
Turn off multi selection uploads for mobile devices. Currently Plupload cannot upload multiple files in iOS Safari. Only the first file makes it to the queue. 

Empty wp on unload to work around caching in iOS Safari.

Props azaozz, miqrogroove, nacin

fixes #22552


git-svn-id: http://core.svn.wordpress.org/trunk@22872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:17:53 +00:00
Ryan Boren 939a47ba48 Add a delete link to the media modal.
Props merty, nacin, koopersmith
fixes #22524


git-svn-id: http://core.svn.wordpress.org/trunk@22869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:50:59 +00:00
Ryan Boren 2c1d52526a Don't use "embed" when referring to inserting from URL.
Props nacin
fixes #22603


git-svn-id: http://core.svn.wordpress.org/trunk@22868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:35:36 +00:00
Ryan Boren 555a87db2f Back compat $_REQUEST['post_id'] for media XHR requests.
Props koopersmith, nacin.
fixes #22588


git-svn-id: http://core.svn.wordpress.org/trunk@22865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 14:58:08 +00:00
Bot (Assets) c33e862097 Compress scripts/styles: 3.5-RC1-22860. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 02:58:50 +00:00
Andrew Ozz 3fd9321c91 TinyMCE: improve hiding of the image/gallery popup buttons, fix selecting a gallery in IE, don't leave empty paragraph after deleting an image with the popup button, fixes #22463, see #21390
git-svn-id: http://core.svn.wordpress.org/trunk@22857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 01:31:51 +00:00
Bot (Assets) 4e2fbb27de Compress scripts/styles: 3.5-RC1-22852.
git-svn-id: http://core.svn.wordpress.org/trunk@22852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:58:43 +00:00
Ryan Boren a6bba833d4 Rename 'id' to 'state' in menu item view.
Props koopersmith
fixes #22594


git-svn-id: http://core.svn.wordpress.org/trunk@22851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:49:45 +00:00
Ryan Boren 7df6a903f5 In wp.media.editor:send, revert back to the old field names used by media_upload_form_handler() for easier back compat.
Fix notices in wp_ajax_send_attachment_to_editor().

Props nacin, azaozz, miqrogroove
fixes #22553


git-svn-id: http://core.svn.wordpress.org/trunk@22847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:08:50 +00:00
Bot (Assets) 34ce6db507 Compress scripts/styles: 3.5-RC1-22844.
git-svn-id: http://core.svn.wordpress.org/trunk@22844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 16:58:36 +00:00
Andrew Nacin ab5c08a120 Media: When inserting an attachment, if the item is unattached (no post_parent), attach it to the post. fixes #22085.
git-svn-id: http://core.svn.wordpress.org/trunk@22843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 16:34:42 +00:00
Ryan Boren 2105efa5bf Correctly access the nonce to save attachment fields. Fixes firing attachment_fields_to_save.
Props koopersmith
fixes #22577


git-svn-id: http://core.svn.wordpress.org/trunk@22842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 15:07:36 +00:00
Ryan Boren 7469f91bc7 Always render the attachment compat view. Assures attachment_fields_to_edit is always fired.
Props koopersmith, Chouby
fixes #22578


git-svn-id: http://core.svn.wordpress.org/trunk@22841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 15:05:14 +00:00
Bot (Assets) a4c7232ce6 Compress scripts/styles: 3.5-RC1-22839.
git-svn-id: http://core.svn.wordpress.org/trunk@22839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:47:40 +00:00
Andrew Nacin 24d68b3bcf Media: Watch more events for input changes to catch paste, autocomplete, etc.
Fixes issue where pasting a URL in 'From URL' (via the context menu) did not
enable the insert button, as the event was not yet fired.

props koopersmith.
fixes #22545.



git-svn-id: http://core.svn.wordpress.org/trunk@22836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:35:28 +00:00
Andrew Nacin 951082d4da Media: Include the link URL when inserting non-image attachments. props koopersmith. fixes #22544.
git-svn-id: http://core.svn.wordpress.org/trunk@22835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:33:30 +00:00
Daryl Koopersmith 43587773a5 jQuery UI 1.9.2. props ocean90. fixes #22563.
git-svn-id: http://core.svn.wordpress.org/trunk@22833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 01:20:40 +00:00
Bot (Assets) cc5b452797 Compress scripts/styles: 3.5-beta3-22826.
git-svn-id: http://core.svn.wordpress.org/trunk@22826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 12:58:32 +00:00
Daryl Koopersmith 5f25155408 Media: Use a full uploader status view in the inline uploader. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 12:54:49 +00:00
Daryl Koopersmith 27e8de7e3a Media: Add uploader error detection to the inline uploader view as well. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 12:35:05 +00:00
Daryl Koopersmith c5991558be Media: Properly render any pre-existing upload errors in the uploader status. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 12:24:54 +00:00
Daryl Koopersmith 14af860aab Uploader: Display a more specific error message when a file exceeds the file size limit. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 12:18:17 +00:00
Daryl Koopersmith 440ec7ef3d Media: Make friends with media_upload_form. Adds notices for browser incompatibility, upload limits, maximum file size, and large file issues to the uploader. fixes #22243, see #22186, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 11:46:03 +00:00
Bot (Assets) 2430f0f974 Compress scripts/styles: 3.5-beta3-22819.
git-svn-id: http://core.svn.wordpress.org/trunk@22820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 10:58:36 +00:00
Daryl Koopersmith 688b8de348 Media: Display WordPress and plupload error messages whenever an upload fails. see #22243, #22186, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 10:56:10 +00:00
Daryl Koopersmith 1e472d8974 Media: Add global upload progress to the sidebar. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:32:21 +00:00
Bot (Assets) 2f47959b2d Compress scripts/styles: 3.5-beta3-22810.
git-svn-id: http://core.svn.wordpress.org/trunk@22810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 06:58:42 +00:00
Daryl Koopersmith e63ef3a443 Media: Move sidebar from the frame view to the attachment browser view. Prevents juggling sidebar visibility state, and makes managing sidebar contents more reasonable. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 06:30:25 +00:00
Bot (Assets) 3006ca6a6c Compress scripts/styles: 3.5-beta3-22808.
git-svn-id: http://core.svn.wordpress.org/trunk@22808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 04:58:35 +00:00
Daryl Koopersmith 98494fdfe1 Media: Check to see if we need more attachments when the browser is attached to the DOM. fixes #22480, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 03:19:08 +00:00
Bot (Assets) b0ee4d8dda Compress scripts/styles: 3.5-beta3-22805.
git-svn-id: http://core.svn.wordpress.org/trunk@22805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 02:58:33 +00:00
Daryl Koopersmith f80e93ebf8 Media: Convert the attachments browser to use internal views. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 01:43:31 +00:00
Bot (Assets) adad154f6b Compress scripts/styles: 3.5-beta3-22803.
git-svn-id: http://core.svn.wordpress.org/trunk@22803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 00:58:36 +00:00
Daryl Koopersmith de54f9318f Media: Make priority list views leverage the subview management class. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 00:41:39 +00:00
Bot (Assets) 3be0694d83 Compress scripts/styles: 3.5-beta3-22801.
git-svn-id: http://core.svn.wordpress.org/trunk@22801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 22:58:36 +00:00
Jon Cave 38e43334a9 Set svn:eol-style to native for all the files
(Except wp-config-sample.php and a couple of license files)


git-svn-id: http://core.svn.wordpress.org/trunk@22798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 22:31:55 +00:00