Dion Hulse
7090cf8980
Updates: When performing an ajax plugin update, rely upon `wp_update_plugins()` to check the contents of the transient and return early if no request needs to be made.
...
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Merges [33257] to the 4.2 branch.
Fixes #32198 for 4.2
Built from https://develop.svn.wordpress.org/branches/4.2@33258
git-svn-id: http://core.svn.wordpress.org/branches/4.2@33230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 08:04:27 +00:00
Dion Hulse
63f64d5909
Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
...
Ports [33055] to the 4.2 branch
Fixes #32127 for 4.2.3
Built from https://develop.svn.wordpress.org/branches/4.2@33063
git-svn-id: http://core.svn.wordpress.org/branches/4.2@33034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 12:44:28 +00:00
Dion Hulse
61122743e2
Don't upgrade global tables to utf8mb4 when `DO_NOT_UPGRADE_GLOBAL_TABLES` is defined.
...
This change also standardises on only checking `DO_NOT_UPGRADE_GLOBAL_TABLES` is defined, not it's value.
Fixes #32154 for 4.2
Built from https://develop.svn.wordpress.org/branches/4.2@33059
git-svn-id: http://core.svn.wordpress.org/branches/4.2@33030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 05:59:27 +00:00
Dion Hulse
371db8aea1
Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
...
Fixes a warning during updating from 4.0 or earlier.
Merges [32852] to the 4.2 branch. Fixes #31388 for 4.2
Built from https://develop.svn.wordpress.org/branches/4.2@32853
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:20:30 +00:00
Gary Pendergast
ca13bd76d5
Upgrades: If a table has already been converted to `utf8mb4`, there's no need to try and convert it again.
...
Props gabrielperezs for the initial patch.
Merge of [32456] to the 4.2 branch.
Fixes #32310 .
Built from https://develop.svn.wordpress.org/branches/4.2@32457
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 12:28:28 +00:00
Michael Adams
ba2de1e736
Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
...
Props jorbin, et alii.
Merges [32440] for the 4.2 branch.
See #32165 .
Built from https://develop.svn.wordpress.org/branches/4.2@32441
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-07 01:12:29 +00:00
Michael Adams
ff4c5d2767
Upgrade: `$wpdb->get_col_length()` sanity check: bail on unexpected return value.
...
See #32165 .
Built from https://develop.svn.wordpress.org/branches/4.2@32430
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 23:12:27 +00:00
Michael Adams
f3d41b7b38
Upgrade: Ensure unintelligible DB schemas don't result in content loss.
...
Merge of [32417] to the 4.2 branch.
See #32165 .
Props ocean90.
Built from https://develop.svn.wordpress.org/branches/4.2@32418
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 21:50:29 +00:00
Aaron Jorbin
ca97837cf3
When upgrading WordPress remove genericons example.html files
...
[32385] for 4.2 branch
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin
Built from https://develop.svn.wordpress.org/branches/4.2@32386
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 18:39:28 +00:00
Gary Pendergast
5c01870b62
Upgrades: When converting to `utf8mb4`, we were trying to change the wrong index on `wp_signups`, causing the conversion to later fail.
...
Merge [32378] to the 4.2 branch.
Props kovshenin, pento.
Fixes #32099 .
Built from https://develop.svn.wordpress.org/branches/4.2@32380
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:42:28 +00:00
Gary Pendergast
db8f915ee6
WPDB: When checking that a string can be sent to MySQL, we shouldn't use `mb_convert_encoding()`, as it behaves differently to MySQL's character encoding conversion.
...
Merge of [32364] to the 4.2 branch.
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.
See #32165 .
Built from https://develop.svn.wordpress.org/branches/4.2@32367
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 03:30:30 +00:00
Dion Hulse
4202e36193
When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop.
...
Props hnle, taka2. Fixes #32135 . See #31811
Merges [32322] to the 4.2 branch.
Built from https://develop.svn.wordpress.org/branches/4.2@32324
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-29 03:20:29 +00:00
Gary Pendergast
a3a76fe665
4.2: When upgrading, remove any suspicious comments.
...
Built from https://develop.svn.wordpress.org/branches/4.2@32311
git-svn-id: http://core.svn.wordpress.org/branches/4.2@32282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 17:10:29 +00:00
Dominik Schilling
89e45feb4c
Don't focus input fields outside of the request filesystem credentials form.
...
props valendesigns.
fixes #32055 .
Built from https://develop.svn.wordpress.org/trunk@32266
git-svn-id: http://core.svn.wordpress.org/trunk@32237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:24:26 +00:00
Dominik Schilling
e0657e6904
Don't return empty themes in `wp_prepare_themes_for_js()`.
...
see #32002 .
Built from https://develop.svn.wordpress.org/trunk@32264
git-svn-id: http://core.svn.wordpress.org/trunk@32235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:11:25 +00:00
Andrew Ozz
60706015e1
Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
...
Props iseulde. Fixes #31139 , fixes #32006 .
Built from https://develop.svn.wordpress.org/trunk@32258
git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 22:41:26 +00:00
Helen Hou-Sandí
1d1c026e8e
Rename the `pre_wp_prepare_themes_for_js` filter to `pre_prepare_themes_for_js`.
...
props DrewAPicture.
fixes #31789 .
Built from https://develop.svn.wordpress.org/trunk@32246
git-svn-id: http://core.svn.wordpress.org/trunk@32217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:23:27 +00:00
Gary Pendergast
e3f1f8fed1
Ensure post titles are correctly escaped on the Dashboard.
...
Props helen, ocean90, dd32, pento.
Built from https://develop.svn.wordpress.org/trunk@32175
git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
Sergey Biryukov
7f48138743
Press This: Update documentation for `press_this_save_redirect` filter after [31992].
...
props kraftbj.
fixes #31996 .
Built from https://develop.svn.wordpress.org/trunk@32143
git-svn-id: http://core.svn.wordpress.org/trunk@32123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-19 01:34:28 +00:00
Dominik Schilling
786bce5b9c
Customizer: Escape theme preview URLs.
...
props johnbillion, ocean90.
see #31896 .
Built from https://develop.svn.wordpress.org/trunk@32134
git-svn-id: http://core.svn.wordpress.org/trunk@32113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 16:33:25 +00:00
Scott Taylor
5e4616039c
Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
...
Props iseulde, ocean90.
Fixes #31912 .
Built from https://develop.svn.wordpress.org/trunk@32125
git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 15:31:28 +00:00
Andrew Ozz
fe150b9ef2
Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
...
Props kraftbj. Fixes #31968 .
Built from https://develop.svn.wordpress.org/trunk@32122
git-svn-id: http://core.svn.wordpress.org/trunk@32101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 05:45:28 +00:00
Dominik Schilling
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Gary Pendergast
0179958273
When `dbDelta()` is checking whether an index is defined in a `CREATE TABLE` statement, don't worry if MySQL has a subpart defined on an index, but the `CREATE TABLE` doesn't.
...
Fixes #31869 .
Built from https://develop.svn.wordpress.org/trunk@32108
git-svn-id: http://core.svn.wordpress.org/trunk@32087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-11 10:40:31 +00:00
Andrew Ozz
ad475b3c69
Press This: check the bookmarklet version and add the update notice from PHP.
...
Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32106
git-svn-id: http://core.svn.wordpress.org/trunk@32085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-10 21:08:29 +00:00
Andrew Ozz
0d4b29ffb9
Press This: add ARIA attributes to the `alerts` container.
...
Props afercia. Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32102
git-svn-id: http://core.svn.wordpress.org/trunk@32081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 23:45:27 +00:00
Andrew Ozz
9db5bac3c4
Press This: change the link text to Standard Editor.
...
Props Michael-Arestad. See #31923 .
Built from https://develop.svn.wordpress.org/trunk@32093
git-svn-id: http://core.svn.wordpress.org/trunk@32072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:28:25 +00:00
Andrew Ozz
33a0022773
Press This:
...
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923 .
Built from https://develop.svn.wordpress.org/trunk@32092
git-svn-id: http://core.svn.wordpress.org/trunk@32071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:14:28 +00:00
Boone Gorges
54a6a8e137
Don't allow whitespace-only image captions from the Media modal.
...
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.
Fixes #21848 .
Built from https://develop.svn.wordpress.org/trunk@32079
git-svn-id: http://core.svn.wordpress.org/trunk@32058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:11:27 +00:00
Aaron Jorbin
abfddb8f3e
Update placeholder for FTP credentials
...
Two changes:
* Remove superfluous __ function call
* Update domain used
Fixes #31922
Props Tmeister
Built from https://develop.svn.wordpress.org/trunk@32077
git-svn-id: http://core.svn.wordpress.org/trunk@32056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:50:27 +00:00
Aaron Jorbin
99d6c67148
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32062
git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
Helen Hou-Sandí
42028327a2
Insert from URL: Make sure the link text is actually used.
...
Turns out there were more pieces to renaming the field.
props iseulde.
fixes #29476 .
Built from https://develop.svn.wordpress.org/trunk@32055
git-svn-id: http://core.svn.wordpress.org/trunk@32034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 18:25:27 +00:00
Helen Hou-Sandí
bfda508c18
Update more instances of default admin blues and grays.
...
props hugobaeta.
fixes #31234 .
Built from https://develop.svn.wordpress.org/trunk@32051
git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Sergey Biryukov
443760252b
`wp_install_maybe_enable_pretty_permalinks()` should have a consistent `@return` value.
...
props DrewAPicture.
fixes #6481 . see #31888 .
Built from https://develop.svn.wordpress.org/trunk@32027
git-svn-id: http://core.svn.wordpress.org/trunk@32006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:49:53 +00:00
Drew Jaynes
ba1e7a7243
Correct grammar when referring to "a user" vs "an user" in several places.
...
Props ocean90.
Fixes #31894 .
Built from https://develop.svn.wordpress.org/trunk@32025
git-svn-id: http://core.svn.wordpress.org/trunk@32004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:44:27 +00:00
Drew Jaynes
7c3e469326
Clarify the DocBlock summary and parameter description for `wp_edit_attachments_query_vars()`.
...
See [31037]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32019
git-svn-id: http://core.svn.wordpress.org/trunk@31998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:52:25 +00:00
Drew Jaynes
6ccba88ea5
Add proper descriptions for the `@global` and `@param` tags in the `wp_media_attach_action()` DocBlock.
...
See [31619]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32018
git-svn-id: http://core.svn.wordpress.org/trunk@31997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:35:25 +00:00
Drew Jaynes
02810a305f
Clarify the DocBlock description for `wp_print_request_filesystem_credentials_modal()`.
...
See [31811]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32016
git-svn-id: http://core.svn.wordpress.org/trunk@31995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:13:26 +00:00
Drew Jaynes
654ee78c93
Clarify 4.2.0 changelog entry, add global description to the DocBlock for `WP_Users_List_Table->single_row()`.
...
See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32015
git-svn-id: http://core.svn.wordpress.org/trunk@31994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:09:27 +00:00
Drew Jaynes
e82de7ef27
Add missing `@since` versions from a variety of methods in `WP_Press_This`.
...
See [31693]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32014
git-svn-id: http://core.svn.wordpress.org/trunk@31993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 19:46:26 +00:00
Drew Jaynes
7b89119eee
Add missing DocBlocks for the `_limit_array()`, `_limit_string()`, `_limit_url()`, `_limit_img()`, `_limit_embed()`, and `_process_meta_entry()` utility methods in `WP_Press_This`.
...
See [31609]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32013
git-svn-id: http://core.svn.wordpress.org/trunk@31992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 18:23:26 +00:00
Drew Jaynes
0306f2c011
Fix filter doc vernacular for the `quick_edit_show_taxonomy` filter.
...
See [31308]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32011
git-svn-id: http://core.svn.wordpress.org/trunk@31990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:08:26 +00:00
Drew Jaynes
4239756a47
Fix syntax for the `$to_display` parameter description in the DocBlock for `WP_Posts_List_Table->_page_rows()`.
...
See [31730]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32010
git-svn-id: http://core.svn.wordpress.org/trunk@31989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:04:28 +00:00
Drew Jaynes
8a3b21aad5
Add a return description to the DocBlock for `WP_Posts_List_Table->is_base_request()`.
...
See [31828]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32009
git-svn-id: http://core.svn.wordpress.org/trunk@31988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 16:01:27 +00:00
Drew Jaynes
b500d3e978
Fix typos in the function summaries for `wp_ajax_press_this_save_post()` and `wp_ajax_press_this_add_category()`.
...
See [31534]. See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32007
git-svn-id: http://core.svn.wordpress.org/trunk@31986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:38:26 +00:00
Drew Jaynes
05fa6879ce
Add an `@see` mention for `Plugin_Upgrader`, plus spacing to the `wp_ajax_update_plugin()` delcaration.
...
See #31888 .
Built from https://develop.svn.wordpress.org/trunk@32006
git-svn-id: http://core.svn.wordpress.org/trunk@31985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:19:27 +00:00
Boone Gorges
62450e9f0f
After [31114] and [31323], 'View Post' generated in `get_sample_permalink_html()` should go to pretty permalink.
...
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.
Fixes #30910 .
Built from https://develop.svn.wordpress.org/trunk@32002
git-svn-id: http://core.svn.wordpress.org/trunk@31981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 01:27:28 +00:00
Sergey Biryukov
247fdbfe19
Remove hidden `user_id` input from `wp_comment_reply()`.
...
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.
See [31776] for Edit Comment screen.
props dllh.
fixes #30307 .
Built from https://develop.svn.wordpress.org/trunk@31999
git-svn-id: http://core.svn.wordpress.org/trunk@31978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 13:28:26 +00:00
Andrew Ozz
05a549723c
Press This:
...
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875 .
Built from https://develop.svn.wordpress.org/trunk@31992
git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:34:26 +00:00
John Blackbourn
d05236f756
Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
...
See #31770 .
Built from https://develop.svn.wordpress.org/trunk@31991
git-svn-id: http://core.svn.wordpress.org/trunk@31970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 00:18:27 +00:00