Commit Graph

2338 Commits

Author SHA1 Message Date
Scott Taylor 34e3377d42 JSHint after [29437].
Built from https://develop.svn.wordpress.org/trunk@29439


git-svn-id: http://core.svn.wordpress.org/trunk@29217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:21:16 +00:00
Scott Taylor 8c96874742 Media Grid:
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.

Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29438


git-svn-id: http://core.svn.wordpress.org/trunk@29216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:01:15 +00:00
Scott Taylor ccd0499d96 Media Grid: use a `media.view.Label` instance in the toolbar for the screen reader text for Search.
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29437


git-svn-id: http://core.svn.wordpress.org/trunk@29215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:54:15 +00:00
Helen Hou-Sandí 485229bc64 Revert styling changes to the Attachment Details modal from [29289]. fixes #28844.
Built from https://develop.svn.wordpress.org/trunk@29436


git-svn-id: http://core.svn.wordpress.org/trunk@29214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:32:16 +00:00
Scott Taylor 8593f7b5e9 Media Grid: add screen reader text in a subview on the toolbar, a `media.view.Label` instance before `media.view.DateFilter`.
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29435


git-svn-id: http://core.svn.wordpress.org/trunk@29213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:25:16 +00:00
Scott Taylor 3f17e7040e Create a new Backbone view, `media.view.Label`, which can be used as a subview in things like toolbars, which need screen reader text.
Make an initial instance of it for the label for Bulk Actions in Media Grid.

See #29026.

Built from https://develop.svn.wordpress.org/trunk@29434


git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:09:17 +00:00
Scott Taylor c5dff42d51 Revert [29428] to avoid errors with Add Media for now.
See #29026.

Built from https://develop.svn.wordpress.org/trunk@29432


git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 19:40:15 +00:00
Scott Taylor afb0b3e4ef Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
Props afercia.
Fixes #29026.

Built from https://develop.svn.wordpress.org/trunk@29428


git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
Scott Taylor f0f4174ed8 Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].
See #28819.

Built from https://develop.svn.wordpress.org/trunk@29427


git-svn-id: http://core.svn.wordpress.org/trunk@29205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:03:17 +00:00
Scott Taylor 8ed123c97f In `media.view.AttachmentFilters.All`, make `uploaded` conditional upon `media.view.settings.post.id` and include a new filter: `unattached`.
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead. 

Props ocean90, wonderboymusic.
Fixes #29065.

Built from https://develop.svn.wordpress.org/trunk@29426


git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00
Scott Taylor 935f10413e Media Grid: expose the `$.Deffered()` object in `media.view.AttachmentsBrowser.updateContent()` so the grid can call `Backbone.history.start()` when models actually exist.
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.

Built from https://develop.svn.wordpress.org/trunk@29420


git-svn-id: http://core.svn.wordpress.org/trunk@29198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 21:44:17 +00:00
Scott Taylor a58a4da852 Media Grid: display upload errors in a dismissable sidebar.
See #29037.

Built from https://develop.svn.wordpress.org/trunk@29415


git-svn-id: http://core.svn.wordpress.org/trunk@29193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 19:13:15 +00:00
Scott Taylor 27b0d4cd20 In `media.view.BulkSelectionActionButton.click()`, do not assume that `delete` is the only possible bulk action.
Fixes #29101.

Built from https://develop.svn.wordpress.org/trunk@29403


git-svn-id: http://core.svn.wordpress.org/trunk@29181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:24:19 +00:00
Andrew Ozz b61903f2bb TinyMCE: add support for `class` attribute on the caption shortcode. Part props knutsp, kadamwhite, fixes #28951.
Built from https://develop.svn.wordpress.org/trunk@29380


git-svn-id: http://core.svn.wordpress.org/trunk@29158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 00:58:16 +00:00
Andrew Ozz 8fc01225ac Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29379


git-svn-id: http://core.svn.wordpress.org/trunk@29157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 19:37:15 +00:00
Andrew Ozz e6b0d0c9ee Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423.
Built from https://develop.svn.wordpress.org/trunk@29376


git-svn-id: http://core.svn.wordpress.org/trunk@29154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-05 05:20:18 +00:00
Andrew Ozz 666fec5144 TinyMCE: fix alignment buttons when used on image with caption. Remove old/unneeded code. Fixes #28705.
Built from https://develop.svn.wordpress.org/trunk@29370


git-svn-id: http://core.svn.wordpress.org/trunk@29148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 00:52:17 +00:00
Andrew Ozz 42c8135fac Mobile: hide the onscreen keyboard when the media modal opens, fixes #28549.
Built from https://develop.svn.wordpress.org/trunk@29369


git-svn-id: http://core.svn.wordpress.org/trunk@29147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 22:34:16 +00:00
Scott Taylor 27890cc734 Media Grid: don't blow away the Attachment Details modal every time a new model is loaded.
Props ericlewis.
Fixes #29104.

Built from https://develop.svn.wordpress.org/trunk@29368


git-svn-id: http://core.svn.wordpress.org/trunk@29146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:40:17 +00:00
Scott Taylor 696c12bc55 Media Grid: don't select `body` with jQuery when instantiating `media.view.UploaderWindow`.
Props ericlewis.
See #28965.

Built from https://develop.svn.wordpress.org/trunk@29367


git-svn-id: http://core.svn.wordpress.org/trunk@29145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-03 19:37:19 +00:00
Dominik Schilling e6513fe33b Media Modal: Restore uploader view, when no items are found.
see #28963.
Built from https://develop.svn.wordpress.org/trunk@29364


git-svn-id: http://core.svn.wordpress.org/trunk@29140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:47:16 +00:00
Andrew Ozz 9662554bfb Add blog_id to the `wp-settings-*` cookie (used for storing user state) to prevent it being overloaded on sub-domain sites. Fixes #29095.
Built from https://develop.svn.wordpress.org/trunk@29362


git-svn-id: http://core.svn.wordpress.org/trunk@29138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 20:09:16 +00:00
Dominik Schilling fb9084eed3 Disable background page scrolling when modals are open.
props celloexpressions.
fixes #29074.
Built from https://develop.svn.wordpress.org/trunk@29346


git-svn-id: http://core.svn.wordpress.org/trunk@29124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:15:15 +00:00
Mark Jaquith 61a0551529 Match background color in DFW and adapt the dashed outline color.
fixes #28330. props avryl, ipstenu.
Built from https://develop.svn.wordpress.org/trunk@29340


git-svn-id: http://core.svn.wordpress.org/trunk@29120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 18:10:16 +00:00
Andrew Ozz b9886e92e3 Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.
Built from https://develop.svn.wordpress.org/trunk@29336


git-svn-id: http://core.svn.wordpress.org/trunk@29116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 02:43:17 +00:00
Andrew Ozz 2dda137191 wpLink: add custom open and close events, props bradyvercher, fixes #28095.
Built from https://develop.svn.wordpress.org/trunk@29335


git-svn-id: http://core.svn.wordpress.org/trunk@29115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 02:04:17 +00:00
Andrew Ozz d15f9617f9 wpLink:
- Fix adding a link on pressing Enter.
- Don't auto-focus the URL field after selecting a local link.
- Don't auto-focus the URL field when opening on touch devices. Toggle focus/blur on it to close the onscreen keyboard so the modal is positioned properly.
See #28897.
Built from https://develop.svn.wordpress.org/trunk@29333


git-svn-id: http://core.svn.wordpress.org/trunk@29113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-31 23:28:19 +00:00
Andrew Ozz 4bff4ff2d6 Use node.nodeName instead of tagName for better consistency/compatibility, see #28704.
Built from https://develop.svn.wordpress.org/trunk@29332


git-svn-id: http://core.svn.wordpress.org/trunk@29112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-30 17:49:16 +00:00
Helen Hou-Sandí 2ca11ebf72 Prevent key event handlers from firing when in input areas in the media modal, as people understandably want to type inside said inputs. props kovshenin. fixes #28704.
Built from https://develop.svn.wordpress.org/trunk@29331


git-svn-id: http://core.svn.wordpress.org/trunk@29111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-30 17:39:15 +00:00
Sergey Biryukov 0c2fe96a31 Media Grid: Close the modal if the attachment is deleted.
props ericlewis.
fixes #28819.
Built from https://develop.svn.wordpress.org/trunk@29322


git-svn-id: http://core.svn.wordpress.org/trunk@29103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 14:58:19 +00:00
Andrew Ozz 77599cd99b wpLink: add keyboard navigation, improve accessibility. Props afercia, fixes #28897.
Built from https://develop.svn.wordpress.org/trunk@29321


git-svn-id: http://core.svn.wordpress.org/trunk@29102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 03:16:17 +00:00
Andrew Ozz c8cec032ae TinyMCE:
- Use `data-wp-*` for processing and styling of the `more` and `nextpage` placeholders, keep the class names for back-compat. Makes them "immune" to "Clear formatting".
- Translate the titles of the placeholders.
Fixes #28772.
Built from https://develop.svn.wordpress.org/trunk@29317


git-svn-id: http://core.svn.wordpress.org/trunk@29098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-28 23:45:18 +00:00
Dominik Schilling 7bbbbe44c7 Media Grid: Improve lazy loading.
props kovshenin.
see #24716.
Built from https://develop.svn.wordpress.org/trunk@29312


git-svn-id: http://core.svn.wordpress.org/trunk@29093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 17:58:15 +00:00
Dominik Schilling 9c77f419f6 Fix jshint errors introduced in [29284] and [29299].
Built from https://develop.svn.wordpress.org/trunk@29306


git-svn-id: http://core.svn.wordpress.org/trunk@29088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 11:49:15 +00:00
Dominik Schilling ab151eca85 Media Grid: Ignore user setting for `content`.
fixes #29034.
Built from https://develop.svn.wordpress.org/trunk@29305


git-svn-id: http://core.svn.wordpress.org/trunk@29087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-27 11:44:18 +00:00
Andrew Ozz b9f97e8352 TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.

Built from https://develop.svn.wordpress.org/trunk@29302


git-svn-id: http://core.svn.wordpress.org/trunk@29084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-26 00:08:19 +00:00
Helen Hou-Sandí f3ede5702e Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.
Built from https://develop.svn.wordpress.org/trunk@29301


git-svn-id: http://core.svn.wordpress.org/trunk@29083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 15:57:16 +00:00
Scott Taylor 0e4c8b2b0c Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.

Built from https://develop.svn.wordpress.org/trunk@29299


git-svn-id: http://core.svn.wordpress.org/trunk@29081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 01:00:16 +00:00
Andrew Ozz 9436186ee4 TinyMCE wpView:
- Fix opening the media modal on clicking Edit in Firefox.
- Fix range errors when restoring the selection bookmark in IE11 after editing a view.
See #28595.
Built from https://develop.svn.wordpress.org/trunk@29298


git-svn-id: http://core.svn.wordpress.org/trunk@29080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-25 00:56:15 +00:00
Scott Taylor 27866228af Media Grid: UI improvements to Attachment modal.
Props ryelle.
See #28844.

Built from https://develop.svn.wordpress.org/trunk@29289


git-svn-id: http://core.svn.wordpress.org/trunk@29071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 21:55:17 +00:00
Scott Taylor 9382741cbe Don't render Attachment Display Settings when `display` is set to `false`. Currently, the value for `display` in the `media.view.AttachmentsBrowser` instance in the `media.view.MediaFrame.Select` frame is set to the value for `displaySettings`.
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.

Built from https://develop.svn.wordpress.org/trunk@29285


git-svn-id: http://core.svn.wordpress.org/trunk@29067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:58:16 +00:00
Scott Taylor 78518beb6b When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.
`wp.media.collection` has a new method to do this: `setDefaults()`.	Also flips the use of `_.extend` to allow this method to be overriden on instance creation.

See #28693.

Built from https://develop.svn.wordpress.org/trunk@29284


git-svn-id: http://core.svn.wordpress.org/trunk@29066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 20:00:16 +00:00
Scott Taylor 5be43cfeb1 Media Grid: Manage focus when toggling between the grid and an edit attachment modal
Props adamsilverstein for the initial patch.
Fixes #28857.

Built from https://develop.svn.wordpress.org/trunk@29282


git-svn-id: http://core.svn.wordpress.org/trunk@29064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 19:05:15 +00:00
Andrew Ozz da0b98a8f0 Editor scrolling:
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29279


git-svn-id: http://core.svn.wordpress.org/trunk@29061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 01:33:15 +00:00
Helen Hou-Sandí 795c97d08b Add support for `attachment_fields_to_edit` in the attachment details modal. props ericlewis. fixes #28991, see #24716.
Built from https://develop.svn.wordpress.org/trunk@29278


git-svn-id: http://core.svn.wordpress.org/trunk@29060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 22:09:18 +00:00
Scott Taylor cb2d88a092 After [29179], remove the last instance of `this.isCompatibleSrc()`.
Props kovshenin.
See #28905.


Built from https://develop.svn.wordpress.org/trunk@29277


git-svn-id: http://core.svn.wordpress.org/trunk@29059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-23 17:54:15 +00:00
Andrew Ozz 8e973f2c29 wpView: make sure the editor is focused before selecting/deselecting a view, or IE may throw an invalid range error, see #28595.
Built from https://develop.svn.wordpress.org/trunk@29273


git-svn-id: http://core.svn.wordpress.org/trunk@29055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 21:53:16 +00:00
Andrew Ozz c40feac4d9 wpView: consolidate pausePlayers() and unsetPlayers(), they are almost the same. Prevent errors when instead of a player ME.js shows only a "Download File" placeholder (in IE). See #28905.
Built from https://develop.svn.wordpress.org/trunk@29272


git-svn-id: http://core.svn.wordpress.org/trunk@29054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 21:49:16 +00:00
Dominik Schilling 270a57075c Media Grid: Add a date filter.
props ericlewis.
fixes #28895.
Built from https://develop.svn.wordpress.org/trunk@29271


git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:47:15 +00:00
Scott Taylor 0702527010 Media Grid: general JS cleanup.
Props ericlewis.
See #28965.


Built from https://develop.svn.wordpress.org/trunk@29266


git-svn-id: http://core.svn.wordpress.org/trunk@29049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 16:21:15 +00:00