Commit Graph

22 Commits

Author SHA1 Message Date
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Dominik Schilling e5ea82d81a Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
Props obrienlabs, thewanderingbrit.
Fixes #34887.
Built from https://develop.svn.wordpress.org/trunk@36709


git-svn-id: http://core.svn.wordpress.org/trunk@36676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-25 12:53:27 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Lance Willett c25f0ae8f8 Twenty Thirteen: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31260


git-svn-id: http://core.svn.wordpress.org/trunk@31241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 20:49:22 +00:00
Dominik Schilling 120cb5e6ef Improve keyboard accessibility on Custom Header and Custom Background screen.
props florianziegler.
fixes #29289.
Built from https://develop.svn.wordpress.org/trunk@30327


git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:00:57 +00:00
Lance Willett 6db0275b95 Twenty Thirteen: adjust background size of header image(s) for small devices. Props senlin, fixes #26856.
Built from https://develop.svn.wordpress.org/trunk@28701


git-svn-id: http://core.svn.wordpress.org/trunk@28518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-08 19:13:14 +00:00
Lance Willett cd72dc041b Twenty Thirteen: update to Genericons 3.0.3. Props celloexpressions, lancewillett. Closes #25391.
Built from https://develop.svn.wordpress.org/trunk@28693


git-svn-id: http://core.svn.wordpress.org/trunk@28511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-06 18:22:14 +00:00
Lance Willett 4305c85fb2 Twenty Thirteen: remove doc block comments for `@return void`. See #27098.
Built from https://develop.svn.wordpress.org/trunk@27598


git-svn-id: http://core.svn.wordpress.org/trunk@27441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:48:29 +00:00
Lance Willett 9001d030f3 Twenty Thirteen: use correct font name in comment docs, props tenpura. Fixes #25593.
Built from https://develop.svn.wordpress.org/trunk@25789


git-svn-id: http://core.svn.wordpress.org/trunk@25701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 16:47:09 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett d373d0982b Twenty Thirteen: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25522


git-svn-id: http://core.svn.wordpress.org/trunk@25442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 19:34:10 +00:00
Andrew Nacin 43016b8948 Twenty Thirteen: Ensure custom headers are set up after the localization is initialized.
props pavelevap.
fixes #24943.

Built from https://develop.svn.wordpress.org/trunk@25129


git-svn-id: http://core.svn.wordpress.org/trunk@25109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-26 19:29:09 +00:00
Ryan Boren 44fca1dc57 Allow absolute URLs in editor styles.
Props nacin, obenland
fixes #24787


git-svn-id: http://core.svn.wordpress.org/trunk@24735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 18:11:43 +00:00
Lance Willett 8492d3b680 Twenty Thirteen: remove `hgroup` from the theme markup structure since it's been dropped from HTML5 spec. Props obenland for the starter patch. Fixes #24114.
git-svn-id: http://core.svn.wordpress.org/trunk@24072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-23 17:55:55 +00:00
Andrew Nacin 1f64b5abd0 Add .displaying-header-text to the default themes, as the Custom Header page toggles this class. props obenland, fixes #24113.
git-svn-id: http://core.svn.wordpress.org/trunk@24050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:40:28 +00:00
Lance Willett 245c2111f0 Bundled themes: add identifier to `style` elements added by the theme. Fixes #24033.
git-svn-id: http://core.svn.wordpress.org/trunk@24001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 17:18:30 +00:00
Lance Willett 92852af835 Twenty Thirteen: fix toggling header text display in Customizer. Props obenland, fixes #23722.
git-svn-id: http://core.svn.wordpress.org/trunk@23670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 16:52:30 +00:00
Lance Willett 10d48f7478 Twenty Thirteen: remove redundant `esc_url()` calls, props SergeyBiryukov, fixes #23663.
git-svn-id: http://core.svn.wordpress.org/trunk@23642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 17:18:02 +00:00
Lance Willett 511180da68 Twenty Thirteen: CSS fixes to change single to double quotes, proper quoting around font-family names, and add a missing escape to a background image in custom-header.php. Props markmcwilliams, fixes #23653.
git-svn-id: http://core.svn.wordpress.org/trunk@23557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:40:29 +00:00
Lance Willett 4ba9ccd643 Twenty Thirteen: header area with no site title or tagline should still be clickable to home. Fixes #23549.
Fix also removes several `!important` flags that aren't necessary, relating to header text color.

git-svn-id: http://core.svn.wordpress.org/trunk@23492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-26 04:50:09 +00:00
Mark Jaquith d1d3076d5a Introduce the Twenty Thirteen theme.
props matt, joen, obenland, lancewillett. see #23504

git-svn-id: http://core.svn.wordpress.org/trunk@23452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-18 23:08:56 +00:00