Scott Taylor
2c42a665a2
`wp.media.view.Button` should create `<button>`s, not `<a href="#">`s.
...
Props afercia.
See #32236 .
Built from https://develop.svn.wordpress.org/trunk@32464
git-svn-id: http://core.svn.wordpress.org/trunk@32434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:39:27 +00:00
Scott Taylor
a417b2cf1a
In `EmbedLink`, a URL needs to be at least 11 chars to be useful.
...
Fixes #32059 .
Built from https://develop.svn.wordpress.org/trunk@32463
git-svn-id: http://core.svn.wordpress.org/trunk@32433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:30:26 +00:00
Scott Taylor
b7d4685f3d
When creating an `EmbedLink` view, don't add a spinner - it already exists in `Embed`.
...
Use the value of `wp.media.controller.Embed.sensitivity` as the sensitivity value for the debounced method in `EmbedLink` to ensure that the spinner toggles don't stutter or overlap.
Fixes #32036 .
Built from https://develop.svn.wordpress.org/trunk@32462
git-svn-id: http://core.svn.wordpress.org/trunk@32432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:10:26 +00:00
Scott Taylor
af326241ff
When fetching in `media/views/embed/link.js`, call `abort()` on any existing XHRs.
...
Use `$.ajax` instead of `wp.ajax.send()` to allow this.
Pass `this` as `context` to the options to remove the need to bind callbacks.
Fixes #32035 .
Built from https://develop.svn.wordpress.org/trunk@32460
git-svn-id: http://core.svn.wordpress.org/trunk@32430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 19:16:25 +00:00
Scott Taylor
31f46f5363
In `media/views/embed/link.js`, URLs should have a valid protocol before an attempt to fetch them is made.
...
Fixes #32037 .
Built from https://develop.svn.wordpress.org/trunk@32459
git-svn-id: http://core.svn.wordpress.org/trunk@32429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 18:34:28 +00:00
Scott Taylor
2807b7146f
After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
...
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.
See #31139 .
Built from https://develop.svn.wordpress.org/trunk@32330
git-svn-id: http://core.svn.wordpress.org/trunk@32301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 21:40:25 +00:00
Andrew Ozz
60706015e1
Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
...
Props iseulde. Fixes #31139 , fixes #32006 .
Built from https://develop.svn.wordpress.org/trunk@32258
git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 22:41:26 +00:00
Helen Hou-Sandí
a581c9851a
Media: Date filtering does not need to be on for all contexts.
...
Affected areas include customizer upload controls and video playlist editing.
props ocean90.
fixes #32004 .
Built from https://develop.svn.wordpress.org/trunk@32228
git-svn-id: http://core.svn.wordpress.org/trunk@32202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 19:49:24 +00:00
Scott Taylor
5e4616039c
Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
...
Props iseulde, ocean90.
Fixes #31912 .
Built from https://develop.svn.wordpress.org/trunk@32125
git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 15:31:28 +00:00
Scott Taylor
6cb16f7a21
Remove unused media JS files.
...
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31405
git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 22:45:28 +00:00
Andrew Ozz
71885dceca
Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392 .
...
Built from https://develop.svn.wordpress.org/trunk@31117
git-svn-id: http://core.svn.wordpress.org/trunk@31098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:47:29 +00:00
Sergey Biryukov
e53b581817
Remove non-functional date filter from Edit Selection view in media modal.
...
props tyxla.
fixes #30931 .
Built from https://develop.svn.wordpress.org/trunk@31096
git-svn-id: http://core.svn.wordpress.org/trunk@31077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 18:23:23 +00:00
Scott Taylor
fb454239fb
In Media Views, use `this.listenTo( this.model, .... )` instead of `this.model.on( .... )` to fix garbage collection and to avoid "ghost views."
...
Fixes #30896 .
Built from https://develop.svn.wordpress.org/trunk@31045
git-svn-id: http://core.svn.wordpress.org/trunk@31026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 05:25:22 +00:00
Scott Taylor
e678f9d051
In Media Grid, don't immediately load full size images if the requested size passed to `wp.media.view.Attachment.imageSize()` does not exist, look for other suitable sizes.
...
Fixes #30861 .
Built from https://develop.svn.wordpress.org/trunk@31039
git-svn-id: http://core.svn.wordpress.org/trunk@31020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 21:32:23 +00:00
Dominik Schilling
4652717828
Customizer: Remove date filter from the Header/Background Image upload frames.
...
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].
see #30689 .
Built from https://develop.svn.wordpress.org/trunk@30872
git-svn-id: http://core.svn.wordpress.org/trunk@30862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 20:27:22 +00:00
Dominik Schilling
93078d7d9f
Fix JSHint error introduced in [30780].
...
see #30608 .
Built from https://develop.svn.wordpress.org/trunk@30792
git-svn-id: http://core.svn.wordpress.org/trunk@30782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 22:07:24 +00:00
Andrew Ozz
31990810f4
Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608 .
...
Built from https://develop.svn.wordpress.org/trunk@30780
git-svn-id: http://core.svn.wordpress.org/trunk@30770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 21:12:21 +00:00
Scott Taylor
845e8ab23d
When using the spacebar to select something in "bulk select" mode, don't scroll the page.
...
Props avryl.
Fixes #30622 .
Built from https://develop.svn.wordpress.org/trunk@30777
git-svn-id: http://core.svn.wordpress.org/trunk@30767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:11:43 +00:00
John Blackbourn
389811b3ec
Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager.
...
Fixes #29934
See #24352
Props jessepollak
Built from https://develop.svn.wordpress.org/trunk@30686
git-svn-id: http://core.svn.wordpress.org/trunk@30676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 04:18:23 +00:00
Scott Taylor
67e5d4041c
When deleting media grid attachments, wait until the server responds before removing the model from its collection.
...
Props 5um17.
Fixes #30457 .
Built from https://develop.svn.wordpress.org/trunk@30638
git-svn-id: http://core.svn.wordpress.org/trunk@30628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 06:19:23 +00:00
Helen Hou-Sandí
6225c63cf1
Media a11y: Don't set role=checkbox for the attachment details view.
...
Some unnecessary attributes were inherited from the attachment view, which created difficulties with screen readers.
fixes #30390 .
Built from https://develop.svn.wordpress.org/trunk@30483
git-svn-id: http://core.svn.wordpress.org/trunk@30471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 17:15:23 +00:00
Dominik Schilling
12b2ca45ad
Simplify selectors in [30374].
...
props wonderboymusic, adamsilverstein.
see #29326 .
Built from https://develop.svn.wordpress.org/trunk@30461
git-svn-id: http://core.svn.wordpress.org/trunk@30452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 15:37:22 +00:00
John Blackbourn
e2a0c6a86d
Improve keyboard control of Edit Selection mode in the media manager.
...
See #29326
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@30374
git-svn-id: http://core.svn.wordpress.org/trunk@30371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-18 03:34:25 +00:00
Scott Taylor
d5a9d63114
Improve `wp.media` documentation.
...
Props ericlewis.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@30245
git-svn-id: http://core.svn.wordpress.org/trunk@30245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:39:22 +00:00
Scott Taylor
8fa0755584
Add some docs to `wp.media.view.EditorUploader`.
...
Props ericlewis.
See #29951 .
Built from https://develop.svn.wordpress.org/trunk@30234
git-svn-id: http://core.svn.wordpress.org/trunk@30234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:48:23 +00:00
Scott Taylor
7eefc4d1e1
JSHint after [30124].
...
Built from https://develop.svn.wordpress.org/trunk@30125
git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:38:21 +00:00
Scott Taylor
a6cb067481
JSHint after [30120].
...
Built from https://develop.svn.wordpress.org/trunk@30124
git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:35:22 +00:00
Dominik Schilling
2e76a697f6
Fix JSHint errors introduced in [30120].
...
see #30193 .
Built from https://develop.svn.wordpress.org/trunk@30123
git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:28:24 +00:00
Scott Taylor
999e0fbd99
Add verbose docs to `media-views.js`.
...
Props ericlewis.
See #30193 .
Built from https://develop.svn.wordpress.org/trunk@30120
git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 15:20:23 +00:00
Scott Taylor
fb019893f9
In `wp.Uploader`, when `uploader:ready` is triggered, set `ready` to `true` on the instance. This allows media workflows to check for an existing uploaded instance when opening.
...
Without this check, workflows might wait for `uploader:ready`, which could already have been fired. This would result in an unresponsive editor dropzone.
Fixes #29689 .
Built from https://develop.svn.wordpress.org/trunk@29917
git-svn-id: http://core.svn.wordpress.org/trunk@29669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 05:54:18 +00:00
Andrew Ozz
7f2f3dcb5d
Media modal: fix reordering of the thumbnails while creating or editing a gallery, props avryl, fixes #29606 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29876
git-svn-id: http://core.svn.wordpress.org/trunk@29633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-11 23:24:23 +00:00
Scott Taylor
821f9f40ec
For `attachment-compat` fields, show a spinner while `wp.media.model.Attachment.saveCompat()` is firing.
...
Fixes #27028 .
Built from https://develop.svn.wordpress.org/trunk@29831
git-svn-id: http://core.svn.wordpress.org/trunk@29595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-03 18:43:20 +00:00
Scott Taylor
d8c913b3f9
Add the `date` filter from media grid to the media modal.
...
Props janhenckens, wonderboymusic.
Fixes #28990 .
Built from https://develop.svn.wordpress.org/trunk@29813
git-svn-id: http://core.svn.wordpress.org/trunk@29579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:32:16 +00:00
Scott Taylor
202ede7696
After [29811], combine 2 `if` statements.
...
Built from https://develop.svn.wordpress.org/trunk@29812
git-svn-id: http://core.svn.wordpress.org/trunk@29578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:16:17 +00:00
Scott Taylor
b885885b67
Media Grid/List Table parity: when `MEDIA_TRASH` is `true` and `trash` is the current filter for the grid, add a second bulk action button: "Delete Selected"
...
Fixes #29742 .
Built from https://develop.svn.wordpress.org/trunk@29811
git-svn-id: http://core.svn.wordpress.org/trunk@29577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 04:13:16 +00:00
Scott Taylor
f30266acb9
Media Grid:
...
* In Bulk Edit mode, don't attempt to delete or trash an attachment that doesn't have a `delete` nonce. The subsequent `_requery()` will then properly display the attachment still present in the library.
* Remove all updated models from the selection at the same time to avoid async race conditions. The selection is reset when the grid's `select` mode is deactivated, but this allows this view instance to be more portable.
This fix allows users to set caps on individual attachments without confusing the grid's library. This issue was present for bulk actions in general, had nothing to do with `MEDIA_TRASH` specifically.
Fixes #29597 .
Built from https://develop.svn.wordpress.org/trunk@29755
git-svn-id: http://core.svn.wordpress.org/trunk@29527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 18:52:16 +00:00
Sergey Biryukov
9f066b2a1d
Correct some @since values added in [29739].
...
see #28459 .
Built from https://develop.svn.wordpress.org/trunk@29743
git-svn-id: http://core.svn.wordpress.org/trunk@29517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-13 12:18:18 +00:00
Scott Taylor
836e0f8cd5
Add some `@since` annotations to `media-views.js`.
...
Props DrewAPicture.
See #28459 .
Built from https://develop.svn.wordpress.org/trunk@29739
git-svn-id: http://core.svn.wordpress.org/trunk@29513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 03:36:16 +00:00
Sergey Biryukov
39b859c21e
Add 'Unattached' filter for galleries.
...
props pento.
fixes #29329 .
Built from https://develop.svn.wordpress.org/trunk@29722
git-svn-id: http://core.svn.wordpress.org/trunk@29496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 07:14:16 +00:00
Andrew Nacin
b0f6b888b9
Media: Avoid repeated thumbnail resizing.
...
props avryl, wonderboymusic, azaozz.
fixes #27423 .
Built from https://develop.svn.wordpress.org/trunk@29686
git-svn-id: http://core.svn.wordpress.org/trunk@29461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 06:10:19 +00:00
Andrew Nacin
4cfdb9851f
Media Modal: Fix 'Insert from URL' oEmbed previews.
...
props johnbillion, azaozz.
fixes #29473 .
Built from https://develop.svn.wordpress.org/trunk@29680
git-svn-id: http://core.svn.wordpress.org/trunk@29455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 00:37:16 +00:00
Helen Hou-Sandí
7586e15e0d
Media: only apply `wp-filter` class to the grid view toolbar.
...
props gcorne.
fixes #29381 .
Built from https://develop.svn.wordpress.org/trunk@29629
git-svn-id: http://core.svn.wordpress.org/trunk@29403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 19:06:15 +00:00
Helen Hou-Sandí
9e8b9a78ca
Media library: Unify headers between view modes.
...
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.
This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).
props pento, helen.
fixes #28946 .
Built from https://develop.svn.wordpress.org/trunk@29625
git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 15:58:15 +00:00
Dominik Schilling
32030a073f
RTL: Fix modal alignments.
...
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778 .
fixes #29352 .
Built from https://develop.svn.wordpress.org/trunk@29623
git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 12:55:16 +00:00
Scott Taylor
80bda02c0f
Media Modal:
...
* the Image Details frame does not have a menu, indicate that by setting `menu: false` when adding states.
* mimic the default router rendering by toggling a `hide-menu` class on the frame when the region for menu is `null`
* remove the dead render code for the Image Details frame
See #29339 .
Built from https://develop.svn.wordpress.org/trunk@29613
git-svn-id: http://core.svn.wordpress.org/trunk@29387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:22:16 +00:00
Helen Hou-Sandí
60c6399d1c
Media Grid: Show upload errors above the grid rather than as a popup.
...
props pento, stephdau, helen. fixes #29141 .
Built from https://develop.svn.wordpress.org/trunk@29612
git-svn-id: http://core.svn.wordpress.org/trunk@29386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:18:17 +00:00
Andrew Ozz
04e28b468c
Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
...
Built from https://develop.svn.wordpress.org/trunk@29609
git-svn-id: http://core.svn.wordpress.org/trunk@29383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 22:45:16 +00:00
Scott Taylor
d869fe0603
Media: cleanup recent changes to `media.view.FocusManager`.
...
* Adjusts the focus method to target the menu for the current modal
* Refactor the FocusManager so that the method names and the functionality matches more closely with how it currently works. The changes in 4.0 to the FocusManager change the purpose of the focus manager entirely — instead of being a way to save and restore focus state, the new FocusManager is about constraining keyboard navigation via the tab key to inside the modal.
Props gcorne.
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29602
git-svn-id: http://core.svn.wordpress.org/trunk@29376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:23:16 +00:00
Scott Taylor
db0b4c5b4d
Media: when activating a mode after [29056], don't trigger the `{mode}:activate` event twice in a row.
...
See #29366 .
Built from https://develop.svn.wordpress.org/trunk@29601
git-svn-id: http://core.svn.wordpress.org/trunk@29375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:07:15 +00:00
Scott Taylor
1335ff3e40
Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
...
Props adamsilverstein.
See #28822 .
Built from https://develop.svn.wordpress.org/trunk@29585
git-svn-id: http://core.svn.wordpress.org/trunk@29359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:55:15 +00:00