Commit Graph

236 Commits

Author SHA1 Message Date
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Ryan Boren f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
ryan 6bba5a265b Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
ryan efbbab1b3c Help tabs. Props chexee. see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-24 00:21:39 +00:00
nacin bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan 3ad1f67958 Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
nacin 795ca8d394 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
azaozz bbafdfa0e5 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
azaozz 3575537e5f Add screen_options with contextual content, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
koopersmith 2207bfe689 Admin Header 2: The Return of 32px Icons. Props, iammattthomas. see #17324.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 00:22:22 +00:00
ryan e5ec44416a Remove favorite_actions() from h2s. Restore Add New buttons. see #17324
git-svn-id: http://svn.automattic.com/wordpress/trunk@17849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-10 19:18:16 +00:00
markjaquith 8d87f5dcb4 Big UI style update. props koopersmith. see #17324
git-svn-id: http://svn.automattic.com/wordpress/trunk@17800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 20:15:05 +00:00
nacin 9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
ryan e9d62d1f01 From post back to get. Props SergeyBiryukov. fixes #16335
git-svn-id: http://svn.automattic.com/wordpress/trunk@17345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-22 01:31:21 +00:00
nacin 37075f7f71 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
westi eb9c28f45a Switch back to GET from REQUEST for these so the non js searches work again. See #14927
git-svn-id: http://svn.automattic.com/wordpress/trunk@17307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-15 02:03:46 +00:00
scribu cfe09b99e5 Introduce WP_List_Table::search_box(). See #15353
git-svn-id: http://svn.automattic.com/wordpress/trunk@17006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 20:45:10 +00:00
nacin cc08068dba Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 08:43:22 +00:00
nacin 1cd758dc89 Help text edits. props dougwrites, fixes #15346.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:37:03 +00:00
scribu 3f2c0aff8a Don't show search box if there are no items available. See #15353
git-svn-id: http://svn.automattic.com/wordpress/trunk@16868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-10 20:22:34 +00:00
nacin a717edca97 Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 18:02:54 +00:00
westi 46cd784f3c Restore some more cap checks for clarity. See #15326.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 21:06:19 +00:00
westi 5e90c5d1c3 Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 08:07:03 +00:00
scribu 3ded7f7c68 complete the renaming. props ocean90. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@16172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-03 22:06:45 +00:00
westi ad92d629d6 The big renaming of the list-table class files.
See #14579

git-svn-id: http://svn.automattic.com/wordpress/trunk@16128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 09:19:50 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
nacin 48d8763734 Commit the rest of [15955]. see #14579.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 02:58:25 +00:00
scribu e975e650cf Introduce WP_List_Table::current_action() and use throughout admin list screens. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-22 00:10:39 +00:00
scribu 75219a5110 Introduce get_list_table(). See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-25 00:51:44 +00:00
scribu cae0e969ce replace $table with $wp_list_table. See #14651
git-svn-id: http://svn.automattic.com/wordpress/trunk@15519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-22 11:22:46 +00:00
scribu c6056827ed Introduce WP_List_Table::check_permissions() and WP_List_Table::prepare_items(). Fixes #14596; See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-12 23:21:05 +00:00
scribu 020ce73746 Ajaxify list-type screens in the admin. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-11 21:54:51 +00:00
nacin 34c1fa6d0b target=blank for help. props jorbin, see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 21:00:39 +00:00
nacin fc172d4d9a Help whitespace/punctuation cleanup. props zeo, see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-29 16:16:40 +00:00
nacin 7fd6e707da Help text typo fixes. props jorbin, dougwrites. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 19:20:52 +00:00
nbachiyski bb00d56a67 Menu translatable strings cleanup.
* Take out <strong> of the translatable part of For more information:
 * Include support forums and Codex links inside translations, because most translators would want to change them to their local documentation sites or Codex prefixes


git-svn-id: http://svn.automattic.com/wordpress/trunk@14989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 11:52:15 +00:00
ryan f762020c74 Help cleanup. Props duck_. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@14965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 21:32:30 +00:00
ryan 6802efce35 Help for links pages. Props jorbin. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@14909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-25 22:45:18 +00:00
nacin 36af10b6b7 Use 'Comments' and 'Links' as page title instead of Edit %s. fixes #11274.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 05:07:31 +00:00
nacin f9df8a36ae s/blog/site/ in more places. props PeteMall, see #11644.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-30 01:54:32 +00:00
nacin 6ec7cb4540 Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 06:14:45 +00:00
nacin 30d6eb32c6 Remove redundant isset() and empty() checks.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-19 21:29:21 +00:00
nacin 8aede6cab7 Consistently hide bulk actions, filters, and subpage links on admin panels when there are no items to show. Fixes #12086
git-svn-id: http://svn.automattic.com/wordpress/trunk@13100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-13 08:49:27 +00:00
dd32 34a88119f8 Use !empty() for Link searching title.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-29 08:11:20 +00:00
dd32 92835977c3 Add text to 'Add New' button in link manager. Props scribu. Fixes #12071
git-svn-id: http://svn.automattic.com/wordpress/trunk@12894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-29 07:27:11 +00:00
ryan b1a242078a Show td attributes for custon coolumns. Props camiloclc. fixes #12050
git-svn-id: http://svn.automattic.com/wordpress/trunk@12872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-27 14:28:03 +00:00
ryan 94859834fc i18n fixes. Props nbachiyski. fixes #11954
git-svn-id: http://svn.automattic.com/wordpress/trunk@12789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-21 21:37:43 +00:00
azaozz 4134133d53 Remove unused .fade CSS class, props nacin, fixes #11628
git-svn-id: http://svn.automattic.com/wordpress/trunk@12546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-26 09:00:58 +00:00