John Blackbourn
ffe8f1cba4
Build/Test Tools: Standardise the name, signature, and usage of the `wpSetUpBeforeClass()` method that's used in test classes.
...
This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its `$factory` parameter.
See #51344
Built from https://develop.svn.wordpress.org/trunk@49603
git-svn-id: http://core.svn.wordpress.org/trunk@49341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 14:01:06 +00:00
Sergey Biryukov
b618452411
Twenty Nineteen: Remove unnecessary references to some variables in `twentynineteen_hsl_hex()` before they are defined.
...
Props ankitmaru, sabernhardt.
Fixes #49052 .
Built from https://develop.svn.wordpress.org/trunk@49602
git-svn-id: http://core.svn.wordpress.org/trunk@49340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-15 12:16:09 +00:00
John Blackbourn
1daf22cae6
Build/Test Tools: Improve the reliability of the test that ensures correct dependency order when inline scripts are used.
...
This test already ensures `WP_Scripts->do_concat` is true, therefore it has no dependency on `SCRIPT_DEBUG` being false. This means the test can run in an environment where the `.min` suffix is not used.
This change allows for the test to pass in this situation.
See #36392 , #51734 , #51344
Built from https://develop.svn.wordpress.org/trunk@49601
git-svn-id: http://core.svn.wordpress.org/trunk@49339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 17:22:05 +00:00
John Blackbourn
48f35e42fc
Docs: For clarity, add some information about the return types of `get_option()`.
...
Props ReneHermi, johannadevos
See #51278
Built from https://develop.svn.wordpress.org/trunk@49600
git-svn-id: http://core.svn.wordpress.org/trunk@49338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 17:02:05 +00:00
Sergey Biryukov
df2644a14a
Docs: Add missing descriptions for `_WP_List_Table_Compat` methods.
...
Props johannadevos, SaeedFard, swissspidy, desrosj, SergeyBiryukov.
Fixes #46842 .
Built from https://develop.svn.wordpress.org/trunk@49599
git-svn-id: http://core.svn.wordpress.org/trunk@49337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:54:08 +00:00
John Blackbourn
429079a9b2
Docs: Revert an accidental revert of this package name.
...
See #51414 , #50768
Built from https://develop.svn.wordpress.org/trunk@49598
git-svn-id: http://core.svn.wordpress.org/trunk@49336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:40:07 +00:00
John Blackbourn
170ca32007
Docs: Various docblock corrections and improvements.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49597
git-svn-id: http://core.svn.wordpress.org/trunk@49335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:35:06 +00:00
Sergey Biryukov
185607c417
Docs: Add missing descriptions for `Automatic_Upgrader_Skin` methods.
...
Props johannadevos, dilipbheda.
Fixes #44546 .
Built from https://develop.svn.wordpress.org/trunk@49596
git-svn-id: http://core.svn.wordpress.org/trunk@49334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 16:23:10 +00:00
Sergey Biryukov
ec051cfb3e
Docs: Clarify that `get_pages()` returns an array of pages, not an HTML list.
...
Props ben.meredith@gmail.com , ovenall, johannadevos.
Fixes #39049 . See #51768 .
Built from https://develop.svn.wordpress.org/trunk@49595
git-svn-id: http://core.svn.wordpress.org/trunk@49333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 15:01:13 +00:00
John Blackbourn
1260493569
Docs: Correct the Chocolatey package name for Node in the local environment setup instructions.
...
Props pbearne
See #51414
Built from https://develop.svn.wordpress.org/trunk@49594
git-svn-id: http://core.svn.wordpress.org/trunk@49332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-14 10:17:08 +00:00
Andrew Ozz
d817ad9b55
Upgrade/Install: Ensure the current user can update core when saving the auto-update options.
...
See #51742 .
Built from https://develop.svn.wordpress.org/trunk@49593
git-svn-id: http://core.svn.wordpress.org/trunk@49331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-13 16:57:13 +00:00
Sergey Biryukov
0bc22bb1fc
Upgrade/Install: Account for the `automatic_updater_disabled` filter in core auto-update settings UI.
...
Follow-up to [49587].
Props markparnell, audrasjb.
See #51742 .
Built from https://develop.svn.wordpress.org/trunk@49592
git-svn-id: http://core.svn.wordpress.org/trunk@49330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-13 11:14:08 +00:00
Sergey Biryukov
d6a597efe2
I18N: Remove HTML tags from translatable strings on WordPress Updates screen.
...
Follow-up to [49587].
Props fierevere.
See #51742 .
Built from https://develop.svn.wordpress.org/trunk@49591
git-svn-id: http://core.svn.wordpress.org/trunk@49329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-13 10:50:08 +00:00
Helen Hou-Sandí
845371edab
Post-WordPress 5.6 Beta 4 bump.
...
Built from https://develop.svn.wordpress.org/trunk@49590
git-svn-id: http://core.svn.wordpress.org/trunk@49328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 23:45:10 +00:00
Helen Hou-Sandí
81659521ad
WordPress 5.6 Beta 4, for real.
...
Built from https://develop.svn.wordpress.org/trunk@49589
git-svn-id: http://core.svn.wordpress.org/trunk@49327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 23:08:08 +00:00
Helen Hou-Sandí
16feb07916
WordPress 5.6 Beta 4.
...
Built from https://develop.svn.wordpress.org/trunk@49588
git-svn-id: http://core.svn.wordpress.org/trunk@49326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 23:02:09 +00:00
Helen Hou-Sandí
582ca50733
Upgrade/Install: Better UI for auto-update settings on update screen.
...
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.
Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes #51742 .
Built from https://develop.svn.wordpress.org/trunk@49587
git-svn-id: http://core.svn.wordpress.org/trunk@49325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 22:37:10 +00:00
Sergey Biryukov
c5257328b7
Customize: Exclude widget ID attributes from search.
...
Having search terms match the ID attributes leads to confusing results, specifically when the admin interface is set to a language other than English.
Follow-up to [27650].
Props afercia, dlh, noisysocks.
Fixes #46456 .
Built from https://develop.svn.wordpress.org/trunk@49586
git-svn-id: http://core.svn.wordpress.org/trunk@49324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 22:05:09 +00:00
Sergey Biryukov
7baab642c1
Bundled Themes: Add `block-patterns` tag to Twenty Nineteen and Twenty Twenty.
...
Follow-up to [49347], [49348].
See #51098 , #51099 .
Built from https://develop.svn.wordpress.org/trunk@49585
git-svn-id: http://core.svn.wordpress.org/trunk@49323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 21:56:12 +00:00
Sergey Biryukov
87fbad7286
Bundled Themes: Introduce block patterns for Twenty Seventeen.
...
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100 .
Built from https://develop.svn.wordpress.org/trunk@49584
git-svn-id: http://core.svn.wordpress.org/trunk@49322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 21:22:12 +00:00
Sergey Biryukov
b6f30e3009
Bundled Themes: Introduce block patterns for Twenty Sixteen.
...
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101 .
Built from https://develop.svn.wordpress.org/trunk@49583
git-svn-id: http://core.svn.wordpress.org/trunk@49321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 21:14:12 +00:00
Sergey Biryukov
f2364f163b
Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes.
...
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870 .
Built from https://develop.svn.wordpress.org/trunk@49582
git-svn-id: http://core.svn.wordpress.org/trunk@49320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 20:42:10 +00:00
Helen Hou-Sandí
d5fd3bd452
Upgrade/Install: Enable all core autoupdates for new installs.
...
Likely needs more work for multisite installs.
Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/
Props audrasjb, azaozz.
See #51743 .
Built from https://develop.svn.wordpress.org/trunk@49581
git-svn-id: http://core.svn.wordpress.org/trunk@49319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 20:22:09 +00:00
John Blackbourn
9115246f72
General: Convert `wp_array_get()` to a "private" function and add tests.
...
This function may be promoted in the future if it's deemed useful enough.
Props dd32, jorgefilipecosta, Hareesh Pillai
Fixes #51720
Built from https://develop.svn.wordpress.org/trunk@49580
git-svn-id: http://core.svn.wordpress.org/trunk@49318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 20:20:12 +00:00
Sergey Biryukov
1d738052b1
Editor: Update packages.
...
The following package versions were changed:
@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3
See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.
Props isabel_brison.
Fixes #51696 .
Built from https://develop.svn.wordpress.org/trunk@49579
git-svn-id: http://core.svn.wordpress.org/trunk@49317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:36:36 +00:00
desrosj
6703f8efee
Twenty Twenty-One: Use consistent casing in strings.
...
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244 ).
Also included is the replacement of an escaped apostrophe with `’`, which is also preferred per the Internationalization guidelines.
See #51526 .
Built from https://develop.svn.wordpress.org/trunk@49578
git-svn-id: http://core.svn.wordpress.org/trunk@49316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:30:11 +00:00
desrosj
5de5b186f3
Twenty Twenty-One: Ignore the `node_modules` folder in SVN.
...
[49576] mistakenly partially reverted [49250].
See #51526 .
Built from https://develop.svn.wordpress.org/trunk@49577
git-svn-id: http://core.svn.wordpress.org/trunk@49315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:07:10 +00:00
desrosj
d23292b3c0
Twenty Twenty-One: Ignore `.css.map` files.
...
These are generated when Sass is compiled, but should never be committed.
See #51526 .
Built from https://develop.svn.wordpress.org/trunk@49576
git-svn-id: http://core.svn.wordpress.org/trunk@49314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 19:00:10 +00:00
desrosj
ee888ad547
Twenty Twenty-One: Convert inline ESLint comments to JSHint.
...
WordPress Core currently uses JSHint instead of ESlint.
See #51526 .
Built from https://develop.svn.wordpress.org/trunk@49575
git-svn-id: http://core.svn.wordpress.org/trunk@49313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 18:48:08 +00:00
desrosj
967d29d83d
Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4.
...
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.
This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.
For a full list of changes since [], see e7d5991...aa284fd
.
Props poena, luminuu kjellr, aristath, justinahinon.
See #51526 .
Built from https://develop.svn.wordpress.org/trunk@49574
git-svn-id: http://core.svn.wordpress.org/trunk@49312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 18:36:15 +00:00
TimothyBlynJacobs
5ee48d6915
App Passwords: MOAR accessibility improvements.
...
Corrects the "Application Name" field's aria-describedby attribute and makes the description visible.
Props alexstine, SergeyBiryukov.
Fixes #51580 .
Built from https://develop.svn.wordpress.org/trunk@49573
git-svn-id: http://core.svn.wordpress.org/trunk@49311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 18:14:08 +00:00
Sergey Biryukov
d772517fcc
Database: Clean up the `post_category` column removed from DB schema for new installations in WordPress 2.8.
...
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.
Follow-up to [10895].
Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288 .
Built from https://develop.svn.wordpress.org/trunk@49572
git-svn-id: http://core.svn.wordpress.org/trunk@49310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:55:11 +00:00
Sergey Biryukov
250d0660b2
Build/Test Tools: Only enforce PHP extension requirements when running core tests.
...
This allows other users of the WordPress unit test suite framework to run their own unit tests without needing the GD extension, which should only be a requirement if running core tests.
Follow-up to [49535].
Props jamescollins.
Fixes #50640 .
Built from https://develop.svn.wordpress.org/trunk@49571
git-svn-id: http://core.svn.wordpress.org/trunk@49309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:25:13 +00:00
Sergey Biryukov
8e58e38ef9
Build/Tests Tools: Restore [49491], accidentally reverted in [49566].
...
See #39210 .
Built from https://develop.svn.wordpress.org/trunk@49570
git-svn-id: http://core.svn.wordpress.org/trunk@49308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:15:08 +00:00
Sergey Biryukov
6ac50d705c
Build/Tests Tools: Restore [49535], accidentally reverted in [49566].
...
See #39210 .
Built from https://develop.svn.wordpress.org/trunk@49569
git-svn-id: http://core.svn.wordpress.org/trunk@49307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 17:08:11 +00:00
antpb
522a7a5d40
Media: Allow users to switch from media grid to list mode in media library.
...
Fixes issue where media modal would open when switching from grid to list mode.
Props mista-flo, mukesh27.
Fixes #51396 .
Built from https://develop.svn.wordpress.org/trunk@49568
git-svn-id: http://core.svn.wordpress.org/trunk@49306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 15:46:07 +00:00
antpb
8efbef867c
Media: Improve count in Media Library pagination.
...
Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem.
Props donsony, karmatosed, desrosj, mista-flo, justinahinon.
Fixes #39968 .
Built from https://develop.svn.wordpress.org/trunk@49567
git-svn-id: http://core.svn.wordpress.org/trunk@49305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 15:40:09 +00:00
Dominik Schilling
abc9d961d5
I18N: Revert [49236] for now to investigate alternative implementations.
...
See #39210 , #51678 , #26511 .
Built from https://develop.svn.wordpress.org/trunk@49566
git-svn-id: http://core.svn.wordpress.org/trunk@49304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 14:43:09 +00:00
Sergey Biryukov
4446e597a7
Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later.
...
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.
Follow-up to [21644], [21652], [22366], [22599].
Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204 .
Built from https://develop.svn.wordpress.org/trunk@49565
git-svn-id: http://core.svn.wordpress.org/trunk@49303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 14:36:10 +00:00
Sergey Biryukov
9c6f41419c
Coding Standards: Pass an empty string instead of `null` as the `$replacement` parameter to `_deprecated_file()`.
...
Follow-up to [48327].
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49564
git-svn-id: http://core.svn.wordpress.org/trunk@49302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 11:17:07 +00:00
Peter Wilson
5da8c0fceb
Canonical: Prevent ID enumeration of private post slugs.
...
Add check to `redirect_canonical()` to ensure the destination post is not using a private post status.
Props dd32, Denis-de-Bernardy, donmhico, helen, nacin, peterwilsoncc, pishmishy, TimothyBlynJacobs, tzafrir, Viper007Bond, whyisjake.
Fixes #5272 .
Built from https://develop.svn.wordpress.org/trunk@49563
git-svn-id: http://core.svn.wordpress.org/trunk@49301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-12 04:16:08 +00:00
Sergey Biryukov
3a1265e188
I18N: Add trailing punctuation to some translator comments.
...
Follow-up to [49549].
See #51580 .
Built from https://develop.svn.wordpress.org/trunk@49562
git-svn-id: http://core.svn.wordpress.org/trunk@49300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-11 10:41:07 +00:00
Sergey Biryukov
9db9343826
Docs: Clarify `sprintf()` usage for the `before_widget` argument of `register_sidebar()`.
...
Follow-up to [49203], [49560].
See #19709 .
Built from https://develop.svn.wordpress.org/trunk@49561
git-svn-id: http://core.svn.wordpress.org/trunk@49299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-11 10:39:09 +00:00
Helen Hou-Sandí
19b035f04b
Widgets: Do not use wrapping container in the admin.
...
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.
Also adds documentation for the `sprintf()` on `before_sidebar`.
Props audrasjb, lpointet.
See #19709 .
Built from https://develop.svn.wordpress.org/trunk@49560
git-svn-id: http://core.svn.wordpress.org/trunk@49298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-10 20:40:09 +00:00
Helen Hou-Sandí
135c75c396
Editor: Display short description from block directory in results.
...
Props dd32, ryelle.
Fixes #51212 .
Built from https://develop.svn.wordpress.org/trunk@49559
git-svn-id: http://core.svn.wordpress.org/trunk@49297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-10 20:26:08 +00:00
Sergey Biryukov
1f984603a2
Help/About: Add Site Health Status dashboard widget to the Help → Content tab.
...
Reorder the items in the help tab to align with their default position on the Dashboard screen.
Follow-up to [47063], [47300].
Props nlpro.
Fixes #51745 .
Built from https://develop.svn.wordpress.org/trunk@49558
git-svn-id: http://core.svn.wordpress.org/trunk@49296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-10 19:05:10 +00:00
Sergey Biryukov
e503ee45d6
TinyMCE: Update to 4.9.11.
...
Changelog:
https://www.tiny.cloud/docs-4x/changelog/#version4911july132020
https://github.com/tinymce/tinymce/blob/4.x/changelog.txt
A full list of changes in this update can be found on GitHub:
https://github.com/tinymce/tinymce/compare/4.9.10...4.9.11
See #51051 .
Built from https://develop.svn.wordpress.org/trunk@49557
git-svn-id: http://core.svn.wordpress.org/trunk@49295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-10 10:44:08 +00:00
Andrew Ozz
16458d8fd2
Tests QUnit: Remove restriction on running the TinyMCE Textpattern WP plugin tests in PhantomJS.
...
Props @desrosj.
Fixes #42009 .
Built from https://develop.svn.wordpress.org/trunk@49556
git-svn-id: http://core.svn.wordpress.org/trunk@49294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-10 09:18:10 +00:00
antpb
64beb3ee49
Media: Removes duplicate alignment fix for browser uploader.
...
See #41648
Built from https://develop.svn.wordpress.org/trunk@49555
git-svn-id: http://core.svn.wordpress.org/trunk@49293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 23:43:07 +00:00
desrosj
964c353504
Tests: Remove duplicate `fields` key in `WP_Query` test.
...
Introduced in [46188].
See #51344 .
Built from https://develop.svn.wordpress.org/trunk@49554
git-svn-id: http://core.svn.wordpress.org/trunk@49292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 23:41:06 +00:00