WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
31,735 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

31735 Commits

Author SHA1 Message Date
Drew Jaynes 08277293e5 Docs: Improve the documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Tag_Cloud`. 
Props leemon.
Fixes #34026. See #34013.

Built from https://develop.svn.wordpress.org/trunk@34610


git-svn-id: http://core.svn.wordpress.org/trunk@34574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:32:24 +00:00
Drew Jaynes 83da7624e6 Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Text`. 
(first!) Props leemon.
Fixes #34027.

Built from https://develop.svn.wordpress.org/trunk@34609


git-svn-id: http://core.svn.wordpress.org/trunk@34573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-27 00:27:26 +00:00
John Blackbourn bc4b983f89 Add function signature tests for the pluggable functions in wp-admin/includes/schema.php and wp-admin/includes/upgrade.php. 
See #33867

Built from https://develop.svn.wordpress.org/trunk@34608


git-svn-id: http://core.svn.wordpress.org/trunk@34572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 22:04:24 +00:00
John Blackbourn 336ac6e5d9 Add function signature tests for the pluggable functions in `wp-includes/cache.php`. 
See #33867

Built from https://develop.svn.wordpress.org/trunk@34607


git-svn-id: http://core.svn.wordpress.org/trunk@34571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 22:03:25 +00:00
Aaron Jorbin d09f7b6c1d Revert change from true to false in multisite upload test 
This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0.  Essentially, 0 means 100.  WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10.  This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0.

See #34037
Props jorbin, boonebgorges


Built from https://develop.svn.wordpress.org/trunk@34606


git-svn-id: http://core.svn.wordpress.org/trunk@34570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 20:59:24 +00:00
Weston Ruter 7493641f86 Customize: Prevent showing "Front Page" and "Posts Page" states for pages in list table when `show_on_front` is not "page". 
Changing the `show_on_front` option back to "posts" also resets the `page_on_front` and `page_for_posts` options when updating via the Reading settings page. In the Customizer, however, this is not the case as these other options remain unchanged. This change accounts for this difference in behavior.

Fixes #34004.

Built from https://develop.svn.wordpress.org/trunk@34605


git-svn-id: http://core.svn.wordpress.org/trunk@34569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 20:54:25 +00:00
Boone Gorges cc8df8ecb6 Remove failing xmlrpc upload test. 
This test was added [34577], but shouldn't have been, because the bug it
describes has not been fixed.

See #21292.
Built from https://develop.svn.wordpress.org/trunk@34604


git-svn-id: http://core.svn.wordpress.org/trunk@34568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 20:32:25 +00:00
Scott Taylor 2c30a11518 After [34577], alter `wp_xmlrpc_server::mw_newMediaObject()` to check upload space in multisite. 
See #21292.

Built from https://develop.svn.wordpress.org/trunk@34603


git-svn-id: http://core.svn.wordpress.org/trunk@34567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 19:49:25 +00:00
Scott Taylor 685ff76514 After [34601], some more cleanup. 
Built from https://develop.svn.wordpress.org/trunk@34602


git-svn-id: http://core.svn.wordpress.org/trunk@34566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 19:29:26 +00:00
Scott Taylor 982edbb061 After [34577] (not because of), uncover and fix some horrifying anomalies in `Tests_Multisite_Site`. 
Built from https://develop.svn.wordpress.org/trunk@34601


git-svn-id: http://core.svn.wordpress.org/trunk@34565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 19:11:24 +00:00
Aaron Jorbin 6856803922 Use an http URL rather then an https URL for tests 
Travis doesn't properly support SSL on older versions of PHP. Since we don't test for SSL support in all of the tests, this can cause these tests to fail.  This changes a URL introduced in [34568]

See #33968


Built from https://develop.svn.wordpress.org/trunk@34600


git-svn-id: http://core.svn.wordpress.org/trunk@34564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 17:48:33 +00:00
Boone Gorges 9f36a943b5 Improve post field lazyloading for comments. 
[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:

* `WP_Comment` magic methods `__isset()` and `__get()` should only load the post when a post field is being requested.
* The new `update_comment_post_cache` argument for `WP_Comment_Query` allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.

Fixes #27571.
Built from https://develop.svn.wordpress.org/trunk@34599


git-svn-id: http://core.svn.wordpress.org/trunk@34563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 16:02:25 +00:00
Dominik Schilling 7b33ad2a99 Plugins: Don't request all fields via `plugins_api( 'plugin_information' )` for plugin installs and update checks. 
The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.

Fixes #34030.
Built from https://develop.svn.wordpress.org/trunk@34598


git-svn-id: http://core.svn.wordpress.org/trunk@34562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 15:50:25 +00:00
John Blackbourn 2079755bd8 Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference. 
See #32246

Built from https://develop.svn.wordpress.org/trunk@34597


git-svn-id: http://core.svn.wordpress.org/trunk@34561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 15:17:24 +00:00
Drew Jaynes ae91c35cb3 Docs: Add much-needed (and awesome) hash-notation-style documentation for the `$args` parameter in the `plugins_api()` DocBlock. 
Also fixes up some formatting in the DocBlock summary and description, and adds a link to the function reference, where supplementary information on return object structs and formatting will live.

Props ocean90.
Fixes #34035.

Built from https://develop.svn.wordpress.org/trunk@34596


git-svn-id: http://core.svn.wordpress.org/trunk@34560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 15:13:25 +00:00
Boone Gorges 95679a3292 Use correct property name when setting child comments. 
This fixes a typo from [34546], uncovered by unrelated changes in [34583].

See #8071, #27571.
Built from https://develop.svn.wordpress.org/trunk@34595


git-svn-id: http://core.svn.wordpress.org/trunk@34559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 14:41:24 +00:00
Sergey Biryukov cef2439453 Replace a stray semicolon on Edit Page screen with a full stop. 
Props manolis09, sjmur.
Fixes #33297.
Built from https://develop.svn.wordpress.org/trunk@34594


git-svn-id: http://core.svn.wordpress.org/trunk@34558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 13:44:26 +00:00
Drew Jaynes 1a91ac752a Docs: Fix a minor typo from [34592]. Meant to be past-tense, not present. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34593


git-svn-id: http://core.svn.wordpress.org/trunk@34557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 13:14:25 +00:00
Drew Jaynes 231b6f4d5b Docs: Add missing parameter documentation for `$profileuser` in the hook doc for `show_password_fields`, added in [11302]. 
Also adds a changelog entry for when the parameter was introduced.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34592


git-svn-id: http://core.svn.wordpress.org/trunk@34556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 13:11:49 +00:00
Sergey Biryukov b28dd45f3d Network Admin: Properly pass the number of delete plugins to the corresponding message. 
Fixes #33239.
Built from https://develop.svn.wordpress.org/trunk@34591


git-svn-id: http://core.svn.wordpress.org/trunk@34555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 13:11:25 +00:00
Drew Jaynes efad273513 Docs: Relocate the hook doc for the `show_password_fields` filter to its duplicate, since the original was removed in [34582]. 
Adds a changelog entry noting the adjustment in behavior, and simplifies the conditional logic.

Fixes #15115.

Built from https://develop.svn.wordpress.org/trunk@34590


git-svn-id: http://core.svn.wordpress.org/trunk@34554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 13:05:26 +00:00
Drew Jaynes 8d96a53ba4 Docs: Adjust the table of providers in the hook doc for `oembed_providers` to use "No" instead of "!" to signify lack of SSL support. 
When displayed in the Code Reference, the "!" doesn't convey enough information.

See #32246. See #28507.

Built from https://develop.svn.wordpress.org/trunk@34589


git-svn-id: http://core.svn.wordpress.org/trunk@34553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 12:50:30 +00:00
John Blackbourn 15a9fd4332 Switch to the `https` oEmbed endpoint for Animoto because it redirects there anyway. 
See #28507

Built from https://develop.svn.wordpress.org/trunk@34588


git-svn-id: http://core.svn.wordpress.org/trunk@34552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 12:24:24 +00:00
John Blackbourn 485a12c2fe Switch to the `https` oEmbed endpoint for Dailymotion so secure embeds are supported. 
See #28507

Built from https://develop.svn.wordpress.org/trunk@34587


git-svn-id: http://core.svn.wordpress.org/trunk@34551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 11:51:24 +00:00
Sergey Biryukov cf3203e016 Twenty Fifteen: Add missing commas in `rtl.css`. 
Props netweb.
Fixes #33985.
Built from https://develop.svn.wordpress.org/trunk@34586


git-svn-id: http://core.svn.wordpress.org/trunk@34550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 10:49:26 +00:00
Scott Taylor 5acee30d9d Docs: object != class 
See [33893] et al.

Built from https://develop.svn.wordpress.org/trunk@34585


git-svn-id: http://core.svn.wordpress.org/trunk@34549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 07:04:28 +00:00
Scott Taylor 75b1dde362 Posts List Table: check `is_multi_author()` before attempting to set `->user_posts_count`. Also, don't show "Mine" when the count is the same as "All." 
Fixes #19609.

Built from https://develop.svn.wordpress.org/trunk@34584


git-svn-id: http://core.svn.wordpress.org/trunk@34548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 06:51:26 +00:00
Scott Taylor 4389962eb8 Comments: add `__get()` and `__set()` to `WP_Comment` to provide BC for plugins that are grabbing post properties from the comment object due to an (unintended?) side effect of `JOIN`ing with the posts table in `WP_Comment_Query`, see [17667]. `'fields'` used to default to `*`, so the `JOIN` would grab every field from both tables. #YOLO 
Since [34310], these properties no longer exist. We can lazy load them for plugins with the magic methods. 

Fixes #27571.

Built from https://develop.svn.wordpress.org/trunk@34583


git-svn-id: http://core.svn.wordpress.org/trunk@34547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 06:41:26 +00:00
Scott Taylor 0d8a80b14c Profile: on `user-new.php`, don't allow the password fields to be hidden. When hidden, you can't add a user. 
Props coffee2code.
Fixes #15115.

Built from https://develop.svn.wordpress.org/trunk@34582


git-svn-id: http://core.svn.wordpress.org/trunk@34546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 06:15:26 +00:00
Scott Taylor 8646c8b93c Recent Comments Widget: a la [34464], this widget has the same mixed content issues. Remove the fragment caching. The comment queries are now split to scale. This was the only remaining widget with an HTML fragment cache. 
Fixes #25556.

Built from https://develop.svn.wordpress.org/trunk@34581


git-svn-id: http://core.svn.wordpress.org/trunk@34545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 06:01:26 +00:00
Scott Taylor 0405a03b5e XML-RPC: in `wp_xmlrpc_server::wp_editTerm()`, check `! empty` when applying `parent` logic. 
Adds unit tests.

Props hrishiv90, markoheijnen, sam2kb.
Fixes #21977.

Built from https://develop.svn.wordpress.org/trunk@34580


git-svn-id: http://core.svn.wordpress.org/trunk@34544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 05:31:25 +00:00
Scott Taylor 80ac048cbc XML-RPC: upgrade the resposnse of`wp_xmlrpc_server::mw_newMediaObject()` based on work down in 3.4 so that it runs the struct through `->_prepare_media_item()`. 
Props markoheijnen.
Fixes #6430.

Built from https://develop.svn.wordpress.org/trunk@34579


git-svn-id: http://core.svn.wordpress.org/trunk@34543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 05:15:25 +00:00
Scott Taylor e9aa518f04 XML-RPC: move the malfunctioning 'overwrite' code from `wp_xmlrpc_server::mw_newMediaObject()`. This was suggested 3 years ago. 
Props markoheijnen.
Fixes #17604.

Built from https://develop.svn.wordpress.org/trunk@34578


git-svn-id: http://core.svn.wordpress.org/trunk@34542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 05:03:24 +00:00
Scott Taylor b310f13c7b XML-RPC: add a `wp_uploadFile` unit test. 
Props MikeHansenMe.
See #21292.

Built from https://develop.svn.wordpress.org/trunk@34577


git-svn-id: http://core.svn.wordpress.org/trunk@34541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 04:58:28 +00:00
Scott Taylor 2f167faeb2 Cron: In `spawn_cron()`, when using `ALTERNATE_WP_CRON`, return early for any non-`GET`, instead of naively checking `! empty( $_POST )`. 
Props johnbillion, markoheijnen.
Fixes #27447.

Built from https://develop.svn.wordpress.org/trunk@34576


git-svn-id: http://core.svn.wordpress.org/trunk@34540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 04:51:26 +00:00
Scott Taylor ffe7f0ec5a XML-RPC: In `wp_xmlrpc_server::wp_getComments()`, allow `post_type` to be passed as part of `$struct`. 
Props nprasath002.
Fixes #20026.

Built from https://develop.svn.wordpress.org/trunk@34575


git-svn-id: http://core.svn.wordpress.org/trunk@34539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 04:45:25 +00:00
Scott Taylor c8b308a647 XML-RPC: In `wp_xmlrpc_server::wp_getUsersBlogs()`, return the `isPrimary` flag for each blog. 
Props SergeyBiryukov, daniloercoli.
Fixes #25958.

Built from https://develop.svn.wordpress.org/trunk@34574


git-svn-id: http://core.svn.wordpress.org/trunk@34538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 04:35:25 +00:00
Scott Taylor 9b253bbc7b XML-RPC: In `wp_xmlrpc_server::blogger_editPost()`, make use of the `$publish` arg (the 6th arg passed to the method) to specify `publish` or `draft`. Restores the arg, which I removed in [31092], because it was unused cruft. 
Props mdawaffe.
Fixes #10764.

Built from https://develop.svn.wordpress.org/trunk@34573


git-svn-id: http://core.svn.wordpress.org/trunk@34537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 04:01:26 +00:00
Scott Taylor dd1098e7c5 XML-RPC: In `wp_xmlrpc_server::mw_newPost()`, if `$dateCreated` is not set, don't set `post_date` and `post_date_gmt`. It calls `wp_insert_post()`, which will handle it correctly. The problem was drafts being created and GMT date being set. It shouldn't be. 
Adds unit test.

Fixes #16985.

Built from https://develop.svn.wordpress.org/trunk@34572


git-svn-id: http://core.svn.wordpress.org/trunk@34536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 03:38:25 +00:00
Scott Taylor 78d846289f XML-RPC: `IXR_Server::output()` is notoriously bad at returning the right value for the `Content-Length` HTTP header. This header is not required, so we will remove it. 
"We could of course remove the content-length header as it is not required" was suggested 10 years ago. The IXR library is not maintained. Our release is the latest, which occurred in 2010.

Fixes #2567.

Built from https://develop.svn.wordpress.org/trunk@34571


git-svn-id: http://core.svn.wordpress.org/trunk@34535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 03:11:24 +00:00
Scott Taylor a0ccd4eae8 XML-RPC: `wp.getComments` should be allowed to return approved comments to those without the `'moderate_comments'` cap. 
Adds (rewrites) unit tests from 4 years ago that we never committed because....

Props wonderboymusic, koke, ericmann, nprasath002.
Fixes #17981.

Built from https://develop.svn.wordpress.org/trunk@34570


git-svn-id: http://core.svn.wordpress.org/trunk@34534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 02:49:27 +00:00
Scott Taylor fa90b77ba4 Comments: in `WP_Comment::get_children()`, accept an array so that the values for `format`, `status`, `hierarchical`, and `orderby` can be passed, instead of just `format`. The defaults for `get_comments()` include `status = 'all'` and `orderby = ''` - which is no bueno. 
For threaded comments, we need comments to be retrieved within bounds, so logged-out users don't see unmoderated comments on the front end, etc.

Updates unit tests.

See #8071.

Built from https://develop.svn.wordpress.org/trunk@34569


git-svn-id: http://core.svn.wordpress.org/trunk@34533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 02:25:26 +00:00
Aaron Jorbin 3a23190505 Stop hitting SVN for http tests 
The automated tests can fail due to svn. Change the tests to use a WordPress CDN image.

see #33968


Built from https://develop.svn.wordpress.org/trunk@34568


git-svn-id: http://core.svn.wordpress.org/trunk@34532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 00:40:24 +00:00
Aaron Jorbin 1bfb20ba2a Move travis secure token under rooms 
Travis lint says it is dropping the secure token, hence not actually pinging slack. According to http://docs.travis-ci.com/user/notifications/#Slack-notifications what we encrypt *should* be usable under rooms.  Will this work?  I don't know, but YOLO.

Fixes #30755


Built from https://develop.svn.wordpress.org/trunk@34567


git-svn-id: http://core.svn.wordpress.org/trunk@34531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-26 00:04:24 +00:00
John Blackbourn aa35e473f7 `callback` is not a valid type in PHP, PSR-5, or phpDocumentor. `callable` should be used instead. 
Fixes #34032

Built from https://develop.svn.wordpress.org/trunk@34566


git-svn-id: http://core.svn.wordpress.org/trunk@34530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 23:58:25 +00:00
Drew Jaynes 3229785656 Docs: Fix the syntax for a mid-file sectional comment in wp-admin/includes/dashboard.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34565


git-svn-id: http://core.svn.wordpress.org/trunk@34529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 22:51:24 +00:00
Drew Jaynes 115c382132 Docs: Remove an inline comment duplicated by the DocBlock summary for `wp_dashboard_trigger_widget_control()`. 
Props tyxla.
Fixes #34014.

Built from https://develop.svn.wordpress.org/trunk@34564


git-svn-id: http://core.svn.wordpress.org/trunk@34528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 22:50:26 +00:00
Weston Ruter 208330f2dc Customizer: Defer embedding widget controls to improve DOM performance and initial load time. 
The Menu Customizer feature includes a performance technique whereby the controls for nav menu items are only embedded into the DOM once the containing menu section is expanded. This commit implements the same DOM deferral for widgets but goes a step further than just embedding the controls once the widget area's Customizer section is expanded: it also defers the embedding of the widget control's form until the widget is expanded, at which point the `widget-added` event also fires to allow any additional widget initialization to be done. The deferred DOM embedding can speed up initial load time by 10x or more. This DOM deferral also yields a reduction in overall memory usage in the browser process.

Includes changes to `wp_widget_control()` to facilitate separating out the widget form from the surrounding accordion container; also includes unit tests for this previously-untested function. Also included are initial QUnit tests (finally) for widgets in the Customizer.

Fixes #33901.

Built from https://develop.svn.wordpress.org/trunk@34563


git-svn-id: http://core.svn.wordpress.org/trunk@34527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 21:02:27 +00:00
Boone Gorges 4e051fa421 After [35461], remove 'page_comments' from database. 
* Don't set as part of initial schema.
* Delete as part of the `$unusedoptions` routine.

Props ocean90.
See #8071.
Built from https://develop.svn.wordpress.org/trunk@34562


git-svn-id: http://core.svn.wordpress.org/trunk@34526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 20:50:25 +00:00
Boone Gorges 18d6b3c8dc Force comment pagination on single posts. 
Previously, the 'page_comments' toggle allowed users to disable comment
pagination. This toggle was only superficial, however. Even with
'page_comments' turned on, `comments_template()` loaded all of a post's
comments into memory, and passed them to `wp_list_comments()` and
`Walker_Comment`, the latter of which produced markup for only the
current page of comments. In other words, it was possible to enable
'page_comments', thereby showing only a subset of a post's comments on a given
page, but all comments continued to be loaded in the background. This technique
scaled poorly. Posts with hundreds or thousands of comments would load slowly,
or not at all, even when the 'comments_per_page' setting was set to a
reasonable number.

Recent changesets have addressed this problem through more efficient tree-
walking, better descendant caching, and more selective queries for top-level
post comments. The current changeset completes the project by addressing the
root issue: that loading a post causes all of its comments to be loaded too.

Here's the breakdown:

* Comment pagination is now forced. Setting 'page_comments' to false leads to evil things when you have many comments. If you want to avoid pagination, set 'comments_per_page' to something high.
* The 'page_comments' setting has been expunged from options-discussion.php, and from places in the codebase where it was referenced. For plugins relying on 'page_comments', we now force the value to `true` with a `pre_option` filter.
* `comments_template()` now queries for an appropriately small number of comments. Usually, this means the `comments_per_page` value.
* To preserve the current (odd) behavior for comment pagination links, some unholy hacks have been inserted into `comments_template()`. The ugliness is insulated in this function for backward compatibility and to minimize collateral damage. A side-effect is that, for certain settings of 'default_comments_page', up to 2x the value of `comments_per_page` might be fetched at a time.
* In support of these changes, a `$format` parameter has been added to `WP_Comment::get_children()`. This param allows you to request a flattened array of comment children, suitable for feeding into `Walker_Comment`.
* `WP_Query` loops are now informed about total available comment counts and comment pages by the `WP_Comment_Query` (`found_comments`, `max_num_pages`), instead of by `Walker_Comment`.

Aside from radical performance improvements in the case of a post with many
comments, this changeset fixes a bug that caused the first page of comments to
be partial (`found_comments` % `comments_per_page`), rather than the last, as
you'd expect.

Props boonebgorges, wonderboymusic.
Fixes #8071.
Built from https://develop.svn.wordpress.org/trunk@34561


git-svn-id: http://core.svn.wordpress.org/trunk@34525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 20:40:25 +00:00