Commit Graph

21322 Commits

Author SHA1 Message Date
Aaron Campbell a9f9235d88 Strip control characters before validating redirect.
Merges [40183] to 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@40186


git-svn-id: http://core.svn.wordpress.org/branches/4.5@40125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 13:42:04 +00:00
Dominik Schilling 4c805032cb Embeds: URL encode YouTube video IDs for broader compatibility.
Merge of [40160] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@40163


git-svn-id: http://core.svn.wordpress.org/branches/4.5@40102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-06 12:06:05 +00:00
Aaron Campbell 5697303ab4 Bump 4.5 branch to version 4.5.6.
Built from https://develop.svn.wordpress.org/branches/4.5@39998


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-26 18:21:32 +00:00
Dominik Schilling aa2ad2c3dd Query: Ensure that queries work correctly with post type names with special characters.
Merge of [39952] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@39958


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-26 13:50:32 +00:00
Aaron Campbell 438fd7f3bb Bump 4.5 branch to version 4.5.5.
Built from https://develop.svn.wordpress.org/branches/4.5@39862


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 16:55:29 +00:00
Joe McGill a1d67608bf Media: Fix exif_imagetype check in wp_get_image_mime
This is a follow up to [39831].

Merges [39850] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39853


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 16:40:32 +00:00
Joe McGill a8dcdd4fd5 Media: Improve image filetype checking.
This adds a new function `wp_get_image_mime()` which is used by
`wp_check_filetype_and_ext()` to validate image files using
`exif_imagetype()` if available instead of `getimagesize()`.

`getimagesize()` is less performant than `exif_imagetype()` and is
dependent on GD. If `exif_imagetype()` is not available, it falls back to
`getimagesize()` as before.

If `wp_check_filetype_and_ext()` can't validate the filetype, we now return
`false` for ext/MIME values.

Merges [39831] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39834


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 13:15:31 +00:00
Dominik Schilling c1684e38b0 Themes: Fix markup for theme name fallbacks.
Merge of [39807] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@39811


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 11:10:05 +00:00
Jeremy Felt 13d318d196 Multisite: Use `wp_rand()` in signup key creation.
Merges [39795] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39798


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 05:33:32 +00:00
Dion Hulse 440b7b387f Update PHPMailer to 5.2.22.
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.21...v5.2.22

Merges [39759] to the 4.5 branch.
Fixes #37210 for 4.5.

Built from https://develop.svn.wordpress.org/branches/4.5@39786


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 05:23:31 +00:00
Dion Hulse f991d9356c Mail: Upgrade PHPMailer to 5.2.21.
Merges [39645] to the 4.5 branch.
See #37210.

Built from https://develop.svn.wordpress.org/branches/4.5@39723


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-06 22:04:36 +00:00
Jeremy Felt 34ea4c35f4 Bump 4.5 branch to 4.5.4.
Built from https://develop.svn.wordpress.org/branches/4.5@38550


git-svn-id: http://core.svn.wordpress.org/branches/4.5@38493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 14:58:31 +00:00
Jeremy Felt ff1790b8e8 Media: Sanitize upload filename.
Merge of [38538] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@38540


git-svn-id: http://core.svn.wordpress.org/branches/4.5@38483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 13:57:58 +00:00
Pascal Birchler b7bb8822d7 Upgrade/Install: Sanitize file name in `File_Upload_Upgrader`.
Merge of [38524] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@38526


git-svn-id: http://core.svn.wordpress.org/branches/4.5@38467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-06 17:34:33 +00:00
Dominik Schilling c1e4d25350 The 4.5 branch is now 4.5.4-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@38000


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-07 12:07:32 +00:00
Boone Gorges b15f7577d3 Bump 4.5 branch to 4.5.3.
Built from https://develop.svn.wordpress.org/branches/4.5@37826


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 15:53:29 +00:00
Pascal Birchler 47e67b7d33 Media: Fix rendering of incorrect toolbar in the Edit view.
This switches event binding in `wp.media.controller.EditImage` to use `on`
instead of `listenTo` to restore rendering of the correct toolbar when the
`toolbar:render:edit-image` event fires. The existing listeners broke
when we upgraded Backbone in [36546].

Merge of [37678] to the 4.5 branch.

Props adamsilverstein.
Fixes #36861.
Built from https://develop.svn.wordpress.org/branches/4.5@37813


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:55:30 +00:00
Joe McGill b747172c20 Media: Improve handling of extensionless filenames.
Merge of [37756] to the 4.5 branch.

See #37111.
Built from https://develop.svn.wordpress.org/branches/4.5@37809


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:52:06 +00:00
Nikolay Bachiyski df44f6cbc4 Admin: escape URL-encoded permalinks
Merge of [37801] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@37806


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:50:03 +00:00
Pascal Birchler 63325a253e Media: Restore keyboard navigation of the media grid.
This changes the binding of event listeners in the Attachments Browser
to use `on` instead of `listenTo` for the `attachment:keydown:arrow` and
`attachment:details:shift-tab` events. The existing listeners broke
when we upgraded Backbone in [36546].

Merge of [37755] to the 4.5 branch.

Props adamsilverstein.
Fixes #36900.
Built from https://develop.svn.wordpress.org/branches/4.5@37804


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:49:28 +00:00
Rachel Baker 01fbbebff4 Revisions: Change the capability needed to view revision diffs to `edit_post`.
Merge of [37779] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@37791


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:27:33 +00:00
Nikolay Bachiyski 97bcc889a7 Admin: Escape attachment name in case it contains special characters
Merge of [37774] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@37783


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:23:45 +00:00
Dominik Schilling 45dc424bc1 Customize: Make sure that preview and return URLs are URLs.
Merge of [37527] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@37768


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:16:56 +00:00
Boone Gorges 4113f3fb69 Taxonomy: More specific cap check when processing category data on post save.
Ports [37691] to the 4.5 branch.

 Props dlh.
 Fixes #36379.
 Please enter the commit message for your changes. Lines starting
Built from https://develop.svn.wordpress.org/branches/4.5@37759


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:11:55 +00:00
Jeremy Felt c75e86705a Admin: Allow for the consistent filtering of `auth_redirect_scheme`
Merge of [37651] to the 4.5 branch.

See #37047.

Built from https://develop.svn.wordpress.org/branches/4.5@37757


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:10:30 +00:00
Pascal Birchler f5fdf443eb Menus: Support nested array variables in POST data when saving menus.
[36510] allowed larger menus to be created in the Edit Menu screen by JSON-encoding the entire form into a single input field. However, it did not correctly handle nested arrays.

This introduces a new `_wp_expand_nav_menu_post_data()` helper function to handle this POST data which uses `array_replace_recursive()` internally. Since the latter is only available on PHP 5.3+, we add a compatibility function to ensure PHP 5.2 support.

Merge of [37748] and [37750] to the 4.5 branch.

Props ericlewis, neverything, swissspidy.
Fixes #36590. See #14134.
Built from https://develop.svn.wordpress.org/branches/4.5@37754


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-20 19:50:30 +00:00
Aaron Jorbin 9b7c749c86 Output node and npm versions on travis.
In order to make local debugging of travis easier, output the npm and node versions when travis runs.

[37730] for 4.5.

see #37116. 

Built from https://develop.svn.wordpress.org/branches/4.5@37733


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 17:32:28 +00:00
Pascal Birchler e05facfc58 Embeds: Enforce a valid post ID when embedding a post from the current site.
Otherwise `wp_filter_pre_oembed_result()` could erroneously return the HTML of the current post instead of the intended result.

Merge of [37729] to the 4.5 branch.

Props kraftbj.
See #36767.
Built from https://develop.svn.wordpress.org/branches/4.5@37732


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 17:30:55 +00:00
Dominik Schilling c3a292dc76 Customize: Separate preview and actions in the site icon control.
Reverts [37456] to allow users to remove/change a site icon even if the attachment has corrupt/missing data about sizes.

Merge of [37724] to the 4.5 branch.

See #36749.
Built from https://develop.svn.wordpress.org/branches/4.5@37725


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 09:53:28 +00:00
Pascal Birchler e09e36af80 Fix tests after [37709].
Avoids using `assertNotFalse()` which is only available in PHPUnit 4.0 and above.

See [37708], [37710].
See #36767.
Built from https://develop.svn.wordpress.org/branches/4.5@37711


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-15 12:24:28 +00:00
Pascal Birchler ddfbf0cbe4 Embeds: Improve performance when embedding a post of the current site.
When the post being embedded is from the same site, there's no reason to do an HTTP request for it. The data can be fetched directly using `get_oembed_response_data()`.

Merge of [37708] to the 4.5 branch.

Fixes #36767.
Built from https://develop.svn.wordpress.org/branches/4.5@37709


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-15 11:32:29 +00:00
Dominik Schilling caf7ab7df5 Database: `dbDelta()` will no longer try to downgrade the size of `TEXT` and `BLOB` columns.
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Merge of [37525] to the 4.5 branch.

Props pento.
See #36748.


Built from https://develop.svn.wordpress.org/branches/4.5@37606


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-01 12:59:28 +00:00
Dominik Schilling d04d7ae710 TinyMCE: Fix inline toolbar positioning.
Introduced in [37000].
See 2fb8aa48e9.
See 5734a8d880.

Merge of [37559] to the 4.5 branch.

Props iseulde.
Fixes #36876.
Built from https://develop.svn.wordpress.org/branches/4.5@37605


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-01 12:32:27 +00:00
Dominik Schilling 71b97108db External Libraries: Update jQuery Migrate to 1.4.1.
http://blog.jquery.com/2016/05/19/jquery-migrate-1-4-1-released-and-the-path-to-jquery-3-0/

Unquoted selectors for attribute selectors should function once again (and output a warning so that plugins and themes using them can update).

Merge of [37472] to the 4.5 branch.

Props jorbin.
Fixes #36892.
Built from https://develop.svn.wordpress.org/branches/4.5@37604


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-01 12:25:31 +00:00
Dominik Schilling c988d1e5ac External Libraries: Update jQuery to 1.12.4.
Release post: https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.3...1.12.4

Merge of [37433] and [37526] to the 4.5 branch.

Fixes #36533.
Built from https://develop.svn.wordpress.org/branches/4.5@37528


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 09:34:30 +00:00
Dominik Schilling 4a57c6bace Media: Remove medium_large size from `$whitelist_options['media']` in `options.php`.
The `medium_large_size_w` and `medium_large_size_h` options were added to the
`$whitelist_options['media']` in options.php in [35479], which causes both options
to be set to `0` when the media settings are changed. When this occurs, the
medium_large image size will no longer be created when an image is uploaded.

Since these options aren't meant to be updated via the settings UI, they can be
safely removed from the whitelist.

Merge of [37435] to the 4.5 branch.

Props joemcgill.
Fixes #36531.
Built from https://develop.svn.wordpress.org/branches/4.5@37457


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:40:29 +00:00
Dominik Schilling 3d0c06e1f6 Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
Merge of [37452] to the 4.5 branch.

Props swissspidy.
See #35237.
Fixes #36838.
Built from https://develop.svn.wordpress.org/branches/4.5@37455


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:38:32 +00:00
Dominik Schilling 677c67fa2f TinyMCE: prevent showing the placeholder URL when adding a link and clicking more than once on the Insert Link button.
Merge of [37301] to the 4.5 branch.

Props iseulde.
Fixes #36637.
Built from https://develop.svn.wordpress.org/branches/4.5@37454


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:36:34 +00:00
Dominik Schilling 53acd1636d Customize: Handle filtering `sidebars_widgets` when the underlying option is non-existent.
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`. 

Merge of [37352] to the 4.5 branch.

See [37166].
See #36389.
Fixes #36660.
Built from https://develop.svn.wordpress.org/branches/4.5@37453


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:34:30 +00:00
Dominik Schilling e16574e010 Bootstrap/Load: Silence `ini_set()` in `wp_debug_mode()`.
Merge of [37448] to the 4.5 branch.

Props SergeyBiryukov.
Fixes #36708.
Built from https://develop.svn.wordpress.org/branches/4.5@37451


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:31:29 +00:00
Dominik Schilling 946b2cc8a2 Customize: Remove use of reserved word `default` in Underscore template which breaks IE8.
Fixes regression introduced in [36769].

Merge of [37417] to the 4.5 branch.

Props adamsilverstein.
Fixes #36793.

Built from https://develop.svn.wordpress.org/branches/4.5@37450


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:29:30 +00:00
Aaron Jorbin 5d60412106 Correct usage of Covers for Tests_Update_Comment_Count_Now
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with `::`.  See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers

See #35060, #36867


Built from https://develop.svn.wordpress.org/branches/4.5@37445


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 17:52:30 +00:00
Dominik Schilling 2429d91496 The 4.5 branch is now 4.5.3-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@37420


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 11:54:30 +00:00
Dominik Schilling ee28ddbf8f Bump 4.5 branch to 4.5.2.
Built from https://develop.svn.wordpress.org/branches/4.5@37384


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:11:28 +00:00
Nikolay Bachiyski bb244816c7 External Libraries: Update plupload from upstream
Built from https://develop.svn.wordpress.org/branches/4.5@37382


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:01:28 +00:00
Dominik Schilling a9a70e1bfb External Libraries: Update MediaElement.js from upstream.
Merge of [37370] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@37371


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 17:52:29 +00:00
Helen Hou-Sandí d7f37d8bc0 The 4.5 branch is now 4.5.2-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@37312


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-26 20:25:28 +00:00
Pascal Birchler 31d8e7d909 Bump 4.5 branch to version 4.5.1.
Built from https://develop.svn.wordpress.org/branches/4.5@37310


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-26 17:52:32 +00:00
Gary Pendergast 998a0152f4 Post 4.5.1-RC2 version bump.
Built from https://develop.svn.wordpress.org/branches/4.5@37295


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 05:57:27 +00:00
Gary Pendergast 20d537e973 4.5.1-RC2
Built from https://develop.svn.wordpress.org/branches/4.5@37294


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 05:52:27 +00:00
Gary Pendergast 59123b5b24 Database: Suppress connection error messages when `WP_DEBUG` isn't enabled.
This is a partial revert of [35860], which has been causing un-catchable warnings to be generated on some server configurations.

Merge of [37292] to the 4.5 branch.

Fixes #36629.
See #21870.


Built from https://develop.svn.wordpress.org/branches/4.5@37293


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 05:24:29 +00:00
Andrew Ozz c84cda9fd0 Post 4.5.1-RC version bump.
Built from https://develop.svn.wordpress.org/branches/4.5@37291


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 01:26:28 +00:00
Andrew Ozz 44e684419b 4.5.1-RC
Built from https://develop.svn.wordpress.org/branches/4.5@37290


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 01:09:28 +00:00
Dominik Schilling 9bfc7ded12 Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Merge of [37288] to the 4.5 branch.

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.
Built from https://develop.svn.wordpress.org/branches/4.5@37289


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 21:34:30 +00:00
Dominik Schilling 3ea969bb66 Media: Don't cache the results of `wp_mkdir_p()` in a persistent cache.
To improve the performance of `wp_upload_dir()` the result of `wp_mkdir_p()` was stored in a persistent cache, introduced in [36565]. But this becomes an issue when WordPress is scaled horizontally. You may end up caching a value for a server where the directory doesn't exist which will prevent further uploads on other servers because of the persistent cache.
The fix is to use a non-persistent cache.

Merge of [37285] to the 4.5 branch.

Props azaozz, ocean90.
See #34359.
Fixes #36621.
Built from https://develop.svn.wordpress.org/branches/4.5@37286


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 20:18:28 +00:00
John Blackbourn ca63f2f7bc Feeds: Revert [36230] which removed the `rss-http` feed content type. Removing this means that any feeds which are using this feed content type are now being served as `application/octet-stream` instead of `text/xml`.
See #36620

Merges [37282] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@37284


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 19:28:28 +00:00
Dominik Schilling 02f7ebf6bd Update `svn:mergeinfo` for [37274].
Built from https://develop.svn.wordpress.org/branches/4.5@37275


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 09:45:28 +00:00
Dominik Schilling 9f63726656 Rewrite Rules: After [36953], correctly replace existing rules on IIS when updating them.
Merge of [37273] to the 4.5 branch.

Props WiZZarD_.
Fixes #36506.
Built from https://develop.svn.wordpress.org/branches/4.5@37274


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 09:37:29 +00:00
Gary Pendergast 58ef0cfe87 Emoji: The diversity support test was incorrectly passing on all browsers.
[37028] missed some logic to capture the base emoji skin tone, to compare to the modified emoji skin tone. This caused all browsers to report that they supported skin tone modifiers, regardless of whether they actually did.

Merge of [37256] to the 4.5 branch.

Fixes #36604.


Built from https://develop.svn.wordpress.org/branches/4.5@37257


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-20 14:08:30 +00:00
Andrew Ozz 8a1f083851 TinyMCE:
- Update to 4.3.10, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt.
- Backport fix for typing the Euro sign on Windows: 
5462e3c1dd.
- Backport copy/paste typo fix for the textcolor plugin: 1fc5a733e9.

Merges [37242] and [37251] to the 4.5 branch.
Fixes #36545 for 4.5.
Built from https://develop.svn.wordpress.org/branches/4.5@37253


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 23:24:28 +00:00
Dominik Schilling 62ba7f4052 Themes: Revert [36112]
Adding the `singular` class per default to the list of body classes is breaking the layout of Twenty Eleven and other themes. Twenty Eleven adds the `singular` class only to single pages if the page doesn't use specific page templates.

Merge of [37249] to the 4.5 branch.

Props flixos90, swissspidy.
Fixes #36510.
Built from https://develop.svn.wordpress.org/branches/4.5@37250


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 21:27:28 +00:00
Aaron Jorbin b363cf3170 Use `px` instead of `in` in device preview
Merges [37247] to the 4.5 branch

Props celloexpressions
Fixes #36457

Built from https://develop.svn.wordpress.org/branches/4.5@37248


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 20:54:28 +00:00
Dominik Schilling 9141a73031 TinyMCE, inline link: Fix VoiceOver in Safari for search suggestions.
Merge of [37228] to the 4.5 branch.

Props afercia.
Fixes #36458.
Built from https://develop.svn.wordpress.org/branches/4.5@37246


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 20:48:28 +00:00
Dominik Schilling f0152dc74c Media: Resolve fatal error on resize with ImageMagick < 6.4.6
Improper checking for 'Imagick::ALPHACHANNEL_UNDEFINED' and
'Imagick::ALPHACHANNEL_OPAQUE' caused fatal errors for some users
with Imagick when compiled against ImageMagick < 6.4.6, when these
constants were introduced. Fixes these compatibility checks.

Merge of [37192] to the 4.5 branch.

Props gblsm.
Fixes #36501.
Built from https://develop.svn.wordpress.org/branches/4.5@37245


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 20:46:30 +00:00
Helen Hou-Sandí a367bb8b59 Version strings typically should contain a revision number.
Built from https://develop.svn.wordpress.org/branches/4.5@37187


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 01:40:30 +00:00
Helen Hou-Sandí 4851ef111c The 4.5 branch is now 4.5.1-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@37182


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-12 19:58:21 +00:00
Mike Schroder 59d0cd77dd WordPress 4.5
Built from https://develop.svn.wordpress.org/trunk@37179


git-svn-id: http://core.svn.wordpress.org/trunk@37146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-12 17:29:26 +00:00
Mike Schroder b3030ca696 About Page: Add Final Video
Props siobhan, melchoyce, hugobaeta, rosso99.
Built from https://develop.svn.wordpress.org/trunk@37178


git-svn-id: http://core.svn.wordpress.org/trunk@37145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-12 17:25:28 +00:00
Mike Schroder 6763394e10 Post 4.5-RC3 version bump.
Built from https://develop.svn.wordpress.org/trunk@37177


git-svn-id: http://core.svn.wordpress.org/trunk@37144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-11 19:13:26 +00:00
Mike Schroder cbd085e290 4.5-RC3
Built from https://develop.svn.wordpress.org/trunk@37176


git-svn-id: http://core.svn.wordpress.org/trunk@37143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-11 18:31:27 +00:00
Dominik Schilling 74102fb128 About Page: Use `srcset` and the w.org CDN for images.
Also, flip the "Selective Refresh" and "Smart Image Resizing" section and remove script enqueues which are no longer used.

Props joemcgill, melchoyce, ocean90.
Fixes #36173.
Built from https://develop.svn.wordpress.org/trunk@37175


git-svn-id: http://core.svn.wordpress.org/trunk@37142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-11 17:46:27 +00:00
Dominik Schilling 12599ea170 TinyMCE, inline link: Make styles for the autocomplete results available on front end.
Also, replace the generic `.alignright` class with a more specific class to avoid styling issues with themes which have padding/margin attached to `.alignright`.

Props azaozz, imath.
Fixes #36461.
Built from https://develop.svn.wordpress.org/trunk@37174


git-svn-id: http://core.svn.wordpress.org/trunk@37141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-11 15:12:29 +00:00
Mike Schroder a116d786a5 Post 4.5-RC2 version bump.
Built from https://develop.svn.wordpress.org/trunk@37173


git-svn-id: http://core.svn.wordpress.org/trunk@37140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-10 05:16:27 +00:00
Mike Schroder 388cf29da4 4.5-RC2
Built from https://develop.svn.wordpress.org/trunk@37172


git-svn-id: http://core.svn.wordpress.org/trunk@37139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-10 04:21:27 +00:00
Jeremy Felt 4d9c9b9433 Ensure consistent dependency order when using `wp_add_inline_script()`
This disables the concatenation of remaining enqueued scripts once `wp_add_inline_script()` is invoked, which allows us to reliably print these scripts and their before/after inline scripts in the desired order.

Props gitlost, azaozz, swisspidy, ocean90.
Fixes #36392.

Built from https://develop.svn.wordpress.org/trunk@37171


git-svn-id: http://core.svn.wordpress.org/trunk@37138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-10 03:33:26 +00:00
Jeremy Felt a70a6c4bae 4.5 About Page, second round.
* Adjust text.
* Improve headings hierarchy.
* Add translation functions and translator comments throughout.

Props ocean90, afercia, ramiy, mikeschroder, mattfelten, helen. 
See #36173.

Built from https://develop.svn.wordpress.org/trunk@37170


git-svn-id: http://core.svn.wordpress.org/trunk@37137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-10 02:03:29 +00:00
Andrew Ozz 4e6b257fa3 4.5 About screen.
Props mikeschroder, melchoyce, ocean90, ryelle, jeremyfelt, Ipstenu, celloexpressions, DrewAPicture.
See #36173.
Built from https://develop.svn.wordpress.org/trunk@37169


git-svn-id: http://core.svn.wordpress.org/trunk@37136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-09 06:23:26 +00:00
Helen Hou-Sandí 5d8b9805eb Default theme bumps for 4.5.
* Twenty Eleven 2.4
* Twenty Twelve 2.0
* Twenty Thirteen 1.9
* Twenty Fourteen 1.7
* Twenty Fifteen 1.5

props davidakennedy, ocean90.
fixes #36354.

Built from https://develop.svn.wordpress.org/trunk@37168


git-svn-id: http://core.svn.wordpress.org/trunk@37135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-08 21:22:28 +00:00
Andrew Ozz c353544c47 Customizer: fix cropping of small images when setting header image, site icon or logo.
Props obenland.
Fixes #36412.
Built from https://develop.svn.wordpress.org/trunk@37167


git-svn-id: http://core.svn.wordpress.org/trunk@37134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-08 01:23:29 +00:00
Dominik Schilling 9363b592e3 Customize: Harden assignment of Customizer settings transports for selective refreshable widgets
Theme support for `customize-selective-refresh-widgets` can be added _after_ the logic for registering the settings for incoming widgets that have been changed. This is due to themes adding the theme support in `after_setup_theme` which is also the action where `WP_Customize_Widgets::register_settings()` is called. If these both happen at priority 10, which one is called first depends on which one was added first. The other issue is that at the time that `WP_Customize_Widgets::register_settings()` is called at `after_setup_theme`, it is called before `widgets_init` and thus no widgets are yet registered. This means that any settings registered at this point will always have a `refresh` transport even if the theme supports `customize-selective-refresh-widgets`, since the `WP_Widget` instance is not visible yet to see if it supports selective refresh.

The fix: Defer `WP_Customize_Widgets::register_settings()` from `after_setup_theme` to `widgets_init` at priority 95 when the widget objects have all been registered. Also, ensure that the preview filter for `sidebars_widgets` is added before the sidebars are iterated for adding the controls.

Props westonruter.
Fixes #36389.
Built from https://develop.svn.wordpress.org/trunk@37166


git-svn-id: http://core.svn.wordpress.org/trunk@37133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-07 20:59:29 +00:00
Boone Gorges cfab9716e3 Use `__trashed` suffix rather than `-%trashed%` for trashed post slugs.
Percent signs are reserved characters in URIs. As such, it was impossible for
plugins to route requests to trashed posts, as happens in bbPress. The new
`__trashed` suffix should be sufficiently unique.

Also adds a test that demonstrates that the `__trashed` suffix can be
appended to slugs that contain the suffix somewhere other than the end of
the string.

Props netweb, ericlewis.
Fixes #11863.
Built from https://develop.svn.wordpress.org/trunk@37165


git-svn-id: http://core.svn.wordpress.org/trunk@37132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-07 19:22:28 +00:00
Aaron Jorbin 1c1daa7ba4 External Libraries: Update jQuery to 1.12.3.
Sing it with me: jQuery fixed two issues, now you can get them with WP 4.5.

Release Post: http://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.2...1.12.3

Fixes #35380.
Props ocean90.


Built from https://develop.svn.wordpress.org/trunk@37164


git-svn-id: http://core.svn.wordpress.org/trunk@37131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 22:45:27 +00:00
Mark Jaquith 31152de134 REST API: Deliver parameters unadulterated instead of slashed.
We goofed, and parameters accessed through the REST API's methods
were slashed (inconsistently, even). This unslashes the data, so
you get the un-messed-with data that was sent.

Props joehoyle.
Fixes #36419.
Built from https://develop.svn.wordpress.org/trunk@37163


git-svn-id: http://core.svn.wordpress.org/trunk@37130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 21:02:28 +00:00
Dominik Schilling b3b22fa1c6 I18N: On the Updates screen simplify plugin's version details link.
Replace the use of a `.screen-reader-text` element with an `aria-label` attribute to make the text easier to translate.

Props dimadin, ocean90.
See #35001.
Fixes #36410.
Built from https://develop.svn.wordpress.org/trunk@37162


git-svn-id: http://core.svn.wordpress.org/trunk@37129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 12:52:30 +00:00
Aaron Jorbin 6c24223def Make Moderate Comment Screen Great Again by showing links
You know what's wrong with the Moderate Comment Screen? It doesn't win anymore. Well, I'm going make the Moderate Comment screen win. It's going to win by showing the urls that are linked to from every anchor. It's going to win by having those urls be a lighter shade of gray than the surrounding text. Spammy links aren't going to be able to hide in commas. Spammy links aren't going to win.  The Moderate Comment Screen is going to win and we are going to make the Moderate Comment Screen Great Again.

Fixes #36380
Props rachelbaker, mikeschroder, adamsilverstein, boonebgorges, melchoyce, ocean90, jorbin, pento

Built from https://develop.svn.wordpress.org/trunk@37161


git-svn-id: http://core.svn.wordpress.org/trunk@37127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-06 00:35:27 +00:00
Andrea Fercia 1bb3dd0ee7 Accessibility: improvements for the Editor wpLink modal form fields.
Adds `aria-describedby` attributes to the modal form fields after it
was partly restored in [37154].

Fixes #33301.
Built from https://develop.svn.wordpress.org/trunk@37160


git-svn-id: http://core.svn.wordpress.org/trunk@37126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-05 22:24:27 +00:00
Dominik Schilling f5c3c658a4 Editor: Remove trailing space from a help text string.
Props dimadin.
Fixes #36407.
Built from https://develop.svn.wordpress.org/trunk@37159


git-svn-id: http://core.svn.wordpress.org/trunk@37125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-05 10:54:29 +00:00
John Blackbourn 32b262fa1c Comments: Wrap the formatted comment text on the comment moderation screen in `comment_text()` so paragraphs and texturisation are applied.
Fixes #34133

Built from https://develop.svn.wordpress.org/trunk@37158


git-svn-id: http://core.svn.wordpress.org/trunk@37124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-04 23:33:27 +00:00
John Blackbourn 217b3b6487 Role/Capability: Add `create_sites` and `delete_sites` to the list of capabilities that are checked as part of the comporehensive roles and capabilities tests.
See #32394, #36413

Built from https://develop.svn.wordpress.org/trunk@37157


git-svn-id: http://core.svn.wordpress.org/trunk@37123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-04 22:30:28 +00:00
Dominik Schilling 3067561bd7 Plugins: Use correct placeholder for the number of reviews.
`number_format_i18n()` returns a string, not an integer.

See #35111.
Fixes #36395.
Built from https://develop.svn.wordpress.org/trunk@37156


git-svn-id: http://core.svn.wordpress.org/trunk@37122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-02 11:17:26 +00:00
Dominik Schilling 72a544168a I18N: Clarify translator comment for an a11y label added in [36618].
Props TacoVerdo.
See #35111.
Fixes #36396.
Built from https://develop.svn.wordpress.org/trunk@37155


git-svn-id: http://core.svn.wordpress.org/trunk@37121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-02 11:12:26 +00:00
Andrew Ozz 2618ccf64d Editor, wpLink:
- Restore the bottom half of the modal.
- Make it always expanded and remove the toggle. It is used as advanced link options now, no need to have simple mode.

Props iseulde, adamsilverstein, azaozz.
Fixes #36359.
Built from https://develop.svn.wordpress.org/trunk@37154


git-svn-id: http://core.svn.wordpress.org/trunk@37120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-01 21:13:29 +00:00
Weston Ruter a311bea6d1 Customize: Fix toggle of title attribute field visibility on nav menus admin page.
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.

Built from https://develop.svn.wordpress.org/trunk@37153


git-svn-id: http://core.svn.wordpress.org/trunk@37119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:55:27 +00:00
Weston Ruter 1a9fda07a4 Customize: Put focus on change button instead of remove button in media control.
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.

Props adamsilverstein, westonruter.
Fixes #36337.

Built from https://develop.svn.wordpress.org/trunk@37152


git-svn-id: http://core.svn.wordpress.org/trunk@37118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 21:41:26 +00:00
Aaron Jorbin 328b4aff92 Adjust unit tests to account for change in [37144]
Built from https://develop.svn.wordpress.org/trunk@37150


git-svn-id: http://core.svn.wordpress.org/trunk@37117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 19:53:25 +00:00
Aaron Jorbin 4e3df608dc Remove Debugging code introduced in [37145]
Built from https://develop.svn.wordpress.org/trunk@37148


git-svn-id: http://core.svn.wordpress.org/trunk@37115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:58:26 +00:00
Aaron Jorbin bd7ffca854 Add Nonce to updating wporg_favorites user meta field
Built from https://develop.svn.wordpress.org/trunk@37145


git-svn-id: http://core.svn.wordpress.org/trunk@37112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:36:26 +00:00
Nikolay Bachiyski 9b7a775413 Add nonce to AJAX action for script compression setting
Built from https://develop.svn.wordpress.org/trunk@37143


git-svn-id: http://core.svn.wordpress.org/trunk@37110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:21:25 +00:00
Konstantin Obenland db47a4913c Template: Remove `$size` reference from `get_custom_logo()`.
Argument was removed in [37077] in favor of `with` and `height` arguments.

Props ocean90.
Fixes #36327.


Built from https://develop.svn.wordpress.org/trunk@37135


git-svn-id: http://core.svn.wordpress.org/trunk@37102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 17:20:27 +00:00
Nikolay Bachiyski b4d97cc8a7 Taxonomies: make sure taxonomy functions work correctly with taxonomy names with special characters
The codex says that taxonomy names "should only contain lowercase letters and the underscore character", but that's not enforced. It's too late to enforce it, since some plugins haven't been following it and the official phpdoc doesn't mention this restriction.

Built from https://develop.svn.wordpress.org/trunk@37133


git-svn-id: http://core.svn.wordpress.org/trunk@37100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 17:13:28 +00:00