fce93c4771
In `get_terms()`, assemble `WHERE` conditions in an array instead of concatenating.
...
This method is more reliable when adding new `WHERE` conditions.
See #35495 .
Built from https://develop.svn.wordpress.org/trunk@36598
git-svn-id: http://core.svn.wordpress.org/trunk@36565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 20:04:26 +00:00
acb6cb1d74
TinyMCE: fix the regex that removes spaces from empty paragraphs. Was causing problems when wpautop is disabled and there are many U+00A0 chars between the opening `<p>` and an inline tag. These chars are inserted by the browsers to maintain consecutive spaces typed by the users in contentEditable.
...
Fixes #35890 .
Built from https://develop.svn.wordpress.org/trunk@36597
git-svn-id: http://core.svn.wordpress.org/trunk@36564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 19:56:27 +00:00
24cfa6a40a
Tests: Test that jQuery can be moved into footer after [36550].
...
Props gitlost.
See #25247 .
Built from https://develop.svn.wordpress.org/trunk@36596
git-svn-id: http://core.svn.wordpress.org/trunk@36563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 16:17:25 +00:00
21b9965613
Theme Compat: Replace the custom comment form with `comment_form()` and reduce number of links.
...
`comment_form()` has nearly the same markup as the custom form but also includes the latest enhancements like improved a11y and more filters.
Add translators comments, props ramiy.
Fixes #35888 .
Built from https://develop.svn.wordpress.org/trunk@36595
git-svn-id: http://core.svn.wordpress.org/trunk@36562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 14:41:27 +00:00
26955c8507
Tests: Add decorators to PHPMailer mock object.
...
The new `get_recipient()` and `get_sent()` methods greatly simplify the
syntax required when writing tests for `wp_mail()`.
Props welcher.
Fixes #34161 .
Built from https://develop.svn.wordpress.org/trunk@36594
git-svn-id: http://core.svn.wordpress.org/trunk@36561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 03:41:27 +00:00
9fdb970ceb
Docs: Add missing @since and @access tags to `get_curies` method and filter from r36533
...
See #34729 , #32246 .
Built from https://develop.svn.wordpress.org/trunk@36593
git-svn-id: http://core.svn.wordpress.org/trunk@36560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 23:42:27 +00:00
a04b869652
Styles: Pass the media attribute as an argument to the `style_loader_tag` filter.
...
Props sebastian.pisula.
Fixes #34765 .
Built from https://develop.svn.wordpress.org/trunk@36592
git-svn-id: http://core.svn.wordpress.org/trunk@36559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 21:05:26 +00:00
0285fd946d
Script Loader: Don't parse `$src` if the current color scheme isn't registered.
...
Avoids a `parse_url()` call on each request if the default colors scheme is in use.
Fixes #35882 .
Built from https://develop.svn.wordpress.org/trunk@36591
git-svn-id: http://core.svn.wordpress.org/trunk@36558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 20:44:26 +00:00
9d8204467c
Styles: Bail if `WP_Styles::_css_href()` returns an empty value.
...
The style `colors` gets registered with `true` as the source value which gets handled later by `wp_style_loader_src()`, a callback for the `style_loader_src` filter in `WP_Styles::_css_href()`. `wp_style_loader_src()` may return false, for example for the default color scheme.
This was removed in [36550].
See #35229 .
Built from https://develop.svn.wordpress.org/trunk@36590
git-svn-id: http://core.svn.wordpress.org/trunk@36557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 20:34:26 +00:00
edceb0173c
TinyMCE: update to 4.3.4. Changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt .
...
Fixes #35876 .
Built from https://develop.svn.wordpress.org/trunk@36589
git-svn-id: http://core.svn.wordpress.org/trunk@36556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 19:19:26 +00:00
06225cc394
Comments: Refresh the Moderate Comment screen for a friendlier experience with email moderation actions.
...
Brings some love to this neglected screen:
* format `comment_content`, instead of escaping in one massive block of text
* only wrap the comment date in a link if the comment permalink exists
* include link to the Edit Comment screen at the bottom of the comment_content
* update the message styles to match other screens
* append `#wpbody-content` to the comment email message links for accessibility
Props johnbillion, rachelbaker, afercia, melchoyce, karmatosed.
Fixes #34133
Built from https://develop.svn.wordpress.org/trunk@36588
git-svn-id: http://core.svn.wordpress.org/trunk@36555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 19:14:26 +00:00
30866ceb5d
Accessibility: Improve color contrast updating any `#999` gray used for text or icons to a darker gray.
...
Fixes #35660 .
Built from https://develop.svn.wordpress.org/trunk@36587
git-svn-id: http://core.svn.wordpress.org/trunk@36554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:44:27 +00:00
6b775d4afe
Customize: Add selective refresh framework with implementation for widgets and re-implementation for nav menus.
...
See https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/ .
Props westonruter, valendesigns, DrewAPicture, ocean90.
Fixes #27355 .
Built from https://develop.svn.wordpress.org/trunk@36586
git-svn-id: http://core.svn.wordpress.org/trunk@36553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:41:28 +00:00
0f88dbfee0
Accessibility: Fix displaying of Universal time and Local time info on the General Settings screen.
...
In [36263] they were mistakenly moved within a conditional check.
Fixes #35064 .
Built from https://develop.svn.wordpress.org/trunk@36585
git-svn-id: http://core.svn.wordpress.org/trunk@36552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 16:09:26 +00:00
08510d2e5d
Accessibility: after [36000] conditionally print out the `aria-describedby` attribute on the Featured Image postbox.
...
Fixes #35076 .
Built from https://develop.svn.wordpress.org/trunk@36584
git-svn-id: http://core.svn.wordpress.org/trunk@36551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 15:10:28 +00:00
34010353cc
Customize: Prevent consecutive `refresh` requests from preview from causing JS error.
...
Fixes "Uncaught TypeError: this.targetWindow is not a function".
See #27355 .
Fixes #35866 .
Built from https://develop.svn.wordpress.org/trunk@36583
git-svn-id: http://core.svn.wordpress.org/trunk@36550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 03:47:27 +00:00
77dbab1e1b
Accessibility: Reduce the WordPress shades of grey, Episode 2.
...
See #35783 .
Built from https://develop.svn.wordpress.org/trunk@36582
git-svn-id: http://core.svn.wordpress.org/trunk@36549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 22:30:27 +00:00
ecdcae565e
Plugins: Remove an unused variable after [35953].
...
Fixes #35050 .
Built from https://develop.svn.wordpress.org/trunk@36581
git-svn-id: http://core.svn.wordpress.org/trunk@36548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:33:25 +00:00
6f2a56bf3e
Themes: After [36546] restore theme search functionality.
...
* Correct several incorrect uses of `_.union`. Since Underscore 1.7.0 `_.union` supports only arrays and not variadic args.
* Use a namespaced event `themes:update`. Backbone 1.2 added a built in `update` event that triggers after any amount of models are added or removed from a collection.
Props adamsilverstein.
See #34350 .
Built from https://develop.svn.wordpress.org/trunk@36580
git-svn-id: http://core.svn.wordpress.org/trunk@36547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:21:26 +00:00
284f88e35a
Themes: Fix flickering of the theme screenshot on hover in WebKit browsers.
...
Props JoeFusco.
Fixes #35787 .
Built from https://develop.svn.wordpress.org/trunk@36579
git-svn-id: http://core.svn.wordpress.org/trunk@36546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:11:27 +00:00
529a53e903
Formatting: Avoid a PHP warning when `wptexturize()` is called with a trailing less-than symbol.
...
Props westonruter.
Fixes #35864 .
Built from https://develop.svn.wordpress.org/trunk@36578
git-svn-id: http://core.svn.wordpress.org/trunk@36545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 20:31:27 +00:00
cc1261f7fd
Docs: Add an explanation for the dynamic portion of the `{$taxonomy}_term_edit_form_top` hook, introduced in [36526].
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36577
git-svn-id: http://core.svn.wordpress.org/trunk@36544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 18:19:26 +00:00
e020ccd081
Docs: Add formatting to a changelog entry in the hook doc for the `rest_dispatch_request` filter.
...
See [36534]. See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36576
git-svn-id: http://core.svn.wordpress.org/trunk@36543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 18:18:25 +00:00
71b735974b
Media Library: After [36546] restore the "Add new" functionality.
...
Rework handling of the `'toggle:upload:attachment'` event using `.on` vs `.listenTo` for better compatibility with the current version of Backbone.
Props adamsilverstein.
See #34350 .
Fixes #35853 .
Built from https://develop.svn.wordpress.org/trunk@36575
git-svn-id: http://core.svn.wordpress.org/trunk@36542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 17:50:26 +00:00
d499011145
Add missing test changes for [36573].
...
See #34755 .
Built from https://develop.svn.wordpress.org/trunk@36574
git-svn-id: http://core.svn.wordpress.org/trunk@36541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 17:44:26 +00:00
658d825ea9
Customizer: In nav menus show the location name instead of slug.
...
Props ryankienstra.
Fixes #34755 .
Built from https://develop.svn.wordpress.org/trunk@36573
git-svn-id: http://core.svn.wordpress.org/trunk@36540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 17:16:27 +00:00
7ee69ca8d1
Remove extra spaces between function names and brackets
...
These were introduced when making list table view modes sticky.
See #16774 , #34365 .
Built from https://develop.svn.wordpress.org/trunk@36572
git-svn-id: http://core.svn.wordpress.org/trunk@36539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 16:51:27 +00:00
956627ff83
Don't display errors during Ajax requests.
...
See #34915 for REST and #23811 for XML-RPC.
Props pento.
Fixes #26262 .
Built from https://develop.svn.wordpress.org/trunk@36571
git-svn-id: http://core.svn.wordpress.org/trunk@36538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 16:43:27 +00:00
04ad9e674d
HTTP API: Certificate bundle: Attempt to move a certificate lower in the file to allow older OpenSSL versions to parse it & communicate with WordPress.org securely again.
...
The OpenSSL version which was failing in this case was `OpenSSL 0.9.8e 23 Feb 2007`.
See #35637 #30434 #25007
Built from https://develop.svn.wordpress.org/trunk@36570
git-svn-id: http://core.svn.wordpress.org/trunk@36537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 08:21:28 +00:00
2d94e025a2
Replace `wp_upload_dir()` with the new `wp_get_upload_dir()` in all cases where a file is not being uploaded. Deprecate `_wp_upload_dir_baseurl()`, and replace it with `wp_get_upload_dir()`.
...
See #34359 .
Built from https://develop.svn.wordpress.org/trunk@36569
git-svn-id: http://core.svn.wordpress.org/trunk@36536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 00:24:27 +00:00
c6ee6246ef
Docs: Remove a duplicate `@static` tag from the `WP_Customize_Panel->instance_count` property DocBlock.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36568
git-svn-id: http://core.svn.wordpress.org/trunk@36535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 00:14:26 +00:00
d9945e5bd4
Reintroduce term meta unit test accidentally removed in [36566].
...
Built from https://develop.svn.wordpress.org/trunk@36567
git-svn-id: http://core.svn.wordpress.org/trunk@36534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 23:02:25 +00:00
571e14f897
More performance improvements to metadata lazyloading.
...
Comment and term meta lazyloading for `WP_Query` loops, introduced in 4.4,
depended on filter callback methods belonging to `WP_Query` objects. This meant
storing `WP_Query` objects in the `$wp_filter` global (via `add_filter()`),
requiring that PHP retain the objects in memory, even when the local variables
would typically be expunged during normal garbage collection. In cases where a
large number of `WP_Query` objects were instantiated on a single pageload,
and/or where the contents of the `WP_Query` objects were quite large, serious
performance issues could result.
We skirt this problem by moving metadata lazyloading out of `WP_Query`. The
new `WP_Metadata_Lazyloader` class acts as a lazyload queue. Query instances
register items whose metadata should be lazyloaded - such as post terms, or
comments - and a `WP_Metadata_Lazyloader` method will intercept comment and
term meta requests to perform the cache priming. Since `WP_Metadata_Lazyloader`
instances are far smaller than `WP_Query` (containing only object IDs), and
clean up after themselves far better than the previous `WP_Query` methods (bp
only running their callbacks a single time for a given set of queued objects),
the resource use is decreased dramatically.
See [36525] for an earlier step in this direction.
Props lpawlik, stevegrunwell, boonebgorges.
Fixes #35816 .
Built from https://develop.svn.wordpress.org/trunk@36566
git-svn-id: http://core.svn.wordpress.org/trunk@36533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:58:26 +00:00
da5b3a55c4
Improve the performance of `wp_upload_dir()`:
...
- Cache the output in non-persistent cache.
- Cache the result from `wp_mkdir_p()` in persistent cache (when present).
- Introduce `wp_get_upload_dir()` for use when not uploading files. It is equivalent to `wp_upload_dir()` but does not check for the existence or create the upload directory.
- Change tests to use the non-cached `_wp_upload_dir()`. They change options on the fly (should never be used in production) to simulate different environments.
- Introduce `_upload_dir_no_subdir()` and `_upload_dir_https()` to facilitate testing. These use the proper `upload_dir` filter to simulate different environments.
Props kovshenin, azaozz.
See #34359 .
Built from https://develop.svn.wordpress.org/trunk@36565
git-svn-id: http://core.svn.wordpress.org/trunk@36532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:51:26 +00:00
84350eb6b6
Add changelog entry for `publicly_queryable` argument in `register_taxonomy()`.
...
Missed in [36525].
Fixes #34491 .
Built from https://develop.svn.wordpress.org/trunk@36564
git-svn-id: http://core.svn.wordpress.org/trunk@36531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:04:32 +00:00
ca6726f331
Tests: Add test for `wp_get_installed_translations()`.
...
Introduces language files in /tests/phpunit/data/language. Each file includes the header and 5 translations.
Props realloc for initial patch.
Fixes #35284 .
Built from https://develop.svn.wordpress.org/trunk@36563
git-svn-id: http://core.svn.wordpress.org/trunk@36530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:02:26 +00:00
3e14571132
Multisite: Make view mode sticky for network users and sites list tables.
...
Fixes #34365 .
Built from https://develop.svn.wordpress.org/trunk@36562
git-svn-id: http://core.svn.wordpress.org/trunk@36529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 22:00:27 +00:00
e7a7f08c8b
Multisite: Avoid a PHP Notice when saving a site address without a path.
...
Props kjbenk.
Fixes #35631 .
Built from https://develop.svn.wordpress.org/trunk@36561
git-svn-id: http://core.svn.wordpress.org/trunk@36528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 20:50:27 +00:00
bffdae7b1d
Plugins: Remove slashes from search terms and use `urldecode()` in non-URL contexts.
...
Fixes #35712 .
Built from https://develop.svn.wordpress.org/trunk@36560
git-svn-id: http://core.svn.wordpress.org/trunk@36527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 20:15:26 +00:00
10234c1907
Tests: Add a test for testing `wp_enqueue_script()` with an alias handle in the footer.
...
Props kovshenin.
See #35643 .
Built from https://develop.svn.wordpress.org/trunk@36559
git-svn-id: http://core.svn.wordpress.org/trunk@36526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:53:26 +00:00
8b781dfaa7
Updates: Prevent further actions if an update button is disabled.
...
Props adamsilverstein, afercia.
Fixes #35257 .
Built from https://develop.svn.wordpress.org/trunk@36558
git-svn-id: http://core.svn.wordpress.org/trunk@36525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:42:26 +00:00
d1d90a3263
Make `$wp_local_package` explicitly global in wp-settings.php.
...
Props danielbachhuber.
Fixes #34975 .
Built from https://develop.svn.wordpress.org/trunk@36557
git-svn-id: http://core.svn.wordpress.org/trunk@36524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:32:25 +00:00
309ea2f138
Multisite: Add a hook to the end of the network's Add New User form.
...
The `network_user_new_form` action can be used to extend the new user form.
Props ptahdunbar.
Fixes #15389 .
Built from https://develop.svn.wordpress.org/trunk@36556
git-svn-id: http://core.svn.wordpress.org/trunk@36523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:15:26 +00:00
39cd3583a4
Multisite: Add a hook to the end of the Add Site form.
...
The `network_site_new_form` action can be used to extend the new site form.
Props igmoweb, ocean90.
Fixes #34739 .
Built from https://develop.svn.wordpress.org/trunk@36555
git-svn-id: http://core.svn.wordpress.org/trunk@36522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:03:25 +00:00
7e5a563876
Credits: Remove unused strings.
...
Props Ankit K Gupta.
Fixes #34909 .
Built from https://develop.svn.wordpress.org/trunk@36554
git-svn-id: http://core.svn.wordpress.org/trunk@36521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:00:28 +00:00
de0e09983d
Install: Enhance the language of the "Success" message.
...
Props ckoerner.
Fixes #34897 .
Built from https://develop.svn.wordpress.org/trunk@36553
git-svn-id: http://core.svn.wordpress.org/trunk@36520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 18:58:26 +00:00
442a637e1e
Tests: Add `Tests_dbDelta::assertTableHasPrimaryKey()`.
...
Also fix a typo in the name for the compound key.
Props charlestonsw.
Fixes #34877 .
Built from https://develop.svn.wordpress.org/trunk@36552
git-svn-id: http://core.svn.wordpress.org/trunk@36519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 18:55:27 +00:00
27b3dddb2e
Styles:
...
- Restore loading order for wp-admin: open-sans, dashicons, etc.
- Remove couple of redundant dependencies.
See #35229 .
Built from https://develop.svn.wordpress.org/trunk@36551
git-svn-id: http://core.svn.wordpress.org/trunk@36518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 18:01:26 +00:00
bc5d22266d
Script/Style Dependencies: Make sure that inline styles for handles without a source are printed.
...
This prevents breaking plugins which are adding inline styles to the `wp-admin` handle after [36341].
Props dd32, ocean90.
Fixes #35229 .
Built from https://develop.svn.wordpress.org/trunk@36550
git-svn-id: http://core.svn.wordpress.org/trunk@36517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 17:11:26 +00:00
0d89816985
Tests: Indent `test_wp_register_script()` with tabs.
...
Built from https://develop.svn.wordpress.org/trunk@36549
git-svn-id: http://core.svn.wordpress.org/trunk@36516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 16:07:26 +00:00
Boone Gorges
Andrew Ozz
Dominik Schilling
Rachel Baker
Andrea Fercia
Weston Ruter
Drew Jaynes
Jeremy Felt
Dion Hulse