Boone Gorges
b17cb707dc
Eliminate a db query when building the admin menu for non-privileged users.
...
Users who cannot `edit_posts` do not see the Comments nav item anyway, so
don't bother running a query that gets a comment count to display in the menu.
Props bordoni, johnbillion.
Fixes #19372 .
Built from https://develop.svn.wordpress.org/trunk@35691
git-svn-id: http://core.svn.wordpress.org/trunk@35655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:34:26 +00:00
Konstantin Obenland
5eeeeb89ce
Menu: Continue to use post dashicon as default menu icon.
...
Prevents a bug where custom post types without a specified menu icon would
adopt the menu icon of the preceding post type. Introduced in [33723].
See #16865 .
Fixes #34637 .
Built from https://develop.svn.wordpress.org/trunk@35590
git-svn-id: http://core.svn.wordpress.org/trunk@35554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 22:00:26 +00:00
Helen Hou-Sandí
7365e0ebbb
Don't show the "Add New" link on `post-new.php`.
...
Using the same `$post_new_file` global variable name in `wp-admin/menu.php` in [33723] was unintentional, but we're already unsetting other variables that are in global scope so we can just unset this one as well. Someday the admin menu won't be a big pile of sad and cryptic globals. Maybe.
props johnjamesjacoby, norcross.
fixes #34045 .
Built from https://develop.svn.wordpress.org/trunk@34723
git-svn-id: http://core.svn.wordpress.org/trunk@34687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 00:48:25 +00:00
Scott Taylor
3cad9d8385
After [33723], ensure that `$i` is properly set before looping.
...
See #16865 .
Built from https://develop.svn.wordpress.org/trunk@33867
git-svn-id: http://core.svn.wordpress.org/trunk@33835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:48:22 +00:00
Scott Taylor
21c61251a2
With a few modifications in `wp-admin/menu.php`, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare `menu_position` on post type registration.
...
Props scribu, wonderboymusic.
Fixes #16865 .
Built from https://develop.svn.wordpress.org/trunk@33723
git-svn-id: http://core.svn.wordpress.org/trunk@33690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-24 21:19:24 +00:00
Scott Taylor
c6a4512b1b
Add missing doc blocks to `wp-admin/includes/*`.
...
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32654
git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor
282e28ad81
Add `@global` annotations to (the rest of the?) `wp-admin/*` files.
...
Does not include list table file changes.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32643
git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:06:31 +00:00
Jeremy Felt
b5b5c98e0a
Introduce delete_site meta capability.
...
Map `delete_site` as a meta capability to `manage_options` so that the ability to delete sites can be more granularly managed for individual site administrators on a multisite network.
Props thomaswm.
Fixes #30470 .
Built from https://develop.svn.wordpress.org/trunk@31673
git-svn-id: http://core.svn.wordpress.org/trunk@31654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 02:10:30 +00:00
Dominik Schilling
4b66a66b20
Escape Customizer links in the admin menu. Fix usage of `add_query_arg()`.
...
props iseulde.
fixes #30952 .
Built from https://develop.svn.wordpress.org/trunk@31427
git-svn-id: http://core.svn.wordpress.org/trunk@31408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:48:27 +00:00
Scott Taylor
9ea224b78f
The menu items for `users.php` and `profile.php` that require the `promote_users` cap should be wrapped in an `is_multisite()` conditional a la `user-new.php`.
...
Props SergeyBiryukov.
Fixes #30526 .
Built from https://develop.svn.wordpress.org/trunk@30659
git-svn-id: http://core.svn.wordpress.org/trunk@30649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 19:18:23 +00:00
Dominik Schilling
cffba3c1ba
Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
...
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.
props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569 , #25571 , #28032 .
Built from https://develop.svn.wordpress.org/trunk@30459
git-svn-id: http://core.svn.wordpress.org/trunk@30450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 15:29:23 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Dominik Schilling
57c914f75a
Customizer: Add meta capability `customize` which is mapped to `edit_theme_options`.
...
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.
props westonruter, nacin.
fixes #28605 .
Built from https://develop.svn.wordpress.org/trunk@29170
git-svn-id: http://core.svn.wordpress.org/trunk@28954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 19:01:16 +00:00
Sergey Biryukov
2fa0de5f6f
Avoid inadvertently adding admin page titles as classes for admin menu submenu items.
...
fixes #28817 .
Built from https://develop.svn.wordpress.org/trunk@29083
git-svn-id: http://core.svn.wordpress.org/trunk@28869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 01:10:15 +00:00
Helen Hou-Sandí
725c824075
When accessing the Customizer from the admin menu, make sure the user is returned to the originating page upon close. We should still investigate the general usage of `customize-loader.js` moving forward, but this approach fixes the immediate issue. props westonruter. fixes #25457 .
...
Built from https://develop.svn.wordpress.org/trunk@29026
git-svn-id: http://core.svn.wordpress.org/trunk@28814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 17:15:14 +00:00
Dominik Schilling
d23cd0aa50
Introduce a `.dashicons-before` CSS class.
...
If you want to use a Dashicon before an element you can use the class because it will not change the elements content styling. With that you don't need to copy the entire `.dashicons` styling to your :before styling anymore.
To demonstrate this change, Admin Menu now uses Dashicons classes directly.
And it fixes a glitch in IE.
fixes #26630 .
Built from https://develop.svn.wordpress.org/trunk@27418
git-svn-id: http://core.svn.wordpress.org/trunk@27265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 20:04:14 +00:00
Andrew Nacin
9b29ad0529
Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
...
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.
To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.
props helen.
fixes #25147 .
Built from https://develop.svn.wordpress.org/trunk@26664
git-svn-id: http://core.svn.wordpress.org/trunk@26554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 06:38:09 +00:00
Dominik Schilling
8688857816
Introduce show_in_menu for register_taxonomy.
...
Accepts boolean: true to show, false to hide. If not set, the default is inherited from show_ui.
fixes #20930 .
Built from https://develop.svn.wordpress.org/trunk@25133
git-svn-id: http://core.svn.wordpress.org/trunk@25113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-26 22:35:10 +00:00
Sergey Biryukov
2a14c96057
Correct phpdoc for wp-admin/menu.php. props neoxx. fixes #25124 .
...
Built from https://develop.svn.wordpress.org/trunk@25100
git-svn-id: http://core.svn.wordpress.org/trunk@25082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-23 13:53:11 +00:00
Andrew Nacin
2e758c4b22
Customize requires edit_theme_options. If you only have switch_themes (rare, but a case that core supports), you should not have access. fixes #21413 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:37:26 +00:00
Andrew Nacin
b11654ce74
Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00
Mark Jaquith
8c4aeb9188
Add "Customize" as first item under Appearance menu.
...
fixes #21413 . props ryanhellyer, obenland, DrewAPicture
git-svn-id: http://core.svn.wordpress.org/trunk@23871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:39:54 +00:00
Andrew Nacin
61caecfa93
Use the create_posts post type cap in more places. Remove the janky create_posts meta cap. see #16714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:28:20 +00:00
Andrew Nacin
f63e0b1df9
Use create_posts whenever linking to post-new.php. props johnbillion. fixes #16714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 18:24:11 +00:00
Ryan Boren
f8f60ac01b
Introduce create_posts meta capability. Props scribu, nacin, casben79. see #16714
...
git-svn-id: http://core.svn.wordpress.org/trunk@22060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 15:33:19 +00:00
Andrew Nacin
33af30eb7f
Use the regular post type UI for editing single media items (attachments).
...
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
* Taxonomies attached to the media library now appear in the admin menu (if show_ui).
* Editing, cropping, uploading, etc. is still very rough, but mostly functional.
API-wise:
* New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
* Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
* wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
* New edit_form_after_title hook.
props helenyhou, ocean90. see #21391 .
git-svn-id: http://core.svn.wordpress.org/trunk@21948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 22:52:54 +00:00
Andrew Ozz
b443373e8e
Admin menu: add phpdoc/inline comments describing the usage of the param $icon_url in add_menu_page(), add string 'none' to be used when a menu icon is added from CSS, switch core items in the admin menu to use 'none', fixes #21349
...
git-svn-id: http://core.svn.wordpress.org/trunk@21877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 22:51:44 +00:00
Andrew Nacin
7fd32ab9fc
Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
...
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.
The text and implementation may change a bit. see #16416 .
git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:28:57 +00:00
nacin
5b285e0803
Un-indent after [21198]. see #19824 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:55:09 +00:00
nacin
fbd46fbc8c
Allow the 'WordPress Updates' page to be accessible even if you cannot update core, as long as you can update plugins or themes. fixes #21124 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:54:05 +00:00
nacin
9d20dfc4e1
Enforce multisite plugins menu preference in map_meta_cap(). This means a simple current_user_can('activate_plugins') check will handle the 'Enable administration menus' setting.
...
Remove bogus checks for enabling/disabling the 'themes' menu (something core does not handle out of the box) when in the network admin.
fixes #21123 .
git-svn-id: http://core.svn.wordpress.org/trunk@21198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:40:25 +00:00
azaozz
817b932ed1
Don't hide links to the upload form and show an error for mobile devices that cannot upload, see #20410
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-12 00:16:37 +00:00
azaozz
1d12cd07b0
Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 01:19:30 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
azaozz
7f9b0fcc1e
Don't show the uploader on iPads (it's pointless), fixes #19004
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 08:43:16 +00:00
nacin
3526f8a7da
Context for 'All Links'. props SergeyBiryukov, pavelevap. fixes #18096 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-07 17:28:20 +00:00
duck_
c1d1590171
Fix typos in documentation (wp-admin/). See #18560 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 14:18:10 +00:00
ryan
c2d37a3d65
Consolidate update count code into wp_get_update_data(). Props mitchoyoshitaka. fixes #17694
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-26 18:39:57 +00:00
ryan
daa14c36f9
Bring out the pinking shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 23:01:45 +00:00
ryan
ebdc0d02b6
Fix warnings in menu.php when plugins.php is enabled for non-supes. Props PeteMall. fixes #17702
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-06 16:59:24 +00:00
nacin
e811e73322
s/Themes Updates/Theme Updates/. props mitchoyoshitaka. fixes #17701 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-06 00:30:17 +00:00
ryan
15a6a89eb0
Validation fixes. Props ocean90, xknown. fixes #17364
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-02 17:05:55 +00:00
ryan
9f677a0847
Use wp-menu-separator after Settings and before the first plugin top-level. Remove trailing separators. fixes #17629
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-01 14:41:43 +00:00
ryan
3462aab64e
Fix name of plugins submenu. Props ocean90. fixes #17530
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 16:06:42 +00:00
ryan
51fe428865
Rename network admin submenus to not clash with top level menus. Props ocean90, markmcwilliams. see #17378
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-24 21:58:01 +00:00
azaozz
d2e54b7932
Revert [17943] as it breaks plugins, props johnjamesjacoby, fixes #17484
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 06:20:30 +00:00
azaozz
46c545cdba
Remove links from the menu separators, see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-17 06:19:00 +00:00
westi
e8ecf0f599
Use the correct cap for the export menu item. Fixes #17452
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-16 10:44:42 +00:00
markjaquith
301be4eeef
Rename submenus to not clash with top level menus. Introduce all_items CPT string, defaulting to menu_name. fixes #17378
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-11 20:09:28 +00:00
ryan
c39f85038e
Don't fetch update info our show update bubbles if the user does not have install caps. Props nacin. fixes #16532
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-06 19:48:13 +00:00