Commit Graph

369 Commits

Author SHA1 Message Date
ryan 2192b1f450 Lose USE INDEX on comment_date_gmt. It didn't help performance very much and some people are missing the comment_date_gmt index. see #7664
git-svn-id: http://svn.automattic.com/wordpress/trunk@8813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-05 15:43:26 +00:00
azaozz 95fa29a208 Reply to comments from admin, first run, see #7435
git-svn-id: http://svn.automattic.com/wordpress/trunk@8720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-24 06:56:22 +00:00
ryan e68d5f07b4 comment_approved can be zero, so check with isset instead of empty. fixes #7446
git-svn-id: http://svn.automattic.com/wordpress/trunk@8622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-12 16:23:47 +00:00
markjaquith 74c46749cb Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784
git-svn-id: http://svn.automattic.com/wordpress/trunk@8572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-06 20:31:54 +00:00
ryan 1b0bfced2e XML-RPC comments API. see #7446
git-svn-id: http://svn.automattic.com/wordpress/trunk@8543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-04 22:29:37 +00:00
westi bf35dedced PHPDoc updates for comment.php. See #5578 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-15 09:34:00 +00:00
ryan f7f3005004 close the socket in discover_pingback_server_uri
git-svn-id: http://svn.automattic.com/wordpress/trunk@8052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-04 23:36:55 +00:00
ryan f57354bf63 Fix duplicate comment notifications. Props MtDewVirus. fixes #6892 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@8004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-28 15:37:59 +00:00
ryan 359601b720 Resurrect comment approval notification. Props chmac. fixes #6892 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@7917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-12 16:14:15 +00:00
markjaquith 25b49b2ceb Remove last remaining user level checks in favor of capabilities checks. props filosofo. fixes #6940
git-svn-id: http://svn.automattic.com/wordpress/trunk@7912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-09 00:45:17 +00:00
ryan 63d12e0b39 Use 'counts' cache group. see #6884
git-svn-id: http://svn.automattic.com/wordpress/trunk@7878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-02 19:42:44 +00:00
ryan 8c59e943d4 Add per post counting to wp_count_comments(). Props josephscott. fixes #6884
git-svn-id: http://svn.automattic.com/wordpress/trunk@7868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-01 16:52:48 +00:00
ryan e399f6ad54 Cache comment count and use count API in menu.php
git-svn-id: http://svn.automattic.com/wordpress/trunk@7714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-16 23:45:39 +00:00
ryan ce1fed1a02 Strip slashes before preparing comment insert to avoid double-slashing. Props filosofo. fixes #6738
git-svn-id: http://svn.automattic.com/wordpress/trunk@7690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-15 18:05:08 +00:00
ryan 56f15cb1bf Add missing comma. see #6644
git-svn-id: http://svn.automattic.com/wordpress/trunk@7657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-14 16:45:12 +00:00
ryan 248a0c06e2 Prepare DB queries in more places. Props filosofo. see #6644
git-svn-id: http://svn.automattic.com/wordpress/trunk@7645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-14 16:13:25 +00:00
markjaquith fda19a41bf don't time-throttle comments from Administrators
git-svn-id: http://svn.automattic.com/wordpress/trunk@7425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-20 20:32:18 +00:00
ryan 6e181bb941 Multi-byte character safe excerpting from nbachiyski. fixes #6077
git-svn-id: http://svn.automattic.com/wordpress/trunk@7140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-03 21:05:23 +00:00
ryan 93f0c00cb7 Manage comments rework. WIP
git-svn-id: http://svn.automattic.com/wordpress/trunk@6994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-23 08:33:44 +00:00
ryan 1857fc1627 generic_ping() improvements from fitztrev. fixes #5855
git-svn-id: http://svn.automattic.com/wordpress/trunk@6853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-14 21:50:43 +00:00
ryan 8fecb97b09 Order by and index on comment_date_gmt instead of comment_date to insulate order from offset changes. fixes #5773
git-svn-id: http://svn.automattic.com/wordpress/trunk@6736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 23:29:59 +00:00
ryan b67bbb9e4e Add key on comment_approved,comment_date to speed up last comment modified queries. fixes #5773
git-svn-id: http://svn.automattic.com/wordpress/trunk@6729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 18:04:17 +00:00
ryan d88983793b Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 06:47:27 +00:00
westi 2ac5c0204f Remove the duplicate code for sanitising IP Addresses we only need to do it once. Fixes #4579.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-26 10:18:33 +00:00
westi f9ba9a3802 Allow IPv6 addresses as well. Fixes #4579 props pishmishy.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-25 18:50:52 +00:00
ryan 6726698979 get_col() instead of get_results(). Props fitzrev. fixes #5699
git-svn-id: http://svn.automattic.com/wordpress/trunk@6640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-22 05:50:22 +00:00
ryan 74cad1dac8 Eliminate comment_date_gmt <= now from get_lastcommentmodified() queries. fixes #5650
git-svn-id: http://svn.automattic.com/wordpress/trunk@6610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-14 05:59:39 +00:00
westi e0856a070f Simplify to_ping query. Fixes #5649 props misterbisson.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-12 17:31:17 +00:00
ryan 502a542d64 phpdoc for comment.php from darkdragon. fixes #5578
git-svn-id: http://svn.automattic.com/wordpress/trunk@6553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-04 20:03:42 +00:00
ryan 1ae1811dd0 Unused var cleanup. Props DD32. see #5418
git-svn-id: http://svn.automattic.com/wordpress/trunk@6551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-04 19:36:34 +00:00
ryan 99b6eff02c wp.getCommentCount from josephscott. fixes #5463
git-svn-id: http://svn.automattic.com/wordpress/trunk@6534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-01 18:40:39 +00:00
ryan 8b64f70945 Defer comment counting. Props tellyworth. fixes #5557
git-svn-id: http://svn.automattic.com/wordpress/trunk@6532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-01 17:03:52 +00:00
ryan 028a159440 Remove unused vars. Props DD32. see #5418
git-svn-id: http://svn.automattic.com/wordpress/trunk@6364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-06 19:49:33 +00:00
ryan 5c07742cd3 Remove old comment_count_cache variable. It's dead.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-29 05:03:25 +00:00
markjaquith 47955b3fae prepare() for wp-includes/ bookmark.php, canonical.php, comment.php, comment-template.php. see #4553
git-svn-id: http://svn.automattic.com/wordpress/trunk@6173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-27 07:34:15 +00:00
ryan 0f6dfb8b1f Remove hardcoded clean_url on comment_author_url since it is handled on the pre_comment_author_url filter. Props wnorris. fixes #4120
git-svn-id: http://svn.automattic.com/wordpress/trunk@5975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-29 19:04:14 +00:00
matt d9793c3e8d Make the entire comment flood check pluggable as it can cause load problems on large sites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-27 06:34:18 +00:00
ryan 948284b296 Don't update comments feed last-modified header for unapproved comments. Props James Ballantine and Nazgul. fixes #4618 for 2.3
git-svn-id: http://svn.automattic.com/wordpress/trunk@5885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-16 19:26:01 +00:00
ryan ddc05f60ea wp_update_comment_count hook from mdawaffe. fixes #4740
git-svn-id: http://svn.automattic.com/wordpress/trunk@5869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-14 03:08:44 +00:00
markjaquith a2f7332558 Mark pingback as already pinged when the target site says it already got the pingback. props mdawaffe. fixes #4289
git-svn-id: http://svn.automattic.com/wordpress/trunk@5772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-27 23:28:36 +00:00
ryan 9d3d20f063 Use EXTR_SKIP when extracting. see #4468
git-svn-id: http://svn.automattic.com/wordpress/trunk@5708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-14 22:45:40 +00:00
ryan f2f6101e1c Comment caching. Reduce queries on edit-comments.php page. Add non-persistent cache groups. Hat tip to hovenko. fixes #4387
git-svn-id: http://svn.automattic.com/wordpress/trunk@5666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-08 00:20:22 +00:00
ryan 8aaa48e041 Use the right field name ya idjit.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-27 04:34:44 +00:00
ryan d44752d2ca Consult global comment in get_comment(). Don't show empty edit links.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-27 03:51:36 +00:00
rob1n 56add54053 Housekeeping -- clean out debug calls.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-24 23:58:51 +00:00
ryan 4de9ca69c2 More clean_url and int casts for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-27 23:45:41 +00:00
matt 3d21925922 Ryan slays the dragon. (Some of these return WP_Error objects.)
git-svn-id: http://svn.automattic.com/wordpress/trunk@5089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-23 02:05:29 +00:00
matt 7602d17899 (int)er the dragon.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-23 00:59:21 +00:00
markjaquith 611b037efa use clean_url() instead of attribute_escape() when dealing with src/href to protect against XSS. props xknown. fixes #3986 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-17 08:46:59 +00:00
ryan 7ba967ebd2 Update comment date gmt when updating comment date. Props mm6. fixes #3503
git-svn-id: http://svn.automattic.com/wordpress/trunk@4705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-01-09 08:22:28 +00:00
markjaquith 5a76c03203 new function for escaping within attributes: attribute_escape()
git-svn-id: http://svn.automattic.com/wordpress/trunk@4656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-12-21 10:10:04 +00:00
ryan 203f6c5ab4 Some caching cleanups.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-12-08 07:35:45 +00:00
markjaquith 0aa19529f9 Bunch of whitespace and coding standardization.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-12-07 03:57:23 +00:00
ryan 9f534ebae6 Remove trailing spaces and convert spaces to tabs. Props Nazgul. fixes #986
git-svn-id: http://svn.automattic.com/wordpress/trunk@4495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-19 07:56:05 +00:00
markjaquith 1b1b5bfe03 comment link counting improvements from Nazgul. fixes: #938
git-svn-id: http://svn.automattic.com/wordpress/trunk@4299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-04 04:43:25 +00:00
markjaquith 2c775dede6 remove comment_user_domain cruft. Props Nazgul. fixes #3197
git-svn-id: http://svn.automattic.com/wordpress/trunk@4293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-04 03:58:43 +00:00
ryan 8a4b655453 Pluggable comment throttling from Mark Jaquith. fixes #3175
git-svn-id: http://svn.automattic.com/wordpress/trunk@4265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-02 18:19:44 +00:00
matt 67d5a6d3c7 Options cleanup and some styling changes.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-19 06:11:42 +00:00
ryan ad1924f837 do_action_ref_array(). fixes #3125
git-svn-id: http://svn.automattic.com/wordpress/trunk@4186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-12 17:45:23 +00:00
ryan 849a0d29d7 Use get_option instead of get_settings. Just 'cause.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-08-30 21:46:31 +00:00
ryan efcb63ad21 s/URI/URL/. Props Nazgul. fixes #2666
git-svn-id: http://svn.automattic.com/wordpress/trunk@4133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-08-30 16:40:17 +00:00
matt 7c65645c62 Clean up how we address IP addresses throughout the code
git-svn-id: http://svn.automattic.com/wordpress/trunk@3990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-07-06 00:04:24 +00:00
ryan 42557940a1 Use wp_die(). Props filosofo. fixes #2914
git-svn-id: http://svn.automattic.com/wordpress/trunk@3985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-07-05 22:00:03 +00:00
ryan 1034767a9a wp_get_current_commenter()
git-svn-id: http://svn.automattic.com/wordpress/trunk@3902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-22 20:52:12 +00:00
ryan e673d82afb Move ping and trackback functions to comment.php (maybe to ping.php later?) #2525
git-svn-id: http://svn.automattic.com/wordpress/trunk@3900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-22 19:44:36 +00:00
ryan 8ae8b35c10 wp_update_comment_count() from MarkJaquith. fixes #2836
git-svn-id: http://svn.automattic.com/wordpress/trunk@3887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-19 17:17:52 +00:00
ryan 3c8ed766e1 Reworg post/page/attachment functions. #2525
git-svn-id: http://svn.automattic.com/wordpress/trunk@3851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-07 23:17:59 +00:00
ryan 8da6c47ae3 Add some prophylactic int casts and quoting.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-04-22 00:02:00 +00:00
ryan 6027cfa946 Reorg comment functions. #2525
git-svn-id: http://svn.automattic.com/wordpress/trunk@3714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-04-19 02:32:12 +00:00