The recommended approach for any plugins using these globals or properties is to switch to the newer `wp.i18n` functions.
In the meantime, this ensures that accessing any of these globals does not break the rest of the code on the page, and an appropriate warning message is logged to the JavaScript console.
Follow-up to: https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5
Props omarreiss, peterwilsoncc, kbjohnson90, johnbillion, TimothyBlynJacobs, joostdevalk, ocean90, desrosj, SergeyBiryukov.
Merges [48923] to the 5.5 branch.
Fixes#51123.
Built from https://develop.svn.wordpress.org/branches/5.5@48925
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used.
Follow-up to [47763], [48620].
Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov.
Merges [48910] to the 5.5 branch.
Fixes#51081.
Built from https://develop.svn.wordpress.org/branches/5.5@48915
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner's liking.
Props audrasjb, Paddy Landau, desrosj.
Merges [48888] to the 5.5 branch.
Fixes#50988.
Built from https://develop.svn.wordpress.org/branches/5.5@48889
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.
Follow-up to [48277], [48286], [48345].
Props Joen, johnbillion, afercia, johnjamesjacoby.
Merges [48862] to the 5.5 branch.
Fixes#51127. See #50504.
Built from https://develop.svn.wordpress.org/branches/5.5@48863
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`.
Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided.
Follow-up to [20102], [21025], [26620], [47745].
Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov.
Merges [48850] to the 5.5 branch.
Fixes#51073.
Built from https://develop.svn.wordpress.org/branches/5.5@48851
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.
Props oakesjosh, jeroenrotty, desrosj, Clorith.
Merges [48800] and [48801] to the 5.5 branch.
Fixes#50945.
Built from https://develop.svn.wordpress.org/branches/5.5@48806
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.
With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.
Follow-up to [47841].
Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Merges [48792] to the 5.5 branch.
Fixes#50912.
Built from https://develop.svn.wordpress.org/branches/5.5@48804
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
- Final CDN asset URLs.
- Some minor color adjustments.
Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Merges [48783] to the 5.5 branch.
Fixes#50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48784
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.
This brings the changes from [48750] to the 5.5 branch.
Props johnbillion.
Fixes#50868, see [48750].
Built from https://develop.svn.wordpress.org/branches/5.5@48756
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.
Add a unit test for `_wp_batch_update_comment_type()`.
Follow-up to [47597], [47626], [48225], [48227].
Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes#49236.
Built from https://develop.svn.wordpress.org/branches/5.5@48752
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.
This brings the changes from [48703] to the WordPress 5.5 branch.
Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/branches/5.5@48704
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.
This brings the changes from [48701] to the 5.5 branch.
Fixes#50824.
Props dd32, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/branches/5.5@48702
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.
See #50798.
Fixes#50280.
Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48669
git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
desrosj
Sergey Biryukov
whyisjake
Andrea Fercia