bfba3fc458
Docs: Improve documentation for functions in `wp-admin/install-helper.php` per the documentation standards.
...
Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47786
git-svn-id: http://core.svn.wordpress.org/trunk@47562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:40:07 +00:00
aa69c25d5f
Coding Standards: Use strict comparison in some `wp-admin` files.
...
Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239 .
Built from https://develop.svn.wordpress.org/trunk@47785
git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:32:08 +00:00
2eef7ee2ac
Bundled Themes: Twenty Twenty anchor links don't work in mobile menu.
...
Modifies the mobile modal menu javascript, so that anchor links will close the modal and scroll to the anchor within the page.
Props Giorgio25b, suzylah, yuhin, samful, bdcstr.
Fixes #48916 .
Built from https://develop.svn.wordpress.org/trunk@47784
git-svn-id: http://core.svn.wordpress.org/trunk@47560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 16:45:11 +00:00
2517abb4bd
Docs: Add a note that the `$protocols` parameter of `esc_url_raw()` defaults to return value of `wp_allowed_protocols()`.
...
This complements already existing note in `esc_url()`.
Props audrasjb.
Fixes #50147 .
Built from https://develop.svn.wordpress.org/trunk@47783
git-svn-id: http://core.svn.wordpress.org/trunk@47559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-11 20:34:13 +00:00
3fc1b33d53
Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in `populate_options()`.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47782
git-svn-id: http://core.svn.wordpress.org/trunk@47558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-11 17:26:08 +00:00
7f60aee75a
Tests: Give canonical test fixtures for paginated content more descriptive names.
...
Follow-up to [47727].
See #28081 , #40773 , #45337 .
Built from https://develop.svn.wordpress.org/trunk@47781
git-svn-id: http://core.svn.wordpress.org/trunk@47557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-10 20:31:08 +00:00
ddd3647d7d
Coding Standards: Rename some files and classes in `phpunit/tests/functions/` per the naming conventions.
...
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47780
git-svn-id: http://core.svn.wordpress.org/trunk@47556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-10 12:09:10 +00:00
1c4513e5c3
Tests: Add unit tests for `_cleanup_header_comment()`.
...
Props pbearne.
Fixes #38101 . See #8497 .
Built from https://develop.svn.wordpress.org/trunk@47779
git-svn-id: http://core.svn.wordpress.org/trunk@47555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-10 05:23:11 +00:00
0c3117a80f
Coding Standards: Fix WPCS issues in `wp-includes/update.php`.
...
Props mukesh27.
Fixes #50130 .
Built from https://develop.svn.wordpress.org/trunk@47778
git-svn-id: http://core.svn.wordpress.org/trunk@47554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-09 12:52:10 +00:00
5511b43e2c
Administration: Avoid a PHP 7.4 notice in `add_meta_box()` when attempting to re-add a previously removed box.
...
The logic for skipping previously removed meta boxes with the `core` priority should also apply to the `sorted` priority that is used when the boxes were manually reordered.
Add a unit test.
Props coolmann, franzarmas, SergeyBiryukov.
Fixes #50019 .
Built from https://develop.svn.wordpress.org/trunk@47777
git-svn-id: http://core.svn.wordpress.org/trunk@47553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-09 12:26:12 +00:00
928ce10da0
Bundled Themes: Twenty Twenty customizer retina_logo should be hidden when no logo is set.
...
Modifies the Customize setting `Site Identity > Retina logo` so that the option is hidden if there is no logo is set in `Site Identity > Logo`.
Props truongwp.
Fixes #50109 .
Built from https://develop.svn.wordpress.org/trunk@47776
git-svn-id: http://core.svn.wordpress.org/trunk@47552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-08 19:36:10 +00:00
1cde7d86f9
Coding Standards: Fix WPCS issues in `wp-admin/includes/template.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47775
git-svn-id: http://core.svn.wordpress.org/trunk@47551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-08 16:36:18 +00:00
43a6aff0d4
Coding Standards: Use strict comparison in `wp-includes/widgets/class-wp-widget-rss.php`.
...
Props mukesh27.
Fixes #50125 .
Built from https://develop.svn.wordpress.org/trunk@47774
git-svn-id: http://core.svn.wordpress.org/trunk@47550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-08 08:36:18 +00:00
33194d29c2
Site Health: Improve the appearance of administration email verification box.
...
Add `max-width` on desktop view and some padding on smaller screens.
Props chetan200891, azaozz, Clorith, afragen.
Fixes #48607 .
Built from https://develop.svn.wordpress.org/trunk@47772
git-svn-id: http://core.svn.wordpress.org/trunk@47548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-07 21:42:11 +00:00
7ded6c2d2a
Administration: Remove any CSS related to Internet Explorer versions 6 – 10.
...
In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks!
* Removes ie.css and `ie` style handle.
* Removes IE specific class names and any related CSS.
* Drops support for IE8 and older in `wp_customize_support_script()`.
* Updates compatibility mode for CSS minification to `ie11`.
Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90.
Fixes #17232 , #46015 .
Built from https://develop.svn.wordpress.org/trunk@47771
git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 20:15:07 +00:00
a0224a579d
Menus: Add a Cancel link to the screen for creating a new menu.
...
The use case this helps the most is when there's only one menu and you click "create a new menu". In this case the Cancel link allows you to go back to the single existing menu.
Props garrett-eclipse, audrasjb.
Fixes #46367 .
Built from https://develop.svn.wordpress.org/trunk@47770
git-svn-id: http://core.svn.wordpress.org/trunk@47546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 19:35:11 +00:00
bf3296a9a0
Script Loader: Add the `$group` parameter to `WP_Dependencies::do_item()`.
...
Previously, the method was called with two parameters in `::do_items()`, while the method signature only included one parameter.
Technically, this was not an issue as `WP_Dependencies::do_item()` is a placeholder meant to be overwritten when extending the class. When handling scripts, `WP_Dependencies` is extended with `WP_Scripts`, and the `$group` parameter was only used in `WP_Scripts::do_item()`, which does expect a second argument.
However, officially adding the parameter to `WP_Dependencies::do_item()` signature prevents code misunderstanding and avoids a warning in PHP code inspection tools.
Props kaggdesign, soulseekah, azaozz, SergeyBiryukov.
Fixes #43627 .
Built from https://develop.svn.wordpress.org/trunk@47769
git-svn-id: http://core.svn.wordpress.org/trunk@47545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 16:27:12 +00:00
86ac5e1432
Site Health: Do not trigger the fatal error handler while updates are being installed.
...
Triggering the error handler during updates may cause false positives. For example, updates may temporarily "fail" while files are moved around, but work fine once completed. Sending emails about temporary failures would just be confusing to the recipient.
Props Clorith, airamerica.
Fixes #48964 .
Built from https://develop.svn.wordpress.org/trunk@47768
git-svn-id: http://core.svn.wordpress.org/trunk@47544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 14:38:17 +00:00
538e9fb308
Block Editor: Update _all_ of the block editor packages following the 5.4.1 release.
...
This is an extension of [47619] and [47765].
Fixes #50094 .
Props aduth, peterwilsoncc, whyisjake, ocean90, and afercia.
Built from https://develop.svn.wordpress.org/trunk@47766
git-svn-id: http://core.svn.wordpress.org/trunk@47542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 23:56:33 +00:00
4a11b9db02
Block Editor: Update WordPress Packages following the 5.4.1 release.
...
This bumps @wordpress/block-library 2.14.7 ➡️ 2.14.8
Fixes #50094 .
Props aduth, peterwilsoncc, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47765
git-svn-id: http://core.svn.wordpress.org/trunk@47541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 23:39:31 +00:00
62f6909480
Code standards: Drop a newline in the customizer to comply with WordPress Coding Standards
...
Extends [47763] and #46829 .
Built from https://develop.svn.wordpress.org/trunk@47764
git-svn-id: http://core.svn.wordpress.org/trunk@47540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 22:00:09 +00:00
7a48040e13
Menus: Denote the special pages in the Customizer menu editor.
...
The special pages here are the pages that are used for the Privacy Policy, Home, and the Posts page.
Fixes #46829 .
Props garrett-eclipse, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@47763
git-svn-id: http://core.svn.wordpress.org/trunk@47539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 21:17:06 +00:00
9782eb82ad
Site Health: Display the original PHP memory limit on Site Health Info screen.
...
This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value.
Props Clorith, espiat, zodiac1978, SergeyBiryukov.
Fixes #49329 .
Built from https://develop.svn.wordpress.org/trunk@47762
git-svn-id: http://core.svn.wordpress.org/trunk@47538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 18:58:09 +00:00
b1a275684a
Canonical: Only redirect non-existing page requests to the post permalink if the post is found.
...
Follow-up to [47760].
See #45337 , #40773 , #28081 , #11694 .
Built from https://develop.svn.wordpress.org/trunk@47761
git-svn-id: http://core.svn.wordpress.org/trunk@47537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 10:49:07 +00:00
5b046976cc
Canonical: Redirect paged requests for a static page assigned as the "Posts page".
...
This avoids displaying duplicate content of the home page under different URLs with appended page numbers.
This change only affects the `<!--nextpage-->` pagination (`page` query variable) and not the regular multiple posts pagination (`paged` query variable).
The posts page does not support the `<!--nextpage-->` pagination, so requests for invalid page numbers should be redirected to the page permalink, applying the logic previously implemented for single posts or pages.
Follow-up to [34492], [47727].
Props jeremyfelt, sachit.tandukar, SergeyBiryukov.
Fixes #45337 . See #40773 , #28081 , #11694 .
Built from https://develop.svn.wordpress.org/trunk@47760
git-svn-id: http://core.svn.wordpress.org/trunk@47536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 10:42:07 +00:00
37d179de1c
Coding Standards: Fix WPCS issues in `wp-includes/canonical.php`.
...
Reformat long conditions and dense code blocks for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47759
git-svn-id: http://core.svn.wordpress.org/trunk@47535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 09:05:08 +00:00
46854d7322
REST API: Support more JSON Schemas when filtering a response by context.
...
The array type, multi-types, and the additional properties keyword are now supported. Additionally, the filter recurses to an infinite depth.
Fixes #48819 .
Built from https://develop.svn.wordpress.org/trunk@47758
git-svn-id: http://core.svn.wordpress.org/trunk@47534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 02:46:05 +00:00
ed4bdbb8f1
Tests: Update wp-api-generated.js.
...
[47755] and [47756] caused a schema change, so the wp-api-generated.js file needs to be updated.
Built from https://develop.svn.wordpress.org/trunk@47757
git-svn-id: http://core.svn.wordpress.org/trunk@47533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-04 00:28:09 +00:00
7023be21f5
REST API: Accept POST requests in the block renderer endpoint.
...
Rendering a block is idempotent, so a GET is the most natural request method. However, the maximum length of URLs prevented blocks with large attributes from being rendered.
Props ryankienstra.
Fixes #49680 .
Built from https://develop.svn.wordpress.org/trunk@47756
git-svn-id: http://core.svn.wordpress.org/trunk@47532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 22:58:05 +00:00
facb1728b9
REST API: Validate that the oembed url parameter is a string.
...
This prevents a PHP warning from being issued by esc_url_raw when a non-string value is provided.
Props dd32.
Fixes #49991 .
Built from https://develop.svn.wordpress.org/trunk@47755
git-svn-id: http://core.svn.wordpress.org/trunk@47531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 22:42:06 +00:00
717f0d0a3e
Docs: Misc docblock corrections and improvements.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@47754
git-svn-id: http://core.svn.wordpress.org/trunk@47530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 19:38:08 +00:00
ac3c2fe60a
REST API: Support the uuid JSON Schema format.
...
This accepts a uuid of any version. A future commit could add support for restricting uuids to a specific version.
Props johnwatkins0.
Fixes #50053 .
Built from https://develop.svn.wordpress.org/trunk@47753
git-svn-id: http://core.svn.wordpress.org/trunk@47529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 19:20:09 +00:00
c215a6dc27
Build/Test Tools: Further enhancements to the local development environment readme.
...
Props desrosj, donmhico
See #50058
Built from https://develop.svn.wordpress.org/trunk@47752
git-svn-id: http://core.svn.wordpress.org/trunk@47528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 14:43:07 +00:00
36524e1e25
File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.
...
Buttons should use the default buttons styles, no exceptions.
Props passoniate, garethgillman.
See #49197 .
Fixes #49353 .
Built from https://develop.svn.wordpress.org/trunk@47751
git-svn-id: http://core.svn.wordpress.org/trunk@47527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 14:21:08 +00:00
bc3cee1d5b
Upload: Improve file input and button alignment in plugin/theme upload form.
...
Resets flexbox on smaller screens. Improves vertical alignment on large screens.
Follow-up to [47599] and [47271].
Props mukesh27, DarkoG.
See #48859 , #49914 .
Fixes #49951 .
Built from https://develop.svn.wordpress.org/trunk@47750
git-svn-id: http://core.svn.wordpress.org/trunk@47526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 13:36:12 +00:00
72ef4ae81a
Docs: Further update inline documentation for the `wpdb` class per the documentation standards.
...
Restore some previous edits from [46696], [47060], [47122], [47230] that were accidentally reverted in [47740].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47749
git-svn-id: http://core.svn.wordpress.org/trunk@47525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 11:45:06 +00:00
f89f744fb2
Media: Ensure a consistent structure for the array returned by `wp_get_attachment_image_src()`.
...
The array returned by this function previously included a fourth element only when an intermediate image size was used. This change ensures a consistent structure in the returned array regardless of the function's internal behaviour.
Props wido, joemcgill, johnbillion
Fixes #46113
Built from https://develop.svn.wordpress.org/trunk@47748
git-svn-id: http://core.svn.wordpress.org/trunk@47524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 22:57:06 +00:00
1a27d51b48
Menus: Allow empty taxonomy terms to be surfaced when searching for items.
...
This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms.
Props birgire, audrasjb
Fixes #45298
Built from https://develop.svn.wordpress.org/trunk@47747
git-svn-id: http://core.svn.wordpress.org/trunk@47523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 22:36:07 +00:00
cc4e27142e
Upgrade/Install: Unlink the logo on the installation and config setup screens.
...
This allows for a natural tab order during installation, without negatively impacting users who use the keyboard for navigation, those who use a screen reader, or those who use neither.
Props lwill, afercia, audrasjb.
Fixes #47759
Built from https://develop.svn.wordpress.org/trunk@47746
git-svn-id: http://core.svn.wordpress.org/trunk@47522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 21:46:08 +00:00
5641afd43b
Administration: Reduce the chance that a PHP error message that occurs before the admin menu gets output is covered by the admin menu.
...
Props EmpireOfLight, afercia, Mte90, audrasjb, sunnyratilal
Fixes #35155
Built from https://develop.svn.wordpress.org/trunk@47745
git-svn-id: http://core.svn.wordpress.org/trunk@47521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 21:01:05 +00:00
55117c5376
Build/Test Tools: Add information regarding the default credentials for the local development environment to the project readme.
...
Props bookdude13
Fixes #49273
Built from https://develop.svn.wordpress.org/trunk@47744
git-svn-id: http://core.svn.wordpress.org/trunk@47520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 20:19:08 +00:00
7307415f6d
Build/Test Tools: Add more comprehensive instructions to the readme for the local development environment.
...
See #50058
Built from https://develop.svn.wordpress.org/trunk@47743
git-svn-id: http://core.svn.wordpress.org/trunk@47519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 19:16:07 +00:00
d29f5c14ac
Build/Test Tools: Exclude plugins and themes within `src`.
...
Just like the `build` directory, `src` can include plugins and themes which shouldn't be linted by PHPCS.
Fixes #49781
Built from https://develop.svn.wordpress.org/trunk@47742
git-svn-id: http://core.svn.wordpress.org/trunk@47518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 18:17:05 +00:00
1c01b6c32e
Build/Test Tools: Remove unnecessary formatting before linting on Travis CI.
...
Fixes #49722
Built from https://develop.svn.wordpress.org/trunk@47741
git-svn-id: http://core.svn.wordpress.org/trunk@47517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 17:46:07 +00:00
736874a51e
Docs: Update inline documentation for the wpdb class.
...
Props theMikeD
Fixes #49477
Built from https://develop.svn.wordpress.org/trunk@47740
git-svn-id: http://core.svn.wordpress.org/trunk@47516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 17:25:07 +00:00
a6f3ad2d21
Users: Don't reset user language preference on user update.
...
Props johnbillion.
Fixes #38665 .
Built from https://develop.svn.wordpress.org/trunk@47739
git-svn-id: http://core.svn.wordpress.org/trunk@47515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 16:29:06 +00:00
4abdb06f72
Query: Simplify the logic in `WP::handle_404()` to allow for easier modifications.
...
See #45337 .
Built from https://develop.svn.wordpress.org/trunk@47738
git-svn-id: http://core.svn.wordpress.org/trunk@47514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 08:48:08 +00:00
25c841026d
General: More PHP compatibility adjustments.
...
In this round:
- Removed references to `safe_mode` in `class-php3.php`. This was removed in PHP 5.4.
- Add inline exclude comments for compatibility checks in getID3.
Follow up of [47735-47736].
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47737
git-svn-id: http://core.svn.wordpress.org/trunk@47513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 20:12:06 +00:00
791e3bdb38
General: Fix typo within `phpcs:ignore` inline comment.
...
Follow up of [47735].
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47736
git-svn-id: http://core.svn.wordpress.org/trunk@47512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:36:06 +00:00
89ddd19884
General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
...
As part of the continued effort to improve PHP compatibility, the following improvments are being made:
- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.
Props desrosj, earnjam, dryanpress.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47735
git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:07:09 +00:00
Sergey Biryukov
ianbelanger
Peter Wilson
Dominik Schilling
whyisjake
TimothyBlynJacobs
John Blackbourn
Andrea Fercia
desrosj