Commit Graph

28617 Commits

Author SHA1 Message Date
Boone Gorges b806668e71 In `wp_update_term()`, limit duplicate slug checks to the same taxonomy as the updated term.
In 4.1 [30240], `wp_insert_term()` was modified to allow the creation of terms
with duplicate slugs, as long as the terms are in different taxonomies.
`wp_update_term()` didn't get the corresponding modification, with the result
that term updates fail when the term being updated shares a slug with an older
term, regardless of that older term's taxonomy.

Props ipm-frommen.
Fixes #30780 for trunk.
Built from https://develop.svn.wordpress.org/trunk@30985


git-svn-id: http://core.svn.wordpress.org/trunk@30971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-22 15:33:25 +00:00
Scott Taylor bc1341628f Comment List Tables:
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30984


git-svn-id: http://core.svn.wordpress.org/trunk@30970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:27:25 +00:00
Scott Taylor 786caa4d55 Correct the `@param` docs for arguments that are truthy/falsey.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30983


git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:04:23 +00:00
Scott Taylor 5eb5afac34 For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30982


git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
Scott Taylor 2dbd0d0a8f In `image_size_input_fields()`:
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30981


git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:19:24 +00:00
Scott Taylor f19bec8754 In `wp_import_handle_upload()`:
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30980


git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 21:10:24 +00:00
Scott Taylor 42f5acd869 Improve some docs for `@param`. Remove an unneeded `$wpdb` global import.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30979


git-svn-id: http://core.svn.wordpress.org/trunk@30965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:56:22 +00:00
Scott Taylor 574fabf2bc Improve some `wp-admin/includes/class-wp-filesystem-*.php` docs for `@param`.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30978


git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:40:23 +00:00
Andrew Ozz 6bde00ec42 Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
Built from https://develop.svn.wordpress.org/trunk@30977


git-svn-id: http://core.svn.wordpress.org/trunk@30963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 19:33:23 +00:00
Andrew Nacin a814ef7bcc About page: CDN images.
Built from https://develop.svn.wordpress.org/trunk@30971


git-svn-id: http://core.svn.wordpress.org/trunk@30958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-18 17:55:22 +00:00
Andrew Nacin 48560edcb8 Update theme POT files in trunk.
Built from https://develop.svn.wordpress.org/trunk@30969


git-svn-id: http://core.svn.wordpress.org/trunk@30956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-18 17:01:23 +00:00
Lance Willett b4947868e0 Bundled Themes: bump version numbers to coordinate with 4.1 release.
Built from https://develop.svn.wordpress.org/trunk@30967


git-svn-id: http://core.svn.wordpress.org/trunk@30954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-18 16:19:22 +00:00
Andrew Nacin aef38fcd4a Update bundled theme POT files in trunk.
Built from https://develop.svn.wordpress.org/trunk@30965


git-svn-id: http://core.svn.wordpress.org/trunk@30952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-18 01:33:22 +00:00
Lance Willett b335af9e63 Twenty Fifteen: use better, universal sans-serif fonts for RTL, similar to Twenty Ten which also had serif fonts throughout.
Props iamtakashi, see #30752.
Built from https://develop.svn.wordpress.org/trunk@30961


git-svn-id: http://core.svn.wordpress.org/trunk@30949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 22:30:24 +00:00
Andrew Nacin 1f7183f467 Update version numbers in trunk.
Built from https://develop.svn.wordpress.org/trunk@30960


git-svn-id: http://core.svn.wordpress.org/trunk@30948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 17:38:22 +00:00
Lance Willett 3bb98189d7 Twenty Fifteen: ensure RTL editor font style is consistent with front-end font style.
Props iamtakashi and alex-ye, see #30746.
Built from https://develop.svn.wordpress.org/trunk@30956


git-svn-id: http://core.svn.wordpress.org/trunk@30944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 17:22:25 +00:00
Lance Willett 8ccffecf03 Twenty Fifteen: ensure menu icon is properly centered for RTL views on small screens.
Props iamtakashi, fixes #30739.
Built from https://develop.svn.wordpress.org/trunk@30955


git-svn-id: http://core.svn.wordpress.org/trunk@30943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:39:46 +00:00
Boone Gorges e1ebba28d4 Update individual term caches in `get_terms()`.
This was removed in [29915] as part of the attempt to add cache support to
`get_term_by()`. When that support was removed in [30900], it was not properly
restored.

This changeset includes a unit test to verify that the cache is properly primed
for terms found in `get_terms()`, as well as tests to verify the other cache
setting that was touched by [30900].

Fixes #30749. See #21760.
Built from https://develop.svn.wordpress.org/trunk@30954


git-svn-id: http://core.svn.wordpress.org/trunk@30942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:39:24 +00:00
Lance Willett e5b753a48a Twenty Fifteen: fix styles for screen-reader-only search button in small screens.
Props iamtakashi, fixes #30744.
Built from https://develop.svn.wordpress.org/trunk@30953


git-svn-id: http://core.svn.wordpress.org/trunk@30941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:38:24 +00:00
Helen Hou-Sandí e9d3be4d99 Ensure inline code examples stay LTR, punctuation and all.
props alex-ye.
see #30748.

Built from https://develop.svn.wordpress.org/trunk@30952


git-svn-id: http://core.svn.wordpress.org/trunk@30940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:22:22 +00:00
Helen Hou-Sandí b25e4524fc About page: Don't allow tab text to wrap.
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.

see #30743.

Built from https://develop.svn.wordpress.org/trunk@30951


git-svn-id: http://core.svn.wordpress.org/trunk@30939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:02:22 +00:00
Dominik Schilling 626af35acb About: Fix the WordPress badge.
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.

see #30735.
Built from https://develop.svn.wordpress.org/trunk@30946


git-svn-id: http://core.svn.wordpress.org/trunk@30935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:54:21 +00:00
Lance Willett 6b9d5a87e3 Twenty Fifteen: hide search input cancel button. See #30728.
Built from https://develop.svn.wordpress.org/trunk@30945


git-svn-id: http://core.svn.wordpress.org/trunk@30934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:43:22 +00:00
Dominik Schilling eccd5a5eda Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.
Built from https://develop.svn.wordpress.org/trunk@30944


git-svn-id: http://core.svn.wordpress.org/trunk@30933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:39:22 +00:00
Dominik Schilling 6f937df4e5 Twenty Fifteen: Use dynamic default color value instead of hardcoded color.
props iamtakashi.
see #30733.
Built from https://develop.svn.wordpress.org/trunk@30932


git-svn-id: http://core.svn.wordpress.org/trunk@30921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 21:35:23 +00:00
Andrew Nacin 72083f67cd Last about page string. props celloexpressions. fixes #30435.
Built from https://develop.svn.wordpress.org/trunk@30929


git-svn-id: http://core.svn.wordpress.org/trunk@30918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 21:27:22 +00:00
John Blackbourn b43470397d Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
See #30435
Props melchoyce

Built from https://develop.svn.wordpress.org/trunk@30921


git-svn-id: http://core.svn.wordpress.org/trunk@30910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 20:02:23 +00:00
Mark Jaquith 0cf92119eb Revert [30036].
see #18035
Built from https://develop.svn.wordpress.org/trunk@30912


git-svn-id: http://core.svn.wordpress.org/trunk@30902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 17:35:23 +00:00
Lance Willett 2a170d1f13 Twenty Fifteen: fallback hex color for no-comments text should come first.
Props iamtakashi, fixes #30730.
Built from https://develop.svn.wordpress.org/trunk@30910


git-svn-id: http://core.svn.wordpress.org/trunk@30900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 16:19:22 +00:00
Scott Taylor f492a8f7dc In response to regressions on .com, fix MEjs styles for screen reader text and overflow on the volume slider.
Props obenland.
See #30281.

Built from https://develop.svn.wordpress.org/trunk@30907


git-svn-id: http://core.svn.wordpress.org/trunk@30897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 15:13:24 +00:00
Dominik Schilling e328484e66 Twenty Fifteen: Remove unnecessary `esc_html()` from `get_the_date()` and `get_the_modified_date()`.
see #30724.
Built from https://develop.svn.wordpress.org/trunk@30905


git-svn-id: http://core.svn.wordpress.org/trunk@30895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 14:19:22 +00:00
John Blackbourn 9592b26cbe Move a `<code>` tag out of a localised string on the About page.
Props pavelevap
See #30435

Built from https://develop.svn.wordpress.org/trunk@30903


git-svn-id: http://core.svn.wordpress.org/trunk@30893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 14:04:22 +00:00
Dominik Schilling 0419c86b54 Twenty Fifteen: Remove `esc_html()` from `get_the_author()`.
The display name is sanitized through `sanitize_text_field`, `wp_filter_kses`, and `_wp_specialchars`.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30901


git-svn-id: http://core.svn.wordpress.org/trunk@30891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:40:22 +00:00
Boone Gorges 6ebb326c54 Remove caching for `get_term_by()` calls.
The new cache group scheme causes term invalidation to be overly broad, so
that busting the cache for one term will bust the cache for all terms in the
taxonomy. We'll have another go at more focused use of the 'last_changed'
incrementor in a future release.

Reverts [29915], [30073], [30080], [30108], [30112].
See #21760.
Built from https://develop.svn.wordpress.org/trunk@30900


git-svn-id: http://core.svn.wordpress.org/trunk@30890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:27:22 +00:00
Dominik Schilling 52454ce5df Twenty Fifteen: Don't escape translated strings.
Replace every unnecessary instance of `esc_html_x()` with just `_x()`.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30899


git-svn-id: http://core.svn.wordpress.org/trunk@30889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:25:23 +00:00
Dominik Schilling 3749d51b72 Twenty Fifteen: Remove `esc_html()` from blog description.
The blog description gets esc_html()'d *into* the DB. It's also escaped because the filter for `get_bloginfo()` is set to 'display'.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30897


git-svn-id: http://core.svn.wordpress.org/trunk@30887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:20:23 +00:00
Dominik Schilling 289f29ac0b Twenty Fifteen: Don't escape translated strings.
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30896


git-svn-id: http://core.svn.wordpress.org/trunk@30886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:00:22 +00:00
Dominik Schilling 7e98a6647e Twenty Fifteen: Don't save unfiltered CSS in a setting.
Introduce `twentyfifteen_get_color_scheme_css( $colors )` which will be used for Underscore/Backbone and the PHP side. Let `twentyfifteen_color_scheme_css()` handle the color calculation on PHP side.

see #30409.
Built from https://develop.svn.wordpress.org/trunk@30893


git-svn-id: http://core.svn.wordpress.org/trunk@30883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 12:27:26 +00:00
Dominik Schilling 1f6e85e60f Customizer: Export Preview instance to `wp.customize.preview`.
see #30409, #30726.
Built from https://develop.svn.wordpress.org/trunk@30891


git-svn-id: http://core.svn.wordpress.org/trunk@30881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 11:53:22 +00:00
Andrew Nacin 8c3027c3c7 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
Built from https://develop.svn.wordpress.org/trunk@30890


git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:07:23 +00:00
Andrew Nacin 7b015d507d Update/add plugin recommendation strings.
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.

Built from https://develop.svn.wordpress.org/trunk@30889


git-svn-id: http://core.svn.wordpress.org/trunk@30879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:06:24 +00:00
Andrew Nacin 23f4b0f62f Updates to the 'Log out everywhere' implementation.
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.

Built from https://develop.svn.wordpress.org/trunk@30888


git-svn-id: http://core.svn.wordpress.org/trunk@30878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 09:15:23 +00:00
Andrew Nacin 6abad25e05 Finalize two more about page strings. see #30435.
Built from https://develop.svn.wordpress.org/trunk@30887


git-svn-id: http://core.svn.wordpress.org/trunk@30877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 08:58:23 +00:00
Dion Hulse 1d59ca9004 Add braces around a Docblock in an if statement, although not required by PHP, this is required by our coding standards for readability.
Introduced in 3.9 with r27365
See #25905

Built from https://develop.svn.wordpress.org/trunk@30886


git-svn-id: http://core.svn.wordpress.org/trunk@30876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 05:52:23 +00:00
Andrew Nacin dc0f6b0b8a Update Akismet external to 3.0.4 in trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@30874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 02:46:00 +00:00
Dominik Schilling fcb00b75e2 Customizer: Add `_wp_attachment_is_custom_background` meta to uploaded background images.
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).

see #30707.
Built from https://develop.svn.wordpress.org/trunk@30885


git-svn-id: http://core.svn.wordpress.org/trunk@30873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 23:28:23 +00:00
Dominik Schilling 824d751879 Autoprefixer for [30857].
see #30435.
Built from https://develop.svn.wordpress.org/trunk@30884


git-svn-id: http://core.svn.wordpress.org/trunk@30872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 23:20:23 +00:00
John Blackbourn b01740334c Correct the height of the search type `select` element when searching the plugin directory.
See #30719
Props pavelevap, eliorivero

Built from https://develop.svn.wordpress.org/trunk@30879


git-svn-id: http://core.svn.wordpress.org/trunk@30867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 22:32:23 +00:00
John Blackbourn 618b673470 Clarify the behaviour of the `wp_editor_set_quality` and `jpeg_quality` filters.
Props DH-Shredder
See #29856

Built from https://develop.svn.wordpress.org/trunk@30874


git-svn-id: http://core.svn.wordpress.org/trunk@30863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 21:43:22 +00:00
Dominik Schilling 4652717828 Customizer: Remove date filter from the Header/Background Image upload frames.
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].

see #30689.
Built from https://develop.svn.wordpress.org/trunk@30872


git-svn-id: http://core.svn.wordpress.org/trunk@30862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 20:27:22 +00:00