Commit Graph

178 Commits

Author SHA1 Message Date
nacin 70da9092d4 Remove unnecessary is_null() checks from the worker loops inside do_action(), apply_filters(), etc. fixes #21321. see #21169.
git-svn-id: http://core.svn.wordpress.org/trunk@21287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 05:25:37 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin 75c741cd8b Revert other stuffs from [19374].
git-svn-id: http://svn.automattic.com/wordpress/trunk@19376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 15:43:57 +00:00
nacin 5e69bd0caf Set $parent_file for post-new.php when show_in_menu is a file. Provides for correct top-level highlighting. $submenu_file remains set to expect a post-new.php menu. see #19125.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 15:35:57 +00:00
duck_ 2f51b9be0d Fix typos in documentation (wp-includes/[i-z]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-05 19:08:15 +00:00
ryan b136c576ed Grammar fix. Props lukeschlather, markmcwilliams. fixes #17315
git-svn-id: http://svn.automattic.com/wordpress/trunk@18507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-04 16:03:53 +00:00
ryan 3e77cd18c9 Avoid array push/pops for empty filters and actions. fixes #17110
git-svn-id: http://svn.automattic.com/wordpress/trunk@17638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-14 18:05:30 +00:00
nacin c9e1ab9bd9 _doing_it_wrong takes three arguments. fixes #15824.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 17:14:25 +00:00
westi 167df97e81 Switch to _doing_it_wrong(). See #15824
git-svn-id: http://svn.automattic.com/wordpress/trunk@16940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 11:31:00 +00:00
markjaquith 14be097d5e Revert [15829] for now, consider better solution for 3.2. see #13550
git-svn-id: http://svn.automattic.com/wordpress/trunk@16575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-24 20:25:26 +00:00
nacin f6d1e9c634 Only a static class method or function can be used in an uninstall hook. props scribu, fixes #13786.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 09:45:57 +00:00
scribu af29ce4440 Apply filter in plugin_basename(). Props vladimir_kolesnikov. Fixes #13550
git-svn-id: http://svn.automattic.com/wordpress/trunk@15829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-17 13:47:40 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
ryan 1a552dd029 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 02:42:15 +00:00
westi 3a3cce834a Fix remaining notice when using closures. Fixes #10493 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 13:41:02 +00:00
westi 86cb0aa6b9 Fix notices/usage of closures as action/filter handlers. Fixes #10493 based on patch from scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 08:10:39 +00:00
westi c3a6bea231 Ensure that apply_filters_ref_array passes the result of the filter to the next filter. Fixes #12723 props scribue.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-31 21:39:18 +00:00
nacin a7feaed0e6 Change @since 3.0 to @since 3.0.0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:13:36 +00:00
westi 5bce147d90 Introduce apply_filters_ref_array(). See #9886 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-18 21:24:07 +00:00
westi c71c407fd2 Fix a possible undefined offset warning in do_action. Fixes #11241 props chrisbliss18.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-11 21:58:17 +00:00
nacin 8dee46ddf0 Fix typo in remove_all_filters() that prevented hooks from being removed by priority. fixes #12492, props chrisbliss18.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 06:41:19 +00:00
ryan 6da55f7792 Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 22:11:12 +00:00
westi c30c392e91 Allow people to attach PHP 5.3 Closures to filters and actions. Fixes #10493 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 08:27:02 +00:00
ryan 7b00fcb9f6 Improve do_action performance. Make an associative array. Props koopersmith. fixes #10561
git-svn-id: http://svn.automattic.com/wordpress/trunk@12464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-21 08:47:34 +00:00
westi 42eb1ba7ca Improve _wp_filter_build_unique_id to give more consistent behaviour and make filter removal reliable for class based filters. Fixes #10535 props dd32.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-22 19:33:11 +00:00
westi 2562197d3b Correct phpDoc comment for add_filter. Fixes #10164 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-20 18:14:46 +00:00
ryan 4e6f054b47 Menu fixes
git-svn-id: http://svn.automattic.com/wordpress/trunk@11565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-15 00:22:53 +00:00
ryan 31f8459c24 Make sure filter IDs are unique. Props bkrausz, hakre. fixes #8723
git-svn-id: http://svn.automattic.com/wordpress/trunk@11409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-20 16:59:01 +00:00
azaozz 4f250c27cf Remove slash from plugin_basename(), props alexrabe, fixes #9561
git-svn-id: http://svn.automattic.com/wordpress/trunk@11072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-23 21:45:38 +00:00
azaozz 8682f79e6a Make plugin_dir() and plugin_basename() work for mu-plugins directory, props Denis-de-Bernardy, fixes #9561
git-svn-id: http://svn.automattic.com/wordpress/trunk@11069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-23 08:16:06 +00:00
markjaquith df58ca2a41 Introducing plugin_dir_path(__FILE__) and plugin_dir_url(__FILE__) ... simple API functions for determining the directory path/url of the current plugin file
git-svn-id: http://svn.automattic.com/wordpress/trunk@10765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-03-10 19:50:55 +00:00
westi c9c4d306ef PHPdoc updates. See €8805 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-22 21:17:52 +00:00
ryan 40c754df1d Unused var fixes. Props DD32. see #8220
git-svn-id: http://svn.automattic.com/wordpress/trunk@9716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-15 18:10:35 +00:00
azaozz 1b84d8e087 Fix constant name in phpDoc, props alexrabe, fixes #8123
git-svn-id: http://svn.automattic.com/wordpress/trunk@9611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-11 12:43:04 +00:00
westi a0f339d3bf Notice fixes. See #7509 props DD32.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-14 21:08:28 +00:00
westi 0161953100 Fix Notice. When nothing exists for an action or filter.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-27 09:53:43 +00:00
westi 9e89b4a99e phpDoc corrections for wp-includes. See #7550 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-30 21:23:43 +00:00
westi e462ca421d remove_all_{actions|filters}. Fixes #7216 props filosofo and santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-17 11:15:38 +00:00
ryan 0f8d8597c3 Update since tags. Props santosj. fixes #5625
git-svn-id: http://svn.automattic.com/wordpress/trunk@8587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-08 04:15:03 +00:00
ryan d7cc99037f Plugin uninstall hooks from santosj. fixes #5625
git-svn-id: http://svn.automattic.com/wordpress/trunk@8585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-07 23:39:27 +00:00
markjaquith 74c46749cb Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784
git-svn-id: http://svn.automattic.com/wordpress/trunk@8572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-06 20:31:54 +00:00
ryan 6c8d35de32 Allow wp-content to exist outside of webroot. Props sambauers. see #6938
git-svn-id: http://svn.automattic.com/wordpress/trunk@7999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-27 17:55:24 +00:00
ryan d88983793b Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 06:47:27 +00:00
ryan f8ab885ab0 Use PLUGINDIR in plugin_basename(). Props hansengel. fixes #5665
git-svn-id: http://svn.automattic.com/wordpress/trunk@6629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-16 19:11:15 +00:00
ryan 479fc2e2b3 phpdoc tuneup from darkdragon. see #5611
git-svn-id: http://svn.automattic.com/wordpress/trunk@6585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-09 17:48:00 +00:00
ryan 050ffefc43 Filter and action optimizations and phpdoc updates from darkdragon. fixes #5338
git-svn-id: http://svn.automattic.com/wordpress/trunk@6361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-06 05:56:38 +00:00
ryan 0eaad56717 Change 'all' hook calling. Bring filters and actions back into one array for back-compat. see #5231
git-svn-id: http://svn.automattic.com/wordpress/trunk@6324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-08 01:05:43 +00:00
ryan 1e320a469e has_action and has_filter. see #5231
git-svn-id: http://svn.automattic.com/wordpress/trunk@6320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-07 04:30:11 +00:00
ryan 902cc8e985 Add missing type arg on call to _wp_filter_build_unique_id(). see #5231
git-svn-id: http://svn.automattic.com/wordpress/trunk@6319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-06 21:39:22 +00:00
ryan 0e63de02ca current_fiter() from tellyworth. fixes #5232
git-svn-id: http://svn.automattic.com/wordpress/trunk@6318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-06 21:38:04 +00:00
ryan 07806ed56a Separate action and filter arrays. Get rid of filter merging. fixes #5231
git-svn-id: http://svn.automattic.com/wordpress/trunk@6316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-06 18:31:43 +00:00
ryan babd1e1a7f phpdoc for plugin API. Props darkdragon. fixes #5225
git-svn-id: http://svn.automattic.com/wordpress/trunk@6276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-19 17:45:08 +00:00
westi f6234acb5d Add documentation of _wp_filter_build_unique_id(). Fixed #5053 props darkdragon.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-07 07:31:14 +00:00
ryan 321c310717 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
ryan 87c4f3a17f Strip lines that contain only whitespace down to newlines.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:19:20 +00:00
ryan 3fe16de587 explicitly check next() against FALSE in do_action_ref_array(). Props Denis-de-Bernardy, Otto42, Nazgul, santosj, DD32. fixes #4625 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@5958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-28 19:06:56 +00:00
ryan c8723a4f3f Fix how wp_filter array is keyed. Props santosj/darkdragon. fixes #3875 for 2.3
git-svn-id: http://svn.automattic.com/wordpress/trunk@5936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-24 14:18:08 +00:00
westi 07ff444b6f Fix plugin basename for Windows servers. Fixes #3002 props Ozh
git-svn-id: http://svn.automattic.com/wordpress/trunk@5924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-23 16:07:21 +00:00
markjaquith b64ce2d0f0 explicitly check next() against FALSE when iterating through filters. Props Denis-de-Bernardy, Otto42, Nazgul, santosj (go team effort!). fixes #4625 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@5857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-08 17:41:46 +00:00
ryan 627725be1a Make sure wp_actions is set before counting.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-08 17:59:52 +00:00
ryan 481e505d49 Fix did_action to properly account for actions that have no callbacks attached.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-07 23:22:50 +00:00
rob1n 8638b7ab3a Return based on whether the hook was removed or not. Props mdawaffe. fixes #4223
Note that this will almost definitely *not* affect existing implementations. The way most code is set up now is to just call remove_filter() or remove_action().


git-svn-id: http://svn.automattic.com/wordpress/trunk@5393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-04 23:27:12 +00:00
ryan c3508de5be Avoid php notices.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-07 05:24:37 +00:00
matt 06d577a539 Because of the next we should always do a reset.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-02 07:46:05 +00:00
matt fde70e7623 Fixes bottlenecks found in filter system using xdebug + kcachegrind. merge_filters was being called 1000+ times.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-02 07:03:38 +00:00
rob1n fe50a59120 PHPdoc for plugin.php. Props Martin10. fixes #3852
git-svn-id: http://svn.automattic.com/wordpress/trunk@5142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-29 02:45:34 +00:00
ryan 2ecae0f50d add and apply filter optimizations from FraT. fixes #3875
git-svn-id: http://svn.automattic.com/wordpress/trunk@4955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-28 01:09:20 +00:00
ryan b81bf35aad did_action()
git-svn-id: http://svn.automattic.com/wordpress/trunk@4630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-12-08 03:45:34 +00:00
markjaquith 0aa19529f9 Bunch of whitespace and coding standardization.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-12-07 03:57:23 +00:00
markjaquith fd5492d87b Code cleanup: wp-includes/plugin.php
git-svn-id: http://svn.automattic.com/wordpress/trunk@4394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-13 14:01:53 +00:00
markjaquith a450c80a6a case insensitive sorting. props Nazgul. fixes #3108
git-svn-id: http://svn.automattic.com/wordpress/trunk@4289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-04 03:49:56 +00:00
ryan ad1924f837 do_action_ref_array(). fixes #3125
git-svn-id: http://svn.automattic.com/wordpress/trunk@4186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-12 17:45:23 +00:00
ryan 3964d277ce Pass along the modified string instead of the original. fixes #3118
git-svn-id: http://svn.automattic.com/wordpress/trunk@4179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-10 17:16:20 +00:00
ryan 93a7a9617f do_action and apply_filters arg passing sanity from mdawaffe. fixes #3116
git-svn-id: http://svn.automattic.com/wordpress/trunk@4177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-08 23:19:29 +00:00
ryan 9e240a859f Specify number of accepted args.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-08 23:18:03 +00:00
ryan 6d7717e159 Move plugin API to plugin.php. #2525
git-svn-id: http://svn.automattic.com/wordpress/trunk@3893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-20 02:03:24 +00:00