WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
31,350 Commits 50 Branches 749 Tags 992 MiB
Commit Graph

18586 Commits

Author SHA1 Message Date
Gary Pendergast c44c7338c0 Tests: Add an extra warning message when checking the recommended PHP version. 
See #33758.


Built from https://develop.svn.wordpress.org/trunk@33944


git-svn-id: http://core.svn.wordpress.org/trunk@33913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 07:28:24 +00:00
Weston Ruter 7c6534fd4c Customize: Fix logic for determining the container element when focusing on a panel, section, or control. 
Fixes #33695 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33939


git-svn-id: http://core.svn.wordpress.org/trunk@33908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 05:59:24 +00:00
Weston Ruter 274373afc6 Customize: Fix clearing of a color control's setting by using proper empty value. 
Props stevehenty.
Fixes #30280.


Built from https://develop.svn.wordpress.org/trunk@33938


git-svn-id: http://core.svn.wordpress.org/trunk@33907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 05:48:23 +00:00
Gary Pendergast 066c30b41e Readme: Update the recommended PHP version to 5.6. 
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.


Built from https://develop.svn.wordpress.org/trunk@33937


git-svn-id: http://core.svn.wordpress.org/trunk@33906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 05:23:24 +00:00
Dion Hulse 580ca68e26 Cron: Reject events when the provided `$timestamp` is not a valid timestamp. 
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.

Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423, Fixes #33475

Built from https://develop.svn.wordpress.org/trunk@33936


git-svn-id: http://core.svn.wordpress.org/trunk@33905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 02:39:23 +00:00
Dion Hulse 36bda54e88 Favicon: Do not specify a `Content-Length: 0` header for our "empty" response to fail more gracefully on environments with extra whitespace on output. 
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.

Props swissspidy.
Fixes #33626

Built from https://develop.svn.wordpress.org/trunk@33935


git-svn-id: http://core.svn.wordpress.org/trunk@33904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 02:18:26 +00:00
Sergey Biryukov a3f82f92f1 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.
Built from https://develop.svn.wordpress.org/trunk@33934


git-svn-id: http://core.svn.wordpress.org/trunk@33903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 07:59:24 +00:00
Sergey Biryukov c177344508 Merge two permission error strings. 
Props pavelevap.
Fixes #33745.
Built from https://develop.svn.wordpress.org/trunk@33933


git-svn-id: http://core.svn.wordpress.org/trunk@33902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 06:42:26 +00:00
Sergey Biryukov c65f37f892 Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response. 
Props extendwings.
Fixes #33753.
Built from https://develop.svn.wordpress.org/trunk@33932


git-svn-id: http://core.svn.wordpress.org/trunk@33901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 00:17:24 +00:00
Sergey Biryukov 0424d962e1 Update the parameter docs for `wp_add_post_tags()`, `wp_set_post_tags()`, and `wp_set_post_terms()`. 
Props johnbillion.
Fixes #33749.
Built from https://develop.svn.wordpress.org/trunk@33931


git-svn-id: http://core.svn.wordpress.org/trunk@33900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 00:12:26 +00:00
Sergey Biryukov 4b5ef333a0 Correct the docblock for `wp_list_widget_controls()`. 
Props swissspidy.
Fixes #33751.
Built from https://develop.svn.wordpress.org/trunk@33930


git-svn-id: http://core.svn.wordpress.org/trunk@33899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:38:25 +00:00
John Blackbourn 504cd3bf15 Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area. 
See #25162

Built from https://develop.svn.wordpress.org/trunk@33929


git-svn-id: http://core.svn.wordpress.org/trunk@33898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:25:24 +00:00
Sergey Biryukov 48a41a6663 List tables: Adjust the styles for checkbox column to align better with longer column names. 
Props swissspidy.
Fixes #32825.
Built from https://develop.svn.wordpress.org/trunk@33928


git-svn-id: http://core.svn.wordpress.org/trunk@33897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:16:23 +00:00
John Blackbourn f482b909e6 Introduce a new `$is_edge` global for the Microsoft Edge browser. 
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.

See #33193
Props gregrickaby, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33927


git-svn-id: http://core.svn.wordpress.org/trunk@33896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:33:23 +00:00
Scott Taylor 15b487b097 After [33925], rename the unit test class to `Tests_Comment_Meta_Cache` to avoid collisions on the PHP 5.2 superhighway. 
See #16894.

Built from https://develop.svn.wordpress.org/trunk@33926


git-svn-id: http://core.svn.wordpress.org/trunk@33895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:30:24 +00:00
Scott Taylor c231add9fe In `wp_list_comments()`, update the comment meta cache when the comments derive from `WP_Query` and the new `->comment_meta_cached` prop is `false`. 
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.

Adds unit tests.

Props wonderboymusic, bradt.
Fixes #16894.

Built from https://develop.svn.wordpress.org/trunk@33925


git-svn-id: http://core.svn.wordpress.org/trunk@33894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:25:24 +00:00
John Blackbourn 3361f90a1c When a user with no role logs in, redirect them to the home page rather than their profile screen which they do not have access to. 
See #25162

Built from https://develop.svn.wordpress.org/trunk@33924


git-svn-id: http://core.svn.wordpress.org/trunk@33893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 21:34:24 +00:00
John Blackbourn bdde0261bc Bail out early from `esc_url()` if the URL becomes empty after stripping out disallowed characters. 
Fixes #28015
Props jesin for the unit test

Built from https://develop.svn.wordpress.org/trunk@33923


git-svn-id: http://core.svn.wordpress.org/trunk@33892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 21:29:25 +00:00
John Blackbourn 9e6f9a5d93 Function docs for the `tax_input` and `meta_input` parameters available for `wp_insert_post()`. 
See #20451

Built from https://develop.svn.wordpress.org/trunk@33922


git-svn-id: http://core.svn.wordpress.org/trunk@33891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 21:02:24 +00:00
Jeremy Felt af557379da Multisite: Update help tab text for `site-info.php` to reference "site URL". 
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.

Fixes #33748. See #22383.

Built from https://develop.svn.wordpress.org/trunk@33921


git-svn-id: http://core.svn.wordpress.org/trunk@33890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:53:24 +00:00
John Blackbourn 4d76ce2521 Implement a language chooser on the Network Admin -> Sites -> Add New screen. 
Props DrewAPicture
Fixes #33528

Built from https://develop.svn.wordpress.org/trunk@33920


git-svn-id: http://core.svn.wordpress.org/trunk@33889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:47:24 +00:00
Sergey Biryukov 695d3ee98b Merge two strings in `Walker_Comment::comment()` and `Walker_Comment::html5_comment()`. 
Props pavelevap.
Fixes #33744.
Built from https://develop.svn.wordpress.org/trunk@33919


git-svn-id: http://core.svn.wordpress.org/trunk@33888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:46:24 +00:00
Jeremy Felt 122862b570 Multisite: Pass the ID of the site being updated to `wpmu_update_blog_options` action. 
Props @swissspidy, @MikeHansenMe.
Fixes #32907.

Built from https://develop.svn.wordpress.org/trunk@33918


git-svn-id: http://core.svn.wordpress.org/trunk@33887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:39:24 +00:00
Scott Taylor 9957d43e13 Bump H3 headings to H2 on the {Term} screens for better accessibility. 
Props mrahmadawais.
Fixes #33658.

Built from https://develop.svn.wordpress.org/trunk@33917


git-svn-id: http://core.svn.wordpress.org/trunk@33886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:17:25 +00:00
Scott Taylor acc7f66cf9 Bump H3 headings to H2 on the Discussion Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33609.

Built from https://develop.svn.wordpress.org/trunk@33916


git-svn-id: http://core.svn.wordpress.org/trunk@33885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:14:24 +00:00
Scott Taylor 941d65c462 Bump H3 headings to H2 on the Media Settings screen for better accessibility. 
Props metodiew.
Fixes #33610.

Built from https://develop.svn.wordpress.org/trunk@33915


git-svn-id: http://core.svn.wordpress.org/trunk@33884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:12:25 +00:00
Scott Taylor 2a3be365e3 Bump H3 headings to H2 on Export screen for better accessibility. 
Props metodiew.
Fixes #33608.

Built from https://develop.svn.wordpress.org/trunk@33914


git-svn-id: http://core.svn.wordpress.org/trunk@33883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:09:24 +00:00
Scott Taylor fd21c92b22 Correct the param docs for `comment_guid()` and `get_comment_guid()`. 
Props dimadin.
Fixes #32619.

Built from https://develop.svn.wordpress.org/trunk@33913


git-svn-id: http://core.svn.wordpress.org/trunk@33882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:00:25 +00:00
Scott Taylor f5c754bfed Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here). 
Props afercia.
Fixes #32866.

Built from https://develop.svn.wordpress.org/trunk@33912


git-svn-id: http://core.svn.wordpress.org/trunk@33881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:57:25 +00:00
Scott Taylor 44dace3487 Add Customizer docs. 
Props ericlewis.
See #33503.

Built from https://develop.svn.wordpress.org/trunk@33911


git-svn-id: http://core.svn.wordpress.org/trunk@33880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:53:24 +00:00
Scott Taylor 102a8aecf8 Allow `wp_insert_post()` to accept a `meta_input` argument. Devs should use `register_meta()` to ensure that specific values specified by key are sanitized properly. 
Adds unit test.

Props CoenJacobs, swissspidy.
Fixes #20451.

Built from https://develop.svn.wordpress.org/trunk@33910


git-svn-id: http://core.svn.wordpress.org/trunk@33879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:50:24 +00:00
Andrea Fercia 47ceb6bb5c Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens. 
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.
Built from https://develop.svn.wordpress.org/trunk@33909


git-svn-id: http://core.svn.wordpress.org/trunk@33878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 18:30:24 +00:00
Sergey Biryukov 465e348c12 Fix closing div in `wp_print_request_filesystem_credentials_modal()`. 
Props trepmal.
Fixes #33737.
Built from https://develop.svn.wordpress.org/trunk@33908


git-svn-id: http://core.svn.wordpress.org/trunk@33877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 15:17:24 +00:00
Sergey Biryukov 1e90498102 Update `Tests_Sanitize_Option::test_sanitize_option()` after [33858]. 
See #23605.
Built from https://develop.svn.wordpress.org/trunk@33907


git-svn-id: http://core.svn.wordpress.org/trunk@33876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 14:18:24 +00:00
Sergey Biryukov 3b2cf952e9 Update `Tests_Admin_includesPlugin::test_menu_page_url()` after [33858]. 
See #23605.
Built from https://develop.svn.wordpress.org/trunk@33906


git-svn-id: http://core.svn.wordpress.org/trunk@33875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 14:16:24 +00:00
Sergey Biryukov faaa9b9e98 Update `Tests_Formatting_GetUrlInContent::get_input_output()` after [33858]. 
Props gitlost.
Fixes #23605.
Built from https://develop.svn.wordpress.org/trunk@33905


git-svn-id: http://core.svn.wordpress.org/trunk@33874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 14:06:26 +00:00
Boone Gorges cc5eddda74 Allow `wp_terms_checklist()` to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.
Built from https://develop.svn.wordpress.org/trunk@33904


git-svn-id: http://core.svn.wordpress.org/trunk@33873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 21:25:25 +00:00
Boone Gorges 45e8bef3cd In `get_terms()`, allow terms to be ordered by 'term_id'. 
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.
Built from https://develop.svn.wordpress.org/trunk@33903


git-svn-id: http://core.svn.wordpress.org/trunk@33872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 21:17:26 +00:00
Sergey Biryukov f0ce1f06ea Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`. 
fixes #33685. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33902


git-svn-id: http://core.svn.wordpress.org/trunk@33871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 03:40:25 +00:00
Drew Jaynes d612c11ab0 Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33901


git-svn-id: http://core.svn.wordpress.org/trunk@33870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:52:24 +00:00
Drew Jaynes bfe8b01ef2 Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API. 
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33900


git-svn-id: http://core.svn.wordpress.org/trunk@33869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:47:25 +00:00
Drew Jaynes f57d7527e6 Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33899


git-svn-id: http://core.svn.wordpress.org/trunk@33868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:42:24 +00:00
Drew Jaynes a71ee9a0ea Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750]. 
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33898


git-svn-id: http://core.svn.wordpress.org/trunk@33867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:38:24 +00:00
Drew Jaynes 5cf6c74499 Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API. 
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33897


git-svn-id: http://core.svn.wordpress.org/trunk@33866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:33:24 +00:00
Drew Jaynes 3be117216e Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33896


git-svn-id: http://core.svn.wordpress.org/trunk@33865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:29:24 +00:00
Drew Jaynes e1e98b04b9 Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749]. 
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33895


git-svn-id: http://core.svn.wordpress.org/trunk@33864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:26:25 +00:00
Scott Taylor 80a20e5c3d Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.

Built from https://develop.svn.wordpress.org/trunk@33894


git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 23:23:24 +00:00
Drew Jaynes 54c2cabf66 Docs: Add complete file, class, property, and method documentation for the new `WP_Comment` class, introduced in [33891]. 
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33893


git-svn-id: http://core.svn.wordpress.org/trunk@33862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 19:58:24 +00:00
Sergey Biryukov 9ffab31d8f Add missing translation functions to the error messages added in [33889]. 
props kraftbj, GaryJ.
fixes #33684.
Built from https://develop.svn.wordpress.org/trunk@33892


git-svn-id: http://core.svn.wordpress.org/trunk@33861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:37:23 +00:00
Scott Taylor e73ee5ac98 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:17:24 +00:00
Helen Hou-Sandí 89de754f0e UI: Restrict textarea resizing to vertical to prevent ugliness. 
props tyxla, MatheusFD.
fixes #33400.

Built from https://develop.svn.wordpress.org/trunk@33890


git-svn-id: http://core.svn.wordpress.org/trunk@33859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:05:25 +00:00
Sergey Biryukov ba056692a6 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-includes/class-wp-customize-manager.php`. 
props kraftbj.
fixes #33684. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33889


git-svn-id: http://core.svn.wordpress.org/trunk@33858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 09:21:23 +00:00
Sergey Biryukov bc8af88903 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/network/site-users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33888


git-svn-id: http://core.svn.wordpress.org/trunk@33857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 09:03:24 +00:00
Sergey Biryukov 771b29455b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33887


git-svn-id: http://core.svn.wordpress.org/trunk@33856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:59:24 +00:00
Sergey Biryukov c4ce11422c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/widgets.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33886


git-svn-id: http://core.svn.wordpress.org/trunk@33855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:56:24 +00:00
Sergey Biryukov ce05b02a59 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33885


git-svn-id: http://core.svn.wordpress.org/trunk@33854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:54:24 +00:00
Sergey Biryukov b4fbbf53cf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/user-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33884


git-svn-id: http://core.svn.wordpress.org/trunk@33853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:46:52 +00:00
Drew Jaynes e2038f9150 Docs: Add inline DocBlocks for the `require_once()` calls that now bring in top-level HTTP API functionality and HTTP API classes. 
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.

Built from https://develop.svn.wordpress.org/trunk@33882


git-svn-id: http://core.svn.wordpress.org/trunk@33851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 04:36:30 +00:00
Drew Jaynes 69375b243a Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33881


git-svn-id: http://core.svn.wordpress.org/trunk@33850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 04:36:08 +00:00
Drew Jaynes 853fd32e88 Docs: Add a missing file header for wp-includes/class-http.php. 
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33880


git-svn-id: http://core.svn.wordpress.org/trunk@33849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:39:21 +00:00
Drew Jaynes 05ec4d2029 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748]. 
Also removes now-moot extra information from the file header description.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33879


git-svn-id: http://core.svn.wordpress.org/trunk@33848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:37:20 +00:00
Drew Jaynes d948d8e104 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33878


git-svn-id: http://core.svn.wordpress.org/trunk@33846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:33:21 +00:00
Drew Jaynes b9ef409823 Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33876


git-svn-id: http://core.svn.wordpress.org/trunk@33844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:30:21 +00:00
Drew Jaynes f7ba27390c Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33875


git-svn-id: http://core.svn.wordpress.org/trunk@33843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:28:21 +00:00
Drew Jaynes 378d3e0f8d Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33874


git-svn-id: http://core.svn.wordpress.org/trunk@33842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:23:21 +00:00
Drew Jaynes c42da1df59 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748]. 
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33873


git-svn-id: http://core.svn.wordpress.org/trunk@33841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:19:21 +00:00
Drew Jaynes 31f52091ec Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API. 
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33872


git-svn-id: http://core.svn.wordpress.org/trunk@33840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:14:20 +00:00
Drew Jaynes 0ce0241740 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33871


git-svn-id: http://core.svn.wordpress.org/trunk@33839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:58:20 +00:00
Drew Jaynes 95dc9825a7 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33870


git-svn-id: http://core.svn.wordpress.org/trunk@33838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:54:22 +00:00
Drew Jaynes a92dc6aeed Docs: Improve the file header for class-wp-widget.php to describe what the file contains. 
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33869


git-svn-id: http://core.svn.wordpress.org/trunk@33837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:50:21 +00:00
Drew Jaynes ab990ac594 Docs: Add a missing summary to the DocBlock for `Walker::get_number_of_root_elements()`. 
Props wen-solutions
See #33662.

Built from https://develop.svn.wordpress.org/trunk@33868


git-svn-id: http://core.svn.wordpress.org/trunk@33836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 19:51:21 +00:00
Scott Taylor 3cad9d8385 After [33723], ensure that `$i` is properly set before looping. 
See #16865.

Built from https://develop.svn.wordpress.org/trunk@33867


git-svn-id: http://core.svn.wordpress.org/trunk@33835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:48:22 +00:00
Sergey Biryukov bc0a1e1c4b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/themes.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33866


git-svn-id: http://core.svn.wordpress.org/trunk@33834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:45:21 +00:00
Sergey Biryukov 3e0929740e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/press-this.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33865


git-svn-id: http://core.svn.wordpress.org/trunk@33833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:38:21 +00:00
Sergey Biryukov d5ac2bc41e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/post-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33864


git-svn-id: http://core.svn.wordpress.org/trunk@33832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:36:22 +00:00
Sergey Biryukov a880c5c576 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/options.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33863


git-svn-id: http://core.svn.wordpress.org/trunk@33831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:31:21 +00:00
Sergey Biryukov 5ceecc4eaf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/nav-menus.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33862


git-svn-id: http://core.svn.wordpress.org/trunk@33830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:21:21 +00:00
Sergey Biryukov b136b074bf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33861


git-svn-id: http://core.svn.wordpress.org/trunk@33829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:15:20 +00:00
Sergey Biryukov d2919e2d71 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit-comments.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33860


git-svn-id: http://core.svn.wordpress.org/trunk@33828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:04:21 +00:00
Sergey Biryukov 31b0fe4b6f Set svn:eol-style for the files added in [32806]. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@33859


git-svn-id: http://core.svn.wordpress.org/trunk@33827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:55:21 +00:00
John Blackbourn 6aad2eb98c Correctly encode spaces in URLs passed to `esc_url()` instead of removing them. 
Fixes #23605
Props enshrined, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33858


git-svn-id: http://core.svn.wordpress.org/trunk@33826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:20:21 +00:00
Sergey Biryukov 3d1c08a1a5 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/customize.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33857


git-svn-id: http://core.svn.wordpress.org/trunk@33825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:05:22 +00:00
Andrea Fercia f35c176426 Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604]. 
Fixes #33633.
Built from https://develop.svn.wordpress.org/trunk@33856


git-svn-id: http://core.svn.wordpress.org/trunk@33824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:56:20 +00:00
John Blackbourn 06c86124ad More unit tests for `esc_url()` and `esc_url_raw()`. 
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33855


git-svn-id: http://core.svn.wordpress.org/trunk@33823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:51:21 +00:00
Sergey Biryukov cf69e6deb3 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/custom-header.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33854


git-svn-id: http://core.svn.wordpress.org/trunk@33822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:29:21 +00:00
Sergey Biryukov d95417a5e7 Provide more helful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/media-upload.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33853


git-svn-id: http://core.svn.wordpress.org/trunk@33821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:21:21 +00:00
Sergey Biryukov c3b663ad8d Provide more helful feedback than just “Cheatin’ uh?” for permission errors in `wp-admin/edit-tags.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33852


git-svn-id: http://core.svn.wordpress.org/trunk@33820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:06:21 +00:00
John Blackbourn 867a449fee Add some more passing unit tests for `esc_url()` in preparation for upcoming changes. 
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33851


git-svn-id: http://core.svn.wordpress.org/trunk@33819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 14:20:21 +00:00
Boone Gorges 709fde7584 Remove `#` from `@ticket` annotation in a unit test. 
This improper character was erroneously introduced in [33724].

Props netweb.
Fixes #33532.
Built from https://develop.svn.wordpress.org/trunk@33850


git-svn-id: http://core.svn.wordpress.org/trunk@33818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 13:40:21 +00:00
John Blackbourn 606b6d15f1 Introduce `wp_removable_query_args()`, which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90

Built from https://develop.svn.wordpress.org/trunk@33849


git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 11:29:23 +00:00
Jeremy Felt 9666aec8d1 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.

Built from https://develop.svn.wordpress.org/trunk@33848


git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:51:21 +00:00
Drew Jaynes 05c7abcf13 Docs: Add missing parameter documentation to the the DocBlock for `WP_User::__set()`. 
Props racase for the initial patch.
Fixes #33652.

Built from https://develop.svn.wordpress.org/trunk@33847


git-svn-id: http://core.svn.wordpress.org/trunk@33815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:47:21 +00:00
Scott Taylor 0415dd7c53 After [33807], fix unit tests for PHP 5.2 
Fixes #17626.

Built from https://develop.svn.wordpress.org/trunk@33846


git-svn-id: http://core.svn.wordpress.org/trunk@33814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 17:04:21 +00:00
Scott Taylor 9f8816c939 De-Jorbin [33814]. 
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33845


git-svn-id: http://core.svn.wordpress.org/trunk@33813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 15:48:22 +00:00
Sergey Biryukov bffe6a63ba Make curly quotes in playlist item title translatable. 
fixes #33391.
Built from https://develop.svn.wordpress.org/trunk@33844


git-svn-id: http://core.svn.wordpress.org/trunk@33812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:50:21 +00:00
Scott Taylor 9b8169bd30 Move widget classes to their own files in `wp-includes/widgets`: 
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.

Built from https://develop.svn.wordpress.org/trunk@33843


git-svn-id: http://core.svn.wordpress.org/trunk@33811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:49:21 +00:00
Sergey Biryukov 32b5726fd4 Merge two similar strings. 
props pavelevap.
fixes #33643.
Built from https://develop.svn.wordpress.org/trunk@33842


git-svn-id: http://core.svn.wordpress.org/trunk@33810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:46:24 +00:00
Scott Taylor ecf0b82afb Add some JS docs to `customize-base.js` 
Props ericlewis.
Fixes #33639.

Built from https://develop.svn.wordpress.org/trunk@33841


git-svn-id: http://core.svn.wordpress.org/trunk@33809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 04:15:22 +00:00
Scott Taylor a829ee32ce User Settings: allow dashes in `get|set_user_setting()` in PHP and `get|setUserSetting()` in JS. 
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.

Built from https://develop.svn.wordpress.org/trunk@33840


git-svn-id: http://core.svn.wordpress.org/trunk@33808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 03:57:21 +00:00
Sergey Biryukov db71d238dd Correct `@since` version for [33838]. 
props JustinSainton.
see #23692.
Built from https://develop.svn.wordpress.org/trunk@33839


git-svn-id: http://core.svn.wordpress.org/trunk@33807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 03:14:21 +00:00
Sergey Biryukov 13540a6b30 Add filters to `feed_links()` to choose whether to display the links to posts feed and comments feed, separately. 
props joostdevalk, juliobox.
fixes #23692.
Built from https://develop.svn.wordpress.org/trunk@33838


git-svn-id: http://core.svn.wordpress.org/trunk@33806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 02:46:21 +00:00
Weston Ruter 1413f2edd5 Customizer: Collapse any expanded panel/sections before expanding other panel/sections 
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33837


git-svn-id: http://core.svn.wordpress.org/trunk@33805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 23:08:42 +00:00
Andrew Ozz e3f3f470ea Editor, Press This: force a page reload when the user publishes a post and then clicks the back button. 
Fixes #23691.
Built from https://develop.svn.wordpress.org/trunk@33836


git-svn-id: http://core.svn.wordpress.org/trunk@33804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 23:08:22 +00:00
Andrew Ozz db0ca19899 TinyMCE: disable the native fullscreen plugin on mobile devices by default. 
Props iseulde. Fixes #33137;
Built from https://develop.svn.wordpress.org/trunk@33835


git-svn-id: http://core.svn.wordpress.org/trunk@33803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 22:45:22 +00:00
Andrew Ozz a231303341 TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content. 
Fixes #33477.
Built from https://develop.svn.wordpress.org/trunk@33834


git-svn-id: http://core.svn.wordpress.org/trunk@33802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 22:07:21 +00:00
Sergey Biryukov 43194cea1c Add `'dashboard_secondary_items'` filter for the number of secondary link items in the 'WordPress News' dashboard widget. 
props MikeHansenMe, DrewAPicture.
fixes #31434.
Built from https://develop.svn.wordpress.org/trunk@33833


git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:57:21 +00:00
Sergey Biryukov a53d6b471f Add `'update_right_now_text'` filter for the text displayed in the 'At a Glance' dashboard widget. 
props obenland.
fixes #33355.
Built from https://develop.svn.wordpress.org/trunk@33832


git-svn-id: http://core.svn.wordpress.org/trunk@33800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:45:21 +00:00
John Blackbourn 6a0818996d Space out. 
Built from https://develop.svn.wordpress.org/trunk@33831


git-svn-id: http://core.svn.wordpress.org/trunk@33799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:25:21 +00:00
Drew Jaynes 375d30f699 Docs: Add a duplicate filter comment to the `comment_email` filter call in `WP_Comments_List_Table`, introduced in [33829]. 
See #11566.

Built from https://develop.svn.wordpress.org/trunk@33830


git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:22:21 +00:00
Scott Taylor a5b157ffde Remove the hamburger global'ing from [33828]: since no args are passed to `comment_author_email_link()`, the internals can be simplified and applied inline. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33829


git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:09:21 +00:00
Scott Taylor d0a1a47708 Fix warnings after [33826]. Only only one function call needs a global `$comment`, we shall hamburger it. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33828


git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:59:21 +00:00
Drew Jaynes cf7694717b Docs: Clarify the DocBlock summary for `wp_create_nonce()` to mention that nonce-creation is also now dependent on user tokens, as of [29221]. 
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.

Props ericlewis
Fixes #33636.

Built from https://develop.svn.wordpress.org/trunk@33827


git-svn-id: http://core.svn.wordpress.org/trunk@33795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:50:20 +00:00
Scott Taylor 7ab015c5ab `WP_Comments_List_Table::single_row()` has no reason to set the `$comment` global. No other methods use it, and we are not in template/loop context. This can mess with the response of `get_comment()` elsewhere, since `get_comment()` internally bypasses the cache/db when a global is set. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33826


git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:42:21 +00:00
Sergey Biryukov 8b1fe986c3 Use `wp_html_excerpt()` to properly cut comment author URL for display on Comments screen. 
props brettz95, solarissmoke.
fixes #15659.
Built from https://develop.svn.wordpress.org/trunk@33825


git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:41:21 +00:00
Scott Taylor 50d0f8f1ae `WP_Widget_Pages::widget()` has no reason to set `$comment` and `$comments` globals. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33824


git-svn-id: http://core.svn.wordpress.org/trunk@33792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:31:22 +00:00
Scott Taylor 1f1b72b5f5 After [33822], really add those unit tests for `wp_count_comments()`. 
See #19903. 

Built from https://develop.svn.wordpress.org/trunk@33823


git-svn-id: http://core.svn.wordpress.org/trunk@33791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 18:51:41 +00:00
Scott Taylor 6ae78f0fe4 Comments: `wp_count_comments()` can use `get_comment_count()` internally to makes its DB query, provided that `get_comment_count()` returns more properties. 
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.

Fixes #19903. 

Built from https://develop.svn.wordpress.org/trunk@33822


git-svn-id: http://core.svn.wordpress.org/trunk@33790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 18:51:22 +00:00
Scott Taylor 7808d5d1fa Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation. 
Fixes #33414. 

Built from https://develop.svn.wordpress.org/trunk@33821


git-svn-id: http://core.svn.wordpress.org/trunk@33789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 17:58:22 +00:00
Sergey Biryukov 5a97ff5206 Bump H3 headings to H2 on Themes screen for better accessibility. 
props joehills.
fixes #33560.
Built from https://develop.svn.wordpress.org/trunk@33820


git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 03:51:21 +00:00
Sergey Biryukov 82a8cec3b3 Bump H3 headings to H2 on Tools screen for better accessibility. 
props Cheffheid.
fixes #33607.
Built from https://develop.svn.wordpress.org/trunk@33819


git-svn-id: http://core.svn.wordpress.org/trunk@33787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 03:32:21 +00:00
Sergey Biryukov 48c82ef14d Bump H3 headings to H2 on Permalink Settings screen for better accessibility. 
props Cheffheid.
fixes #33611.
Built from https://develop.svn.wordpress.org/trunk@33818


git-svn-id: http://core.svn.wordpress.org/trunk@33786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 03:29:21 +00:00
Sergey Biryukov fb3d54d569 Bump H3 headings to H2 on WordPress Updates screen for better accessibility. 
props Cheffheid.
fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@33817


git-svn-id: http://core.svn.wordpress.org/trunk@33785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 03:26:24 +00:00
Drew Jaynes 4d006fad9e Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard: 
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant

See #33413

Built from https://develop.svn.wordpress.org/trunk@33816


git-svn-id: http://core.svn.wordpress.org/trunk@33784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 23:14:21 +00:00
Konstantin Obenland 1e9372b699 Themes: Get the correct theme when template and stylesheet were both passed as arguments. 
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.

Introduced in [21131].

Props obenland, wonderboymusic.
Fixes #32635.


Built from https://develop.svn.wordpress.org/trunk@33815


git-svn-id: http://core.svn.wordpress.org/trunk@33783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 21:45:23 +00:00
Scott Taylor b35b167cfc Improve/update escaping in default widgets: 
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs

Props welcher.
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33814


git-svn-id: http://core.svn.wordpress.org/trunk@33782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 05:38:21 +00:00
Scott Taylor 42f915273d Improve/update escaping in `WP_Widget_Pages`. 
Props welcher.
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33813


git-svn-id: http://core.svn.wordpress.org/trunk@33781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 04:47:22 +00:00
Scott Taylor 848c40c6a7 Add some theme mod unit tests. 
Props MikeHansenMe.
See #28637.

Built from https://develop.svn.wordpress.org/trunk@33812


git-svn-id: http://core.svn.wordpress.org/trunk@33780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 03:43:22 +00:00
Scott Taylor 107a7104bd Fix the doc block syntax for the `'wp_get_current_commenter'` filter. 
Props dimadin.
Fixes #33304.

Built from https://develop.svn.wordpress.org/trunk@33811


git-svn-id: http://core.svn.wordpress.org/trunk@33779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 03:21:20 +00:00
Scott Taylor db11b48627 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table. 
Props pavelevap.
Fixes #33515.

Built from https://develop.svn.wordpress.org/trunk@33810


git-svn-id: http://core.svn.wordpress.org/trunk@33778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 03:10:21 +00:00
Scott Taylor d5f666013f Fix copy pasta in `wp_cache_decr()` doc block. 
Props danielbachhuber.
Fixes #33548.

Built from https://develop.svn.wordpress.org/trunk@33809


git-svn-id: http://core.svn.wordpress.org/trunk@33777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 03:04:21 +00:00
Scott Taylor 32110c7f77 Switching themes: if the new theme doesn't have `nav_menu_locations` defined, but the old theme does, copy the old theme's `nav_menu_locations` into the new theme's theme mods. 
cc melchoyce

Fixes #18588.

Built from https://develop.svn.wordpress.org/trunk@33808


git-svn-id: http://core.svn.wordpress.org/trunk@33776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 03:01:21 +00:00
Scott Taylor 0d3f30ba61 Improve the reliability of the crop returned by `image_get_intermediate_size()`. 
Add a bunch of unit tests to `tests/image/intermediate_size.php`.

Props joemcgill, ericlewis, kitchin, SergeyBiryukov, chipbennett.
Fixes #17626.

Built from https://develop.svn.wordpress.org/trunk@33807


git-svn-id: http://core.svn.wordpress.org/trunk@33775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 02:41:21 +00:00
Scott Taylor e49980bdc1 `get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash. This occurs because `case 0:` will match any value passed to `switch` that is a string that isn't specified in the list of cases. This is terrifying. 
* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.

See #33414.

Built from https://develop.svn.wordpress.org/trunk@33806


git-svn-id: http://core.svn.wordpress.org/trunk@33774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-30 02:19:21 +00:00
Boone Gorges a0e00c0d24 Pass taxonomy name to filters in `get_adjacent_post()`. 
Props sboisvert.
Fixes #33568.
Built from https://develop.svn.wordpress.org/trunk@33805


git-svn-id: http://core.svn.wordpress.org/trunk@33773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-29 19:59:21 +00:00
Boone Gorges 7f5a8e6680 In `wp_list_categories()`, 'current_category' should accept an array of values. 
This allows the 'current-cat' or 'current-cat-parent' classes to be applied
to more than one item in the list.

Props vilkatis.
Fixes #33565.
Built from https://develop.svn.wordpress.org/trunk@33804


git-svn-id: http://core.svn.wordpress.org/trunk@33772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-29 19:46:23 +00:00
Boone Gorges f1d6acac56 Simplify the weeks-per-year calculation `WP_Date_Query::validate_date_values()`. 
Props luciole135.
Fixes #30845.
Built from https://develop.svn.wordpress.org/trunk@33803


git-svn-id: http://core.svn.wordpress.org/trunk@33771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-29 01:47:21 +00:00
Sergey Biryukov 50d4d4a956 Make a period translatable. 
props mako09.
fixes #33594.
Built from https://develop.svn.wordpress.org/trunk@33802


git-svn-id: http://core.svn.wordpress.org/trunk@33770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-29 01:40:21 +00:00
John Blackbourn 6ee45a9606 Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens. 
Fixes #32913

Built from https://develop.svn.wordpress.org/trunk@33801


git-svn-id: http://core.svn.wordpress.org/trunk@33769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-29 00:19:24 +00:00
Sergey Biryukov 0764191402 Twenty Fifteen: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.
Built from https://develop.svn.wordpress.org/trunk@33800


git-svn-id: http://core.svn.wordpress.org/trunk@33768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 16:55:00 +00:00
Sergey Biryukov a17a93dfc9 Twenty Fourteen: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.
Built from https://develop.svn.wordpress.org/trunk@33799


git-svn-id: http://core.svn.wordpress.org/trunk@33767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 16:54:41 +00:00
Sergey Biryukov a842133f97 Twenty Thirteen: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.
Built from https://develop.svn.wordpress.org/trunk@33798


git-svn-id: http://core.svn.wordpress.org/trunk@33766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 16:54:20 +00:00
Sergey Biryukov 5035f85bb4 Twenty Twelve: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.
Built from https://develop.svn.wordpress.org/trunk@33797


git-svn-id: http://core.svn.wordpress.org/trunk@33765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 16:53:02 +00:00
Sergey Biryukov 0a40e3a1eb Twenty Eleven: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.
Built from https://develop.svn.wordpress.org/trunk@33796


git-svn-id: http://core.svn.wordpress.org/trunk@33764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 16:52:41 +00:00
Sergey Biryukov 5373802ffa Twenty Ten: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.
Built from https://develop.svn.wordpress.org/trunk@33795


git-svn-id: http://core.svn.wordpress.org/trunk@33763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 16:52:21 +00:00
Drew Jaynes 6a839cf091 Docs: Add a changelog entry to the `set_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
Fixes #28402.

Built from https://develop.svn.wordpress.org/trunk@33794


git-svn-id: http://core.svn.wordpress.org/trunk@33762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:41:21 +00:00
Drew Jaynes 0c2d49b844 Docs: Add a changelog entry to the `pre_set_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33793


git-svn-id: http://core.svn.wordpress.org/trunk@33761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:40:21 +00:00
Drew Jaynes 45c5fe16c2 Docs: Add a changelog entry to the `site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33792


git-svn-id: http://core.svn.wordpress.org/trunk@33760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:39:21 +00:00
Drew Jaynes 5e8df999b8 Docs: Add a changelog entry to the `pre_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33791


git-svn-id: http://core.svn.wordpress.org/trunk@33759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:37:21 +00:00
Drew Jaynes 2f926931a0 Docs: Add a changelog entry to the `pre_update_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33790


git-svn-id: http://core.svn.wordpress.org/trunk@33758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:36:21 +00:00
Drew Jaynes 9342ae98e9 Docs: Add a changelog entry to the `pre_delete_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33789


git-svn-id: http://core.svn.wordpress.org/trunk@33757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:35:21 +00:00
Drew Jaynes f62b7a70ba Docs: Add a changelog entry to the `pre_add_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33788


git-svn-id: http://core.svn.wordpress.org/trunk@33756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:34:21 +00:00
Drew Jaynes 5d1a7579b2 Docs: Add a changelog entry to the `site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33787


git-svn-id: http://core.svn.wordpress.org/trunk@33755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:32:21 +00:00
Drew Jaynes 6ec59018cf Docs: Add a changelog entry to the `default_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33786


git-svn-id: http://core.svn.wordpress.org/trunk@33754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:31:21 +00:00
Drew Jaynes 111559495f Docs: Add a changelog entry to the `pre_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33785


git-svn-id: http://core.svn.wordpress.org/trunk@33753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:30:20 +00:00
Drew Jaynes 94775c9391 Docs: Add a changelog entry to the `pre_set_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33784


git-svn-id: http://core.svn.wordpress.org/trunk@33752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:29:21 +00:00
Drew Jaynes df9aa619d7 Docs: Add a changelog entry to the `transient_$transient` hook doc for the `$transient` parameter, introduced in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33783


git-svn-id: http://core.svn.wordpress.org/trunk@33751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:27:20 +00:00
Drew Jaynes d850f67df6 Docs: Add a changelog entry to the `pre_transient_$transient` hook doc for the `$transient` parameter, introduced in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33782


git-svn-id: http://core.svn.wordpress.org/trunk@33750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:25:21 +00:00
Drew Jaynes 7cec289b60 Docs: Add a changelog entry to the `update_option_{$option}` hook doc for the `$option` parameter, introduced in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33781


git-svn-id: http://core.svn.wordpress.org/trunk@33749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:24:21 +00:00
Drew Jaynes 96cd3a4a3c Docs: Add a changelog entry to the `pre_update_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33780


git-svn-id: http://core.svn.wordpress.org/trunk@33748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:22:20 +00:00
Drew Jaynes e33d5c45bc Docs: Add a changelog entry to the `option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.

Built from https://develop.svn.wordpress.org/trunk@33779


git-svn-id: http://core.svn.wordpress.org/trunk@33747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:20:20 +00:00
Drew Jaynes 7c02c6b6fb Docs: Add a changelog entry to the `default_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402

Built from https://develop.svn.wordpress.org/trunk@33778


git-svn-id: http://core.svn.wordpress.org/trunk@33746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 15:18:22 +00:00
Sergey Biryukov d10fc64ab5 Network Admin: Hide the bulk actions checkbox for super admins. 
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.
Built from https://develop.svn.wordpress.org/trunk@33777


git-svn-id: http://core.svn.wordpress.org/trunk@33745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:49:21 +00:00
Sergey Biryukov 4e77ffdee1 In `get_post_type_labels()`, ensure that filtered labels contain all required default values. 
fixes #33543.
Built from https://develop.svn.wordpress.org/trunk@33776


git-svn-id: http://core.svn.wordpress.org/trunk@33744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:39:21 +00:00
Sergey Biryukov 78d43de7e4 Avoid PHP notices in `redirect_canonical()` and `_wp_menu_item_classes_by_context()` if `$_SERVER['HTTP_HOST']` is not set. 
fixes #32229.
Built from https://develop.svn.wordpress.org/trunk@33775


git-svn-id: http://core.svn.wordpress.org/trunk@33743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:31:20 +00:00
Helen Hou-Sandí 1f500055a6 Drop the hyphen from e-mail and standardize on email. 
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.

Built from https://develop.svn.wordpress.org/trunk@33774


git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:17:21 +00:00
John Blackbourn 6d7aeeac03 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post. 
Fixes #32954
Props boonebgorges, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33773


git-svn-id: http://core.svn.wordpress.org/trunk@33741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 20:57:22 +00:00
Sergey Biryukov 4ae4d94dbb Remove `wp-includes/comment-functions.php` from the `$_old_files` array. See [33750]. 
props rachelbaker.
fixes #33569.
Built from https://develop.svn.wordpress.org/trunk@33772


git-svn-id: http://core.svn.wordpress.org/trunk@33740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 20:40:24 +00:00
John Blackbourn 69bee8ed43 Improve the efficiency of `is_user_member_of_blog()` by removing its use of `get_blogs_of_user()`. Adds additional tests. 
Fixes #32472
Props BinaryKitten, sammybeats, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33771


git-svn-id: http://core.svn.wordpress.org/trunk@33739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 20:02:23 +00:00
John Blackbourn b9ec4136d9 Remove `error` from the query variables when cleaning up a URL in `wp_admin_canonical_url()`. 
Fixes #32847

Built from https://develop.svn.wordpress.org/trunk@33770


git-svn-id: http://core.svn.wordpress.org/trunk@33738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 17:26:21 +00:00
John Blackbourn a60d143f7b Correct the hook docs for the `user_profile_update_errors` action. 
Fixes #33537
Props yamchhetri

Built from https://develop.svn.wordpress.org/trunk@33769


git-svn-id: http://core.svn.wordpress.org/trunk@33737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 17:16:21 +00:00
Drew Jaynes 4affa545d0 Docs: Add a changelog entry to the `pre_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402

Built from https://develop.svn.wordpress.org/trunk@33768


git-svn-id: http://core.svn.wordpress.org/trunk@33736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 17:00:24 +00:00
Boone Gorges 8670349f70 Rename param added to `wp_list_categories()` in [33764] to 'hide_title_if_empty'. 
Props vilkatis, DrewAPicture.
Fixes #33565.
Built from https://develop.svn.wordpress.org/trunk@33767


git-svn-id: http://core.svn.wordpress.org/trunk@33735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 02:09:21 +00:00
Sergey Biryukov be59078ef8 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile. 
props peterwilsoncc.
fixes #33419 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33766


git-svn-id: http://core.svn.wordpress.org/trunk@33734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-27 00:11:21 +00:00
Boone Gorges 0db421e69b After [33764], fix docblock formatting for `wp_list_categories()`. 
See #33460.
Built from https://develop.svn.wordpress.org/trunk@33765


git-svn-id: http://core.svn.wordpress.org/trunk@33733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 19:43:24 +00:00
Boone Gorges ccb9c641f4 Introduce `hide_title_if_no_cats` parameter to `wp_list_categories()`. 
When generating a `<ul>` using `wp_list_categories()`, a title `<li>` element
is put at the top of the term list. Current behavior is that this title `<li>`
appears even when no terms are found. The new `hide_title_if_no_cats` param
allows developers to specify that the title should be hidden when the term list
is empty.

Props vilkatis.
Fixes #33460.
Built from https://develop.svn.wordpress.org/trunk@33764


git-svn-id: http://core.svn.wordpress.org/trunk@33732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 19:42:21 +00:00
Boone Gorges d031a79a3e Use proper array documentation formatting for `wp_list_categories()`. 
This changeset also corrects a few parameter descriptions, and adds a few that
were previously missing.

Fixes #33556.
Built from https://develop.svn.wordpress.org/trunk@33763


git-svn-id: http://core.svn.wordpress.org/trunk@33731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 15:30:21 +00:00
Sergey Biryukov fc9961ca22 Make post meta box toggles accessible. 
props joedolson.
fixes #33544.
Built from https://develop.svn.wordpress.org/trunk@33762


git-svn-id: http://core.svn.wordpress.org/trunk@33730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 15:23:24 +00:00
Scott Taylor b6c01b80fa Meta: move `WP_Meta_Query` into its own file. `meta.php` loads the new files, so this is 100% BC if someone is loading `meta.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-meta-query.php` 
`meta-functions.php` 

`meta.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33761


git-svn-id: http://core.svn.wordpress.org/trunk@33729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 13:02:21 +00:00
Scott Taylor fa0dc526f4 Taxonomy: move `WP_Tax_Query` into its own file. `taxonomy.php` loads the new files, so this is 100% BC if someone is loading `taxonomy.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-tax-query.php` 
`taxonomy-functions.php` 

`taxonomy.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33760


git-svn-id: http://core.svn.wordpress.org/trunk@33728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 12:49:21 +00:00
Scott Taylor cd99e0cfff Posts: move `WP_Post` into its own file. `post.php` loads the new files, so this is 100% BC if someone is loading `post.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-post.php` 
`post-functions.php` 

`post.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33759


git-svn-id: http://core.svn.wordpress.org/trunk@33727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 12:40:21 +00:00
Drew Jaynes fb75e4b938 Docs: Add inline-docblocks for the `require_once()` calls that now bring in the `WP_Widget` and `WP_Widget_Factory` classes, as well as general core widgets functionality, as of [33746]. 
See [33746]. See #33413.

Built from https://develop.svn.wordpress.org/trunk@33758


git-svn-id: http://core.svn.wordpress.org/trunk@33726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 08:01:20 +00:00
Drew Jaynes f21cb339db Docs: Add a file header description and `@since` version to wp-includes/widget-functions.php, introduced in [33746]. 
Also adds sub-section headers per the inline documentation standards for syntax.

See [33746]. See #33413.

Built from https://develop.svn.wordpress.org/trunk@33757


git-svn-id: http://core.svn.wordpress.org/trunk@33725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 07:57:20 +00:00
Drew Jaynes 5a77c96ea6 Docs: Add a file header to wp-includes/class-wp-widget-factory.php, created when the `WP_Widget_Factory` class was moved to its own file in [33746]. 
It's important for every file in WordPress, regardless of makeup or architecture, to have its own file header, even if the file contains nothing but a class. When parsed, files and classes are mutually exclusive and should be documented with this in mind.

See [33746]. See #33413.

Built from https://develop.svn.wordpress.org/trunk@33756


git-svn-id: http://core.svn.wordpress.org/trunk@33724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 07:53:21 +00:00
Drew Jaynes 2aa0a42661 Docs: Add a file header to wp-includes/class-wp-widget.php, created when the `WP_Widget` class was moved to its own file in [33746]. 
It's important for every file in WordPress, regardless of makeup or architecture, to have its own file header, even if the file contains nothing but a class. When parsed, files and classes are mutually exclusive and should be documented with this in mind.

See [33746]. See #33413.

Built from https://develop.svn.wordpress.org/trunk@33755


git-svn-id: http://core.svn.wordpress.org/trunk@33723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 07:45:21 +00:00
Weston Ruter 10503cd3af Customizer: Ensure persistence of unchanged `active` state for controls, sections, and panels. 
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494.

Built from https://develop.svn.wordpress.org/trunk@33754


git-svn-id: http://core.svn.wordpress.org/trunk@33722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 07:26:21 +00:00
Weston Ruter a2d9547825 Customizer: Prevent JS error during init when `nav_menus` panel is removed by plugin. 
Fixes #33411 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33753


git-svn-id: http://core.svn.wordpress.org/trunk@33721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 06:43:22 +00:00
Scott Taylor df1c0c2363 Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-roles.php` 
`class-wp-role.php` 
`class-wp-user.php` 
`capbilities-functions.php` 

`capbilities.php` contains only top-level code. Class files only contains classes. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33752


git-svn-id: http://core.svn.wordpress.org/trunk@33720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 04:58:21 +00:00
Scott Taylor 207abc77e1 Rewrite: move `WP_Rewrite` into its own file. `rewrite.php` loads the new files, so this is 100% BC if someone is loading `rewrite.php` directly. New files created using `svn cp`. 
The rewrite functions have all kinds of cross-dependencies (like `WP_Query`), so loading the file by itself would have been bizarre (and still is).

Creates: 
`rewrite-constants.php` 
`rewrite-functions.php` 
`class-wp-rewrite.php` 

`rewrite.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33751


git-svn-id: http://core.svn.wordpress.org/trunk@33719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 04:42:20 +00:00
Scott Taylor f07ab12359 Comments: move `WP_Comment_Query` into its own file. `comment.php` loads the new files, so this is 100% BC if someone is loading `comment.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-comment-query.php` 
`comment-functions.php` 

`comment.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33750


git-svn-id: http://core.svn.wordpress.org/trunk@33718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 04:27:21 +00:00
Scott Taylor 484331e492 Users: move `WP_User_Query` into its own file. `user.php` loads the new files, so this is 100% BC if someone is loading `user.php` directly (a lot of plugins do). New files created using `svn cp`. 
Creates: 
`class-wp-user-query.php` 
`user-functions.php` 

`user.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33749


git-svn-id: http://core.svn.wordpress.org/trunk@33717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 04:20:21 +00:00
Scott Taylor 7c8c216bec HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 
`class-http.php` requires functions from `http.php`, so loading it by itself wouldn't have worked.

Creates: 
`class-wp-http-cookie.php` 
`class-wp-http-curl.php` 
`class-wp-http-encoding.php` 
`class-wp-http-proxy.php` 
`class-wp-http-streams.php` 
`http-functions.php` 

`WP_Http` remains in `class-http.php`.

`http.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33748


git-svn-id: http://core.svn.wordpress.org/trunk@33716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 03:55:21 +00:00
Gary Pendergast 48e83418ed When `wp_json_encode()` calls `json_encode()`, the latter will generate warnings if the string contains non-UTF-8 characters. No-one likes warnings, so we need to do something about that. 
The good news is, the point of `wp_json_encode()` is to handle those non-UTF-8 characters. It'll totally just fix them up, no problem.

Anyway, we can just ignore those warnings.

Fixes #33524.


Built from https://develop.svn.wordpress.org/trunk@33747


git-svn-id: http://core.svn.wordpress.org/trunk@33715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 03:26:21 +00:00
Scott Taylor c3565b2cba Widgets: move classes into their own files, `widgets.php` loads the new files, so this is 100% BC if someone is loading `widgets.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-widget.php` 
`class-wp-widget-factory.php` 
`widget-functions.php` 

`widgets.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@33746


git-svn-id: http://core.svn.wordpress.org/trunk@33714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 02:40:23 +00:00
Sergey Biryukov a6ea3624ef Add oEmbed support for ReverbNation. 
props rhubbardreverb.
fixes #33207.
Built from https://develop.svn.wordpress.org/trunk@33745


git-svn-id: http://core.svn.wordpress.org/trunk@33713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 00:29:21 +00:00
Sergey Biryukov 1f4ae40c03 Add `'wp_verify_nonce_failed'` action that fires when nonce verification fails. 
props johnbillion, garza, Shelob9.
fixes #24030.
Built from https://develop.svn.wordpress.org/trunk@33744


git-svn-id: http://core.svn.wordpress.org/trunk@33712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-26 00:06:21 +00:00
Sergey Biryukov b34af5586a Fire the `check_ajax_referer` action on failure as well as success. 
See [33017] for `check_admin_referer`.

props egill.
fixes #33342.
Built from https://develop.svn.wordpress.org/trunk@33743


git-svn-id: http://core.svn.wordpress.org/trunk@33711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 23:25:21 +00:00
Sergey Biryukov d75453cc7c Remove rounded corners from "Choose from the most used tags" result in Tags meta box. 
props tyxla.
fixes #31560.
Built from https://develop.svn.wordpress.org/trunk@33742


git-svn-id: http://core.svn.wordpress.org/trunk@33710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 23:14:21 +00:00
Sergey Biryukov b4a5dd59f3 Customizer: Use existing decoupled strings in Menu Locations section. See [31941] and [31951]. 
props egill.
fixes #33416.
Built from https://develop.svn.wordpress.org/trunk@33741


git-svn-id: http://core.svn.wordpress.org/trunk@33709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 21:53:20 +00:00
Scott Taylor b68886efb4 Add some more data for Shortcode unit tests. 
Props miqrogroove.
Fixes #33455.

Built from https://develop.svn.wordpress.org/trunk@33740


git-svn-id: http://core.svn.wordpress.org/trunk@33708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 21:51:22 +00:00
Scott Taylor 8d27055b0c Allow these CSS properties in KSES: `min-height', 'max-height', 'min-width', 'max-width'` 
Props MikeHansenMe.
Fixes #31949.

Built from https://develop.svn.wordpress.org/trunk@33739


git-svn-id: http://core.svn.wordpress.org/trunk@33707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 21:46:20 +00:00
Scott Taylor a13230b93f Pass option name to option and transient filters with dynamic names. 
Props Viper007Bond, SergeyBiryukov, MikeHansenMe.
Fixes #28402.

Built from https://develop.svn.wordpress.org/trunk@33738


git-svn-id: http://core.svn.wordpress.org/trunk@33706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 21:42:20 +00:00
Scott Taylor 8913ea39f2 After [33698], wrap the time constants in a DocBlock template. 
Props egill.
Fixes #33397.

Built from https://develop.svn.wordpress.org/trunk@33737


git-svn-id: http://core.svn.wordpress.org/trunk@33705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 21:21:21 +00:00
Scott Taylor d8752c191d In `get_home_url()`, import the `$pagenow` global to avoid having to check if it exists before comparing against it. 
Props KalenJohnson.
See #33545.

Built from https://develop.svn.wordpress.org/trunk@33736


git-svn-id: http://core.svn.wordpress.org/trunk@33704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 21:03:20 +00:00
Scott Taylor 93f745fd9b In `WP_Users_List_Table::single_row()`, `$actions` is not always set before being used. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33735


git-svn-id: http://core.svn.wordpress.org/trunk@33703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:38:20 +00:00
Scott Taylor ef87172270 `foreach` is a statement, not a function. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33734


git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:28:22 +00:00
Scott Taylor c2a0336d22 Instead of [33713], allow `WP_Posts_List_Table::get_bulk_actions()` to check `edit_posts` AND `delete_posts`. 
Props DeBAAT.
Fixes #29789.

Built from https://develop.svn.wordpress.org/trunk@33733


git-svn-id: http://core.svn.wordpress.org/trunk@33701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:12:22 +00:00
Sergey Biryukov 85d3345e05 Multisite: Add `'invite_user'` action that fires immediately after a user is invited to join a site, but before the notification is sent. 
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008.
Built from https://develop.svn.wordpress.org/trunk@33732


git-svn-id: http://core.svn.wordpress.org/trunk@33700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 17:48:21 +00:00
Drew Jaynes e8283a6f88 Docs: The type for the `$t_time` parameter in the `post_date_column_time` filter docs should be `string`, not `array`. 
Props jjeaton
Fixes #33540.

Built from https://develop.svn.wordpress.org/trunk@33731


git-svn-id: http://core.svn.wordpress.org/trunk@33699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 17:15:21 +00:00
Drew Jaynes 7aff9092c7 Docs: Document the default comment data arguments for `wp_new_comment()`. 
Props rachelbaker, DrewAPicture
Fixes #32369.

Built from https://develop.svn.wordpress.org/trunk@33730


git-svn-id: http://core.svn.wordpress.org/trunk@33698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 17:03:21 +00:00
Scott Taylor 767dd35a47 Media: 
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.

Built from https://develop.svn.wordpress.org/trunk@33729


git-svn-id: http://core.svn.wordpress.org/trunk@33697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 12:13:23 +00:00
Andrew Ozz 25b0eedf2b TinyMCE: ensure the `wordpress` plugin is loaded before calling `_createToolbar()`. 
Props hauvong, azaozz. Fixes #33393.
Built from https://develop.svn.wordpress.org/trunk@33728


git-svn-id: http://core.svn.wordpress.org/trunk@33696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 04:38:20 +00:00
Dion Hulse 4f8ce1c232 Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423

Built from https://develop.svn.wordpress.org/trunk@33727


git-svn-id: http://core.svn.wordpress.org/trunk@33695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 04:32:21 +00:00
Gary Pendergast 0401ee6007 Build Tools: Update `grunt-contrib-uglify` to 0.9.2. 
Fixes #33533.


Built from https://develop.svn.wordpress.org/trunk@33726


git-svn-id: http://core.svn.wordpress.org/trunk@33694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 03:28:23 +00:00
Drew Jaynes dbdc8bf149 Docs: Clarify the return description for `wp_create_user()` to illustrate that a `WP_Error` object will be returned on failure. 
Props jmayhak
Fixes #33321.

Built from https://develop.svn.wordpress.org/trunk@33725


git-svn-id: http://core.svn.wordpress.org/trunk@33693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 22:23:24 +00:00
Boone Gorges 8a95b13cab In `WP_Query::parse_tax_query()`, allow 'cat' and 'tag' querystrings to be formatted as arrays. 
See [33095] #32454 for a previous fix related to custom taxonomies.

Props Veraxus.
Fixes #33532.
Built from https://develop.svn.wordpress.org/trunk@33724


git-svn-id: http://core.svn.wordpress.org/trunk@33691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 21:22:26 +00:00
Scott Taylor 21c61251a2 With a few modifications in `wp-admin/menu.php`, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare `menu_position` on post type registration. 
Props scribu, wonderboymusic.
Fixes #16865.

Built from https://develop.svn.wordpress.org/trunk@33723


git-svn-id: http://core.svn.wordpress.org/trunk@33690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 21:19:24 +00:00
Scott Taylor d345a6012c `WP_Query`: add changelog for the `title` param after [33706] 
Props dimadin.
Fixes #33074.

Built from https://develop.svn.wordpress.org/trunk@33722


git-svn-id: http://core.svn.wordpress.org/trunk@33689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 20:10:26 +00:00
Drew Jaynes d2517984e0 Docs: Improve pared formatting of the oEmbed providers tables by removing the unrecognized first and last rows in the hook docs for the `oembed_providers` filter. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@33720


git-svn-id: http://core.svn.wordpress.org/trunk@33687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 04:38:25 +00:00
Gary Pendergast f2a248e16d oEmbed: Remove blip.tv as an oEmbed provider, the service has been shut down. 
Vale, blip.tv.

Fixes #33522.

Props rabmalin.


Built from https://develop.svn.wordpress.org/trunk@33719


git-svn-id: http://core.svn.wordpress.org/trunk@33686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 04:12:25 +00:00
Gary Pendergast eb99787e32 WPDB: `get_table_from_query()` didn't find table names with hyphens in them. 
Props dustinbolton for the fix.

Fixes #33470.


Built from https://develop.svn.wordpress.org/trunk@33718


git-svn-id: http://core.svn.wordpress.org/trunk@33685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-24 00:19:25 +00:00
Drew Jaynes 45578c525e Docs: Add a description and example to the hook docs for the `navigation_markup_template` filter, introduced in [33714]. 
Since the value of the filter is passed through `sprintf()` it's important to note that any filtered output needs to contain the expected specifiers.

See #31315.

Built from https://develop.svn.wordpress.org/trunk@33717


git-svn-id: http://core.svn.wordpress.org/trunk@33684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 18:08:25 +00:00
Drew Jaynes 5e32a0c646 Docs: Better clarify that the `$post_type` parameter for the `get_usernumposts` filter and `count_user_posts()` can accept either a single post type or array of post types. 
Props tyxla
See #33481. Fixes #33520.

Built from https://develop.svn.wordpress.org/trunk@33716


git-svn-id: http://core.svn.wordpress.org/trunk@33683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 17:46:24 +00:00
Drew Jaynes ea4f27f519 Docs: Add better documentation for all accepted values for the `fields` argument in `get_terms()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@33715


git-svn-id: http://core.svn.wordpress.org/trunk@33682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 17:40:24 +00:00
Scott Taylor 27b551ee50 Add a filter to `_navigation_markup`: 'navigation_markup_template' 
Props joedolson, mordauk.
Fixes #31315.

Built from https://develop.svn.wordpress.org/trunk@33714


git-svn-id: http://core.svn.wordpress.org/trunk@33681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 16:34:26 +00:00
Scott Taylor b1c00f2653 Posts List Table: 
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.

Built from https://develop.svn.wordpress.org/trunk@33713


git-svn-id: http://core.svn.wordpress.org/trunk@33680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 16:28:28 +00:00
Drew Jaynes dffa53dca8 Docs: Fix a minor alignment issue in the DocBlock for `get_pagenum_link()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@33712


git-svn-id: http://core.svn.wordpress.org/trunk@33679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-23 07:19:27 +00:00
Boone Gorges dc0e7671b0 In `wp_delete_term()`, the `$deleted_term` object passed to filters should be generated before term relationships are deleted. 
This allows the `count` property to reflect the pre-delete state of affairs,
rather than always being 0.

Props nicholas_io.
Fixes #33485.
Built from https://develop.svn.wordpress.org/trunk@33711


git-svn-id: http://core.svn.wordpress.org/trunk@33678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 19:43:26 +00:00
Boone Gorges 6ab7493b27 Pass the `$public_only` value to 'get_usernumposts' filter. 
[32523] introduced the `$public_only` parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter.

Props swisspidy, tmatsuur.
Fixes #33481 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33710


git-svn-id: http://core.svn.wordpress.org/trunk@33677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 18:59:26 +00:00
Scott Taylor 20cc53b929 Add some JS Docs for Customizer. 
Props ericlewis.
See #33503.

Built from https://develop.svn.wordpress.org/trunk@33709


git-svn-id: http://core.svn.wordpress.org/trunk@33676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 17:24:25 +00:00
Scott Taylor c192d90fa1 In `wp_insert_user()`, add a filter: `insert_user_meta`, to filter a user's meta values and keys before the user is created or updated. 
Props tharsheblows, chriscct7, DrewAPicture.
Fixes #31549.

Built from https://develop.svn.wordpress.org/trunk@33708


git-svn-id: http://core.svn.wordpress.org/trunk@33675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 17:12:25 +00:00
Scott Taylor 5510b519f5 In `wp_sanitize_redirect()`, don't eat `@` characters. According to RFC 3986, "@" is a perfectly valid character in a URL path or query string. 
Adds unit test.

Props markjaquith.
Fixes #18818.

Built from https://develop.svn.wordpress.org/trunk@33707


git-svn-id: http://core.svn.wordpress.org/trunk@33674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 17:05:24 +00:00
Scott Taylor 523b51a359 Query: 
Add a query var, `title`, that allows you to query posts by `post_title`. To accomplish this now, you have to do something like:

{{{
$tacos = get_posts( [
  'post_type' => 'taco',
  's' => $name,
  'exact' => true,
  'sentence' => true,
  'post_status' => 'publish',
  'fields' => 'ids',
  'posts_per_page' => 1
] );
}}}

Adds unit tests.

Fixes #33074.

Built from https://develop.svn.wordpress.org/trunk@33706


git-svn-id: http://core.svn.wordpress.org/trunk@33673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 16:59:26 +00:00
Scott Taylor 42b6ac80e7 Ensure that `attachment_url_to_postid()` matches cross-scheme when front-end and back-end schemes are different. 
Adds unit test.

Props welcher.
Fixes #33109.

Built from https://develop.svn.wordpress.org/trunk@33705


git-svn-id: http://core.svn.wordpress.org/trunk@33672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 16:39:25 +00:00
Scott Taylor f2a9cd365b `update-core.php` help docs, update string to include translations: `themes, plugins, and translations` 
Props netweb, DrewAPicture.
Fixes #28201.

Built from https://develop.svn.wordpress.org/trunk@33704


git-svn-id: http://core.svn.wordpress.org/trunk@33671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 16:25:28 +00:00
Dominik Schilling f0a89de3d4 Tests: Fix a typo in function names for `$autoload` tests. 
Autoload is "no" if the `$autoload` param for `update_option()` is `'no'` or `false`.

see #26394.
Built from https://develop.svn.wordpress.org/trunk@33703


git-svn-id: http://core.svn.wordpress.org/trunk@33670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-22 09:45:27 +00:00
Dominik Schilling 888af781b2 Tests: Skip some tests for the Transients API when an external object cache is in use. 
`test_transient_data_with_timeout()`, `test_transient_add_timeout()`, `test_nonexistent_key_dont_delete_if_false()`, and `test_nonexistent_key_old_timeout` are testing option values which aren't available with an an external object cache like memcache.

see #31491.
Built from https://develop.svn.wordpress.org/trunk@33702


git-svn-id: http://core.svn.wordpress.org/trunk@33669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 20:33:26 +00:00
Scott Taylor 029c274b86 In `wpdb::get_col_length()`, `break`s are not necessary when a `case` returns 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33701


git-svn-id: http://core.svn.wordpress.org/trunk@33668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:41:25 +00:00
Scott Taylor 3982598305 Doc block for`_wp_specialchars`: `$quote_style` can also be `string` ('single' or 'double') 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33700


git-svn-id: http://core.svn.wordpress.org/trunk@33667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:36:24 +00:00
Scott Taylor 2a44bc6a59 In `_WP_Editors::editor_settings()`, `$first_run` is unused. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33699


git-svn-id: http://core.svn.wordpress.org/trunk@33666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:30:24 +00:00
Aaron Jorbin ece59bf72a Add new constant MONTH_IN_SECONDS and expand time convenience documentation. 
The "month" isn't really a month.  It's a WordPress Month. As the docs make clear, it's not about accuracy as much as it about convenience.  This adds a missing step in the time convenience constants. 

Props egill
Fixes #33397



Built from https://develop.svn.wordpress.org/trunk@33698


git-svn-id: http://core.svn.wordpress.org/trunk@33665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:16:25 +00:00
Scott Taylor 0fa7f817c4 In `wp_ajax_add_meta()`, do not juggle the value of `$_POST` and alter it directly. This was done so that `edit_post()` could pull `$_POST` out of the air by-reference and alter it (equally as bad). `edit_post()` accepts a `$post_data` array. Do that instead. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33697


git-svn-id: http://core.svn.wordpress.org/trunk@33664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:13:24 +00:00
Weston Ruter cb2879b9d4 Widgets: Switch back to using `array_key_exists()` instead of `isset()` for widget instance existence check. 
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

See #32474.
Fixes #33442.

Built from https://develop.svn.wordpress.org/trunk@33696


git-svn-id: http://core.svn.wordpress.org/trunk@33663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 18:09:25 +00:00
Scott Taylor db32f96d8a Make 'Docs Committer' translatable. 
Props dimadin. 
Fixes #33424.

Built from https://develop.svn.wordpress.org/trunk@33695


git-svn-id: http://core.svn.wordpress.org/trunk@33662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:47:25 +00:00
Scott Taylor 3d780c6a4b Clarify doc entry for `_wp_customize_include()` 
Props ericlewis. 
Fixes #33488.

Built from https://develop.svn.wordpress.org/trunk@33694


git-svn-id: http://core.svn.wordpress.org/trunk@33661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:45:25 +00:00
Scott Taylor e9305edbce When createing "Sample Page" on install, comments should be `closed`. 
Props macmanx. 
Fixes #33490.

Built from https://develop.svn.wordpress.org/trunk@33693


git-svn-id: http://core.svn.wordpress.org/trunk@33660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:42:25 +00:00
Scott Taylor fa2d0a2d55 Comment List Tables: 
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33692


git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:26:26 +00:00
Drew Jaynes 54b2e39fdd Docs: Add a changelog entry for the `$post_type` parameter added to the `restrict_manage_posts` hook in [33644]. 
Props pavelevap
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33691


git-svn-id: http://core.svn.wordpress.org/trunk@33658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 16:12:25 +00:00
Drew Jaynes 0e4285c451 Docs: Fix a typo in the DocBlock description for `_get_additional_user_keys()`, introduced in [33687]. 
Props dimadin
See #29120.

Built from https://develop.svn.wordpress.org/trunk@33690


git-svn-id: http://core.svn.wordpress.org/trunk@33657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 16:01:28 +00:00
Helen Hou-Sandí 514caf0120 List tables: Allow filtering of hidden and default hidden columns. 
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.

Built from https://develop.svn.wordpress.org/trunk@33689


git-svn-id: http://core.svn.wordpress.org/trunk@33656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 15:32:29 +00:00
Dion Hulse 09da29102b WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk

Built from https://develop.svn.wordpress.org/trunk@33688


git-svn-id: http://core.svn.wordpress.org/trunk@33655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 11:43:25 +00:00
Drew Jaynes 6d405d34da Docs: Clarify the DocBlock summary and add a description and return description for `_get_additional_user_keys()`. 
As noted in the description, returned keys being set is dependent on the existence of those keys in user meta at the point where `_get_additional_user_keys()` is called in `wp_update_user()`.

Fixes #29120.

Built from https://develop.svn.wordpress.org/trunk@33687


git-svn-id: http://core.svn.wordpress.org/trunk@33654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 05:33:25 +00:00
Drew Jaynes 93009543bc Docs: Fix some minor inline documentation syntax issues in the hook docs for the `post_edit_category_parent_dropdown_args` filter, introduced in [33682]. 
See #32246. See #33026.

Built from https://develop.svn.wordpress.org/trunk@33686


git-svn-id: http://core.svn.wordpress.org/trunk@33653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:54:26 +00:00
Drew Jaynes 416df545ba Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 
Fixes #29086.

Built from https://develop.svn.wordpress.org/trunk@33685


git-svn-id: http://core.svn.wordpress.org/trunk@33652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:13:24 +00:00
Drew Jaynes 3bb87e08e4 Docs: Add missing `@access` tags to properties and methods in wp-admin/includes/class-wp-upgrader. 
See #29086.

Built from https://develop.svn.wordpress.org/trunk@33684


git-svn-id: http://core.svn.wordpress.org/trunk@33651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 04:05:25 +00:00
Drew Jaynes 73d6dec8eb Docs: Correct a typo in the summary for the `Theme_Upgrader->bulk` property. 
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.

Built from https://develop.svn.wordpress.org/trunk@33683


git-svn-id: http://core.svn.wordpress.org/trunk@33650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 03:15:25 +00:00
Boone Gorges 52614b491a Filter the arguments passed to `wp_dropdown_categories()` in the Categories post edit metabox. 
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.
Built from https://develop.svn.wordpress.org/trunk@33682


git-svn-id: http://core.svn.wordpress.org/trunk@33649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 01:28:25 +00:00
Boone Gorges 8b15f8be3d In `Walker_CategoryDropdown::start_el()`, cast values to strings before deciding whether to append 'selected' attribute. 
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the `'selected'`
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.

Fixes #33452 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33681


git-svn-id: http://core.svn.wordpress.org/trunk@33648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 01:11:26 +00:00
Drew Jaynes b407bb0936 Docs: Standardize `@deprecated` tag formatting in the DocBlock for the `logIO()` function. 
Props Alphawolf.
Fixes #28806.

Built from https://develop.svn.wordpress.org/trunk@33680


git-svn-id: http://core.svn.wordpress.org/trunk@33647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:44:25 +00:00
Drew Jaynes 4770601d73 Docs: Standardize `@deprecated` tag formatting in the DocBlocks for several `wpdb` methods. 
Props Alphawolf.
See #28806.

Built from https://develop.svn.wordpress.org/trunk@33679


git-svn-id: http://core.svn.wordpress.org/trunk@33646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:42:25 +00:00
Drew Jaynes bf371f1577 Docs: Standardize `@deprecated` tag formatting in the DocBlock for `WP_Object_Cache:reset()`. 
Props Alphawolf.
See #28806.

Built from https://develop.svn.wordpress.org/trunk@33678


git-svn-id: http://core.svn.wordpress.org/trunk@33645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:39:24 +00:00
Drew Jaynes 02ec47fc92 Docs: Standardize `@deprecated` tag formatting in the DocBlock for `wp_xmlrpc_server::login_pass_ok()`. 
Props Alphawolf.
See #28806.

Built from https://develop.svn.wordpress.org/trunk@33677


git-svn-id: http://core.svn.wordpress.org/trunk@33644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:38:25 +00:00
Drew Jaynes eaab0e72a6 Docs: Standardize `@deprecated` tag formatting and add missing summaries to deprecated functions in wp-includes/ms-deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33676


git-svn-id: http://core.svn.wordpress.org/trunk@33643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:36:25 +00:00
Drew Jaynes c8638a285a Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33675


git-svn-id: http://core.svn.wordpress.org/trunk@33642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:26:24 +00:00
Drew Jaynes b2dcf3d1f4 Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-includes/pluggable-deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture.

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33674


git-svn-id: http://core.svn.wordpress.org/trunk@33641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:15:25 +00:00
Drew Jaynes e9f1e69b23 Docs: Standardize `@deprecated` tag formatting and add missing DocBlock summaries to deprecated functions in wp-includes/deprecated.php. 
Props Alphawolf for the initial patch.
Props DrewAPicture.

See #28806.

Built from https://develop.svn.wordpress.org/trunk@33673


git-svn-id: http://core.svn.wordpress.org/trunk@33640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 22:11:26 +00:00
Scott Taylor 6f9aa6df03 After [33666], fix broken `sprintf` cruff. 
See #17609.

Built from https://develop.svn.wordpress.org/trunk@33672


git-svn-id: http://core.svn.wordpress.org/trunk@33639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:37:24 +00:00
Drew Jaynes bac6e69b3c Docs: Standardize `@deprecated` tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806

Built from https://develop.svn.wordpress.org/trunk@33671


git-svn-id: http://core.svn.wordpress.org/trunk@33638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:23:25 +00:00
Drew Jaynes c36c4efea6 Docs: Add a missing summary to the DocBlock for `wp_media_upload_handler()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@33670


git-svn-id: http://core.svn.wordpress.org/trunk@33637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 21:01:25 +00:00
Scott Taylor 677d47ebc5 In `wp_get_attachment_link()`, accept an `id` or `WP_Post` as the first parameter. 
Props several27, DrewAPicture.
Fixes #33277.

Built from https://develop.svn.wordpress.org/trunk@33669


git-svn-id: http://core.svn.wordpress.org/trunk@33636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:32:26 +00:00
Drew Jaynes 89c39e7eab Docs: Clarify the different return conditions in the DocBlock for `WP_List_Table->handle_row_actions()`. 
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.

Built from https://develop.svn.wordpress.org/trunk@33668


git-svn-id: http://core.svn.wordpress.org/trunk@33635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:22:25 +00:00
Scott Taylor 4254f22c2d In `WP_Posts_List_Table::inline_edit()`, check that `$post_formats[0]` is an array before traversing. 
Props DrewAPicture.
Fixes #33025.


Built from https://develop.svn.wordpress.org/trunk@33667


git-svn-id: http://core.svn.wordpress.org/trunk@33634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 20:19:25 +00:00
Scott Taylor 4694c477d3 Custom Post Types: 
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.

Built from https://develop.svn.wordpress.org/trunk@33666


git-svn-id: http://core.svn.wordpress.org/trunk@33633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 19:40:25 +00:00
Drew Jaynes a7b38bf90a Docs: Correct the phpDoc type to a boolean for the `$single` parameter in the `get_{$meta_type}_metadata` hook docs. 
Props dlh.
Fixes #33451.

Built from https://develop.svn.wordpress.org/trunk@33665


git-svn-id: http://core.svn.wordpress.org/trunk@33632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 19:36:25 +00:00
Drew Jaynes bec5bcf717 Docs: Mark the `$notify` parameter in the DocBlock for `wp_new_user_notification()` as optional, and provide additional context on the difference between the accepted values. 
See [33620] and [33023] for background.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@33664


git-svn-id: http://core.svn.wordpress.org/trunk@33631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 18:26:26 +00:00
Scott Taylor d65112d382 After [33662], remove unused var. 
See #11200.

Built from https://develop.svn.wordpress.org/trunk@33663


git-svn-id: http://core.svn.wordpress.org/trunk@33630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 17:19:25 +00:00
Scott Taylor 20f6db2b18 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.


Built from https://develop.svn.wordpress.org/trunk@33662


git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 16:36:25 +00:00
Dominik Schilling 6d45b63562 WordPress 4.3 has just passed 2,222,222 downloads. 
(Fix typo in [33653].)
Built from https://develop.svn.wordpress.org/trunk@33661


git-svn-id: http://core.svn.wordpress.org/trunk@33628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 16:00:28 +00:00
Scott Taylor 0e4606c13e JSHint after [33655]. 
Built from https://develop.svn.wordpress.org/trunk@33660


git-svn-id: http://core.svn.wordpress.org/trunk@33627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 06:31:25 +00:00
Scott Taylor 45fc6a3def Deprecate `post_permalink()` (Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps `get_permalink()` and was only used by XML-RPC in 4 places. 
Props solarissmoke.
Fixes #16982.

Built from https://develop.svn.wordpress.org/trunk@33659


git-svn-id: http://core.svn.wordpress.org/trunk@33626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 06:24:26 +00:00
Scott Taylor 1fd0dcbc9e Ensure that feeds are served with the proper `Content-Type` HTTP header. 
Props stevenkword.
Fixes #32024.

Built from https://develop.svn.wordpress.org/trunk@33658


git-svn-id: http://core.svn.wordpress.org/trunk@33625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 06:10:24 +00:00
Scott Taylor 2e2223ae74 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.

Built from https://develop.svn.wordpress.org/trunk@33657


git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 05:54:25 +00:00
Scott Taylor 657d0f6918 Comments List Table: 
* Properly increment/decrement approved/pending bubbles in `response` column

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33656


git-svn-id: http://core.svn.wordpress.org/trunk@33623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 04:02:24 +00:00
Scott Taylor df618f3461 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33655


git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:51:25 +00:00
Scott Taylor 572a0a587a Comments shouldn't have more than one `_wp_trash_meta_status` entry. When deleting `_wp_trash_meta_status`, also delete `_wp_trash_meta_time`. 
See #11200.

Built from https://develop.svn.wordpress.org/trunk@33654


git-svn-id: http://core.svn.wordpress.org/trunk@33621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:45:26 +00:00
Boone Gorges 7c0d3ab83a Introduce `post_name__in` parameter for `WP_Query`. 
Props enshrined.
Fixes #33065.
Built from https://develop.svn.wordpress.org/trunk@33653


git-svn-id: http://core.svn.wordpress.org/trunk@33620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:19:25 +00:00
Boone Gorges bc592af91f `wp_update_term()` should return a true integer for 'term_taxonomy_id'. 
Props ipm-frommen.
Fixes #32876.
Built from https://develop.svn.wordpress.org/trunk@33652


git-svn-id: http://core.svn.wordpress.org/trunk@33619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 19:33:24 +00:00
Konstantin Obenland f770303868 Themes: Prevent short descriptions from wrapping version info. 
Props mehulkaklotar for initial patch.
Fixes #33248.


Built from https://develop.svn.wordpress.org/trunk@33651


git-svn-id: http://core.svn.wordpress.org/trunk@33618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 19:10:24 +00:00
Konstantin Obenland 2849e2c5e9 Themes: Open preview when requesting a single theme in the installer. 
Props kraftner, obenland.
Fixes #28735.


Built from https://develop.svn.wordpress.org/trunk@33650


git-svn-id: http://core.svn.wordpress.org/trunk@33617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 18:54:27 +00:00
Dion Hulse a32d83586e Upgrades: When upgrading via FTP, use `LIST -a` to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.

Built from https://develop.svn.wordpress.org/trunk@33648


git-svn-id: http://core.svn.wordpress.org/trunk@33615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 12:38:25 +00:00
Dion Hulse 25c5d372d3 Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33646


git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 11:31:26 +00:00
Dion Hulse 096b2f58fa Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.

Built from https://develop.svn.wordpress.org/trunk@33645


git-svn-id: http://core.svn.wordpress.org/trunk@33612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 10:35:25 +00:00
Scott Taylor 3923017f82 The `'restrict_manage_posts'` hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass `$post_type`. 
Props sunnyratilal, scribu.
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33644


git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 06:23:25 +00:00
Scott Taylor b19bb99853 Playlists, for `.wp-playlist-item-title` elements: move the curly quotes to CSS pseudo-element `content`, making them easier to override or remove. 
Fixes #33391.

Built from https://develop.svn.wordpress.org/trunk@33643


git-svn-id: http://core.svn.wordpress.org/trunk@33610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 05:51:25 +00:00
Scott Taylor 07c079cc86 `WP_Embed::maybe_run_ajax_cache()` doesn't hook to pages, because it only happens on `'edit_form_advanced'`, not `'edit_page_form'`. Make sure it runs for pages as well. This was probably not intentional, see [29557]. 
Fixes #32418.

Built from https://develop.svn.wordpress.org/trunk@33642


git-svn-id: http://core.svn.wordpress.org/trunk@33609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 05:40:24 +00:00
Scott Taylor c15a1c2bab Replace some hyphens with `&mdash;`s in admin help tabs. 
Props pixolin.
Fixes #30605.

Built from https://develop.svn.wordpress.org/trunk@33641


git-svn-id: http://core.svn.wordpress.org/trunk@33608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 04:53:25 +00:00
Scott Taylor 8af2dbc671 Correct punctuation/case for inline comment in `async-upload.php` 
Props chriscct7.
Fixes #33408.

Built from https://develop.svn.wordpress.org/trunk@33640


git-svn-id: http://core.svn.wordpress.org/trunk@33607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 23:35:25 +00:00
Scott Taylor 23f62a59da Correct typo in doc block for `WP_Filesystem_ftpsockets::rmdir` 
Props Toro_Unit.
Fixes #33255.

Built from https://develop.svn.wordpress.org/trunk@33639


git-svn-id: http://core.svn.wordpress.org/trunk@33606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 23:33:24 +00:00
Scott Taylor 227d38c9cd Correct typo in JSDoc for `wp.updates.decrementCount` 
Props mt8.biz.
Fixes #33363.

Built from https://develop.svn.wordpress.org/trunk@33638


git-svn-id: http://core.svn.wordpress.org/trunk@33605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 21:47:25 +00:00
Scott Taylor 0b29061b3d Fix case type in docs for `get_children()`. 
Props bobbingwide.
Fixes #33364.

Built from https://develop.svn.wordpress.org/trunk@33637


git-svn-id: http://core.svn.wordpress.org/trunk@33604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 21:39:24 +00:00
Helen Hou-Sandí 0c89678c9b Trunk is now 4.4-alpha. 
Built from https://develop.svn.wordpress.org/trunk@33636


git-svn-id: http://core.svn.wordpress.org/trunk@33603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 19:32:26 +00:00
Konstantin Obenland 2e73c24e30 WordPress 4.3 
Built from https://develop.svn.wordpress.org/trunk@33633


git-svn-id: http://core.svn.wordpress.org/trunk@33600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 18:02:25 +00:00
Konstantin Obenland e36a91efe4 About: Use actual locale and not subtitle debug cruft. 
H/t dimadin.

See #32929.

Built from https://develop.svn.wordpress.org/trunk@33632


git-svn-id: http://core.svn.wordpress.org/trunk@33599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 17:07:26 +00:00
Konstantin Obenland d55738d327 About: Update release video to use the correct ID. 
Also adjusts locale handling to work with Videopress' subtitle implementation.

Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.


Built from https://develop.svn.wordpress.org/trunk@33631


git-svn-id: http://core.svn.wordpress.org/trunk@33598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 17:02:27 +00:00
Boone Gorges 2f514a6115 When generating a fallback `post_name` using the post ID, `wp_insert_post()` should clear the post cache immediately. 
If the post cache is not cleared at this point, the cache can become stale
for operations performed before the cache is cleared later in the function.
Specifically, the generation of a `guid` for new posts can use stale data,
resulting in non-unique values. [33262] introduced a call to `get_post()`
that introduced just such an invalidation problem.

Fixes #5305.
Built from https://develop.svn.wordpress.org/trunk@33630


git-svn-id: http://core.svn.wordpress.org/trunk@33597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-18 02:51:26 +00:00
Konstantin Obenland 6b9b32c431 4.3-RC3-33629 
Built from https://develop.svn.wordpress.org/trunk@33629


git-svn-id: http://core.svn.wordpress.org/trunk@33596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:46:25 +00:00
Konstantin Obenland cd937b6771 4.3-RC3 
Built from https://develop.svn.wordpress.org/trunk@33628


git-svn-id: http://core.svn.wordpress.org/trunk@33595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:40:25 +00:00
Dominik Schilling 96a6f0ac1f Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@33627


git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:39:25 +00:00
Dominik Schilling ce557062f4 Upgrade: Update `$_old_files` for 4.3. 
fixes #33394.
Built from https://develop.svn.wordpress.org/trunk@33626


git-svn-id: http://core.svn.wordpress.org/trunk@33593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 20:24:26 +00:00
Konstantin Obenland 69146f6b10 Passwords: Use `keyup` event to prevent IE8's misinterpretation of `propertychange`. 
Props adamsilverstein, peterwilsoncc.
Fixes #33385.


Built from https://develop.svn.wordpress.org/trunk@33625


git-svn-id: http://core.svn.wordpress.org/trunk@33592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 18:46:25 +00:00
Andrew Ozz 2de7757124 Fix creating of extra `<br />` tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future. 
Props valendesigns, azaozz. Fixes #33377.
Built from https://develop.svn.wordpress.org/trunk@33624


git-svn-id: http://core.svn.wordpress.org/trunk@33591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 17:36:24 +00:00
Helen Hou-Sandí 50e42e8a07 List tables: Yet more primary column fallbacks. 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Built from https://develop.svn.wordpress.org/trunk@33623


git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 15:38:25 +00:00
Konstantin Obenland dfcf1d0035 Editor: Exclude `shift` from modifier keys when handling spacebar shortcuts. 
Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.


Built from https://develop.svn.wordpress.org/trunk@33622


git-svn-id: http://core.svn.wordpress.org/trunk@33589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:51:24 +00:00
Boone Gorges dba7c50d29 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33621


git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:29:25 +00:00
Konstantin Obenland e6bc6242ad Passwords: Restore second parameter for `wp_new_user_notification()`. 
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.


Built from https://develop.svn.wordpress.org/trunk@33620


git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:25:27 +00:00
Boone Gorges 52a7082d11 Don't suspend cache invalidation when running term splitting batch routine. 
`wp_suspend_cache_invalidation()` was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@33619


git-svn-id: http://core.svn.wordpress.org/trunk@33586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-15 19:25:26 +00:00
Helen Hou-Sandí 1880411a0b Menu customizer: Ensure the search results section is full height. 
fixes #33375.

Built from https://develop.svn.wordpress.org/trunk@33618


git-svn-id: http://core.svn.wordpress.org/trunk@33585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 21:32:25 +00:00
Weston Ruter 9ee7f050e9 Customize: Fix keyboard accessibility for toggling screen options and contextual help. 
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.

Built from https://develop.svn.wordpress.org/trunk@33617


git-svn-id: http://core.svn.wordpress.org/trunk@33584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 21:23:27 +00:00
Boone Gorges 69a03fd1a3 Remove unit test related to pre-4.1 term splitting during `wp_update_term()`. 
After [33615], `wp_update_term()` no longer checks `$wp_db_version` before
attempting a split. This is because pre-4.1 versions of WordPress must be
allowed to update to 4.3+.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@33616


git-svn-id: http://core.svn.wordpress.org/trunk@33583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 04:16:26 +00:00
Boone Gorges 151d27369d Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33615


git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 03:59:26 +00:00
Dominik Schilling f74a907eac Capabilities: Fall back to the `edit_posts` capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.
Built from https://develop.svn.wordpress.org/trunk@33614


git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 22:31:24 +00:00
Konstantin Obenland 35f8b77882 About: Third pass at 4.3 about page: 
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.


Built from https://develop.svn.wordpress.org/trunk@33613


git-svn-id: http://core.svn.wordpress.org/trunk@33580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 22:11:35 +00:00
Scott Taylor 4a1f50f732 After [33325], supply a missing `post_type` in `->mw_editPost()`. 
Add unit test.

Props ocean90.
Fixes #20662.

Built from https://develop.svn.wordpress.org/trunk@33612


git-svn-id: http://core.svn.wordpress.org/trunk@33579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 15:28:27 +00:00
Boone Gorges 2c9e81349c When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained. 
Props boonebgorges, dd32.
Fixes #33187.
Built from https://develop.svn.wordpress.org/trunk@33611


git-svn-id: http://core.svn.wordpress.org/trunk@33578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-12 14:07:26 +00:00
Weston Ruter 7fcc3e50e1 Customize: Fix layout issues in panels and sections when resizing and autofocusing. 
Also reverts [33157] which is no longer needed.

Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220.

Built from https://develop.svn.wordpress.org/trunk@33610


git-svn-id: http://core.svn.wordpress.org/trunk@33577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 23:56:25 +00:00
Andrew Ozz 3bfd096440 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.
Built from https://develop.svn.wordpress.org/trunk@33609


git-svn-id: http://core.svn.wordpress.org/trunk@33576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 23:44:24 +00:00
Konstantin Obenland 08743e43eb After [32948]: Account for the use of `paginate_links()` with table navigation markup. 
Props afercia.
Fixes #32253.


Built from https://develop.svn.wordpress.org/trunk@33608


git-svn-id: http://core.svn.wordpress.org/trunk@33575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 20:43:24 +00:00
Konstantin Obenland be9d89d3e3 Tests: Update Site Icon tests to account for changes in [33605]. 
H/t jorbin.

Fixes #33325.


Built from https://develop.svn.wordpress.org/trunk@33607


git-svn-id: http://core.svn.wordpress.org/trunk@33574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 18:41:24 +00:00
Konstantin Obenland dfa53a1da7 Site Icon: Improvements to Site Icon API. 
* Only call `get_blog_option()` when there is a blog id and we're in Mulitsite. If there is no blog id the request is for the current blog.
* Check return value of `wp_get_attachment_image_src()` before getting the URL since it could be `false`.
* Use `{bool}` rather than `!!` to return a boolean value.

Props MikeHansenMe, obenland.
Fixes #33326.


Built from https://develop.svn.wordpress.org/trunk@33606


git-svn-id: http://core.svn.wordpress.org/trunk@33573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 16:25:27 +00:00
Helen Hou-Sandí 731c255aee Site icon: Rearrange function parameters to avoid frequently passing empty values. 
props obenland.
fixes #33325.

Built from https://develop.svn.wordpress.org/trunk@33605


git-svn-id: http://core.svn.wordpress.org/trunk@33572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 20:15:26 +00:00
Konstantin Obenland 48712a0309 Customize: Limit styles for menu's reorder button to the `nav_menu` control. 
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.

Fixes #33260.


Built from https://develop.svn.wordpress.org/trunk@33604


git-svn-id: http://core.svn.wordpress.org/trunk@33571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 19:36:27 +00:00
Helen Hou-Sandí d03082323e Network admin: Internationalize some existing strings that were missed in [33186]. 
Also adds the trailing slash to the `get_home_url()` calls.

props johnbillion.
fixes #33317.

Built from https://develop.svn.wordpress.org/trunk@33603


git-svn-id: http://core.svn.wordpress.org/trunk@33570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 18:11:25 +00:00
Helen Hou-Sandí 7e2cec4edb Customizer: Rename `WP_New_Menu_Customize_Control` to `WP_Customize_New_Menu_Control` for consistency. 
props DrewAPicture.
fixes #33324.

Built from https://develop.svn.wordpress.org/trunk@33602


git-svn-id: http://core.svn.wordpress.org/trunk@33569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 18:06:25 +00:00
Dion Hulse aace7c2c8d Function documentation: Fix a broken docbock introduced with [32642]. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@33601


git-svn-id: http://core.svn.wordpress.org/trunk@33568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-10 10:50:26 +00:00
Dominik Schilling e9e88d0b4b Shortcodes: Trim whitespace after sanitizing the shortcode output. 
props Ankit K Gupta, obenland, miqrogroove.
fixes #33259.
Built from https://develop.svn.wordpress.org/trunk@33600


git-svn-id: http://core.svn.wordpress.org/trunk@33567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-09 20:49:25 +00:00
Dominik Schilling 45b8634605 Customizer: Remove obsolete `.control-panel-back` and `.customize-overlay-close` buttons. 
props afercia, ocean90.
see #31336.
fixes #33229.
Built from https://develop.svn.wordpress.org/trunk@33599


git-svn-id: http://core.svn.wordpress.org/trunk@33566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-09 19:00:24 +00:00
Dominik Schilling bd342572f1 List tables: Adjust width of Quick Edit labels for longer translations. 
props Clorith, SergeyBiryukov, ocean90.
fixes #33212.
Built from https://develop.svn.wordpress.org/trunk@33598


git-svn-id: http://core.svn.wordpress.org/trunk@33565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-09 18:55:25 +00:00
Dion Hulse e2b10dad49 Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206

Built from https://develop.svn.wordpress.org/trunk@33597


git-svn-id: http://core.svn.wordpress.org/trunk@33564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-09 02:22:26 +00:00
Dominik Schilling 04c21a0e3c Customizer: Restore Shift + Clicking on widgets to open the widgets panel. 
Includes an alternative for jQuery UI's `:focusable` selector because it has an ancestor visibility requirement, see https://github.com/jquery/jquery-ui/pull/1583.

props westonruter.
fixes #33258.
Built from https://develop.svn.wordpress.org/trunk@33596


git-svn-id: http://core.svn.wordpress.org/trunk@33563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-08 09:37:26 +00:00
Konstantin Obenland f673128a13 Install: Adjust `th` padding to align with `td`s. 
Props Ankit K Gupta for initial patch.
Fixes #33280.


Built from https://develop.svn.wordpress.org/trunk@33595


git-svn-id: http://core.svn.wordpress.org/trunk@33562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-07 22:10:26 +00:00
Dion Hulse f8136f2ab2 Fix `do_shortcode('<[shortcode]')` edge case. 
Props miqrogroove.
Merges [33499] trunk.
See #33116.

Built from https://develop.svn.wordpress.org/trunk@33594


git-svn-id: http://core.svn.wordpress.org/trunk@33561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-07 02:50:25 +00:00
John Blackbourn 6bd6069fc0 Remove all existing internal feature pointers. 
Fixes #33289
Props obenland, ocean90, SergeyBiryukov

Built from https://develop.svn.wordpress.org/trunk@33593


git-svn-id: http://core.svn.wordpress.org/trunk@33560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-07 00:59:24 +00:00
Ella Iseulde Van Dorpe 718271dd53 TinyMCE: fix inline toolbar repositioning for inline editors 
Fixes #33286.

Built from https://develop.svn.wordpress.org/trunk@33592


git-svn-id: http://core.svn.wordpress.org/trunk@33559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-06 21:35:25 +00:00
Mark Jaquith d60e2eea84 Only use a bare URL when the link text field is used. 
Fixes bug that would remove images on edit, in some circumstances.

fixes #33293
props azaozz
Built from https://develop.svn.wordpress.org/trunk@33591


git-svn-id: http://core.svn.wordpress.org/trunk@33558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-06 20:58:25 +00:00
Mark Jaquith 309516a6c1 Move media hooks out of `admin-filters.php` as sometimes editors are used on the front end. 
fixes #33257
props wonderboymusic
Built from https://develop.svn.wordpress.org/trunk@33590


git-svn-id: http://core.svn.wordpress.org/trunk@33557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-06 20:40:26 +00:00
Dominik Schilling 4a31dd6fe8 Comments: Update help text for new comment bubbles. 
props kraftbj.
fixes #33256.
Built from https://develop.svn.wordpress.org/trunk@33589


git-svn-id: http://core.svn.wordpress.org/trunk@33556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-06 08:03:26 +00:00
Sergey Biryukov 1b282962a4 wpLink: Make sure the link wrapper is the last element in the body, otherwise the inline editor toolbar may show up above the backdrop. 
props azaozz.
fixes #33268.
Built from https://develop.svn.wordpress.org/trunk@33588


git-svn-id: http://core.svn.wordpress.org/trunk@33555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-06 02:17:25 +00:00
Jeremy Felt 1e5b0ff0fa Multisite: Use single URL input when editing sites in a subdirectory configuration 
In [32759], we adjusted `site-info.php` to display a single input for a site's full URL if the network was configured for subdomains. We also enforced path only editing for non-subdomain networks, which is a regression in expected behavior.

The full URL of a site can now be edited in both subdomain and subdirectory configurations.

Props @michaelryanmcneill.
Fixes #22383.

Built from https://develop.svn.wordpress.org/trunk@33586


git-svn-id: http://core.svn.wordpress.org/trunk@33553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-05 03:34:25 +00:00
Weston Ruter 2678bd9225 Customizer: Restore default `fallback_cb` arg for `wp_nav_menu()` calls in customizer preview. 
Props ocean90, westonruter.
Fixes #33218.

Built from https://develop.svn.wordpress.org/trunk@33585


git-svn-id: http://core.svn.wordpress.org/trunk@33552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-04 21:57:25 +00:00
Ella Iseulde Van Dorpe 34d50e6165 TinyMCE: wplink: fix WPLinkPreview for multiple editors 
Fixes #33264.

Built from https://develop.svn.wordpress.org/trunk@33584


git-svn-id: http://core.svn.wordpress.org/trunk@33551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-04 21:42:26 +00:00
Dominik Schilling 2fbdeae0a8 WordPress 4.3-RC2-33572. 
Built from https://develop.svn.wordpress.org/trunk@33572


git-svn-id: http://core.svn.wordpress.org/trunk@33539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-04 11:48:25 +00:00