Commit Graph

62 Commits

Author SHA1 Message Date
nacin 4664d4bed8 Don't output empty class names or ones with leading/trailing spaces. props MattyRob for the initial patch. fixes #20698.
git-svn-id: http://core.svn.wordpress.org/trunk@21193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 11:47:21 +00:00
azaozz 1d12cd07b0 Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014
git-svn-id: http://svn.automattic.com/wordpress/trunk@20417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 01:19:30 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin aa3cf9d286 Make sure that _render() is only called with a valid root object. As in, render() can only be validly called once and must not fail on the second call. props SergeyBiryukov, see #19642 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-30 23:04:28 +00:00
ryan d295e6e600 Introduce user-actions group and move profile and logout menu items to it and change priority. Props koopersmith. fixes #19425
git-svn-id: http://svn.automattic.com/wordpress/trunk@19559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 03:51:58 +00:00
ryan 06a1675a3c Admin bar API improvements. Props koopersmith. fixes #19416 #19371
git-svn-id: http://svn.automattic.com/wordpress/trunk@19558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 03:42:11 +00:00
ryan 0112c9d628 Don't drop dollars. see #19426
git-svn-id: http://svn.automattic.com/wordpress/trunk@19556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 00:46:03 +00:00
ryan a39bffbadb Add back compat support for my-account-with-avatar admin bar node id. fixes #19426
git-svn-id: http://svn.automattic.com/wordpress/trunk@19555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 00:31:11 +00:00
azaozz f6047c397e Remove role="menu" and role="menuitem" for now, fixes #19394
git-svn-id: http://svn.automattic.com/wordpress/trunk@19548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-05 17:47:23 +00:00
koopersmith 74e1b3ea68 Remove the shortlink item from the toolbar, but keep the function for plugins. fixes #19407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:25:54 +00:00
koopersmith 39ac39ef2c In toolbar, move search item to the right of the account menu and make it icon-only. fixes #19370, #19406.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:03:12 +00:00
nacin a109cf8c6b Finalize the WP_Admin_Bar architecture for 3.3.
* Introduce a get_node() method for plugins.
 * Deprecate $wp_admin_bar->menu. Plugins will need to use get_node(), remove_node(), add_node() to make modifications. This finalizes a backwards incompatible change made earlier in the cycle.
 * Allow add_node() to take a node object (which could come from get_node(), then be modified).
 * Ensure that our underlying storage (the nodes property) is private to core. Introduce _set_node, _unset_node, _get_nodes, get_nodes as the only ways to interface with this.
 * Protect and finalize _render_item, and _render_group. render() remains public and technically overridable, though I would discourage this of plugin authors.
 * Deprecate recursive_render(). Use render() or _render_item().

More about the internals:
 * Late-binds a node's 'children' array.
 * Eliminates the root property, leverages a 'root' node.
 * Splits render() into _bind() and _render(), both protected and finalized.

Fixes #19371.


git-svn-id: http://svn.automattic.com/wordpress/trunk@19501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:25:04 +00:00
koopersmith 7c6cd25f00 Print title attributes for linkless toolbar items. see #19277.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 23:59:10 +00:00
azaozz 7f81dbfe3f Add ARIA related attributes (first take), props DrewAPicture, see #19394
git-svn-id: http://svn.automattic.com/wordpress/trunk@19484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 01:27:33 +00:00
nacin 18e0faf83e Use an 'appearance' group in the admin bar. fixes #19245.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 23:01:20 +00:00
koopersmith eecf9dc3c1 Admin Bar: Secondary is so passé. Groups are the new black. fixes #19136.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 21:46:47 +00:00
azaozz 34d1e6c8f2 Admin bar: add class for IE9 and fix background color in search, props SergeyBiryukov, see #19151
git-svn-id: http://svn.automattic.com/wordpress/trunk@19407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-22 21:35:08 +00:00
ryan 28152dfd20 Don't show Add New and Comments admin bar menus in network or user admins. Add tooltip to comments menu. Props ocean90. fixes #19327
git-svn-id: http://svn.automattic.com/wordpress/trunk@19398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-22 16:19:05 +00:00
koopersmith 46dbae63e6 Slight rearrangements in admin bar render logic. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 23:07:54 +00:00
azaozz eb5dbde246 Admin bar IE7, iPad and rtl refresh, see #81197
git-svn-id: http://svn.automattic.com/wordpress/trunk@19368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 02:03:02 +00:00
nacin 249cee46a3 Handle 'appearance' as a admin bar menu parent in a backwards compatible way. fixes #19245.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-20 18:39:54 +00:00
koopersmith 924ed5885c Allow linkless items in the admin bar. Improve non-jQuery admin bar tabbing. fixes #19277, #19149, #19164, #15519. see #18197, #19088.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 00:12:57 +00:00
koopersmith 9057e02e72 More admin bar markup improvements. Make primary and secondary submenu groups siblings (and prevent ul nesting issues). see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 11:05:37 +00:00
koopersmith f099d03f84 Improve admin bar markup. Un-nest top level secondary menu. Remove unnecessary span. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-12 00:26:55 +00:00
koopersmith 5299994ce5 Add general top-level class to the secondary admin menu. Fixes hover styling and tabbing JS. fixes #19220.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 20:46:29 +00:00
nacin c3fb2795b0 Promote secondary admin bar items to primary if there are no primary items at time of render. see #19136, #19221.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 00:42:39 +00:00
koopersmith 4de1815c67 Add secondary flag to admin bar. fixes #19136.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-09 19:12:48 +00:00
azaozz b8f091fcbc Fix a:focus styling and backwards tabbing, add tabindex arg for <a>, see #19088
git-svn-id: http://svn.automattic.com/wordpress/trunk@19207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-07 20:38:38 +00:00
azaozz 94ef5dd13f Support for "tabbing" through the admin bar and admin menu, fixes #19088
git-svn-id: http://svn.automattic.com/wordpress/trunk@19162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-05 01:13:18 +00:00
ryan e4ae15aefe If an empty menu ID is passed, derive it from the title and issue a _doing_it_wrong() notice. see #18197
git-svn-id: http://svn.automattic.com/wordpress/trunk@19158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-04 17:41:38 +00:00
azaozz f73e6b3228 Revert placement of Help and Screen Options to under the admin bar on the right, see #18197, see #18785
git-svn-id: http://svn.automattic.com/wordpress/trunk@19130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 17:08:12 +00:00
koopersmith eac1a7b369 Improve admin bar internal representation. Simpler signatures, with backwards compatibility. Add items without requiring parents to be added first. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:34:54 +00:00
koopersmith 260d918501 Improve admin bar item order for W menu, add new menu, and edit content item. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-10 18:40:00 +00:00
koopersmith ddf8e3e31d Clean up the 'Site Name' admin bar functions.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 19:52:26 +00:00
koopersmith 4c3edc9b6b Adjust admin bar item order. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-06 00:02:18 +00:00
koopersmith dcf34868ed Revise admin bar items based on user testing. Post at http://wp.me/pbNCB-qz. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 18:45:32 +00:00
koopersmith 590868d915 Second pass, admin bar overhaul. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-25 23:30:40 +00:00
westi 34dbc01722 Remove the unimplemented user locale code in the admin bar until we actually implement it for real.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-16 11:12:37 +00:00
westi 96b942e891 We don't need to do this if the user isn't logged in.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-16 10:56:06 +00:00
koopersmith 834dc9ff5e Admin bar UX improvements. First pass, see #18197
git-svn-id: http://svn.automattic.com/wordpress/trunk@18683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-16 05:01:54 +00:00
nacin ba5c2141bb Some more class instantiations. props eko-fr, fixes #18049.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-18 06:16:57 +00:00
azaozz 670980920d Admin bar: use jQuery if loaded to improve UX, fixes #18299
git-svn-id: http://svn.automattic.com/wordpress/trunk@18488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 22:57:30 +00:00
nacin e627a9a57a 'Dashboard' should be to the right of 'My Sites' for visual hierarchy reasons. see #17705.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-12 02:47:02 +00:00
nacin 71c2782b1c Admin Bar: Add View Site/Dashboard links, 'View X' links in the admin, 'View' action link for terms. New custom taxonomy string: view_item, defaulting to 'View Tag' and View Category'. fixes #17705.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-08 16:49:27 +00:00
ryan f63ccddadb Pink the whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-09 17:35:36 +00:00
westi 2a75d9c511 Add unique ids as well as of classes in the admin bar to make it easier for plugins to extend.
Ensure we escape the classname.
Fixes #16211 props koopersmith.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 01:34:15 +00:00
westi 43fa1e5294 Admin Bar - show fullsite name in the tooltip. Correct some escaping. Fixes #16197 props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-12 16:02:56 +00:00
ryan 55d6d8af12 PHP4 compat. Props SergeyBiryukov, westi. see #16080
git-svn-id: http://svn.automattic.com/wordpress/trunk@17211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-03 19:19:34 +00:00
ryan d0a0c31b1f Clean up admin bar node removal. Make it PHP4 safe and prevent display of blank spots. Props sorich87, SergeyBiryukov. fixes #16005
git-svn-id: http://svn.automattic.com/wordpress/trunk@17184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-30 19:04:32 +00:00
ryan 3949ce12d0 Pink trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00