Commit Graph

420 Commits

Author SHA1 Message Date
Scott Taylor d5acdd82c8 Eliminate use of `extract()` in `paginate_links()`. Adds unit tests. Moves `tests/general/template.php` (which only had one method) to `tests/general/paginateLinks.php`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28397


git-svn-id: http://core.svn.wordpress.org/trunk@28225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-14 22:29:14 +00:00
Scott Taylor b110c7f887 Eliminate use of `extract()` in `wp_get_archives()`.
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28379


git-svn-id: http://core.svn.wordpress.org/trunk@28207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:29:26 +00:00
Scott Taylor 3d0eed82f8 In `paginate_links()`, `break` is unreachable after `return`.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28326


git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:25:15 +00:00
Scott Taylor 9bdbd50ac0 In `general-template.php` - remove dead code:
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28274


git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:58:16 +00:00
Scott Taylor a2067a7324 Set the proper value for `wp_title()` when `is_author()` and `is_post_type_archive()` are both true. `post_type` should always win due to the precedence indicated in `get_queried_object()`.
Props mordauk.
Fixes #25398.


Built from https://develop.svn.wordpress.org/trunk@28251


git-svn-id: http://core.svn.wordpress.org/trunk@28079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 22:21:22 +00:00
Drew Jaynes 05537ab967 Ensure the `register` filter hook is only documented once.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28208


git-svn-id: http://core.svn.wordpress.org/trunk@28038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:24:15 +00:00
Drew Jaynes e8be2a7e1e Inline documentation for three remaining hooks in wp-includes/general-template.php.
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.

That's 184/184 hook docs files complete. Boom!

Props kpdesign, DrewAPicture.
Fixes #27719.

Built from https://develop.svn.wordpress.org/trunk@28131


git-svn-id: http://core.svn.wordpress.org/trunk@27962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 04:42:16 +00:00
Drew Jaynes 577fe1960a Inline documentation for hooks in wp-includes/general-template.php.
Props jesin, kpdesign.
See #27719.

Built from https://develop.svn.wordpress.org/trunk@28130


git-svn-id: http://core.svn.wordpress.org/trunk@27961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 04:01:15 +00:00
John Blackbourn 8f5e5941bb Introduce `before_page_number` and `after_page_number` arguments for `paginate_links()`. Fixes #24709. Props grahamarmfield.
Built from https://develop.svn.wordpress.org/trunk@27600


git-svn-id: http://core.svn.wordpress.org/trunk@27443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 23:31:14 +00:00
John Blackbourn 3ec5d81f97 Improve `paginate_links()` performance by not calling `number_format_i18n()` unnecessarily. Fixes #25735 with tests. Props johnpbloch.
Built from https://develop.svn.wordpress.org/trunk@27523


git-svn-id: http://core.svn.wordpress.org/trunk@27366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 17:39:15 +00:00
Andrew Nacin f1bcaeb35f Let get_the_date() accept a post object.
props tanner-m, adamsilverstein, bigdawggi.
fixes #13771.

Built from https://develop.svn.wordpress.org/trunk@27380


git-svn-id: http://core.svn.wordpress.org/trunk@27229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 18:00:14 +00:00
Andrew Nacin d24a109288 Revert [27115] and let cache backends handle the stripping of spaces in cache keys as necessary.
microtime() returns greater precision than microtime(true).

see #27000, #23448, #26903, #14485.

Built from https://develop.svn.wordpress.org/trunk@27300


git-svn-id: http://core.svn.wordpress.org/trunk@27153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 22:05:13 +00:00
Drew Jaynes cb8951b0b3 Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Sergey Biryukov 46fc082824 Correct @return value for get_the_date().
props TobiasBg.
fixes #27181.
Built from https://develop.svn.wordpress.org/trunk@27231


git-svn-id: http://core.svn.wordpress.org/trunk@27088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-21 22:49:13 +00:00
Sergey Biryukov 68f4f9d5ba Remove unnecessary assignment and concatenation from the_date() and get_the_date().
props juliobox.
fixes #27181.
Built from https://develop.svn.wordpress.org/trunk@27230


git-svn-id: http://core.svn.wordpress.org/trunk@27087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-21 22:38:13 +00:00
Drew Jaynes cb3c7997c7 Improve inline documenation for `get_the_time()` and `get_post_time().
Props ruud@joyo for the initial patch.
Fixes #26682.

Built from https://develop.svn.wordpress.org/trunk@27148


git-svn-id: http://core.svn.wordpress.org/trunk@27015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-09 21:03:13 +00:00
Andrew Nacin 084a7b50cd Use a float for last_changed microtime cache values.
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.

props _jameslee, drozdz.
fixes #27000. see #23448.

Built from https://develop.svn.wordpress.org/trunk@27115


git-svn-id: http://core.svn.wordpress.org/trunk@26982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 08:14:12 +00:00
Andrew Nacin 12a64b39db Fix the conditional enqueueing/printing of colors stylesheets, without breaking dependencies.
fixes #18380.
see #20729 which should properly fix this.

Built from https://develop.svn.wordpress.org/trunk@27111


git-svn-id: http://core.svn.wordpress.org/trunk@26978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 22:16:11 +00:00
Andrew Nacin b7d3166e90 Use the_title_attribute() in feed_links_extra(), rather than get_the_title().
props c3mdigital.
fixes #15046.

Built from https://develop.svn.wordpress.org/trunk@26975


git-svn-id: http://core.svn.wordpress.org/trunk@26854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 09:53:09 +00:00
Andrew Ozz 90403aed4b Deprecate rich_edit_exists(). It doesn't make sense to support deleting the TinyMCE directory when we have auto-updates. Fixes #26786.
Built from https://develop.svn.wordpress.org/trunk@26933


git-svn-id: http://core.svn.wordpress.org/trunk@26814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-13 00:00:12 +00:00
Drew Jaynes 081932443f Avoid a notice by checking that SCRIPT_DEBUG is defined before evaluating it in `register_admin_color_schemes()`.
See #26316.

Built from https://develop.svn.wordpress.org/trunk@26786


git-svn-id: http://core.svn.wordpress.org/trunk@26673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 19:23:11 +00:00
Andrew Nacin aa1ac65bfc Admin color schemes: Manually handle RTL and minified versions of the CSS files on registration.
This bypasses WP_Styles entirely, which is much simpler for the moment, given that color schemes bypass WP_Styles for plenty already. The script loader is told to stop thinking of colors.css as an RTL-ified file. The colors-fresh handle, used directly on the login screen, needed to be (even before this commit).

fixes #26316.

Built from https://develop.svn.wordpress.org/trunk@26780


git-svn-id: http://core.svn.wordpress.org/trunk@26667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 09:05:10 +00:00
Andrew Nacin ce94d432a7 Add four more color schemes to round out our collection at eight.
The new schemes are Ectoplasm, Coffee, Ocean, Sunrise. For those following along, the first three were at one point named Ghostbusters, Pixel, and Cape Cod.

See [26137] for the original color schemes.

props ryelle, melchoyce, drw158, littlethingsstudio.
fixes #26468. see #25858, #22862.

Built from https://develop.svn.wordpress.org/trunk@26773


git-svn-id: http://core.svn.wordpress.org/trunk@26660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 07:26:12 +00:00
Andrew Ozz e6dd5fbf48 Svg-painter:
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333.
Built from https://develop.svn.wordpress.org/trunk@26601


git-svn-id: http://core.svn.wordpress.org/trunk@26491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 04:13:11 +00:00
Andrew Nacin dd465838e6 Rename colors-fresh.css to colors.css. fixes #26137.
Built from https://develop.svn.wordpress.org/trunk@26570


git-svn-id: http://core.svn.wordpress.org/trunk@26461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:16:11 +00:00
Helen Hou-Sandí 7c940061fd Pass the post type to the `post_type_archive_title` filter for better context. Adds lovely docs. props DrewAPicture. fixes #25605.
Built from https://develop.svn.wordpress.org/trunk@26457


git-svn-id: http://core.svn.wordpress.org/trunk@26355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-28 05:24:09 +00:00
Andrew Nacin f665c7eeb1 Remove SCRIPT_DEBUG reference from register_admin_color_schemes().
Instead, script-loader.php handles converting .min.css to .css when SCRIPT_DEBUG is on, and has since r21592. (This was done for compatibility with plugin color schemes that used .css and .dev.css.)

see #25858.

Built from https://develop.svn.wordpress.org/trunk@26147


git-svn-id: http://core.svn.wordpress.org/trunk@26058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 00:03:10 +00:00
Helen Hou-Sandí 94dfe504f3 Avoid a notice when SCRIPT_DEBUG is not defined. props MikeHansenMe. see #25824, #25858.
Built from https://develop.svn.wordpress.org/trunk@26146


git-svn-id: http://core.svn.wordpress.org/trunk@26057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 23:59:08 +00:00
Helen Hou-Sandí 603c1aff6d Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight.
Color scheme selection on your own profile page gives you a preview and autosaves the selection.

Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.

Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.

props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858, #22862.

Built from https://develop.svn.wordpress.org/trunk@26137


git-svn-id: http://core.svn.wordpress.org/trunk@26048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:38:38 +00:00
Scott Taylor d7efe7a3b0 Change `nofollow` to `follow` in `wp_robots_noindex()`. "The noindex is fine, the nofollow stops any link equity from that URL, so that's actually a bad idea."
Props joostdevalk.
Fixes #22876.


Built from https://develop.svn.wordpress.org/trunk@26096


git-svn-id: http://core.svn.wordpress.org/trunk@26011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 22:27:10 +00:00
Helen Hou-Sandí 69d432410a Say hello to a fresh new look for the WordPress admin.
Still to come: more color schemes, a responsive component, and more.

see #25858.
props iammattthomas, tillkruess, EmpireOfLight, melchoyce, ryelle, joen, mitchoyoshitaka, sirbrillig, andypeatling, isaackeyet, Otto42, dd32, matt, helen.

Built from https://develop.svn.wordpress.org/trunk@26072


git-svn-id: http://core.svn.wordpress.org/trunk@25992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-10 00:27:10 +00:00
Andrew Nacin 5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin 74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Sergey Biryukov 1863c06879 Escape title in HTML5 search form. props obenland, joostdevalk, scottsweb. fixes #25322.
Built from https://develop.svn.wordpress.org/trunk@25710


git-svn-id: http://core.svn.wordpress.org/trunk@25624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 14:14:09 +00:00
Andrew Nacin ce637bdcb3 Remove redundant title attributes.
props sabreuse.
see #24766.

Built from https://develop.svn.wordpress.org/trunk@25675


git-svn-id: http://core.svn.wordpress.org/trunk@25591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 22:51:10 +00:00
Andrew Nacin 32917eb0bd Ensure that get_bloginfo( 'pingback_url' ) uses site_url(), for SSL awareness.
props technosailor.
fixes #25418.

Built from https://develop.svn.wordpress.org/trunk@25671


git-svn-id: http://core.svn.wordpress.org/trunk@25587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:15:09 +00:00
Scott Taylor 8bd9659d0d Move checks for `post_type` being an array inline. See [25291], [25292], #18614.
Built from https://develop.svn.wordpress.org/trunk@25312


git-svn-id: http://core.svn.wordpress.org/trunk@25274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 03:02:10 +00:00
Scott Taylor d24a3940de Make sure the queried object is non-null before accessing its properties.
Props markoheijnen, ryan.
Fixes #21394.


Built from https://develop.svn.wordpress.org/trunk@25310


git-svn-id: http://core.svn.wordpress.org/trunk@25272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 02:28:11 +00:00
Scott Taylor a67d551dac Ensure that the post type object is the queried object when a post type has been registered with `has_archive => true`. Ensure it is not stomped when decorated with `tax_query`. Adds unit tests.
Props nacin.
Fixes #18614.


Built from https://develop.svn.wordpress.org/trunk@25291


git-svn-id: http://core.svn.wordpress.org/trunk@25255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 22:07:09 +00:00
Sergey Biryukov 02e5cb6f9d Escape URLs in feed_links(). props Chouby. fixes #25212.
Built from https://develop.svn.wordpress.org/trunk@25207


git-svn-id: http://core.svn.wordpress.org/trunk@25179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 10:11:09 +00:00
Andrew Nacin daf9fcc07a Obey $prefix when $display = false in single_term_title(), single_post_title(), and post_type_archive_title(). props yoavf, fixes #16632.
Built from https://develop.svn.wordpress.org/trunk@25041


git-svn-id: http://core.svn.wordpress.org/trunk@25028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-16 20:54:10 +00:00
Andrew Nacin 34a1d5394c Have get_footer() match get_header() etc in [24616]. fixes #24714.
git-svn-id: http://core.svn.wordpress.org/trunk@24617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 20:48:02 +00:00
Andrew Nacin fb20e3b5bb In general template functions, cast to string then ensure we actually have a template name before proceeding. Affects get_sidebar(), get_header(), get_footer(), get_template_part().
props tivnet for initial patch.
fixes #24714.



git-svn-id: http://core.svn.wordpress.org/trunk@24616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 20:31:04 +00:00
Ryan Boren d04bce99e8 Don't sync the blog public option from noindex(). This can cause race conditions.
fixes #23155


git-svn-id: http://core.svn.wordpress.org/trunk@24559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 15:17:31 +00:00
Andrew Nacin ff6dd2b952 Improve the HTML classes for the new html5 format in get_search_form().
Update Twenty Thirteen to reflect the changes.

props obenland.
fixes #23850.



git-svn-id: http://core.svn.wordpress.org/trunk@24524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 20:45:12 +00:00
Andrew Nacin 5969819038 `add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'
props obenland.
see #23850.



git-svn-id: http://core.svn.wordpress.org/trunk@24417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:31:34 +00:00
Sergey Biryukov 351fda2958 Allow to switch get_search_form() to HTML5 with an add_theme_support() call. fixes #23850.
git-svn-id: http://core.svn.wordpress.org/trunk@24225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 22:41:30 +00:00
Andrew Nacin a518fb0c94 Fix usage of undeclared variables.
* the_weekday_date() needs the global $currentday
 * ms_site_check() needs the global $current_site
 * media list table does not need to check for $total_orphans
 * upgrader has no $feedback variable, appears to be copypasta from other upgrade APIs
 * install_themes_feature_list() has no $features variable, return array() instead of a new return type of WP_Error

see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 16:35:03 +00:00
Andrew Nacin a9712e0183 Add wp_registration_url() and register_url filter.
props scribu, JustinSainton, SergeyBiryukov.
fixes #17950.



git-svn-id: http://core.svn.wordpress.org/trunk@24053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:21:22 +00:00