WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,594 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

899 Commits

Author SHA1 Message Date
Scott Taylor 27523183bf Don't use variable variables in `touch_time()`. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28747


git-svn-id: http://core.svn.wordpress.org/trunk@28561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 21:05:16 +00:00
John Blackbourn 03131233e2 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
Built from https://develop.svn.wordpress.org/trunk@28730


git-svn-id: http://core.svn.wordpress.org/trunk@28544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 18:50:14 +00:00
Scott Taylor 05eeb16e30 Replace all uses of `like_escape()` with `$wpdb->esc_like()`. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Sergey Biryukov 4b14fe0593 Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.
Built from https://develop.svn.wordpress.org/trunk@28681


git-svn-id: http://core.svn.wordpress.org/trunk@28499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 18:29:14 +00:00
Drew Jaynes b0877f02a4 Make sure `$post` is properly documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28653


git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 03:53:17 +00:00
Scott Taylor 5b5b756edf In `get_terms_to_edit()`, call `get_object_term_cache()` before priming cache with `wp_get_object_terms()`. 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.


Built from https://develop.svn.wordpress.org/trunk@28561


git-svn-id: http://core.svn.wordpress.org/trunk@28387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:29:14 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Scott Taylor a7a6cb5bef Eliminate use of `extract()` in `Walker_Category_Checklist::start_el()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28411


git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:14:14 +00:00
Scott Taylor 7ebab48f4c Eliminate use of `extract()` in `wp_terms_checklist()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28410


git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:09:15 +00:00
Scott Taylor a75f8137bc Eliminate use of `extract()` in `wp_star_rating()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28409


git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:57:14 +00:00
Andrew Nacin 55b0cd935e Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.

Built from https://develop.svn.wordpress.org/trunk@28107


git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:00:14 +00:00
Andrew Nacin eca26bc5ae The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.

Built from https://develop.svn.wordpress.org/trunk@28093


git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:53:15 +00:00
Andrew Nacin 497b0df4a5 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.

Built from https://develop.svn.wordpress.org/trunk@28090


git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:48:15 +00:00
Andrew Nacin bec78b5e11 Proper IDs for the custom fields box. 
props SergeyBiryukov.
fixes #14376.

Built from https://develop.svn.wordpress.org/trunk@27776


git-svn-id: http://core.svn.wordpress.org/trunk@27613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 06:56:14 +00:00
Drew Jaynes 7dc9b02577 Correct misleading verbiage in 'print' hook docs. 
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.

Built from https://develop.svn.wordpress.org/trunk@27695


git-svn-id: http://core.svn.wordpress.org/trunk@27534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 08:05:15 +00:00
Andrew Nacin 17ccbc86c9 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context. 
see #13265.

Built from https://develop.svn.wordpress.org/trunk@27470


git-svn-id: http://core.svn.wordpress.org/trunk@27315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:19:16 +00:00
Andrew Ozz 19efb78b48 Restyles the modal for attaching media to posts, props avryl, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27401


git-svn-id: http://core.svn.wordpress.org/trunk@27248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-04 23:11:13 +00:00
Drew Jaynes ad3861242d Inline documentation for hooks in wp-admin/includes/template.php. 
Props shelob9 for the initial patch. Props kpdesign.
Fixes #26089.

Built from https://develop.svn.wordpress.org/trunk@27237


git-svn-id: http://core.svn.wordpress.org/trunk@27094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-23 22:44:13 +00:00
Sergey Biryukov 6919d9f197 Use correct variable. props avryl. fixes #27153. 
Built from https://develop.svn.wordpress.org/trunk@27194


git-svn-id: http://core.svn.wordpress.org/trunk@27053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-19 15:29:14 +00:00
Scott Taylor ca4045ce76 Use `selected()` where appropriate in `touch_time()`, `page_template_dropdown()`, and `parent_dropdown()`. Also, add proper docs. 
Props meloniq, DrewAPicture.
Fixes #25889.


Built from https://develop.svn.wordpress.org/trunk@27188


git-svn-id: http://core.svn.wordpress.org/trunk@27047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-17 22:27:15 +00:00
Drew Jaynes 30c7a12aa2 Fix docs spacing missed in [27136]. 
See #27070.

Built from https://develop.svn.wordpress.org/trunk@27137


git-svn-id: http://core.svn.wordpress.org/trunk@27004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:19:11 +00:00
Drew Jaynes 8b3c9c6b97 Improve inline documentation for `submit_button()`. 
See #27070.

Built from https://develop.svn.wordpress.org/trunk@27136


git-svn-id: http://core.svn.wordpress.org/trunk@27003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:14:12 +00:00
Drew Jaynes de97319ad8 Clarify `submit_button()` `$type` parameter docs to mention that the value doubles as the CSS class attribute. 
See #27070

Built from https://develop.svn.wordpress.org/trunk@27135


git-svn-id: http://core.svn.wordpress.org/trunk@27002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 22:11:15 +00:00
Andrew Nacin dbea669271 Improve parameter documentation of add_meta_box(). 
props philiparthurmoore, DrewAPicture.
fixes #26698.

Built from https://develop.svn.wordpress.org/trunk@27132


git-svn-id: http://core.svn.wordpress.org/trunk@26999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-08 00:55:12 +00:00
Andrew Ozz eb1d21d782 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712. 
Built from https://develop.svn.wordpress.org/trunk@27029


git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-24 19:06:15 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-24 18:57:12 +00:00
Drew Jaynes 7bf5470bab Inline documentation fixes for hooks and functions introduced in 3.8.0. 
Built from https://develop.svn.wordpress.org/trunk@26736


git-svn-id: http://core.svn.wordpress.org/trunk@26625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-06 19:18:11 +00:00
Dion Hulse 89dfee993d Replace the Star ratings in the dashboard with dashicons ratings. 
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170

Built from https://develop.svn.wordpress.org/trunk@26380


git-svn-id: http://core.svn.wordpress.org/trunk@26280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-26 02:25:21 +00:00
Matt Thomas 7fe71ffe81 Style and positioning fixes to form elements in the Publish box: 
- Make select element text #555 to match others
- Make Cancel links vertically align with buttons
- Make sure the spacing between buttons and cancel links is always consistent
- Override active button styles for responsive states so button size doesn't change when active
- Reduce font size of date select element to match date text inputs

Fixes #26082, props aubreypwd.


Built from https://develop.svn.wordpress.org/trunk@26247


git-svn-id: http://core.svn.wordpress.org/trunk@26153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-18 18:53:10 +00:00
Andrew Ozz 541d22e18d Fix the X-UA-Compatible header for IE8, fixes #25575 
Built from https://develop.svn.wordpress.org/trunk@26089


git-svn-id: http://core.svn.wordpress.org/trunk@26007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-11 18:02:10 +00:00
Andrew Ozz 0743625aed Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575. 
Built from https://develop.svn.wordpress.org/trunk@26029


git-svn-id: http://core.svn.wordpress.org/trunk@25959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-06 23:49:09 +00:00
Andrew Nacin d93d8b850d Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.

Built from https://develop.svn.wordpress.org/trunk@25695


git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 10:56:09 +00:00
Drew Jaynes 858343ed71 Inline documentation for `Walker_Category_Checklist`. 
See #23406.

Built from https://develop.svn.wordpress.org/trunk@25642


git-svn-id: http://core.svn.wordpress.org/trunk@25559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-28 18:08:10 +00:00
Andrew Nacin 9cf6436ff3 Ignore unauthorized meta keys in meta_form(). fixes #18786. 
Built from https://develop.svn.wordpress.org/trunk@25591


git-svn-id: http://core.svn.wordpress.org/trunk@25508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 01:31:10 +00:00
Sergey Biryukov 14db24911f Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340. 
Built from https://develop.svn.wordpress.org/trunk@25472


git-svn-id: http://core.svn.wordpress.org/trunk@25393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-17 09:08:08 +00:00
Scott Taylor ffe8f1b13a Remove unnecessary checks before setting `$wp_settings_*` arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional `array`. 
Props scribu.
Fixes #17884.


Built from https://develop.svn.wordpress.org/trunk@25240


git-svn-id: http://core.svn.wordpress.org/trunk@25210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-04 19:07:09 +00:00
Sergey Biryukov ca17a6161a Avoid displaying multiple instances of the same feature pointers on a single screen. props nacin. fixes #25022 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@25117


git-svn-id: http://core.svn.wordpress.org/trunk@25097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-24 22:34:10 +00:00
Andrew Nacin d06c049d51 Fix various typos in inline documentation. props nofearinc, fixes #25119. 
Built from https://develop.svn.wordpress.org/trunk@25094


git-svn-id: http://core.svn.wordpress.org/trunk@25078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-22 22:01:08 +00:00
Helen Hou-Sandí eb44516e48 Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333. 
Built from https://develop.svn.wordpress.org/trunk@25083


git-svn-id: http://core.svn.wordpress.org/trunk@25068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-22 15:24:10 +00:00
Ryan Boren 3a5f483e14 Set RTL body class for iframes. 
Props mitchoyoshitaka
see #24149


git-svn-id: http://core.svn.wordpress.org/trunk@24994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-06 17:35:43 +00:00
Andrew Nacin e91002f4fb Remove unnecessary cap checks from [24854]. You need these capabilities (or equivalent) to access the screens for these feature pointers. see #24832. 
git-svn-id: http://core.svn.wordpress.org/trunk@24855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-29 06:43:30 +00:00
Mark Jaquith 8abd5bb815 Tooltips for 3.6 features: Revisions, Post Locking. 
Props siobhan. See #24832 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-29 06:17:01 +00:00
Andrew Nacin c2a543566c Move _local_storage_notice() to admin/includes/template.php. props azaozz, see #24756. 
git-svn-id: http://core.svn.wordpress.org/trunk@24762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-22 05:09:49 +00:00
Mark Jaquith e9afe4c5d1 Fixes and tweaks for the metabox accordion. 
* Fixed hover issues in Customizer.
* Toned down the default active/hover style (as it is normally not the top level menu, and should not be so prominent).
* Allow the active section to be closed.
* Other misc fixes.

Props ocean90, helen. Fixes #23449.

git-svn-id: http://core.svn.wordpress.org/trunk@24734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-18 17:42:53 +00:00
Helen Hou-Sandí 0da48b8335 Tweaks to the accordion: 
* Enqueues JS in `do_accordion_sections()`.
* Top and bottom rounded corners for the nav menu accordion.
* Better RTL and no-JS.

props lessbloat, DrewAPicture, aaroncampbell, helen. fixes #23449.


git-svn-id: http://core.svn.wordpress.org/trunk@24680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-12 18:16:29 +00:00
Andrew Nacin eaa4370237 Remove 'sorted' from do_accordion_sections(). fixes #23450. 
git-svn-id: http://core.svn.wordpress.org/trunk@24674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-12 15:43:00 +00:00
Andrew Nacin c2db94d10c Use meta caps edit_post, read_post, and delete_post directly, rather than consulting the post type object. map_meta_cap() handles that for us. props markjaquith, kovshenin. fixes #23226. 
git-svn-id: http://core.svn.wordpress.org/trunk@24593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-08 20:05:42 +00:00
Sergey Biryukov 4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356. 
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-28 03:29:15 +00:00
Andrew Nacin b34ca3234e Remove manual printing of userSettings as utils.js receives this as inline script data (since 3.5). see #24210. 
git-svn-id: http://core.svn.wordpress.org/trunk@24187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-07 15:49:20 +00:00
Andrew Nacin 00b7fa589a Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com. 
props mboynes, jonbishop, SergeyBiryukov.
fixes #23322.



git-svn-id: http://core.svn.wordpress.org/trunk@24052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-22 20:17:25 +00:00
Andrew Nacin d095eac796 Ensure that the resulting post time is localized after the date is changed. props SergeyBiryukov. fixes #24072. 
git-svn-id: http://core.svn.wordpress.org/trunk@24046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-22 19:04:02 +00:00
Andrew Nacin ef3d64ccd9 Pass $post to display_post_states filter (in _post_states()). 
git-svn-id: http://core.svn.wordpress.org/trunk@24028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-18 15:02:30 +00:00
Ryan Boren 469d1a3099 Escape form action urls with esc_url() rather than esc_attr(). 
Props SergeyBiryukov
fixes #23266


git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-18 14:01:25 +00:00
Sergey Biryukov 099c3c6422 Remove unused variable. props DrewAPicture. fixes #23782. 
git-svn-id: http://core.svn.wordpress.org/trunk@23710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-15 16:23:36 +00:00
Mark Jaquith 83bb916b81 Turn the Nav Menu meta boxes into an accordion. Less sprawling and overwhelming. 
* Registration stays the same — they're meta boxes
* Call `do_accordion_sections()` instead of `do_meta_boxes()` and they render as an accordion

props DrewAPicture, lessbloat, jkudish. fixes #23450. see #23449

git-svn-id: http://core.svn.wordpress.org/trunk@23707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-15 13:16:38 +00:00
Ryan Boren f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:14:09 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Andrew Nacin 401e88e387 Ignore protected meta keys in meta_form(). see #18786. 
git-svn-id: http://core.svn.wordpress.org/trunk@23534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-28 19:51:29 +00:00
Sergey Biryukov b5c34dc411 Fix typo in phpdoc. see #17515. 
git-svn-id: http://core.svn.wordpress.org/trunk@23457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-19 23:40:03 +00:00
Sergey Biryukov bc2ff9d342 Deprecate wp_convert_bytes_to_hr() in favor of size_format(). props F J Kaiser. fixes #19067. 
git-svn-id: http://core.svn.wordpress.org/trunk@23439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-16 03:07:56 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Mark Jaquith 00dbfdf89e Document the mysterious seventh parameter of add_meta_box(). 
props wonderboymusic, markjaquith. fixes #17515

git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-08 18:37:34 +00:00
Mark Jaquith 2fb915f860 Display post formats in the posts list table. 
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.

fixes #16047

git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-08 16:10:05 +00:00
Sergey Biryukov 72784ad6c2 Consistently use a helper function instead of directly printing the disabled attribute. 
Remove an erroneous esc_attr() call.

fixes #23194.

git-svn-id: http://core.svn.wordpress.org/trunk@23352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-28 03:23:01 +00:00
Sergey Biryukov 3e917ac75f Make sure the post exists before checking its ID. fixes #23026. 
git-svn-id: http://core.svn.wordpress.org/trunk@23351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-28 02:55:06 +00:00
Ryan Boren d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles. 
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-30 13:40:59 +00:00
Andrew Nacin fe3ace4f05 Feature pointers: 
* Finalize the text for the media pointer. Offer it for translation.
 * Remove the favorites pointer.
fixes #22454.



git-svn-id: http://core.svn.wordpress.org/trunk@22874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-27 18:58:07 +00:00
Andrew Nacin 67b5e59b68 Two initial feature pointers for WordPress 3.5: plugin favorites and the media dialog. One offered for translation. props nacin, lessbloat, DrewAPicture. see #22454. 
git-svn-id: http://core.svn.wordpress.org/trunk@22815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-22 09:24:11 +00:00
Andrew Nacin 3da5e3a7fc Fix up the 'Attach' dialog on upload.php. 
We are de-emphasising attaching (see [22630]) but this is existing
core functionality and will remain for now. This commit just cleans
it up a bit so as to be less embarrassing.

props lessbloat, helenyhou.
fixes #20164.



git-svn-id: http://core.svn.wordpress.org/trunk@22723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-20 18:50:15 +00:00
Andrew Nacin b9b9ebeeae Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855. 
git-svn-id: http://core.svn.wordpress.org/trunk@22459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 23:54:03 +00:00
Andrew Ozz cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152 
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-06 01:01:52 +00:00
Ryan Boren 3eabc7db5a Use esc_attr() for attributes. Props johnjamesjacoby. fixes #22327 
git-svn-id: http://core.svn.wordpress.org/trunk@22373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-05 18:04:50 +00:00
Daryl Koopersmith a918ec9135 Refine button styles, notably the gray buttons. 
* Crisper edges, fewer outer shadows.
* Higher contrast borders on the gray buttons.
* Separates `button-large` from `button-primary`, and removes the `regular` override class.

props hugobaeta, helenyhou, lessbloat. see #21598.


git-svn-id: http://core.svn.wordpress.org/trunk@22099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-02 23:38:21 +00:00
Ryan Boren 21d38d35d4 Initialize to avoid notice. Props bradyvercher. fixes #22050 
git-svn-id: http://core.svn.wordpress.org/trunk@22091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-01 16:09:16 +00:00
Daryl Koopersmith eb54ac6373 Move wp_max_upload_size and dependencies to wp-includes. props johnjamesjacoby. see #21390, fixes #21867. 
git-svn-id: http://core.svn.wordpress.org/trunk@22073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 20:59:57 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup. 
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-26 19:57:44 +00:00
Andrew Nacin 76bc5c7c21 Better alignment in the ustom fields metabox. props SergeyBiryukov, ocean90, fixes #21847. 
git-svn-id: http://core.svn.wordpress.org/trunk@21955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-23 17:42:46 +00:00
Andrew Nacin c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598. 
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-21 19:34:23 +00:00
Andrew Nacin 0d43250e2d Move the Cancel button for replying and quick-editing a comment to after the primary update/reply button so tabbing from the comment field takes you to the primary action. see #21340. 
git-svn-id: http://core.svn.wordpress.org/trunk@21883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-17 22:13:53 +00:00
Andrew Nacin 7fd32ab9fc Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy. 
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-13 17:28:57 +00:00
Ryan Boren daa6757a9b Check for an empty post in wp_popular_terms_checklist(). _wp_ajax_add_hierarchical_term() doesn't set up global post info. Props SergeyBiryukov. see #21309 
git-svn-id: http://core.svn.wordpress.org/trunk@21791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-10 16:45:49 +00:00
Daryl Koopersmith 67894a3407 New button styles. 
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-08 04:58:34 +00:00
Andrew Nacin aa543734b8 Fix adding and updating from the Custom Fields meta box. Broken in [21205]. props SergeyBiryukov. see #21829 for trunk. 
git-svn-id: http://core.svn.wordpress.org/trunk@21781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-07 15:49:20 +00:00
Ryan Boren 999d31c237 Make the callback optional for add_settings_section(). Props lightningspirit. fixes #21630 
git-svn-id: http://core.svn.wordpress.org/trunk@21742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-04 20:55:20 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post. 
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-04 16:29:28 +00:00
Andrew Nacin 3331a345bc Update some code comments from .dev.js to .js. props georgestephanis. see #21633. 
git-svn-id: http://core.svn.wordpress.org/trunk@21659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-30 02:15:57 +00:00
Ryan Boren f56d8278bb Remove return ref from all calls to get_post() 
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-23 20:01:10 +00:00
Ryan Boren 65f5267604 Send Content-Type with charset for iframe_header(). Props SergeyBiryukov, sergey.s.betke@novgaro.ru. fixes #19454 
git-svn-id: http://core.svn.wordpress.org/trunk@21538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-17 14:19:03 +00:00
ryan e02ea8023e Remove debug cruft. Props ocean90. fixes #21315 
git-svn-id: http://core.svn.wordpress.org/trunk@21349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-26 15:01:44 +00:00
ryan 91ab52d443 For get_settings_errors(), make sure errors from transient get added to the global variable and not unset when checking for an error of a specific setting. Also always return an array, as noted in the documentation. Props obenland. fixes #20833 
git-svn-id: http://core.svn.wordpress.org/trunk@21315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-24 15:13:46 +00:00
azaozz 34535097b7 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar). 
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-24 00:15:15 +00:00
duck_ ea548d7891 Hide pointers introduced in 3.4 from new users. Fixes #20941. 
git-svn-id: http://core.svn.wordpress.org/trunk@21075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-13 17:38:42 +00:00
nacin 08c3cb242a Prevent a scrollbar in the admin caused by padding given to the toolbar. props SergeyBiryukov, ocean90. fixes #19196. 
git-svn-id: http://core.svn.wordpress.org/trunk@21025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-07 22:05:01 +00:00
azaozz c4942fae11 Pointers: fix check for defer_loading, fixes #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 22:50:30 +00:00
azaozz 7729e3742e Pointers: center pointer on Themes screen, fixes #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 16:34:51 +00:00
azaozz 453ab841d0 s/deffer/defer, see #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 07:02:25 +00:00
azaozz b0e634031f Pointers: add arg to pointer options to load at window.loaded (after all images have been loaded and the layout is finalized) and use it on the custom header screen, see #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 06:45:49 +00:00
ryan 2f97993537 Updated text for Customize pointer. Props jane. see #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-23 19:49:14 +00:00
ryan 17f9635a45 Feature pointers for choosing an image from the library on the custom header and background pages. see #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-21 20:34:20 +00:00