WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
31,357 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

5647 Commits

Author SHA1 Message Date
Drew Jaynes 0322d0e89b Fix inline documentation syntax in the `WP_Upgrader->clear_destination()` method added in 4.3. 
See [32854]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33209


git-svn-id: http://core.svn.wordpress.org/trunk@33181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 19:46:25 +00:00
Drew Jaynes f9070e11b4 Fix summaries for two methods added to `WP_Terms_List_Table` in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33207


git-svn-id: http://core.svn.wordpress.org/trunk@33179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 18:22:25 +00:00
Drew Jaynes d1a3d2e6ea Add missing summaries, `@access` tags, and some parameter descriptions for methods added to `WP_Links_List_Table` in 4.3. 
See [32753]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33204


git-svn-id: http://core.svn.wordpress.org/trunk@33176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 18:03:24 +00:00
Konstantin Obenland 2829827c1c Site Icon: Add Android-specific app icon. 
Falling back to Apple app icons is deprecated behavior and will not work
forever. 192px is the recommended size for that icon.

Props kraftbj.
Fixes #32964.


Built from https://develop.svn.wordpress.org/trunk@33202


git-svn-id: http://core.svn.wordpress.org/trunk@33174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:58:47 +00:00
Drew Jaynes 5ebb6855b6 Add missing summaries, `@access` tags, and some parameter descriptions for methods added to `WP_MS_Sites_List_Table` in 4.3. 
See [32755]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33199


git-svn-id: http://core.svn.wordpress.org/trunk@33171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:53:24 +00:00
Drew Jaynes 88229587c0 Improving formatting for various pieces of inline documentation in the new `WP_Site_Icon` class added in 4.3. 
See [32994]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33198


git-svn-id: http://core.svn.wordpress.org/trunk@33170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:51:24 +00:00
Drew Jaynes b2cc4de9b2 Add missing summaries, `@access` tags, and some parameter descriptions to methods added to `WP_Posts_List_Table` in 4.3. 
See [32740]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33197


git-svn-id: http://core.svn.wordpress.org/trunk@33169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:49:25 +00:00
Drew Jaynes 9a2261d3bf Fix the DocBlock summary for `WP_Plugins_List_Table->get_primary_column_name()`, added in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33196


git-svn-id: http://core.svn.wordpress.org/trunk@33168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:46:26 +00:00
Drew Jaynes 3361f39479 Add missing summaries and parameter descriptions to new methods added to `WP_MS_Users_List_Table` in 4.3. 
See [32757]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33195


git-svn-id: http://core.svn.wordpress.org/trunk@33167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 17:43:25 +00:00
Drew Jaynes 5961dbb65b Add missing summaries to new methods added to `WP_MS_Themes_List_Table` in 4.3. 
See [32756]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33193


git-svn-id: http://core.svn.wordpress.org/trunk@33165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 16:13:26 +00:00
John Blackbourn f3eba1581c Place the locale inside the md5 hash in the dashboard RSS feed widget transient key to prevent the transient timeout option name becoming longer than the allowed field size. 
Props andg
Fixes #32804

Built from https://develop.svn.wordpress.org/trunk@33192


git-svn-id: http://core.svn.wordpress.org/trunk@33164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 15:32:25 +00:00
John Blackbourn 396cc7b2e4 Correct a parameter name in the docs for `wp_insert_category()`. 
Built from https://develop.svn.wordpress.org/trunk@33190


git-svn-id: http://core.svn.wordpress.org/trunk@33162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 12:59:25 +00:00
John Blackbourn 1f7a3bc58d Append the current locale to dashboard RSS widget cache keys so they refresh accordingly when the locale is changed. 
Fixes #32804
Props andg

Built from https://develop.svn.wordpress.org/trunk@33183


git-svn-id: http://core.svn.wordpress.org/trunk@33155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 22:07:25 +00:00
Konstantin Obenland 13ab10fff7 Site Icon: Improve a11y in Settings. 
Props afercia.
Fixes #32970.


Built from https://develop.svn.wordpress.org/trunk@33180


git-svn-id: http://core.svn.wordpress.org/trunk@33152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 19:43:24 +00:00
Drew Jaynes 967b04a7f8 Add missing summaries and `@access` tags to methods added to `WP_Media_List_Table` in 4.3. 
See [32754]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33179


git-svn-id: http://core.svn.wordpress.org/trunk@33151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 18:34:24 +00:00
Drew Jaynes d7c887fe5d Fix the summaries for a few methods and hooks added to `WP_List_Table` in 4.3. 
See [32644]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33178


git-svn-id: http://core.svn.wordpress.org/trunk@33150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 18:32:24 +00:00
Drew Jaynes 703d4c259c Fix filter doc vernacular for the new `wp_ajax_cropped_attachment_id` hook added in 4.3. 
See #32891.

Built from https://develop.svn.wordpress.org/trunk@33176


git-svn-id: http://core.svn.wordpress.org/trunk@33148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 18:26:24 +00:00
Jeremy Felt 9f0506e3b2 Add better handling for actions and messaging in MS Sites List Table row actions 
* Simplify URLs used for row actions to remove messaging and site domain/path.
* Use confirmation messaging from a managed list of actions when handling the request.
* Find the site address from the site ID rather than using information passed in the URL.

Fixes #32963.

Built from https://develop.svn.wordpress.org/trunk@33173


git-svn-id: http://core.svn.wordpress.org/trunk@33145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-12 02:36:26 +00:00
Helen Hou-Sandí 6e73f1282e List tables: Better accessibility and design for the comments bubble. 
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.

props picard102, afercia, karinchristen.
fixes #32152.

Built from https://develop.svn.wordpress.org/trunk@33155


git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:44:25 +00:00
Konstantin Obenland f29e5044cd Site Icon: Add Customizer UI. 
Second part of the Site Icon feature after [32994] introduced it for Settings.

Props celloexpressions.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33154


git-svn-id: http://core.svn.wordpress.org/trunk@33126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:33:24 +00:00
Dominik Schilling 75d6c10b01 Customizer: Use a `<button>` for the collapse sidebar … button. 
props afercia.
fixes #32819.
Built from https://develop.svn.wordpress.org/trunk@33153


git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:22:26 +00:00
Jeremy Felt 0bc0b0c917 Do not allow deletion of a super admin user through `wpmu_delete_user()`. 
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.

Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935.

Built from https://develop.svn.wordpress.org/trunk@33143


git-svn-id: http://core.svn.wordpress.org/trunk@33114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-09 16:16:25 +00:00
Andrew Ozz 4cd790906f TinyMCE, Press This: add the `wptextpattern` plugin to the Press This editor. 
See #31441.
Built from https://develop.svn.wordpress.org/trunk@33128


git-svn-id: http://core.svn.wordpress.org/trunk@33099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-08 19:53:25 +00:00
Helen Hou-Sandí 9c3bc85649 Ensure error messages look like, well, errors. 
props obenland, rachelbaker.
fixes #32475.

Built from https://develop.svn.wordpress.org/trunk@33117


git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 23:11:24 +00:00
Scott Taylor 0deed4b842 In `install_dashboard()` (`plugin-install`, FWIW), make sure `slug` is populated and degrease the unfortunate whitespace that was present. 
Props tyxla.
Fixes #32889.

Built from https://develop.svn.wordpress.org/trunk@33114


git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 19:19:24 +00:00
Helen Hou-Sandí 0b046085ae Show row actions on focus for the dashboard comment list. 
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33106


git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 15:26:24 +00:00
Helen Hou-Sandí 81c2f541b0 List tables: Add a fallback for the primary column. 
Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33104


git-svn-id: http://core.svn.wordpress.org/trunk@33075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 15:12:27 +00:00
Helen Hou-Sandí df220685a0 List tables: Account for comments being reused on the post edit screen. 
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.

Built from https://develop.svn.wordpress.org/trunk@33101


git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 00:09:24 +00:00
Jeremy Felt c9027b00ba Assign proper active class when showing plugin updates in network admin 
Previously, a plugin would trigger an active class if it was active on the network's main site.

Fixes #32901.

Built from https://develop.svn.wordpress.org/trunk@33100


git-svn-id: http://core.svn.wordpress.org/trunk@33071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 00:02:24 +00:00
Jeremy Felt 3faebf40a6 Remove unused `$current_site` global in MS Sites list table 
Found itself unused after [32719].

See #32434.

Built from https://develop.svn.wordpress.org/trunk@33097


git-svn-id: http://core.svn.wordpress.org/trunk@33068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-06 22:51:25 +00:00
Konstantin Obenland c9a29b0123 Check for all required caps before (un)sticking a post. 
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.

Props ericmann, chriscct7.
Fixes #24153.


Built from https://develop.svn.wordpress.org/trunk@33096


git-svn-id: http://core.svn.wordpress.org/trunk@33067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-06 22:41:25 +00:00
Sergey Biryukov c543f98ee6 Plugins list table: Add an `aria-label` attribute with the plugin name to plugin action links to provide context for screen reader users. 
props bramd, rianrietveld, afercia.
fixes #26167.
Built from https://develop.svn.wordpress.org/trunk@33087


git-svn-id: http://core.svn.wordpress.org/trunk@33058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-05 15:03:25 +00:00
Konstantin Obenland 664b0373dc Site Icon: Switch to using H1 headings. 
See #31650.

Props afercia.
Fixes #32885.


Built from https://develop.svn.wordpress.org/trunk@33084


git-svn-id: http://core.svn.wordpress.org/trunk@33055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-04 18:49:27 +00:00
Jeremy Felt 767ed1e9b1 Use the full site URL in `choose_primary_blog()` when a user is a member of only one site. 
Aligns with the output used when a user is a member of multiple sites.

Fixes #32884.

Built from https://develop.svn.wordpress.org/trunk@33081


git-svn-id: http://core.svn.wordpress.org/trunk@33052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-04 04:21:24 +00:00
Sergey Biryukov b2299463b6 Plugins list table: Use case-insensitive sorting. 
props GaryJ.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33076


git-svn-id: http://core.svn.wordpress.org/trunk@33047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 21:53:25 +00:00
Konstantin Obenland cf22cd7d72 Site Icon: Remove date dropdown from media modal. 
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.

Props ocean90.
Fixes #32860.


Built from https://develop.svn.wordpress.org/trunk@33075


git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 21:28:24 +00:00
Dion Hulse ceaec85751 Press This: Rewrite `WP_Press_This::fetch_source_html()` to utilise the HTTP API better without the need for a local temporary file. 
This reverts [33061] but keeps it's custom UA string.

See #32864

Built from https://develop.svn.wordpress.org/trunk@33062


git-svn-id: http://core.svn.wordpress.org/trunk@33033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 12:01:25 +00:00
Sergey Biryukov fc8c36eb97 Press This: Set explicit user agent. 
props kraftbj.
fixes #32864.
Built from https://develop.svn.wordpress.org/trunk@33061


git-svn-id: http://core.svn.wordpress.org/trunk@33032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 11:17:24 +00:00
Dion Hulse 36de491d68 Don't upgrade global tables to utf8mb4 when `wp_should_upgrade_global_tables()` says not to. 
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154

Built from https://develop.svn.wordpress.org/trunk@33058


git-svn-id: http://core.svn.wordpress.org/trunk@33029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 05:44:24 +00:00
Dion Hulse d651de0dac Introduce `wp_should_upgrade_global_tables()` to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines. 
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk

Built from https://develop.svn.wordpress.org/trunk@33057


git-svn-id: http://core.svn.wordpress.org/trunk@33028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 04:34:24 +00:00
Dion Hulse cbacb92dae Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally. 
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33055


git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 03:26:24 +00:00
Konstantin Obenland a4e803fbd4 Use `get_default_comment_status()` globally. 
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.


Built from https://develop.svn.wordpress.org/trunk@33054


git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 22:32:25 +00:00
Konstantin Obenland cd7a40bdc7 Site Icon: Improve responsiveness for small screen devices. 
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33053


git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 21:16:24 +00:00
Sergey Biryukov 3fb3d2a762 Replace `@returns` with `@return` in PHP docblocks. 
props kraftbj.
fixes #32865.
Built from https://develop.svn.wordpress.org/trunk@33052


git-svn-id: http://core.svn.wordpress.org/trunk@33023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 21:05:24 +00:00
Konstantin Obenland 0d270f67c2 Site Icon: Skip cropping if image has the correct size. 
Props jipmoors for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33051


git-svn-id: http://core.svn.wordpress.org/trunk@33022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 20:40:25 +00:00
Mark Jaquith 423a1a7ca4 New password change/set UI. 
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023


git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 14:48:24 +00:00
Dion Hulse ebb6aa1d4a Split `upgrade_430()` into two so that `split_all_shared_terms()` runs when `upgrade_430_fix_comments()` bails early. 
See [32814], #30261, [32364], #32165

Built from https://develop.svn.wordpress.org/trunk@33020


git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 07:35:24 +00:00
Helen Hou-Sandí 8eb7f71e6b List tables: A better responsive view. 
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 01:31:25 +00:00
Konstantin Obenland f18fabc300 Site Icon: Move admin icon filter to its rightful place. 
The action is unrelated to `WP_Site_Icon` itself.

Props kraftbj.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33011


git-svn-id: http://core.svn.wordpress.org/trunk@32982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 23:26:25 +00:00
Dominik Schilling 7cc9a4c092 Plugins list table: Sort plugins by `Name` by default so translated plugin names get correctly sorted. 
props swissspidy.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33010


git-svn-id: http://core.svn.wordpress.org/trunk@32981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 22:31:25 +00:00
Dominik Schilling 86ebc13446 Remove unnecessary feedback message from `WP_Importer::is_user_over_quota()`. 
fixes #32021.
Built from https://develop.svn.wordpress.org/trunk@33008


git-svn-id: http://core.svn.wordpress.org/trunk@32979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 20:32:25 +00:00
Konstantin Obenland 38e4211efb Use existing nomenclature pattern for Site Icon class. 
Props kraftbj.
Fixes #32834.


Built from https://develop.svn.wordpress.org/trunk@33001


git-svn-id: http://core.svn.wordpress.org/trunk@32972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 14:37:27 +00:00
Andrew Ozz b092defb17 Press This: 
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.
Built from https://develop.svn.wordpress.org/trunk@32999


git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 03:58:27 +00:00
Konstantin Obenland c56a8ae0f7 Introducing Site Icon, favicon management for WordPress. 
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@32994


git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 12:58:25 +00:00
Helen Hou-Sandí 83e33a2ca0 List tables: Bring screen reader text for comments column title to media. 
see #32152, [31513].

Built from https://develop.svn.wordpress.org/trunk@32991


git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 15:44:25 +00:00
Aaron Jorbin 1525010f74 Deprecate php4 style constructors 
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982


Built from https://develop.svn.wordpress.org/trunk@32990


git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 15:27:24 +00:00
Sergey Biryukov b26accf35a List tables: Select All should not be a column header. 
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 05:46:25 +00:00
Andrew Ozz 275fc220ef Press This: 
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32983


git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 04:59:24 +00:00
Konstantin Obenland 7dc1d06e64 Proper heading for admin screens. 
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:41:25 +00:00
Scott Taylor 8b1286417e `ob_get_contents()` followed by `ob_end_clean()` can be replaced by `ob_get_clean()`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32965


git-svn-id: http://core.svn.wordpress.org/trunk@32936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:12:24 +00:00
Scott Taylor a0e373ef80 For doc block types, favor `bool` over the few remaining `boolean`s 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:03:25 +00:00
Scott Taylor 642af1f3f4 Some doc blocks should use `bool` instead of `true|false` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32963


git-svn-id: http://core.svn.wordpress.org/trunk@32934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:45:24 +00:00
Scott Taylor 60b8e86b36 In `WP_Filesystem_Base::chdir|chgrp|chmod()` (all mock `abstract` methods), modify `@return` to include `string` so that subclass `@return`s match. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32962


git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:43:24 +00:00
Scott Taylor 7537240d37 List tables: when post navigation links point to the current page, use `<span>`s and text instead of `<a>`s. 
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 20:32:26 +00:00
Scott Taylor 587c570efa After [32796], improve the accessibility and markup for instances of `touch_time()`. 
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:30:25 +00:00
Andrew Ozz 7142248743 Press This: better screen reader text for the arrow part of the split button. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32944


git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:24:25 +00:00
Scott Taylor 7453d12390 Remove unused code from `WP_Press_This::html()`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32939


git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:38:25 +00:00
Scott Taylor d9bd43c702 Remove unused code from `WP_MS_Sites_List_Table::display_rows()`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32938


git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:36:29 +00:00
Andrew Ozz d3ee649cb9 Press This: support passing `i` parameter to add an image src. 
Props stephdau, azaozz. Fixes #32173.
Built from https://develop.svn.wordpress.org/trunk@32936


git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 03:06:25 +00:00
Andrew Ozz d4f3428d5f Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32934


git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 01:55:30 +00:00
John Blackbourn b5973e92ec Introduce a `no_terms` label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object. 
Fixes #32150
Props afercia

Built from https://develop.svn.wordpress.org/trunk@32933


git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 00:16:27 +00:00
Drew Jaynes e9758d4e48 Fix a typo in the DocBlock for `get_plugins()`. 
Props onnimonni, swissspidy.
Fixes #32758.

Built from https://develop.svn.wordpress.org/trunk@32927


git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 12:22:27 +00:00
Dion Hulse 42fbb6568e WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923. 
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548

Built from https://develop.svn.wordpress.org/trunk@32924


git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:52:25 +00:00
Dion Hulse 8f47efe7dc WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments 
Props mnelson4 for initial patch.
Fixes #29548

Built from https://develop.svn.wordpress.org/trunk@32923


git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:49:25 +00:00
Andrew Ozz f8cf80e9b1 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32921


git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 03:23:27 +00:00
Andrew Ozz f4109b0c5d Press This: convert the Preview | Save | Publish buttons to a split button. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32920


git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 02:46:27 +00:00
Scott Taylor 00de0e6341 In `unregister_setting()`, search for `$option_name` in a segment of `$new_whitelist_options` keyed by `$option_group`. 
Props nofearinc.
Fixes #26479.

Built from https://develop.svn.wordpress.org/trunk@32905


git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:51:26 +00:00
Scott Taylor b8f49cebee List table views: fix missing current class for "All" when logged in as an author. 
Props afercia.
Fixes #32015.

Built from https://develop.svn.wordpress.org/trunk@32903


git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:39:27 +00:00
Helen Hou-Sandí 5a07e4bba4 Add "Scheduled" to post states. 
props rclations.
fixes #32131.

Built from https://develop.svn.wordpress.org/trunk@32902


git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 16:07:26 +00:00
Sergey Biryukov 4332d8dfc0 Avoid a PHP notice in `WP_Press_This::get_suggested_content()` after [32828]. 
props kraftbj.
fixes #32751.
Built from https://develop.svn.wordpress.org/trunk@32901


git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 15:20:28 +00:00
Scott Taylor 92d67bf395 Use valid markup in `Walker_Nav_Menu_Edit::start_el()` - replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`. 
Props sagarjadhav.
Fixes #31817.

Built from https://develop.svn.wordpress.org/trunk@32879


git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:22:26 +00:00
Scott Taylor 032ea5b132 Add access modifier to `WP_Upgrader::clear_destination()` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32871


git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:53:25 +00:00
Scott Taylor 86beb35f6d Use `<button>` instead of `<a>` for non-link links in Quick Edit. 
Props afercia.
Fixes #32213.

Built from https://develop.svn.wordpress.org/trunk@32869


git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:42:27 +00:00
Scott Taylor cfe78e0e95 Cleanup `(ms-)?admin-filters.php` 
Props johnjamesjacoby.
Fixes #32529.

Built from https://develop.svn.wordpress.org/trunk@32865


git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:18:25 +00:00
Dion Hulse 8593dc3172 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process. 
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921

Built from https://develop.svn.wordpress.org/trunk@32854


git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:49:25 +00:00
Dion Hulse a21f890abb Remove a redundant index drop, it'll be dropped and re-created a few lines further down. 
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk

Built from https://develop.svn.wordpress.org/trunk@32852


git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:18:26 +00:00
Konstantin Obenland c1a9c4b7b8 Semanticize Help and Screen Options toggle. 
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.


Built from https://develop.svn.wordpress.org/trunk@32844


git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 16:36:25 +00:00
Konstantin Obenland d872f38c31 Show the posts meta box by default in Appearance > Menus. 
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.


Built from https://develop.svn.wordpress.org/trunk@32842


git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 15:04:26 +00:00
Konstantin Obenland c9e1e2be9b Make posts in the 'Most recent' tab of post type meta boxes filterable. 
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.


Built from https://develop.svn.wordpress.org/trunk@32833


git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:35:28 +00:00
Andrew Ozz bc2630e099 Press This: Check the embeds list against all of the oembed providers. 
Props stephdau. Fixes #32069.
Built from https://develop.svn.wordpress.org/trunk@32828


git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 00:12:26 +00:00
Andrew Ozz b77a3a33f5 Press This: show error message when the user is attempting to add a category that already exists. 
Fixes #32339.
Built from https://develop.svn.wordpress.org/trunk@32827


git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 23:13:26 +00:00
Boone Gorges f62bf61b2c Bail out of 4.3 term splitting routine when no shared terms are found. 
Props dd32.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@32819


git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 11:40:24 +00:00
Boone Gorges 290044ef15 Split all shared taxonomy terms on upgrade to 4.3. 
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32814


git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 01:53:26 +00:00
Helen Hou-Sandí d159cc2272 Media list table: Avoid PHP notices by using the proper variables. 
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 21:33:25 +00:00
Scott Taylor 5c6b63d3a6 `if` is a statment, not a function. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:01:25 +00:00
Helen Hou-Sandí a49c192f37 Media list table: Restore row actions. 
see #29881, #32657.

Built from https://develop.svn.wordpress.org/trunk@32798


git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 19:47:24 +00:00
Dion Hulse faf6383ebd Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key. 
Props mordauk. Fixes #31784

Built from https://develop.svn.wordpress.org/trunk@32784


git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 06:26:25 +00:00
Dion Hulse c6bb637f89 Updats: Add a filter for the options params for the update being performed. 
Props nofearinc. Fixes #27754

Built from https://develop.svn.wordpress.org/trunk@32783


git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:35:26 +00:00
Dion Hulse b881a541bb Updates: Remove redundant title tags from update outputs. 
Props afercia. Fixes #32530

Built from https://develop.svn.wordpress.org/trunk@32781


git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:09:25 +00:00
Dion Hulse 0eb8bfc464 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message. 
See #32435

Built from https://develop.svn.wordpress.org/trunk@32778


git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 03:32:27 +00:00
Andrew Nacin e7f618d86e Tweak the first post/page content to get with the times. 
props chriscct7.
fixes #22474.

Built from https://develop.svn.wordpress.org/trunk@32768


git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:56:50 +00:00
Scott Taylor 4348074f3a In `WP_MS_Users_List_Table::display_rows()`: 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32757


git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 17:11:26 +00:00
Scott Taylor 3855cfbffd In `WP_MS_Themes_List_Table::display_rows()`: 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32756


git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:54:26 +00:00
Scott Taylor 2bdcc71bc0 In `WP_MS_Sites_List_Table::display_rows()`: 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32755


git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:23:25 +00:00
Scott Taylor ba8cfcab71 In `WP_Media_List_Table::display_rows()`: 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32754


git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:57:27 +00:00
Scott Taylor a56576edfe In `WP_Links_List_Table::display_rows()`: 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32753


git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:33:25 +00:00
Scott Taylor b8eb353590 In `WP_Posts_List_Table`, move the `<th>` markup out of `->column_cb()`. 
See #29881, [32740].

Built from https://develop.svn.wordpress.org/trunk@32752


git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:14:24 +00:00
Scott Taylor 18827ed337 In `wp_ajax_hidden_columns()`, don't `explode()` on an empty string. 
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.

Built from https://develop.svn.wordpress.org/trunk@32751


git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:00:25 +00:00
Scott Taylor da0400e273 In `WP_Posts_List_Table::column_title()`, use `is_post_type_hierarchical()` instead of `$this->hierarchical_display` in the logic to determine whether `the_excerpt()` should be called. 
Fixes #32187.

Built from https://develop.svn.wordpress.org/trunk@32749


git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:42:26 +00:00
Scott Taylor c11e433858 After [32740], in `WP_Posts_List_Table::single_row()` - `$lock_holder` is checked but unused, so the call to `get_userdata()` is unnecessary. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32742


git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:48:26 +00:00
Scott Taylor c1c7a7c14c After [32740], correct doc block typo. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32741


git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:29:26 +00:00
Scott Taylor 3f4cadf4aa Override `->single_row_columns()` in `WP_Posts_List_Table`. 
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32740


git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:18:24 +00:00
Scott Taylor d0aa8e4a6e In `WP_Terms_List_Table::display_rows_or_placeholder()`: 
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32739


git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:55:25 +00:00
Scott Taylor da4c3d0fe4 In `WP_Posts_List_Table::single_row()`: 
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32738


git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:50:25 +00:00
Scott Taylor 4835310a18 In `WP_Media_List_Table::display_rows()`, `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32737


git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:45:25 +00:00
Scott Taylor f88b42be94 In `WP_Comments_List_Table::column_comment()`, `$post` and `$the_comment_status` are unused, as is the `$comment_status` global. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32736


git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:39:25 +00:00
Scott Taylor d2a00338f6 Don't loosely compare functions that return `bool` against a literal `bool`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32730


git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:19:27 +00:00
Dion Hulse c445d60a00 SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions. 
See #32345

Built from https://develop.svn.wordpress.org/trunk@32726


git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 06:31:28 +00:00
Konstantin Obenland cb39d03501 Improve non-visual feedback for list table items without terms. 
Props karpstrucking, afercia.
Fixes #32150.


Built from https://develop.svn.wordpress.org/trunk@32725


git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-11 09:28:31 +00:00
Helen Hou-Sandí c87224eaf6 List tables: Use a class instead of inline styles for hidden columns. 
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 19:47:27 +00:00
Helen Hou-Sandí 06ebd0a2aa List tables: 
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@32723


git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 19:31:25 +00:00
Helen Hou-Sandí 51b5ed9fa4 List tables: Better primary column back-compat. 
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32722


git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 14:59:30 +00:00
Helen Hou-Sandí 3562ac028d List tables: Consolidate `<td>` output for posts. 
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32721


git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 14:01:28 +00:00
Konstantin Obenland ce16fd8dca More semantic markup for the post formats metabox. 
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.


Built from https://develop.svn.wordpress.org/trunk@32720


git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 09:09:25 +00:00
Jeremy Felt 0e76a2c570 Additional improvement to sites list table display 
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.

Built from https://develop.svn.wordpress.org/trunk@32719


git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 07:28:26 +00:00
Jeremy Felt 93ff65e677 Improve information displayed in a network's sites list table 
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.

Built from https://develop.svn.wordpress.org/trunk@32718


git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 06:50:25 +00:00
Helen Hou-Sandí 005d937ce2 List tables: 
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32717


git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 01:46:27 +00:00
Konstantin Obenland 6d56231da3 Sort screen options for meta boxes according to the meta box's priority. 
Props swissspidy.
Fixes #32582.


Built from https://develop.svn.wordpress.org/trunk@32707


git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 12:35:26 +00:00
Konstantin Obenland c20edc4df5 Remove title attributes in user list tables. 
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.


Built from https://develop.svn.wordpress.org/trunk@32694


git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 08:40:26 +00:00
Konstantin Obenland 5daf12dba4 Text improvements for screen readers in list table paginations. 
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.


Built from https://develop.svn.wordpress.org/trunk@32693


git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 05:01:25 +00:00
Helen Hou-Sandí 0e77b693ac Nav menus: hide the title attribute field by default for new users and installs. 
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.

Built from https://develop.svn.wordpress.org/trunk@32691


git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-04 04:38:25 +00:00
Helen Hou-Sandí 6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained. 
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:23:25 +00:00
Helen Hou-Sandí 40fca44c89 Media: move the thumbnail into the title column in list view. 
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:13:25 +00:00
Helen Hou-Sandí 2d3a637598 List tables: tighten up primary column handling for plugins and multisite themes. 
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32686


git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:08:28 +00:00
Andrew Ozz b3d04247b7 Editor: 
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.
Built from https://develop.svn.wordpress.org/trunk@32677


git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 17:38:29 +00:00
John Blackbourn 02192cb53f Introduce `featured_image`, `set_featured_image`, `remove_featured_image`, and `use_featured_image` post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases. 
Props johnbillion, mordauk, valendesigns.
Fixes #19257.

Built from https://develop.svn.wordpress.org/trunk@32673


git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 16:54:27 +00:00
Scott Taylor 42d51a4f89 Add doc blocks to functions that are missing them. 
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32672


git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 03:18:25 +00:00
Drew Jaynes 9cb1017b3c Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653]. 
See #32529.

Built from https://develop.svn.wordpress.org/trunk@32671


git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 02:00:26 +00:00
Drew Jaynes 0df0e0bf36 Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_Users_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32670


git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:45:27 +00:00
Drew Jaynes 65f31bc52e Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Terms_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32669


git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:44:26 +00:00
Drew Jaynes a69f867738 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Posts_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32668


git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:42:25 +00:00
Drew Jaynes 5e2983a77e Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Plugins_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32667


git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:40:29 +00:00
Drew Jaynes d7428fc35d Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Users_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32666


git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:38:26 +00:00
Drew Jaynes 5e84c7004d Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_MS_Themes_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32665


git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:36:27 +00:00
Drew Jaynes 88569734d8 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Sites_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32664


git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:34:25 +00:00
Drew Jaynes 42afe1d373 Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Media_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32663


git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:32:26 +00:00
Drew Jaynes 8bcf53cc68 Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for `WP_List_Table`. 
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32662


git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:29:26 +00:00
Drew Jaynes 2a0048b1fb Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Links_List_Table`. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32661


git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:23:26 +00:00
Drew Jaynes 5457eb4933 Add missing return descriptions and fix formatting of inline documentation introduced in [32644]. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32660


git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:18:26 +00:00
Scott Taylor 6a08b00632 Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:32:24 +00:00
Scott Taylor b3e0cfd25d Add (more) missing doc blocks to `wp-admin/includes/*`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:17:27 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Scott Taylor a51dfa3971 In the style of #30947 and `default-filters.php`, add 2 new files to `wp-admin/includes`: 
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 17:04:26 +00:00
Scott Taylor 9a29d8ac7b Add missing` annotations to `ajax-actions.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32652


git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 16:01:27 +00:00
Helen Hou-Sandí f5646cd9e5 Define a primary column for `WP_Post_Comments_List_Table`. 
props boonebgorges.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32651


git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:52:25 +00:00
Scott Taylor 19a3aacc94 Add `@static*` annotations where they are missing. 
Initialize all static vars that are not, most to `null`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32650


git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:43:29 +00:00
Helen Hou-Sandí 4c0c7fd7ba List tables: introduce the concept of a "primary" column. 
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:41:25 +00:00
Scott Taylor 282e28ad81 Add `@global` annotations to (the rest of the?) `wp-admin/*` files. 
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:06:31 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 21:41:30 +00:00
Jeremy Felt a5c688e817 Use site objects rather than get_blog_status() in MS list tables. 
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.

Built from https://develop.svn.wordpress.org/trunk@32630


git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 23:14:29 +00:00
Scott Taylor 19b8ef0c92 `get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:59:25 +00:00
Drew Jaynes 4c37f68b79 Fix inline documentation syntax in `wp_xmlrpc_server`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:25:25 +00:00
Scott Taylor af7a017f46 When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32545


git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:47:25 +00:00
Scott Taylor a69b8b3b91 In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32517


git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 20:50:27 +00:00
Scott Taylor 5a3dc2a371 In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32516


git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 20:46:25 +00:00
Dion Hulse 2ba7f3da75 Allow plugins to activate other plugins within their Activation hook. Fixes #32368 
Built from https://develop.svn.wordpress.org/trunk@32504


git-svn-id: http://core.svn.wordpress.org/trunk@32474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-14 06:58:27 +00:00
Dominik Schilling f9e1c18698 List Table: Add placeholder to a plural string. 
props SergeyBiryukov.
fixes #32034.
Built from https://develop.svn.wordpress.org/trunk@32473


git-svn-id: http://core.svn.wordpress.org/trunk@32443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-09 19:22:24 +00:00
Dominik Schilling 5268a77a80 Sites List Table: Replace context with a translators comment for the site name and tagline. 
props ramiy.
fixes #31849.
Built from https://develop.svn.wordpress.org/trunk@32472


git-svn-id: http://core.svn.wordpress.org/trunk@32442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-09 19:18:27 +00:00
Dominik Schilling c37bdc3c9e Merge similar error strings. 
props pavelevap.
fixes #32327.
Built from https://develop.svn.wordpress.org/trunk@32471


git-svn-id: http://core.svn.wordpress.org/trunk@32441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-09 18:27:26 +00:00
Gary Pendergast 02621f2a14 Upgrades: If a table has already been converted to `utf8mb4`, there's no need to try and convert it again. 
Props gabrielperezs for the initial patch.

See #32310.


Built from https://develop.svn.wordpress.org/trunk@32456


git-svn-id: http://core.svn.wordpress.org/trunk@32426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-08 12:22:25 +00:00
Michael Adams a3807c1d34 Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes. 
Props jorbin, et alii.

See #32165.

Built from https://develop.svn.wordpress.org/trunk@32440


git-svn-id: http://core.svn.wordpress.org/trunk@32410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-07 01:11:29 +00:00
Michael Adams 26c3c6d9cb Upgrade: `$wpdb->get_col_length()` sanity check: bail on unexpected return value. 
See #32165.

Built from https://develop.svn.wordpress.org/trunk@32429


git-svn-id: http://core.svn.wordpress.org/trunk@32399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 23:11:26 +00:00
Michael Adams 0640526e72 Upgrade: Ensure unintelligible DB schemas don't result in content loss. 
See #32165.

Built from https://develop.svn.wordpress.org/trunk@32417


git-svn-id: http://core.svn.wordpress.org/trunk@32387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 21:46:26 +00:00
Aaron Jorbin 2d189ef812 When upgrading WordPress remove genericons example.html files 
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin

--This line,build.wordpress-develop.dea and those below, will be ignored--

M    src/wp-admin/includes/update-core.php

Built from https://develop.svn.wordpress.org/trunk@32385


git-svn-id: http://core.svn.wordpress.org/trunk@32355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 18:37:25 +00:00
Sergey Biryukov 77572cf024 Multisite: Add translator comments to default email messages with non-typical placeholders. 
props yoavf.
fixes #32263.
Built from https://develop.svn.wordpress.org/trunk@32381


git-svn-id: http://core.svn.wordpress.org/trunk@32351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 09:12:25 +00:00
Gary Pendergast 4e615fb9ff Fix an incorrect version number check in [32378]. 
See #32099.


Built from https://develop.svn.wordpress.org/trunk@32379


git-svn-id: http://core.svn.wordpress.org/trunk@32349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 07:41:24 +00:00
Gary Pendergast 3a6e79c409 Upgrades: When converting to `utf8mb4`, we were trying to change the wrong index on `wp_signups`, causing the conversion to later fail. 
Props kovshenin, pento.

See #32099.


Built from https://develop.svn.wordpress.org/trunk@32378


git-svn-id: http://core.svn.wordpress.org/trunk@32348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 07:34:24 +00:00
Gary Pendergast 364886a5be WPDB: When checking that a string can be sent to MySQL, we shouldn't use `mb_convert_encoding()`, as it behaves differently to MySQL's character encoding conversion. 
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.


Built from https://develop.svn.wordpress.org/trunk@32364


git-svn-id: http://core.svn.wordpress.org/trunk@32335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 03:00:25 +00:00
Drew Jaynes a452927c39 Fix documentation syntax and formatting for the `media_sideload_image()` DocBlock. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32352


git-svn-id: http://core.svn.wordpress.org/trunk@32323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-05 02:20:25 +00:00
Drew Jaynes cbd07f213d Add two changelog entries for functional changes introduced in 4.2.0. 
Props dimadin.
See #31925.

Built from https://develop.svn.wordpress.org/trunk@32350


git-svn-id: http://core.svn.wordpress.org/trunk@32321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-05 02:16:25 +00:00
Drew Jaynes 08e3572b7c Add a missing DocBlock for `wp_caption_input_textarea()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32341


git-svn-id: http://core.svn.wordpress.org/trunk@32312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-04 01:13:25 +00:00
Drew Jaynes e7e93f50cf Add a missing `@return` tag to the DocBlock for `uninstall_plugin(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32340


git-svn-id: http://core.svn.wordpress.org/trunk@32311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-04 01:08:27 +00:00
Drew Jaynes 87e149a19f Add a missing `@return` tag to the DocBlock for `site_admin_notice()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32339


git-svn-id: http://core.svn.wordpress.org/trunk@32310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-04 01:06:25 +00:00
Drew Jaynes cdbecf201b Clarify accepted types for the `$args` and `$context` parameters in `WP_Filesystem()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32338


git-svn-id: http://core.svn.wordpress.org/trunk@32309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-04 01:04:25 +00:00
Sergey Biryukov ed0da72d97 Replace `echo __()` with `_e()`. 
props marsjaninzmarsa.
fixes #32239.
Built from https://develop.svn.wordpress.org/trunk@32333


git-svn-id: http://core.svn.wordpress.org/trunk@32304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-03 16:18:28 +00:00
Scott Taylor 2807b7146f After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code. 
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

See #31139.

Built from https://develop.svn.wordpress.org/trunk@32330


git-svn-id: http://core.svn.wordpress.org/trunk@32301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-30 21:40:25 +00:00
Sergey Biryukov aaafb3113a Bulk Edit: Properly associate the Format select with its label. 
props afercia.
fixes #32210.
Built from https://develop.svn.wordpress.org/trunk@32329


git-svn-id: http://core.svn.wordpress.org/trunk@32300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-30 16:04:24 +00:00
Dion Hulse 610e34c215 When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop. 
Props hnle, taka2. Fixes #32135. See #31811

Built from https://develop.svn.wordpress.org/trunk@32322


git-svn-id: http://core.svn.wordpress.org/trunk@32293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-29 03:17:31 +00:00
Gary Pendergast 44b56d9393 When deleting suspicious comments, do so permanently. 
Built from https://develop.svn.wordpress.org/trunk@32310


git-svn-id: http://core.svn.wordpress.org/trunk@32281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 16:11:26 +00:00
Gary Pendergast b89fc65951 [32308] was for 4.3, not 4.2.1. 
Built from https://develop.svn.wordpress.org/trunk@32309


git-svn-id: http://core.svn.wordpress.org/trunk@32280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 16:08:27 +00:00
Gary Pendergast 51402dc520 When upgrading to 4.2.1, delete suspicious comments. 
Built from https://develop.svn.wordpress.org/trunk@32308


git-svn-id: http://core.svn.wordpress.org/trunk@32279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 16:04:25 +00:00
Dominik Schilling 89e45feb4c Don't focus input fields outside of the request filesystem credentials form. 
props valendesigns.
fixes #32055.
Built from https://develop.svn.wordpress.org/trunk@32266


git-svn-id: http://core.svn.wordpress.org/trunk@32237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-22 16:24:26 +00:00
Dominik Schilling e0657e6904 Don't return empty themes in `wp_prepare_themes_for_js()`. 
see #32002.
Built from https://develop.svn.wordpress.org/trunk@32264


git-svn-id: http://core.svn.wordpress.org/trunk@32235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-22 16:11:25 +00:00
Andrew Ozz 60706015e1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3. 
Props iseulde. Fixes #31139, fixes #32006.
Built from https://develop.svn.wordpress.org/trunk@32258


git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-21 22:41:26 +00:00
Helen Hou-Sandí 1d1c026e8e Rename the `pre_wp_prepare_themes_for_js` filter to `pre_prepare_themes_for_js`. 
props DrewAPicture.
fixes #31789.

Built from https://develop.svn.wordpress.org/trunk@32246


git-svn-id: http://core.svn.wordpress.org/trunk@32217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-21 14:23:27 +00:00
Gary Pendergast e3f1f8fed1 Ensure post titles are correctly escaped on the Dashboard. 
Props helen, ocean90, dd32, pento.


Built from https://develop.svn.wordpress.org/trunk@32175


git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-20 07:39:25 +00:00
Sergey Biryukov 7f48138743 Press This: Update documentation for `press_this_save_redirect` filter after [31992]. 
props kraftbj.
fixes #31996.
Built from https://develop.svn.wordpress.org/trunk@32143


git-svn-id: http://core.svn.wordpress.org/trunk@32123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-19 01:34:28 +00:00
Dominik Schilling 786bce5b9c Customizer: Escape theme preview URLs. 
props johnbillion, ocean90.
see #31896.
Built from https://develop.svn.wordpress.org/trunk@32134


git-svn-id: http://core.svn.wordpress.org/trunk@32113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-15 16:33:25 +00:00
Scott Taylor 5e4616039c Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system). 
Props iseulde, ocean90.
Fixes #31912.

Built from https://develop.svn.wordpress.org/trunk@32125


git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-14 15:31:28 +00:00
Andrew Ozz fe150b9ef2 Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php. 
Props kraftbj. Fixes #31968.
Built from https://develop.svn.wordpress.org/trunk@32122


git-svn-id: http://core.svn.wordpress.org/trunk@32101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-14 05:45:28 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org. 
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-12 21:29:32 +00:00
Gary Pendergast 0179958273 When `dbDelta()` is checking whether an index is defined in a `CREATE TABLE` statement, don't worry if MySQL has a subpart defined on an index, but the `CREATE TABLE` doesn't. 
Fixes #31869.


Built from https://develop.svn.wordpress.org/trunk@32108


git-svn-id: http://core.svn.wordpress.org/trunk@32087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-11 10:40:31 +00:00
Andrew Ozz ad475b3c69 Press This: check the bookmarklet version and add the update notice from PHP. 
Fixes #31942.
Built from https://develop.svn.wordpress.org/trunk@32106


git-svn-id: http://core.svn.wordpress.org/trunk@32085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-10 21:08:29 +00:00
Andrew Ozz 0d4b29ffb9 Press This: add ARIA attributes to the `alerts` container. 
Props afercia. Fixes #31942.
Built from https://develop.svn.wordpress.org/trunk@32102


git-svn-id: http://core.svn.wordpress.org/trunk@32081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-09 23:45:27 +00:00
Andrew Ozz 9db5bac3c4 Press This: change the link text to Standard Editor. 
Props Michael-Arestad. See #31923.
Built from https://develop.svn.wordpress.org/trunk@32093


git-svn-id: http://core.svn.wordpress.org/trunk@32072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-08 23:28:25 +00:00
Andrew Ozz 33a0022773 Press This: 
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923.
Built from https://develop.svn.wordpress.org/trunk@32092


git-svn-id: http://core.svn.wordpress.org/trunk@32071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-08 23:14:28 +00:00
Boone Gorges 54a6a8e137 Don't allow whitespace-only image captions from the Media modal. 
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.

Fixes #21848.
Built from https://develop.svn.wordpress.org/trunk@32079


git-svn-id: http://core.svn.wordpress.org/trunk@32058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-08 17:11:27 +00:00
Aaron Jorbin abfddb8f3e Update placeholder for FTP credentials 
Two changes:
 * Remove superfluous __ function call
 * Update domain used

Fixes #31922
Props Tmeister


Built from https://develop.svn.wordpress.org/trunk@32077


git-svn-id: http://core.svn.wordpress.org/trunk@32056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-08 16:50:27 +00:00
Aaron Jorbin 99d6c67148 Enable users to initiate a shiny update from plugin detail modal 
The plugin detail modal can contain a link to update a plugin.  When it does, we should initiate a shiny update.

This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on.  These are the same users that can't use the customizer. 

Fixes #31739



Built from https://develop.svn.wordpress.org/trunk@32062


git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-07 03:09:26 +00:00
Helen Hou-Sandí 42028327a2 Insert from URL: Make sure the link text is actually used. 
Turns out there were more pieces to renaming the field.

props iseulde.
fixes #29476.

Built from https://develop.svn.wordpress.org/trunk@32055


git-svn-id: http://core.svn.wordpress.org/trunk@32034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-06 18:25:27 +00:00
Helen Hou-Sandí bfda508c18 Update more instances of default admin blues and grays. 
props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@32051


git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-05 21:20:27 +00:00
Sergey Biryukov 443760252b `wp_install_maybe_enable_pretty_permalinks()` should have a consistent `@return` value. 
props DrewAPicture.
fixes #6481. see #31888.
Built from https://develop.svn.wordpress.org/trunk@32027


git-svn-id: http://core.svn.wordpress.org/trunk@32006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-05 14:49:53 +00:00
Drew Jaynes ba1e7a7243 Correct grammar when referring to "a user" vs "an user" in several places. 
Props ocean90.
Fixes #31894.

Built from https://develop.svn.wordpress.org/trunk@32025


git-svn-id: http://core.svn.wordpress.org/trunk@32004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-05 14:44:27 +00:00
Drew Jaynes 7c3e469326 Clarify the DocBlock summary and parameter description for `wp_edit_attachments_query_vars()`. 
See [31037]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32019


git-svn-id: http://core.svn.wordpress.org/trunk@31998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 21:52:25 +00:00
Drew Jaynes 6ccba88ea5 Add proper descriptions for the `@global` and `@param` tags in the `wp_media_attach_action()` DocBlock. 
See [31619]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32018


git-svn-id: http://core.svn.wordpress.org/trunk@31997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 21:35:25 +00:00
Drew Jaynes 02810a305f Clarify the DocBlock description for `wp_print_request_filesystem_credentials_modal()`. 
See [31811]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32016


git-svn-id: http://core.svn.wordpress.org/trunk@31995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 21:13:26 +00:00
Drew Jaynes 654ee78c93 Clarify 4.2.0 changelog entry, add global description to the DocBlock for `WP_Users_List_Table->single_row()`. 
See #31888.

Built from https://develop.svn.wordpress.org/trunk@32015


git-svn-id: http://core.svn.wordpress.org/trunk@31994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 21:09:27 +00:00
Drew Jaynes e82de7ef27 Add missing `@since` versions from a variety of methods in `WP_Press_This`. 
See [31693]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32014


git-svn-id: http://core.svn.wordpress.org/trunk@31993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 19:46:26 +00:00
Drew Jaynes 7b89119eee Add missing DocBlocks for the `_limit_array()`, `_limit_string()`, `_limit_url()`, `_limit_img()`, `_limit_embed()`, and `_process_meta_entry()` utility methods in `WP_Press_This`. 
See [31609]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32013


git-svn-id: http://core.svn.wordpress.org/trunk@31992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 18:23:26 +00:00
Drew Jaynes 0306f2c011 Fix filter doc vernacular for the `quick_edit_show_taxonomy` filter. 
See [31308]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32011


git-svn-id: http://core.svn.wordpress.org/trunk@31990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 16:08:26 +00:00
Drew Jaynes 4239756a47 Fix syntax for the `$to_display` parameter description in the DocBlock for `WP_Posts_List_Table->_page_rows()`. 
See [31730]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32010


git-svn-id: http://core.svn.wordpress.org/trunk@31989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 16:04:28 +00:00
Drew Jaynes 8a3b21aad5 Add a return description to the DocBlock for `WP_Posts_List_Table->is_base_request()`. 
See [31828]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32009


git-svn-id: http://core.svn.wordpress.org/trunk@31988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 16:01:27 +00:00
Drew Jaynes b500d3e978 Fix typos in the function summaries for `wp_ajax_press_this_save_post()` and `wp_ajax_press_this_add_category()`. 
See [31534]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32007


git-svn-id: http://core.svn.wordpress.org/trunk@31986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 14:38:26 +00:00
Drew Jaynes 05fa6879ce Add an `@see` mention for `Plugin_Upgrader`, plus spacing to the `wp_ajax_update_plugin()` delcaration. 
See #31888.

Built from https://develop.svn.wordpress.org/trunk@32006


git-svn-id: http://core.svn.wordpress.org/trunk@31985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 14:19:27 +00:00
Boone Gorges 62450e9f0f After [31114] and [31323], 'View Post' generated in `get_sample_permalink_html()` should go to pretty permalink. 
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.

Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@32002


git-svn-id: http://core.svn.wordpress.org/trunk@31981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 01:27:28 +00:00
Sergey Biryukov 247fdbfe19 Remove hidden `user_id` input from `wp_comment_reply()`. 
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.
Built from https://develop.svn.wordpress.org/trunk@31999


git-svn-id: http://core.svn.wordpress.org/trunk@31978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-03 13:28:26 +00:00
Andrew Ozz 05a549723c Press This: 
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875.
Built from https://develop.svn.wordpress.org/trunk@31992


git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-03 01:34:26 +00:00
John Blackbourn d05236f756 Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet. 
See #31770.

Built from https://develop.svn.wordpress.org/trunk@31991


git-svn-id: http://core.svn.wordpress.org/trunk@31970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-03 00:18:27 +00:00
Dion Hulse 02403eadd1 Plugins Browser: Replace the download count with the number of Active installs of the plugin. 
Fixes #31865

Built from https://develop.svn.wordpress.org/trunk@31990


git-svn-id: http://core.svn.wordpress.org/trunk@31969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-02 23:49:27 +00:00
Aaron Jorbin 3ac2f91922 Update aria-label when doing a shiny plugin update 
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722



Built from https://develop.svn.wordpress.org/trunk@31982


git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-02 05:31:26 +00:00
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible. 
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 22:06:28 +00:00
Scott Taylor 62279ae07d In `WP_Posts_List_Table::get_views()`, don't add the `current` class to the `all` status link if `->user_posts_count` has a value, which triggers the additional `mine` status. 
See [31828].
Fixes #24869.

Built from https://develop.svn.wordpress.org/trunk@31959


git-svn-id: http://core.svn.wordpress.org/trunk@31938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 16:17:28 +00:00
Dominik Schilling 8ab7c076d6 Customizer Theme Switcher: Switch the details/live preview buttons. 
props celloexpressions, ocean90.
fixes #31791.
Built from https://develop.svn.wordpress.org/trunk@31954


git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 12:36:26 +00:00
Aaron Jorbin 8f99fbeb8d Refine UI for FTP modal and shiny updates 
Numerous changes to make the FTP modal experience a good one.  These include:
 * Update HTML used by both the form here and the form on the standalone screen
 * Allow users to cancel FTP install
 * Focus locking in the modal
 * Focus on modal form on load
 * ARIA Attributes
 * Style Enhancements
 * Add low screen height (such as phone and some tablets) friendly experience for entering credentials

Props ericlewis, afercia 
Fixes #31608


Built from https://develop.svn.wordpress.org/trunk@31949


git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 02:48:28 +00:00
Sergey Biryukov efb2740e88 Themes: Add a filter to short-circuit `wp_prepare_themes_for_js()`. 
props mattwiebe, DrewAPicture.
fixes #31789.
Built from https://develop.svn.wordpress.org/trunk@31943


git-svn-id: http://core.svn.wordpress.org/trunk@31922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-31 20:04:25 +00:00
Sergey Biryukov 5fae37471a Media Library: Add a label for attachment type select in list mode. 
props afercia.
fixes #31795.
Built from https://develop.svn.wordpress.org/trunk@31942


git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-31 19:57:26 +00:00
Sergey Biryukov 36643388ef Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings. 
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.

fixes #28502.
Built from https://develop.svn.wordpress.org/trunk@31941


git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-31 18:45:28 +00:00
Dion Hulse 7e1e32909e Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress. 
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811

Built from https://develop.svn.wordpress.org/trunk@31936


git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-31 02:11:26 +00:00
Dominik Schilling 289db2d37b Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother. 
see #31782.
Built from https://develop.svn.wordpress.org/trunk@31933


git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-30 19:22:26 +00:00
Sergey Biryukov e70e4e74fa Press This: Use the error message returned by `wp_update_post()` instead of a generic one. 
props stephdau.
fixes #31808.
Built from https://develop.svn.wordpress.org/trunk@31930


git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-30 14:39:26 +00:00
Sergey Biryukov 43a99e0f1b Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings. 
props SergeyBiryukov, afercia, tyxla.
fixes #30766.
Built from https://develop.svn.wordpress.org/trunk@31928


git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-30 12:50:29 +00:00
Andrew Ozz 6cd9c9645e Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button. 
Part props afercis, joedolson. Fixes #31575.
Built from https://develop.svn.wordpress.org/trunk@31925


git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-30 03:09:51 +00:00
Andrew Ozz f663dc73d4 Press This: remove `role="application"` from the Categories list wrapper. This doesn't make it work better in screen readers. 
See #31443.
Built from https://develop.svn.wordpress.org/trunk@31907


git-svn-id: http://core.svn.wordpress.org/trunk@31886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-26 21:49:32 +00:00
Dominik Schilling 8daaa09c9b Improve newly added strings for i18n: 
* Add context to "Format" string.
* Use "Format" with context for "Post format".

see #31776.
Built from https://develop.svn.wordpress.org/trunk@31906


git-svn-id: http://core.svn.wordpress.org/trunk@31885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-26 21:19:26 +00:00
Aaron Jorbin 9b23faef07 Remove Shiny Plugin Installs 
See #31773, #29820


Built from https://develop.svn.wordpress.org/trunk@31897


git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-26 02:30:28 +00:00
Boone Gorges 60c26865f9 Check that `$_POST` array index is set before comparing it in `post_preview()`. 
This prevents PHP notices in cases where a user with 'edit_others_posts' but
without 'publish_posts' previews another user's posts.

Props tyxla.
Fixes #31760.
Built from https://develop.svn.wordpress.org/trunk@31896


git-svn-id: http://core.svn.wordpress.org/trunk@31875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-26 01:45:26 +00:00
Andrew Ozz 6cc20e7095 Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed. 
Props stephdau. Fixes #31763.
Built from https://develop.svn.wordpress.org/trunk@31894


git-svn-id: http://core.svn.wordpress.org/trunk@31873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-26 01:17:26 +00:00
Dominik Schilling 51854c53b4 Improve alignment of labels and inputs in Quick Edit. 
props mattheu, valendesigns.
fixes #31408.
Built from https://develop.svn.wordpress.org/trunk@31890


git-svn-id: http://core.svn.wordpress.org/trunk@31869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-25 22:25:26 +00:00
Dominik Schilling 5ef13b688e Comments List: Don't let "Quick Edit" break on smaller screens. 
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.

props kraftbj.
fixes #31482.
Built from https://develop.svn.wordpress.org/trunk@31889


git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-25 22:15:27 +00:00
Drew Jaynes 1ad0eaf416 Clean up DocBlock information and syntax for `get_filesystem_method()`. 
Props ericlewis, HarishChaudhari, valendesigns.
Fixes #31267.

Built from https://develop.svn.wordpress.org/trunk@31884


git-svn-id: http://core.svn.wordpress.org/trunk@31863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-25 16:32:28 +00:00