WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,913 Commits 50 Branches 749 Tags 904 MiB
Commit Graph

17152 Commits

Author SHA1 Message Date
Scott Taylor 66a9c83284 Add missing doc blocks to `update.php`: 
* `wp_version_check()`, `wp_update_plugins()`, and `wp_update_themes()` do not return meaningful responses, and their responses are never handled by core. As such, they shouldn't alternately return `void` or `false`. "Returning" in those functions is just "bailing"
* In the same functions, `version.php` doesn't need to load if `WP_INSTALLING` is defined - the function will immediately bail, the values will never be read, and the globals won't be reset. I have unified the approach in all 3 functions.
* When returning filtered `$locale`, there is no need to set the variable twice.
* In `_maybe_update_core()`, `isset()` can take multiple values to bail before the call to `time()`, if necessary. This is a micro-optimization to prevent PHP from hitting the OS unnecessarily.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32635


git-svn-id: http://core.svn.wordpress.org/trunk@32605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 15:29:28 +00:00
Jeremy Felt f1ff34e547 Use a dataProvider for network option sanitization tests. 
Cleans up tests for sanitization of `illegal_names`, `illegal_email_domains`, and `banned_email_domains` network options.

Fixes #32517.

Built from https://develop.svn.wordpress.org/trunk@32634


git-svn-id: http://core.svn.wordpress.org/trunk@32604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 06:38:25 +00:00
Andrew Nacin 6df83c542b Revert change to default-filters.php in [32632]. see #32516. 
Built from https://develop.svn.wordpress.org/trunk@32633


git-svn-id: http://core.svn.wordpress.org/trunk@32603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 05:52:25 +00:00
Andrew Nacin 65c382d550 Fix `return` error in get_theme_mods() from [32629]. 
Split a line with both an assignment and a conditional, not to mention an interpolated variable. Lots going on, easy mistake to make.

props BrianLayman.
fixes #32516.

Built from https://develop.svn.wordpress.org/trunk@32632


git-svn-id: http://core.svn.wordpress.org/trunk@32602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 05:51:25 +00:00
Andrew Nacin e9551d2d43 Add unit test asserting that serializable objects will never pass is_serialized(). see #17375. 
Built from https://develop.svn.wordpress.org/trunk@32631


git-svn-id: http://core.svn.wordpress.org/trunk@32601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 05:23:27 +00:00
Jeremy Felt a5c688e817 Use site objects rather than get_blog_status() in MS list tables. 
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.

Built from https://develop.svn.wordpress.org/trunk@32630


git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 23:14:29 +00:00
Scott Taylor b4eccbd5a0 Add missing doc blocks to `theme.php`. 
Correct some `@return` values.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32629


git-svn-id: http://core.svn.wordpress.org/trunk@32599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 22:21:25 +00:00
Scott Taylor 0c1b765a6f Add missing doc blocks to `template.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32628


git-svn-id: http://core.svn.wordpress.org/trunk@32598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 22:04:26 +00:00
Scott Taylor 4777433584 Add missing doc blocks to `taxonomy.php`. 
Correct some `@return` values.
Some functions can `return new WP_Error` without setting it to a variable.
Some functions can return their `apply_filters(...)` call without first setting it to a variable.
`is_object_in_taxonomy()` can return its conditional instead of if/else true/false.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32627


git-svn-id: http://core.svn.wordpress.org/trunk@32597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 22:00:25 +00:00
Jeremy Felt 45ad4808d9 Provide all site flag data in objects returned by `get_blogs_of_user()` 
Previously, `archived`, `spam`, and `deleted` properties were forced to `0` when returned by `get_blogs_of_user()`. This was originally introduced in [21794] as a way to prevent notices when properties were expected.

Instead, we can properly fill these properties with those retrieved from `get_blog_details()`.

Props realloc.
Fixes #32281.

Built from https://develop.svn.wordpress.org/trunk@32626


git-svn-id: http://core.svn.wordpress.org/trunk@32596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 21:23:26 +00:00
Mark Jaquith 0a70901c50 Insert temporary password field hook for feature development in a plugin. 
Built from https://develop.svn.wordpress.org/trunk@32625


git-svn-id: http://core.svn.wordpress.org/trunk@32595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:59:25 +00:00
Scott Taylor 2bac335bdc Add missing doc blocks to `shortcodes.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32624


git-svn-id: http://core.svn.wordpress.org/trunk@32594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:39:25 +00:00
Scott Taylor e4a574fc87 Add missing doc blocks to `script-loader.php`. 
Use `wp_styles()` and `wp_scripts()` where appropriate. 
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32623


git-svn-id: http://core.svn.wordpress.org/trunk@32593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:34:27 +00:00
Scott Taylor 274daa059a Add missing doc blocks to `rewrite.php`. 
Clarify `@return` values where necessary.
`add_permastruct()` doesn't need to return.
`->using_index_permalinks()` and `->using_mod_rewrite_permalinks()` can just return their conditions, instead of if/else true/false.
`->mod_rewrite_rules()` and `->iis7_url_rewrite_rules()` don't need to set a variable that is immediately returned.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32622


git-svn-id: http://core.svn.wordpress.org/trunk@32592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:23:26 +00:00
Scott Taylor 5ee54c05ac Add missing doc blocks to `revision.php`. 
Clarify `@return` values where necessary.
In `wp_delete_post_revision()`, `wp_delete_post()` doesn't return `WP_Error`, so that check can be removed.
`wp_revisions_to_keep()` always returns an `int`, so `wp_revisions_enabled()` can use strict comparison.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32621


git-svn-id: http://core.svn.wordpress.org/trunk@32591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 18:38:24 +00:00
Scott Taylor 1ef11d7789 Add missing doc blocks to `query.php`. 
Clarify `@return` values where necessary.
Some wrapper functions don't need to return if the function they wrap doesn't return.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32620


git-svn-id: http://core.svn.wordpress.org/trunk@32590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 18:15:25 +00:00
Scott Taylor 2ebce023df Add missing doc blocks to `post.php`. 
Clarify some existing values for `@param` and `@return`.
Some functions do not need to set a variable before immediately returning it.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32619


git-svn-id: http://core.svn.wordpress.org/trunk@32589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 17:05:26 +00:00
Scott Taylor 2f75a74b3e Add missing doc blocks to `post-thumbnail-template.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32618


git-svn-id: http://core.svn.wordpress.org/trunk@32588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 16:29:28 +00:00
Scott Taylor bba3f1785c Add missing doc blocks to `post-template.php`. 
Correct some types for `@param` and `@return`.
`is_page_template()` can return the conditional instead of if/else true/false.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32617


git-svn-id: http://core.svn.wordpress.org/trunk@32587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 16:26:25 +00:00
Scott Taylor 4c6d8467e2 Add missing doc blocks to `post-formats.php`. 
Correct some types for `@param` and `@return`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32616


git-svn-id: http://core.svn.wordpress.org/trunk@32586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 16:06:25 +00:00
Scott Taylor fd04235a04 Add missing doc blocks to `plugin.php`. 
`has_filter()` can use strict comparison when checking `$has` internally.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32615


git-svn-id: http://core.svn.wordpress.org/trunk@32585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 15:56:26 +00:00
Scott Taylor 26554549c7 Add missing doc blocks for `pluggable.php`. 
Correct some `@return` values.
`is_user_logged_in()` can simply return the `->exists()` call instead of if/else'ing true/false.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32614


git-svn-id: http://core.svn.wordpress.org/trunk@32584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 15:32:26 +00:00
Scott Taylor ea89aeee0b Fix doc blocks for `option.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32613


git-svn-id: http://core.svn.wordpress.org/trunk@32583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 22:17:25 +00:00
Scott Taylor cb0b0b109d Fix doc blocks for `nav-menu*.php` files. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32612


git-svn-id: http://core.svn.wordpress.org/trunk@32582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 22:10:25 +00:00
Scott Taylor 4d26d999ce Fix doc blocks for `ms-*.php` files. 
A few functions can return a conditional instead of an `if`/`else` of `true`/`false`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32611


git-svn-id: http://core.svn.wordpress.org/trunk@32581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 21:51:31 +00:00
Scott Taylor cae2415562 Fix doc blocks for `meta.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32610


git-svn-id: http://core.svn.wordpress.org/trunk@32580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 19:33:25 +00:00
Scott Taylor 4bf8e158ec Fix doc blocks for `media*.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32609


git-svn-id: http://core.svn.wordpress.org/trunk@32579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 19:23:25 +00:00
Scott Taylor 5845a0c372 Add missing doc blocks to `locale.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32608


git-svn-id: http://core.svn.wordpress.org/trunk@32578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:59:25 +00:00
Scott Taylor 0ba1025d66 Add missing doc blocks to `load.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32607


git-svn-id: http://core.svn.wordpress.org/trunk@32577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:53:27 +00:00
Scott Taylor bf16064448 Fix doc blocks to `link-template.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32606


git-svn-id: http://core.svn.wordpress.org/trunk@32576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:44:25 +00:00
Scott Taylor 2787e0080a Add missing doc blocks to `l10n.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32605


git-svn-id: http://core.svn.wordpress.org/trunk@32575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:13:25 +00:00
Boone Gorges 8f9a7c4f83 Improve unit tests for `wp_unique_post_slug()`. 
See #5305.
Built from https://develop.svn.wordpress.org/trunk@32604


git-svn-id: http://core.svn.wordpress.org/trunk@32574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:08:24 +00:00
Scott Taylor 4b24007353 Add missing doc blocks to `kses.php` - also fix some unfortunate whitespace issues in related funcs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32603


git-svn-id: http://core.svn.wordpress.org/trunk@32573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:06:24 +00:00
Weston Ruter 7792b5c942 Add support for `WP_Widget::get_settings()` returning `ArrayIterator`/`ArrayObject` instances. 
Plugins can use `pre_option_widget_{$id_base}` filters to return `ArrayIterator`/`ArrayObject` instances instead of primitive arrays. This makes possible for widget instance data to be drawn from somewhere else than `wp_options`, such as a custom post type.

Add unit tests for widgets.

Fixes #32474.


Built from https://develop.svn.wordpress.org/trunk@32602


git-svn-id: http://core.svn.wordpress.org/trunk@32572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 16:51:27 +00:00
Weston Ruter 0f5e6d2825 Fix wp_send_json_error() response for update-widget Ajax request, to return error code instead of error message, as the WP_Error objects are instantiated with codes and the messages are empty. 
Fixes #32496.


Built from https://develop.svn.wordpress.org/trunk@32601


git-svn-id: http://core.svn.wordpress.org/trunk@32571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 22:09:25 +00:00
Scott Taylor 19b8ef0c92 `get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:59:25 +00:00
Scott Taylor 053790537f Cleanup doc blocks in `http.php`. 
In the few functions that used `$objFetchSite` instead of `$http`: use the `$http` naming, which is more civilized.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32599


git-svn-id: http://core.svn.wordpress.org/trunk@32569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:32:27 +00:00
Scott Taylor 82f5d2e9b5 Cleanup doc blocks in `general-template.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32598


git-svn-id: http://core.svn.wordpress.org/trunk@32568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:18:26 +00:00
Scott Taylor bbe2301960 Cleanup the use of `$wp_styles` global in `functions.wp-styles.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32597


git-svn-id: http://core.svn.wordpress.org/trunk@32567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 16:35:24 +00:00
Scott Taylor ebd7fe8a2f Cleanup the use of `$wp_scripts` global in `functions.wp-scripts.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32596


git-svn-id: http://core.svn.wordpress.org/trunk@32566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 16:24:25 +00:00
Scott Taylor 89a6ace623 Add missing doc blocks to `wp-includes/functions.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32595


git-svn-id: http://core.svn.wordpress.org/trunk@32565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 16:11:25 +00:00
Boone Gorges 51a892f975 Pass the original `$user_id` variable to the filter in `get_the_author_meta()`. 
Props dlh, chriscct7.
Fixes #32481.
Built from https://develop.svn.wordpress.org/trunk@32594


git-svn-id: http://core.svn.wordpress.org/trunk@32564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 13:06:25 +00:00
Ella Iseulde Van Dorpe 677c3e53bb Link modal: reset search results appropriately 
Reset the search results when the input field is emptied with the
browser's "clear" button inside that field.

Fixes #32174.

Built from https://develop.svn.wordpress.org/trunk@32593


git-svn-id: http://core.svn.wordpress.org/trunk@32563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:41:25 +00:00
Ella Iseulde Van Dorpe 6e0e924de9 TinyMCE: wpeditimage: trim class 
Don't add extra spaces to classes. It causes some tests in the TinyMCE QUnit test suite to fail.

Fixes #31764.

Built from https://develop.svn.wordpress.org/trunk@32592


git-svn-id: http://core.svn.wordpress.org/trunk@32562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:35:28 +00:00
Drew Jaynes 4c37f68b79 Fix inline documentation syntax in `wp_xmlrpc_server`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:25:25 +00:00
Scott Taylor bd8fafea54 Use `void` instead of `null` where appropriate when pipe-delimiting `@return` types. If a `@return` only contains `void`, remove it. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:40:25 +00:00
Scott Taylor 876918dc53 Add missing doc blocks to `comment-template.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32567


git-svn-id: http://core.svn.wordpress.org/trunk@32537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:19:24 +00:00
Scott Taylor 451914addb Add missing doc blocks to `class.wp-(scripts|styles).php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32566


git-svn-id: http://core.svn.wordpress.org/trunk@32536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:05:26 +00:00
Drew Jaynes 459ccb0d8b Add missing or incomplete argument and return descriptions for `wp_xmlrpc_server->wp_editPost()`. 
Also includes many small syntax fixes for inline documentation throughout the file.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@32565


git-svn-id: http://core.svn.wordpress.org/trunk@32535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:47:25 +00:00
Drew Jaynes 2bebcf4c39 Add missing parameter and return descriptions to the DocBlock for `wp_xmlrpc_server->_convert_date_gmt()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32564


git-svn-id: http://core.svn.wordpress.org/trunk@32534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:41:24 +00:00
Drew Jaynes d94d97eab6 Add missing parameter and return descriptions to the DocBlock for `wp_xmlrpc_server->_convert_date()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32563


git-svn-id: http://core.svn.wordpress.org/trunk@32533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:40:24 +00:00
Drew Jaynes 9f73a3351f Fix inline documentation syntax in the DocBlock for `wp_xmlrpc_server->_prepare_taxonomy()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32562


git-svn-id: http://core.svn.wordpress.org/trunk@32532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:38:25 +00:00
Drew Jaynes 8aa163e65a Fix some inline documentation syntax in the DocBlock for `wp_xmlrpc_server->minimum_args()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32561


git-svn-id: http://core.svn.wordpress.org/trunk@32531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:37:26 +00:00
Drew Jaynes ebe60d1fc4 Use a valid parameter type of string for the `$name` parameter in the `xmlrpc_call` hook docs. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32560


git-svn-id: http://core.svn.wordpress.org/trunk@32530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:36:26 +00:00
Drew Jaynes 18066945ae Add missing argument descriptions for the `$args` hash notation in `wp_xmlrpc_server->wp_getUsersBlogs()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32559


git-svn-id: http://core.svn.wordpress.org/trunk@32529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:33:27 +00:00
Drew Jaynes c76493d29b Properly notate the inline link to the `xmlrpc_blog_options` filter in the description for `wp_xmlrpc_server->initialise_blog_option_info()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@32558


git-svn-id: http://core.svn.wordpress.org/trunk@32528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:30:26 +00:00
Drew Jaynes ed0421e7de Add a proper return description for the `wp_xmlrpc_server->addTwoNumbers()` method. 
See [30181]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32557


git-svn-id: http://core.svn.wordpress.org/trunk@32527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:26:26 +00:00
Drew Jaynes 7a93dda2d2 Add proper descriptions for the `$methods`, `$blog_options`, and `$error` properties in `wp_xmlrpc_server`. 
See [30181]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32556


git-svn-id: http://core.svn.wordpress.org/trunk@32526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:23:25 +00:00
Drew Jaynes 7a7df47087 Add a proper description comment for the `WP_Image_Editor_Imagick->$image` property. 
See [30180]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32555


git-svn-id: http://core.svn.wordpress.org/trunk@32525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:20:24 +00:00
Drew Jaynes a94c16f334 Add a proper description comment for the `WP_Image_Editor_GD->$image` property. 
See [30180]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32554


git-svn-id: http://core.svn.wordpress.org/trunk@32524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:10:28 +00:00
Boone Gorges 10dd80cc61 Introduced `$field` argument to `get_term_link()`. 
This new argument allows developers to specify which term field should be
matched by the value of the `$term` parameter (in particular, 'name' and
'term_taxonomy_id' are now supported).

Props sudar, mordauk.
Fixes #14156.
Built from https://develop.svn.wordpress.org/trunk@32553


git-svn-id: http://core.svn.wordpress.org/trunk@32523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 18:29:26 +00:00
Boone Gorges 0fa7bf9cb4 Unit tests for `get_term_link()`. 
See #14156.
Built from https://develop.svn.wordpress.org/trunk@32552


git-svn-id: http://core.svn.wordpress.org/trunk@32522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 18:13:24 +00:00
Scott Taylor f217f8c5d2 Add missing doc blockss in `class-wp.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32551


git-svn-id: http://core.svn.wordpress.org/trunk@32521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 20:05:25 +00:00
Scott Taylor ecf4c668b3 Upgrade the doc blocks in `class-wp-xmlrpc-server.php`. Rehabilitate some unfortunate use of tabbing. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32550


git-svn-id: http://core.svn.wordpress.org/trunk@32520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 19:37:24 +00:00
Scott Taylor c8a224c48e Cleanup missing doc blocks for `class-wp-walker.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32549


git-svn-id: http://core.svn.wordpress.org/trunk@32519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 17:59:25 +00:00
Drew Jaynes e90a327694 Add a missing `@since` version to a function introduced in [32541]. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32548


git-svn-id: http://core.svn.wordpress.org/trunk@32518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 17:38:25 +00:00
Scott Taylor 1b960d56b6 Add missing doc blocks to `class-wp-theme.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32547


git-svn-id: http://core.svn.wordpress.org/trunk@32517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 17:31:27 +00:00
Scott Taylor bf43be3e9e Add missing doc blocks to `wp-image-editor*.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32546


git-svn-id: http://core.svn.wordpress.org/trunk@32516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 06:18:25 +00:00
Scott Taylor af7a017f46 When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32545


git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:47:25 +00:00
Scott Taylor 1fa7958fe8 Clean up doc blocks for `class-wp-embed.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32544


git-svn-id: http://core.svn.wordpress.org/trunk@32514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:15:26 +00:00
Scott Taylor 94f29f27a1 Clean up `@global` doc blocks/imports for `class-wp-editor.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32543


git-svn-id: http://core.svn.wordpress.org/trunk@32513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:10:24 +00:00
Scott Taylor 082bfab426 Clean up `@global` doc blocks/imports for `class-wp-customizer-*.php` and friends. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32542


git-svn-id: http://core.svn.wordpress.org/trunk@32512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:06:25 +00:00
Scott Taylor 1b52916239 Create a function, `wp_roles()`, to DRY the inline instantiation of the `$wp_roles` global. 
Add missing doc blocks for `capabilities.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32541


git-svn-id: http://core.svn.wordpress.org/trunk@32511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:47:24 +00:00
Scott Taylor 3d130ba909 Add missing doc blocks for `canonical.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32540


git-svn-id: http://core.svn.wordpress.org/trunk@32510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:26:26 +00:00
Scott Taylor ebd3201268 Add/standardize missing doc blocks for `cache.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32539


git-svn-id: http://core.svn.wordpress.org/trunk@32509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:24:26 +00:00
Scott Taylor 5c6ffc4dd6 Add missing doc blocks to `author-template.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32538


git-svn-id: http://core.svn.wordpress.org/trunk@32508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:14:24 +00:00
Scott Taylor 83dd461b2f Add missing doc blocks to `admin-bar.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32537


git-svn-id: http://core.svn.wordpress.org/trunk@32507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:00:26 +00:00
Scott Taylor 3a5f584109 Add missing doc blocks to `class-wp-editor.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32536


git-svn-id: http://core.svn.wordpress.org/trunk@32506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 03:52:27 +00:00
Scott Taylor b2bbbf9759 In `class-wp-customize-*`, clarify/add some `@param`/`@return` blocks. Disambiguate some functions that are trying to return the `void` response of another function they call internally. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32535


git-svn-id: http://core.svn.wordpress.org/trunk@32505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 22:05:24 +00:00
Scott Taylor f7098c8c2e In `class-wp-admin-bar.php`, clarify/add some doc blocks. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32534


git-svn-id: http://core.svn.wordpress.org/trunk@32504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:39:24 +00:00
Scott Taylor 3c24a2b32b In `class-oembed.php`, clarify/add some `return` docs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32533


git-svn-id: http://core.svn.wordpress.org/trunk@32503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:31:27 +00:00
Scott Taylor ed4aafa692 In `category.php`: 
* Clarify some `return` docs.
* In `_make_cat_compat()`, ensure that `WP_Error` is not decorated

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32532


git-svn-id: http://core.svn.wordpress.org/trunk@32502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:18:24 +00:00
Scott Taylor 27522d1c00 In `category-template.php`: 
* Clarify/add some `return` docs.
* In `walk_category_tree()` and `walk_category_dropdown_tree()`, make behavior consistent and don't pass `$walker` by-reference - it is no longer necessary to do that with object instances.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32531


git-svn-id: http://core.svn.wordpress.org/trunk@32501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:05:24 +00:00
Scott Taylor e724ed2b04 In `capabilities.php`, clarify/add some `return` docs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32530


git-svn-id: http://core.svn.wordpress.org/trunk@32500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 20:47:26 +00:00
Scott Taylor 3f32bf7bc0 In `canonical.php`: 
* Clarify some docs
* `redirect_canonical()` inconsistently returns `null` or `false` when bailing - can simply return.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32529


git-svn-id: http://core.svn.wordpress.org/trunk@32499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 20:30:25 +00:00
Scott Taylor 9b3271f635 In `cache.php`, clarify some `return` docs. Some `WP_Object_Cache` methods return `void`, so those wrapper functions don't need to return at all. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32528


git-svn-id: http://core.svn.wordpress.org/trunk@32498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 20:22:24 +00:00
Scott Taylor e4c19c591f In `bookmark.php`, clarify some `return` docs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32527


git-svn-id: http://core.svn.wordpress.org/trunk@32497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 20:13:25 +00:00
Scott Taylor 04554bc30d In `author-template.php`, clarify/add some `return` docs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32526


git-svn-id: http://core.svn.wordpress.org/trunk@32496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 20:10:26 +00:00
Scott Taylor c92608aebd In `admin-bar.php`, most functions simply return when a conditional is not met. `wp_admin_bar_render()` shouldn't explicitly return `false`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32525


git-svn-id: http://core.svn.wordpress.org/trunk@32495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 20:09:24 +00:00
Boone Gorges 9d54232e39 Streamline support for multiple post types in `get_posts_by_author_sql()`. 
* Don't accept a comma-separated list, only a single post type or an array of post types. This is easier to document.
* Add changelog entries to all calling functions.

Props DrewAPicture.
Fixes #32243.
Built from https://develop.svn.wordpress.org/trunk@32524


git-svn-id: http://core.svn.wordpress.org/trunk@32494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 19:49:29 +00:00
Boone Gorges 67c935ad9c Support multiple post types in `count_user_posts()` and other functions that use `get_posts_by_author_sql()`. 
Props nikonratm.
Fixes #32243.
Built from https://develop.svn.wordpress.org/trunk@32523


git-svn-id: http://core.svn.wordpress.org/trunk@32493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 18:43:27 +00:00
Helen Hou-Sandí 248a49c930 Updates: Use the warning color for the backup notice, as it's not a success message. 
props paulwilde.
fixes #32241.

Built from https://develop.svn.wordpress.org/trunk@32522


git-svn-id: http://core.svn.wordpress.org/trunk@32492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 18:10:25 +00:00
Aaron Jorbin 2dff825af7 In List Tables, ensure sorting indicator is visible on focus 
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose. 

Happy #GAAD

Props afercia
Fixes #32189


Built from https://develop.svn.wordpress.org/trunk@32521


git-svn-id: http://core.svn.wordpress.org/trunk@32491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 18:05:26 +00:00
Boone Gorges 33b99991a8 In `sanitize_option()`, pass the unsanitized `$value` to the filter. 
Props simonwheatley, MikeHansenMe.
Fixes #26199.
Built from https://develop.svn.wordpress.org/trunk@32520


git-svn-id: http://core.svn.wordpress.org/trunk@32490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 18:00:26 +00:00
Boone Gorges 33b61a9244 Add tests for `check_comment()`. 
Props CalEvans, rachelbaker.
Fixes #31108.
Built from https://develop.svn.wordpress.org/trunk@32519


git-svn-id: http://core.svn.wordpress.org/trunk@32489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-20 19:09:25 +00:00
John Blackbourn cde30a03aa Use the available user and blog factories in the `Tests_Multisite_Option::test_with_another_site()` test. 
Fixes #32404

Built from https://develop.svn.wordpress.org/trunk@32518


git-svn-id: http://core.svn.wordpress.org/trunk@32488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-20 19:03:26 +00:00
Scott Taylor a69b8b3b91 In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32517


git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 20:50:27 +00:00
Scott Taylor 5a3dc2a371 In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32516


git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 20:46:25 +00:00
Scott Taylor 45d897d0e7 In `wpdb::load_col_info()`, don't fetch the number of fields in the result row on each iteration of the `for` loop. It can be stored in a var and referenced. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32515


git-svn-id: http://core.svn.wordpress.org/trunk@32485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 20:30:27 +00:00
Jeremy Felt 2a2e976501 Move network update submenu items to the Network Dashboard menu item 
Provides parity with the placement of the "Updates" submenu item in single site.

props Ipstenu.
fixes #32431.

Built from https://develop.svn.wordpress.org/trunk@32514


git-svn-id: http://core.svn.wordpress.org/trunk@32484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 17:00:29 +00:00