4848a09b35
I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
...
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.
Fixes #43523 .
Built from https://develop.svn.wordpress.org/trunk@42827
git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 16:44:34 +00:00
fab939595d
Docs: Fix typo in a comment in `WP_Community_Events::trim_events()`.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42826
git-svn-id: http://core.svn.wordpress.org/trunk@42656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 10:35:31 +00:00
15e969be8d
Docs: Add missing brace in `auto_update_{$type}` filter DocBlock.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42825
git-svn-id: http://core.svn.wordpress.org/trunk@42655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 10:30:33 +00:00
8bab745586
General: In `wp_debug_backtrace_summary()`, check if `$call['args']` is defined to avoid a PHP notice.
...
Props paulschreiber.
Fixes #31215 .
Built from https://develop.svn.wordpress.org/trunk@42824
git-svn-id: http://core.svn.wordpress.org/trunk@42654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 17:31:32 +00:00
ba7b8cd8a0
Accessibility improvements for the Privacy Tools screen.
...
Propr afercia.
See #43435 .
Built from https://develop.svn.wordpress.org/trunk@42823
git-svn-id: http://core.svn.wordpress.org/trunk@42653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 14:01:31 +00:00
f700ac6075
Docs: Use `WP_Term` instead of generic `object` type for the `$tag` parameter in `wp-admin/edit-tag-form.php` hook docs.
...
Props xhezairi, ocean90.
Fixes #43507 .
Built from https://develop.svn.wordpress.org/trunk@42822
git-svn-id: http://core.svn.wordpress.org/trunk@42652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 02:01:29 +00:00
4e9c3f916f
Docs: Fix typos in `_wp_emoji_list()` description.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42821
git-svn-id: http://core.svn.wordpress.org/trunk@42651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 01:50:30 +00:00
0b799bd6a7
General: In `wp_debug_backtrace_summary()`, capture hook name for `do_action_ref_array()` and `apply_filters_ref_array()` as well.
...
Props Rarst.
Fixes #43488 .
Built from https://develop.svn.wordpress.org/trunk@42820
git-svn-id: http://core.svn.wordpress.org/trunk@42650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-10 00:05:31 +00:00
c46a518330
Tests: Skip symlinked theme file tests if `symlink()` is not available, e.g. in PHP 5.2.x on Windows.
...
See #43508 .
Built from https://develop.svn.wordpress.org/trunk@42819
git-svn-id: http://core.svn.wordpress.org/trunk@42649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:48:30 +00:00
e70caa19a1
Media: Fix image cropping on touch screen devices.
...
* In initCrop, handle touch events in addition to mouse events.
* In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.
Props yahil, alexgso, joemcgill.
Fixes #41242 .
Built from https://develop.svn.wordpress.org/trunk@42818
git-svn-id: http://core.svn.wordpress.org/trunk@42648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:27:31 +00:00
6751be3561
Customizer menus: correct oversized viewport after dragging menu items.
...
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.
Props kwonye.
Fixes #36884 .
Built from https://develop.svn.wordpress.org/trunk@42817
git-svn-id: http://core.svn.wordpress.org/trunk@42647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:06:30 +00:00
d1d60bb22c
Themes: Revert [42788] as it breaks a lot of things.
...
See #43228
Built from https://develop.svn.wordpress.org/trunk@42816
git-svn-id: http://core.svn.wordpress.org/trunk@42646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:00:31 +00:00
63dd79d908
Respect the commenter decision when they have checked the checkbox to consent to cookies, and keep it checked when they reload the page or post another comment.
...
See #43436 .
Built from https://develop.svn.wordpress.org/trunk@42815
git-svn-id: http://core.svn.wordpress.org/trunk@42645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 15:57:30 +00:00
b93dfd3571
Add Privacy Tools admin page under the Tools menu.
...
Props allendav, xkon, azaozz.
See #43435 .
Built from https://develop.svn.wordpress.org/trunk@42814
git-svn-id: http://core.svn.wordpress.org/trunk@42644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 15:04:33 +00:00
051dd178b3
Tests: Skip symlinked theme file tests if the links could not be created.
...
Fixes #43508 .
Built from https://develop.svn.wordpress.org/trunk@42812
git-svn-id: http://core.svn.wordpress.org/trunk@42642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 01:10:31 +00:00
127ecc530c
Accessibility: Underline the links in the Plugins descriptions and update notices.
...
Links within blocks and lines of text should always be underlined.
Props Travel_girl, chetan200891, Shital Patel.
Fixes #42647 .
Built from https://develop.svn.wordpress.org/trunk@42810
git-svn-id: http://core.svn.wordpress.org/trunk@42640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:20:30 +00:00
eaf4f346fd
Docs: Improve documentation for meta capability filters.
...
Remove self-references, correct parameter names and descriptions.
Props milana_cap, ocean90, SergeyBiryukov.
Fixes #43504 .
Built from https://develop.svn.wordpress.org/trunk@42809
git-svn-id: http://core.svn.wordpress.org/trunk@42639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:19:30 +00:00
320a05019a
Accessibility: Themes: use `aria-current` for the `Walker_Nav_Menu` current link.
...
The `aria-current` attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the
introduction in core of `aria-current` after [42440], [41683], [41359], and [41371].
Props williampatton, chetan200891, sami.keijonen.
Fixes #43191 .
Built from https://develop.svn.wordpress.org/trunk@42808
git-svn-id: http://core.svn.wordpress.org/trunk@42638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 21:31:30 +00:00
48077799d9
Accessibility: Insert Link modal: Improve keyboard interaction.
...
Avoids to change the selected link when using the Shift and Up/Down arrow keys
to select text in the form fields.
Fixes #43253 .
Built from https://develop.svn.wordpress.org/trunk@42807
git-svn-id: http://core.svn.wordpress.org/trunk@42637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 20:58:30 +00:00
996efe8f6e
Filesystem API: Avoid an infinite loop in `wp_mkdir_p()` when trying to determine the parent folder with `open_basedir` restriction in effect.
...
Props soulseekah, 1265578519-1.
Fixes #43417 .
Built from https://develop.svn.wordpress.org/trunk@42801
git-svn-id: http://core.svn.wordpress.org/trunk@42631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 19:32:30 +00:00
c1897645a2
General: In `wp_debug_backtrace_summary()`, normalize paths before replacement for better cross–platform compatibility.
...
Props Rarst.
Fixes #43501 .
Built from https://develop.svn.wordpress.org/trunk@42800
git-svn-id: http://core.svn.wordpress.org/trunk@42630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 17:08:31 +00:00
902232ffec
Tests: Correct assertion in `Tests_WP_Customize_Setting::test_constructor_with_args()`.
...
Props jipmoors.
See #30988 , #43218 .
Built from https://develop.svn.wordpress.org/trunk@42799
git-svn-id: http://core.svn.wordpress.org/trunk@42629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 16:38:30 +00:00
e2707d57f9
Docs: Improve JSDoc for `wp-includes/js/media/controllers/gallery-add.js`.
...
Props boblinthorst, bramheijmink, manuelaugustin, ireneyoast, igorsch, nataliashitova.
Fixes #43500 .
Built from https://develop.svn.wordpress.org/trunk@42798
git-svn-id: http://core.svn.wordpress.org/trunk@42628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 16:25:34 +00:00
fdc4f68678
Docs: Remove copy/pasted default value description for `$type` in `WP_Customize_Manager::add_setting()`.
...
Props DannyCooper.
Fixes #43497 .
Built from https://develop.svn.wordpress.org/trunk@42797
git-svn-id: http://core.svn.wordpress.org/trunk@42627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 13:06:33 +00:00
ef33f565b1
Docs: Improve documentation for `add_meta_boxes` and `do_meta_boxes` actions.
...
Props danieltj, johnbillion, SergeyBiryukov.
Fixes #43229 .
Built from https://develop.svn.wordpress.org/trunk@42796
git-svn-id: http://core.svn.wordpress.org/trunk@42626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 03:57:31 +00:00
24f43065b9
Docs: Document globals in `wp-admin/revision.php` as `@global` instead of `@param`.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42795
git-svn-id: http://core.svn.wordpress.org/trunk@42625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 03:53:34 +00:00
ffedf3d752
Accessibility: Widgets: Make the "Available Widgets" section operable with a keyboard.
...
For a number of years, the "Available Widgets" section has been off-limits for
keyboard users. Now it can be used also with the keyboard. This change introduces
also some improvements for assistive technologies.
- makes the widget toggles focusable and adds an `aria-expanded` attribute to indicate their state
- improves the toggles labelling to clarify context (add/edit)
- changes the controls to choose a sidebar from list items to buttons
- adds an `aria-label` attribute to the buttons to clarify their purpose
- adds an `aria-pressed` attribute to the buttons to indicate which one is selected
- improves color contrast of the selected button
- uses a `wp.a11y.speak()` message to announce to screen reader users when a widget has been added to a sidebar
- moves focus back to the toggle button when closing a widget
See #40677 .
Built from https://develop.svn.wordpress.org/trunk@42794
git-svn-id: http://core.svn.wordpress.org/trunk@42624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 22:27:31 +00:00
e34999f4aa
Accessibility: Networks and Sites: mark the New Site required form fields as required.
...
Also, adds an `aria-describedby` attribute to associate the Admin Email field with its description.
Props dipesh.kakadiya, jackreichert, rianrietveld.
Fixes #37331 .
Built from https://develop.svn.wordpress.org/trunk@42793
git-svn-id: http://core.svn.wordpress.org/trunk@42623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 19:41:33 +00:00
51b0a3cd28
Media: Correctly allow changing PDF thumbnail crop value.
...
Corrects logic that keeping plugins from setting crop value of intermediate image sizes for rendered PDFs.
Adds test.
Props leemon, SergeyBiryukov, chetan200891, birgire.
Fixes #43226 .
Built from https://develop.svn.wordpress.org/trunk@42792
git-svn-id: http://core.svn.wordpress.org/trunk@42622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 01:19:31 +00:00
791b11bc3f
Add a method to confirm user requests by email. First run.
...
Props mikejolley.
See #43443 .
Built from https://develop.svn.wordpress.org/trunk@42791
git-svn-id: http://core.svn.wordpress.org/trunk@42621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 23:47:30 +00:00
6a4b2a022a
Accessibility: Make the Widgets screen "Enable accessibility mode" link more discoverable.
...
For a number of years, the link to the Widgets screen "Accessibility mode" lived
in the Screen Options panel, hidden by default. Many users, including assistive
technologies users, weren't able to find it or even aware it existed. By bringing
the link in the main screen, visible by default, this change makes the
"Accessibility mode" easily discoverable for everyone.
Props chetan200891, antonioeatgoat.
Fixes #42778 .
Built from https://develop.svn.wordpress.org/trunk@42790
git-svn-id: http://core.svn.wordpress.org/trunk@42620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 17:21:33 +00:00
6c09e79cc5
Database: Add the query start time to logged query data.
...
This allows debugging plugins to plot the time at which queries were executed.
Props Rarst for initial patch.
Fixes #43315
Built from https://develop.svn.wordpress.org/trunk@42789
git-svn-id: http://core.svn.wordpress.org/trunk@42619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 22:54:35 +00:00
ea6360b47c
Themes: Ensure the theme roots cache is cleared when registering a theme directory.
...
Props soulseekah, johnbillion
Fixes #43228
Built from https://develop.svn.wordpress.org/trunk@42788
git-svn-id: http://core.svn.wordpress.org/trunk@42618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 22:14:30 +00:00
c9b07e6411
Docs: Standardise and correct documentation relating to parameters which accept plugin names.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42787
git-svn-id: http://core.svn.wordpress.org/trunk@42617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 21:50:31 +00:00
087b52dced
Upgrade/Install: Fix the format of the `upgrader_process_complete` actions after [42343].
...
More info: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1323
See #41057 , #42505
Built from https://develop.svn.wordpress.org/trunk@42786
git-svn-id: http://core.svn.wordpress.org/trunk@42616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 21:44:30 +00:00
9842bd6d24
Accessibility: Change the "Show / Hide dismissed updates" link to a button.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Also, adds an `aria-expanded` attribute to communicate the expandable panel state
and improves the buttons spacing.
Props Cheffheid, audrasjb, afercia.
Fixes #38674 .
Built from https://develop.svn.wordpress.org/trunk@42785
git-svn-id: http://core.svn.wordpress.org/trunk@42615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:50:30 +00:00
64634898c2
Accessibility: Change the media upload "Dismiss error" link to a button.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Props Cheffheid, audrasjb.
Fixes #38671 .
Built from https://develop.svn.wordpress.org/trunk@42784
git-svn-id: http://core.svn.wordpress.org/trunk@42614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:33:33 +00:00
084b48e1ba
Help/About: Adjust capability checks formatting in help text on Dashboard screen for readability and consistency with similar checks in other files.
...
See #43472 .
Built from https://develop.svn.wordpress.org/trunk@42783
git-svn-id: http://core.svn.wordpress.org/trunk@42613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:32:30 +00:00
24f13abf63
Help/About: Remove popular plugins feed reference from help text on Dashboard screen, no longer relevant since [40607].
...
Props denisco.
See #43472 .
Built from https://develop.svn.wordpress.org/trunk@42782
git-svn-id: http://core.svn.wordpress.org/trunk@42612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:17:31 +00:00
31a3083c28
Help/About: Update "WordPress News" widget references in help text and inline documentation.
...
Props monikarao, denisco.
Fixes #43400 , #43472 .
Built from https://develop.svn.wordpress.org/trunk@42781
git-svn-id: http://core.svn.wordpress.org/trunk@42611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:04:31 +00:00
5596017878
Media: Recognize `.ico` files as displayable images on PHP 5.3+ and allow attachment meta data to be generated for them.
...
Props remyvv, Guido07111975.
Fixes #43458 .
Built from https://develop.svn.wordpress.org/trunk@42780
git-svn-id: http://core.svn.wordpress.org/trunk@42610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 01:03:31 +00:00
e451dfac9e
Help/About: Correct the number of most recent drafts in help text on Dashboard screen.
...
Props denisco.
Fixes #43471 .
Built from https://develop.svn.wordpress.org/trunk@42779
git-svn-id: http://core.svn.wordpress.org/trunk@42609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 00:24:30 +00:00
3385d5b2de
Docs: Expand `delete_theme()` return value, fix typo in `delete_plugins()` return value.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42778
git-svn-id: http://core.svn.wordpress.org/trunk@42608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 22:07:29 +00:00
58592b64dc
Docs: Use consistent description for `$wp_filesystem` global.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42777
git-svn-id: http://core.svn.wordpress.org/trunk@42607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 21:58:30 +00:00
179bec1306
Docs: Clarify return values and improve DocBlock formatting for `verify_file_md5()`, `unzip_file()`, `_unzip_file_ziparchive()`, `_unzip_file_pclzip()`, `copy_dir()`, `WP_Filesystem()`.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42776
git-svn-id: http://core.svn.wordpress.org/trunk@42606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 21:43:30 +00:00
3c8ae81018
Docs: Clarify `download_url()` return value, improve DocBlock formatting.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42775
git-svn-id: http://core.svn.wordpress.org/trunk@42605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 19:50:31 +00:00
7b7ca428f3
Docs: Clarify that `wp_update_user()` accepts an array as `$userdata` argument.
...
Props nextendweb.
Fixes #43051 .
Built from https://develop.svn.wordpress.org/trunk@42774
git-svn-id: http://core.svn.wordpress.org/trunk@42604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 18:12:31 +00:00
86c3c7e1c9
Filesystem API: Allow `download_url()` to return the response code and body on error as an additional `WP_Error` object data.
...
The error response body size is limited to 1 KB by default to avoid taking up too much memory. The size can be increased using `download_url_error_max_body_size` filter.
Props soulseekah, campusboy1987, mihdan, SergeyBiryukov.
Fixes #43329 .
Built from https://develop.svn.wordpress.org/trunk@42773
git-svn-id: http://core.svn.wordpress.org/trunk@42603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 17:14:31 +00:00
8ae59374f3
Add a checkbox to the comment form so logged out users can opt-out of commenter cookies.
...
Props lakenh, xkon, birgire, azaozz.
See #43436 .
Built from https://develop.svn.wordpress.org/trunk@42772
git-svn-id: http://core.svn.wordpress.org/trunk@42602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 16:41:33 +00:00
d950c75307
Import: Avoid counting an uncountable type when reading arguments passed to a script.
...
Props josephscott.
Fixes #42898 .
Built from https://develop.svn.wordpress.org/trunk@42771
git-svn-id: http://core.svn.wordpress.org/trunk@42601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 17:17:31 +00:00
de8936588c
Add pre-save content filter to make target=_blank always secure.
...
Props notnownikki, iseulde, azaozz
Fixes #43187
Built from https://develop.svn.wordpress.org/trunk@42770
git-svn-id: http://core.svn.wordpress.org/trunk@42600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 14:42:31 +00:00
74cb5936fc
Docs: Remove trailing whitespace in `wp-includes/post.php`.
...
Built from https://develop.svn.wordpress.org/trunk@42769
git-svn-id: http://core.svn.wordpress.org/trunk@42599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 10:02:33 +00:00
35ad9e9efc
Allow `LIKE` queries against the 'key' value in meta queries.
...
The new `compare_key=LIKE` parameter works in conjunction with `key` in a
similar way to the `compare=LIKE` and `value`: by doing a "compares" `LIKE`
query. This allows developers to do partial matches against keys when
doing meta queries.
Props mariovalney, chasewg.
Fixes #42409 .
Built from https://develop.svn.wordpress.org/trunk@42768
git-svn-id: http://core.svn.wordpress.org/trunk@42598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-01 04:03:33 +00:00
d2d64f13c7
Accessibility: Change the comments "Quick Edit" and "Reply" links to buttons.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Props Cheffeid, audrasjb, afercia.
See #43382 , #38677 .
Fixes #43376 .
Built from https://develop.svn.wordpress.org/trunk@42767
git-svn-id: http://core.svn.wordpress.org/trunk@42597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 22:36:34 +00:00
e786f9eb91
Docs: Mark `WP_Http::_dispatch_request()` as deprecated. It's no longer used since [37428].
...
Fixes #43414 .
Built from https://develop.svn.wordpress.org/trunk@42766
git-svn-id: http://core.svn.wordpress.org/trunk@42596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:48:30 +00:00
b0ddd7ca43
Docs: Add description for `register_admin_color_schemes()`.
...
Props terriann, danieltj.
Fixes #42779 .
Built from https://develop.svn.wordpress.org/trunk@42765
git-svn-id: http://core.svn.wordpress.org/trunk@42595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:28:31 +00:00
7d8809c98b
XML-RPC: Unify permission error messages in `wp_xmlrpc_server`.
...
Props ramiy.
Fixes #42266 .
Built from https://develop.svn.wordpress.org/trunk@42764
git-svn-id: http://core.svn.wordpress.org/trunk@42594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:19:31 +00:00
acfced54f0
External Libraries: Test for MEjs files in `src` instead of `build`.
...
The `build` task doesn't get run during TravisCI jobs, so the `build` folder doesn't exist in that context. Because of that, the test added in r42762 was failling.
Checking for the files in `src` instead achieves the same goal as that commit, but should pass in Travis.
See #43101
See https://wordpress.slack.com/archives/C02RQBWTW/p1519742993000615
Built from https://develop.svn.wordpress.org/trunk@42763
git-svn-id: http://core.svn.wordpress.org/trunk@42593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 00:26:31 +00:00
f71c4f38c3
External Libraries: Test that MediaElement SWF files remain deleted.
...
The files were removed from Core in r42462 because they're no longer necessary, and have a history of security issues. They remain upstream, though, so this test makes it explicitly clear that they should not be added back in the future without careful consideration and discussion with the Security team.
`Tests_Admin_IncludesUpdateCore::test_new_files_are_not_in_old_files_array_compiled()` would already catch files with the exact same name, but this test will also catch files with new names, just to be extra cautious.
Props iandunn, ocean90, SergeyBiryukov
Fixes 43101
Built from https://develop.svn.wordpress.org/trunk@42762
git-svn-id: http://core.svn.wordpress.org/trunk@42592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-27 14:38:33 +00:00
0e802a627d
General: Introduce `WP_Error::has_errors()` method and use it where appropriate.
...
Props robdxw, DrewAPicture, SergeyBiryukov.
Fixes #42742 .
Built from https://develop.svn.wordpress.org/trunk@42761
git-svn-id: http://core.svn.wordpress.org/trunk@42591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-27 02:31:31 +00:00
71f206839d
Build/Test Tools: Add `watch:phpunit` task.
...
This allow PHPUnit test groups to run automatically when files are changed, rather than having to be ran manually throughout the development process. This creates a smoother developer experience, and a tighter feedback loop.
Props iandunn, netweb, pento
Fixes #42282
Built from https://develop.svn.wordpress.org/trunk@42760
git-svn-id: http://core.svn.wordpress.org/trunk@42590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-27 00:32:33 +00:00
669f8bb750
Media: Remove unnecessary `aria-required` attribute from legacy (pre-3.5.0) media functions, added in [7888].
...
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.
Props shital-patel, afercia, audrasjb.
Fixes #43415 .
Built from https://develop.svn.wordpress.org/trunk@42759
git-svn-id: http://core.svn.wordpress.org/trunk@42589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 23:10:31 +00:00
d3b2daf490
Comments: Remove unnecessary `aria-required` attribute from `comment_form()`, added with the function in [12810].
...
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.
Props lakenh, afercia, davidakennedy, henry.wright.
Fixes #39045 .
Built from https://develop.svn.wordpress.org/trunk@42758
git-svn-id: http://core.svn.wordpress.org/trunk@42588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 20:50:30 +00:00
666e203f31
Administration: Remove unnecessary capitalization when referencing to plugin/theme editors.
...
Fixes #43072 .
Built from https://develop.svn.wordpress.org/trunk@42757
git-svn-id: http://core.svn.wordpress.org/trunk@42587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 19:35:30 +00:00
a018cdd4e3
Docs: Add missing `@since` entries for functions in `wp-admin/image-edit.php`.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42756
git-svn-id: http://core.svn.wordpress.org/trunk@42586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 18:38:31 +00:00
9cb07ec40e
Taxonomy: Make the "Format" taxonomy name plural, for consistency with other taxonomies.
...
Props afercia, danieltj.
Fixes #43370 .
Built from https://develop.svn.wordpress.org/trunk@42755
git-svn-id: http://core.svn.wordpress.org/trunk@42585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 18:22:31 +00:00
3812402cc7
Docs: Fix typo in `wp.customize.selectiveRefresh.placements()` description.
...
Props Nikschavan.
Fixes #43418 .
Built from https://develop.svn.wordpress.org/trunk@42754
git-svn-id: http://core.svn.wordpress.org/trunk@42584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 17:52:31 +00:00
5cde2018ea
Docs: Remove erroneous period in the description for `esc_html__()`.
...
Props danieltj.
Fixes #43419 .
Built from https://develop.svn.wordpress.org/trunk@42753
git-svn-id: http://core.svn.wordpress.org/trunk@42583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 15:57:32 +00:00
9226691b3c
Docs: Remove erroneous `@static` notation from `WP_Tax_Query::get_sql()`, added in [32627].
...
The method was never used as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42752
git-svn-id: http://core.svn.wordpress.org/trunk@42582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 21:45:30 +00:00
0b45a1e5fa
Docs: Remove erroneous `@static` notation from `WP_Http::_dispatch_request()`, added in [32650].
...
The method was never user as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42751
git-svn-id: http://core.svn.wordpress.org/trunk@42581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 21:35:30 +00:00
bd9cdde1eb
Docs: Remove duplicated DocBlock for `http_response` hook in `WP_Http::_dispatch_request()`.
...
The filter is already documented in `WP_Http::request()`.
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42750
git-svn-id: http://core.svn.wordpress.org/trunk@42580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 21:32:30 +00:00
510feac5bb
Twenty Fourteen: Remove redundant `@access` and `@static` notations from classes.
...
Props birgire.
See #41452 , #42803 , #42505 .
Built from https://develop.svn.wordpress.org/trunk@42749
git-svn-id: http://core.svn.wordpress.org/trunk@42579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:49:30 +00:00
c3738e9617
Docs: Remove `@access` notation from `WP_Taxonomy::$meta_box_sanitize_cb`.
...
See #42505 , #41452 .
Built from https://develop.svn.wordpress.org/trunk@42748
git-svn-id: http://core.svn.wordpress.org/trunk@42578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:38:30 +00:00
b026fde152
Docs: Remove `@static` notations from property DocBlocks in `wp-admin/*` and `wp-includes/*` classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42747
git-svn-id: http://core.svn.wordpress.org/trunk@42577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:32:30 +00:00
08227812a0
Docs: Remove `@static` notations from method DocBlocks in `wp-includes/*` classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42746
git-svn-id: http://core.svn.wordpress.org/trunk@42576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:22:30 +00:00
0fea564b7d
Docs: Remove `@static` notations from method DocBlocks in `wp-admin/*` classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42745
git-svn-id: http://core.svn.wordpress.org/trunk@42575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:06:30 +00:00
de6906a045
Customizer: in menus, reset results when closing the 'add items' panel.
...
Trigger a keyup event when clearing the search field in response to closing the add item panel. The keyup event triggers a search and resets the results. Previously, the search field was cleared while the potentially blank search results were left in place making it impossible to select new menu items.
Props Blair jersyer, aranwer104, afercia.
Fixes #43333 .
Built from https://develop.svn.wordpress.org/trunk@42744
git-svn-id: http://core.svn.wordpress.org/trunk@42574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:48:29 +00:00
b34b1ee061
Tests: Correct a "false positive" assertion in `test_media_handle_upload_ignores_page_parent_for_directory_date()`.
...
Props birgire.
Fixes #42736 .
Built from https://develop.svn.wordpress.org/trunk@42743
git-svn-id: http://core.svn.wordpress.org/trunk@42573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:47:30 +00:00
61e8101442
Tests: Avoid hardcoded domain name in `test_media_handle_upload_uses_post_parent_for_directory_date()`.
...
Props birgire.
See #42736 .
Built from https://develop.svn.wordpress.org/trunk@42742
git-svn-id: http://core.svn.wordpress.org/trunk@42572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:43:30 +00:00
89c9e27fd1
Unit Tests: add a DIR_TESTROOT constant to avoid relative paths.
...
Fix an issue that prevents tests from running correctly when run outside their normal context.
Props PressLabs, johnbillion.
Fixes #40071 .
Built from https://develop.svn.wordpress.org/trunk@42741
git-svn-id: http://core.svn.wordpress.org/trunk@42571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:07:31 +00:00
a299c5c344
Fix eshint error since r42739.
...
Remove a trailing comma in [42739] that was throing a jshint error.
Built from https://develop.svn.wordpress.org/trunk@42740
git-svn-id: http://core.svn.wordpress.org/trunk@42570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:49:30 +00:00
da89d20c39
Media: grid view - correct placeholder positioning during uploads.
...
Preventing contextually created attachments from being added to the grid collection in Attachments.validator. Remove the previous filtering introduced in [41937] which caused the placement issue.
Props lancewillett, Junaidkbr, designsimply, joemcgill.
Fixes #42968 .
Built from https://develop.svn.wordpress.org/trunk@42739
git-svn-id: http://core.svn.wordpress.org/trunk@42569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:41:31 +00:00
4d47bfce41
Coding Standards: Fix code indent in `unescape_invalid_shortcodes()`.
...
Props joelcj91, GaryJ.
Fixes #43346 .
Built from https://develop.svn.wordpress.org/trunk@42738
git-svn-id: http://core.svn.wordpress.org/trunk@42568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:36:30 +00:00
505c2ddb61
Taxonomy: restore TagSearch unit tests and correct deprecated version string.
...
Reverts unit test removal, instead changing them to expect the function to be deprecated.
Correct the version the ajax callback was deprecated.
Amends [42614].
Props dlh, ocean90.
Fixes #38922 .
Built from https://develop.svn.wordpress.org/trunk@42737
git-svn-id: http://core.svn.wordpress.org/trunk@42567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:28:30 +00:00
395667f916
Comments: After [42703], make sure `$args['type']` in `paginate_comments_links()` is always defined.
...
Props anantajitjg.
Fixes #43299 .
Built from https://develop.svn.wordpress.org/trunk@42736
git-svn-id: http://core.svn.wordpress.org/trunk@42566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:08:30 +00:00
35d5163d66
Docs: Correct description for `WP_User::get_role_caps()`.
...
Props thomaswm.
Fixes #43410 .
Built from https://develop.svn.wordpress.org/trunk@42735
git-svn-id: http://core.svn.wordpress.org/trunk@42565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 15:39:30 +00:00
b6229650e0
Themes: Pre-translate theme names on Themes screen before sorting the array, to improve performance and avoid a warning in PHP 5.x.
...
Props bobbingwide, sebastian.pisula.
Fixes #34565 .
Built from https://develop.svn.wordpress.org/trunk@42734
git-svn-id: http://core.svn.wordpress.org/trunk@42564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 13:18:30 +00:00
b12620e798
Build/Test Tools: Remove `vendor` file name entry from `.gitignore`.
...
Props netweb.
Fixes #43411 .
Built from https://develop.svn.wordpress.org/trunk@42733
git-svn-id: http://core.svn.wordpress.org/trunk@42563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 11:30:32 +00:00
0e39cef343
Menus: When checking if a Custom Link matches the current URL to add the `current-menu-item` class, check for decoded URL as well.
...
Props soulseekah, campusboy1987.
Fixes #43401 .
Built from https://develop.svn.wordpress.org/trunk@42732
git-svn-id: http://core.svn.wordpress.org/trunk@42562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-24 13:44:31 +00:00
fc5617e7fe
Administration: Use HTTPS for `dashboard_primary_feed` URL.
...
`dashboard_secondary_feed` is already using HTTPS since [29787].
Props iandunn.
Fixes #40416 .
Built from https://develop.svn.wordpress.org/trunk@42731
git-svn-id: http://core.svn.wordpress.org/trunk@42561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-24 09:30:33 +00:00
cf49eacd62
REST API: Translate the taxonomy visibility description strings.
...
This was missed in [42729].
Props TimothyBlynJacobs.
Fixes #42707 .
Built from https://develop.svn.wordpress.org/trunk@42730
git-svn-id: http://core.svn.wordpress.org/trunk@42560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-22 00:59:30 +00:00
d6923d285c
REST API: Show taxonomy visibility settings.
...
For Gutenberg and other admin-type interfaces, it's useful to be able to see the visibility settings for taxonomies.
Props joehoyle, pento.
Fixes #42707 .
Built from https://develop.svn.wordpress.org/trunk@42729
git-svn-id: http://core.svn.wordpress.org/trunk@42559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-22 00:24:31 +00:00
f4f64377b7
Community Events Dashboard: Use wp_list_pluck rather than array_columns
...
array_columns is only available in PHP 5.5+
Introduced in [42726]
See: #41112 .
Built from https://develop.svn.wordpress.org/trunk@42728
git-svn-id: http://core.svn.wordpress.org/trunk@42558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 23:27:31 +00:00
54a45f6d77
Accessibility: Change the terms "Quick Edit" link to a button.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
See #38677 / [42725].
Fixes #43382 .
Built from https://develop.svn.wordpress.org/trunk@42727
git-svn-id: http://core.svn.wordpress.org/trunk@42557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 23:04:31 +00:00
9f8d1ab69d
Community Events Dashboard: Always show a WordCamp if one is coming up
...
WordCamps are celebrations of the local WordPress Community and once a local one is scheduled, people in that community should know it is coming. This adjusts the WordPress Events in the dashboard widgets to always display a WordCamp, even if there are multiple Meetups happening first.
Props iandunn, metalandcoffee, warmlaundry, alejandroxlopez, jorbin.
Fixes #41112 .
Built from https://develop.svn.wordpress.org/trunk@42726
git-svn-id: http://core.svn.wordpress.org/trunk@42556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 23:01:31 +00:00
4767e7736c
Accessibility: Change the posts "Quick Edit" link to a button.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation. Also,
adds an `aria-expanded` attribute to the button to communicate to assistive
technologies the expanded / collapsed status of the Quick Edit form.
Props Cheffheid, audrasjb, afercia.
Fixes #38677 .
Built from https://develop.svn.wordpress.org/trunk@42725
git-svn-id: http://core.svn.wordpress.org/trunk@42555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 22:31:32 +00:00
ebeb2bcf5b
Tests: Replace use of `$this->server` with `rest_get_server()` for better memory recycling.
...
Props danielbachhuber.
Fixes #41641 .
Built from https://develop.svn.wordpress.org/trunk@42724
git-svn-id: http://core.svn.wordpress.org/trunk@42554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 16:25:31 +00:00
edfe2ece51
Cache API: Allow external object caches to gracefully degrade to the default object cache.
...
Rework logic for how external object caches are detected, so that if
an external cache does not define a `wp_cache_init()`, the built-in
object cache will be used.
Object caches can now wrap their entire contents in logic checks. So a
Redis caching backend could make sure that the `Redis` PHP class is
available before defining all the caching functions. And if Redis is
not available, the site doesn't break or throw errors or think it is
using caching when it isn't. This is particularly useful for doing
local development, where you might want to develop on a site without
running Memcache or Redis like you are in production.
* Accounts for multisite, which may re-initialize the object cache
multiple times.
* Accounts for object caches that may include `object-cache.php` during
`advanced-cache.php` (before WP loads it).
Props jtsternberg, markjaquith.
Fixes #22661 .
Built from https://develop.svn.wordpress.org/trunk@42723
git-svn-id: http://core.svn.wordpress.org/trunk@42553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 14:59:30 +00:00
c7c98dd7ea
Docs: Correct `$id` parameter type for `old_slug_redirect_post_id` filter.
...
Props dlh.
Fixes #43375 .
Built from https://develop.svn.wordpress.org/trunk@42722
git-svn-id: http://core.svn.wordpress.org/trunk@42552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 09:35:33 +00:00
9e5e5ecdc6
Docs: Add a reference to `get_pages()` arguments in `wp_dropdown_pages()` and `wp_list_pages()`, as they both use the function internally.
...
Props birgire.
Fixes #43355 .
Built from https://develop.svn.wordpress.org/trunk@42721
git-svn-id: http://core.svn.wordpress.org/trunk@42549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-19 22:24:31 +00:00
dcf5eb07de
Docs: Correct documentation for Heartbeat filters.
...
`$response` parameter is documented as an array or object, but only array is actually supported.
See #42777 , #42505 .
Built from https://develop.svn.wordpress.org/trunk@42720
git-svn-id: http://core.svn.wordpress.org/trunk@42548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-19 21:46:33 +00:00
e6ccdf161f
General: Further improve error messages following [42648].
...
Props kristastevens, melchoyce.
Fixes #38332 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42719
git-svn-id: http://core.svn.wordpress.org/trunk@42547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-19 02:13:32 +00:00
5eddf9a359
I18N: Remove unused `$start_of_week` property from `WP_Locale`.
...
Missed in [35685], see #28344 .
Props birgire, tonybogdanov.
Fixes #43344 .
Built from https://develop.svn.wordpress.org/trunk@42718
git-svn-id: http://core.svn.wordpress.org/trunk@42546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-18 16:32:34 +00:00
3f7a8aac6b
Docs: Add filter docs for wp_refresh_nonces
...
Props chetan200891, slushman, dlh, netweb.
Fixes #42777 .
Built from https://develop.svn.wordpress.org/trunk@42717
git-svn-id: http://core.svn.wordpress.org/trunk@42545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-17 04:42:33 +00:00
e50b9c943f
Database: If both `WP_DEBUG` and `WP_DEBUG_DISPLAY` are true, display a more specific error message in `wpdb::bail()`.
...
Props sivel, Mte90, SergeyBiryukov.
Fixes #13657 .
Built from https://develop.svn.wordpress.org/trunk@42716
git-svn-id: http://core.svn.wordpress.org/trunk@42544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-15 14:29:30 +00:00
e17e29d4ea
Docs: Improve JSDoc for for `wp-admin/js/xfn.js`.
...
Props kapteinbluf, igorsch.
Fixes #43204 .
Built from https://develop.svn.wordpress.org/trunk@42715
git-svn-id: http://core.svn.wordpress.org/trunk@42543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-15 13:35:31 +00:00
34c6523a0d
Docs: Improve JSDoc for `wp-admin/js/user-suggest.js`.
...
Amend r42708 by fixing the 80 character wrap around.
Props timhavinga.
See #43270 .
Built from https://develop.svn.wordpress.org/trunk@42714
git-svn-id: http://core.svn.wordpress.org/trunk@42542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-15 13:26:33 +00:00
7d2cd516d1
Twenty Seventeen: Underline links in comments.
...
Props jainnidhi, larrach, audrasjb.
Fixes #43317 .
Built from https://develop.svn.wordpress.org/trunk@42713
git-svn-id: http://core.svn.wordpress.org/trunk@42541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-15 03:34:30 +00:00
5d1e06f939
Docs: Move inline comments in `wp_kses_split2()` before the blocks they apply to.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42712
git-svn-id: http://core.svn.wordpress.org/trunk@42540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-14 11:46:33 +00:00
d9f222f740
Customize: Correct closing tags in `customize_themes_print_templates()`.
...
Props johnpgreen, nandorsky.
Fixes #43307 .
Built from https://develop.svn.wordpress.org/trunk@42711
git-svn-id: http://core.svn.wordpress.org/trunk@42539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-13 22:15:32 +00:00
6e665d1f15
Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions.
...
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.
Notations been added for the following functions:
* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()
Props janalwin.
Fixes #43254 .
Built from https://develop.svn.wordpress.org/trunk@42710
git-svn-id: http://core.svn.wordpress.org/trunk@42538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-13 16:54:31 +00:00
5e190dc084
Docs: Improve JSDoc for `media/views/spinner.js`.
...
Amends r42675 - includes the built media files.
Built from https://develop.svn.wordpress.org/trunk@42709
git-svn-id: http://core.svn.wordpress.org/trunk@42537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-13 15:45:30 +00:00
87130f0e20
Docs: Improve JSDoc for `wp-admin/js/user-suggest.js`.
...
Props timhavinga.
Fixes #43270 .
Built from https://develop.svn.wordpress.org/trunk@42708
git-svn-id: http://core.svn.wordpress.org/trunk@42536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-13 15:38:31 +00:00
68a3e7745a
Docs: Add documentation for `header_video_settings` filter.
...
Props milana_cap.
Fixes #43300 .
Built from https://develop.svn.wordpress.org/trunk@42707
git-svn-id: http://core.svn.wordpress.org/trunk@42535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-12 22:39:31 +00:00
dfa6839706
Media: In `img_caption_shortcode()`, make sure `$id` and `$caption_id` are always defined.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42706
git-svn-id: http://core.svn.wordpress.org/trunk@42534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-12 22:36:33 +00:00
0306b3f637
Docs: Use code formatting for tags in `img_caption_shortcode()` DocBlock.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42705
git-svn-id: http://core.svn.wordpress.org/trunk@42533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-12 21:40:31 +00:00
0f8d7de77d
Media: Pass original attribute values to `img_caption_shortcode_width` filter instead of markup pieces.
...
Add `caption_id` to the list of documented `[caption]` shortcode attributes.
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42704
git-svn-id: http://core.svn.wordpress.org/trunk@42532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-12 21:37:30 +00:00
0a97d79899
Comments: Avoid a PHP notice in `paginate_comments_links()` if `type` argument is set to array.
...
The function is a wrapper for `paginate_links()`, which returns an array if requested.
Props anantajitjg.
Fixes #43299 .
Built from https://develop.svn.wordpress.org/trunk@42703
git-svn-id: http://core.svn.wordpress.org/trunk@42531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-12 21:12:35 +00:00
abf27d78b9
Media: After [42695], remove redundant check that is already performed a few lines above.
...
Props gnif.
See #43255 .
Built from https://develop.svn.wordpress.org/trunk@42702
git-svn-id: http://core.svn.wordpress.org/trunk@42530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 21:55:30 +00:00
c2e74ab915
Database: In `require_wp_db()`, check if database constants are defined before using them.
...
Otherwise, `wp-admin/setup-config.php` triggers an undefined constant warning in PHP 7.2.
Props mariusvw, jryancard for initial patch.
Fixes #35560 .
Built from https://develop.svn.wordpress.org/trunk@42701
git-svn-id: http://core.svn.wordpress.org/trunk@42529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 18:47:30 +00:00
b2411e9e3f
Administration: Make sure `wp.updates.addAdminNotice` is displayed after the page header and does not unexpectedly push down "Add New" and other buttons.
...
Props shivapoudel.
Fixes #41221 .
Built from https://develop.svn.wordpress.org/trunk@42700
git-svn-id: http://core.svn.wordpress.org/trunk@42528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 17:28:30 +00:00
e1e041271e
Docs: Fix typo in `term_exists()` DocBlock.
...
Props milana_cap, danieltj.
Fixes #43268 .
Built from https://develop.svn.wordpress.org/trunk@42699
git-svn-id: http://core.svn.wordpress.org/trunk@42527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 17:16:29 +00:00
4a55ea5e68
Networks and Sites: In `get_site_by_path()`, use single `domain` and `path` parameters if there's only one item to look for.
...
This should increase the chances of `WP_Site_Query::get_sites()` hitting an existing cache.
Props spacedmonkey.
Fixes #42299 .
Built from https://develop.svn.wordpress.org/trunk@42698
git-svn-id: http://core.svn.wordpress.org/trunk@42526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 17:09:31 +00:00
f88dddcab5
Media: Add `aac` to the list of allowed file types.
...
Props desrosj.
Fixes #42919 .
Built from https://develop.svn.wordpress.org/trunk@42697
git-svn-id: http://core.svn.wordpress.org/trunk@42525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 16:40:31 +00:00
3de0634199
Docs: Fix typo in `wp_audio_extensions` and `wp_video_extensions` filter descriptions.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42696
git-svn-id: http://core.svn.wordpress.org/trunk@42524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 16:29:30 +00:00
e6322d0afe
Media: In `WP_Image_Editor::make_image()`, close previously opened output buffer if the file could not be created.
...
Props dhanendran, gnif.
Fixes #43255 .
Built from https://develop.svn.wordpress.org/trunk@42695
git-svn-id: http://core.svn.wordpress.org/trunk@42523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 16:25:31 +00:00
beeafbc7ec
Media: After [42693], update HTML4 markup in `img_caption_shortcode()` to avoid an empty ID attribute as well.
...
Add a unit test for `aria-describedby` in `img_caption_shortcode()`.
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42694
git-svn-id: http://core.svn.wordpress.org/trunk@42522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 15:40:30 +00:00
0f2b559d05
Media: Only add `aria-describedby` in `img_caption_shortcode()` if a non-empty attachment ID attribute was provided.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42693
git-svn-id: http://core.svn.wordpress.org/trunk@42521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 15:20:30 +00:00
dffe5deb97
Media: Make sure `$caption_id` does not depend on an undefined variable.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42692
git-svn-id: http://core.svn.wordpress.org/trunk@42520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 14:53:30 +00:00
3e19b66f40
Media: Add `aria-describedby` to `img_caption_shortcode()` output to improve image/caption relationship.
...
Props joedolson.
Fixes #34595 .
Built from https://develop.svn.wordpress.org/trunk@42691
git-svn-id: http://core.svn.wordpress.org/trunk@42519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 14:44:30 +00:00
8df00f0354
Media: Convert concatenation in `img_caption_shortcode()` to `sprintf()` for clarity.
...
See #34595 .
Built from https://develop.svn.wordpress.org/trunk@42690
git-svn-id: http://core.svn.wordpress.org/trunk@42518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 14:17:30 +00:00
7a8e4bcb1b
Administration: Remove erroneous `transition-delay` values from CSS files.
...
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.
Props chetan200891, manuel_84, GaryJ.
Fixes #43195 .
Built from https://develop.svn.wordpress.org/trunk@42689
git-svn-id: http://core.svn.wordpress.org/trunk@42517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 12:55:30 +00:00
e97d2c0407
Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed.
...
Props dilipbheda.
Fixes #43106 . See #16470 .
Built from https://develop.svn.wordpress.org/trunk@42688
git-svn-id: http://core.svn.wordpress.org/trunk@42516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-11 12:23:31 +00:00
12f854b6e8
Build/Test Tools: Update prefixed CSS properties in `about.css`.
...
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.
Props netweb, afercia.
Fixes #43190 .
Built from https://develop.svn.wordpress.org/trunk@42687
git-svn-id: http://core.svn.wordpress.org/trunk@42515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 23:47:31 +00:00
903224cce4
Plugins: Use correct variable name in `install_plugin_information()`.
...
Props afragen.
Fixes #43282 . See #43192 , #29274 .
Built from https://develop.svn.wordpress.org/trunk@42686
git-svn-id: http://core.svn.wordpress.org/trunk@42514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 22:08:30 +00:00
b1f48870d7
Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity.
...
Props xkon, karmatosed.
Fixes #43072 .
Built from https://develop.svn.wordpress.org/trunk@42685
git-svn-id: http://core.svn.wordpress.org/trunk@42513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-10 08:43:32 +00:00
ee24b48106
Comments: Add a "Mine" link to the list of filters on the comment listing screen.
...
This filter shows comments made by the current user, and copies the same filter functionality that's available on the post listing screens.
Props Iceable
Fixes #42379
Built from https://develop.svn.wordpress.org/trunk@42684
git-svn-id: http://core.svn.wordpress.org/trunk@42512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:46:31 +00:00
1ae9491548
Docs: Fix a copy paste error in the DocBlock summary for `wp_ssl_constants()`, see [13062].
...
Props terriann.
Fixes #43272 .
Built from https://develop.svn.wordpress.org/trunk@42683
git-svn-id: http://core.svn.wordpress.org/trunk@42511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:21:31 +00:00
b1ed10ab9a
HTTP API: Add the URL as a paramter to various HTTP related filters.
...
Props paulschreiber, purnendu
Fixes #42186
Built from https://develop.svn.wordpress.org/trunk@42682
git-svn-id: http://core.svn.wordpress.org/trunk@42510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:11:30 +00:00
427ae1692d
Docs: Un-correct an incorrection correction.
...
See [42680]
See #42505
Built from https://develop.svn.wordpress.org/trunk@42681
git-svn-id: http://core.svn.wordpress.org/trunk@42509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:57:30 +00:00
763f34d117
Docs: Correct some secondary documentation for the `https_local_ssl_verify` and `https_ssl_verify` filters.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42680
git-svn-id: http://core.svn.wordpress.org/trunk@42508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:48:29 +00:00
fc6ba86b80
Docs: First pass at switching some array parameter documentation to typed notation.
...
Props janak007
See #41756
Built from https://develop.svn.wordpress.org/trunk@42679
git-svn-id: http://core.svn.wordpress.org/trunk@42507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:26:31 +00:00
91464bce65
Docs: Add missing code formatting to various `@since` entries.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42678
git-svn-id: http://core.svn.wordpress.org/trunk@42506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 16:55:31 +00:00
823cac40df
Docs: Update the hook docs for `update_bulk_theme_complete_actions`.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42677
git-svn-id: http://core.svn.wordpress.org/trunk@42505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 16:22:45 +00:00
332b9844a9
Posts, Post Types: Add a new `add_inline_data` action which allows extra fields to be added to the inline editing fields.
...
Props mensmaximus, NathanAtmoz
Fixes #36085
Built from https://develop.svn.wordpress.org/trunk@42676
git-svn-id: http://core.svn.wordpress.org/trunk@42504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 15:55:32 +00:00
8ad4538d0f
Docs: Improve JSDoc for `media/views/spinner.js`.
...
Props avillegasn.
Fixes #43230 .
Built from https://develop.svn.wordpress.org/trunk@42675
git-svn-id: http://core.svn.wordpress.org/trunk@42503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 14:32:33 +00:00
b9944def27
Posts, Post Types: Remove extra tabs around `page_attributes_meta_box_template` action in `page_attributes_meta_box()`.
...
Props chetan200891.
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42674
git-svn-id: http://core.svn.wordpress.org/trunk@42502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 11:24:32 +00:00
ef4f47d00f
Customize: Avoid extra tabs in a textarea in `WP_Customize_Control::render_content()`.
...
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42673
git-svn-id: http://core.svn.wordpress.org/trunk@42501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:59:30 +00:00
a5958a289b
Upgrade/Install: Avoid extra line breaks in a textarea in `wp-admin/setup-config.php`.
...
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42672
git-svn-id: http://core.svn.wordpress.org/trunk@42500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:59:00 +00:00
a65ce4e34b
Options: Avoid extra tabs in a textarea in `wp-admin/options.php`.
...
See #43252 .
Built from https://develop.svn.wordpress.org/trunk@42671
git-svn-id: http://core.svn.wordpress.org/trunk@42499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:58:31 +00:00
cceab04984
Comments: Avoid extra tabs in a textarea in `WP_Comments_List_Table::column_comment()`.
...
Props chetan200891, jrf.
Fixes #43252 .
Built from https://develop.svn.wordpress.org/trunk@42670
git-svn-id: http://core.svn.wordpress.org/trunk@42498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-08 10:57:32 +00:00
aaa28bba15
Options: Use strings in the test suite that follow community guidelines.
...
Also somewhat explain to future maintainers why this pairing of strings was chosen, besides this committer's musical preferences. Social opinions on cancer are fairly clear, as are commonly accepted definitions of profanity and family-friendly language.
Shout out to the close contender, which would have been particularly appropriate here: "You could be the king // But watch the queen conquer".
see #43207 , #38176
Built from https://develop.svn.wordpress.org/trunk@42667
git-svn-id: http://core.svn.wordpress.org/trunk@42495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 22:42:31 +00:00
1c2ef0f475
Build/Test Tools: Allow code coverage reports to be generated.
...
This corrects the attribute needed to allow PHPUnit to generate coverage reports, and also adds a blacklist of files and directories that are excluded from coverage reports.
Props schlessera, jipmoors
Fixes #43067 , #43240
Built from https://develop.svn.wordpress.org/trunk@42665
git-svn-id: http://core.svn.wordpress.org/trunk@42494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 22:21:30 +00:00
f7224ea635
Docs: Copy a helpful inline doc into the function header for visibility.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42664
git-svn-id: http://core.svn.wordpress.org/trunk@42493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 22:13:30 +00:00
17589837d2
Options: Use most appropriate language in the test suite.
...
The test suite's opinion of cancer should be clear.
Reverts r42659.
See #43207 , #38176
Built from https://develop.svn.wordpress.org/trunk@42663
git-svn-id: http://core.svn.wordpress.org/trunk@42492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 20:59:31 +00:00
355b6e80da
Improve parameter description for 'allow_empty_comments'.
...
Introduced in [42661].
Props swissspidy.
See #16979 .
Built from https://develop.svn.wordpress.org/trunk@42662
git-svn-id: http://core.svn.wordpress.org/trunk@42491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 20:50:30 +00:00
6c11ac0c16
Comments: Introduce 'allow_empty_comment' filter.
...
This filter allows plugin authors to allow empty comments on a selective
basis during comment submission.
Props jpurdy647.
Fixes #16979 .
Built from https://develop.svn.wordpress.org/trunk@42661
git-svn-id: http://core.svn.wordpress.org/trunk@42490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 20:09:30 +00:00
39ce01d83a
Docs: Fix a typo in the DocBlock description for `get_bloginfo()` illustrating the URL structure for RDF feeds.
...
Props ibachal.
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42660
git-svn-id: http://core.svn.wordpress.org/trunk@42489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 19:42:30 +00:00
982791db31
Options: Use more appropriate language in the test suite.
...
See #43207 , #38176
Built from https://develop.svn.wordpress.org/trunk@42659
git-svn-id: http://core.svn.wordpress.org/trunk@42488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 18:52:31 +00:00
9dd9913ecd
Docs: Document default arguments for `wp_tag_cloud()` in a hash notation, noting that full lists of additionally-supported arguments are already documented in `get_terms()` and `wp_generate_tag_cloud()`.
...
Props birgire, johnbillion.
Fixes #42019 .
Built from https://develop.svn.wordpress.org/trunk@42658
git-svn-id: http://core.svn.wordpress.org/trunk@42487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 15:22:34 +00:00
f3eaddd2dc
Options: Unhook default option filter when setting is unregistered.
...
Fixes #43207 .
Built from https://develop.svn.wordpress.org/trunk@42655
git-svn-id: http://core.svn.wordpress.org/trunk@42484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-06 14:49:32 +00:00
3517dc0b8b
Updates: Partially revert [42584], as this branch of code should always be run after a core update check.
...
This code branch is responsible for running all autoupdates, including plugins and themes - which should run regardless of if there's a core autoupdate available.
This revert does not revert the `$timeout` changes, as these should still use cached data if it's available.
Ideally this should be decoupled from the core update check to allow background updates to operate even when the core update check is disabled or running more often than twice daily.
See #43103 .
Built from https://develop.svn.wordpress.org/trunk@42653
git-svn-id: http://core.svn.wordpress.org/trunk@42482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-06 11:04:34 +00:00
0eb9e0c8d0
XML-RPC: Add default values to IXR_Message for PHP 7.2 compatibility to avoid PHP Warnings.
...
Fixes #43216 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42652
git-svn-id: http://core.svn.wordpress.org/trunk@42481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-06 02:56:32 +00:00
8f0ab2efb8
Taxonomy: Stop warming term meta cache unnecessarily.
...
Prevent several core function calls to `get_terms()` from warming the term meta cache.
Props peterwilsoncc, boonebgorges, jrf.
Fixes #43142 .
Built from https://develop.svn.wordpress.org/trunk@42649
git-svn-id: http://core.svn.wordpress.org/trunk@42478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-05 04:10:30 +00:00
0d39b35c11
General: Replace `Cheatin’ uh?` with friendlier error messages.
...
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.
Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332 .
Built from https://develop.svn.wordpress.org/trunk@42648
git-svn-id: http://core.svn.wordpress.org/trunk@42477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-05 02:30:34 +00:00
a1eb261cd1
Canonical: Add `$x_redirect_by` parameter to `wp_safe_redirect()`.
...
See [42633] and [42408].
Fixes #42313 .
Built from https://develop.svn.wordpress.org/trunk@42647
git-svn-id: http://core.svn.wordpress.org/trunk@42476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-04 16:05:32 +00:00
f3ca5b5f47
Tests: Simplify `@covers` annotations for `WP_Error` test coverage. Also fix a typo in a test method name.
...
See #42742 .
Built from https://develop.svn.wordpress.org/trunk@42646
git-svn-id: http://core.svn.wordpress.org/trunk@42475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 17:38:30 +00:00
3544e0151d
Tests: Fix two typos introduced for a get_term_field() test in [35270].
...
See #33968 .
Built from https://develop.svn.wordpress.org/trunk@42645
git-svn-id: http://core.svn.wordpress.org/trunk@42474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 17:11:30 +00:00
8a664edcab
Administration: Make the Screen Options available on small screens.
...
Previously, the Screen Options toggle and the related panel content
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.
Props chetan200891.
Fixes #40985 .
Built from https://develop.svn.wordpress.org/trunk@42644
git-svn-id: http://core.svn.wordpress.org/trunk@42473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 16:58:30 +00:00
430a724a03
Help/About: Correct outdated media icons reference in help text on Edit Post screen.
...
Props thrijith, transl8or.
Fixes #42378 .
Built from https://develop.svn.wordpress.org/trunk@42643
git-svn-id: http://core.svn.wordpress.org/trunk@42472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 13:58:30 +00:00
4951b2897e
Media: Remove checkered background for icons in Attachment Details.
...
Props BandonRandon.
Fixes #42535 . See #41948 .
Built from https://develop.svn.wordpress.org/trunk@42642
git-svn-id: http://core.svn.wordpress.org/trunk@42471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 13:54:31 +00:00
a7c89d5761
Administration: CSS coding standards: use double quotes for values that require quotes.
...
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.
Fixes #43220 .
Built from https://develop.svn.wordpress.org/trunk@42641
git-svn-id: http://core.svn.wordpress.org/trunk@42470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-03 13:19:32 +00:00
abdea23275
Docs: Convert `$args` array description for `wp_get_themes()` to a hash notation.
...
Props milana_cap.
Fixes #43213 .
Built from https://develop.svn.wordpress.org/trunk@42640
git-svn-id: http://core.svn.wordpress.org/trunk@42469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-02 09:38:30 +00:00
f45e696e21
Media: Avoid a PHP warning in `wp_calculate_image_srcset()` if a plugin returns a non-array value via `wp_calculate_image_srcset` filter.
...
Props mrmadhat, codegrau.
Fixes #43201 .
Built from https://develop.svn.wordpress.org/trunk@42639
git-svn-id: http://core.svn.wordpress.org/trunk@42468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-02 07:48:31 +00:00
2f54a93369
Posts, Post Types: Don't count pending comments in `WP_Posts_List_Table::_display_rows()` if the post type does not support comments.
...
Props seanchayes.
Fixes #43212 .
Built from https://develop.svn.wordpress.org/trunk@42638
git-svn-id: http://core.svn.wordpress.org/trunk@42467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-02 07:38:32 +00:00
66e2c1ed87
Build Tools: Update SPDX License in `package.json` to adhere to SPDX v3.0 specification.
...
Props netweb.
Fixes #43032 .
Built from https://develop.svn.wordpress.org/trunk@42637
git-svn-id: http://core.svn.wordpress.org/trunk@42466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 16:39:30 +00:00
e5adb49dbb
Tests: Correct erroneous `@covers` and `@use` tags.
...
Props jipmoors.
Fixes #43203 .
Built from https://develop.svn.wordpress.org/trunk@42636
git-svn-id: http://core.svn.wordpress.org/trunk@42465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 16:09:30 +00:00
7282155198
Tests: Improve tests for `wp_get_post_parent_id()` added in [42397].
...
Props frank-klein.
Fixes #42797 .
Built from https://develop.svn.wordpress.org/trunk@42635
git-svn-id: http://core.svn.wordpress.org/trunk@42464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 16:03:31 +00:00
8393519ade
Menus: Remove `$_menu_item_sort_prop` global reference from `wp_get_nav_menu_items()`, unused since [38928].
...
Props PieWP, welcher.
Fixes #40947 .
Built from https://develop.svn.wordpress.org/trunk@42634
git-svn-id: http://core.svn.wordpress.org/trunk@42463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 15:42:31 +00:00
673ff22b2b
Canonical: Add `$x_redirect_by` parameter to `wp_redirect()` that allows applications doing the redirect to identify themselves.
...
This complements the `x_redirect_by` filter added in [42408].
Props NathanAtmoz, johnbillion.
Fixes #42313 .
Built from https://develop.svn.wordpress.org/trunk@42633
git-svn-id: http://core.svn.wordpress.org/trunk@42462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 15:06:35 +00:00
1e5629d1f1
Themes: Use `api.wordpress.org/themes/info/1.2/` to query theme information.
...
See #43192 .
Built from https://develop.svn.wordpress.org/trunk@42632
git-svn-id: http://core.svn.wordpress.org/trunk@42461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 05:19:30 +00:00
7abfd84c75
Plugins: Use `api.wordpress.org/plugins/info/1.2/` for querying plugins & plugin information.
...
See #43192 .
Fixes #29274 .
Built from https://develop.svn.wordpress.org/trunk@42631
git-svn-id: http://core.svn.wordpress.org/trunk@42460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 05:17:33 +00:00
b170b60693
Docs: Correct erroneous class references in `@see` tags.
...
Props coffee2code.
Fixes #43158 .
Built from https://develop.svn.wordpress.org/trunk@42630
git-svn-id: http://core.svn.wordpress.org/trunk@42459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-01 01:20:30 +00:00
76ad62d11e
Code Editor: Add Ctrl/Cmd+F as aliases for persistent search for more intuitive behaviour.
...
Keep Alt+F as well for users who already expect that.
Props Desertsnowman.
See #42586 .
Built from https://develop.svn.wordpress.org/trunk@42625
git-svn-id: http://core.svn.wordpress.org/trunk@42454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-31 22:22:30 +00:00
d6a73ef110
Media: avoid page scrolling when opening the media modal.
...
Moves focus to a proper element within the media modal to avoid the underlying
page to scroll to the bottom. Removes the media modal `freeze` option.
Props andreiglingeanu, adamsilverstein.
Fixes 39859.
Built from https://develop.svn.wordpress.org/trunk@42624
git-svn-id: http://core.svn.wordpress.org/trunk@42453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-31 17:03:33 +00:00
587da39a9e
Remove unit tests for deprecated ajax tag search function.
...
Fixes unit tests failing since r42614.
Ammends [42614].
See #38922 .
Built from https://develop.svn.wordpress.org/trunk@42619
git-svn-id: http://core.svn.wordpress.org/trunk@42448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-30 02:29:31 +00:00
35a20d8f50
Remove unused var after r42614, fixing a jshint error.
...
Built from https://develop.svn.wordpress.org/trunk@42618
git-svn-id: http://core.svn.wordpress.org/trunk@42447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-30 00:34:59 +00:00
c2369bfad7
Widgets: Fix Text widget unit test which broke due to global scope not being cleaned.
...
Amends [42613].
See #42495 .
Built from https://develop.svn.wordpress.org/trunk@42617
git-svn-id: http://core.svn.wordpress.org/trunk@42446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-30 00:34:30 +00:00
39575cede2
Correct the version term_search_min_chars changed. Ammends r42614.
...
Built from https://develop.svn.wordpress.org/trunk@42616
git-svn-id: http://core.svn.wordpress.org/trunk@42445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-30 00:30:30 +00:00
c6013a2b87
Customize: Ensure `customize_autosaved` requests only use revision of logged-in user.
...
Props dlh, westonruter.
See #42433 , #39896 .
Fixes #42450 .
Built from https://develop.svn.wordpress.org/trunk@42615
git-svn-id: http://core.svn.wordpress.org/trunk@42444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-30 00:21:30 +00:00
86434ebca4
Taxonomy: Use REST API for ajax tag search.
...
Deprecate wp_ajax_ajax_tag_search and switch to using the REST API when searching tags in the tags meta box.
Props nacin, chriscct7, afercia, swissspidy, jnylen0, rmccue, ryelle.
Fixes #38922 .
Built from https://develop.svn.wordpress.org/trunk@42614
git-svn-id: http://core.svn.wordpress.org/trunk@42443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-30 00:17:31 +00:00
1829a2ce27
Customize: Ensure media playlists get initialized after selective refresh; expose new `wp.playlist.initialize()` API.
...
In particular allows audio and video playlists to be added to the Text widget and previewed.
Props bpayton, westonruter.
See #40854 .
Fixes #42495 .
Built from https://develop.svn.wordpress.org/trunk@42613
git-svn-id: http://core.svn.wordpress.org/trunk@42442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-29 23:56:29 +00:00
b32df8f64e
Customize: Ensure heartbeat keeps changeset locked when in branching mode.
...
Props dlh.
See #42024 .
Fixes #42658 .
Built from https://develop.svn.wordpress.org/trunk@42612
git-svn-id: http://core.svn.wordpress.org/trunk@42441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-29 23:05:31 +00:00
a8b77a1948
Customize: Include nav menu item for Home custom link in search results for "Home".
...
Props audrasjb, westonruter.
Fixes #42991 .
Built from https://develop.svn.wordpress.org/trunk@42611
git-svn-id: http://core.svn.wordpress.org/trunk@42440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-29 22:10:33 +00:00
7d9c47d536
Emoji: Tweak the generated emoji arrays to not cause coding standards errors.
...
Props netweb, jrf.
Fixes #43150 .
Built from https://develop.svn.wordpress.org/trunk@42610
git-svn-id: http://core.svn.wordpress.org/trunk@42439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-25 01:06:31 +00:00
1cda7b9667
Role/Capability: Make `install_languages` capability check less restrictive.
...
A user should still be able to have the capability, even when language packs cannot be automatically installed. The automatic installation part is separate from that now.
Props flixos90.
Fixes #42697 .
Built from https://develop.svn.wordpress.org/trunk@42606
git-svn-id: http://core.svn.wordpress.org/trunk@42435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 22:42:30 +00:00
ea6f648401
Upgrade/Install: In `postMessage` events handler, check for `message` object existence before checking its `action` property.
...
Props manikmist09.
Fixes #43005 .
Built from https://develop.svn.wordpress.org/trunk@42604
git-svn-id: http://core.svn.wordpress.org/trunk@42433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 22:31:30 +00:00
6bb7fcebf4
Emoji: Update Emoji browser support tests for Twemoji v2.4.0
...
Really, following [42598].
Fixes #42862 for trunk, really.
Built from https://develop.svn.wordpress.org/trunk@42602
git-svn-id: http://core.svn.wordpress.org/trunk@42431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 22:02:30 +00:00
a1121f1def
Media: Fix JSHint error after [42595].
...
See #42646 .
Built from https://develop.svn.wordpress.org/trunk@42599
git-svn-id: http://core.svn.wordpress.org/trunk@42428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 21:51:31 +00:00
891c8255c3
Emoji: Update Emoji browser support tests for Twemoji v2.4.0
...
Replaces the fairy (male) browser support test with a woman in business suit levitating. While the things that make people different sometimes become less obvious this isn't always a problem, because the things that make you strange are the things that make you powerful.
Fixes #42862 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42598
git-svn-id: http://core.svn.wordpress.org/trunk@42427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 21:47:30 +00:00
365c70d415
Media: Store and reuse image cropper ratio settings if available, instead of overwriting.
...
Props adamsilverstein.
Fixes #42646 .
Built from https://develop.svn.wordpress.org/trunk@42595
git-svn-id: http://core.svn.wordpress.org/trunk@42424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 21:36:31 +00:00
4d89f4a20c
Query: Improve tests for set_found_posts dealing with non arrays
...
Use a data provider and include tests for `false` and `''`.
Previous: [42581] [42585]
See #42860
Built from https://develop.svn.wordpress.org/trunk@42594
git-svn-id: http://core.svn.wordpress.org/trunk@42423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 20:52:30 +00:00
c7b0073e92
Tests: Update emoji base URL in `Tests_Formatting_Emoji` after [42590].
...
See #42862 .
Built from https://develop.svn.wordpress.org/trunk@42592
git-svn-id: http://core.svn.wordpress.org/trunk@42421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 17:26:30 +00:00
ee58ffcbe7
Emoji: Update emoji base URL in `_print_emoji_detection_script()` and `wp_staticize_emoji()`.
...
Props pento.
Fixes #42862 .
Built from https://develop.svn.wordpress.org/trunk@42590
git-svn-id: http://core.svn.wordpress.org/trunk@42419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 16:51:30 +00:00
488df7c563
Docs: Correct some version numbers.
...
`wp_check_for_changed_dates()`, `_find_post_by_old_slug(), `_find_post_by_old_date()`, and the `old_slug_redirect_post_id` filter were intended to land in 4.9.2, but didn't quite make it. Instead, they'll be landing in 4.9.3.
See #15397 .
Built from https://develop.svn.wordpress.org/trunk@42588
git-svn-id: http://core.svn.wordpress.org/trunk@42417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 06:48:31 +00:00
dcb0ebef21
Tests: Improve the old date redirect tests.
...
Props frank-klein.
See #15397 .
Built from https://develop.svn.wordpress.org/trunk@42587
git-svn-id: http://core.svn.wordpress.org/trunk@42416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 06:39:30 +00:00
02bc2c3186
Tests: Skip newly added tests from [42581] on PHP 5.2 as they require ReflectionMethod.
...
See #42860 .
Built from https://develop.svn.wordpress.org/trunk@42585
git-svn-id: http://core.svn.wordpress.org/trunk@42414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 04:21:31 +00:00
14068105f7
Updates: Only trigger Background Update processes from within the core update check when a core autoupdate is on offer.
...
This change reduces the number of API calls which WordPress makes to api.wordpress.org during release windows.
Previously the background updates would run upon every core update transient refresh, however now they'll only run if there's an update available.
The change also increases the cache period for plugin & theme checks when running via the cron, from never-cache to 2 hours, which should hopefully reduce the number of needless API calls.
Fixes #43103 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42584
git-svn-id: http://core.svn.wordpress.org/trunk@42413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 04:17:30 +00:00
3429cfeabe
Media: Introduce a custom error handler for MediaElement.js to display a download link if a FLV file cannot be rendered for any reason.
...
Props Clorith.
Fixes #42643 .
Built from https://develop.svn.wordpress.org/trunk@42582
git-svn-id: http://core.svn.wordpress.org/trunk@42411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 01:51:30 +00:00
8a884f562a
Query: Fix warning on counting non countable
...
Adds tests to continue the behavior for both null and strings.
See https://wiki.php.net/rfc/counting_non_countables for information on the PHP change.
Fixes #42860 .
Props janak007 and ayeshrajans for initial patches.
Built from https://develop.svn.wordpress.org/trunk@42581
git-svn-id: http://core.svn.wordpress.org/trunk@42410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 01:21:31 +00:00
09432d1aa6
Emoji: Update emoji regex for Twemoji to 2.4.0.
...
Build `src/wp-includes/formatting.php` following [42566].
Fixes #42862 .
Built from https://develop.svn.wordpress.org/trunk@42579
git-svn-id: http://core.svn.wordpress.org/trunk@42408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 21:12:31 +00:00
84cdc05c58
TinyMCE: backport bug fixes to `NotificationManager` and `WindowManager` from d1877933fa (diff-2e5c98d81ce2481aa1042b2320728b65) and to `MultiRange` from 250675bb7b.
...
Props peterwilsoncc, azaozz.
Fixes #42722 for trunk, see #43012 .
Built from https://develop.svn.wordpress.org/trunk@42576
git-svn-id: http://core.svn.wordpress.org/trunk@42405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 19:35:31 +00:00
5878c6c83a
Editor: when keeping the scroll position treat all shortcodes as preview-able. Otherwise in some cases the marker span can get stuck inside the shortcode and break the markup.
...
Props azaozz, lizkarkoski and othellobloke for testing.
Fixes #42908 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42574
git-svn-id: http://core.svn.wordpress.org/trunk@42403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 17:34:32 +00:00
d9d841b807
Media: Restore white background of the content area in media modal.
...
Props afercia, chetan200891.
Fixes #43088 .
Built from https://develop.svn.wordpress.org/trunk@42572
git-svn-id: http://core.svn.wordpress.org/trunk@42401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 14:01:31 +00:00
e9599bc7b5
Email: Don't send notifications for site or network admin email address change to the default 'admin_email' value.
...
Props tigertech, MattyRob, seanchayes.
Fixes #42693 .
Built from https://develop.svn.wordpress.org/trunk@42570
git-svn-id: http://core.svn.wordpress.org/trunk@42399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 13:45:32 +00:00
5cfda780d8
Customize: Correct "Add Items" button reference in help text shown after creating a new menu.
...
Props dlh, munyagu, rishishah.
Fixes #42565 .
Built from https://develop.svn.wordpress.org/trunk@42568
git-svn-id: http://core.svn.wordpress.org/trunk@42397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 12:03:30 +00:00
d9a535ee13
Emoji: Update Twemoji to 2.4.0.
...
WordPress was already on 2.5.0, but Twemoji decided to break their versioning, so 2.4.0 is actually the latest release.
Fixes #42862 .
Built from https://develop.svn.wordpress.org/trunk@42566
git-svn-id: http://core.svn.wordpress.org/trunk@42395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 11:49:30 +00:00
9a1066c90e
Taxonomy: Don't display an empty edit link in taxonomy list table if the user doesn't have permissions to edit the term.
...
Props grapplerulrich.
Fixes #43146 .
Built from https://develop.svn.wordpress.org/trunk@42565
git-svn-id: http://core.svn.wordpress.org/trunk@42394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 11:34:31 +00:00
fc42c062f1
WPDB: Use a PCRE syntax which supports PCRE compiled between 2003 and 2006.
...
This fixes a PHP Warning in `wpdb::parse_db_host()` when WordPress is used with (sometimes a modern) PHP that's compiled against an ancient PCRE version.
Fixes #43109 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42549
git-svn-id: http://core.svn.wordpress.org/trunk@42378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 03:39:30 +00:00
9efeb545c0
Remove JSHint due to license compatibility
...
JSHint inherits a license from JSLint that includes the clause "The Software shall be used for Good, not Evil." WordPress's license specifically allows grants the freedom to run the program, for any purpose. Please note, this is not an encouragement of evil. Rather than doing something evil, how about learning to love those around you. Instead of tweeting lies and saying people are "Not Good!", help your neighbor. In the words of Lin Manual Miranda, "Love is love is love is love is love is love is love is love, cannot be killed or swept aside."
This replaces JSHint with esprima, a part of the larger jQuery project, and a custom wrapper for some basic error checking within codemirror.
The existing JSHint configuration is kept in place in case someone wants to use that, but they can only do so for Good.
Fixes #42850
Props netweb for a spelling fix on a comment.
Built from https://develop.svn.wordpress.org/trunk@42547
git-svn-id: http://core.svn.wordpress.org/trunk@42376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-23 01:29:32 +00:00
2ec77391f6
Widgets: Ensure media is explicitly enqueued from Text widget in case Media widgets are unregistered.
...
Amends [41344].
See #40854 .
Fixes #43125 .
Built from https://develop.svn.wordpress.org/trunk@42545
git-svn-id: http://core.svn.wordpress.org/trunk@42374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 19:25:31 +00:00
94d178dd31
Customize: Let default status for Customizer be `draft` if user does not have capability to `publish`.
...
Amends [41626].
Props sayedwp, westonruter.
See #30937 .
Fixes #42686 .
Built from https://develop.svn.wordpress.org/trunk@42543
git-svn-id: http://core.svn.wordpress.org/trunk@42372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 19:10:34 +00:00
183cda343a
Customize: Prevent frontend previewing from causing a customization lock on the changeset.
...
Props dlh.
Amends [41839].
See #42024 .
Fixes #42975 .
Built from https://develop.svn.wordpress.org/trunk@42541
git-svn-id: http://core.svn.wordpress.org/trunk@42370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:49:31 +00:00
0e94d99f64
REST API: Update the fixture data for `wp-api.js` tests following [42359].
...
Props danielbachhuber.
See #41014 .
Built from https://develop.svn.wordpress.org/trunk@42540
git-svn-id: http://core.svn.wordpress.org/trunk@42369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:34:32 +00:00
87cae6e261
Customize: Use changeset-specific "locked" messages when branching is enabled.
...
Props dlh.
See #39896 .
Fixes #42655 .
Built from https://develop.svn.wordpress.org/trunk@42538
git-svn-id: http://core.svn.wordpress.org/trunk@42367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:28:31 +00:00
cd9f48b54f
Customize: Prevent showing SFTP theme installation notification in multisite when user cannot install themes.
...
Props flixos90.
See #37661 , #42184 .
Fixes #42674 .
Built from https://develop.svn.wordpress.org/trunk@42536
git-svn-id: http://core.svn.wordpress.org/trunk@42365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 06:15:30 +00:00
fa460ab32f
Widgets: Allow relative/partial URLs in Image Widget's link field.
...
Props audrasjb.
Amends [41252].
See #41274 .
Fixes #42740 .
Built from https://develop.svn.wordpress.org/trunk@42533
git-svn-id: http://core.svn.wordpress.org/trunk@42362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 04:52:33 +00:00
11af5ae5cd
Code Editor: Disable `attr-value-double-quotes` HTMLHint rule since too strict for user input.
...
Using single-quoted attribute values is not in any way invalid HTML.
Amends [41376].
Props sasiddiqui.
See #12423 .
Fixes #42802 .
Built from https://develop.svn.wordpress.org/trunk@42531
git-svn-id: http://core.svn.wordpress.org/trunk@42360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-21 08:01:31 +00:00
5ecd978e74
Formatting: Fix typo in inline documentation of `_deep_replace()`.
...
Props ixkaito.
Fixes #43134 .
Built from https://develop.svn.wordpress.org/trunk@42530
git-svn-id: http://core.svn.wordpress.org/trunk@42359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-20 13:32:32 +00:00
365025fb62
Editor: change the test in `user_can_richedit()` to also detect when IE11 is in compatibility mode.
...
Props ndavison, azaozz.
Fixes #42503 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42529
git-svn-id: http://core.svn.wordpress.org/trunk@42358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 14:43:31 +00:00
d268976255
Docs: Improve JSDoc for `password-strength-meter.js`.
...
Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066 .
Built from https://develop.svn.wordpress.org/trunk@42528
git-svn-id: http://core.svn.wordpress.org/trunk@42357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 13:39:33 +00:00
44c89cac5a
General: Allow `wp_list_pluck()` to operate on arrays of references without overwriting the referenced items.
...
Fixes #16895 .
Built from https://develop.svn.wordpress.org/trunk@42527
git-svn-id: http://core.svn.wordpress.org/trunk@42356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 05:18:31 +00:00
26a5d758d5
Tests: Remove redundant `assertEquals()` calls in listFilter tests.
...
As these tests are already validating that two arrays match, checking that the counts also match before is redundant and makes it harder to debug when the test fails.
See #16895
Built from https://develop.svn.wordpress.org/trunk@42526
git-svn-id: http://core.svn.wordpress.org/trunk@42355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 05:15:34 +00:00
0eb2581c67
Media: In `_wp_handle_upload()`, check if the file was properly uploaded before checking its size.
...
Props achbed, dglingren.
Fixes #39522 .
Built from https://develop.svn.wordpress.org/trunk@42525
git-svn-id: http://core.svn.wordpress.org/trunk@42354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 07:16:30 +00:00
3b73ac9eb3
Editor: Use explicit context instead of a trailing space for `Edit` string in TinyMCE plugins.
...
Props scottlee, ayubadiputra, NathanAtmoz.
Fixes #42543 .
Built from https://develop.svn.wordpress.org/trunk@42523
git-svn-id: http://core.svn.wordpress.org/trunk@42352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 06:28:30 +00:00
443594dd00
Widgets: Prevent `checkValidity` from running on a form when widget is first adding to sidebar.
...
Amends [41352].
See #23120 .
Fixes #43003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42521
git-svn-id: http://core.svn.wordpress.org/trunk@42350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 01:24:30 +00:00
8bd98be63d
BUILD/TEST TOOLS: Report Travis test results to make/hosting PHPUnit test results
...
Send the core test results to make/hosting in order to improve the alerting. See: https://github.com/WordPress/phpunit-test-reporter/issues/45
Fixes #43099
Props danielbachhuber
Built from https://develop.svn.wordpress.org/trunk@42492
git-svn-id: http://core.svn.wordpress.org/trunk@42321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 20:29:31 +00:00
fc51a83ed8
Plugins: Fix the plugin details modal "Close" button after [42443].
...
Props rinkuyadav999.
Fixes #43082 .
Built from https://develop.svn.wordpress.org/trunk@42491
git-svn-id: http://core.svn.wordpress.org/trunk@42320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 17:15:32 +00:00
e62806fcb8
Posts, Post Types: Add tests for `get_post_type_labels()`.
...
These were accidentally omitted in [38157].
See #38157 .
Built from https://develop.svn.wordpress.org/trunk@42490
git-svn-id: http://core.svn.wordpress.org/trunk@42319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 08:33:30 +00:00
82054452d2
Build: Bump the version of node used on Travis to match WordPress.org.
...
Props netweb, dd32.
See #35105
Built from https://develop.svn.wordpress.org/trunk@42464
git-svn-id: http://core.svn.wordpress.org/trunk@42293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:36:30 +00:00
88135346c6
Build: Bump grunt-sass to v2.0.0 from v1.2.1 for Node 8.x support.
...
Changes: https://github.com/sindresorhus/grunt-sass/compare/v1.2.1...v2.0.0
Props netweb.
See #35105 .
Fixes #43097 .
Built from https://develop.svn.wordpress.org/trunk@42463
git-svn-id: http://core.svn.wordpress.org/trunk@42292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:33:34 +00:00
3fe9cb61ee
External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
...
Props joemcgill.
Fixes #42720 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42462
git-svn-id: http://core.svn.wordpress.org/trunk@42291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:28:43 +00:00
ceaaed6604
Build: Use Node 8.x for trunk.
...
Props netweb.
See #35105 .
Built from https://develop.svn.wordpress.org/trunk@42461
git-svn-id: http://core.svn.wordpress.org/trunk@42290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 03:58:49 +00:00
406ec082cc
Build: Switch `package.json` to using tabs for indents.
...
Props netweb.
Fixes #43075 .
Built from https://develop.svn.wordpress.org/trunk@42460
git-svn-id: http://core.svn.wordpress.org/trunk@42289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 03:55:49 +00:00
bee0136037
Plugins: Update review filter links in Details modal.
...
Props darko-a7, afercia.
Fixes #43016 . See #meta3379.
Built from https://develop.svn.wordpress.org/trunk@42459
git-svn-id: http://core.svn.wordpress.org/trunk@42288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 00:15:46 +00:00
589395347a
Widgets: When checking for errors in Custom HTML widget, pass correct value to `toggleClass()` for Save button.
...
`toggleClass()` expects a boolean as a second argument, not an integer.
Props iCaleb.
Fixes #42867 .
Built from https://develop.svn.wordpress.org/trunk@42457
git-svn-id: http://core.svn.wordpress.org/trunk@42286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 23:47:47 +00:00
0d23b38fd3
Media: Add `small-audio.flac` for a unit test added in [42451].
...
See #42225 .
Built from https://develop.svn.wordpress.org/trunk@42453
git-svn-id: http://core.svn.wordpress.org/trunk@42283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:33:47 +00:00
13e40181eb
Media: Add `flac` to the list of allowed file types.
...
Props blobfolio.
Fixes #42225 .
Built from https://develop.svn.wordpress.org/trunk@42451
git-svn-id: http://core.svn.wordpress.org/trunk@42281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:17:47 +00:00
35653f0432
Media: Bring consistency to `getimagesize()` error suppression.
...
Props chasewg, joemcgill, jeremyfelt.
Fixes #42480 .
Built from https://develop.svn.wordpress.org/trunk@42449
git-svn-id: http://core.svn.wordpress.org/trunk@42279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:44:47 +00:00
9cb44f5f2f
Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.
...
Props chetan200891 for initial patch.
Fixes #42871 .
Built from https://develop.svn.wordpress.org/trunk@42447
git-svn-id: http://core.svn.wordpress.org/trunk@42277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:27:53 +00:00
1fb6a63449
TinyMCE: on the toolbar drop-downs apply overflow style on the actual element with text.
...
Props abdullahramzan, azaozz.
Fixes #43090 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42446
git-svn-id: http://core.svn.wordpress.org/trunk@42276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 09:51:48 +00:00
3fb8eee9fc
Accessibility: Media: Improve the usage of a few label elements in the media templates.
...
Label elements should only be used for labelable elements.
- `Uploaded By` and `Uploaded To` aren't form controls and shouldn't be associated with labels
- changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)
Props Presskopp, afercia.
Fixes #38759 , #40468 .
Built from https://develop.svn.wordpress.org/trunk@42444
git-svn-id: http://core.svn.wordpress.org/trunk@42274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-14 16:39:47 +00:00
239da4c1e6
Plugins: Fix the plugin details modal in the install plugin search tab after [41356].
...
Fixes #43082
Built from https://develop.svn.wordpress.org/trunk@42443
git-svn-id: http://core.svn.wordpress.org/trunk@42273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-13 18:53:51 +00:00
a492541c35
Formatting: Do not run formatting and texturization on author bios.
...
Removes the formatting and texturization added to author bios in #40040 due to back-compatibility concerns.
Reverts [41172], [41173].
Props 0x6f0, rabmalin for review.
Fixes #42578 .
Built from https://develop.svn.wordpress.org/trunk@42441
git-svn-id: http://core.svn.wordpress.org/trunk@42271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-13 01:11:49 +00:00
9c3344197d
Accessibility: use `aria-current` for the paginated post links output by `wp_link_pages()`.
...
Continues the introduction in core of the aria-current attribute after [41683], [41359], and [41371].
- changes the `wp_link_pages()` (see the `nextpage` quicktag) output to use an `aria-current` attribute on the current item
- adds `post-nav-links` and `post-page-numbers` CSS classes to help themes style these links
- updates the related tests
Props antonioeatgoat, alexstine.
Fixes #41859 .
Built from https://develop.svn.wordpress.org/trunk@42440
git-svn-id: http://core.svn.wordpress.org/trunk@42270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:17:51 +00:00
351d71d7ea
Twenty Seventeen: Remove unnecessary comment in `front-page.php`.
...
Props hardik-amipara, poena.
Fixes #42820 .
Built from https://develop.svn.wordpress.org/trunk@42437
git-svn-id: http://core.svn.wordpress.org/trunk@42267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:01:51 +00:00
6310ad30d0
Docs: Improve JS Docs for `controllers/customize-image-cropper.js`.
...
Props manuelaugustin, bramheijmink, andizer, ireneyoast.
Fixes #43020 .
Built from https://develop.svn.wordpress.org/trunk@42435
git-svn-id: http://core.svn.wordpress.org/trunk@42265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-11 14:32:52 +00:00
1d59873ace
Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
...
Props joemcgill, dd32.
Fixes #42963 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42433
git-svn-id: http://core.svn.wordpress.org/trunk@42263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 06:10:47 +00:00
cdfa5adc43
Streams: When checking in `wp_is_stream()` escape the stream wrapper names for PCRE to avoid PHP warnings when invalid stream wrappers are registered.
...
Fixes #43054 .
Built from https://develop.svn.wordpress.org/trunk@42432
git-svn-id: http://core.svn.wordpress.org/trunk@42262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 02:50:46 +00:00
7bfc60864f
Media: Skip `test_remove_orientation_data_on_rotate` if missing deps.
...
The `test_remove_orientation_data_on_rotate()` test was failing on systems that did not have the `exif` extension available.
Skips test when the `exif_read_data()` function does not exist.
Props danielbachhuber, desrosj.
Fixes #42447 .
Built from https://develop.svn.wordpress.org/trunk@42431
git-svn-id: http://core.svn.wordpress.org/trunk@42261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 01:17:51 +00:00
4a3faae0e8
Editor: ensure there is a selection before getting the caret position. Fixes a bug in Firefox when there is no selection for a hidden element.
...
Props johnschulz, azaozz.
Fixes #43012 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42430
git-svn-id: http://core.svn.wordpress.org/trunk@42260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-08 20:20:53 +00:00
fbb1f9162b
Formatting: Fix capital_P_dangit() not capital P-ing, dangit.
...
Unfortunately, in my overzealous desire to fix all the un-capitalised Ps, [42343] capitalled some Ps that intentionally should not be capitals.
This commit fixes the incorrectly capitalling of Ps, as well as including unit tests and PHPCS instructions to ensure we never capitulate to capitalisationing them again.
Props superdav42.
Fixes #43040 .
Fixes #43041 .
Built from https://develop.svn.wordpress.org/trunk@42429
git-svn-id: http://core.svn.wordpress.org/trunk@42259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-08 10:36:51 +00:00
d1c58e7850
Docs: Improve JSDoc for `js/media-upload.js`.
...
Props terwdan, diedeexterkate, andizer, ireneyoast.
Fixes #42956 .
Built from https://develop.svn.wordpress.org/trunk@42426
git-svn-id: http://core.svn.wordpress.org/trunk@42257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-04 14:37:49 +00:00
4e5215deec
Editor: Link suggestions: add fallback title for posts with no title.
...
Fixes #42664 .
Built from https://develop.svn.wordpress.org/trunk@42425
git-svn-id: http://core.svn.wordpress.org/trunk@42256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-02 18:11:52 +00:00
502dcd51a4
General: Update copyright year to 2018 in license.txt.
...
Fixes #43007 .
Built from https://develop.svn.wordpress.org/trunk@42424
git-svn-id: http://core.svn.wordpress.org/trunk@42255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-01 03:17:48 +00:00
2eca52eaa4
REST API: Adjust unit testes to expect a 401 status code in error responses from permission callbacks when user is not authenticated.
...
Missed in [42421].
Fixes #42828 .
Built from https://develop.svn.wordpress.org/trunk@42423
git-svn-id: http://core.svn.wordpress.org/trunk@42254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-01 02:31:46 +00:00
a787006298
REST API: Return the proper status code for failed permission callbacks in `WP_REST_Server->dispatch()`.
...
Use the `rest_authorization_required_code()` function to return a 401 status code when a permission callback fails due to a user not being logged in.
Props jaswrks.
Fixes #42828 .
Built from https://develop.svn.wordpress.org/trunk@42421
git-svn-id: http://core.svn.wordpress.org/trunk@42252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-30 20:37:47 +00:00
386a5c397f
Comments: Introduce filter for the arguments for the comment query in the comments list table.
...
Add `comments_list_table_query_args` filter to the Comments List Table.
Props soulseekah, birgire.
Fixes #42997 .
Built from https://develop.svn.wordpress.org/trunk@42420
git-svn-id: http://core.svn.wordpress.org/trunk@42251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-29 18:21:52 +00:00
02d04f2b5c
WP: Don't attempt to convert multiple-nested arrays to a string in WP->parse_request().
...
See #14330 .
Fixes #42752 .
Built from https://develop.svn.wordpress.org/trunk@42419
git-svn-id: http://core.svn.wordpress.org/trunk@42250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 03:18:47 +00:00
699025a785
Taxonomy: Restore deprecated argument to `term_description()` signature.
...
This ensures that the parameter can't be reused for something else
in the future.
Props jorbin.
Fixes #42605 .
Built from https://develop.svn.wordpress.org/trunk@42417
git-svn-id: http://core.svn.wordpress.org/trunk@42248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 02:48:51 +00:00
02b86b8418
Docs: Improve JSDoc for `customize-preview-widgets.js`.
...
Props ireneyoast, andizer, robinvandervliet, boblinthorst.
Fixes #42954 .
Built from https://develop.svn.wordpress.org/trunk@42416
git-svn-id: http://core.svn.wordpress.org/trunk@42247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 15:12:49 +00:00
f296e2cbbc
Docs: Improve JSDoc for `media/views/attachments.js`.
...
Props maartenleenders, herregroen, jipmoors, ireneyoast.
Fixes #42832 .
Built from https://develop.svn.wordpress.org/trunk@42415
git-svn-id: http://core.svn.wordpress.org/trunk@42246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 14:27:52 +00:00
7dfcb33d4d
Docs: Remove erroneous zero-width space before URL in `fetch_feed()` DocBlock.
...
Props coffee2code.
Fixes #42951 . See #meta3212.
Built from https://develop.svn.wordpress.org/trunk@42414
git-svn-id: http://core.svn.wordpress.org/trunk@42245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 02:40:54 +00:00
1caa918dbc
i18n: Don't use `esc_attr_e()` on a variable.
...
Props yoavf.
Fuxes #42935 .
Built from https://develop.svn.wordpress.org/trunk@42413
git-svn-id: http://core.svn.wordpress.org/trunk@42244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-20 05:35:50 +00:00
a5e2908bbd
Docs: Improve the function and parameter descriptions for `do_meta_boxes()`.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42412
git-svn-id: http://core.svn.wordpress.org/trunk@42243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-19 15:03:52 +00:00
f6a37e7d39
Docs: Remove `@summary` tags from JSDoc.
...
As decided in the JavaScript core chat. With a few reasons:
* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.
The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.
Props herregroen.
Fixes #42901 .
Built from https://develop.svn.wordpress.org/trunk@42411
git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
65b715c991
Docs: Improve JSDoc for `js/media/controllers/edit-image.js`.
...
Amends r42392 - includes the built media files.
Built from https://develop.svn.wordpress.org/trunk@42410
git-svn-id: http://core.svn.wordpress.org/trunk@42239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 11:20:47 +00:00
df07690883
Canonical: After [42408], remove `sprintf()` call for consistency with `Location` header.
...
See #42313 .
Built from https://develop.svn.wordpress.org/trunk@42409
git-svn-id: http://core.svn.wordpress.org/trunk@42238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 01:11:47 +00:00
0bc86bc220
Canonical: Introduce `x_redirect_by` filter that allows applications to identify themselves via `X-Redirect-By` header when they're doing a redirect.
...
Props joostdevalk.
Fixes #42313 .
Built from https://develop.svn.wordpress.org/trunk@42408
git-svn-id: http://core.svn.wordpress.org/trunk@42237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 01:04:52 +00:00
cb53982d1f
Media: Pass the attachment ID to the `intermediate_image_sizes_advanced` filter.
...
Props drywallbmb, robbie505
Fixes 42745
Built from https://develop.svn.wordpress.org/trunk@42407
git-svn-id: http://core.svn.wordpress.org/trunk@42236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-16 13:47:47 +00:00
3ee38c0a05
Login and Registration: Instruct the browser to disable autocapitalisation for the user login field on the login screen.
...
Props drywallbmb
Fixes #42886
Built from https://develop.svn.wordpress.org/trunk@42406
git-svn-id: http://core.svn.wordpress.org/trunk@42235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-16 13:41:48 +00:00
e123166a3a
Build/Test Tools: Instruct Git and Subversion to ignore Composer's `vendor` directory.
...
Props netweb
Fixes #42909
Built from https://develop.svn.wordpress.org/trunk@42405
git-svn-id: http://core.svn.wordpress.org/trunk@42234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-16 13:38:53 +00:00
d82e2b02be
Media: improve flows for cropping on attachment details screen.
...
On the "Attachment Details" screen:
* The crop button is always 'enabled'.
* Clicking the crop button with no selection selects the entire image.
* Clicking the crop button with the entire image selected doesn't do anything.
* Clicking the crop button with a selection crops as expected.
Props sonjanyc, afercia, mikeschroder.
Fixes #30155 .
Built from https://develop.svn.wordpress.org/trunk@42404
git-svn-id: http://core.svn.wordpress.org/trunk@42233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 22:03:50 +00:00
1f707de9dd
Docs: Improve wp-admin JSDoc structural data globally.
...
JSDoc takes it structural data from `@namespace`, `@lends` and `@memberOf`. This change fixes these tags for all JavaScript files in the wp-admin folder.
* Add jsdoc configuration to parse wp-admin/js files. Use `jsdoc -c jsdoc.conf.json` to generate JSDoc.
* Define all used namespaces using `@namespace`.
* Define each usage of the extend function as a prototype assignment using `@lends`.
* Add `@alias` if JSDoc cannot detect the correct name automatically.
This has previously been corrected for all `wp-includes` JavaScript files: [41351].
Props herregroen.
Fixes #42485 .
Built from https://develop.svn.wordpress.org/trunk@42403
git-svn-id: http://core.svn.wordpress.org/trunk@42232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 13:42:46 +00:00
36498bd601
Improve performance of `wp_list_pages()` tests.
...
The changeset also removes the use of hardcoded post/author IDs.
Props frank-klein.
Fixes #42903 .
Built from https://develop.svn.wordpress.org/trunk@42402
git-svn-id: http://core.svn.wordpress.org/trunk@42231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 11:15:46 +00:00
6da54f0d9b
Canonical URLs: Redirect to the correct URL when the post date changes.
...
When a post slug is changed, we store a copy of the old slug, so that we can redirect visitors visiting the old URL to the new URL.
In the same way, this stores a copy of the old date, when the post date changes, so we can redirect visitors to the new URL.
Props nickmomrik.
Fixes #15397 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42401
git-svn-id: http://core.svn.wordpress.org/trunk@42230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 08:31:47 +00:00
7c77266b9b
Docs: Remove extra dot from some `@since` tags.
...
Props hardik-amipara.
Fixes #42899 .
Built from https://develop.svn.wordpress.org/trunk@42400
git-svn-id: http://core.svn.wordpress.org/trunk@42229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 05:16:47 +00:00
a3f69ffaa3
Docs: Add missing `@staticvar` entries in `wp-includes/l10n.php`.
...
Props birgire.
Fixes #42800 .
Built from https://develop.svn.wordpress.org/trunk@42399
git-svn-id: http://core.svn.wordpress.org/trunk@42228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 05:08:51 +00:00
ff89ce1879
Posts: Rename `$ID` to `$post` in `get_post_mime_type()` and `get_post_status()` for consistency with other functions.
...
See #42797 .
Built from https://develop.svn.wordpress.org/trunk@42398
git-svn-id: http://core.svn.wordpress.org/trunk@42227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 01:03:47 +00:00
0d09b75c4b
Docs: Add missing parameter description in `wp_get_post_parent_id()` function DocBlock.
...
Rename `$post_ID` to `$post` for consistency with other functions.
Add unit tests for `wp_get_post_parent_id()`.
Props keesiemeijer.
Fixes #42797 .
Built from https://develop.svn.wordpress.org/trunk@42397
git-svn-id: http://core.svn.wordpress.org/trunk@42226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 01:02:48 +00:00
faa04cf9b3
Docs: Add `@since` version for `WP_Customize_Widgets::filter_dynamic_sidebar_params()`.
...
Props keesiemeijer.
Fixes #42894 .
Built from https://develop.svn.wordpress.org/trunk@42396
git-svn-id: http://core.svn.wordpress.org/trunk@42225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 00:35:47 +00:00
835bec6282
Docs: Add `@since` version for `WP_Locale_Switcher::init()`.
...
Props keesiemeijer.
Fixes #42798 .
Built from https://develop.svn.wordpress.org/trunk@42395
git-svn-id: http://core.svn.wordpress.org/trunk@42224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 00:32:46 +00:00
986e46d2c0
Docs: Add missing `@since` tags for add menu page functions.
...
Props keesiemeijer.
Fixes #42882 .
Built from https://develop.svn.wordpress.org/trunk@42394
git-svn-id: http://core.svn.wordpress.org/trunk@42223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 00:15:52 +00:00
f544da9b38
Docs: Improve JS Docs for `wp-admin/js/dashboard.js`.
...
Props jipmoors, andizer, ireneyoast, boblinthorst.
Fixes #42831 .
Built from https://develop.svn.wordpress.org/trunk@42393
git-svn-id: http://core.svn.wordpress.org/trunk@42222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-14 14:11:51 +00:00
a846a553a1
Docs: Improve JS Docs for `js/media/controllers/edit-image.js`.
...
Props jjcomack, nicollle, andizer.
Fixes #42680 .
Built from https://develop.svn.wordpress.org/trunk@42392
git-svn-id: http://core.svn.wordpress.org/trunk@42221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-13 14:10:52 +00:00
fe2fda8cc2
Editor: Fix determining TinyMCE editor width when in inline mode instead of iframe mode.
...
See #40854 .
Amends [41985].
Props aduth.
Fixes #42416 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42390
git-svn-id: http://core.svn.wordpress.org/trunk@42219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-13 05:17:48 +00:00
1a357d3758
Docs: Improve JS Docs for `wp-includes/js/heartbeat.js`.
...
Most of the documentation was already present. This change achieves the following:
* Fixes the formatting for most doc blocks.
* Adds `@since` tags to all functions.
* Makes sure the heartbeat public methods are correctly added to the `wp.heartbeat` namespace.
Props andizer, jjcomack, carolinegeven.
Fixes #42675 .
Built from https://develop.svn.wordpress.org/trunk@42389
git-svn-id: http://core.svn.wordpress.org/trunk@42218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-12 14:33:54 +00:00
04efa7e7ea
WPDB: Always use `mysqli` when available.
...
This change makes WordPress use `mysqli` on PHP <5.5 when available, instead of only in PHP 5.5+ and development installs.
WPDB includes a fallback to `mysql` in the event that the database connection fails with `mysqli` so incompatibilities should be few and far between.
Fixes #42812 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42388
git-svn-id: http://core.svn.wordpress.org/trunk@42217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-12 05:43:48 +00:00
6322887487
Filesystem: Allow `wp_normalise_path()` to handle PHP stream wrappers such as `php://` correctly.
...
Props calin, dd32.
Fixes #42837 .
Built from https://develop.svn.wordpress.org/trunk@42387
git-svn-id: http://core.svn.wordpress.org/trunk@42216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-12 04:16:47 +00:00
d6ffe16606
Twenty Ten: Use global img contraint for captions
...
Fixes an incompatibility with the way caption width is set since 4.9, where the caption element would cover the whole content width.
Props slilley, Clorith, hardeepasrani.
Fixes #42604 .
Built from https://develop.svn.wordpress.org/trunk@42386
git-svn-id: http://core.svn.wordpress.org/trunk@42215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-11 23:32:46 +00:00
Sergey Biryukov
Andrew Ozz
Adam Silverstein
John Blackbourn
Andrea Fercia
Mike Schroder
Dominik Schilling
Boone Gorges
iandunn
Pascal Birchler
Gary Pendergast
Aaron Jorbin
Mark Jaquith
Peter Wilson
Konstantin Obenland
atimmer
Drew Jaynes
Helen Hou-Sandí
Felix Arntz
Dion Hulse
Weston Ruter
Rachel Baker