Scott Taylor
bf43be3e9e
Add missing doc blocks to `wp-image-editor*.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32546
git-svn-id: http://core.svn.wordpress.org/trunk@32516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 06:18:25 +00:00
Scott Taylor
af7a017f46
When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32545
git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
Scott Taylor
1fa7958fe8
Clean up doc blocks for `class-wp-embed.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32544
git-svn-id: http://core.svn.wordpress.org/trunk@32514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:15:26 +00:00
Scott Taylor
94f29f27a1
Clean up `@global` doc blocks/imports for `class-wp-editor.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32543
git-svn-id: http://core.svn.wordpress.org/trunk@32513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:10:24 +00:00
Scott Taylor
082bfab426
Clean up `@global` doc blocks/imports for `class-wp-customizer-*.php` and friends.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32542
git-svn-id: http://core.svn.wordpress.org/trunk@32512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:06:25 +00:00
Scott Taylor
1b52916239
Create a function, `wp_roles()`, to DRY the inline instantiation of the `$wp_roles` global.
...
Add missing doc blocks for `capabilities.php`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32541
git-svn-id: http://core.svn.wordpress.org/trunk@32511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:47:24 +00:00
Scott Taylor
3d130ba909
Add missing doc blocks for `canonical.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32540
git-svn-id: http://core.svn.wordpress.org/trunk@32510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:26:26 +00:00
Scott Taylor
ebd3201268
Add/standardize missing doc blocks for `cache.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32539
git-svn-id: http://core.svn.wordpress.org/trunk@32509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:24:26 +00:00
Scott Taylor
5c6ffc4dd6
Add missing doc blocks to `author-template.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32538
git-svn-id: http://core.svn.wordpress.org/trunk@32508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:14:24 +00:00
Scott Taylor
83dd461b2f
Add missing doc blocks to `admin-bar.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32537
git-svn-id: http://core.svn.wordpress.org/trunk@32507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:00:26 +00:00
Scott Taylor
3a5f584109
Add missing doc blocks to `class-wp-editor.php`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32536
git-svn-id: http://core.svn.wordpress.org/trunk@32506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 03:52:27 +00:00
Scott Taylor
b2bbbf9759
In `class-wp-customize-*`, clarify/add some `@param`/`@return` blocks. Disambiguate some functions that are trying to return the `void` response of another function they call internally.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32535
git-svn-id: http://core.svn.wordpress.org/trunk@32505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 22:05:24 +00:00
Scott Taylor
f7098c8c2e
In `class-wp-admin-bar.php`, clarify/add some doc blocks.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32534
git-svn-id: http://core.svn.wordpress.org/trunk@32504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:39:24 +00:00
Scott Taylor
3c24a2b32b
In `class-oembed.php`, clarify/add some `return` docs.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32533
git-svn-id: http://core.svn.wordpress.org/trunk@32503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:31:27 +00:00
Scott Taylor
ed4aafa692
In `category.php`:
...
* Clarify some `return` docs.
* In `_make_cat_compat()`, ensure that `WP_Error` is not decorated
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32532
git-svn-id: http://core.svn.wordpress.org/trunk@32502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:18:24 +00:00
Scott Taylor
27522d1c00
In `category-template.php`:
...
* Clarify/add some `return` docs.
* In `walk_category_tree()` and `walk_category_dropdown_tree()`, make behavior consistent and don't pass `$walker` by-reference - it is no longer necessary to do that with object instances.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32531
git-svn-id: http://core.svn.wordpress.org/trunk@32501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:05:24 +00:00
Scott Taylor
e724ed2b04
In `capabilities.php`, clarify/add some `return` docs.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32530
git-svn-id: http://core.svn.wordpress.org/trunk@32500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:47:26 +00:00
Scott Taylor
3f32bf7bc0
In `canonical.php`:
...
* Clarify some docs
* `redirect_canonical()` inconsistently returns `null` or `false` when bailing - can simply return.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32529
git-svn-id: http://core.svn.wordpress.org/trunk@32499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:30:25 +00:00
Scott Taylor
9b3271f635
In `cache.php`, clarify some `return` docs. Some `WP_Object_Cache` methods return `void`, so those wrapper functions don't need to return at all.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32528
git-svn-id: http://core.svn.wordpress.org/trunk@32498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:22:24 +00:00
Scott Taylor
e4c19c591f
In `bookmark.php`, clarify some `return` docs.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32527
git-svn-id: http://core.svn.wordpress.org/trunk@32497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:13:25 +00:00
Scott Taylor
04554bc30d
In `author-template.php`, clarify/add some `return` docs.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32526
git-svn-id: http://core.svn.wordpress.org/trunk@32496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:10:26 +00:00
Scott Taylor
c92608aebd
In `admin-bar.php`, most functions simply return when a conditional is not met. `wp_admin_bar_render()` shouldn't explicitly return `false`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32525
git-svn-id: http://core.svn.wordpress.org/trunk@32495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:09:24 +00:00
Boone Gorges
9d54232e39
Streamline support for multiple post types in `get_posts_by_author_sql()`.
...
* Don't accept a comma-separated list, only a single post type or an array of post types. This is easier to document.
* Add changelog entries to all calling functions.
Props DrewAPicture.
Fixes #32243 .
Built from https://develop.svn.wordpress.org/trunk@32524
git-svn-id: http://core.svn.wordpress.org/trunk@32494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 19:49:29 +00:00
Boone Gorges
67c935ad9c
Support multiple post types in `count_user_posts()` and other functions that use `get_posts_by_author_sql()`.
...
Props nikonratm.
Fixes #32243 .
Built from https://develop.svn.wordpress.org/trunk@32523
git-svn-id: http://core.svn.wordpress.org/trunk@32493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:43:27 +00:00
Helen Hou-Sandí
248a49c930
Updates: Use the warning color for the backup notice, as it's not a success message.
...
props paulwilde.
fixes #32241 .
Built from https://develop.svn.wordpress.org/trunk@32522
git-svn-id: http://core.svn.wordpress.org/trunk@32492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:10:25 +00:00
Aaron Jorbin
2dff825af7
In List Tables, ensure sorting indicator is visible on focus
...
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose.
Happy #GAAD
Props afercia
Fixes #32189
Built from https://develop.svn.wordpress.org/trunk@32521
git-svn-id: http://core.svn.wordpress.org/trunk@32491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:05:26 +00:00
Boone Gorges
33b99991a8
In `sanitize_option()`, pass the unsanitized `$value` to the filter.
...
Props simonwheatley, MikeHansenMe.
Fixes #26199 .
Built from https://develop.svn.wordpress.org/trunk@32520
git-svn-id: http://core.svn.wordpress.org/trunk@32490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:00:26 +00:00
Boone Gorges
33b61a9244
Add tests for `check_comment()`.
...
Props CalEvans, rachelbaker.
Fixes #31108 .
Built from https://develop.svn.wordpress.org/trunk@32519
git-svn-id: http://core.svn.wordpress.org/trunk@32489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-20 19:09:25 +00:00
John Blackbourn
cde30a03aa
Use the available user and blog factories in the `Tests_Multisite_Option::test_with_another_site()` test.
...
Fixes #32404
Built from https://develop.svn.wordpress.org/trunk@32518
git-svn-id: http://core.svn.wordpress.org/trunk@32488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-20 19:03:26 +00:00
Scott Taylor
a69b8b3b91
In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32517
git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:50:27 +00:00
Scott Taylor
5a3dc2a371
In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32516
git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:46:25 +00:00
Scott Taylor
45d897d0e7
In `wpdb::load_col_info()`, don't fetch the number of fields in the result row on each iteration of the `for` loop. It can be stored in a var and referenced.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32515
git-svn-id: http://core.svn.wordpress.org/trunk@32485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:30:27 +00:00
Jeremy Felt
2a2e976501
Move network update submenu items to the Network Dashboard menu item
...
Provides parity with the placement of the "Updates" submenu item in single site.
props Ipstenu.
fixes #32431 .
Built from https://develop.svn.wordpress.org/trunk@32514
git-svn-id: http://core.svn.wordpress.org/trunk@32484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 17:00:29 +00:00
Jeremy Felt
3471545942
s/anbled/enabled/ in `global_terms_enabled` filter documentation.
...
Fixes #32436 .
Built from https://develop.svn.wordpress.org/trunk@32513
git-svn-id: http://core.svn.wordpress.org/trunk@32483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 06:35:25 +00:00
Jeremy Felt
de7074efab
Use `WP_TESTS_DOMAIN` in `test_get_blogaddress_by_id_with_valid_id()`
...
A hard coded `example.org` would break the test if a custom `WP_TESTS_DOMAIN` was specified. We should defer to the configured default.
Fixes #32026 .
Built from https://develop.svn.wordpress.org/trunk@32512
git-svn-id: http://core.svn.wordpress.org/trunk@32482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 05:46:28 +00:00
Sergey Biryukov
96f787260f
In `comment_form()`, ensure that filtered arguments contain all required default values.
...
props boonebgorges.
fixes #32312 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32511
git-svn-id: http://core.svn.wordpress.org/trunk@32481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 01:04:25 +00:00
Sergey Biryukov
d40fe7d80b
Allow `wp_dropdown_languages()` to return the markup instead of displaying.
...
props leewillis77, juliobox.
fixes #32432 .
Built from https://develop.svn.wordpress.org/trunk@32510
git-svn-id: http://core.svn.wordpress.org/trunk@32480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 00:33:26 +00:00
Helen Hou-Sandí
348ec03052
Accessibility: Ensure screen reader text is read as words and not affected by word-wrap.
...
props afercia.
fixes #31962 .
Built from https://develop.svn.wordpress.org/trunk@32509
git-svn-id: http://core.svn.wordpress.org/trunk@32479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-18 18:37:29 +00:00
Helen Hou-Sandí
7381d50904
Autoprefixer for [32506]. see #31874 .
...
Built from https://develop.svn.wordpress.org/trunk@32508
git-svn-id: http://core.svn.wordpress.org/trunk@32478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 20:44:25 +00:00
Boone Gorges
0949d6492f
Improve unit tests for `wp_unique_term_slug()`.
...
See #20783 .
Built from https://develop.svn.wordpress.org/trunk@32507
git-svn-id: http://core.svn.wordpress.org/trunk@32477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 20:38:27 +00:00
Helen Hou-Sandí
1e8a787aa1
Media: Visually align upload errors with other admin notices.
...
props sagarjadhav.
fixes #31874 .
Built from https://develop.svn.wordpress.org/trunk@32506
git-svn-id: http://core.svn.wordpress.org/trunk@32476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 16:19:26 +00:00
Andrew Ozz
8cbfdfa51b
Fix dragging to the bottom of the screen on the Dashboard.
...
Props eltobiano. See #32094 .
Built from https://develop.svn.wordpress.org/trunk@32505
git-svn-id: http://core.svn.wordpress.org/trunk@32475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 23:50:28 +00:00
Dion Hulse
2ba7f3da75
Allow plugins to activate other plugins within their Activation hook. Fixes #32368
...
Built from https://develop.svn.wordpress.org/trunk@32504
git-svn-id: http://core.svn.wordpress.org/trunk@32474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 06:58:27 +00:00
Scott Taylor
1c0fa5f73a
In `tb_show()` in `thickbox`, when loading content into `#TB_ajaxContent`, make sure a URL with no `?` doesn't break when `&random=` is appended to it.
...
Thickbox hasn't been updated since 2007, just FYI.
Fixes #31726 .
Built from https://develop.svn.wordpress.org/trunk@32503
git-svn-id: http://core.svn.wordpress.org/trunk@32473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:42:24 +00:00
Scott Taylor
2f82bbb60d
In `views/button/select-mode-toggle`, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's `toggleBulkEditHandler` method.
...
Props afercia.
Fixes #32324 .
Built from https://develop.svn.wordpress.org/trunk@32502
git-svn-id: http://core.svn.wordpress.org/trunk@32472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:27:27 +00:00
John Blackbourn
1c40b495a1
Add a viewport meta tag to `wp_die()`.
...
Props leogopal
Fixes #29336
Built from https://develop.svn.wordpress.org/trunk@32501
git-svn-id: http://core.svn.wordpress.org/trunk@32471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 04:08:25 +00:00
Drew Jaynes
2aa620b76a
Update the DocBlock for `wp_new_comment()` to reference the `wp_insert_comment()` documentation for argument information.
...
Fixes #31747 .
Built from https://develop.svn.wordpress.org/trunk@32500
git-svn-id: http://core.svn.wordpress.org/trunk@32470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 02:54:26 +00:00
Drew Jaynes
4769bd2a4f
Document the default arguments for `wp_insert_comment()` as a hash notation.
...
Props lamosty, rachelbaker.
See #31747 .
Built from https://develop.svn.wordpress.org/trunk@32499
git-svn-id: http://core.svn.wordpress.org/trunk@32469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 02:51:28 +00:00
Boone Gorges
63eb910445
Respect `$_wp_suspend_cache_invalidation` in `clean_term_cache()`.
...
Props tollmanz, rmccue.
Fixes #28743 .
Built from https://develop.svn.wordpress.org/trunk@32498
git-svn-id: http://core.svn.wordpress.org/trunk@32468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 20:14:26 +00:00
Lance Willett
4633e1eb79
Twenty Fifteen: add missing social link Genericons styles for Skype and Path.
...
Fixes #32332 , props philiparthurmoore.
Built from https://develop.svn.wordpress.org/trunk@32497
git-svn-id: http://core.svn.wordpress.org/trunk@32467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 18:15:27 +00:00