WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,811 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

4304 Commits

Author SHA1 Message Date
Andrew Nacin 5a0b227316 Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.) 
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.

Built from https://develop.svn.wordpress.org/trunk@25859


git-svn-id: http://core.svn.wordpress.org/trunk@25771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-21 22:29:09 +00:00
Andrew Nacin ee489a2e81 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED. 
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25851


git-svn-id: http://core.svn.wordpress.org/trunk@25763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-18 21:24:10 +00:00
Andrew Nacin c00bba9e8b Use correct variable. fixes #10787. 
Built from https://develop.svn.wordpress.org/trunk@25843


git-svn-id: http://core.svn.wordpress.org/trunk@25755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-18 17:16:10 +00:00
Andrew Nacin ee20af1fad Notify administrators of successful, failed, and pending core updates. 
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.

Built from https://develop.svn.wordpress.org/trunk@25841


git-svn-id: http://core.svn.wordpress.org/trunk@25753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-18 16:30:11 +00:00
Andrew Nacin 859da01c4a Delete expired transients on database upgrades. 
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

Built from https://develop.svn.wordpress.org/trunk@25838


git-svn-id: http://core.svn.wordpress.org/trunk@25750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-18 07:48:09 +00:00
Andrew Nacin 5f3e90a112 Introduce email templates for automatic background updates. 
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.

Built from https://develop.svn.wordpress.org/trunk@25837


git-svn-id: http://core.svn.wordpress.org/trunk@25749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-18 06:33:10 +00:00
Andrew Nacin 325ccd0a14 set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin. 
fixes #25622.

Built from https://develop.svn.wordpress.org/trunk@25836


git-svn-id: http://core.svn.wordpress.org/trunk@25748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 23:24:09 +00:00
Andrew Nacin a65661abee In automatic background updates, standardize on 'update'. 
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25835


git-svn-id: http://core.svn.wordpress.org/trunk@25747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 23:21:10 +00:00
Dion Hulse 924e35d66a Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check). 
See #25576, #22704

Built from https://develop.svn.wordpress.org/trunk@25831


git-svn-id: http://core.svn.wordpress.org/trunk@25743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 18:40:10 +00:00
Dion Hulse 1c8d882e13 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock. 
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25828


git-svn-id: http://core.svn.wordpress.org/trunk@25740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 05:24:09 +00:00
Andrew Nacin 9432acde4e Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 04:02:09 +00:00
Andrew Nacin 191efaef61 Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods. 
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25823


git-svn-id: http://core.svn.wordpress.org/trunk@25735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 00:55:09 +00:00
Dion Hulse 640f73ecd2 Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200 
Built from https://develop.svn.wordpress.org/trunk@25822


git-svn-id: http://core.svn.wordpress.org/trunk@25734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 00:12:10 +00:00
Dion Hulse 376a0a55c7 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200 
Built from https://develop.svn.wordpress.org/trunk@25818


git-svn-id: http://core.svn.wordpress.org/trunk@25730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 22:27:09 +00:00
Dion Hulse ed07bab4b4 When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704 
Built from https://develop.svn.wordpress.org/trunk@25817


git-svn-id: http://core.svn.wordpress.org/trunk@25729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 19:48:10 +00:00
Andrew Nacin bccefbbd83 Merge the should_auto_update() and can_auto_update() methods. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25815


git-svn-id: http://core.svn.wordpress.org/trunk@25727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 19:35:09 +00:00
Dion Hulse 085f5c5fb9 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200 
Built from https://develop.svn.wordpress.org/trunk@25812


git-svn-id: http://core.svn.wordpress.org/trunk@25724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 17:07:08 +00:00
Dion Hulse 8c35982ae8 Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath. 
See #18201

Built from https://develop.svn.wordpress.org/trunk@25811


git-svn-id: http://core.svn.wordpress.org/trunk@25723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 15:20:10 +00:00
Andrew Nacin ba0ebf3736 Include translations in the update bubbles (as +1 if there are any). see #18200. 
Built from https://develop.svn.wordpress.org/trunk@25810


git-svn-id: http://core.svn.wordpress.org/trunk@25722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 14:34:10 +00:00
Dion Hulse 84cec7b526 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin. 
See #18200, [25806]

Built from https://develop.svn.wordpress.org/trunk@25807


git-svn-id: http://core.svn.wordpress.org/trunk@25719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 04:19:09 +00:00
Dion Hulse 1c8e79353a Language Packs: Many many fixes such as: 
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704


Built from https://develop.svn.wordpress.org/trunk@25806


git-svn-id: http://core.svn.wordpress.org/trunk@25718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 04:15:09 +00:00
Andrew Nacin 9fe39c464a Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value. 
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.

Built from https://develop.svn.wordpress.org/trunk@25805


git-svn-id: http://core.svn.wordpress.org/trunk@25717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 04:02:09 +00:00
Andrew Nacin 4542fbb2ae Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief. 
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.

Built from https://develop.svn.wordpress.org/trunk@25801


git-svn-id: http://core.svn.wordpress.org/trunk@25713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 23:03:10 +00:00
Andrew Nacin 9507d22243 Use correct variable. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25800


git-svn-id: http://core.svn.wordpress.org/trunk@25712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 22:07:09 +00:00
Andrew Nacin 95831a8a67 Remove accidental debug cruft in [25780]. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25799


git-svn-id: http://core.svn.wordpress.org/trunk@25711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 21:24:09 +00:00
Andrew Nacin 2100fa65fd Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet. 
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25798


git-svn-id: http://core.svn.wordpress.org/trunk@25710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 20:35:10 +00:00
Andrew Nacin a6188bc84a Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied. 
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25797


git-svn-id: http://core.svn.wordpress.org/trunk@25709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 20:01:09 +00:00
Andrew Nacin 82547b21b6 In show_message(), only print error data if it is a string. 
see #25576, [25775].

Built from https://develop.svn.wordpress.org/trunk@25796


git-svn-id: http://core.svn.wordpress.org/trunk@25708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 19:51:10 +00:00
Andrew Nacin 26c03ea5fb Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport. 
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25794


git-svn-id: http://core.svn.wordpress.org/trunk@25706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 19:18:10 +00:00
Andrew Nacin eeaad19a26 Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir(). 
This occurs when we can't copy a file. We chmod it and try again.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25793


git-svn-id: http://core.svn.wordpress.org/trunk@25705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 19:14:10 +00:00
Dion Hulse 592123951b Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/. 
My bad. See #22704, [25781].

Built from https://develop.svn.wordpress.org/trunk@25787


git-svn-id: http://core.svn.wordpress.org/trunk@25699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 14:55:09 +00:00
Andrew Nacin e503d0e2ec Hide auto updates from update-core.php directly in get_core_updates(). see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25783


git-svn-id: http://core.svn.wordpress.org/trunk@25696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 05:07:10 +00:00
Andrew Nacin 957df34182 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback. 
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25782


git-svn-id: http://core.svn.wordpress.org/trunk@25695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 02:59:10 +00:00
Andrew Nacin cdede88a23 Automatic updates: Include error data in the follow-up API request. 
props dd32.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25781


git-svn-id: http://core.svn.wordpress.org/trunk@25694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 23:33:10 +00:00
Andrew Nacin 9b56d4d11f Parse absolute paths out of error data. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25780


git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 22:25:08 +00:00
Dion Hulse 4dcca90887 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return. 
See #22704

Built from https://develop.svn.wordpress.org/trunk@25779


git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 21:55:09 +00:00
Andrew Nacin 4fa3687e6a Account for the possible failure of disk_free_space() in update_core(). 
see #22704, #25576.

Built from https://develop.svn.wordpress.org/trunk@25778


git-svn-id: http://core.svn.wordpress.org/trunk@25691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 21:15:10 +00:00
Andrew Nacin 3e3c085db3 Auto updates: Only attempt a roll back when we've hit a critical error code. 
Specifically, this means when we've failed in copying files.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25777


git-svn-id: http://core.svn.wordpress.org/trunk@25690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 21:03:09 +00:00
Andrew Nacin 145dbde82f Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files. 
see #25576.

Built from https://develop.svn.wordpress.org/trunk@25776


git-svn-id: http://core.svn.wordpress.org/trunk@25689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 20:58:09 +00:00
Andrew Nacin 1516b990f1 In the upgrader, only print additional error data if it is a string. 
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.

Built from https://develop.svn.wordpress.org/trunk@25775


git-svn-id: http://core.svn.wordpress.org/trunk@25688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 20:20:10 +00:00
Andrew Nacin d68a80217f In unzip_file(), confirm we have enough available disk space before extracting. 
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.

Built from https://develop.svn.wordpress.org/trunk@25774


git-svn-id: http://core.svn.wordpress.org/trunk@25687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 20:15:09 +00:00
Andrew Nacin 2d898df04f More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25772


git-svn-id: http://core.svn.wordpress.org/trunk@25685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 19:38:10 +00:00
Andrew Nacin 4c90c3cb31 Add explicit link to the installation being updated in debugging emails. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25770


git-svn-id: http://core.svn.wordpress.org/trunk@25683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-12 20:18:10 +00:00
Andrew Nacin de1d3c8261 Silence possible warnings from is_dir(). fixes #25572. 
Built from https://develop.svn.wordpress.org/trunk@25764


git-svn-id: http://core.svn.wordpress.org/trunk@25677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-11 17:11:10 +00:00
Andrew Nacin 29f5f5b5fd Refine error codes throughout the upgrader so we can better detect at what stage updates fail. 
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25763


git-svn-id: http://core.svn.wordpress.org/trunk@25676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-11 16:06:11 +00:00
Andrew Nacin 2a8dcbae1f Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25755


git-svn-id: http://core.svn.wordpress.org/trunk@25668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-10 14:46:11 +00:00
Dion Hulse 186a5379e8 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704 
Built from https://develop.svn.wordpress.org/trunk@25752


git-svn-id: http://core.svn.wordpress.org/trunk@25665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-10 01:57:08 +00:00
Dion Hulse 0b9f198994 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful. 
See #22704

Built from https://develop.svn.wordpress.org/trunk@25750


git-svn-id: http://core.svn.wordpress.org/trunk@25663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-10 01:32:09 +00:00
Andrew Nacin f0eb99952c Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height. 
props plocha.
fixes #25038.

Built from https://develop.svn.wordpress.org/trunk@25744


git-svn-id: http://core.svn.wordpress.org/trunk@25657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-09 19:07:17 +00:00
Helen Hou-Sandí 75eb364ced Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410. 
Built from https://develop.svn.wordpress.org/trunk@25741


git-svn-id: http://core.svn.wordpress.org/trunk@25654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-09 18:47:09 +00:00
Dion Hulse 543d84a379 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069 
Built from https://develop.svn.wordpress.org/trunk@25739


git-svn-id: http://core.svn.wordpress.org/trunk@25652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-09 16:47:09 +00:00
Scott Taylor 7a7b9c89ec Use parens to ensure that RegEx OR matches the front when determining that mime-type matches `audio|video` in `attachment_submitbox_metadata()`. 
Props kovshenin.
See #23926.


Built from https://develop.svn.wordpress.org/trunk@25727


git-svn-id: http://core.svn.wordpress.org/trunk@25640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-08 15:32:10 +00:00
Andrew Nacin a00df382a3 Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping. 
props SergeyBiryukov.
see #25023.
for trunk.

Built from https://develop.svn.wordpress.org/trunk@25719


git-svn-id: http://core.svn.wordpress.org/trunk@25632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-07 18:35:09 +00:00
Drew Jaynes ec96affcad Inline documentation for hooks in wp-admin/includes/bookmark.php. 
Props johnafish, kpdesign.
Fixes #25494.

Built from https://develop.svn.wordpress.org/trunk@25706


git-svn-id: http://core.svn.wordpress.org/trunk@25620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-07 02:19:09 +00:00
Andrew Nacin a8ea7828e9 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates. 
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25700


git-svn-id: http://core.svn.wordpress.org/trunk@25615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 15:46:09 +00:00
Andrew Nacin f29acee299 Don't modify post_author during a quick edit when the post type doesn't support authors. 
props ocean90.
fixes #16645.

Built from https://develop.svn.wordpress.org/trunk@25698


git-svn-id: http://core.svn.wordpress.org/trunk@25613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 13:15:09 +00:00
Andrew Nacin e8e5f48905 Run _fix_attachment_links() when post_status is future or private in addition to publish. 
Fixes regression caused by [20308].

props jond3r.
fixes #25268.

Built from https://develop.svn.wordpress.org/trunk@25697


git-svn-id: http://core.svn.wordpress.org/trunk@25612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 12:56:09 +00:00
Andrew Nacin d93d8b850d Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.

Built from https://develop.svn.wordpress.org/trunk@25695


git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 10:56:09 +00:00
Andrew Nacin e4dc691e75 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override. 
props azaozz.
fixes #24930.

Built from https://develop.svn.wordpress.org/trunk@25694


git-svn-id: http://core.svn.wordpress.org/trunk@25609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 10:46:09 +00:00
Andrew Nacin 8392f942a4 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009. 
Built from https://develop.svn.wordpress.org/trunk@25691


git-svn-id: http://core.svn.wordpress.org/trunk@25607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-05 10:59:12 +00:00
Andrew Nacin 4c63d45139 Avoid counting auto-drafts in sticky. 
props nofearinc.
fixes #25127.

Built from https://develop.svn.wordpress.org/trunk@25678


git-svn-id: http://core.svn.wordpress.org/trunk@25594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-03 01:16:10 +00:00
Andrew Nacin 49af5f34d7 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses. 
props creativeinfusion.
fixes #24818.

Built from https://develop.svn.wordpress.org/trunk@25676


git-svn-id: http://core.svn.wordpress.org/trunk@25592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-03 01:00:09 +00:00
Andrew Nacin be366723d2 Don't use a double negative. 
props TobiasBg.
fixes #18201.

Built from https://develop.svn.wordpress.org/trunk@25674


git-svn-id: http://core.svn.wordpress.org/trunk@25590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 21:50:09 +00:00
Andrew Nacin 524b62c5f6 Links manager: Restrict field length based on DB schema. 
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.

Built from https://develop.svn.wordpress.org/trunk@25670


git-svn-id: http://core.svn.wordpress.org/trunk@25586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 21:11:10 +00:00
Dominik Schilling e4c8d56b76 Replace use of global `$user_ID` in favor of `get_current_user_id()`. fixes #25372. 
Built from https://develop.svn.wordpress.org/trunk@25669


git-svn-id: http://core.svn.wordpress.org/trunk@25585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 21:10:09 +00:00
Andrew Nacin 7de2054ece Show a proper error message on the dashboard when the current theme is broken. 
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.

Built from https://develop.svn.wordpress.org/trunk@25666


git-svn-id: http://core.svn.wordpress.org/trunk@25582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 20:50:09 +00:00
Scott Taylor 6a5d2f8fb0 Rather than adding a `taxonomy` arg to `get_category()`, convert all uses of `get_category()` in core to `get_term()`. By doing so, we negate the need to call `_make_cat_compat()` in a few places that are only looking for a single property. 
Fixes #8722.


Built from https://develop.svn.wordpress.org/trunk@25662


git-svn-id: http://core.svn.wordpress.org/trunk@25578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 19:59:10 +00:00
Andrew Nacin 01484339b9 More string cleanups. 
Built from https://develop.svn.wordpress.org/trunk@25658


git-svn-id: http://core.svn.wordpress.org/trunk@25575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 18:51:10 +00:00
Andrew Nacin bc842ab011 This error message should have a period. 
Built from https://develop.svn.wordpress.org/trunk@25656


git-svn-id: http://core.svn.wordpress.org/trunk@25573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 17:45:09 +00:00
Andrew Nacin 32376e99be Rollback is not a verb. 
Built from https://develop.svn.wordpress.org/trunk@25655


git-svn-id: http://core.svn.wordpress.org/trunk@25572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 17:44:09 +00:00
Dion Hulse 55822259df Automatic Updates: Remove some debug from [25649] See #22704 
Built from https://develop.svn.wordpress.org/trunk@25651


git-svn-id: http://core.svn.wordpress.org/trunk@25568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-30 00:30:10 +00:00
Dion Hulse 30b921d10e Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704 
Built from https://develop.svn.wordpress.org/trunk@25650


git-svn-id: http://core.svn.wordpress.org/trunk@25567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-30 00:25:10 +00:00
Dion Hulse 75475ed773 Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse). 
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25649


git-svn-id: http://core.svn.wordpress.org/trunk@25566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-30 00:21:09 +00:00
Dion Hulse 7ed4059230 MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201 
Built from https://develop.svn.wordpress.org/trunk@25648


git-svn-id: http://core.svn.wordpress.org/trunk@25565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-29 23:08:09 +00:00
Dion Hulse 6e9ba8be22 Automatic Updates: Skip doing the sanity checking MD5 before deciding if we should use a partial build or not, This change means we always use a partial build for automatic updates. See #22704 
Built from https://develop.svn.wordpress.org/trunk@25647


git-svn-id: http://core.svn.wordpress.org/trunk@25564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-29 23:00:09 +00:00
Drew Jaynes 39d7e0df8a Improve inline documentation for `Walker_Nav_Menu`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`. 
Includes previously undocumented parameters.

See #23406.

Built from https://develop.svn.wordpress.org/trunk@25643


git-svn-id: http://core.svn.wordpress.org/trunk@25560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-28 21:02:09 +00:00
Drew Jaynes 858343ed71 Inline documentation for `Walker_Category_Checklist`. 
See #23406.

Built from https://develop.svn.wordpress.org/trunk@25642


git-svn-id: http://core.svn.wordpress.org/trunk@25559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-28 18:08:10 +00:00
Andrew Nacin e3798dc013 Fix strict notice. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25635


git-svn-id: http://core.svn.wordpress.org/trunk@25552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-28 06:33:10 +00:00
Andrew Nacin 00d2c39c48 Changes to automatic background updates in preparation for Beta 1. 
* Show a notice for beta testers on update-core.php explaining the status of their install. Three possibilities: auto updates are enabled, auto updates are disabled because the install doesn't support SSL HTTP requests, and auto updates are disabled because it is a VCS checkout.
 * Improve the output of the email, for maximum debugging potential. Failures are clearly labeled and the email leads testers to the support forums and Trac.
 * Try to create wp-content/languages in the upgrader if it doesn't exist. Our mkdir isn't recursive, so trying to create wp-content/languages/plugins could fail.
 * Abstract out version control checkout determination into a public method. The filter is now auto_upgrade_is_vcs_checkout, still subject to change.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25633


git-svn-id: http://core.svn.wordpress.org/trunk@25550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-27 23:21:10 +00:00
Drew Jaynes 2befec291f Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php. 
Props naomicbush.
Fixes #25357.

Built from https://develop.svn.wordpress.org/trunk@25630


git-svn-id: http://core.svn.wordpress.org/trunk@25547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-26 02:48:09 +00:00
Helen Hou-Sandí 9d5c2eb55f Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170. 
Built from https://develop.svn.wordpress.org/trunk@25608


git-svn-id: http://core.svn.wordpress.org/trunk@25525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 20:23:10 +00:00
Andrew Nacin 00c545606e Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods. 
props johnnyb.
fixes #24273.

Built from https://develop.svn.wordpress.org/trunk@25606


git-svn-id: http://core.svn.wordpress.org/trunk@25523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 18:14:09 +00:00
Dion Hulse 7669224311 Automatic Updates: Correct a typo of a constant, s/DISABLE_FILE_MODS/DISALLOW_FILE_MODS/. See #22704 
Built from https://develop.svn.wordpress.org/trunk@25599


git-svn-id: http://core.svn.wordpress.org/trunk@25516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 07:16:09 +00:00
Dion Hulse 65caf043c0 Automatic Core Updates: Enable Core Automatic Updates for Security releases, Development nightly releases, and, Language packs. See #22704 
For more information on Automatic Core Updates, See #22704 and http://wp.me/p2AvED-1Lo


Built from https://develop.svn.wordpress.org/trunk@25598


git-svn-id: http://core.svn.wordpress.org/trunk@25515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 03:36:09 +00:00
Helen Hou-Sandí 9796e54574 Saner CSS for row actions - now we can just target `.row-actions` instead of both `.row-actions` and `.row-actions-visible`. CSS for `.row-actions-visible` remains for now due to usage in plugins. Visibility is controlled by toggling a `.visible` class. fixes #25403. 
Built from https://develop.svn.wordpress.org/trunk@25592


git-svn-id: http://core.svn.wordpress.org/trunk@25509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 01:54:09 +00:00
Andrew Nacin 9cf6436ff3 Ignore unauthorized meta keys in meta_form(). fixes #18786. 
Built from https://develop.svn.wordpress.org/trunk@25591


git-svn-id: http://core.svn.wordpress.org/trunk@25508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-24 01:31:10 +00:00
Drew Jaynes bdcc067c4c Inline documentation for hooks in wp-admin/includes/revision.php. 
Fixes #25283.

Built from https://develop.svn.wordpress.org/trunk@25587


git-svn-id: http://core.svn.wordpress.org/trunk@25504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 22:45:10 +00:00
Dion Hulse c4a20fd9fe Language Packs: Integrate Language Packs into the Auto-upgrader. See #18200 See #22704 
Built from https://develop.svn.wordpress.org/trunk@25568


git-svn-id: http://core.svn.wordpress.org/trunk@25486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 09:38:09 +00:00
Andrew Nacin 187c26415f Add a language pack upgrader class. 
At the conclusion of any upgrade, after the transients are refreshed from the API, pending translations are downloaded and installed to wp-content/languages.

props dd32.
see #18200.

Built from https://develop.svn.wordpress.org/trunk@25566


git-svn-id: http://core.svn.wordpress.org/trunk@25484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 02:08:10 +00:00
Dion Hulse c43600ea4b First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time. 
See #18476 See #23122. Props kurtpayne, bananastalktome, and, DrewAPicture 

Built from https://develop.svn.wordpress.org/trunk@25560


git-svn-id: http://core.svn.wordpress.org/trunk@25478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-22 04:44:10 +00:00
Drew Jaynes e6e033aa08 Inline documentation for hooks in wp-admin/includes/ajax-actions.php. 
Fixes #25374.

Built from https://develop.svn.wordpress.org/trunk@25558


git-svn-id: http://core.svn.wordpress.org/trunk@25477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 20:47:09 +00:00
Drew Jaynes c5abe8acaa Make the `WP_List_Table::months_dropdown()` query results filterable. 
Introduces the `months_dropdown_results` filter.

Fixes #17022.

Built from https://develop.svn.wordpress.org/trunk@25556


git-svn-id: http://core.svn.wordpress.org/trunk@25476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 18:35:09 +00:00
Dion Hulse a54a345cff Add a missing . in the Hook documentation from r25542 See #22704 
Built from https://develop.svn.wordpress.org/trunk@25543


git-svn-id: http://core.svn.wordpress.org/trunk@25463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 07:02:11 +00:00
Dion Hulse 2c3a35491b WordPress Core Automatic Updates: Add a filter as to whether or not to send the site administrator a summary of executed updates. Props JustinSainton. See #22704 
Built from https://develop.svn.wordpress.org/trunk@25542


git-svn-id: http://core.svn.wordpress.org/trunk@25462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 07:00:10 +00:00
Dion Hulse a82b463610 When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074 
Built from https://develop.svn.wordpress.org/trunk@25541


git-svn-id: http://core.svn.wordpress.org/trunk@25461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 06:54:09 +00:00
Dion Hulse 6737d0a202 Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly. 
Props pento for initial patch. Fixes #18201

Built from https://develop.svn.wordpress.org/trunk@25540


git-svn-id: http://core.svn.wordpress.org/trunk@25460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 06:49:11 +00:00
Helen Hou-Sandí c7e2071893 Make it possible to filter comment screen by post type; no UI. props johnbillion, c3mdigital. fixes #18596. 
Built from https://develop.svn.wordpress.org/trunk@25526


git-svn-id: http://core.svn.wordpress.org/trunk@25446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-20 20:16:11 +00:00
Drew Jaynes 11080f459c Inline documentation for hooks in wp-admin/includes/plugin-install.php. 
Props naomicbush.
See #25229.

Built from https://develop.svn.wordpress.org/trunk@25511


git-svn-id: http://core.svn.wordpress.org/trunk@25431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-20 02:22:10 +00:00
Helen Hou-Sandí 6c121d303d Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197. 
Built from https://develop.svn.wordpress.org/trunk@25509


git-svn-id: http://core.svn.wordpress.org/trunk@25429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-19 21:01:09 +00:00
Helen Hou-Sandí 52426794c1 Restore post formats to bulk editing. props azaozz, SergeyBiryukov, DrewAPicture. fixes #24096. 
Built from https://develop.svn.wordpress.org/trunk@25505


git-svn-id: http://core.svn.wordpress.org/trunk@25426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-19 17:47:08 +00:00