WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,559 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

18671 Commits

Author SHA1 Message Date
Sergey Biryukov 6b5e748dee Docs: Correct usage of the dynamic `auto_update_{$type}` filter. 
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

Props johnbillion.
Fixes #50868.
Built from https://develop.svn.wordpress.org/trunk@48750


git-svn-id: http://core.svn.wordpress.org/trunk@48512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-07 16:14:03 +00:00
Sergey Biryukov 5221a27593 Site Health: Consistently pass an object to the `auto_update_{$type}` filter in Site Health debug data. 
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.

Props bpayton, pbiron.
Fixes #50852.
Built from https://develop.svn.wordpress.org/trunk@48745


git-svn-id: http://core.svn.wordpress.org/trunk@48507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-07 13:28:05 +00:00
Sergey Biryukov 3a32284b26 Posts, Post Types: Use a consistent wording in messages about a locked post. 
Props ramiy.
Fixes #50859.
Built from https://develop.svn.wordpress.org/trunk@48743


git-svn-id: http://core.svn.wordpress.org/trunk@48505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-06 13:14:08 +00:00
Sergey Biryukov 7e1e4f379a Site Health: Check if `session_status()` exists before calling it. 
Props bgermann.
Fixes #50862.
Built from https://develop.svn.wordpress.org/trunk@48742


git-svn-id: http://core.svn.wordpress.org/trunk@48504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-06 00:25:07 +00:00
Sergey Biryukov ee213e333b Comments: Remove a few more unnecessary instances of `esc_html()` in `WP_Comments_List_Table::comment_status_dropdown()`. 
Core translations are considered safe, and these labels are not escaped in any other instances.

Follow-up to [48521], [48722], [48724].

See #40188, #50815.
Built from https://develop.svn.wordpress.org/trunk@48741


git-svn-id: http://core.svn.wordpress.org/trunk@48503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-05 13:53:06 +00:00
Sergey Biryukov 2f878f1e74 Help/About: Correct header spacing on shorter screens after removing the musician name. 
Remove some unnecessary CSS.

Follow-up to [48730].

Props ryelle.
See #50416.
Built from https://develop.svn.wordpress.org/trunk@48736


git-svn-id: http://core.svn.wordpress.org/trunk@48498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 18:11:09 +00:00
Sergey Biryukov aaf49752b2 Plugins: Move the "Successfully installed the plugin" string to the correct `Plugin_Upgrader` method. 
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.

Props sswebster, nateinaction, SergeyBiryukov.
Fixes #50837.
Built from https://develop.svn.wordpress.org/trunk@48734


git-svn-id: http://core.svn.wordpress.org/trunk@48496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 17:54:04 +00:00
whyisjake b84d7f1fd3 Site Health: Display auto-update properly for plugins that don't support auto-updates. 
Properly filter `auto_update_plugin` when displaying the table.

Fixes #50822.
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48731


git-svn-id: http://core.svn.wordpress.org/trunk@48493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 17:37:02 +00:00
desrosj fa9b043313 Help/About: Remove “Musician Name” placeholder. 
The musician name is traditionally not included on the About page due to i18n concerns regarding last minute changes.

Props audrasjb, SergeyBiryukov.
See #50416.
Built from https://develop.svn.wordpress.org/trunk@48730


git-svn-id: http://core.svn.wordpress.org/trunk@48492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 17:35:06 +00:00
desrosj 527ca5ff78 Help/About: String updates and accessibility improvements to the 5.5 About page. 
Props ryelle, nrqsnchz, desrosj, audrasjb, marybaum, spacedmonkey, SergeyBiryukov, estelaris, afercia, ocean90.
See #50416.
Built from https://develop.svn.wordpress.org/trunk@48729


git-svn-id: http://core.svn.wordpress.org/trunk@48491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 17:26:03 +00:00
Sergey Biryukov 315db55458 Comments: Restore the `::has_items()` call in `WP_Comments_List_Table::extra_tablenav()` for now, until unit tests are updated accordingly. 
Follow-up to [48722].

Fixes #40188. See #50815.
Built from https://develop.svn.wordpress.org/trunk@48724


git-svn-id: http://core.svn.wordpress.org/trunk@48486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 16:26:03 +00:00
Sergey Biryukov b615c45103 Comments: Use the existing static variable instead of calling `::has_items()` again in `WP_Comments_List_Table::extra_tablenav()`. 
Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.

Props whyisjake, SergeyBiryukov.
Fixes #40188.
Built from https://develop.svn.wordpress.org/trunk@48722


git-svn-id: http://core.svn.wordpress.org/trunk@48484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 15:58:06 +00:00
whyisjake 500c0118d4 Help/About: String update for 5.5 release. 
We don't use hyphens for the [block editor](https://make.wordpress.org/core/handbook/best-practices/spelling/).

See #50416.
Props davidbaumwald, marybaum, desrosj.

Built from https://develop.svn.wordpress.org/trunk@48721


git-svn-id: http://core.svn.wordpress.org/trunk@48483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 15:56:02 +00:00
Andrea Fercia efdd927b48 Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340]. 
Fixes #49288.

Built from https://develop.svn.wordpress.org/trunk@48717


git-svn-id: http://core.svn.wordpress.org/trunk@48479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-04 13:17:02 +00:00
Sergey Biryukov e2c8e2fa5a Administration: Allow `wp_credits()` to accept `$version` and `$locale` parameters. 
This can be helpful for plugin developers to get credits information for older versions or different locales.

Props ramiy.
Fixes #35910.
Built from https://develop.svn.wordpress.org/trunk@48715


git-svn-id: http://core.svn.wordpress.org/trunk@48477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-03 12:53:08 +00:00
Sergey Biryukov 016df3b6c6 Docs: Correct placement for `wp_editor_expand` filter DocBlock. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@48714


git-svn-id: http://core.svn.wordpress.org/trunk@48476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-03 12:11:06 +00:00
Sergey Biryukov 8ff7595ae9 Permalinks: Don't show "You should update your `.htaccess` file now" message when saving permalink settings on Multisite. 
Multisite routing is taken care of by WordPress, not by the web server.

Follow-up to [13706], [37747], [38066].

Props boonebgorges.
Fixes #39547.
Built from https://develop.svn.wordpress.org/trunk@48713


git-svn-id: http://core.svn.wordpress.org/trunk@48475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-02 12:57:08 +00:00
Sergey Biryukov 0a76cb6240 Permalinks: Simplify the logic for displaying "You should update your `.htaccess` file now" message. 
See #39547, #50834.
Built from https://develop.svn.wordpress.org/trunk@48712


git-svn-id: http://core.svn.wordpress.org/trunk@48474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-02 12:51:03 +00:00
Sergey Biryukov c9cf1ba365 Docs: Correct formatting for a comment in `wp-admin/options-permalink.php`. 
Previously committed in [48694], accidentally reverted in [48710].

See #50768.
Built from https://develop.svn.wordpress.org/trunk@48711


git-svn-id: http://core.svn.wordpress.org/trunk@48473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-02 12:39:07 +00:00
Sergey Biryukov 38f653b639 Permalinks: Correct the check whether `.htaccess` update is required when saving permalink settings. 
The check should be performed after the permalink structure update, not before.

Fixes #50834.
Built from https://develop.svn.wordpress.org/trunk@48710


git-svn-id: http://core.svn.wordpress.org/trunk@48472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-02 12:36:02 +00:00
Sergey Biryukov 85c38d54e6 Upgrade/Install: Show the installed WordPress version number on WordPress Updates screen if there is a newer version available. 
This makes it easier for a user to know how significant of an update the change might be, and helps them make an informed decision about how to proceed.

Props tmdesigned, dd32, circlecube, dkarfa, hakre, scribu, MadtownLems, markshep, nbachiyski, dmchale, miqrogroove, ovann86, danieltj, sterndata, seanpaulrasmussen, mrgrt, Commeuneimage, dpacks, puneetsahalot, jonoaldersonwp, SergeyBiryukov.
Fixes #15101. See #35554, #47848.
Built from https://develop.svn.wordpress.org/trunk@48709


git-svn-id: http://core.svn.wordpress.org/trunk@48471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-01 19:46:04 +00:00
whyisjake 224fdb27b8 Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled. 
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.

Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@48703


git-svn-id: http://core.svn.wordpress.org/trunk@48465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-31 17:21:04 +00:00
whyisjake b4497ef13f Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes 
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.

Fixes #50824.
Props dd32, whyisjake, SergeyBiryukov.


Built from https://develop.svn.wordpress.org/trunk@48701


git-svn-id: http://core.svn.wordpress.org/trunk@48463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-31 17:03:05 +00:00
Sergey Biryukov 3f83523b4e Editor: Correctly back up the global `$post` in `wp-admin/edit-form-blocks.php`. 
To create a copy of the object, instead of a reference to the same object, the `clone` keyword should be used.

Props scarolan.
Fixes #50775.
Built from https://develop.svn.wordpress.org/trunk@48700


git-svn-id: http://core.svn.wordpress.org/trunk@48462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-31 14:00:05 +00:00
whyisjake 078db63c4b Upgrade/Install: Pass the plugin file path into the `plugin_auto_update_debug_string` filter. 
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.

Fixes #50821.
Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake. 


Built from https://develop.svn.wordpress.org/trunk@48696


git-svn-id: http://core.svn.wordpress.org/trunk@48458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-30 21:50:02 +00:00
Sergey Biryukov 629af79b24 Docs: Correct formatting for a comment in `wp-admin/options-permalink.php`. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@48694


git-svn-id: http://core.svn.wordpress.org/trunk@48456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-30 14:02:04 +00:00
Sergey Biryukov cf137e7c1b Comments: Pass the `$which` parameter to the `manage_comments_nav` action. 
This brings some consistency with the  `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions.

Props Tkama, wpgurudev.
Fixes #50736.
Built from https://develop.svn.wordpress.org/trunk@48693


git-svn-id: http://core.svn.wordpress.org/trunk@48455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-30 13:27:04 +00:00
Sergey Biryukov 72b87b3d74 Themes: Pass correct variable to `is_php_version_compatible()` in `wp_theme_update_row()`. 
This applies to the Themes screen in Multisite network admin.

Follow-up to [48660].

Props pbiron, afragen.
Fixes #48507. See #48491.
Built from https://develop.svn.wordpress.org/trunk@48689


git-svn-id: http://core.svn.wordpress.org/trunk@48451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-29 21:08:02 +00:00
whyisjake e6bfdde581 Upgrade/Install: Only show auto-update for themes that support the feature. 
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.

See #50280.
Props dd32.

Built from https://develop.svn.wordpress.org/trunk@48688


git-svn-id: http://core.svn.wordpress.org/trunk@48450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-29 20:01:08 +00:00
Sergey Biryukov 1d552ea6b1 Help/About: Adjust two strings on the About page for better i18n. 
Follow-up to [48675].

Props ocean90, audrasjb, kittmedia, nao.
See #50416.
Built from https://develop.svn.wordpress.org/trunk@48686


git-svn-id: http://core.svn.wordpress.org/trunk@48448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-29 13:29:04 +00:00
Sergey Biryukov d351100eba Upgrade/Install: Pass correct argument to `clear_destination` in `Theme_Upgrader::install()`. 
Follow-up to [48390].

Props afragen, sabernhardt.
Fixes #9757.
Built from https://develop.svn.wordpress.org/trunk@48685


git-svn-id: http://core.svn.wordpress.org/trunk@48447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-29 13:09:04 +00:00
Sergey Biryukov c5ef3b7976 Media: Pass the `$rel` parameter to `image_send_to_editor` filter. 
Props mihdan, pputzer.
Fixes #50765.
Built from https://develop.svn.wordpress.org/trunk@48684


git-svn-id: http://core.svn.wordpress.org/trunk@48446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 21:21:05 +00:00
whyisjake d8fd6d05a3 Upgrade/Install: Swap `auto-update-supported` to `update-supported` in update checks. 
Ensures backwards compatability with external updaters.

See #50280.
Props everyone-in-the-core-updates-channel. 


Built from https://develop.svn.wordpress.org/trunk@48678


git-svn-id: http://core.svn.wordpress.org/trunk@48440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 18:28:06 +00:00
desrosj 6209a40fd9 Upgrade/Install: Clarify the descriptions for `install_(plugin|theme)_overwrite_actions`. 
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48677


git-svn-id: http://core.svn.wordpress.org/trunk@48439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 18:16:07 +00:00
desrosj 1aa48c68f5 Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes. 
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48676


git-svn-id: http://core.svn.wordpress.org/trunk@48438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 17:56:04 +00:00
whyisjake 7267fc02b0 Help/About: WordPress 5.5 About Page. 
Speed. Search. Security.

This is the start of the WordPress 5.5 about page. 

Fixes #50416. 
Props ryelle, marybaum, estelaris, yvettesonneveld, michelebutcher-jones, metalandcoffee, melchoyce, marktimemedia, abhanonstopnewsuk, elmastudio, davidbaumwald, audrasjb, afercia, cbringmann, andreamiddleton, desrosj, earnjam, SergeyBiryukov, whyisjake, elrae.

Built from https://develop.svn.wordpress.org/trunk@48675


git-svn-id: http://core.svn.wordpress.org/trunk@48437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 17:46:04 +00:00
Sergey Biryukov eb0869755e Administration: Correct alignment of the "PHP Update Required" dashboard box title. 
Restore one instance of `!important` CSS rule for backward compatibility.

Follow-up to [48129], [48373].

Props whyisjake, sabernhardt, TimothyBlynJacobs, SergeyBiryukov.
Fixes #50788.
Built from https://develop.svn.wordpress.org/trunk@48671


git-svn-id: http://core.svn.wordpress.org/trunk@48433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 17:08:03 +00:00
Sergey Biryukov e4b2ad02b6 Administration: Don't override the `$mode` global in `WP_Screen::render_view_mode()` if it's already set. 
Follow-up to [48398], [48423], [48424], [48450].

See #49715.
Built from https://develop.svn.wordpress.org/trunk@48670


git-svn-id: http://core.svn.wordpress.org/trunk@48432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 16:55:04 +00:00
whyisjake 0f1f9bdb03 Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates. 
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.

See #50798.
Fixes #50280.

Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.


Built from https://develop.svn.wordpress.org/trunk@48669


git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 16:32:01 +00:00
Sergey Biryukov 2bf5b5749f Administration: Pull the `table_view_mode` filter for now. 
The extensibility of list table view modes will be explored in a future release.

Props audrasjb.
See #49715.
Built from https://develop.svn.wordpress.org/trunk@48668


git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 16:19:03 +00:00
Sergey Biryukov 3db534a988 Upgrade/Install: Disable the plugin/theme auto-updates UI if `AUTOMATIC_UPDATER_DISABLED` is defined and set as `true`. 
Props pbiron, dd32.
Fixes #50798. See #50280.
Built from https://develop.svn.wordpress.org/trunk@48667


git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 16:15:03 +00:00
Sergey Biryukov 4cfc383544 Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file. 
Props mariovalney, desrosj.
See #50593.
Built from https://develop.svn.wordpress.org/trunk@48666


git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 16:07:02 +00:00
Sergey Biryukov 0dd2f9f5c5 Docs: Add missing documentation for various upgrade/install class properties and methods. 
Props ramiy.
Fixes #42923.
Built from https://develop.svn.wordpress.org/trunk@48661


git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 11:57:03 +00:00
Sergey Biryukov a745f035ab Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress. 
This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.
Built from https://develop.svn.wordpress.org/trunk@48660


git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 11:34:04 +00:00
Sergey Biryukov e349d92b53 Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages. 
Follow-up to [48652-48654].

See #48491.
Built from https://develop.svn.wordpress.org/trunk@48659


git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 11:31:01 +00:00
Mike Schroder 8c3d56919e Upgrade/Install: Improve `wp_opcache_invalidate()` performance. 
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.

Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784.
Built from https://develop.svn.wordpress.org/trunk@48657


git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 08:09:05 +00:00
whyisjake 26b706e27f Site Health: Incorrect file path in `require_once`. 
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.

Fixes #50793.
Props dd32.

Built from https://develop.svn.wordpress.org/trunk@48655


git-svn-id: http://core.svn.wordpress.org/trunk@48417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 02:21:06 +00:00
Sergey Biryukov db175a9868 Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress. 
This applies to the WordPress Updates screen.

Props afragen, SergeyBiryukov.
Fixes #48491.
Built from https://develop.svn.wordpress.org/trunk@48654


git-svn-id: http://core.svn.wordpress.org/trunk@48416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 01:02:04 +00:00
Sergey Biryukov ab6c396531 Themes: Correct the logic for displaying a message in theme grid if a theme update requires a higher version of PHP or WordPress. 
This applies to the Themes screen fallback used when JS is turned off.

Follow-up to [48652].

See #48491.
Built from https://develop.svn.wordpress.org/trunk@48653


git-svn-id: http://core.svn.wordpress.org/trunk@48415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 00:43:02 +00:00
Sergey Biryukov 0122e035b0 Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress. 
This applies to the Themes screen and the Customizer theme browser.

Props afragen, SergeyBiryukov.
See #48491.
Built from https://develop.svn.wordpress.org/trunk@48652


git-svn-id: http://core.svn.wordpress.org/trunk@48414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 00:09:02 +00:00
Sergey Biryukov 6307a7c41c Docs: Correct alignment for some parameters in JS documentation. 
Follow-up to [48650].

See #43828.
Built from https://develop.svn.wordpress.org/trunk@48651


git-svn-id: http://core.svn.wordpress.org/trunk@48413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-28 00:07:03 +00:00
whyisjake 3dd9628aae Build/Test Tools: Enable JSDocs to be linted with ESLint. 
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/) this add some tooling to lint Javascript docblocks. Two new commands:

* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`

The latter will run the linter and try to fix an possible issues automatically.

Fixes #43828.
Props netweb, atimmer, kamataryo, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48650


git-svn-id: http://core.svn.wordpress.org/trunk@48412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 23:35:02 +00:00
youknowriad bb54ebcd0d Administration: Fix the red links on the Media Modal. 
The custom link colors for admin scheme colors were overriding the danger color.

Props kebbet, dlh.
Fixes #50547.

Built from https://develop.svn.wordpress.org/trunk@48643


git-svn-id: http://core.svn.wordpress.org/trunk@48405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 19:17:05 +00:00
Sergey Biryukov e071ace6c4 Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress. 
This applies to the Themes screen fallback used when JS is turned off.

Props afragen, desrosj, SergeyBiryukov.
See #48491.
Built from https://develop.svn.wordpress.org/trunk@48640


git-svn-id: http://core.svn.wordpress.org/trunk@48402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 15:21:02 +00:00
Sergey Biryukov 4336a2b9a7 Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress. 
This applies to the Themes screen, Add Themes screen, and the Customizer theme browser.

Props afragen, desrosj, SergeyBiryukov.
See #48491.
Built from https://develop.svn.wordpress.org/trunk@48638


git-svn-id: http://core.svn.wordpress.org/trunk@48400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 15:04:03 +00:00
Sergey Biryukov 39147698d9 Themes: Display a message in Details & Preview modal on Add Themes screen if a theme requires a higher version of PHP or WordPress. 
Props afragen, desrosj, SergeyBiryukov.
See #48491.
Built from https://develop.svn.wordpress.org/trunk@48637


git-svn-id: http://core.svn.wordpress.org/trunk@48399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 14:26:07 +00:00
Sergey Biryukov 1f89186a3d Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress. 
Props afragen, desrosj, SergeyBiryukov.
See #48491.
Built from https://develop.svn.wordpress.org/trunk@48636


git-svn-id: http://core.svn.wordpress.org/trunk@48398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 13:12:04 +00:00
Mike Schroder 9ec7f2febd Docs: Correct `wp_opcache_invalidate_file` filter docs. 
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.

See #36455.
Built from https://develop.svn.wordpress.org/trunk@48632


git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 09:08:05 +00:00
Sergey Biryukov df74d8f10d Revisions: Ensure the global `$post` remains the same after revision is restored. 
Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`.

Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes #46671.
Built from https://develop.svn.wordpress.org/trunk@48625


git-svn-id: http://core.svn.wordpress.org/trunk@48387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 21:25:02 +00:00
Sergey Biryukov a6cf8df9d1 Docs: Synchronize some comments in `wp-admin/revision.php`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48624


git-svn-id: http://core.svn.wordpress.org/trunk@48386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 20:43:02 +00:00
Sergey Biryukov d8c62b5647 Posts, Post Types: Move `get_post_states()` back to the admin for now, require the file in `WP_Customize_Nav_Menus::customize_register()` instead. 
This provides a minor performance improvement by only running the function in contexts where it's needed.

Follow-up to [47211], [47213], [47763], [48619].

See #46829, #49374.
Built from https://develop.svn.wordpress.org/trunk@48620


git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 10:51:06 +00:00
Sergey Biryukov aab535a576 Posts, Post Types: Make `get_post_states()` available on frontend. 
This allows special pages to be denoted as such when editing a menu in the Customizer.

This applies to the Front Page, Posts Page, and Privacy Policy Page.

Follow-up to [47211], [47213], [47763].

Props dlh, whyisjake, SergeyBiryukov.
Fixes #46829. See #49374.
Built from https://develop.svn.wordpress.org/trunk@48619


git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 01:14:06 +00:00
Sergey Biryukov 609acd89ed I18N: Merge duplicate "List view" and "Grid view" strings. 
Props ramiy.
Fixes #50757.
Built from https://develop.svn.wordpress.org/trunk@48618


git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 21:32:05 +00:00
Sergey Biryukov c40a645510 Docs: Correct `@see` references for privacy hooks: 
* `wp_privacy_personal_data_export_page`
* `wp_privacy_personal_data_erasure_page`

Hooks should be single-quoted when referenced.

Props pbiron, coffee2code.
See #49572, #meta5318.
Built from https://develop.svn.wordpress.org/trunk@48616


git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 19:14:03 +00:00
Sergey Biryukov 7d305c8ff9 Docs: Correct `@since` tags for some `WP_List_Table` hooks: 
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`

Follow-up to [15491], [15578], [26401].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48615


git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 18:55:03 +00:00
Sergey Biryukov 0ef0a1905b Docs: Remove outdated statement in `bulk_actions-{$this->screen->id}` filter description. 
As of WordPress 4.7, developers can register their own bulk actions on list table screens.

Follow-up to [17297], [38647].

Props joyously, pbiron.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48614


git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 18:13:02 +00:00
Sergey Biryukov ef382e6aaf Site Health: Escape the displayed result of the request in REST API availability test. 
Props siliconforks, gisselfeldt.
Fixes #50588.
Built from https://develop.svn.wordpress.org/trunk@48608


git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 15:38:06 +00:00
Sergey Biryukov b6f52721ed Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments. 
Follow-up to [48352].

See #40244.
Built from https://develop.svn.wordpress.org/trunk@48595


git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 00:27:03 +00:00
Sergey Biryukov 703a978a77 Administration: Capitalize `Trash` consistently in various messages. 
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Follow-up to [47233], [48352].

See #45317, #40244.
Built from https://develop.svn.wordpress.org/trunk@48594


git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 00:21:03 +00:00
John Blackbourn 9bc7d0a776 Docs: Another pass at some inline docs fixes mostly made by PHPCBF. 
See #49572, #50744
Built from https://develop.svn.wordpress.org/trunk@48590


git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 21:11:05 +00:00
Sergey Biryukov 3f04e3bf5c I18N: Further adjust some update/install strings for consistency. 
Follow-up to [48568], [48569].

See #50708, #50714.
Built from https://develop.svn.wordpress.org/trunk@48589


git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 21:08:01 +00:00
Sergey Biryukov 5950e15042 I18N: Merge two "Return to top" strings. 
Props ramiy, carike, whyisjake.
Fixes #50743.
Built from https://develop.svn.wordpress.org/trunk@48588


git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 20:21:07 +00:00
Sergey Biryukov 161821d155 Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test. 
Follow-up to [48584].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48587


git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 20:13:05 +00:00
John Blackbourn 57a3f803ae Docs: First pass at some inline docs fixes mostly made by PHPCBF. 
See #49572, #50744
Built from https://develop.svn.wordpress.org/trunk@48586


git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 20:01:04 +00:00
John Blackbourn 7f898dd9c4 Docs: Use more appropriate variable names in the inline docs for action and filter parameters. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48585


git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 19:06:03 +00:00
desrosj 231d21ebcd Site Health: Pass all expected parameters to `auto_update_{$type}`. 
This prevents fatal errors when other hooked functions are expecting both parameters. 

Props dd32, desrosj, audrasjb, pbiron.
Fixes #50662.
Built from https://develop.svn.wordpress.org/trunk@48584


git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 19:03:04 +00:00
Sergey Biryukov 0eb1b2a447 I18N: Update "Default Template" string to match the sentence case used in the block editor. 
Props ramiy.
Fixes #50742.
Built from https://develop.svn.wordpress.org/trunk@48583


git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 18:55:01 +00:00
desrosj 2c2508f98c General: Ensure the database upgrades from [48575] are run. 
This corrects the database version to match the commit number the upgrade changes were made.

See #50413.
Built from https://develop.svn.wordpress.org/trunk@48582


git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 18:43:04 +00:00
John Blackbourn 124972f2c6 Docs: Further corrections and improvements to various inline docblocks. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48576


git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 07:39:02 +00:00
Aaron Jorbin 6cab8cce22 General: Update code for readability and inclusion 
There are two pieces in here:

1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.

2) This improves backwards compatibility for code that was accessing the now deprecated code.

Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]

Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes: #50413


Built from https://develop.svn.wordpress.org/trunk@48575


git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 03:14:06 +00:00
John Blackbourn 0bf9b04c53 Docs: Various formatting improvements to inline docblocks. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48574


git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 00:52:05 +00:00
John Blackbourn 1fbcdb2213 Docs: Various corrections to inline docblocks. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48573


git-svn-id: http://core.svn.wordpress.org/trunk@48335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 00:48:06 +00:00
whyisjake 413fae70e8 i18n: Merge similar translation strings in wp-admin/options.php 
WARNING! is now Warning:

You have been warned.

Fixes #50715.
Props: ramiy, audrasjb, ocean90.


Built from https://develop.svn.wordpress.org/trunk@48570


git-svn-id: http://core.svn.wordpress.org/trunk@48332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 22:21:03 +00:00
whyisjake dd642e7b00 i18n: Merge similar translation strings to "Update failed". 
Fixes #50714.
Props ramiy, ocean90.

Built from https://develop.svn.wordpress.org/trunk@48569


git-svn-id: http://core.svn.wordpress.org/trunk@48331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 22:10:02 +00:00
whyisjake 921ddab889 I18N: Merge similar "Installation failed" strings 
Fixes #50708.

Props ramiy, ocean90, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@48568


git-svn-id: http://core.svn.wordpress.org/trunk@48330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 21:59:05 +00:00
whyisjake d1517a1ad4 I18N: Update some strings to have periods. 
Fixes #50707.
Props ramiy, afercia, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@48567


git-svn-id: http://core.svn.wordpress.org/trunk@48329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 21:55:06 +00:00
desrosj 2cebcb6144 General: Rename `remove_option_allowed_list()` to `remove_allowed_options()`. 
This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names.

See #50413.
Built from https://develop.svn.wordpress.org/trunk@48566


git-svn-id: http://core.svn.wordpress.org/trunk@48328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 18:52:02 +00:00
Sergey Biryukov 3db2c3afd4 Upgrade/Install: Don't trigger database upgrade on Ajax requests via `wp-admin/async-upload.php`. 
Props schlessera, jgrodel, elrae, davidbaumwald, hareesh-pillai, adamsilverstein, SergeyBiryukov.
Fixes #39459.
Built from https://develop.svn.wordpress.org/trunk@48565


git-svn-id: http://core.svn.wordpress.org/trunk@48327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 12:56:04 +00:00
Sergey Biryukov 6f0b8e2b2b Accessibility: Themes: Consistently use an underline for "Enable auto-updates" link and theme author link in theme overlay. 
Props chetan200891, sabernhardt, afercia.
Fixes #50697.
Built from https://develop.svn.wordpress.org/trunk@48564


git-svn-id: http://core.svn.wordpress.org/trunk@48326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 12:19:05 +00:00
Sergey Biryukov 1373b2056d Docs: Correct type for the `$theme` parameter of `theme_auto_update_debug_string` filter. 
Follow-up to [48546], [48549], [48552].

See #50663.
Built from https://develop.svn.wordpress.org/trunk@48561


git-svn-id: http://core.svn.wordpress.org/trunk@48323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:29:03 +00:00
Sergey Biryukov 88e046f1e8 Site Health: Fix some typos in the test for plugin and theme auto-updates. 
Follow-up to [48548], [48558], [48559].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48560


git-svn-id: http://core.svn.wordpress.org/trunk@48322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:17:04 +00:00
Sergey Biryukov c6034be779 Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates. 
Follow-up to [48548], [48558].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48559


git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:15:02 +00:00
Sergey Biryukov 93bf0c3b83 Site Health: Add the test for plugin and theme auto-updates to `WP_Site_Health::get_tests()`. 
This ensures that the test actually runs.

Follow-up to [48548].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48558


git-svn-id: http://core.svn.wordpress.org/trunk@48320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:07:02 +00:00
Sergey Biryukov a68d462439 Site Health: Use a consistent label for theme auto-updates in debug data. 
Props audrasjb.
Fixes #50728.
Built from https://develop.svn.wordpress.org/trunk@48554


git-svn-id: http://core.svn.wordpress.org/trunk@48316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 21:06:02 +00:00
Sergey Biryukov 94d4561906 Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes. 
Remove some extra variables.

Follow-up to [48546], [48549].

See #50663.
Built from https://develop.svn.wordpress.org/trunk@48552


git-svn-id: http://core.svn.wordpress.org/trunk@48314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 18:44:04 +00:00
Sergey Biryukov 8a58ab36cc Site Health: Rename the filters added in [48546] for clarity. 
See #50663.
Built from https://develop.svn.wordpress.org/trunk@48549


git-svn-id: http://core.svn.wordpress.org/trunk@48311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 17:09:03 +00:00
whyisjake 9d2b92be26 Site Health: Add tests to check for potential issues with plugin and theme auto-updates. 
Fixes #50662.
Props desrosj, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@48548


git-svn-id: http://core.svn.wordpress.org/trunk@48310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 17:07:05 +00:00
whyisjake 32f791da49 Site Health: Add auto-update information to for plugins and themes. 
New filters:

* `plugin_auto_update_debug_str`
* `theme_auto_update_debug_str`

Fixes #50663.
Props pbiron, audrasjb, davidbaumwald.

Built from https://develop.svn.wordpress.org/trunk@48546


git-svn-id: http://core.svn.wordpress.org/trunk@48308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:54:02 +00:00
Sergey Biryukov 548df4e3e6 I18N: Add context to some theme strings for consistency. 
Props ramiy, ocean90.
Fixes #50709.
Built from https://develop.svn.wordpress.org/trunk@48545


git-svn-id: http://core.svn.wordpress.org/trunk@48307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:33:05 +00:00
Sergey Biryukov 48841f9ab3 Site Health: Rename `upload_max` array key in file upload checks to `max_effective_size` for clarity. 
Follow-up to [48535].

See #50038.
Built from https://develop.svn.wordpress.org/trunk@48544


git-svn-id: http://core.svn.wordpress.org/trunk@48306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:20:03 +00:00
Sergey Biryukov 1c52ad8d3f Site Health: Move `post_max_size` and `upload_max_filesize` out of a translatable string in file upload checks. 
Simplify some other strings, use a consistent format for translator comments.

Follow-up to [48535].

See #50038.
Built from https://develop.svn.wordpress.org/trunk@48539


git-svn-id: http://core.svn.wordpress.org/trunk@48301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:53:04 +00:00
Sergey Biryukov bec9fa5010 Site Health: Remove `parse_ini_size()`, use the existing `wp_convert_hr_to_bytes()` function instead. 
Follow-up to [48535].

See #50038.
Built from https://develop.svn.wordpress.org/trunk@48538


git-svn-id: http://core.svn.wordpress.org/trunk@48300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:40:03 +00:00
desrosj 3dda74c337 Editor: Ensure the required assets for the block directory are enqueued. 
This fixes an issue where the block directory appears unstyled due to the stylesheets not being enqueued.

Props ryelle, timothyblynjacobs, earnjam.
Fixes #50661.
Built from https://develop.svn.wordpress.org/trunk@48537


git-svn-id: http://core.svn.wordpress.org/trunk@48299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:38:03 +00:00
whyisjake 73a8fb4cc3 Site Health: Include new tests to check for the ability to upload files. 
Several new checks:

* `max_file_uploads`
* `file_uploads`
* `post_max_size`
* `upload_max_filesize`
* `upload_max`
* `max_file_uploads`

In addition, new function `parse_ini_size()` that converts shorthand byte strings to bytes. Useful for size comparisons.

Fixes #50038.
Props dd32, donmhico, JavierCasares, SergeyBiryukov, ayeshrajans, Clorith, ipstenu, sabernhardt, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@48535


git-svn-id: http://core.svn.wordpress.org/trunk@48297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:21:02 +00:00
Sergey Biryukov d1822e81ba Site Health: Use consistent error messages when switching plugin or theme auto-updates on or off. 
Props ramiy.
Fixes #50721.
Built from https://develop.svn.wordpress.org/trunk@48534


git-svn-id: http://core.svn.wordpress.org/trunk@48296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 14:42:05 +00:00
Sergey Biryukov 9ce7bd633b Docs: Improve description for `edit_post()`. 
Props stevenlinx.
Fixes #50713.
Built from https://develop.svn.wordpress.org/trunk@48529


git-svn-id: http://core.svn.wordpress.org/trunk@48291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:49:03 +00:00
Sergey Biryukov de462d2c20 Site Health: Correct the message for snoozed email verifications. 
Follow-up to [48522].

Fixes #48333.
Built from https://develop.svn.wordpress.org/trunk@48528


git-svn-id: http://core.svn.wordpress.org/trunk@48290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:37:07 +00:00
ellatrix ec05ee2f5d Editor: update packages for Beta 3 
Fixes #50712.


Built from https://develop.svn.wordpress.org/trunk@48527


git-svn-id: http://core.svn.wordpress.org/trunk@48289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:14:37 +00:00
whyisjake 7112440881 Site Health: Ensure that there is a human readable time for snoozed email verifications. 
This will be the time the was proposed, added to the reminder interval.

Fixes #48333.
Props SergeyBiryukov, desrosj.


Built from https://develop.svn.wordpress.org/trunk@48522


git-svn-id: http://core.svn.wordpress.org/trunk@48284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 00:43:02 +00:00
whyisjake 5c836585d1 Comments: Don't show the filter/pagination actions if there are no comments to list. 
It doesn't make sense to be able to filter the comments list table when there are are no (trashed/spam) comments available.

Fixes #40188.
Props swissspidy, Jim_Panse, menakas, akbarhusen429, dinhtungdu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48521


git-svn-id: http://core.svn.wordpress.org/trunk@48283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 00:29:02 +00:00
Sergey Biryukov e4ce35dd11 I18N: Add context to some plugin and theme strings for consistency. 
Props ramiy, audrasjb.
Fixes #50710.
Built from https://develop.svn.wordpress.org/trunk@48520


git-svn-id: http://core.svn.wordpress.org/trunk@48282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 23:14:05 +00:00
Sergey Biryukov 82ce41ff51 I18N: Mark the strings with plugin and theme names in email notifications for translation. 
Follow-up to [48517].

See #50350.
Built from https://develop.svn.wordpress.org/trunk@48519


git-svn-id: http://core.svn.wordpress.org/trunk@48281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 21:25:06 +00:00
desrosj 02f200df1d Administration: Include the new plugin and theme versions in email notifications. 
This helps administrators keep track of which versions of plugins and themes are running on their site when auto-updates occur.

Props audrasjb, pbiron.
Fixes #50350.
Built from https://develop.svn.wordpress.org/trunk@48517


git-svn-id: http://core.svn.wordpress.org/trunk@48279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 18:28:03 +00:00
Andrew Ozz efb77b4a65 Upgrade/install: Fix/clarify the "Upload in a zip format" string. 
Props greenshady, mariovalney.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48509


git-svn-id: http://core.svn.wordpress.org/trunk@48271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-19 17:11:02 +00:00
John Blackbourn c3f787b8ff Docs: Miscellaneous docblock corrections. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48508


git-svn-id: http://core.svn.wordpress.org/trunk@48270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-18 22:11:02 +00:00
whyisjake 59ee72969d Plugins: Update the height of the Install Now button for new plugins. 
Due to Thickbox shenanigans, the buttons height needed to be shrunk a little to center properly in the iframe.

Fixes #49828.

Props ibachal, Otto42, afercia.

Built from https://develop.svn.wordpress.org/trunk@48503


git-svn-id: http://core.svn.wordpress.org/trunk@48265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-17 06:29:06 +00:00
whyisjake da7a54d206 Administration: Fix an index inconsistency in `get_admin_page_title()` function. 
Ensure that `get_admin_page_title()` returns a value from pages registered using `add_menu_page()`.

Fixes #46081.

Props grapestain, valentinbora, SergeyBiryukov, audrasjb.


Built from https://develop.svn.wordpress.org/trunk@48500


git-svn-id: http://core.svn.wordpress.org/trunk@48262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 22:15:07 +00:00
whyisjake a53b741359 Coding Standards: Update the docblock to remove superflous `since`. 
The `@deprecated` DocBlock tag should start with the version followed by the description of what to use instead.

Fixes #44959.

Props keesiemeijer, sabernhardt.


Built from https://develop.svn.wordpress.org/trunk@48495


git-svn-id: http://core.svn.wordpress.org/trunk@48257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 21:12:08 +00:00
Sergey Biryukov 64a4066874 Upgrade/Install: Check if the theme installer skin's `overwrite` property exists in `Theme_Upgrader::install_strings()`. 
This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations.

Props schlessera, azaozz.
See #50670.
Built from https://develop.svn.wordpress.org/trunk@48493


git-svn-id: http://core.svn.wordpress.org/trunk@48255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 13:19:03 +00:00
Andrea Fercia 9e8d1b1a68 Accessibility: Security: Improves the accessible audible messages for Plugins & Themes Auto-Updates. 
- changes the politeness level of the two error messages introduced in [47835] to `assertive`
- remove unnecessary `polite` parameters as that's the default value

See #50512, #50052.


Built from https://develop.svn.wordpress.org/trunk@48479


git-svn-id: http://core.svn.wordpress.org/trunk@48248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 15:46:02 +00:00
desrosj fdd88e24ed General: Rename the `$new_whitelist_options` global variable. 
This change renames `$new_whitelist_options` to `$new_allowed_options`. This makes the variable’s purpose more clear, and promotes using more inclusive language.

For backwards compatibility, the new variable is passed by reference to the old one.

Follow up to [48121].

Props ayeshrajans, desrosj, jorbin, SergeyBiryukov.
See #50413.
Fixes #50434.
Built from https://develop.svn.wordpress.org/trunk@48477


git-svn-id: http://core.svn.wordpress.org/trunk@48246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 12:33:02 +00:00
John Blackbourn 5eb3f0ffcb Docs: Improve docs for arguments that accept a numerically indexed array of associative arrays. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48475


git-svn-id: http://core.svn.wordpress.org/trunk@48244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 12:10:05 +00:00
John Blackbourn 4ff1233e75 Docs: Correct and improve inline docs for parameters that accept a callback function. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48473


git-svn-id: http://core.svn.wordpress.org/trunk@48242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:56:04 +00:00
Sergey Biryukov b40e44dd69 Privacy: Set the direction for the "Username or email address" field on privacy screens to LTR. 
This is consistent with other email inputs across the admin.

Follow-up to [27743], [42967].

Props man4toman, sushyant.
Fixes #50625.
Built from https://develop.svn.wordpress.org/trunk@48468


git-svn-id: http://core.svn.wordpress.org/trunk@48237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:17:04 +00:00
Andrew Ozz 02d1cc0fea Administration: Attempt to even-out the new Up/Down arrows in metabox headings and make them look a bit better. Also group them a little closer together in an attempt to reduce confusion of having two down arrows next to one another. Move the focus outline to the button instead of only the icon. 
Fixes #39074.
Built from https://develop.svn.wordpress.org/trunk@48465


git-svn-id: http://core.svn.wordpress.org/trunk@48234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 01:37:02 +00:00
John Blackbourn 6b21db7fb9 Docs: Miscellaneous docblock corrections and improvements. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48462


git-svn-id: http://core.svn.wordpress.org/trunk@48231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 22:10:07 +00:00
whyisjake ac2a1c341d Customize: Ensure that widgets and nav-menus can be closed after entering content. 
Previously, the ⌧ button would close the search panel, or remove the results. This restores that, in addition pressing escape will do the same.

Fixes #48198.

Props garrett-eclipse, tobifjellner, afercia, JavierCasares.


Built from https://develop.svn.wordpress.org/trunk@48461


git-svn-id: http://core.svn.wordpress.org/trunk@48230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 20:15:06 +00:00
Andrea Fercia c7617838b1 Accessibility: Improve reordering of the post boxes in the block editor meta boxes area. 
Follow-up to [48373].
- ignores hidden "sortables" areas 
- hides the reorder buttons when there's only one post box 
- makes the reorder buttons slightly bigger to match the side of the toggle button

Fixes #39074.

Built from https://develop.svn.wordpress.org/trunk@48460


git-svn-id: http://core.svn.wordpress.org/trunk@48229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 18:03:05 +00:00
Sergey Biryukov 7c09c153d5 Upgrade/Install: Simplify compatibility checks for uploaded plugins and themes for better readability. 
Use `$new_plugin_data` and `$new_theme_data` as a shorthand for the corresponding `$this->upgrader` properties.

Follow-up to [48390], [48448].

Props afragen.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48455


git-svn-id: http://core.svn.wordpress.org/trunk@48224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 13:35:05 +00:00
Andrew Ozz 63a2cb3060 Upgrade/Install: Use `wp_strip_all_tags()` for the fields in the compare table on the "Update theme/plugin from uploaded zip" screen. Some may contain HTML. 
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48453


git-svn-id: http://core.svn.wordpress.org/trunk@48222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 20:00:03 +00:00
Sergey Biryukov 9848b6b3e9 Plugins: Make delete plugin message less scary. 
This adds a check if the plugin actually has an uninstall routine before saying that its data will be deleted too.

Props samful, joostdevalk, joyously, Chouby, SergeyBiryukov.
Fixes #50346.
Built from https://develop.svn.wordpress.org/trunk@48451


git-svn-id: http://core.svn.wordpress.org/trunk@48220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 13:22:04 +00:00
Sergey Biryukov c4543704e2 Administration: Restore the `excerpt` key for the Extended view mode for backward compatibility for now. 
Props Offereins.
See #49715.
Built from https://develop.svn.wordpress.org/trunk@48450


git-svn-id: http://core.svn.wordpress.org/trunk@48219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 11:36:04 +00:00
Sergey Biryukov 1556ecc000 Docs: Add a `@since` entry for the `$hook_extra` parameter added to `WP_Upgrader::download_package()`. 
Follow-up to [48399].

See #49686.
Built from https://develop.svn.wordpress.org/trunk@48449


git-svn-id: http://core.svn.wordpress.org/trunk@48218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 11:02:03 +00:00
Sergey Biryukov 707534c2d8 Upgrade/Install: Use `is_php_version_compatible()` and `is_wp_version_compatible()` in plugin and theme requirement checks. 
Follow-up to [48390].

Props afragen.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48448


git-svn-id: http://core.svn.wordpress.org/trunk@48217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 10:55:03 +00:00
Sergey Biryukov f83b8775b3 I18N: Move the "WordPress Backups" support URL to its own translatable string. 
Follow-up to [48390].

See #9757.
Built from https://develop.svn.wordpress.org/trunk@48447


git-svn-id: http://core.svn.wordpress.org/trunk@48216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 10:34:05 +00:00
Sergey Biryukov 3f1650122a Docs: Miscellaneous DocBlock corrections for plugin and theme updates. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48446


git-svn-id: http://core.svn.wordpress.org/trunk@48215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 01:19:03 +00:00
Sergey Biryukov cecf7b9823 Administration: Handle the result of `Plugin_Upgrader::bulk_upgrade()` for a plugin that is already at the latest version in the same way it is handled for themes. 
This corrects a fragile check of the result in `wp_ajax_update_plugin()` that depended on the internal array pointer, and brings some consistency with `wp_ajax_update_theme()`.

Follow-up to [37714], [48401].
See #50448.
Built from https://develop.svn.wordpress.org/trunk@48445


git-svn-id: http://core.svn.wordpress.org/trunk@48214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 01:16:05 +00:00
Sergey Biryukov 7b61df725e Revisions: Replace `array_shift()` with `reset()` in `register_and_do_post_meta_boxes()` for better performance. 
Follow-up to [31829], [48422].

See #34560.
Built from https://develop.svn.wordpress.org/trunk@48436


git-svn-id: http://core.svn.wordpress.org/trunk@48205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 12:30:02 +00:00
Sergey Biryukov a6fed0173d Themes: Correct closing tag for the "Enable auto-updates" button in the JS template for theme auto-update setting. 
Follow-up to [48418].

See #50516.
Built from https://develop.svn.wordpress.org/trunk@48428


git-svn-id: http://core.svn.wordpress.org/trunk@48197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 22:03:04 +00:00
Sergey Biryukov 4645084c09 Docs: Improve description for the JS function that hides the update button for expired plugin or theme uploads. 
Add missing `@since` tag.

Follow-up to [48417].

See #50612.
Built from https://develop.svn.wordpress.org/trunk@48427


git-svn-id: http://core.svn.wordpress.org/trunk@48196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 21:15:03 +00:00
Sergey Biryukov 51856d435b Administration: Bring some consistency to handling list table view modes. 
* Remove duplicate variables and DocBlocks.
* Add missing description for the `$mode` global.
* Use sentence case for "Compact view" and "Extended view" labels.

Follow-up to [48398], [48423].

Props afercia, Offereins, SergeyBiryukov.
See #49715.
Built from https://develop.svn.wordpress.org/trunk@48424


git-svn-id: http://core.svn.wordpress.org/trunk@48193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 16:04:05 +00:00
Sergey Biryukov 0f92086ca0 Administration: Make some adjustments to `WP_Screen::render_view_mode()`: 
* Restore the `$mode` global for backward compatibility.
* Remove redundant check, as `$mode` is already set at this point, and already defaults to `list` via `get_user_setting()`'s second argument.
* Use sentence case for "View mode" and "Extended view" labels.

Follow-up to [48398].

See #49715.
Built from https://develop.svn.wordpress.org/trunk@48423


git-svn-id: http://core.svn.wordpress.org/trunk@48192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 16:02:05 +00:00
Adam Silverstein 7d0162bc2e Revisions: optimize performance when post has large number of revisions. 
Improve speed and reduce the memory footprint when loading posts with many revisions.

* Use a direct query in `wp_get_post_autosave` to avoid loading all revisions.
* Query for IDs vs full objects in `register_and_do_post_meta_boxes`.

Props pdfernhout, johnnyb, miqrogroove, ocean90, senatorman, DBrumbaugh10Up, martijn-van-der-kooij, pavelevap, mackensen, mikeyarce, whyisjake.
Fixes #34560.


Built from https://develop.svn.wordpress.org/trunk@48422


git-svn-id: http://core.svn.wordpress.org/trunk@48191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 15:13:07 +00:00
Sergey Biryukov b03053eb2a Docs: Correct documentation for `customize_controls_head` hook and `_customizer_mobile_viewport_meta()` function. 
Follow-up to [48412].

See #47369.
Built from https://develop.svn.wordpress.org/trunk@48420


git-svn-id: http://core.svn.wordpress.org/trunk@48189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 11:36:07 +00:00
whyisjake edb4943a9d Administration: Better align labels on the discussion options page. 
The labels for Comment Moderation, and Comment Blocklist are now aligned properly with the adjacent text.

Fixes #37384.
Props ankit-k-gupta, karmatosed, FolioVision, desrosj, valentinbora, samful, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@48419


git-svn-id: http://core.svn.wordpress.org/trunk@48188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 06:48:06 +00:00
whyisjake 28a390c2b2 Upgrade/Install: Use ARIA button class on plugin and theme auto-updates action links 
According to the [accesability guidelines](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/#semantics-for-controls), the control should be a link when JavaScript is not available and a button the rest of the time.

In addition, handlers were added for spacebar usage, and some changes to the a11y speak verbiage.

Fixes #50516.
Props ryokuhi, audrasjb, afercia, whyisjake/



Built from https://develop.svn.wordpress.org/trunk@48418


git-svn-id: http://core.svn.wordpress.org/trunk@48187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 06:18:04 +00:00
whyisjake 836ad98276 Upgrade/Install: Ensure cleanup after canceled update. 
Ensure that the uploaded zip is hidden from the media library, where a task will remove failed installs after two hours.

Fixes #50612.

Props psykro, desrosj, joyously, azaozz, noisysocks, whyisjake. 

Built from https://develop.svn.wordpress.org/trunk@48417


git-svn-id: http://core.svn.wordpress.org/trunk@48186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 06:08:06 +00:00
whyisjake 9397ad46ba Coding Standards: Some missed code formatting. 
Unprops: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48415


git-svn-id: http://core.svn.wordpress.org/trunk@48184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 01:01:03 +00:00
whyisjake 1158166d9c Administration: Remove multiple viewport meta tags from mobile pages. 
In addition, add the `wp_admin_viewport_meta()` function, paired to the `admin_viewport_meta` filter to control attributes of the meta tag.

Fixes #47369.
Props BettyJJ, mukesh27, SergeyBiryukov, ajayghaghretiya1, msaggiorato, talldanwp, davidbaumwald, donmhico, audrasjb.


Built from https://develop.svn.wordpress.org/trunk@48412


git-svn-id: http://core.svn.wordpress.org/trunk@48181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-09 23:29:08 +00:00
Sergey Biryukov 6bf6bc451f Docs: Miscellaneous DocBlock corrections. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48408


git-svn-id: http://core.svn.wordpress.org/trunk@48177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-08 13:15:03 +00:00