Commit Graph

30570 Commits

Author SHA1 Message Date
Mark Jaquith 31ca0cd939 Soothe JSHint's rankled spirits
Built from https://develop.svn.wordpress.org/trunk@33365


git-svn-id: http://core.svn.wordpress.org/trunk@33337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 18:56:26 +00:00
Mark Jaquith 1ef40251b9 Introduce a Cancel button and onUnload warning for password changes.
fixes #33079
props johnjamesjacoby
Built from https://develop.svn.wordpress.org/trunk@33364


git-svn-id: http://core.svn.wordpress.org/trunk@33336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 18:36:24 +00:00
Mark Jaquith f08f12f7cc Fix up and normalize pw_weak/pw-weak IDs and labels.
props johnjamesjacoby
fixes #33077
Built from https://develop.svn.wordpress.org/trunk@33363


git-svn-id: http://core.svn.wordpress.org/trunk@33335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 17:24:24 +00:00
Mark Jaquith ae03a8a0a2 Make password field toggling work in IE8, and clean up a bunch of password CSS issues.
fixes #32886
props peterwilsoncc, adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@33362


git-svn-id: http://core.svn.wordpress.org/trunk@33334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 16:56:27 +00:00
Gary Pendergast c3e0ed7e03 Shortcodes: Improve the reliablity of shortcodes inside HTML tags.
Props miqrogroove.

See #15694.


Built from https://develop.svn.wordpress.org/trunk@33359


git-svn-id: http://core.svn.wordpress.org/trunk@33331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 05:15:25 +00:00
Gary Pendergast fe5a844be5 Capabilities: When creating an auto-draft, ensure that the current user still has permission to do so.
Built from https://develop.svn.wordpress.org/trunk@33357


git-svn-id: http://core.svn.wordpress.org/trunk@33329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 04:02:25 +00:00
Konstantin Obenland 0f61e187b6 Site Icon: Create custom sizes for images that don't need cropping.
This will duplicate an image that doesn't need cropping once and will skip
creating new images and custom sizes if the selected image has the `site-icon`
context.

Fixes #33011.

Built from https://develop.svn.wordpress.org/trunk@33356


git-svn-id: http://core.svn.wordpress.org/trunk@33328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 02:30:25 +00:00
Jeremy Felt a0e830d9af Nav Menus: Add a Menus title with Manage in Customizer button to nav-menus.php
This aligns the `<h1>` on `wp-admin/nav-menus.php` with that of other admin screens and aligns the "Manage in Customizer" button with that on `wp-admin/widgets.php`.

Fixes #32808.

Built from https://develop.svn.wordpress.org/trunk@33355


git-svn-id: http://core.svn.wordpress.org/trunk@33327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 01:26:25 +00:00
Andrew Ozz e5340ea63f Widgets screen: while dragging a widget over a closed sidebar refresh only the widgets in the current sidebar instead of all widgets in all sidebars.
Props chriscct7. Fixes #33015.
Built from https://develop.svn.wordpress.org/trunk@33354


git-svn-id: http://core.svn.wordpress.org/trunk@33326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 01:25:26 +00:00
Konstantin Obenland 45bfab3aa8 Passwords: Add password strength meter feedback for screen readers.
Also gives context to the show/hide button.

Props rianrietveld, afercia.
Fixes #33032.


Built from https://develop.svn.wordpress.org/trunk@33353


git-svn-id: http://core.svn.wordpress.org/trunk@33325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 00:15:25 +00:00
Ella Iseulde Van Dorpe 482f174f2e Publish box: move focus when the animation is done
Also move the focus back to 'edit' when saving changes.

Props afercia.
Fixes #33060.

Built from https://develop.svn.wordpress.org/trunk@33352


git-svn-id: http://core.svn.wordpress.org/trunk@33324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:46:24 +00:00
Andrew Ozz d8980f96da TinyMCE: add min-width to the placeholder images for the more and nextpage tags to fix them in themes that force width = auto.
Fixes #33022.
Built from https://develop.svn.wordpress.org/trunk@33351


git-svn-id: http://core.svn.wordpress.org/trunk@33323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:36:24 +00:00
Andrew Ozz 8a090123ce TinyMCE, inline link toolbar: tweak styling on small screens to fix wrapping in iOS.
Fixes #32604.
Built from https://develop.svn.wordpress.org/trunk@33350


git-svn-id: http://core.svn.wordpress.org/trunk@33322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:25:24 +00:00
Ella Iseulde Van Dorpe 253d9db831 Publish box: focus first date field on edit
The order of the fields may change depending on the translation.

Props afercia.
Fixes #33059.

Built from https://develop.svn.wordpress.org/trunk@33349


git-svn-id: http://core.svn.wordpress.org/trunk@33321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:23:24 +00:00
Ella Iseulde Van Dorpe d827a71c7f Publish box: apply changes post.js to comment.js
See [22250], [27035], [24046], [33340] and [33341].
Fixes #33063.

Built from https://develop.svn.wordpress.org/trunk@33348


git-svn-id: http://core.svn.wordpress.org/trunk@33320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:09:25 +00:00
Scott Taylor 23712a822f Customizer: Nav Menus JS cleanup, second round
* Follow the same pattern of namespace instantiation that `WidgetCustomizerPreview` uses
* Remove use of `self` for global delegation
* Use `api` for `wp.customize` and import only top-level globals
* Bind `this` where appropriate and disambiguate scope

See #32911.

Built from https://develop.svn.wordpress.org/trunk@33347


git-svn-id: http://core.svn.wordpress.org/trunk@33319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 17:40:25 +00:00
Konstantin Obenland 146befe7bf Customizer: Add label for menu names when editing a menu.
Props celloexpressions.
Fixes #32726.


Built from https://develop.svn.wordpress.org/trunk@33346


git-svn-id: http://core.svn.wordpress.org/trunk@33318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 17:02:24 +00:00
Scott Taylor 4e8fc7b69c Customizer: Nav Menus JS cleanup, first round
* In `init`, settings should be fresh and set to default values before extending
* When looping via `_.each`, pass `this` as 3rd arg to bind context
* Settings should be encapsulated in the module, instead of being exposed as static class props
* `currentRefreshMenuInstanceDebouncedCalls` should be encapsulated and renamed, instead of being the longest symbol in the entire codebase

See #32911.

Built from https://develop.svn.wordpress.org/trunk@33345


git-svn-id: http://core.svn.wordpress.org/trunk@33317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 16:14:24 +00:00
Ella Iseulde Van Dorpe 50159974c9 Editor: word count: exclude HTML comments and entities
Also make sure `type` is one of the three allowed types and remove unnecessary regex flags.

See #30966.

Built from https://develop.svn.wordpress.org/trunk@33344


git-svn-id: http://core.svn.wordpress.org/trunk@33316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 15:24:24 +00:00
Scott Taylor bf481ed496 After [33325], add a doc summary.
Fixes #20662.

Built from https://develop.svn.wordpress.org/trunk@33343


git-svn-id: http://core.svn.wordpress.org/trunk@33315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 15:18:25 +00:00
Scott Taylor d349e9c290 Revert [32466], I will pick this up in 4.4.
See #32466.

Built from https://develop.svn.wordpress.org/trunk@33342


git-svn-id: http://core.svn.wordpress.org/trunk@33314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 15:10:27 +00:00
Ella Iseulde Van Dorpe 52f6aebdaa Publish box: fix leading zeros in date format
See #30716.

Built from https://develop.svn.wordpress.org/trunk@33341


git-svn-id: http://core.svn.wordpress.org/trunk@33313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 14:55:24 +00:00
Ella Iseulde Van Dorpe 262c1a7e54 Publish box: fix strange date format after change
Part props tyxla.
Fixes #30716.

Built from https://develop.svn.wordpress.org/trunk@33340


git-svn-id: http://core.svn.wordpress.org/trunk@33312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 11:40:25 +00:00
Dominik Schilling 4dcfd3ec83 Customizer: Avoid duplicate IDs and remove role presentation from menu items reorder button. Follow-up to [33074].
props afercia.
fixes #32725.
Built from https://develop.svn.wordpress.org/trunk@33339


git-svn-id: http://core.svn.wordpress.org/trunk@33311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 11:37:26 +00:00
Ella Iseulde Van Dorpe 1ab119798c TinyMCE: views: make sure gallery captions update
Part props dmsnell.
Fixes #32779.

Built from https://develop.svn.wordpress.org/trunk@33338


git-svn-id: http://core.svn.wordpress.org/trunk@33310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 23:56:25 +00:00
Ella Iseulde Van Dorpe 1d92ed1c79 JSHint: don't redeclare globals listed in .jshintrc
See #33021.

Built from https://develop.svn.wordpress.org/trunk@33337


git-svn-id: http://core.svn.wordpress.org/trunk@33309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 23:39:24 +00:00
Konstantin Obenland f1e604e6e2 Customize: Align screen options toggle with info icon.
Fixes #32733.

Built from https://develop.svn.wordpress.org/trunk@33336


git-svn-id: http://core.svn.wordpress.org/trunk@33308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 21:21:25 +00:00
Konstantin Obenland 8dad70c190 Tests: Remove test for `delete_site_icon()`.
Removed in [33329].
H/t wonderboymusic.

See #16434.

Built from https://develop.svn.wordpress.org/trunk@33335


git-svn-id: http://core.svn.wordpress.org/trunk@33307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 20:53:24 +00:00
Konstantin Obenland f9c88fcb5c Toolbar: Restore scroll-to-top functionality.
H/t Ipstenu.
Introduced in [33056].

See #29906.


Built from https://develop.svn.wordpress.org/trunk@33334


git-svn-id: http://core.svn.wordpress.org/trunk@33306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 20:02:24 +00:00
Konstantin Obenland 0ccb9c47cb Site Icon: Center initial crop position.
Starting out at the center of the image makes for a better user experience.

Props iseulde.
Fixes #33050.


Built from https://develop.svn.wordpress.org/trunk@33333


git-svn-id: http://core.svn.wordpress.org/trunk@33305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 19:02:24 +00:00
Konstantin Obenland f535f2889b Site Icon: Improve vertical spacing in preview.
Props eliorivero.
Fixes #33038.


Built from https://develop.svn.wordpress.org/trunk@33332


git-svn-id: http://core.svn.wordpress.org/trunk@33304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 19:01:50 +00:00
Konstantin Obenland 7c75a6d00a Passwords: Use small screen styles for all small screens.
H/t johnjamesjacoby.
Introduced in [33206].

See #32589.

Built from https://develop.svn.wordpress.org/trunk@33331


git-svn-id: http://core.svn.wordpress.org/trunk@33303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 19:01:26 +00:00
Konstantin Obenland 7725d25cb7 Use WP's version number after monkey-patch in [33329].
Built from https://develop.svn.wordpress.org/trunk@33330


git-svn-id: http://core.svn.wordpress.org/trunk@33302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 17:27:24 +00:00
Konstantin Obenland 3248497cf3 Site Icon: Add crop preview to the media modal.
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.

Fixes #16434.



Built from https://develop.svn.wordpress.org/trunk@33329


git-svn-id: http://core.svn.wordpress.org/trunk@33301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 15:57:25 +00:00
Weston Ruter 8041554b30 Customizer: Fix previewing certain changes to nav menus.
Addresses regression introduced in [33138], where deleted menu items would not be removed from the preview, and changes to a location's assigned menu would likewise not preview. Also makes the binding of the setting change events more robust.

Fixes #33010.


Built from https://develop.svn.wordpress.org/trunk@33328


git-svn-id: http://core.svn.wordpress.org/trunk@33300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 07:44:26 +00:00
Dion Hulse 412013a158 Allow HTML/entities in the Active Theme Name in the themes.php & Customizer templates.
Props iCaleb
Fixes #33036

Built from https://develop.svn.wordpress.org/trunk@33327


git-svn-id: http://core.svn.wordpress.org/trunk@33299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 01:46:24 +00:00
Scott Taylor 432f9891f7 Ensure that private posts cannot be made sticky via Quick Edit.
DRY the logic for stickies in `wp_xmlrpc_server` by introducing `->_toggle_sticky()`.

Props wonderboymusic, obenland, chriscct7.
Fixes #20662.

Built from https://develop.svn.wordpress.org/trunk@33325


git-svn-id: http://core.svn.wordpress.org/trunk@33297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 18:09:25 +00:00
Andrew Nacin 2166b4a6c1 JSHint: Use 'global' rather than 'globals' for inline configuration.
Don't declare a global already listed in .jshintrc.

props johnjamesjacoby.
fixes #33021.

Built from https://develop.svn.wordpress.org/trunk@33324


git-svn-id: http://core.svn.wordpress.org/trunk@33296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 17:09:26 +00:00
Weston Ruter 910092531b Customizer: Indicate when there are no nav menu items available for a given type.
Props celloexpressions, valendesigns, rittesh.patel.
Fixes #32810.

Built from https://develop.svn.wordpress.org/trunk@33323


git-svn-id: http://core.svn.wordpress.org/trunk@33295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 00:06:24 +00:00
Weston Ruter afd7a8e836 Customizer: Finish unit tests for nav menus.
Removes object_type restriction to allow for future extensibility. Refactors some methods to improve testability. Includes new tests for Ajax requests.

Fixes #32687.
Props valendesigns, welcher, westonruter.

Built from https://develop.svn.wordpress.org/trunk@33322


git-svn-id: http://core.svn.wordpress.org/trunk@33294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 23:20:25 +00:00
Weston Ruter a36d50fbd0 Customizer: Prevent `wp-a11y` from being needlessly enqueued in the customizer preview.
Reduces the number of live regions that screen readers have to deal with.

Fixes #33001.

Built from https://develop.svn.wordpress.org/trunk@33321


git-svn-id: http://core.svn.wordpress.org/trunk@33293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 17:10:25 +00:00
Ella Iseulde Van Dorpe e9b6d25bcd Editor: word count: count astrals as one character
This makes sure an emoji, for example, is counted as one character.

See #30966.

Built from https://develop.svn.wordpress.org/trunk@33320


git-svn-id: http://core.svn.wordpress.org/trunk@33292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 11:42:25 +00:00
Drew Jaynes 0729c70e03 Update the description for `get_the_category()` with helpful information for the proper function to use for custom taxonomies.
Also adds a missing return description.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@33318


git-svn-id: http://core.svn.wordpress.org/trunk@33290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 22:58:25 +00:00
Weston Ruter 909dde9ce5 Customizer: Move "Menu options" heading outside of a nav menu auto-add control's label.
Standardizes capitalization. Amends [33189].

Props valendesigns.
Fixes #32820.

Built from https://develop.svn.wordpress.org/trunk@33317


git-svn-id: http://core.svn.wordpress.org/trunk@33289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 22:42:24 +00:00
Gary Pendergast a6cb4b293c WPDB: `::strip_text_from_query()` doesn't pass a length to `::strip_invalid_text()`, which was causing queries to fail when they contained characters that needed to be sanity checked by MySQL.
Props dd32, mdawaffe, pento.

Fixes #32279.


Built from https://develop.svn.wordpress.org/trunk@33310


git-svn-id: http://core.svn.wordpress.org/trunk@33282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 07:07:26 +00:00
Gary Pendergast 6759a210ca WPDB: Remove some of the complexities in `::strip_invalid_text()` associated with switching character sets between queries. Instead of trying to dynamically change connection character sets, we now rely on the value of `::charset`. This also fixes the case where queries were being blocked when `DB_CHARSET` was `utf8`, but the column character set was non-`utf8`.
Fixes #32165.


Built from https://develop.svn.wordpress.org/trunk@33308


git-svn-id: http://core.svn.wordpress.org/trunk@33280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-17 06:34:26 +00:00
Andrew Ozz f9980c793c wpLink: fix vertical alignment of the fields labels.
Part props daniluk4000. Fixes #32829.
Built from https://develop.svn.wordpress.org/trunk@33300


git-svn-id: http://core.svn.wordpress.org/trunk@33272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 23:58:25 +00:00
Ella Iseulde Van Dorpe f00d1e63f1 Editor: word count: exclude shortcodes
Props desaiuditd, adamsilverstein, azaozz and iseulde.
Fixes #27386. See #30966.

Built from https://develop.svn.wordpress.org/trunk@33299


git-svn-id: http://core.svn.wordpress.org/trunk@33271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 21:09:26 +00:00
Ella Iseulde Van Dorpe dac985cdc4 Editor: Add Media should be a button
Props afercia.
Fixes #32969.

Built from https://develop.svn.wordpress.org/trunk@33298


git-svn-id: http://core.svn.wordpress.org/trunk@33270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 19:38:23 +00:00
Helen Hou-Sandí e9f33a90b3 Customizer: Ensure consistent margins in sections.
Since the customizer dynamically changes, `nth-child` selectors are not always a great idea.

props afercia.
fixes #32902.

Built from https://develop.svn.wordpress.org/trunk@33297


git-svn-id: http://core.svn.wordpress.org/trunk@33269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 19:15:27 +00:00