Commit Graph

24834 Commits

Author SHA1 Message Date
Sergey Biryukov e35d675558 Add braces around conditionals. props TobiasBg. fixes #25704.
Built from https://develop.svn.wordpress.org/trunk@27082


git-svn-id: http://core.svn.wordpress.org/trunk@26955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 20:17:11 +00:00
Scott Taylor 4830eeb9ad Properly invalidate the cache for `wp_count_posts()` on insert, trash, or when transitioning `post_status` inside of `_transition_post_status()`. Introduces `_count_posts_cache_key()`. Adds unit tests.
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879.


Built from https://develop.svn.wordpress.org/trunk@27081


git-svn-id: http://core.svn.wordpress.org/trunk@26954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 19:42:13 +00:00
Andrew Ozz 2f6d9d37cc Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854.
Built from https://develop.svn.wordpress.org/trunk@27080


git-svn-id: http://core.svn.wordpress.org/trunk@26953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 05:31:14 +00:00
Andrew Ozz 87c3c8adc0 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233.
Built from https://develop.svn.wordpress.org/trunk@27079


git-svn-id: http://core.svn.wordpress.org/trunk@26952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 23:50:13 +00:00
Andrew Ozz 7e7723f1de Editor: add :focus style for the Quicktags buttons, fixes #26932
Built from https://develop.svn.wordpress.org/trunk@27078


git-svn-id: http://core.svn.wordpress.org/trunk@26951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:38:12 +00:00
Andrew Nacin 39e32ed1eb Consistently trim and unslash search queries for the users list tables.
props aubreypwd.
fixes #26115.

Built from https://develop.svn.wordpress.org/trunk@27077


git-svn-id: http://core.svn.wordpress.org/trunk@26950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:10:12 +00:00
Andrew Nacin fb3985663a Remove an unnecessary variable passed to wpdb::prepare() during multisite load.
props jeremyfelt.
fixes #26941.

Built from https://develop.svn.wordpress.org/trunk@27076


git-svn-id: http://core.svn.wordpress.org/trunk@26949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:09:12 +00:00
Andrew Nacin 43c7993c1a When the MySQL server has "gone away," attempt to reconnect and retry the query.
props pento.
see #5932.

Built from https://develop.svn.wordpress.org/trunk@27075


git-svn-id: http://core.svn.wordpress.org/trunk@26948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 22:07:12 +00:00
Andrew Nacin 17828876fa Add a comment for [27073] as someone will inevitably complain it is tricked by % in a string. see #25604.
Built from https://develop.svn.wordpress.org/trunk@27074


git-svn-id: http://core.svn.wordpress.org/trunk@26947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:48:13 +00:00
Andrew Nacin 9c4a97c676 Throw an incorrect usage notice when the query argument of wpdb::prepare() does not include a placeholder.
props ounziw.
fixes #25604.

Built from https://develop.svn.wordpress.org/trunk@27073


git-svn-id: http://core.svn.wordpress.org/trunk@26946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:47:11 +00:00
Andrew Nacin 9f250b2ef7 Ensure compatibility with MySQL 5.6 which has stricter SQL modes by default.
Disables NO_ZERO_DATE, ONLY_FULL_GROUP_BY, STRICT_TRANS_TABLES, STRICT_ALL_TABLES, TRADITIONAL. Introduces wpdb::set_sql_mode() with an incompatible_sql_modes filter so a plugin can alter the set mode after the fact.

props pento.
fixes #26847.

Built from https://develop.svn.wordpress.org/trunk@27072


git-svn-id: http://core.svn.wordpress.org/trunk@26945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:39:13 +00:00
Andrew Ozz 28cd7371c4 WP_Link: convert < > and " to HTML entities when setting link title for the Text editor. Fixes #25704.
Built from https://develop.svn.wordpress.org/trunk@27071


git-svn-id: http://core.svn.wordpress.org/trunk@26944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 21:12:12 +00:00
Dominik Schilling a4e5457ee1 Update @return statement of wp_nonce_url(): The URL is escaped.
props c3mdigital.
see #4221.
Built from https://develop.svn.wordpress.org/trunk@27070


git-svn-id: http://core.svn.wordpress.org/trunk@26943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 10:53:11 +00:00
Andrew Nacin 59f86351c9 Use get_current_user_id() instead of $user_ID in user-edit.php.
props kovshenin.
fixes #26274.

Built from https://develop.svn.wordpress.org/trunk@27069


git-svn-id: http://core.svn.wordpress.org/trunk@26942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 10:04:13 +00:00
Andrew Nacin 0e0c2d3cdc New resetpass_form hook in wp-login.php.
props romaimperator.
fixes #21044.

Built from https://develop.svn.wordpress.org/trunk@27068


git-svn-id: http://core.svn.wordpress.org/trunk@26941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 07:52:13 +00:00
Scott Taylor d6baca3c35 Fix an error in SQL generation when `perm` is set and an array is passed for `post_status`. Adds unit test.
Props oso96_2000.
Fixes #25523.


Built from https://develop.svn.wordpress.org/trunk@27067


git-svn-id: http://core.svn.wordpress.org/trunk@26940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 07:36:13 +00:00
Andrew Nacin 718cc193c9 Ensure the last separator is removed from the user and network admin menus.
props johnjamesjacoby.
fixes #25425.

Built from https://develop.svn.wordpress.org/trunk@27066


git-svn-id: http://core.svn.wordpress.org/trunk@26939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 06:19:12 +00:00
Andrew Nacin 08a1d44ba5 Add arguments to the wp_dropdown_cats filter, and docs.
props olivM.
fixes #24103.

Built from https://develop.svn.wordpress.org/trunk@27065


git-svn-id: http://core.svn.wordpress.org/trunk@26938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 05:33:13 +00:00
Scott Taylor 38bd18bd08 Remove `$force` argument from `WP_Object_Cache::delete()`. From @nacin: "This was for internal-use-only, I don't think _deprecated_argument() is needed, but let's put a comment somewhere just so we know we'd have to be careful if we ever want to add a third argument here later."
`$force` argument has been removed, and docs were updated.

Fixes #22478.


Built from https://develop.svn.wordpress.org/trunk@27064


git-svn-id: http://core.svn.wordpress.org/trunk@26937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-01 22:25:16 +00:00
Scott Taylor 84911b9707 Let the video shortcode accept a YouTube URL as the value of its `src` attribute, as MediaElement.js supports Chromeless YouTube videos by using a pseudo-mime-type `video/youtube`.
HTTP and HTTPS www, non-www, and short url fronts are supported:
http://www.youtube.com/watch 
https://www.youtube.com/watch
http://youtube.com/watch
https://youtube.com/watch
http://youtu.be
https://youtu.be

Fixes #24764.


Built from https://develop.svn.wordpress.org/trunk@27063


git-svn-id: http://core.svn.wordpress.org/trunk@26936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-31 18:59:13 +00:00
Andrew Ozz 7b4b508b91 TinyMCE: update to 4.0.16, see #24067.
Built from https://develop.svn.wordpress.org/trunk@27062


git-svn-id: http://core.svn.wordpress.org/trunk@26935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-31 18:58:15 +00:00
Andrew Nacin c88f57d7c0 Update Dashicons to latest. Adds line break, paragraph, code, and bbPress.
props empireoflight, melchoyce.
see #26936.

Built from https://develop.svn.wordpress.org/trunk@27061


git-svn-id: http://core.svn.wordpress.org/trunk@26934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-31 00:41:13 +00:00
Andrew Ozz 314f9569e5 TinyMCE: update to 4.0.14. Remove the fix for using init.setup in old plugins, now fixed upstream. See #24067.
Built from https://develop.svn.wordpress.org/trunk@27060


git-svn-id: http://core.svn.wordpress.org/trunk@26933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-31 00:06:12 +00:00
Scott Taylor 79ad468c61 Upgrade MediaElement to 2.13.2 from 2.13.0. For a full list of changes: https://github.com/johndyer/mediaelement/compare/2.13.0...2.13.2
Fixes #26954.


Built from https://develop.svn.wordpress.org/trunk@27059


git-svn-id: http://core.svn.wordpress.org/trunk@26932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 18:24:11 +00:00
Andrew Ozz ede5c4d01c TinyMCE: add outline when a button is focused. Fixes #26931, see #24067.
Built from https://develop.svn.wordpress.org/trunk@27058


git-svn-id: http://core.svn.wordpress.org/trunk@26931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 18:14:13 +00:00
Scott Taylor a6b3bced06 `get_comment()`, `wp_get_post_revision()`, and `get_term()` all used to return by reference. Because of this, `$null` was set to `null` so the return value would be a variable where applicable. This has not been necessary since [21792], so the `$null`s have been removed.
Props toszcze.
Fixes #24768.


Built from https://develop.svn.wordpress.org/trunk@27057


git-svn-id: http://core.svn.wordpress.org/trunk@26930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 06:46:12 +00:00
Scott Taylor 678ef2b1e1 In `wpdb::db_connect()`, allow the loading of a custom database error template - this is already allowed in `dead_db()`.
In `dead_db()`, move the call to `wp_load_translations_early()` before the inclusion of the `db-error.php` file to allow translation in both locations before the template is loaded.

Props sbruner, kovshenin.
Fixes #25703.


Built from https://develop.svn.wordpress.org/trunk@27056


git-svn-id: http://core.svn.wordpress.org/trunk@26929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 05:28:12 +00:00
Scott Taylor ad211ca06a Add Unit Tests for `get_comment_pages_count()`. Fix a notice caused when `$wp_query->comments` is not set in that function.
Props mdbitz, markjaquith.
Fixes #20633.


Built from https://develop.svn.wordpress.org/trunk@27055


git-svn-id: http://core.svn.wordpress.org/trunk@26928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 05:17:12 +00:00
Scott Taylor 0347a8944e Update the versions of several `devDependencies` in `package.json`. `grunt-cssjanus` has been updated to `0.2.2`, we no longer need the fork. Run `npm install` to receive updates for `node_modules` in the project root.
Props yoavf, TobiasBg.
Fixes #26073.


Built from https://develop.svn.wordpress.org/trunk@27053


git-svn-id: http://core.svn.wordpress.org/trunk@26927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 04:43:30 +00:00
Andrew Ozz 6f25a990d0 TinyMCE: fix Ctrl + s shortcut (trigger autosave), see #24067.
Built from https://develop.svn.wordpress.org/trunk@27052


git-svn-id: http://core.svn.wordpress.org/trunk@26926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:29:12 +00:00
Scott Taylor e1759d668a For starters, [27050] is rad. This just cleans up some extra new lines that were littered about, updates *some* of the inline docs (needs more), moves `wp.media.controller.ImageDetails` closer to its parent class, and de-dupes some code in `media-template.php`.
See #24409.


Built from https://develop.svn.wordpress.org/trunk@27051


git-svn-id: http://core.svn.wordpress.org/trunk@26925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:21:13 +00:00
Andrew Ozz 33eedc570b Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409.
Built from https://develop.svn.wordpress.org/trunk@27050


git-svn-id: http://core.svn.wordpress.org/trunk@26924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 21:17:12 +00:00
Drew Jaynes 9172107539 Inline documentation for hooks in wp-includes/class-http.php.
Props kraftbj for the initial patches. Props kpdesign, DrewAPicture.
Fixes #26049.

Built from https://develop.svn.wordpress.org/trunk@27049


git-svn-id: http://core.svn.wordpress.org/trunk@26923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:25:11 +00:00
Drew Jaynes 0715a1d551 Inline documentation for hooks in wp-admin/includes/export.php.
Props cmmarslender, kpdesign.
Fixes #26894.

Built from https://develop.svn.wordpress.org/trunk@27048


git-svn-id: http://core.svn.wordpress.org/trunk@26922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:10:12 +00:00
Drew Jaynes b977d778b2 Inline documentation for hooks in wp-admin/includes/update-core.php.
Props JoshuaAbenazer, kpdesign.
Fixes #25998.

Built from https://develop.svn.wordpress.org/trunk@27047


git-svn-id: http://core.svn.wordpress.org/trunk@26921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:02:14 +00:00
Helen Hou-Sandí 291ed370b4 Autocomplete for the new site admin email. Better than trying to remember which email address you used.
fixes #25348.

Built from https://develop.svn.wordpress.org/trunk@27046


git-svn-id: http://core.svn.wordpress.org/trunk@26920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 23:10:12 +00:00
Andrew Nacin d39d60e841 Add wp_install and wp_upgrade hooks to the respective functions.
props Denis-de-Bernardy.
fixes #25762.

Built from https://develop.svn.wordpress.org/trunk@27045


git-svn-id: http://core.svn.wordpress.org/trunk@26919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 16:32:12 +00:00
Andrew Ozz 544116e76a TinyMCE: add dashicon for the "wp_page" button, see #24067.
Built from https://develop.svn.wordpress.org/trunk@27044


git-svn-id: http://core.svn.wordpress.org/trunk@26918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 15:06:32 +00:00
Dominik Schilling ea7f080573 Update help content for Dashboard. props kpdesign. fixes #26632.
Built from https://develop.svn.wordpress.org/trunk@27043


git-svn-id: http://core.svn.wordpress.org/trunk@26917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 14:47:12 +00:00
Andrew Nacin c4e119d530 Basic unit tests and additional documentation for wp_strip_all_tags().
props joehoyle.
fixes #25507.

Built from https://develop.svn.wordpress.org/trunk@27042


git-svn-id: http://core.svn.wordpress.org/trunk@26916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 03:16:11 +00:00
Andrew Ozz 398ae265bc DFW: remove unused #wp-fullscreen-title-prompt-text selectors. See #24067.
Built from https://develop.svn.wordpress.org/trunk@27039


git-svn-id: http://core.svn.wordpress.org/trunk@26915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 00:39:12 +00:00
Andrew Ozz 864ab9ae56 Autosave:
- Move the 'Saving post' and 'Draft saved at...' strings from autosaveL10n to postL10n as they are used only there.
- Use the custom jQuery events 'before-autosave' and 'after-autosave' to show these messages.
- Separate autosave.suspend() for local and server so local autosaves can continue while server autosaves are suspended.
- Remove the recently added autosave.server.disable() and use autosave.server.suspend() instead.
- Bring back .button.disabled, button-primary.disabled and use .disabled to prevent multiple form submissions.
See #25272.

Built from https://develop.svn.wordpress.org/trunk@27038


git-svn-id: http://core.svn.wordpress.org/trunk@26914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 00:28:13 +00:00
Andrew Ozz ced6e2a428 Remove one more valign, props neoxx, fixes #22712.
Built from https://develop.svn.wordpress.org/trunk@27037


git-svn-id: http://core.svn.wordpress.org/trunk@26913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:38:11 +00:00
Andrew Ozz 87589dd445 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
Built from https://develop.svn.wordpress.org/trunk@27036


git-svn-id: http://core.svn.wordpress.org/trunk@26912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:28:12 +00:00
Andrew Ozz 61540893f3 Fix tabbing order when opening/closing post status and visibility in the Publish postbox and cache some of the jQuery selectors. Part-props atimmer, fixes #25460.
Built from https://develop.svn.wordpress.org/trunk@27035


git-svn-id: http://core.svn.wordpress.org/trunk@26911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 03:07:16 +00:00
Andrew Ozz 07ae13e432 TinyMCE: do not run preventDefault() on the tab key when Ctrl, Alt or Command key is also pressed. Ctrl + Tab is used to switch between browser tabs. See #24067, fixes #17261.
Built from https://develop.svn.wordpress.org/trunk@27034


git-svn-id: http://core.svn.wordpress.org/trunk@26910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 00:29:12 +00:00
Dominik Schilling 496c05f1e9 Remove unused code. props nofearinc. fixes #26205.
Built from https://develop.svn.wordpress.org/trunk@27033


git-svn-id: http://core.svn.wordpress.org/trunk@26909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 00:12:11 +00:00
Scott Taylor 7ef7a7cb47 Add some inline docs to methods in `media-models.js` - particularly around `@param` and `@returns`.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@27032


git-svn-id: http://core.svn.wordpress.org/trunk@26908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 08:56:12 +00:00
Scott Taylor bf09d042eb Add some JSDoc annotations to `media-models.js` to disambiguate instance properties and static class properties/methods in the base media Models.
See #26870.


Built from https://develop.svn.wordpress.org/trunk@27031


git-svn-id: http://core.svn.wordpress.org/trunk@26907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 07:39:11 +00:00
Andrew Ozz ed3145ec3d TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.
Built from https://develop.svn.wordpress.org/trunk@27030


git-svn-id: http://core.svn.wordpress.org/trunk@26906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 01:21:13 +00:00