Commit Graph

15581 Commits

Author SHA1 Message Date
Aaron Jorbin 4e3df608dc Remove Debugging code introduced in [37145]
Built from https://develop.svn.wordpress.org/trunk@37148


git-svn-id: http://core.svn.wordpress.org/trunk@37115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:58:26 +00:00
Aaron Jorbin bd7ffca854 Add Nonce to updating wporg_favorites user meta field
Built from https://develop.svn.wordpress.org/trunk@37145


git-svn-id: http://core.svn.wordpress.org/trunk@37112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:36:26 +00:00
Nikolay Bachiyski 9b7a775413 Add nonce to AJAX action for script compression setting
Built from https://develop.svn.wordpress.org/trunk@37143


git-svn-id: http://core.svn.wordpress.org/trunk@37110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:21:25 +00:00
Jeremy Felt cb2b3ed3c7 Multisite: Improve escaping in network settings.
Built from https://develop.svn.wordpress.org/trunk@37124


git-svn-id: http://core.svn.wordpress.org/trunk@37091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 15:59:26 +00:00
Dominik Schilling 6a3acea8b5 Multisite: Validate new email address confirmations.
Built from https://develop.svn.wordpress.org/trunk@37103


git-svn-id: http://core.svn.wordpress.org/trunk@37070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 14:44:26 +00:00
Pascal Birchler b204d3ead2 Taxonomy: After [36874], run the correct `load-edit-tags.php` hook on the new term edit page.
When not misspelled, this hook is useful (and needed) for backward compatibility.

Unprops swissspidy.
Fixes #34988.
Built from https://develop.svn.wordpress.org/trunk@37084


git-svn-id: http://core.svn.wordpress.org/trunk@37051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-27 15:16:29 +00:00
Dominik Schilling a2d62ccf32 Common CSS: Reset bottom padding for `.nav-tab-wrapper`.
Props ericdaams.
Fixes #35960.
Built from https://develop.svn.wordpress.org/trunk@37073


git-svn-id: http://core.svn.wordpress.org/trunk@37040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 20:14:26 +00:00
Weston Ruter 41bbbfa5e7 Customize: Prevent preview `iframe` from showing until fully loaded.
Fixes issue where the Customizer preview window can appear to momentarily bounce to the top when being refreshed. Regression from [36532].

See #31195.
Fixes #36276.

Built from https://develop.svn.wordpress.org/trunk@37060


git-svn-id: http://core.svn.wordpress.org/trunk@37027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-23 00:53:28 +00:00
Dominik Schilling 6c81a0cbf6 Users: In `edit_user()` check for a blank password when adding a user.
Props wesleye, gitlost, adamsilverstein.
Fixes #35715.
Built from https://develop.svn.wordpress.org/trunk@37059


git-svn-id: http://core.svn.wordpress.org/trunk@37026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-22 23:07:27 +00:00
Weston Ruter f3f84d2f21 Customize: Require opt-in for selective refresh of widgets.
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.

Built from https://develop.svn.wordpress.org/trunk@37040


git-svn-id: http://core.svn.wordpress.org/trunk@37007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-21 21:59:29 +00:00
Andrew Ozz d47a15ed3c Media: fix erroneously inserting a rel attribute in `get_image_send_to_editor()`. Reverts most of [34259] and [34260] and adds a unit test.
Props joemcgill, azaozz.
Fixes #36084.
Built from https://develop.svn.wordpress.org/trunk@37035


git-svn-id: http://core.svn.wordpress.org/trunk@37002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-18 20:05:26 +00:00
Dominik Schilling 6a90070793 I18N: Move translatable Codex URLs to separate strings in `wp-admin/includes/meta-boxes.php`.
Props ramiy.
Fixes #35751.
Built from https://develop.svn.wordpress.org/trunk@37016


git-svn-id: http://core.svn.wordpress.org/trunk@36983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 16:58:26 +00:00
Andrew Ozz d529800cba Editor: fix exiting DFW with the keyboard shortcut on Mac (Opt+Ctrl+W).
Fixes #36222.
Built from https://develop.svn.wordpress.org/trunk@37003


git-svn-id: http://core.svn.wordpress.org/trunk@36970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-16 02:48:25 +00:00
John Blackbourn 852f085d19 Docs: The `$update_result` parameter passed to `WP_Automatic_Updater::after_core_update()` is never a `WP_Error`. If an error is returned, the error object lives in the `result` property of the paramter.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36995


git-svn-id: http://core.svn.wordpress.org/trunk@36962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 22:43:27 +00:00
Sergey Biryukov 138b2abcf5 Media: Fix typo introduced in [36887].
Props claudiosanches.
Fixes #36230. See #36089.
Built from https://develop.svn.wordpress.org/trunk@36987


git-svn-id: http://core.svn.wordpress.org/trunk@36954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 09:00:28 +00:00
Andrew Ozz 13c885bdce TinyMCE, inline link:
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().

Props afercia, azaozz.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36985


git-svn-id: http://core.svn.wordpress.org/trunk@36952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 01:39:26 +00:00
Eric Lewis 8592072857 Editor: Fix Mac keyboard shortcut for distraction free writing.
Fixes #36214.

Built from https://develop.svn.wordpress.org/trunk@36973


git-svn-id: http://core.svn.wordpress.org/trunk@36941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 17:44:26 +00:00
Andrew Ozz 70ac7ab943 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved.
Props iseulde.
Fixes #16116.
Built from https://develop.svn.wordpress.org/trunk@36972


git-svn-id: http://core.svn.wordpress.org/trunk@36940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 17:22:26 +00:00
Andrew Ozz 91d2354e7c Editor: correct and update the Visual and Text editors description in the screen help.
Props arush, adamsilverstein, azaozz.
Fixes #35479.
Built from https://develop.svn.wordpress.org/trunk@36971


git-svn-id: http://core.svn.wordpress.org/trunk@36939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 16:43:26 +00:00
Dominik Schilling d8f3325c14 Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
Fixes #36218.
Built from https://develop.svn.wordpress.org/trunk@36970


git-svn-id: http://core.svn.wordpress.org/trunk@36938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 12:39:27 +00:00
Pascal Birchler 9462ab0576 Taxonomy: After [36874], rename `$term_id` to `$tag_ID` in `wp-admin/edit-tag-form.php`.
This ensures that no variables changed in the process of introducing `wp-admin/term.php`, improving overall backward compatibility.

Props Chouby for initial patch.
Fixes #34988.
Built from https://develop.svn.wordpress.org/trunk@36969


git-svn-id: http://core.svn.wordpress.org/trunk@36937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-11 08:52:29 +00:00
Andrea Fercia 0020bcd796 Coding standards after [36510].
Built from https://develop.svn.wordpress.org/trunk@36967


git-svn-id: http://core.svn.wordpress.org/trunk@36935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 23:18:26 +00:00
Andrea Fercia fd1f45a7cf Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.
Built from https://develop.svn.wordpress.org/trunk@36964


git-svn-id: http://core.svn.wordpress.org/trunk@36932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:37:26 +00:00
Andrea Fercia 899edd87da Accessibility: Improve the color contrast ratio of the expandable panel "handles".
Fixes #35923.
Built from https://develop.svn.wordpress.org/trunk@36959


git-svn-id: http://core.svn.wordpress.org/trunk@36927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 21:44:26 +00:00
Rachel Baker a6e66c0cfc Comments: On the Edit Comment screen do not show the permalink for unapproved comments.
Fixes #36161.
Built from https://develop.svn.wordpress.org/trunk@36958


git-svn-id: http://core.svn.wordpress.org/trunk@36926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 21:18:27 +00:00
Dominik Schilling d483093e0b Build Tools: Update grunt-rtlcss ~1.6.0 → ~2.0.1.
This updates the underlying RTLCSS framework to 2.0 which provides new options and config settings, see https://github.com/MohammadYounes/rtlcss/blob/master/CHANGELOG.md#200---18-feb-2016.

See #35104.

Build: https://build.trac.wordpress.org/changeset/36903
Built from https://develop.svn.wordpress.org/trunk@36935


git-svn-id: http://core.svn.wordpress.org/trunk@36903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 16:01:32 +00:00
Dominik Schilling f37eca2259 Editor: Fix size of the resize handle on RTL sites for HiDPI screens.
Also, add the `/*rtl:ignore*/` control directive so rtlcss doesn't process them again.

Fixes #36193.
Built from https://develop.svn.wordpress.org/trunk@36934


git-svn-id: http://core.svn.wordpress.org/trunk@36902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 14:06:29 +00:00
Aaron Jorbin 1972aa2a2a Add grunt prerelease task
An unintended consequence of improving the precommit task is that when it's time to run a release, more tasks need to get run to verify things. This adds a prerelease task to help fix that situation. grunt prerelease should include tasks that verify the code base is ready to be released to the wild and find all the tears on the mausoleum floor and help Blood stain the Colosseum doors.

See #35557

Built from https://develop.svn.wordpress.org/trunk@36930


git-svn-id: http://core.svn.wordpress.org/trunk@36898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 05:37:27 +00:00
Mel Choyce 3773f9be8b About: Improve color contrast of WP Badge text, and update the logo to use the latest version.
Fixes #35661.
Props @hugobaeta.

Built from https://develop.svn.wordpress.org/trunk@36910


git-svn-id: http://core.svn.wordpress.org/trunk@36878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 21:53:26 +00:00
Weston Ruter 7441acafaf Customize: Fix persistence of toggles for displayed nav menu item properties.
* Eliminates need to click more than one checkbox to have preferences saved.
* Adds debouncing to saving user-selected menu item properties.
* Also removes discrepancies between available nav menu item properties on admin page vs Customizer.

Fixes #35273.
Props afercia, westonruter.

Built from https://develop.svn.wordpress.org/trunk@36908


git-svn-id: http://core.svn.wordpress.org/trunk@36876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 21:41:28 +00:00
Konstantin Obenland f39d1e4fcc Customize: Reduce vertical space of site icon control.
Makes the control easier to find, reduces visual clutter, and is more
consistent with Customizer UI conventions.

Props celloexpressions.
Fixes #35943.

Built from https://develop.svn.wordpress.org/trunk@36907


git-svn-id: http://core.svn.wordpress.org/trunk@36875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 21:19:27 +00:00
Andrea Fercia a71f14b8d9 Accessibility: Reduce the WordPress shades of grey, Episode 3.
Also, removes some no more used CSS.

See #35783.
Built from https://develop.svn.wordpress.org/trunk@36904


git-svn-id: http://core.svn.wordpress.org/trunk@36872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 19:51:26 +00:00
Sergey Biryukov 90c7ce63d9 Use `admin_url()` for "Add New" links in `wp-admin/users.php`.
Props johnjamesjacoby.
Fixes #36186.
Built from https://develop.svn.wordpress.org/trunk@36902


git-svn-id: http://core.svn.wordpress.org/trunk@36870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 19:09:50 +00:00
Sergey Biryukov 729ddb899c Use `admin_url()` for "Add New" links in `wp-admin/upload.php`.
Props johnjamesjacoby.
See #36186.
Built from https://develop.svn.wordpress.org/trunk@36901


git-svn-id: http://core.svn.wordpress.org/trunk@36869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-09 19:09:25 +00:00
Dominik Schilling 7e8e3429e1 Media: Change wording for media files which aren't attached.
The media library can contain files which aren't attached yet. When attaching a file you currently get "Media attachment reattached.", or the opposite "Media attachment detached.". That's redundant and can be inaccurate. It's also not easy to translate in some languages.

This change generalizes the strings to refer to a "media file" instead.

Props SergeyBiryukov, ocean90, netweb.
Fixes #36089.
Built from https://develop.svn.wordpress.org/trunk@36887


git-svn-id: http://core.svn.wordpress.org/trunk@36854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-08 17:43:25 +00:00
Andrea Fercia 34ab7ae5ac Accessibility: Remove the title attributes from the old Media UI.
Also, adds better indication and attributes for the required form fields.
Moves some styles to `deprecated-media.css`.

Props andg, afercia.
Fixes #34944.
Built from https://develop.svn.wordpress.org/trunk@36879


git-svn-id: http://core.svn.wordpress.org/trunk@36846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:29:26 +00:00
Drew Jaynes d59fdfd951 Docs: Add a missing `@since` version to the DocBlock for `wp_add_dashboard_widget()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36878


git-svn-id: http://core.svn.wordpress.org/trunk@36845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:17:26 +00:00
Andrea Fercia 5bd8219816 Customizer: Improve the collapsed view when switching to the responsive view.
Props rittesh.patel, afercia.

Fixes #35220.
Built from https://develop.svn.wordpress.org/trunk@36877


git-svn-id: http://core.svn.wordpress.org/trunk@36844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:05:27 +00:00
Pascal Birchler 033044a872 Taxonomy: Improve backward compatibility on the `wp-admin/term.php` page.
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.
Built from https://develop.svn.wordpress.org/trunk@36874


git-svn-id: http://core.svn.wordpress.org/trunk@36841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 12:56:28 +00:00
Dion Hulse cbda43788b Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source.
Props diddledan.
Fixes #35290

Built from https://develop.svn.wordpress.org/trunk@36872


git-svn-id: http://core.svn.wordpress.org/trunk@36839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 06:32:29 +00:00
Andrea Fercia aaa040eee9 CSS: Rename the handle for `deprecated-media.css` after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.
Built from https://develop.svn.wordpress.org/trunk@36869


git-svn-id: http://core.svn.wordpress.org/trunk@36836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 15:38:28 +00:00
Sergey Biryukov b80a516549 Docs: Add `wp_add_dashboard_widget()` parameter descriptions.
Props meitar for initial patch.
Fixes #36092.
Built from https://develop.svn.wordpress.org/trunk@36868


git-svn-id: http://core.svn.wordpress.org/trunk@36835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 12:08:28 +00:00
Weston Ruter 40f6779665 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.

Built from https://develop.svn.wordpress.org/trunk@36866


git-svn-id: http://core.svn.wordpress.org/trunk@36833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 01:45:27 +00:00
Dominik Schilling 30f8c75047 Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.
Built from https://develop.svn.wordpress.org/trunk@36858


git-svn-id: http://core.svn.wordpress.org/trunk@36825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:07:25 +00:00
John Blackbourn 3184328ecb Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.
Fixes #35980

Built from https://develop.svn.wordpress.org/trunk@36853


git-svn-id: http://core.svn.wordpress.org/trunk@36820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 03:56:27 +00:00
Eric Lewis 0c1cca9961 Menus: Ensure theme location setting data is saved with a large menu.
[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.

Built from https://develop.svn.wordpress.org/trunk@36852


git-svn-id: http://core.svn.wordpress.org/trunk@36819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 00:47:26 +00:00
Weston Ruter a8ca958d43 Customize: Eliminate unnecessary `WP_Customize_Site_Logo_Control` in favor of re-using `WP_Customize_Image_Control`.
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096.

See #33755.
Fixes #35941.

Built from https://develop.svn.wordpress.org/trunk@36851


git-svn-id: http://core.svn.wordpress.org/trunk@36818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 23:47:26 +00:00
Dominik Schilling f11d47d9ba I18N: Fix an invalid placeholder added in [36844].
See #36048.
Built from https://develop.svn.wordpress.org/trunk@36850


git-svn-id: http://core.svn.wordpress.org/trunk@36817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 21:10:26 +00:00
Andrew Ozz 3bb9185496 TinyMCE, inline link: add styling for the dialog and UI Autocomplete to Press This.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36849


git-svn-id: http://core.svn.wordpress.org/trunk@36816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 20:31:26 +00:00
Andrew Ozz 9b2d44e5a1 Pres This:
- Change the newly added `press_this_save_post_content` filter to `press_this_save_post` and pass the $post_data array to it.
- Remove the newly added `press_this_useful_html_elements`. It only runs in compatibility mode when a URL is typed by the user.
- Remove the `press_this_suggested_content` filter. It is redundant as the suggested HTML for the editor is already filtered by `press_this_suggested_html`.
- Add some more inline docs and rename couple of vars to make the code more readable.

Fixes #34455.
Built from https://develop.svn.wordpress.org/trunk@36848


git-svn-id: http://core.svn.wordpress.org/trunk@36815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-04 18:56:26 +00:00