32ace06a39
Templates: Fix the return value of `get_the_author_posts_link()`.
...
When the `$authordata` global isn't defined, return an empty string, rather than `void`.
Props mukesh27, subrataemfluence.
Fixes #45597 .
Built from https://develop.svn.wordpress.org/trunk@44616
git-svn-id: http://core.svn.wordpress.org/trunk@44447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:54:49 +00:00
4fa5437fc1
Admin: Use `is_user_logged_in()` instead of `wp_validate_auth_cookie()` in `admin-post.php`.
...
This matches the authentication check in `admin-ajax.php`, and allows the authentication method to be filtered.
Props jmdodd.
Fixes #45475 .
Built from https://develop.svn.wordpress.org/trunk@44615
git-svn-id: http://core.svn.wordpress.org/trunk@44446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:41:50 +00:00
5ed802faf4
Docs: Correct the docs for `POMO_Reader::setEndian()`.
...
The parameter type and name where the wrong way around.
Props ishitaka.
Fixes #45410 .
Built from https://develop.svn.wordpress.org/trunk@44614
git-svn-id: http://core.svn.wordpress.org/trunk@44445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:36:48 +00:00
19642fd0c9
Docs: Correct the `@return` type of `get_theme_mod()`.
...
This now matches the type of the `$value` parameter of `set_theme_mod()`.
Props mensmaximus.
Fixes #45319 .
Built from https://develop.svn.wordpress.org/trunk@44613
git-svn-id: http://core.svn.wordpress.org/trunk@44444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:32:48 +00:00
97aef0e336
Docs: Remove duplicate docblocks for the `pre_user_login` and `link_category` filters.
...
Props coffee2code.
Fixes #45308 .
Built from https://develop.svn.wordpress.org/trunk@44612
git-svn-id: http://core.svn.wordpress.org/trunk@44443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:29:49 +00:00
655d44ffe8
Users: Add extra checking to `wp_new_user_notification()`.
...
Prevent a notification from being sent when an unrecognised value is passed in the `$notify` parameter.
Props cthreelabs, 360zen.
Fixes #44293 .
Built from https://develop.svn.wordpress.org/trunk@44611
git-svn-id: http://core.svn.wordpress.org/trunk@44442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 04:27:50 +00:00
dd9442ae6c
Posts: Set a HTTP 403 error when an incorrect post preview nonce is sent.
...
Props graymouser.
Fixes #43570 .
Built from https://develop.svn.wordpress.org/trunk@44610
git-svn-id: http://core.svn.wordpress.org/trunk@44441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 03:54:50 +00:00
6f723ddf50
Docs: Add documentation for the `wp_maybe_auto_update` action.
...
Props MikeGillihan.
Fixes #43301 .
Built from https://develop.svn.wordpress.org/trunk@44609
git-svn-id: http://core.svn.wordpress.org/trunk@44440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 03:38:49 +00:00
f2d2126d0d
Admin Bar: Set the Admin Bar to not be showing on REST API requests.
...
Props ayeshrajans.
Fixes #45727 .
Built from https://develop.svn.wordpress.org/trunk@44608
git-svn-id: http://core.svn.wordpress.org/trunk@44439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 02:54:50 +00:00
4bb472ac32
Docs: Add missing documentation for `_WP_Dependency::set_translations()`.
...
Introduced in [43859].
Props stazdotio.
Fixes #45550 .
Built from https://develop.svn.wordpress.org/trunk@44607
git-svn-id: http://core.svn.wordpress.org/trunk@44438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 22:48:51 +00:00
50ddffbac3
Privacy: Use consistent variable naming when working with privacy requests.
...
Throughout the core privacy functions, `WP_User_Request` instances were stored in variables named both `$request`, and `$request_data`. This changes all occurrences of `$request_data` to `$request` for better consistency.
Props nateallen, bruceallen, garrett-eclipse.
Fixes #44708 .
Built from https://develop.svn.wordpress.org/trunk@44606
git-svn-id: http://core.svn.wordpress.org/trunk@44437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 22:35:52 +00:00
c062e39ac8
Docs: Tweak the docblock for `setup_userdata()`.
...
This is a followup to [44603]. The default value should be last, not somewhere in the middle.
Props swissspidy.
Fixes #44697 .
Built from https://develop.svn.wordpress.org/trunk@44605
git-svn-id: http://core.svn.wordpress.org/trunk@44436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 10:29:50 +00:00
f76f57e8ab
Admin: Use the correct CSS media query for the Help tab on small screens after [44588].
...
See #43221
Built from https://develop.svn.wordpress.org/trunk@44604
git-svn-id: http://core.svn.wordpress.org/trunk@44435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 07:48:50 +00:00
e0c4e5b610
Users: Correct the default value in `setup_userdata()`.
...
The `$for_user_id` parameter is an `int`, not a `string`, so the default value should be `0`, rather than an empty string.
Props subrataemfluence.
Fixes #44697 .
Built from https://develop.svn.wordpress.org/trunk@44603
git-svn-id: http://core.svn.wordpress.org/trunk@44434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 06:33:50 +00:00
8ddef3e98d
Users: Check that a valid user is passed to `get_password_reset_key()`.
...
Props edocev.
Fixes #44601 .
Built from https://develop.svn.wordpress.org/trunk@44602
git-svn-id: http://core.svn.wordpress.org/trunk@44433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 06:27:49 +00:00
a5d8a6bde3
Docs: Fix the `WP_Object_Cache::get()` docblock.
...
The `$force` parameter is a `bool`, not a `string`. The matching `wp_cache_get()` docblock has the correct type.
Props subrataemfluence.
Fixes #44454 .
Built from https://develop.svn.wordpress.org/trunk@44601
git-svn-id: http://core.svn.wordpress.org/trunk@44432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 06:18:51 +00:00
656d8edcaf
Docs: Add docblocks for `WP_Customize_Header_Image_Control` member variables.
...
Props subrataemfluence.
Fixes #44410 .
Built from https://develop.svn.wordpress.org/trunk@44600
git-svn-id: http://core.svn.wordpress.org/trunk@44431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:54:48 +00:00
e4b25f1be2
Build Tools: Don't send AppVeyor notifications on Slack on repeated successful builds.
...
See #44276 .
Built from https://develop.svn.wordpress.org/trunk@44599
git-svn-id: http://core.svn.wordpress.org/trunk@44430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:49:49 +00:00
883ee72ed6
Coding Standards: Move an assignment out of a condition in `wp-admin/admin.php`.
...
Props subrataemfluence, jrf, pento.
Fixes #44363 .
Built from https://develop.svn.wordpress.org/trunk@44598
git-svn-id: http://core.svn.wordpress.org/trunk@44429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:48:50 +00:00
120710d8f8
Coding Standards: Move assignments out of conditions in `wp-includes/user.php`.
...
Props subrataemfluence.
See #44315 .
Built from https://develop.svn.wordpress.org/trunk@44597
git-svn-id: http://core.svn.wordpress.org/trunk@44428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:38:49 +00:00
db696999f1
Updates: Tweak the "before updating, please back up..." message.
...
Props chetan200891, sebastien@thivinfo.com .
See #43790 .
Built from https://develop.svn.wordpress.org/trunk@44596
git-svn-id: http://core.svn.wordpress.org/trunk@44427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:20:50 +00:00
4de7979b25
Build Tools: Tweak AppVeyor settings.
...
- Set `grunt build` as the build script
- Disable testing and deployment options
- Customise the Slack integration message
- Only show the Slack message when the status changes
See #44276 .
Built from https://develop.svn.wordpress.org/trunk@44595
git-svn-id: http://core.svn.wordpress.org/trunk@44426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 04:51:52 +00:00
c009a1960a
Build Tools: Add AppVeyor integration.
...
AppVeyor allows us to test in a Windows environment. This first iteration tests that building works correctly.
Props netweb.
Fixes #44276 .
Built from https://develop.svn.wordpress.org/trunk@44594
git-svn-id: http://core.svn.wordpress.org/trunk@44425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 04:21:50 +00:00
59fbee8544
Coding Standards: Assignments must be the first block of code on a line.
...
Props subrataemfluence.
Fixes #44225 .
Built from https://develop.svn.wordpress.org/trunk@44593
git-svn-id: http://core.svn.wordpress.org/trunk@44424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 02:41:50 +00:00
34c4ce3c81
Docs: Update inaccurate `return` descriptions.
...
In the `@return` tag description for `get_post_modified_time()`, `get_the_time()`, and `get_post_time()`, the `$d` parameter is incorrectly referred to as `$id`.
Props behzod.
Fixes #45323 .
Built from https://develop.svn.wordpress.org/trunk@44592
git-svn-id: http://core.svn.wordpress.org/trunk@44423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 02:08:49 +00:00
bf43978730
Link Template: In `get_adjacent_post()`, move the sanitisation of `$excluded_terms` earlier.
...
This is a followup to [42828], ensuring that the `get_{$adjacent}_post_excluded_terms` filter is always passed an array, as expected.
Props soulseekah, zottto.
Fixes #43521 .
Built from https://develop.svn.wordpress.org/trunk@44591
git-svn-id: http://core.svn.wordpress.org/trunk@44422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 01:54:49 +00:00
6073c6e209
Docs: Update the `@since` version for the `doing_it_wrong_trigger_error` filter.
...
Fixes #34183 .
Built from https://develop.svn.wordpress.org/trunk@44590
git-svn-id: http://core.svn.wordpress.org/trunk@44421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:52:50 +00:00
2f288c306c
Widgets: Remove unnecessary `sanitize_text_field()` calls in core widget `::form()` methods.
...
This sanitisation only needs to be run in `::update()` to correctly clean up the input.
Props welcher, greenshady.
Fixes #42461 .
Built from https://develop.svn.wordpress.org/trunk@44589
git-svn-id: http://core.svn.wordpress.org/trunk@44420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:43:49 +00:00
11e9c98d5b
Admin: Make the Help tab available on small screens.
...
Props jobthomas, xkon.
Fixes #43221 .
Built from https://develop.svn.wordpress.org/trunk@44588
git-svn-id: http://core.svn.wordpress.org/trunk@44419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:20:50 +00:00
d2695fe283
Query: Cache the result when `get_pages()` doesn't find anything in the database.
...
Props flixos90, soulseekah.
Fixes #43514 .
Built from https://develop.svn.wordpress.org/trunk@44587
git-svn-id: http://core.svn.wordpress.org/trunk@44418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 23:27:50 +00:00
56e77d8928
Docs: Improve the docblock of `wp_admin_bar_edit_menu()`.
...
What age were you when you learned that there's a `$user_id` global, as well as `$user_ID` global? I was today years old.
Props pento, mukesh27.
Fixes #43448 .
Built from https://develop.svn.wordpress.org/trunk@44586
git-svn-id: http://core.svn.wordpress.org/trunk@44417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 23:12:50 +00:00
767fb99e94
Docs: Improve documentation of the ``$wp_registered_sidebars` global.
...
Props mukesh27.
Fixes #43448 .
Built from https://develop.svn.wordpress.org/trunk@44585
git-svn-id: http://core.svn.wordpress.org/trunk@44416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 23:01:49 +00:00
a7d0293446
Tests: Add missing `parent::tearDown()`.
...
Also, remove a `tearDown()` method that was not serving any purpose.
Fixes #45931 .
Built from https://develop.svn.wordpress.org/trunk@44584
git-svn-id: http://core.svn.wordpress.org/trunk@44415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 21:34:55 +00:00
51f4314441
Customizer: Use the `sandbox` attribute to prevent top navigation from the preview.
...
Props valchovski.
Fixes #42341 .
Built from https://develop.svn.wordpress.org/trunk@44583
git-svn-id: http://core.svn.wordpress.org/trunk@44414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 07:25:50 +00:00
b083cc65aa
Customizer: Fix a coding standards issue introduced in [44580].
...
See #40020 .
Built from https://develop.svn.wordpress.org/trunk@44582
git-svn-id: http://core.svn.wordpress.org/trunk@44413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 07:23:50 +00:00
0390ddad6b
Docs: Improve docblocks for `_get_plugin_data_markup_translate()` and `_sort_uname_callback()`.
...
Props Jaydeep Rami.
Fixes #42228 .
Built from https://develop.svn.wordpress.org/trunk@44581
git-svn-id: http://core.svn.wordpress.org/trunk@44412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 06:54:49 +00:00
d8f4a04232
Customizer: Improve browser compatibility of the preview iframe.
...
When `home` and `siteurl` are different, the customizer preview iframe will be blank in Chrome and Safari, due to their `X-Frame-Options` implementation quirks.
Changing this to `SAMEORIGIN` and adding the `frame-ancestors` Content Security Policy gives the correct behaviour.
Props fullyint.
Fixes #40020 .
Built from https://develop.svn.wordpress.org/trunk@44580
git-svn-id: http://core.svn.wordpress.org/trunk@44411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 06:38:51 +00:00
10c66fb426
Formatting: Remove soft hyphens when sanitising titles.
...
Props andg.
Fixes #45378 .
Built from https://develop.svn.wordpress.org/trunk@44579
git-svn-id: http://core.svn.wordpress.org/trunk@44410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 05:39:51 +00:00
fcd66d09d9
Widgets: Don't log invalid HTML in the Text Widget.
...
[41215] supresses these irrelevant error messages from the front end, this removes them from the error log, too.
Props jeherve.
Fixes #43815 .
Built from https://develop.svn.wordpress.org/trunk@44578
git-svn-id: http://core.svn.wordpress.org/trunk@44409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 05:05:48 +00:00
5ed789dc63
Tests: Add missing `parent::setUp()` calls to all test classes.
...
Props johnbillion, birgire.
Fixes #37375 .
Built from https://develop.svn.wordpress.org/trunk@44577
git-svn-id: http://core.svn.wordpress.org/trunk@44408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 04:54:50 +00:00
0bbfe3b8e2
Blocks: Add a `$source_block` parameter to the `render_block_data` filter.
...
This contains a copy of the block, unmodified by other filter functions, so that plugins have a clean reference to work from, if they need.
Props dmsnell.
Fixes #45451 .
Built from https://develop.svn.wordpress.org/trunk@44576
git-svn-id: http://core.svn.wordpress.org/trunk@44407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 01:47:51 +00:00
1c59f76953
Accessibility: Exclude the Windows High Contrast mode transparent outline from the CSS transition after [44544].
...
See #41286 .
Built from https://develop.svn.wordpress.org/trunk@44575
git-svn-id: http://core.svn.wordpress.org/trunk@44406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 15:01:49 +00:00
7a617078fa
Coding Standards: Upgrade WPCS to 1.2.1.
...
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.
Fixes #45956 .
Built from https://develop.svn.wordpress.org/trunk@44574
git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
8656a65e1e
Coding Standards: Fix and whitelist variable names.
...
From the `WordPress.NamingConventions.ValidVariableName` sniff, this commit fixes/whitelists all `NotSnakeCaseMemberVar`, `MemberNotSnakeCase`, and `StringNotSnakeCase` violations. It also fixes a handful of the `NotSnakeCase` violations.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44573
git-svn-id: http://core.svn.wordpress.org/trunk@44404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:06:48 +00:00
3a697f7f46
Coding Standards: Remove an unnecessary line whitelisting.
...
Props jrf.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44572
git-svn-id: http://core.svn.wordpress.org/trunk@44403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 04:53:51 +00:00
f72594974f
Coding Standards: Exclude some external files.
...
- `class-wp-block-parser.php` and `wp-includes/blocks/*` are imported from the Gutenberg plugin.
- `speed-trap-listener.php` is a third party library.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44571
git-svn-id: http://core.svn.wordpress.org/trunk@44402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 04:01:50 +00:00
57fcb7d8dd
Coding Standards: Fix an incorrect `phpcs:ignore` comment.
...
It's `phpcs:ignore`, not `wpcs:ignore`.
Props GaryJ.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44570
git-svn-id: http://core.svn.wordpress.org/trunk@44401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 03:49:49 +00:00
08e8270a48
Coding Standards: Extract `extract()` from the codebase.
...
Of the last four instances of `extract()` occurring, three of them are removed by this commit, and the fourth is appropriately documented.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44569
git-svn-id: http://core.svn.wordpress.org/trunk@44400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 03:20:48 +00:00
2785313bf2
REST API: Encourage proper usage of `register_rest_route()`.
...
Calling `register_rest_route()` too early in the loading process has the potential to cause some unintentional problems and pitfalls. Because `register_rest_route()` calls `rest_get_server()` (which creates the `WP_REST_Server` instance), calling the function directly and/or before `rest_api_init` should be discouraged.
For example, if `register_rest_route ()` is called on `init`, the REST API server instance is set up (and all functions added to `rest_api_init` and other related hooks are invoked), even though the current request may not be a REST request. Also, if `register_rest_route()` is called even earlier (say, in an `mu-plugin` file), required endpoints may be missing since normal plugins have not yet been loaded and have not had a chance to register their own action hooks.
This adds a `_doing_it_wrong()` notice the first time `register_rest_route()` is called before `rest_api_init` in a request to encourage best practices for registering REST API routes.
Props kraftbj, desrosj, timothyblynjacobs.
Fixes #45265 .
Built from https://develop.svn.wordpress.org/trunk@44568
git-svn-id: http://core.svn.wordpress.org/trunk@44399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 18:19:49 +00:00
298ef1992e
Menus: Make menu items not jump while dragging items.
...
Props alexvorn2, welcher, afercia.
Fixes #41160 .
Built from https://develop.svn.wordpress.org/trunk@44567
git-svn-id: http://core.svn.wordpress.org/trunk@44398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 13:56:49 +00:00
Gary Pendergast
desrosj
Andrea Fercia