Commit Graph

116 Commits

Author SHA1 Message Date
Scott Taylor d569b9609e Media: show Trash filter for Media list table when `MEDIA_TRASH` is true.
Props chacha102.
Fixes #34795.

Built from https://develop.svn.wordpress.org/trunk@35752


git-svn-id: http://core.svn.wordpress.org/trunk@35716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:48:25 +00:00
Drew Jaynes 8a386cb24f Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35241


git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 15:13:25 +00:00
Sergey Biryukov dcf23c5e2a In `WP_Media_List_Table`, rename `$pending_count` to `$comment_pending_count` and mark it as protected, for consistency with `WP_Posts_List_Table`.
See #11381.
Built from https://develop.svn.wordpress.org/trunk@35222


git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:23:27 +00:00
Scott Taylor 0c2b2a0e3d List Tables/WP_Screen: in `WP_Screen`, add methods to store, retrieve, and render screen reader text, primarily used by list table screens.
These additions are based on an audit and recommendations by the Accessibility team. #a11y'all

Props afercia.
Fixes #32147.

Built from https://develop.svn.wordpress.org/trunk@34891


git-svn-id: http://core.svn.wordpress.org/trunk@34856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:28:25 +00:00
Dominik Schilling fcc36d1adf Media List Table: Remove the date display in `column_parent()`.
It should be the time at which the post was written, but it was never because of the missing `$parent` argument.

Fixes #33238.
Built from https://develop.svn.wordpress.org/trunk@34839


git-svn-id: http://core.svn.wordpress.org/trunk@34804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 22:25:26 +00:00
Scott Taylor 939d9b7395 Remove some unused globals and/or their docs.
See ##33491.

Built from https://develop.svn.wordpress.org/trunk@34446


git-svn-id: http://core.svn.wordpress.org/trunk@34410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:27:25 +00:00
Scott Taylor f9c2a88a8a List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
Props wonderboymusic, Viper007Bond.
Fixes #21249.

Built from https://develop.svn.wordpress.org/trunk@34383


git-svn-id: http://core.svn.wordpress.org/trunk@34347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 06:06:25 +00:00
Scott Taylor 58ac764859 Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.

Built from https://develop.svn.wordpress.org/trunk@34256


git-svn-id: http://core.svn.wordpress.org/trunk@34220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 02:30:26 +00:00
Scott Taylor 191400f9e6 Don't ever use the `guid` value when retrieving URLs for media, use `wp_get_attachment_url()`. Use `get_attached_file()` for path to file.
Fixes #33386.

Built from https://develop.svn.wordpress.org/trunk@34163


git-svn-id: http://core.svn.wordpress.org/trunk@34131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 02:50:25 +00:00
Scott Taylor 4d33644373 In `WP_Media_List_Table`, fetch all pending comment counts at once, instead of for each row in the loop.
See #11381.

Built from https://develop.svn.wordpress.org/trunk@34127


git-svn-id: http://core.svn.wordpress.org/trunk@34095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 19:25:25 +00:00
Scott Taylor db11b48627 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
Props pavelevap.
Fixes #33515.

Built from https://develop.svn.wordpress.org/trunk@33810


git-svn-id: http://core.svn.wordpress.org/trunk@33778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:10:21 +00:00
Scott Taylor 3923017f82 The `'restrict_manage_posts'` hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass `$post_type`.
Props sunnyratilal, scribu.
Fixes #17891.

Built from https://develop.svn.wordpress.org/trunk@33644


git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 06:23:25 +00:00
Scott Taylor 4d34e37311 List Tables:
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

Built from https://develop.svn.wordpress.org/trunk@33270


git-svn-id: http://core.svn.wordpress.org/trunk@33242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:47:24 +00:00
Konstantin Obenland 4f94d3a969 Media: Don't indent action links if there is no media icon.
See #32254.


Built from https://develop.svn.wordpress.org/trunk@33269


git-svn-id: http://core.svn.wordpress.org/trunk@33241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:46:24 +00:00
Konstantin Obenland 2a0ddf8523 Media: Reduce link noise between icons and titles in list view.
Props afercia.
Fixes #32254.


Built from https://develop.svn.wordpress.org/trunk@33268


git-svn-id: http://core.svn.wordpress.org/trunk@33240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 17:24:26 +00:00
Drew Jaynes 967b04a7f8 Add missing summaries and `@access` tags to methods added to `WP_Media_List_Table` in 4.3.
See [32754]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33179


git-svn-id: http://core.svn.wordpress.org/trunk@33151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 18:34:24 +00:00
Helen Hou-Sandí 83e33a2ca0 List tables: Bring screen reader text for comments column title to media.
see #32152, [31513].

Built from https://develop.svn.wordpress.org/trunk@32991


git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:44:25 +00:00
John Blackbourn b5973e92ec Introduce a `no_terms` label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
Fixes #32150
Props afercia

Built from https://develop.svn.wordpress.org/trunk@32933


git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 00:16:27 +00:00
Helen Hou-Sandí d159cc2272 Media list table: Avoid PHP notices by using the proper variables.
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 21:33:25 +00:00
Scott Taylor 5c6b63d3a6 `if` is a statment, not a function.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
Helen Hou-Sandí a49c192f37 Media list table: Restore row actions.
see #29881, #32657.

Built from https://develop.svn.wordpress.org/trunk@32798


git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:47:24 +00:00
Scott Taylor ba8cfcab71 In `WP_Media_List_Table::display_rows()`:
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32754


git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:57:27 +00:00
Scott Taylor 4835310a18 In `WP_Media_List_Table::display_rows()`, `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32737


git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:45:25 +00:00
Konstantin Obenland cb39d03501 Improve non-visual feedback for list table items without terms.
Props karpstrucking, afercia.
Fixes #32150.


Built from https://develop.svn.wordpress.org/trunk@32725


git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-11 09:28:31 +00:00
Helen Hou-Sandí c87224eaf6 List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
Helen Hou-Sandí 6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:23:25 +00:00
Helen Hou-Sandí 40fca44c89 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:13:25 +00:00
Drew Jaynes 42afe1d373 Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Media_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32663


git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:32:26 +00:00
Scott Taylor 6a08b00632 Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Helen Hou-Sandí 4c0c7fd7ba List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:41:25 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor a69b8b3b91 In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32517


git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:50:27 +00:00
Sergey Biryukov 5fae37471a Media Library: Add a label for attachment type select in list mode.
props afercia.
fixes #31795.
Built from https://develop.svn.wordpress.org/trunk@31942


git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 19:57:26 +00:00
Helen Hou-Sandí bc54176af0 Media: Show filename instead of extension in the list table.
This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore.

fixes #30943.

Built from https://develop.svn.wordpress.org/trunk@31857


git-svn-id: http://core.svn.wordpress.org/trunk@31836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-22 11:02:29 +00:00
Scott Taylor d3471e9850 Allow attachments to be Detached from their parent in media grid and list modes.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31619


git-svn-id: http://core.svn.wordpress.org/trunk@31600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 05:35:28 +00:00
Scott Taylor 02a1f35ac8 Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31220


git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:51:21 +00:00
Helen Hou-Sandí 62a197d6bf List tables: Use CSS :nth-child() selectors for zebra striping.
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

Built from https://develop.svn.wordpress.org/trunk@31181


git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 22:14:22 +00:00
Scott Taylor 86c0f63739 Add 2 `private` fields to `WP_Media_List_Table`, `$detached` and `$is_trash`.
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31162


git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:08:21 +00:00
Scott Taylor e4b6265c7a Overriding methods should do more than simply call the same method in the super class.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31101


git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:20:22 +00:00
Scott Taylor f79eb196df Improve the handling of comma-separated mime-types in `wp_match_mime_types()`, particularly as pertains to the mime-type selector on the Media list table screen.
Props mdgl.
Fixes #30788.

Built from https://develop.svn.wordpress.org/trunk@31042


git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:32:22 +00:00
Andrew Ozz 0aa0016488 Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658.
Built from https://develop.svn.wordpress.org/trunk@30813


git-svn-id: http://core.svn.wordpress.org/trunk@30803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-11 04:12:23 +00:00
John Blackbourn bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference.
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Scott Taylor 65ab522a51 Improve various `@param` docs for List Tables.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30679


git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 00:33:23 +00:00
Scott Taylor 562ddb8316 Use `sanitize_mime_type()` instead of `urlencode()` when string-building `<option>` values in `->get_views()` for media list tables.
`urlencode()` was introduced in [28553] via _duck and yours truly.

Got weirder after [29625].

Props birgire.
Fixes #30123.

Built from https://develop.svn.wordpress.org/trunk@30661


git-svn-id: http://core.svn.wordpress.org/trunk@30651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 20:23:23 +00:00
Scott Taylor 0b9c1be743 In `WP_List_Table`, add a property, `$modes`, to allow `WP_Media_List_Table` to inherit `->view_switcher()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30154


git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:56:24 +00:00
Scott Taylor cf31ee092b Media List Table: account for `MEDIA_TRASH` in the bulk action dropdown.
See #29742.

Built from https://develop.svn.wordpress.org/trunk@29810


git-svn-id: http://core.svn.wordpress.org/trunk@29576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 03:12:18 +00:00
Andrew Nacin 8a9186b878 Media Library: Fix media trash handling.
props ocean90, obenland.
fixes #29469.

Built from https://develop.svn.wordpress.org/trunk@29690


git-svn-id: http://core.svn.wordpress.org/trunk@29465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 06:47:16 +00:00
Helen Hou-Sandí 6926e9aea6 Media: Translate a string for the search placeholder.
props alex-ye.
fixes #29448.

Built from https://develop.svn.wordpress.org/trunk@29659


git-svn-id: http://core.svn.wordpress.org/trunk@29433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-01 19:54:16 +00:00
Helen Hou-Sandí 42afb446db Media: `views_upload` filter expects an array, not a string.
see #28946.

Built from https://develop.svn.wordpress.org/trunk@29641


git-svn-id: http://core.svn.wordpress.org/trunk@29415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 03:06:27 +00:00