Commit Graph

16 Commits

Author SHA1 Message Date
Sergey Biryukov 7932193708 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov 38676936ba Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov 37f04694d5 Bundled Themes: Use consistent HTML comments after closing HTML tags.
Props iamdmitrymayorov.
Fixes #46871.
Built from https://develop.svn.wordpress.org/trunk@45209


git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 01:30:53 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Lance Willett 63c82dd11d Twenty Fourteen: remove invalid `rel` attributes from post thumbnail output, and fix a CSS typo. See #25946 and #25325.
Built from https://develop.svn.wordpress.org/trunk@26694


git-svn-id: http://core.svn.wordpress.org/trunk@26584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:09:10 +00:00
Lance Willett e46662b6ae Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26556


git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:06:11 +00:00
Lance Willett 9e201fadff Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093.
Built from https://develop.svn.wordpress.org/trunk@26260


git-svn-id: http://core.svn.wordpress.org/trunk@26166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 23:11:10 +00:00
Lance Willett c8cfe17a02 Twenty Fourteen: simplify and prefix post thumbnail sizes, props obenland. See #25946.
Built from https://develop.svn.wordpress.org/trunk@26152


git-svn-id: http://core.svn.wordpress.org/trunk@26063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 04:50:11 +00:00
Lance Willett 1b98c32e7a Twenty Fourteen: performance win by reducing the number of post thumbnail sizes needed in the theme. Props iamtakashi, closes #25876.
Built from https://develop.svn.wordpress.org/trunk@26047


git-svn-id: http://core.svn.wordpress.org/trunk@25972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 05:31:09 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Lance Willett 83f5f48dea Twenty Fourteen: remove excerpts from featured posts, and display full titles instead. Props iamtakashi, closes #25581.
Built from https://develop.svn.wordpress.org/trunk@25804


git-svn-id: http://core.svn.wordpress.org/trunk@25716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 03:47:09 +00:00
Lance Willett eaf78d3f7c Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257.
Built from https://develop.svn.wordpress.org/trunk@25769


git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 22:02:11 +00:00
Lance Willett 66be5edfb5 Twenty Fourteen: remove title attributes for better accessibility. Props sabreuse for original patch, see #25054.
Built from https://develop.svn.wordpress.org/trunk@25743


git-svn-id: http://core.svn.wordpress.org/trunk@25656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:09 +00:00
Lance Willett e5c55b09e9 Twenty Fourteen: first pass at matching code standards achieved with Twenty Thirteen development. See #24858, props obenland.
Built from https://develop.svn.wordpress.org/trunk@25021


git-svn-id: http://core.svn.wordpress.org/trunk@25012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:29 +00:00
Lance Willett 7d35419e62 Importing the Further theme, first pass at the new default theme for 2014.
A magazine theme with clean, responsive design focused on highlighting featured content prominently on home page.

This is slated for 3.8. Development will occur in trunk for the theme, and in plugins for the nice-to-have features.

Nice-to-have improvements include:

- Add a Contributors page template to highlight authors.
- Easy-to-manage featured content.
- Add support for an Authors widget to highlight authors.

Welcome, Twenty Fourteen né Further. Props iamtakashi, see #24858.


git-svn-id: http://core.svn.wordpress.org/trunk@24832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:55:10 +00:00