WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
40,683 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

14362 Commits

Author SHA1 Message Date
Sergey Biryukov 409a89668a Upgrade/Install: Improve the appearance of language selection on install: 
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Merges [46887] to the 5.3 branch.
Fixes #48927.
Built from https://develop.svn.wordpress.org/branches/5.3@46888


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 23:05:02 +00:00
Sergey Biryukov c7d610fb02 Comments: Avoid a PHP notice in `comment_form()` if the `email` field is not set. 
Follow-up to [46090].

Props mat-lipe.
Merges [46885] to the 5.3 branch.
Fixes #48943.
Built from https://develop.svn.wordpress.org/branches/5.3@46886


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 22:16:03 +00:00
Andrew Ozz 9e38fc8259 Fixes in `admin-bar.js`: 
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Merges [46883] to the 5.3 branch.
Fixes #47069.


Built from https://develop.svn.wordpress.org/branches/5.3@46884


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 20:23:05 +00:00
Sergey Biryukov e4cf151207 Post WordPress 5.3.1 RC1 version bump 
Built from https://develop.svn.wordpress.org/branches/5.3@46877


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 02:12:03 +00:00
Sergey Biryukov 17570cfbd8 WordPress 5.3.1 RC1 
Built from https://develop.svn.wordpress.org/branches/5.3@46876


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:56:04 +00:00
Sergey Biryukov 6e0e255964 Coding Standards: Fix WPCS and JSHint issues in [46872]. 
Merges [46874] to the 5.3 branch.
See #47069.
Built from https://develop.svn.wordpress.org/branches/5.3@46875


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:38:02 +00:00
Andrew Ozz d73f11a4ce Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package. 
Props dinhtungdu, audrasjb, azaozz.
Merges [46872] to the 5.3 branch.
Fixes #47069.
Built from https://develop.svn.wordpress.org/branches/5.3@46873


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:08:03 +00:00
Sergey Biryukov f5d738e01c Block Editor: Resolve `@wordpress/block-directory` to the expected version, 1.0.6. 
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Merges [46870] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46871


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 22:31:05 +00:00
Sergey Biryukov 3487611129 Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters. 
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Merges [46868] to the 5.3 branch.
Fixes #48599.
Built from https://develop.svn.wordpress.org/branches/5.3@46869


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 21:06:03 +00:00
Sergey Biryukov ecdd9d8390 Administration: Standardize form control height and alignment across the admin. 
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Merges [46866] to the 5.3 branch.
Fixes #48420.
Built from https://develop.svn.wordpress.org/branches/5.3@46867


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 20:28:04 +00:00
Sergey Biryukov 1cdaf142f2 Date/Time: XML-RPC: Сalculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set. 
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Merges [46864] to the 5.3 branch.
Fixes #30429.
Built from https://develop.svn.wordpress.org/branches/5.3@46865


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 20:08:06 +00:00
Sergey Biryukov e5f1a70a87 Date/Time: When determining whether to decline the month name in `wp_maybe_decline_date()`, take word boundaries into account. 
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Merges [46862] to the 5.3 branch.
Fixes #48606.
Built from https://develop.svn.wordpress.org/branches/5.3@46863


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 19:02:04 +00:00
Sergey Biryukov 44bff0da78 Block Editor: Bug fixes targeted for WordPress 5.3.1. 
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46861


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 17:42:10 +00:00
Sergey Biryukov 01bd5c0eed Upgrade/Install: Update sodium_compat to v1.12.1. 
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Merges [46858] to the 5.3 branch.
Fixes #48371.
Built from https://develop.svn.wordpress.org/branches/5.3@46859


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:46:03 +00:00
Sergey Biryukov d01a9c3c46 Media: Use consistent width for Scale and Crop inputs. 
Follow-up to [46359].

Props sabernhardt, audrasjb.
Merges [46856] to the 5.3 branch.
Fixes #48907.
Built from https://develop.svn.wordpress.org/branches/5.3@46857


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:25:04 +00:00
Sergey Biryukov e3c254bf75 Bundled Themes: Misaligned input placeholder text Twenty Twenty. 
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal, ianbelanger.
Merges [46851], [46854] to the 5.3 branch.
Fixes #48876.
Built from https://develop.svn.wordpress.org/branches/5.3@46855


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:20:03 +00:00
Sergey Biryukov ba1ec74fdc Help/About: Add a hover effect for links on About pages. 
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Merges [46852] to the 5.3 branch.
Fixes #48582.
Built from https://develop.svn.wordpress.org/branches/5.3@46853


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:33:03 +00:00
Sergey Biryukov a590a590a3 Twenty Twenty: Remove redundant `echo` for `bloginfo()` call in `footer.php`. 
Props acosmin.
Merges [46849] to the 5.3 branch.
Fixes #48918.
Built from https://develop.svn.wordpress.org/branches/5.3@46850


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:02:04 +00:00
Sergey Biryukov 06ebac2233 Twenty Twenty: Adds Customizer option to show or hide author bio. 
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange, acosmin, dlh, ianbelanger.
Merges [46813] to the 5.3 branch.
Fixes #48550.
Built from https://develop.svn.wordpress.org/branches/5.3@46848


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:41:04 +00:00
Sergey Biryukov 7e5d62f195 Twenty Twenty: Make checkbox in comment form larger. 
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb, ianbelanger.
Merges [46844] to the 5.3 branch.
Fixes #48652.
Built from https://develop.svn.wordpress.org/branches/5.3@46847


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:32:03 +00:00
Sergey Biryukov 05b9f27d11 Administration: Correct checkbox width in list tables on smaller screens. 
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Merges [46845] to the 5.3 branch.
Fixes #48815.
Built from https://develop.svn.wordpress.org/branches/5.3@46846


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:30:02 +00:00
Sergey Biryukov 9870e114af Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. 
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Merges [46842] to the 5.3 branch.
Fixes #48409.
Built from https://develop.svn.wordpress.org/branches/5.3@46843


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:51:02 +00:00
Sergey Biryukov ad8e49e8dd Twenty Twenty: Correct alignment for embedded Instagram posts. 
Props SGr33n, audrasjb, nielslange, JarretC.
Merges [46840] to the 5.3 branch.
Fixes #48688.
Built from https://develop.svn.wordpress.org/branches/5.3@46841


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:41:00 +00:00
Sergey Biryukov 97b8443321 Users: Introduce `admin_email_remind_interval` filter for dismissing the admin email confirmation screen. 
Props desrosj, birgire.
Merges [46838], [46837] to the 5.3 branch.
Fixes #48334.
Built from https://develop.svn.wordpress.org/branches/5.3@46839


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:30:03 +00:00
Sergey Biryukov 176a6206a3 Upload: fix `wp_unique_filename()` to prevent name collisions with existing or future image sub-size file names, and add unit tests. 
Props Viper007Bond, pbiron, azaozz.
Merges [46822], [46835] to the 5.3 branch.
Fixes #42437.
Built from https://develop.svn.wordpress.org/branches/5.3@46836


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 12:21:03 +00:00
Sergey Biryukov d6875bc495 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. 
Props azaozz.
Merges [46809] to the 5.3 branch.
Fixes #48736.
Built from https://develop.svn.wordpress.org/branches/5.3@46834


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 12:04:02 +00:00
Sergey Biryukov 33da7d7e7f Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context. 
Props msaari, SergeyBiryukov.
Merges [46832] to the 5.3 branch.
Fixes #48906.
Built from https://develop.svn.wordpress.org/branches/5.3@46833


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:51:05 +00:00
Sergey Biryukov bd3bd0c6ff Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property. 
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Merges [46824] to the 5.3 branch.
Fixes #48763, #48551, #48866.
Built from https://develop.svn.wordpress.org/branches/5.3@46825


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 11:08:01 +00:00
Sergey Biryukov 4c4662e95c Accessibility: Administration: Correct active button color for the alternative color schemes. 
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Merges [46817] to the 5.3 branch.
Fixes #48598.
Built from https://develop.svn.wordpress.org/branches/5.3@46818


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 22:14:04 +00:00
Sergey Biryukov 6cd7126ff2 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes. 
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Merges [46815] to the 5.3 branch.
Fixes #48585.
Built from https://develop.svn.wordpress.org/branches/5.3@46816


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 21:34:05 +00:00
Sergey Biryukov b7f33680dc Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Merges [46797] to the 5.3 branch.
Fixes #48692.
Built from https://develop.svn.wordpress.org/branches/5.3@46798


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 15:57:05 +00:00
Sergey Biryukov 9156181d27 Date/Time: Make `get_permalink()` more resilient against PHP timezone changes. 
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Merges [46795] to the 5.3 branch.
Fixes #48623.
Built from https://develop.svn.wordpress.org/branches/5.3@46796


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 13:57:02 +00:00
Sergey Biryukov 2fed57f1b0 KSES: Add support for gradient backgrounds. 
Props jorgefilipecosta.
Merges [46793] to the 5.3 branch.
Fixes #48376.
Built from https://develop.svn.wordpress.org/branches/5.3@46794


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 00:31:02 +00:00
Sergey Biryukov b06ee36d81 Users: Display admin email verification screen in user's locale instead of site locale. 
Props sathyapulse, TimothyBlynJacobs.
Merges [46788] to the 5.3 branch.
Fixes #48313.
Built from https://develop.svn.wordpress.org/branches/5.3@46789


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 14:40:00 +00:00
desrosj 6f3a28818e Bundled Themes: Fixes JS TypeError in Twenty Twenty. 
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx, ianbelanger.
Fixes #48601.
Built from https://develop.svn.wordpress.org/branches/5.3@46787


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 18:43:04 +00:00
Sergey Biryukov d6c12ac919 Users: Use correct variable when displaying the Additional Capabilities list in user profile. 
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Merges [46782] to the 5.3 branch.
Fixes #48725.
Built from https://develop.svn.wordpress.org/branches/5.3@46783


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 14:03:02 +00:00
Sergey Biryukov fd1e68a6a4 Widgets: Avoid to move focus to the Image Widget "Insert from URL" field. 
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven, afercia.
Merges [46745] to the 5.3 branch.
See #43169.
Fixes #48588.
Built from https://develop.svn.wordpress.org/branches/5.3@46781


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 13:51:03 +00:00
Sergey Biryukov 50f419f0a8 Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes. 
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.

This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.

Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
Merges [46753] and [46779] to the 5.3 branch.
Fixes #31245.
Built from https://develop.svn.wordpress.org/branches/5.3@46780


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 13:46:12 +00:00
Sergey Biryukov c54903a12e Accessibility: Media: Add an `aria-pressed` attribute to active button within a button group. 
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".

Props afercia.
Merges [46748] to the 5.3 branch.
Fixes #48355.
Built from https://develop.svn.wordpress.org/branches/5.3@46778


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 11:20:02 +00:00
Sergey Biryukov 159068b2a0 Accessibility: Add an `aria-current` attribute to the Media Library switch links. 
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Merges [46746] to the 5.3 branch.
Fixes #48271.
Built from https://develop.svn.wordpress.org/branches/5.3@46777


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:23:03 +00:00
Sergey Biryukov ff1db3c4a9 Docs: Fix typo in `wp_credits_section_title()` description. 
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Merges [46738] to the 5.3 branch.
Fixes #48674.
Built from https://develop.svn.wordpress.org/branches/5.3@46776


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:20:03 +00:00
Sergey Biryukov 4baea39a4d Editor: Improve the appearance of tag cloud in Tags meta box in classic editor. 
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Merges [46758] to the 5.3 branch.
Fixes #48592.
Built from https://develop.svn.wordpress.org/branches/5.3@46775


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:14:04 +00:00
Sergey Biryukov abbe0c7912 Date/Time: Remove `mysql2date()` usage in `get_feed_build_date()` to ensure the output includes correct timezone offset. 
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Merges [46756] and [46757] to the 5.3 branch.
Fixes #48675.
Built from https://develop.svn.wordpress.org/branches/5.3@46774


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:12:01 +00:00
Sergey Biryukov 35e045286d Media: Avoid a PHP notice in `image_downsize()` when trying to replace a non-image URL with a rendered image from its meta. 
Props Mte90, jrf, hareesh-pillai.
Merges [46772] to the 5.3 branch.
Fixes #48324.
Built from https://develop.svn.wordpress.org/branches/5.3@46773


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 10:09:01 +00:00
Sergey Biryukov 0a417c0dc9 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Merges [46770] to the 5.3 branch.
Fixes #48406.
Built from https://develop.svn.wordpress.org/branches/5.3@46771


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 20:00:04 +00:00
Sergey Biryukov 7df949e31e Twenty Twenty: Fix typos in a variable name and inline comment in assets/js/color-calculations.js. 
Props tanvirul.
Merges [46747] to the 5.3 branch.
Fixes #48704.
Built from https://develop.svn.wordpress.org/branches/5.3@46769


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 11:05:02 +00:00
Sergey Biryukov 27e67093f7 Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore. 
Props audrasjb, youknowriad.
Merges [46761] to the 5.3 branch.
Fixes #48696.
Built from https://develop.svn.wordpress.org/branches/5.3@46768


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 11:03:02 +00:00
Sergey Biryukov e5296ce359 Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile. 
Props nielslange, Anlino.
Merges [46762] to the 5.3 branch.
Fixes #48619.
Built from https://develop.svn.wordpress.org/branches/5.3@46767


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 11:01:04 +00:00
Sergey Biryukov 51ba5fd05b Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`. 
Props manikmist09.
Merges [46765] to the 5.3 branch.
Fixes #48624.
Built from https://develop.svn.wordpress.org/branches/5.3@46766


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 10:59:04 +00:00
Sergey Biryukov 01c05f6ba4 Post WordPress 5.3 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.3@46728


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 21:57:01 +00:00
Sergey Biryukov 1d39158963 WordPress 5.3. 
Built from https://develop.svn.wordpress.org/branches/5.3@46726


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 20:28:04 +00:00
Sergey Biryukov ace691cd92 Help/About: Move images to the CDN. 
Props ryelle.
Merges [46724] to the 5.3 branch.
Fixes #47708.
Built from https://develop.svn.wordpress.org/branches/5.3@46725


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 18:32:03 +00:00
Sergey Biryukov adfc7aad8d Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Merges [46722] to the 5.3 branch.
Fixes #48571.
Built from https://develop.svn.wordpress.org/branches/5.3@46723


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 18:26:03 +00:00
Sergey Biryukov 492e68fa7c Bundled Themes: Update copyright year in `readme.txt`. 
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Merges [46719] and [46720] to the 5.3 branch.
Fixes #48566.
Built from https://develop.svn.wordpress.org/branches/5.3@46721


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 18:06:04 +00:00
Sergey Biryukov 1bbf386977 Post WordPress 5.3 RC5 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.3@46718


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 02:48:03 +00:00
Sergey Biryukov c6be5ae66c WordPress 5.3 RC5. 
Built from https://develop.svn.wordpress.org/branches/5.3@46717


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 02:19:01 +00:00
Sergey Biryukov 70f65b8fcd Bundled Themes: Update Twenty Twenty. 
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes #48557.
Built from https://develop.svn.wordpress.org/branches/5.3@46716


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 02:08:02 +00:00
Sergey Biryukov f8218720fb Bundled Themes: Update Twenty Twenty. 
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes #48557.
Built from https://develop.svn.wordpress.org/branches/5.3@46714


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 01:46:02 +00:00
Sergey Biryukov 4c19b2c3c3 Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...ab5fa23.

Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes #48557.
Built from https://develop.svn.wordpress.org/branches/5.3@46712


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 21:05:01 +00:00
Sergey Biryukov 79ea28c053 Help/About: Update the 5.3 About page. 
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616].

Reviewed by SergeyBiryukov.
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
Merges [46705] and [46709] to the 5.3 branch.
Fixes #47708.
Built from https://develop.svn.wordpress.org/branches/5.3@46710


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 20:48:02 +00:00
Sergey Biryukov f542e3f870 Tests: Fix a typo in an inline comment introduced in [46568]. 
Reviewed by whyisjake, SergeyBiryukov.
Props david.binda.
Merges [46707] to the 5.3 branch.
Fixes #48564. See #48312.
Built from https://develop.svn.wordpress.org/branches/5.3@46708


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 20:32:05 +00:00
whyisjake d804c8218d Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press. 
Brings [46700] to the 5.3 branch.

Follow-up to [45790].
Props raamdev.
Fixes #48543. See #41545.


Built from https://develop.svn.wordpress.org/branches/5.3@46706


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 16:59:02 +00:00
Sergey Biryukov 0dcfbcca36 Script Loader: In `wp_default_packages_inline_scripts()`, make sure the root URL middleware is registered before using the media middleware. 
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.

Reviewed by johnbillion, youknowriad, SergeyBiryukov.
Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Merges [46703] to the 5.3 branch.
Fixes #48542.
Built from https://develop.svn.wordpress.org/branches/5.3@46704


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 15:13:02 +00:00
Sergey Biryukov a4ea358a27 Bundled Themes: Standardize the Required PHP and Tested Up To headers. 
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Merges [46676] to the 5.3 branch.
Fixes #48517.
Built from https://develop.svn.wordpress.org/branches/5.3@46699


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 11:39:04 +00:00
Andrew Ozz 5e93894c98 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. 
Props desrosj, azaozz.
Merges [46677] to the 5.3 branch.
Fixes #48518.
Built from https://develop.svn.wordpress.org/branches/5.3@46680


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-08 22:58:03 +00:00
John Blackbourn 69f5738ed0 Post WordPress 5.3 RC4 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.3@46673


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-06 00:02:02 +00:00
John Blackbourn 3189b48619 WordPress 5.3 RC4. 
Built from https://develop.svn.wordpress.org/branches/5.3@46672


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 23:24:02 +00:00
desrosj f252700dec Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.
Built from https://develop.svn.wordpress.org/branches/5.3@46669


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:30:04 +00:00
desrosj 30ea8d0dd9 Emoji: Upgrade Twemoji to 12.1.3. 
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.

Merges [46665] to the 5.3 branch.

Reviewed by desrosj, SergeyBiryukov.
Props matstars, desrosj, Otto42, pento.
Fixes #48293.
Built from https://develop.svn.wordpress.org/branches/5.3@46667


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:16:02 +00:00
John Blackbourn 181367b5c6 Block Editor: Bug fixes targeted for WordPress 5.3 RC4. 
Merges [46656] to the 5.3 branch.
Fixes #48502

Built from https://develop.svn.wordpress.org/branches/5.3@46666


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:06:04 +00:00
Andrew Ozz 1d815800d4 Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. 
Props ianmjones, azaozz.
Merges [46658] to the 5.3 branch.
Fixes #48453.
Built from https://develop.svn.wordpress.org/branches/5.3@46659


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 20:58:02 +00:00
Andrew Ozz 9ef78246d8 Upload: 
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting image post-processing.

Props SergeyBiryukov, azaozz.
Merges [46621], [46622], and [46651] to the 5.3 branch.
Fixes #48472.
Built from https://develop.svn.wordpress.org/branches/5.3@46655


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 18:44:02 +00:00
whyisjake 645ce999a7 Revert: Undo r46639. 
This was meant to be committed to /trunk. 

See #48337.

Built from https://develop.svn.wordpress.org/branches/5.3@46653


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 17:36:03 +00:00
whyisjake 7a8e558ac4 REST API: Fix for Yoda condition. 
Little coding standards fix for the REST API.

Props mukesh27, spenserhale.
Fixes #48337.

Built from https://develop.svn.wordpress.org/branches/5.3@46639


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 18:34:04 +00:00
desrosj 6b9ce11634 Post WordPress 5.3 RC3 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.3@46619


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 21:16:05 +00:00
desrosj ae762f145f WordPress 5.3 RC3. 
Built from https://develop.svn.wordpress.org/branches/5.3@46618


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 20:56:03 +00:00
desrosj 4a89da0ff3 Help/About: Update the 5.3 About page for RC3. 
Previously [46556], [46572].

Reviewed by azaozz, desrosj.
Merges [46616] to the 5.3 branch.
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.
Built from https://develop.svn.wordpress.org/branches/5.3@46617


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 20:13:03 +00:00
whyisjake d68a6ab321 Build/Test Tools: Don't hardcode the directory name of the repo 
When Travis builds the directory, it was looking for a hardcoded wordpress-develop directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.

Props pento, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.3@46615


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 19:19:06 +00:00
desrosj 749596e95c Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Reviewed by ianbelanger, SergeyBiryukov, desrosj.
Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Merges [46613] to the 5.3 branch.
Fixes #48450.
Built from https://develop.svn.wordpress.org/branches/5.3@46614


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 16:42:05 +00:00
gziolo 5bb6344302 Block Editor: Bug fixes targetted for WordPress 5.3 RC3. 
The list of included fixes is:
https://github.com/WordPress/gutenberg/pull/18108
https://github.com/WordPress/gutenberg/pull/18051
https://github.com/WordPress/gutenberg/pull/18106
https://github.com/WordPress/gutenberg/pull/18102
Updated packages:
@wordpress/api-fetch@3.6.4
@wordpress/block-directory@1.0.4
@wordpress/block-library@2.9.4
@wordpress/core-data@2.7.4
@wordpress/data-controls@1.3.4
@wordpress/edit-post@3.8.4
@wordpress/editor@9.7.4
@wordpress/list-reusable-blocks@1.8.4
@wordpress/media-utils@1.2.4
@wordpress/server-side-render@1.3.4

Props desrosj, youknowriad.
Merges [{46606}] to the 5.3 branch.
See #48447.



Built from https://develop.svn.wordpress.org/branches/5.3@46611


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 09:59:08 +00:00
Sergey Biryukov 4b2996f926 Date/Time: Remove incomplete and redundant test for `get_post_time()` added in [46580]. 
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

Props Rarst.
Merges [46583] to the 5.3 branch.
Fixes #48384.
Built from https://develop.svn.wordpress.org/branches/5.3@46584


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:34:40 +00:00
Sergey Biryukov 75c183c248 Date/Time: Make sure `get_post_time()` keeps UTC time on timezone change. 
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.
Built from https://develop.svn.wordpress.org/trunk@46580


git-svn-id: http://core.svn.wordpress.org/trunk@46377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 13:08:05 +00:00
Sergey Biryukov 7e11e9d732 Posts, Post Types: Remove unintended change from [46578]. 
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46579


git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:54:03 +00:00
Sergey Biryukov 0b83bffd45 Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp. 
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46578


git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:51:03 +00:00
Sergey Biryukov 8410526528 Date/Time: Make sure `date_i18n()` correctly handles zero timestamp after [45901]. 
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.
Built from https://develop.svn.wordpress.org/trunk@46577


git-svn-id: http://core.svn.wordpress.org/trunk@46374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 11:05:07 +00:00
desrosj 5e18c8320b Build/Test Tools: Update the `https-proxy-agent` dependency. 
Fixes #48428.
Built from https://develop.svn.wordpress.org/trunk@46576


git-svn-id: http://core.svn.wordpress.org/trunk@46373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 00:24:05 +00:00
Andrea Fercia 5b85aa1936 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241]. 
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.

Built from https://develop.svn.wordpress.org/trunk@46575


git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-23 20:57:05 +00:00
desrosj cc73b9a1be Post WordPress 5.3 RC2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46574


git-svn-id: http://core.svn.wordpress.org/trunk@46371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 20:11:05 +00:00
desrosj ca5925d6dc WordPress 5.3 RC2. 
Built from https://develop.svn.wordpress.org/trunk@46573


git-svn-id: http://core.svn.wordpress.org/trunk@46370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:44:06 +00:00
desrosj 27994975f9 Help/About: Update the 5.3 About page for RC2. 
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46572


git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:19:07 +00:00
desrosj 16e5753b48 Bundled Themes: Update Twenty Twenty. 
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.
Built from https://develop.svn.wordpress.org/trunk@46571


git-svn-id: http://core.svn.wordpress.org/trunk@46368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 18:27:08 +00:00
Sergey Biryukov 0609e04266 Administration: Relax the default value check for the `$position` argument added to `add_submenu_page()` and related functions in [46197]. 
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
Built from https://develop.svn.wordpress.org/trunk@46570


git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:52:04 +00:00
Sergey Biryukov 4e06f0ad40 Date/Time: Make sure `wp_date()` does not unnecessarily escape localized numbers, but keeps localized slashes. 
Props Rarst, tmatsuur, remcotolsma, peterwilsoncc.
Reviewed by peterwilsoncc.
Fixes #48319.
Built from https://develop.svn.wordpress.org/trunk@46569


git-svn-id: http://core.svn.wordpress.org/trunk@46366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:31:08 +00:00
Sergey Biryukov ff65cfcacf Plugins: Restore backward compatibility for PHP4-style passing of `array( &$this )` as action argument to `do_action()`. 
This is a follow-up to [46149] to avoid unnecessary breakage in case of using the old notation.

Props david.binda, jrf.
Reviewed by azaozz.
Fixes #48312.
Built from https://develop.svn.wordpress.org/trunk@46568


git-svn-id: http://core.svn.wordpress.org/trunk@46365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 00:11:03 +00:00
Andrew Ozz b37a2b5c3b Media: After [46237] add the same fix to the `.button-group` on the "Insert form URL" screen in the media modal. 
Props afercia, sabernhardt.
FIxes #48087.
Built from https://develop.svn.wordpress.org/trunk@46567


git-svn-id: http://core.svn.wordpress.org/trunk@46364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 23:23:04 +00:00
Andrew Ozz 5013b45775 Upload: Expand error codes to include all 5xx HTTP errors when retrying to create image sub-sizes. Some servers may be configured to set HTTP 508 or 504, or possibly other `5` errors. 
Porps mikeschroder, azaozz.
Fixes #48379.
Built from https://develop.svn.wordpress.org/trunk@46566


git-svn-id: http://core.svn.wordpress.org/trunk@46363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 22:44:03 +00:00
Andrew Ozz e1560cd1e0 Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append `scaled-` to the file names of the scaled images to make them easier to recognize. 
Props kraftbj, azaozz.
Fixes #48304.
Built from https://develop.svn.wordpress.org/trunk@46565


git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 21:43:04 +00:00
Sergey Biryukov 654c413990 Comments: Add `rel="nofollow ugc"` attribute when converting plain URLs to `<a>` tags in comments via `make_clickable()`. 
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.
Built from https://develop.svn.wordpress.org/trunk@46564


git-svn-id: http://core.svn.wordpress.org/trunk@46361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 20:41:04 +00:00
K. Adam White cfec48cc31 REST API: Cast empty meta values to correct scalar types in REST response. 
Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.


Built from https://develop.svn.wordpress.org/trunk@46563


git-svn-id: http://core.svn.wordpress.org/trunk@46360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 19:10:06 +00:00
youknowriad 21bf3bf8dd Block Editor: Update Packages that include WP 5.3 RC2 fixes. 
Updated packages:
 - @wordpress/api-fetch@3.6.3
 - @wordpress/block-directory@1.0.3
 - @wordpress/block-editor@3.2.3
 - @wordpress/block-library@2.9.3
 - @wordpress/core-data@2.7.3
 - @wordpress/data-controls@1.3.3
 - @wordpress/e2e-test-utils@2.4.3
 - @wordpress/e2e-tests@1.7.3
 - @wordpress/edit-post@3.8.3
 - @wordpress/editor@9.7.3
 - @wordpress/format-library@1.9.3
 - @wordpress/list-reusable-blocks@1.8.3
 - @wordpress/media-utils@1.2.3
 - @wordpress/server-side-render@1.3.3
 - @wordpress/url@2.8.2

Props gziolo.
Fixes #48381.

Built from https://develop.svn.wordpress.org/trunk@46562


git-svn-id: http://core.svn.wordpress.org/trunk@46359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 14:02:07 +00:00