Commit Graph

25710 Commits

Author SHA1 Message Date
Sergey Biryukov 357a4957ec General: Introduce `wp_unique_id()`, a PHP implementation of Underscore's `uniqueId` method.
A static variable contains an integer that is incremented with each call. This number is returned with the optional prefix.
As such the returned value is not universally unique, but it is unique across the life of the PHP process.

Props westonruter, dlh.
See #44883.
Built from https://develop.svn.wordpress.org/trunk@43658


git-svn-id: http://core.svn.wordpress.org/trunk@43487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-24 20:57:23 +00:00
Sergey Biryukov eb6be7eee1 Docs: Add a line break to `wp_is_uuid()` DocBlock for better readability.
See #42505.
Built from https://develop.svn.wordpress.org/trunk@43657


git-svn-id: http://core.svn.wordpress.org/trunk@43486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-24 20:46:26 +00:00
Felix Arntz a58654d87e Multisite: Fix coding standard errors after [43654].
See #41333.

Built from https://develop.svn.wordpress.org/trunk@43655


git-svn-id: http://core.svn.wordpress.org/trunk@43484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-24 15:22:24 +00:00
Felix Arntz 2b10923a28 Multisite: Introduce a site initialization and uninitialization API.
This changeset makes the new CRUD API for sites introduced in [43548] usable for real-world sites. A new function `wp_initialize_site()`, which takes care of creating a site's database tables and populating them with initial values, is hooked into the site insertion process that is initiated when calling `wp_insert_site()`. Similarly, a new function `wp_uninitialize_site()`, which takes care of dropping a site's database tables, is hooked into the site deletion process that is initiated when calling `wp_delete_site()`.

A new function `wp_is_site_initialized()` completes the API, allowing to check whether a site is initialized. Since this function always makes a database request in its default behavior, it should be called with caution. Plugins that would like to use site initialization in special ways can leverage a `pre_wp_is_site_initialized` filter to alter that default behavior.

The separate handling of the site's row in the `wp_blogs` database table and the actual site setup allows for more flexibility in controlling whether or how a site's data is set up. For example, a unit test that only checks data from the site's database table row can unhook the site initialization process to improve performance. At the same time, developers consuming the new sites API only need to know about the CRUD functions, since the initialization and uninitialization processes happen internally.

With this changeset, the foundation for a sites REST API endpoint is fully available. The previously recommended functions `wpmu_create_blog()` and `wpmu_delete_blog()` now call the new respective function internally. Further follow-up work to this includes replacing calls to `wpmu_create_blog()` with `wp_insert_site()`, `update_blog_details()` with `wp_update_site()` and `wpmu_delete_blog()` with `wp_delete_blog()` throughout the codebase.

As a side-effect of this work, the `wpmu_new_blog`, `delete_blog`, and `deleted_blog` actions and the `install_blog()` function have been deprecated.

Fixes #41333. See #40364.

Built from https://develop.svn.wordpress.org/trunk@43654


git-svn-id: http://core.svn.wordpress.org/trunk@43483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-24 15:09:26 +00:00
Aaron Jorbin 76ef0432c0 General: PHP7.3 throws an `E_WARNING` when using continue to target a switch
Applying continue to a switch is equivalent to using break and quite possibly, a continue targeting a higher level control structure is actually intended.

To target the higher level control structure, a numeric argument has to be passed to continue. This fixes two cases in WordPress Core where this is currently happening.

See: https://github.com/php/php-src/pull/3364
See: https://wiki.php.net/rfc/continue_on_switch_deprecation

Props jrf.
Fixes #44543.


Built from https://develop.svn.wordpress.org/trunk@43653


git-svn-id: http://core.svn.wordpress.org/trunk@43482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-23 22:50:24 +00:00
Sergey Biryukov 0929610414 Tests: Add missing `public` access modifier to `Tests_REST_Server` methods.
Props andizer.
Fixes #44939.
Built from https://develop.svn.wordpress.org/trunk@43652


git-svn-id: http://core.svn.wordpress.org/trunk@43481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-23 15:46:23 +00:00
Sergey Biryukov 727cdc94c9 Users: Add `LIMIT 1` to SQL query in `WP_User::get_data_by()`, as only one row is requested.
Props spacedmonkey.
Fixes #43692.
Built from https://develop.svn.wordpress.org/trunk@43651


git-svn-id: http://core.svn.wordpress.org/trunk@43480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-23 15:33:24 +00:00
Sergey Biryukov 2e8c823212 Upgrade/Install: Adjust table prefix string check in `setup-config.php` for the coding standards change in [42343].
Props shashwatmittal, allendav.
Fixes #44318.
Built from https://develop.svn.wordpress.org/trunk@43650


git-svn-id: http://core.svn.wordpress.org/trunk@43479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-20 05:15:25 +00:00
Sergey Biryukov 9ab70735ef Tests: Restore `restapi` group on `WP_Test_REST_Revisions_Controller`.
See #40510.
Built from https://develop.svn.wordpress.org/trunk@43647


git-svn-id: http://core.svn.wordpress.org/trunk@43476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-18 03:45:25 +00:00
John Blackbourn 21ce9f7313 Build/Test Tools: Implement the automatic retry functionality that Travis CI provides.
This functionality will cause the command to be retried up to three times in case of a non-zero return value. Implementing it on commands that perform network requests means that intermittent network failures are less likely to cause a build to fail, as they'll be retried up to three times.

See #44858

Built from https://develop.svn.wordpress.org/trunk@43645


git-svn-id: http://core.svn.wordpress.org/trunk@43474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-15 09:22:25 +00:00
John Blackbourn aa77e7c27f Docs: Improve docblocks within `wp-login.php`.
Props birgire

See #42505

Built from https://develop.svn.wordpress.org/trunk@43644


git-svn-id: http://core.svn.wordpress.org/trunk@43473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-14 13:48:24 +00:00
John Blackbourn 0facb2f5dd Docs: Correct and improve docblocks for user session management functionality.
See #42505

Built from https://develop.svn.wordpress.org/trunk@43643


git-svn-id: http://core.svn.wordpress.org/trunk@43472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-14 13:45:26 +00:00
John Blackbourn 8992656b13 Docs: Correct and improve some docblocks.
See #42505

Built from https://develop.svn.wordpress.org/trunk@43642


git-svn-id: http://core.svn.wordpress.org/trunk@43471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-14 13:35:25 +00:00
Felix Arntz 9b2e72a6b4 Upgrade/Install: Properly exclude the `admin/includesSchema.php` tests file for the `WordPress.DB.PreparedSQL.NotPrepared` sniff.
The way this was implemented in [43630] caused the file to be excluded for all sniffs, since PHPCS does not support file-wide ignores of a specific sniff at this point.

Props jrf.
See #44896.

Built from https://develop.svn.wordpress.org/trunk@43641


git-svn-id: http://core.svn.wordpress.org/trunk@43470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-14 07:55:23 +00:00
iandunn 8a63198883 Privacy: Add test for `wp_privacy_export_expiration` filter.
Props desrosj.
See #44233.

Built from https://develop.svn.wordpress.org/trunk@43640


git-svn-id: http://core.svn.wordpress.org/trunk@43469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-13 17:26:25 +00:00
Sergey Biryukov f7ba175491 Docs: Correct `@since` value for `_wp_privacy_statuses()`.
Fix typo in `@since` entry for `WP_Privacy_Policy_Content:add()`.

Props dimadin.
Fixes #44915.
Built from https://develop.svn.wordpress.org/trunk@43638


git-svn-id: http://core.svn.wordpress.org/trunk@43467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-13 10:20:24 +00:00
K. Adam White 42b578ad94 REST API: Pass correct ID to `meta->update_value` to permit setting term meta during term creation.
Props joehoyle.
Fixes #44834.


Built from https://develop.svn.wordpress.org/trunk@43636


git-svn-id: http://core.svn.wordpress.org/trunk@43465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-12 23:56:24 +00:00
Dominik Schilling a7bb083120 I18N: In the POMO library, replace `chr()` calls for static values with their string representation.
Props ccismaru, ocean90.
Fixes #17128.
Built from https://develop.svn.wordpress.org/trunk@43635


git-svn-id: http://core.svn.wordpress.org/trunk@43464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-12 06:11:26 +00:00
Dominik Schilling 836d2bf421 Revert accidental change to `package-lock.json` introduced in [43571].
Built from https://develop.svn.wordpress.org/trunk@43634


git-svn-id: http://core.svn.wordpress.org/trunk@43463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-12 05:43:26 +00:00
Adam Silverstein e71a3d6193 Media: Improve display and accessibility of meta data in detail view.
* Add a `human_readable_duration` function including tests.
* Add 'pixels' after image width/height.
* Add screen reader text for durations.

Props Presskopp, kiranpotphode, milindmore22, stormrockwell, afercia.
Fixes #39667. 


Built from https://develop.svn.wordpress.org/trunk@43633


git-svn-id: http://core.svn.wordpress.org/trunk@43462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-08 04:20:24 +00:00
Sergey Biryukov c0aa2239a8 Docs: Update `@since` version for `(un)registered_taxonomy_for_object_type` actions introduced in [43558].
See #44733.
Built from https://develop.svn.wordpress.org/trunk@43631


git-svn-id: http://core.svn.wordpress.org/trunk@43460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-06 07:49:24 +00:00
Felix Arntz 1c2ff54037 Upgrade/Install: Fix coding standard errors after [43629].
See #44896.

Built from https://develop.svn.wordpress.org/trunk@43630


git-svn-id: http://core.svn.wordpress.org/trunk@43459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-05 12:50:24 +00:00
Felix Arntz def921f6a5 Upgrade/Install: Introduce `populate_site_meta()`.
Fixes #44896. See #41333.

Built from https://develop.svn.wordpress.org/trunk@43629


git-svn-id: http://core.svn.wordpress.org/trunk@43458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-05 11:02:24 +00:00
Felix Arntz ea2550180b Upgrade/Install: Introduce `populate_network_meta()`, moving logic out of `populate_network()`.
Fixes #44895. See #41333.

Built from https://develop.svn.wordpress.org/trunk@43628


git-svn-id: http://core.svn.wordpress.org/trunk@43457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-05 10:45:23 +00:00
Felix Arntz e2f9dfcebb Upgrade/Install: Add support for an optional `$options` parameter to `populate_options()`.
Fixes #44893. See #41333.

Built from https://develop.svn.wordpress.org/trunk@43627


git-svn-id: http://core.svn.wordpress.org/trunk@43456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-05 09:39:24 +00:00
Sergey Biryukov 7ee752e40c Privacy: When clicking a confirmation link for a privacy request, return a `WP_Error` object if the link has expired.
Returning a string caused a success message to be displayed instead of the correct error message.

Props desrosj.
Fixes #44685.
Built from https://develop.svn.wordpress.org/trunk@43623


git-svn-id: http://core.svn.wordpress.org/trunk@43452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-03 21:44:24 +00:00
Sergey Biryukov 7c366e8889 Docs: Update `@since` version for `edit_post_{$post->post_type}` action introduced in [43535] to 4.9.9.
See #34706.
Built from https://develop.svn.wordpress.org/trunk@43616


git-svn-id: http://core.svn.wordpress.org/trunk@43445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-03 21:09:27 +00:00
Sergey Biryukov c714ad082d Docs: Correct parameter type for `WP_Privacy_Policy_Content::notice()`.
Props burhandodhy.
Fixes #44877.
Built from https://develop.svn.wordpress.org/trunk@43609


git-svn-id: http://core.svn.wordpress.org/trunk@43438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-03 14:15:25 +00:00
Peter Wilson 51a9a80da2 Cron API: Clarify documentation for `wp_reschedule_event()`.
Expands documentation to indicate `wp_schedule_event()` ought to be used for rescheduling an upcoming event, while `wp_reschedule_event()` is used for internally rescheduling a recurring event after it runs.

Props Dharm1025, jrf.
Fixes #35968.


Built from https://develop.svn.wordpress.org/trunk@43608


git-svn-id: http://core.svn.wordpress.org/trunk@43437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-03 04:04:25 +00:00
Peter Wilson b8bf6de0ed Twenty Sixteen: Add pre-connect resource hint for Google Fonts.
When using Google Fonts, pre-connect to https://fonts.gstatic.com to improve the performance downloading the webfont files.

Props westonruter.
Fixes #44668.

Built from https://develop.svn.wordpress.org/trunk@43606


git-svn-id: http://core.svn.wordpress.org/trunk@43435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-03 00:53:23 +00:00
Sergey Biryukov 70e66a0bdf Taxonomy: Make sure `wp_list_categories()` correctly outputs term name of `0`.
Props joyously, SergeyBiryukov.
Fixes #44872.
Built from https://develop.svn.wordpress.org/trunk@43605


git-svn-id: http://core.svn.wordpress.org/trunk@43434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-09-02 22:09:24 +00:00
Rachel Baker d372b53ad7 REST API: Load missing required file for multisite users in `WP_REST_Attachments_Controller::create_item()`.
Requires wp-admin/includes/image.php to make `wp_read_image_metadata()` function available. Fixes error introduced in [43589].

Props ocean90, soulseekah.
Fixes #43757.
Built from https://develop.svn.wordpress.org/trunk@43604


git-svn-id: http://core.svn.wordpress.org/trunk@43433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-31 23:46:23 +00:00
Rachel Baker ad5cb69c91 REST API: Load missing required file for multisite users in `WP_REST_Attachments_Controller::check_upload_size()`.
Requires wp-admin/includes/ms.php to make `upload_is_user_over_quota()` function available to multisite users uploading files.

Props JakePT, rachelbaker.
Fixes #44864.
Built from https://develop.svn.wordpress.org/trunk@43603


git-svn-id: http://core.svn.wordpress.org/trunk@43432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-31 23:26:24 +00:00
John Blackbourn 61ba015b0f Media: Ensure the "Edit more details" link in the attachment details modal always points to the correct editing URL.
Fixes #44620

Built from https://develop.svn.wordpress.org/trunk@43601


git-svn-id: http://core.svn.wordpress.org/trunk@43430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-31 10:51:24 +00:00
Sergey Biryukov 773e45e34e Docs: Convert `@see` reference in `wp_checkdate()` DocBlock to `@link`.
Props WiZZarD_.
Fixes #44866.
Built from https://develop.svn.wordpress.org/trunk@43599


git-svn-id: http://core.svn.wordpress.org/trunk@43428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 13:49:25 +00:00
jrf f4e1cf65c1 I18n: Improve translators comments [3].
* Add missing translators comments.
* Fix placement of some translators comments.
  Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools.
  The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.

Includes minor code layout fixes.

Patch `44360-wp-admin-includes-dir.patch` of the series.

Props flipkeijzer, alvarogois, michielatyoast
See #44360

Built from https://develop.svn.wordpress.org/trunk@43598


git-svn-id: http://core.svn.wordpress.org/trunk@43427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 13:36:25 +00:00
Sergey Biryukov e1b0d4ed7a Embeds: After [43593], move the new check to a separate line to avoid `test_js_no_ampersands_in_compiled` failure caused by UglifyJS task.
See #44832.
Built from https://develop.svn.wordpress.org/trunk@43597


git-svn-id: http://core.svn.wordpress.org/trunk@43426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 12:40:26 +00:00
jrf f2d0e69030 I18n: Improve translators comments [2].
* Add missing translators comments.
* Fix placement of some translators comments.
  Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools.
  The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.

Patch `44360.wp-includes_customize.3.patch` of the series.

Props marcomartins, mihaiiceyro, michielatyoast
See #44360

Built from https://develop.svn.wordpress.org/trunk@43596


git-svn-id: http://core.svn.wordpress.org/trunk@43425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 12:36:24 +00:00
jrf c952f8f98f I18n: Improve translators comments [1].
* Add missing translators comments.
* Fix placement of some translators comments.
  Translators comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools.
  The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translators comments.

Patch `44360-src.2.diff` of the series.

Props garyj, alvarogois, michielatyoast
See #44360
Built from https://develop.svn.wordpress.org/trunk@43595


git-svn-id: http://core.svn.wordpress.org/trunk@43424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 12:14:24 +00:00
Sergey Biryukov 998d381fa0 Date/Time: Make sure `current_time()` always calculates the offset from GMT/UTC.
Previously, UTC context was implied, but could be unreliable due to being affected by plugins.

Props Rarst, rahulsprajapati, marco.marsala.
Fixes #37440.
Built from https://develop.svn.wordpress.org/trunk@43594


git-svn-id: http://core.svn.wordpress.org/trunk@43423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 12:13:24 +00:00
Sergey Biryukov 07e2fba981 Embeds: Avoid a JS error in `wp.receiveEmbedMessage` if `data` parameter is not set.
Props dsifford, kadamwhite.
Fixes #44832.
Built from https://develop.svn.wordpress.org/trunk@43593


git-svn-id: http://core.svn.wordpress.org/trunk@43422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 10:30:24 +00:00
Sergey Biryukov 810b1333ff Post Formats: Don't assign a variable inside `if` statement in `get_post_format()`.
Props Mirucon.
Fixes #44840.
Built from https://develop.svn.wordpress.org/trunk@43592


git-svn-id: http://core.svn.wordpress.org/trunk@43421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 09:01:25 +00:00
Sergey Biryukov dafee9fae6 Date/Time: Make `get_the_date()` call `get_post_time()` for consistency with `get_the_time()`.
Props Rarst.
Fixes #44490.
Built from https://develop.svn.wordpress.org/trunk@43591


git-svn-id: http://core.svn.wordpress.org/trunk@43420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 08:50:24 +00:00
Jeremy Felt cf48e75785 Multisite: Display registered `new_item` text for `post` post type in My Sites menu.
Previously, the My Sites menu would show "New Post" even if the `post` post type labels had been filtered to different values.

Props nahuelmahe.
Fixes #44794.

Built from https://develop.svn.wordpress.org/trunk@43590


git-svn-id: http://core.svn.wordpress.org/trunk@43419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-29 15:50:25 +00:00
Rachel Baker 062568e6b6 REST API: Limit the scope of wp-admin files required in WP_REST_Attachments_Controller methods.
Narrow the scope of the included wp-admin files loaded for `wp_generate_attachment_metadata()`, `wp_handle_upload()`, `wp_tempnam()`, and `wp_handle_sideload()`. Requires only wp-admin/includes/file.php and wp-admin/includes/image.php instead of wp-admin/includes/admin.php. 

Props lonelyvegan, soulseekah, pratikthink.
Fixes #43757.
Built from https://develop.svn.wordpress.org/trunk@43589


git-svn-id: http://core.svn.wordpress.org/trunk@43418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-29 03:23:25 +00:00
Felix Arntz 6eb4e9c5fc Customize: Ensure that only sidebar sections are considered when comparing against sidebars.
In the Customizer a notice will show up if there is at least one registered sidebar with its section not being active. In order to achieve that, the count of registered sidebars is compared to the count of active sections in the Widgets panel. Prior to this change, the latter would incorrectly include any sections, even additional sections that do not correspond to a sidebar.

Fixes #43556.

Built from https://develop.svn.wordpress.org/trunk@43588


git-svn-id: http://core.svn.wordpress.org/trunk@43417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-28 19:55:25 +00:00
Felix Arntz 17f435b5aa General: Provide context parameters to `doing_it_wrong_trigger_error` filter.
`$function`, `$message`, and `$version` have historically been passed to the `doing_it_wrong_run` action. It makes sense to pass those to the filter as well, so that one can conditionally determine the filter value to return.

Fixes #34183.

Built from https://develop.svn.wordpress.org/trunk@43587


git-svn-id: http://core.svn.wordpress.org/trunk@43416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-28 13:38:24 +00:00
Felix Arntz 27e48708f8 REST API: Fix failing tests after [43584] and [43585].
See #40510.

Built from https://develop.svn.wordpress.org/trunk@43586


git-svn-id: http://core.svn.wordpress.org/trunk@43415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-28 13:05:24 +00:00
Felix Arntz 77fd4135f1 REST API: Fix failing tests after [43584].
See #40510.

Built from https://develop.svn.wordpress.org/trunk@43585


git-svn-id: http://core.svn.wordpress.org/trunk@43414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-28 12:44:24 +00:00
Felix Arntz 9fe4db814a REST API: Support pagination, order, search and other common query parameters for revisions.
The original REST API revisions controller relied on `wp_get_post_revisions()`, getting all revisions of a post without any possibility to restrict the result. This changeset replaces that function call with a proper `WP_Query` setup, replicating how `wp_get_post_revisions()` works while offering parameters to alter the default behavior.

Props adamsilverstein, birgire, flixos90.
Fixes #40510.

Built from https://develop.svn.wordpress.org/trunk@43584


git-svn-id: http://core.svn.wordpress.org/trunk@43413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-28 12:23:26 +00:00