Commit Graph

37 Commits

Author SHA1 Message Date
Sergey Biryukov 7932193708 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
atimmer f6a37e7d39 Docs: Remove `@summary` tags from JSDoc.
As decided in the JavaScript core chat. With a few reasons:

* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.

The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.

Props herregroen.
Fixes #42901.

Built from https://develop.svn.wordpress.org/trunk@42411


git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
Weston Ruter 36e46af382 Twenty Thirteen: Fix selective refresh of Masonry-laid out widgets by deferring initialization until DOM ready.
This ensures that the `wp.customize.selectiveRefresh` object will be available when in the Customizer preview.

Fixes #37390.
Props westonruter, celloexpressions.

Built from https://develop.svn.wordpress.org/trunk@38083


git-svn-id: http://core.svn.wordpress.org/trunk@38024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 21:14:29 +00:00
Weston Ruter f3f84d2f21 Customize: Require opt-in for selective refresh of widgets.
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.

See #27355.
Fixes #35855.

Built from https://develop.svn.wordpress.org/trunk@37040


git-svn-id: http://core.svn.wordpress.org/trunk@37007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-21 21:59:29 +00:00
Tammie Lister 12c6679165 Twenty Thirteen, Twenty Fourteen and Twenty Fifteen: Fixes insufficient check for existence of DOM elements in jQuery object
Fixes #34033
Props: tywayne 

Built from https://develop.svn.wordpress.org/trunk@36999


git-svn-id: http://core.svn.wordpress.org/trunk@36966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-15 21:33:28 +00:00
Weston Ruter 6b775d4afe Customize: Add selective refresh framework with implementation for widgets and re-implementation for nav menus.
See https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/.

Props westonruter, valendesigns, DrewAPicture, ocean90.
Fixes #27355.

Built from https://develop.svn.wordpress.org/trunk@36586


git-svn-id: http://core.svn.wordpress.org/trunk@36553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:41:28 +00:00
Lance Willett b8e58b3352 Twenty Thirteen: make sure submenu links work correctly on small screens with touch events.
Fixes #31762, props davidhamiltron.
Built from https://develop.svn.wordpress.org/trunk@31932


git-svn-id: http://core.svn.wordpress.org/trunk@31911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:20:27 +00:00
Lance Willett 80faa524fe Bundled themes: add documentation for new `onResizeARIA` function.
See #31527. Props davidakennedy, lancewillett.
Built from https://develop.svn.wordpress.org/trunk@31814


git-svn-id: http://core.svn.wordpress.org/trunk@31796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 18:31:26 +00:00
Lance Willett c0c8c61d26 Twenty Thirteen: add ARIA attributes to menu toggle. See #31527.
Built from https://develop.svn.wordpress.org/trunk@31785


git-svn-id: http://core.svn.wordpress.org/trunk@31765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-15 20:01:26 +00:00
Lance Willett 7d95c83257 Twenty Twelve and Thirteen: Use proper way to get customizer settings values.
Props obenland, kdoran. Fixes #29577.
Built from https://develop.svn.wordpress.org/trunk@30482


git-svn-id: http://core.svn.wordpress.org/trunk@30470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 17:06:23 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Lance Willett 550a0ef768 Twenty Thirteen: make submenu links work correctly on tablets. Props tar.gz, purzlbaum, DavidTheMachine. See #24767.
Built from https://develop.svn.wordpress.org/trunk@28699


git-svn-id: http://core.svn.wordpress.org/trunk@28516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-08 18:48:16 +00:00
Lance Willett 5d05c757b3 Twenty Thirteen: improve menu navigation for keyboard and voice-over interactions by properly focusing on submenu items when they are open. Closes #24839, props dannydehaan, joedolson, lancewillett, Frank Klein.
Built from https://develop.svn.wordpress.org/trunk@27607


git-svn-id: http://core.svn.wordpress.org/trunk@27450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:29:29 +00:00
Andrew Nacin 00bb092d31 Update the HTML5 Shiv across the default themes to 3.7.0.
props rickalee.
fixes #26491.

Built from https://develop.svn.wordpress.org/trunk@27263


git-svn-id: http://core.svn.wordpress.org/trunk@27120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:18:14 +00:00
Lance Willett a0d63de4f8 Twenty Thirteen: JS fix, after r24511 changes -- add missing semicolon to end variable definition. See #24643.
git-svn-id: http://core.svn.wordpress.org/trunk@24514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-25 21:30:43 +00:00
Lance Willett 0c7a17d735 Twenty Thirteen: functions.js optimizations, props obenland. Fixes #24643.
git-svn-id: http://core.svn.wordpress.org/trunk@24511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-25 21:09:00 +00:00
Lance Willett ff9e60e3e6 Twenty Thirteen: remove all `post_format_*()` and `the_remaining_content()` function calls, reverting to `the_content()`. Simplify functions.php, JS, and CSS files accordingly. Props obenland for starter patch, fixes #24469 and #24407. See #24452.
git-svn-id: http://core.svn.wordpress.org/trunk@24391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-31 17:45:00 +00:00
Lance Willett cb9bf04530 Twenty Thirteen: improve Quote post format styles to look more like quotes. Fixes #24176.
git-svn-id: http://core.svn.wordpress.org/trunk@24172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-03 20:47:28 +00:00
Lance Willett c9b9c41dbb Twenty Thirteen: remove fixed navbar. Closes #24184.
git-svn-id: http://core.svn.wordpress.org/trunk@24169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-03 18:22:57 +00:00
Lance Willett 8492d3b680 Twenty Thirteen: remove `hgroup` from the theme markup structure since it's been dropped from HTML5 spec. Props obenland for the starter patch. Fixes #24114.
git-svn-id: http://core.svn.wordpress.org/trunk@24072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-23 17:55:55 +00:00
Lance Willett 7edf4b4910 Twenty Thirteen: update JavaScript-based accessibility function hooked to `hashchange` event to verify user input correctly. Props mfields for the original patch.
Also add textarea to list of elements. See #23875.

git-svn-id: http://core.svn.wordpress.org/trunk@24070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-23 16:30:03 +00:00
Lance Willett 7ed04565bb Twenty Thirteen: further performance for functions.js scroll event callback, props obenland. See #23875.
git-svn-id: http://core.svn.wordpress.org/trunk@24005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 22:35:55 +00:00
Lance Willett e4248830a8 Twenty Thirteen: improvements to functions.js to add namespacing to events and simplify repeatable functions. See #23875.
git-svn-id: http://core.svn.wordpress.org/trunk@24004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 21:51:07 +00:00
Lance Willett 2fe90e6312 Twenty Thirteen: adjust JavaScript handling for scrolling and finding viewport heigh/width to better support various IE versions. Also consolidate variables at the top of the file per best practices. Fixes #23841, props obenland.
git-svn-id: http://core.svn.wordpress.org/trunk@23965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-11 16:11:46 +00:00
Andrew Nacin 155a7c2455 Don't use jQuery.on('ready'). props obenland. see #23875.
git-svn-id: http://core.svn.wordpress.org/trunk@23891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-03 17:29:59 +00:00
Lance Willett a553da699d Twenty Thirteen: remove logging code, accidentally added in r23676.
git-svn-id: http://core.svn.wordpress.org/trunk@23757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-19 21:38:51 +00:00
Lance Willett 16c33f55b2 Twenty Thirteen: pinking shears.
git-svn-id: http://core.svn.wordpress.org/trunk@23679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 22:42:34 +00:00
Lance Willett e18309bc0e Twenty Thirteen: enable a JavaScript-based fix for long sidebar areas that overflow the footer. Props obenland, fixes #23557.
git-svn-id: http://core.svn.wordpress.org/trunk@23676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 21:42:53 +00:00
Lance Willett 92852af835 Twenty Thirteen: fix toggling header text display in Customizer. Props obenland, fixes #23722.
git-svn-id: http://core.svn.wordpress.org/trunk@23670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 16:52:30 +00:00
Lance Willett 7b26a36756 Twenty Thirteen: simpler isRTL check for masonry, props obenland. See #23550.
git-svn-id: http://core.svn.wordpress.org/trunk@23645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 18:22:58 +00:00
Lance Willett d96b1ca8e2 Twenty Thirteen: RTL JS support, fix class selector, see #23550.
git-svn-id: http://core.svn.wordpress.org/trunk@23644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 18:00:26 +00:00
Lance Willett 79163b239b Twenty Thirteen: first pass at RTL CSS and JS support. Props DrewAPicture and maor, see #23550.
git-svn-id: http://core.svn.wordpress.org/trunk@23643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 17:57:16 +00:00
Lance Willett 531494b993 Twenty Thirteen: make footer widget area the primary sidebar, acting as "secondary" content. Move optional sidebar widget area to "tertiary" content. Props obenland, fixes #23644.
git-svn-id: http://core.svn.wordpress.org/trunk@23539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 21:35:26 +00:00
Lance Willett 8293fc84bb Twenty Thirteen: disable fixed navbar on small screens. Props obenland, fixes #23647.
Also closes #23526, #23535, and #23566

git-svn-id: http://core.svn.wordpress.org/trunk@23533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:49:26 +00:00
Lance Willett 4aec9565df Twenty Thirteen: instantly preview header text color changes in the Theme Customizer. Fixes #23585, props SriniG.
git-svn-id: http://core.svn.wordpress.org/trunk@23493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-26 04:59:35 +00:00
Lance Willett 4ba9ccd643 Twenty Thirteen: header area with no site title or tagline should still be clickable to home. Fixes #23549.
Fix also removes several `!important` flags that aren't necessary, relating to header text color.

git-svn-id: http://core.svn.wordpress.org/trunk@23492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-26 04:50:09 +00:00
Mark Jaquith d1d3076d5a Introduce the Twenty Thirteen theme.
props matt, joen, obenland, lancewillett. see #23504

git-svn-id: http://core.svn.wordpress.org/trunk@23452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-18 23:08:56 +00:00