909470db67
Don't reset index keys when trimming results of term queries.
...
`array_slice()` must be told to preserve keys when the query results exceed the
limit specified the 'number' parameter, so that `id=>parent` and other
id-indexed return value formats don't get mangled.
Props fantasyworld, wpdelighter.
Fixes #35382 .
Built from https://develop.svn.wordpress.org/trunk@36252
git-svn-id: http://core.svn.wordpress.org/trunk@36219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 04:06:25 +00:00
cfae56d2c2
Avoid invalid SQL when building ORDER BY clause using long search strings.
...
The introduction of negative search terms in 4.4 [34934] introduced the
possibility that the ORDER BY clause of a search query could be assembled in
such a way as to create invalid syntax. The current changeset fixes this by
ensuring that the ORDER BY clause corresponding to the search terms is
excluded when it would otherwise be empty.
Props salvoaranzulla.
Fixes #35361 .
Built from https://develop.svn.wordpress.org/trunk@36251
git-svn-id: http://core.svn.wordpress.org/trunk@36218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 03:26:26 +00:00
a4facedfee
Docs: Various docblock corrections.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36250
git-svn-id: http://core.svn.wordpress.org/trunk@36217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:26:25 +00:00
877d14883e
Emoji: Explictly use `https` as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway.
...
Fixes #35376
Props ocean90
Built from https://develop.svn.wordpress.org/trunk@36249
git-svn-id: http://core.svn.wordpress.org/trunk@36216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:24:26 +00:00
f63dc802cb
Comments: Correct the docblocks for various methods in the comment list table class.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36248
git-svn-id: http://core.svn.wordpress.org/trunk@36215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 00:52:25 +00:00
16fe7012dd
Taxonomy: More tests for `unregister_taxonomy()`.
...
See #35227
Built from https://develop.svn.wordpress.org/trunk@36247
git-svn-id: http://core.svn.wordpress.org/trunk@36214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 23:35:26 +00:00
c52af7470b
Login is not a verb, change "login" to "log in".
...
See #35387
Built from https://develop.svn.wordpress.org/trunk@36246
git-svn-id: http://core.svn.wordpress.org/trunk@36213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 21:08:26 +00:00
2f41867519
Users: Fix incorrect docs for user authentication and login functions.
...
Fixes #35387
Built from https://develop.svn.wordpress.org/trunk@36245
git-svn-id: http://core.svn.wordpress.org/trunk@36212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 20:52:27 +00:00
2e4210e209
Taxonomy: Use `Invalid taxonomy` instead of `Invalid Taxonomy` for error strings.
...
Built from https://develop.svn.wordpress.org/trunk@36244
git-svn-id: http://core.svn.wordpress.org/trunk@36211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 15:16:25 +00:00
710501dc53
Taxonomy: Introduce `unregister_taxonomy()`.
...
This new function can be used to completely unregister non built-in taxonomies.
Fixes #35227 .
Built from https://develop.svn.wordpress.org/trunk@36243
git-svn-id: http://core.svn.wordpress.org/trunk@36210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:58:26 +00:00
d591f26ce7
Ensure `wp_get_referer()` returns `false` when the referrer URL is the current URL.
...
Adds unit tests.
Fixes #19856 .
Built from https://develop.svn.wordpress.org/trunk@36242
git-svn-id: http://core.svn.wordpress.org/trunk@36209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:36:26 +00:00
fdb6bbfa10
Media: After [36240], remove some unneeded whitespace.
...
Props ocean90.
See #35367 .
Built from https://develop.svn.wordpress.org/trunk@36241
git-svn-id: http://core.svn.wordpress.org/trunk@36208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:29:26 +00:00
8ee945d82f
Media: Fix `wp_audio_shortcode` and `wp_video_shortcode` attributes handling.
...
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.
Fixes #35367 .
Built from https://develop.svn.wordpress.org/trunk@36240
git-svn-id: http://core.svn.wordpress.org/trunk@36207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 14:18:27 +00:00
43d8a30d0c
Tests: Add more paged canonical tests for page_on_front.
...
See #35344 .
Built from https://develop.svn.wordpress.org/trunk@36238
git-svn-id: http://core.svn.wordpress.org/trunk@36205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 08:09:26 +00:00
84a3b4407f
Canonical: Generate the correct canonical url for paged posts/pages when they're used as the page_on_front.
...
This fixes an issue where pages become inacessible on a front page post.
Fixes #35344 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36237
git-svn-id: http://core.svn.wordpress.org/trunk@36204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 07:33:27 +00:00
d57776b108
Tests: Remove some debug that's slipped in at some point.
...
Built from https://develop.svn.wordpress.org/trunk@36236
git-svn-id: http://core.svn.wordpress.org/trunk@36203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 06:12:27 +00:00
72265e4a98
Introduce `comments_template_query_args` filter.
...
This new filter gives developers a way to target the arguments used for comment
queries specifically when populating the main comment template.
Props birgire.
Fixes #34442 .
Built from https://develop.svn.wordpress.org/trunk@36235
git-svn-id: http://core.svn.wordpress.org/trunk@36202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 04:44:26 +00:00
4ce9b93af9
Clarify return types in `get_option()` documentation.
...
The new note specifies that scalar values will always be returned as strings.
Fixes #31820 .
Built from https://develop.svn.wordpress.org/trunk@36234
git-svn-id: http://core.svn.wordpress.org/trunk@36201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 03:12:26 +00:00
5a6be6d431
Media: fix undefined error that prevents showing a preview in the media modal when replacing video or audio.
...
Fixes #35363 .
Built from https://develop.svn.wordpress.org/trunk@36233
git-svn-id: http://core.svn.wordpress.org/trunk@36200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 02:22:26 +00:00
a5d44337b2
Docs: `@param` fixes for a variety of docblocks.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36232
git-svn-id: http://core.svn.wordpress.org/trunk@36199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:45:26 +00:00
7718e07129
Docs: Correct the parameter docs for various Heartbeat filters and functions.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36231
git-svn-id: http://core.svn.wordpress.org/trunk@36198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:37:26 +00:00
7931478595
Feeds: Remove the `rss-http` feed type, unused since r32468.
...
See #15110
Built from https://develop.svn.wordpress.org/trunk@36230
git-svn-id: http://core.svn.wordpress.org/trunk@36197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:20:26 +00:00
b464b01c7e
Add documentation for parseData() and ajaxDel() in wp-lists.js.
...
Fixes #35360 .
Built from https://develop.svn.wordpress.org/trunk@36229
git-svn-id: http://core.svn.wordpress.org/trunk@36196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 00:05:26 +00:00
7733ed2ddc
Cron: Add the cron lock timestamp to the 'cron_request' filter arguments.
...
Fixes #31307
Built from https://develop.svn.wordpress.org/trunk@36228
git-svn-id: http://core.svn.wordpress.org/trunk@36195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 23:54:26 +00:00
cbb245196c
Use a more generous selector when setting up tag suggestion.
...
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.
Props johnjamesjacoby..
Fixes #35349 .
Built from https://develop.svn.wordpress.org/trunk@36227
git-svn-id: http://core.svn.wordpress.org/trunk@36194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 23:18:25 +00:00
13629bf5d0
In `comments_template()`, don't run hierarchical queries if comment threading is disabled.
...
When hierarchical=true, `WP_Comment_Query` will always fetch comments according
to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded
comments have been recorded on the site; comments will no longer be returned in
a strictly chronological order.
We address the issue by refraining from querying hierarchically when comment
threading is disabled.
Props jmdodd.
Fixes #35378 .
Built from https://develop.svn.wordpress.org/trunk@36226
git-svn-id: http://core.svn.wordpress.org/trunk@36193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 22:17:26 +00:00
d8e6199126
Permalinks: Make `get_post_type_archive_link()` work for the 'post' post type.
...
Props jjj.
See #19902 .
Built from https://develop.svn.wordpress.org/trunk@36225
git-svn-id: http://core.svn.wordpress.org/trunk@36192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 22:01:26 +00:00
5b4b4fc479
Introduce 'author_url' param to `WP_Comment_Query`.
...
Props swissspidy.
Fixes #35377 .
Built from https://develop.svn.wordpress.org/trunk@36224
git-svn-id: http://core.svn.wordpress.org/trunk@36191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 21:52:27 +00:00
ae1575bd80
Media: make the Image Editor usable with a keyboard.
...
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.
Fixes #28864 .
Built from https://develop.svn.wordpress.org/trunk@36223
git-svn-id: http://core.svn.wordpress.org/trunk@36190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:13:26 +00:00
1f9c29d98f
Accessibility: remove the title attribute from the `get_search_form()` HTML5 search field.
...
It was added in [23801] as a workaround for issues with very old browser/screen reader combos (Jaws7/IE6).
No more necessary today. Reduces redundancy and noise for screen reader users.
See #16539 .
Fixes #33952 .
Built from https://develop.svn.wordpress.org/trunk@36222
git-svn-id: http://core.svn.wordpress.org/trunk@36189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 19:01:26 +00:00
c252e77ce3
Plugins: Use plugin file rather than slug as identifier
...
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.
See [36205].
Fixes #35350 .
Built from https://develop.svn.wordpress.org/trunk@36221
git-svn-id: http://core.svn.wordpress.org/trunk@36188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 17:48:28 +00:00
07e9d22968
Update to Random_Compat 1.1.5 to fix an issue with older libSodium modules.
...
Props sarciszewski.
Fixes #35327 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36220
git-svn-id: http://core.svn.wordpress.org/trunk@36187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 03:28:28 +00:00
0b8c6eed83
Customizer: Improve `_doing_it_wrong()` message when `widgets` or `nav_menus` are manually removed via `WP_Customize_Manager::remove_panel()`.
...
* Link to code reference page for `customize_loaded_components` instead of linking to a Trac comment.
* Remove HTML code from being included in translated string.
* Add missing translator comment for the specifiers in the translated string.
Amends [36216].
Props DrewAPicture.
Fixes #35242 .
Built from https://develop.svn.wordpress.org/trunk@36219
git-svn-id: http://core.svn.wordpress.org/trunk@36186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 18:44:28 +00:00
0075480202
Tests: Fix unit tests after [36217].
...
See #35236 .
Built from https://develop.svn.wordpress.org/trunk@36218
git-svn-id: http://core.svn.wordpress.org/trunk@36185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 10:17:27 +00:00
f079f57357
Rewrite: Add a `remove_rewrite_tag()` helper function.
...
It can be used to properly remove registered rewrite tags. Adds unit tests.
Fixes #35236 .
Built from https://develop.svn.wordpress.org/trunk@36217
git-svn-id: http://core.svn.wordpress.org/trunk@36184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 09:39:27 +00:00
668818e93d
Customizer: Call `_doing_it_wrong()` if `widgets` or `nav_menus` are manually removed via `WP_Customize_Manager::remove_panel()`.
...
Advise that the `customize_loaded_components` filter should be used instead.
Props voldemortensen.
See #33552 .
Fixes #35242 .
Built from https://develop.svn.wordpress.org/trunk@36216
git-svn-id: http://core.svn.wordpress.org/trunk@36183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 06:06:28 +00:00
74f83e1016
Allow comment agent and author IP to be set via `wp_update_comment()`.
...
Props adamsilverstein, welcher.
Fixes #35276 .
Built from https://develop.svn.wordpress.org/trunk@36215
git-svn-id: http://core.svn.wordpress.org/trunk@36182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 03:55:28 +00:00
0e0c6a7ee7
Ensure 'description' is a string in `wp_insert_term()`.
...
Passing `'description' => null` when creating a term can cause MySQL notices,
as the description column in the terms table does not allow for null values.
We correct this by intepreting a `null` description as an empty string.
Props TimothyBlynJacobs.
Fixes #35321 .
Built from https://develop.svn.wordpress.org/trunk@36214
git-svn-id: http://core.svn.wordpress.org/trunk@36181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-07 03:32:28 +00:00
0b9f825e29
Plugins: Avoid ID attribute collisions in plugins list table.
...
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.
Props khag7.
Fixes #18974 .
Built from https://develop.svn.wordpress.org/trunk@36205
git-svn-id: http://core.svn.wordpress.org/trunk@36172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:40:26 +00:00
d5fd177b96
Themes: Avoid changing the count of themes with updates in network admin.
...
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.
See [29786], [31495].
Fixes #35332 .
Built from https://develop.svn.wordpress.org/trunk@36204
git-svn-id: http://core.svn.wordpress.org/trunk@36171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:32:28 +00:00
7ab65139c6
Theme: Escape error messages
...
Built from https://develop.svn.wordpress.org/trunk@36185
git-svn-id: http://core.svn.wordpress.org/trunk@36152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 17:23:28 +00:00
83059c3553
Unit Tests: Fix the unit test added in [36181] to include the index in the comparison.
...
See #35235
Built from https://develop.svn.wordpress.org/trunk@36183
git-svn-id: http://core.svn.wordpress.org/trunk@36150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 08:10:26 +00:00
4a0e40a814
Updates: Don't perform an API call to WordPress.org for every plugin update displayed. The API has been updated to return this information with the update response.
...
See #35301
Built from https://develop.svn.wordpress.org/trunk@36182
git-svn-id: http://core.svn.wordpress.org/trunk@36149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 07:53:26 +00:00
dbe28bf8e3
Rewrite: Add a `remove_permastruct()` helper function.
...
It can be used to remove permastructs that were added using `add_permastruct()`.
Fixes #35235 .
Built from https://develop.svn.wordpress.org/trunk@36181
git-svn-id: http://core.svn.wordpress.org/trunk@36148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 07:40:26 +00:00
06a3f799e7
Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place.
...
See #27772 , #35323 .
Built from https://develop.svn.wordpress.org/trunk@36180
git-svn-id: http://core.svn.wordpress.org/trunk@36147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 06:12:26 +00:00
7d378fce01
Bundled Themes: Bump version number of Twenty Thirteen.
...
Props davidakennedy.
Fixes #35319 .
Built from https://develop.svn.wordpress.org/trunk@36179
git-svn-id: http://core.svn.wordpress.org/trunk@36146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 22:20:26 +00:00
4cb341e82c
Install: Use new colors for error notices.
...
Props duaneblake, DBrumbaugh10Up.
Fixes #34704 .
Built from https://develop.svn.wordpress.org/trunk@36178
git-svn-id: http://core.svn.wordpress.org/trunk@36145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 21:47:25 +00:00
85bb9aa5fb
Query: Add a `WP::remove_query_var()` helper function.
...
This makes cleaning up public query vars easier.
Fixes #35234 .
Built from https://develop.svn.wordpress.org/trunk@36177
git-svn-id: http://core.svn.wordpress.org/trunk@36144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 20:57:28 +00:00
c9d7fb9b28
Install: Only enqueue scripts when necessary.
...
Props flixos90 for initial patch.
Fixes #34700 .
Built from https://develop.svn.wordpress.org/trunk@36176
git-svn-id: http://core.svn.wordpress.org/trunk@36143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 16:42:29 +00:00
0929025aea
Docs: Move the hook doc for the `the_title` filter in `Walker_Page::start_el()` to directly precede the `apply_filters()` line.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@36175
git-svn-id: http://core.svn.wordpress.org/trunk@36142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 16:35:26 +00:00
Boone Gorges
John Blackbourn
Eric Lewis
Pascal Birchler
Dion Hulse
Andrew Ozz
Andrea Fercia
Konstantin Obenland
Weston Ruter
Aaron Jorbin
Dominik Schilling