Commit Graph

18602 Commits

Author SHA1 Message Date
audrasjb 3b946f8047 Grouped backports to the 5.5 branch.
- Editor: Bump @wordpress packages for the branch,
- Media: Refactor search by filename within the admin,
- REST API: Lockdown post parameter of the terms endpoint,
- Customize: Escape blogname option in underscores templates,
- Query: Validate relation in `WP_Date_Query`,
- Posts, Post types: Apply KSES to post-by-email content,
- General: Validate host on "Are you sure?" screen,
- Posts, Post types: Remove emails from post-by-email logs,
- Pings/trackbacks: Apply KSES to all trackbacks,
- Mail: Reset PHPMailer properties between use,
- Comments: Apply kses when editing comments,
- Widgets: Escape RSS error messages for display.

Merges [54521-54530] to the 5.5 branch.
Props audrasjb, costdev, cu121, dd32, davidbaumwald, ehtis, johnbillion, johnjamesjacoby, martinkrcho, matveb, oztaser, paulkevan, peterwilsoncc, ravipatel, SergeyBiryukov, talldanwp, timothyblynjacobs, tykoted, voldemortensen, vortfu, xknown.

Built from https://develop.svn.wordpress.org/branches/5.5@54556


git-svn-id: http://core.svn.wordpress.org/branches/5.5@54111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-10-17 17:59:59 +00:00
Peter Wilson 54eb24feb7 Security: Introduce strings to indicate support status.
Add strings for use in future maintenance/security releases to indicate the security support status of the version of WordPress.

Two strings are introduced:

* indicating the version of WordPress is not receiving security updates, and,
* indicating the version of WordPress will shortly stop receiving security updates.

This change does not make use of the strings, the purpose is to make them available to translators prior to dropping support of selected versions of WordPress.

Props costdev, chesio, robinwpdeveloper, desrosj, rudlinkon, mukesh27, sumitbagthariya16.
Merges [54322] to the 5.5 branch.
See #56532.


Built from https://develop.svn.wordpress.org/branches/5.5@54435


git-svn-id: http://core.svn.wordpress.org/branches/5.5@53994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-10-10 05:05:05 +00:00
desrosj 7692dd406b WordPress 5.5.10.
Built from https://develop.svn.wordpress.org/branches/5.5@53992


git-svn-id: http://core.svn.wordpress.org/branches/5.5@53551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-30 17:30:10 +00:00
Sergey Biryukov f2387898e2 Grouped backports to the 5.5 branch.
- Posts, Post Types: Escape output within `the_meta()`.
- General: Ensure bookmark query limits are numeric.
- Plugins: Escape output in error messages.
- Build/Test Tools: Allow the PHPCS plugin in Composer configuration.

Merges [52412,53958-53960] to the 5.5 branch.
Props tykoted, martinkrcho, xknown, dd32, peterwilsoncc, paulkevan, timothyblynjacobs.

Built from https://develop.svn.wordpress.org/branches/5.5@53968


git-svn-id: http://core.svn.wordpress.org/branches/5.5@53527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-30 15:34:58 +00:00
davidbaumwald bc3f96de92 WordPress 5.5.9.
Built from https://develop.svn.wordpress.org/branches/5.5@52871


git-svn-id: http://core.svn.wordpress.org/branches/5.5@52460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-03-10 21:55:58 +00:00
desrosj 28b01cf262 WordPress 5.5.8.
Built from https://develop.svn.wordpress.org/branches/5.5@52490


git-svn-id: http://core.svn.wordpress.org/branches/5.5@52082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-01-06 18:48:58 +00:00
desrosj 52734cdc4e Grouped backports to the 5.5 branch.
- Query: Improve sanitization within `WP_Tax_Query`.
- Query: Improve sanitization within `WP_Meta_Query`.
- Upgrade/Install: Avoid using `unserialize()` unnecessarily.
- Formatting: Correctly encode ASCII characters in post slugs.

Merges [52454-52457] to the 5.5 branch.
Props vortfu, dd32, ehtis, zieladam, whyisjake, xknown, peterwilsoncc, desrosj, iandunn.
Built from https://develop.svn.wordpress.org/branches/5.5@52468


git-svn-id: http://core.svn.wordpress.org/branches/5.5@52060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-01-06 18:10:57 +00:00
desrosj 9d38fc1ea9 WordPress 5.5.7.
Built from https://develop.svn.wordpress.org/branches/5.5@52116


git-svn-id: http://core.svn.wordpress.org/branches/5.5@51708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-10 17:08:56 +00:00
desrosj daf9eff56a Grouped merges for 5.5.6.
- Update `lodash` to the latest version `4.17.21`.
- Disable some attributes for rich text.
- Use hashed/deterministic moduleIDs in webpack config.

Props ellatrix, peterwilsoncc, get_dave, mcsf, talldanwp, youknowriad, desrosj, nerrad, gziolo.
Merges [50940-50941,50984-50985,51426] to the 5.5 branch.
Built from https://develop.svn.wordpress.org/branches/5.5@51752


git-svn-id: http://core.svn.wordpress.org/branches/5.5@51360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 21:17:20 +00:00
Peter Wilson 356a49af41 WordPress 5.5.5
Built from https://develop.svn.wordpress.org/branches/5.5@50871


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-05-12 23:13:54 +00:00
Peter Wilson 3623a537fa Grouped merges for 5.5.4.
* REST API: Allow authors to read their own password protected posts.
* About page update

Merges [50717] to the 5.5 branch.

Built from https://develop.svn.wordpress.org/branches/5.5@50725


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 01:07:00 +00:00
desrosj 64dc3f9159 Build/Test Tools: Backport GitHub Action and build improvements to the 5.5 branch.
This backports several build and test tool improvements to the 5.5 branch. Most notably, this includes:

- The changes required to allow each workflow to be triggered by the `workflow_dispatch` event so that tests can be run on a schedule [50590].
- The ability to run PHPUnit tests from `src` instead of `build` [50441-50443].
- Splitting single site and multisite tests into parallel jobs [50379].
- Split slow tests into separate, parallel jobs for PHP 5.6 [50444].
- Better branch and path scoping for GitHub Action workflows when running on `pull_request` [50432,50479].
- Several `devDependency` updates.

Merges [50267,50299,50379,50387,50413,50416,50432,50435-50436,50441-50444,50446,50473-50474,50476,50479,50485-50487,50545,50579,50590,50592,50598] to the 5.5 branch.
See #50401, #51734, #51801, #51802, #52548, #52608, #52612, #52623, #52624, #52625, #52645, #52653, #52658, #52660, #52667, #52786.
Built from https://develop.svn.wordpress.org/branches/5.5@50603


git-svn-id: http://core.svn.wordpress.org/branches/5.5@50216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 17:49:17 +00:00
desrosj 2d74427834 Build/Test Tools: Support NodeJS 14.x in the 5.5 branch.
This updates the 5.5 branch to support the latest LTS version of NodeJS (currently 14.x) in an effort to allow the same version of NodeJS to be used across all WordPress branches receiving security updates as a courtesy.

In addition to backporting the package updates that happened after branching 5.5, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [48705,49636,49933,49937,49939-49940,49983,49989-49990,50016-50017,50126,50176,50185] to the 5.5 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/5.5@50188


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 03:06:34 +00:00
Sergey Biryukov 3448d022f8 WordPress 5.5.3.
Props audrasjb.
Fixes #51684.
Built from https://develop.svn.wordpress.org/branches/5.5@49458


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-30 19:32:05 +00:00
desrosj f9e0a7396c WordPress 5.5.2.
Props audrasjb.
Fixes #51649.
Built from https://develop.svn.wordpress.org/branches/5.5@49447


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 20:02:05 +00:00
whyisjake f2b1d503c0 Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.
Props xknown, zieladam, peterwilsoncc, whyisjake

Built from https://develop.svn.wordpress.org/branches/5.5@49379


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:35:04 +00:00
whyisjake a428042e49 Coding standards: Modify escaping functions to avoid potential false positives.
Props xknown, zieladam, peterwilsoncc.Y


Built from https://develop.svn.wordpress.org/branches/5.5@49375


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 16:58:05 +00:00
tellyworth 542c3d4bb1 Community Events: Display dates and times in the user's time zone.
Fixes #51130
Merges [49145], [49146], [49147], [49152], and [49201] to the 5.5 branch.
Props sippis, hlashbrooke, audrasjb, Rarst, iandunn

Built from https://develop.svn.wordpress.org/branches/5.5@49275


git-svn-id: http://core.svn.wordpress.org/branches/5.5@49037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 04:05:05 +00:00
Sergey Biryukov 5188ab0ce7 Upgrade/Install: Check if plugin or theme update results are available before applying the notification filters.
This avoids a PHP notice for an undefined index of either `plugin` or `theme` in the `auto_{plugin|theme}_update_send_email` filter hook.

Props afragen, audrasjb.
Merges [49166] to the 5.5 branch.
Fixes #51400.
Built from https://develop.svn.wordpress.org/branches/5.5@49167


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-15 23:31:07 +00:00
Sergey Biryukov 2434d8188d Comments: Check if a valid comment ID was passed when editing a comment.
This avoids a PHP notice after submitting the Edit Comment form.

Follow-up to [48050].

Props regan.khadgi.
Merges [48958] to the 5.5 branch.
Fixes #51263.
Built from https://develop.svn.wordpress.org/branches/5.5@48959


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-08 22:46:07 +00:00
Sergey Biryukov a4b9563038 Media: In `wp_ajax_image_editor()`, check if the `error` property exists before accessing it.
This avoids a PHP notice when editing an image.

Follow-up to [48375].

Props Mista-Flo.
Merges [48946] to the 5.5 branch.
Fixes #51251.
Built from https://develop.svn.wordpress.org/branches/5.5@48956


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-07 13:07:03 +00:00
Sergey Biryukov ff206bc029 Administration: Give the `$error` variable in `wp-admin/admin-header.php` a more descriptive name.
This avoids a conflict with the same global variable used elsewhere, e.g. in Theme Editor.

Follow-up to [48850].

Props vinayak.anivase.
Merges [48938] to the 5.5 branch.
Fixes #51219.
Built from https://develop.svn.wordpress.org/branches/5.5@48955


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-07 13:05:10 +00:00
Sergey Biryukov bb254465ec Help/About: Update the About page for 5.5.1.
Props audrasjb, desrosj, SergeyBiryukov.
Fixes #51202.
Built from https://develop.svn.wordpress.org/branches/5.5@48933


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-01 17:44:03 +00:00
Sergey Biryukov 0cf22af9bc Help/About: Fix typo and remove trailing spaces from some strings.
Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.
Built from https://develop.svn.wordpress.org/branches/5.5@48932


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-01 17:24:08 +00:00
desrosj fdad915022 Script Loader: Add backward compatibility for JavaScript i18n globals and properties deprecated in WordPress 5.5.
The recommended approach for any plugins using these globals or properties is to switch to the newer `wp.i18n` functions.

In the meantime, this ensures that accessing any of these globals does not break the rest of the code on the page, and an appropriate warning message is logged to the JavaScript console.

Follow-up to: https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5

Props omarreiss, peterwilsoncc, kbjohnson90, johnbillion, TimothyBlynJacobs, joostdevalk, ocean90, desrosj, SergeyBiryukov.
Merges [48923] to the 5.5 branch.
Fixes #51123.
Built from https://develop.svn.wordpress.org/branches/5.5@48925


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 22:44:13 +00:00
desrosj 22ceef8ed5 Themes: Normalize the installed theme path in `Theme_Installer_Skin::do_overwrite()` before comparing with the uploaded theme.
This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.

Follow-up to [48390].

Props bobbingwide, wpamitkumar, mukesh27.
Merges [48913] to the 5.5 branch.
Fixes #51182.
Built from https://develop.svn.wordpress.org/branches/5.5@48919


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 18:31:09 +00:00
desrosj 26edd1d039 Docs: Clarify the usage of `null` for `auto_update_{$type}` filter.
The value is internally used to detect whether nothing has hooked into this filter.

Props audrasjb, pbiron, johnbillion, SergeyBiryukov.
Merges [48909] to the 5.5 branch.
Fixes #50848.
Built from https://develop.svn.wordpress.org/branches/5.5@48916


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 18:02:04 +00:00
desrosj 15ed5a9e75 Docs: Add a `@since` note to the `display_post_states` filter to clarify that it is now also applied in the Customizer context.
If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used.

Follow-up to [47763], [48620].

Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov.
Merges [48910] to the 5.5 branch.
Fixes #51081.
Built from https://develop.svn.wordpress.org/branches/5.5@48915


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 17:57:02 +00:00
Sergey Biryukov a6f6950507 Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature.
Follow-up to [48669], [48688].

Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Merges [48899] to the 5.5 branch.
Fixes #51129.
Built from https://develop.svn.wordpress.org/branches/5.5@48900


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 22:26:04 +00:00
desrosj 9fceb56948 Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters.
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner's liking.

Props audrasjb, Paddy Landau, desrosj.
Merges [48888] to the 5.5 branch.
Fixes #50988.
Built from https://develop.svn.wordpress.org/branches/5.5@48889


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 19:34:05 +00:00
Sergey Biryukov 522904bde6 Taxonomy: Make sure `wp_terms_checklist()` and `Walker_Category_Checklist::start_el()` properly handle an array of strings as `selected_cats` or `popular_cats` values.
Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results.

Add a unit test.

Props brianhogg, TimothyBlynJacobs, SergeyBiryukov.
Merges [48880] to the 5.5 branch.
Fixes #51137.
Built from https://develop.svn.wordpress.org/branches/5.5@48882


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 03:08:03 +00:00
Sergey Biryukov 97bbea6001 Upgrade/Install: Make the check for empty `home` option in `__get_option()` more resilient.
This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty.

Props fjarrett.
Merges [48868] to the 5.5 branch.
Fixes #51011.
Built from https://develop.svn.wordpress.org/branches/5.5@48869


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 17:07:09 +00:00
Sergey Biryukov 559fcbdfed Quick/Bulk Edit: Revert [48134] to address the bottom "Bulk actions" dropdown not functioning properly on Posts and Users list tables.
A better solution for the original issue will be explored in a future release.

Props audrasjb, garrett-eclipse, webzunft, Krstarica, chunkysteveo, SergeyBiryukov.
Merges [48866] to the 5.5 branch.
Fixes #50882, #50998. See #46872.
Built from https://develop.svn.wordpress.org/branches/5.5@48867


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 14:21:04 +00:00
Sergey Biryukov 202f167106 Administration: Remove non-color related styling from Modern color scheme.
Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.

Follow-up to [48277], [48286], [48345].

Props Joen, johnbillion, afercia, johnjamesjacoby.
Merges [48862] to the 5.5 branch.
Fixes #51127. See #50504.
Built from https://develop.svn.wordpress.org/branches/5.5@48863


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 13:21:03 +00:00
Sergey Biryukov be19de843c Administration: Don't print the `.php-error` class in the admin header for PHP notices in `wp-config.php`.
Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`.

Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided.

Follow-up to [20102], [21025], [26620], [47745].

Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov.
Merges [48850] to the 5.5 branch.
Fixes #51073.
Built from https://develop.svn.wordpress.org/branches/5.5@48851


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-24 10:50:05 +00:00
Sergey Biryukov 5ddabef439 Plugins: Avoid a PHP notice if the `update-supported` key in plugin data is not set.
Props sanzeeb3.
Merges [48820] to the 5.5 branch.
Fixes #51052.
Built from https://develop.svn.wordpress.org/branches/5.5@48821


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 20:40:04 +00:00
Sergey Biryukov 62a5dbff7b Help/About: Revert [48811] from the 5.5 branch for now, to avoid displaying untranslated strings on the About page.
This should be merged back when 5.5.1 is about to be released.

See #51028.
Built from https://develop.svn.wordpress.org/branches/5.5@48813


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 03:02:08 +00:00
Sergey Biryukov b2e4cc384d Help/About: Fix typo and remove trailing spaces from some strings.
Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.
Built from https://develop.svn.wordpress.org/branches/5.5@48811


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 10:59:06 +00:00
Sergey Biryukov f6dfc217e7 Site Health: Ensure that the tests returned by `WP_Site_Health::get_tests()` always have the required array keys: `direct` and `async`.
This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter.

Props khag7, Ov3rfly, desrosj, Clorith.
Merges [48808] to the 5.5 branch.
Fixes #50858.
Built from https://develop.svn.wordpress.org/branches/5.5@48810


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 02:23:06 +00:00
Sergey Biryukov 260dd52af5 Site Health: Only display the warning about the `post_max_size` PHP value when it's lower than `upload_max_filesize`.
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Merges [48800] and [48801] to the 5.5 branch.
Fixes #50945.
Built from https://develop.svn.wordpress.org/branches/5.5@48806


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:29:03 +00:00
Sergey Biryukov f86e37faae Site Health: Add site environment type to the debug information.
Follow-up to [47919], [48188], [48372].

Props joostdevalk, Clorith.
Merges [48802] to the 5.5 branch.
Fixes #50887.
Built from https://develop.svn.wordpress.org/branches/5.5@48805


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:25:04 +00:00
Sergey Biryukov 3557ce0af2 Site Health: Recognize `define( 'WP_AUTO_UPDATE_CORE', 'minor' )` as an acceptable value.
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.

With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Merges [48792] to the 5.5 branch.
Fixes #50912.
Built from https://develop.svn.wordpress.org/branches/5.5@48804


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 01:04:04 +00:00
Sergey Biryukov 38da35836a Filesystem API: Use correct variable when closing the file handle in `WP_Filesystem_FTPext::get_contents()`.
Props gothick@gothick.org.uk.
Merges [48797] to the 5.5 branch.
Fixes #51029.
Built from https://develop.svn.wordpress.org/branches/5.5@48803


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 00:57:07 +00:00
desrosj abd91fb7c9 Help/About: Final adjustments to the 5.5 About page.
- Final CDN asset URLs.
- Some minor color adjustments.

Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Merges [48783] to the 5.5 branch.
Fixes #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48784


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 16:57:06 +00:00
Sergey Biryukov d5c3cd0293 I18N: Fix typo in a screen reader text string on the About page.
Follow-up to [48729].

Props pedromendonca.
Reviewed by desrosj, SergeyBiryukov.
Merges [48770] to the 5.5 branch.
Fixes #50884.
Built from https://develop.svn.wordpress.org/branches/5.5@48771


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 13:25:05 +00:00
Sergey Biryukov 8e47fe0608 Help/About: Update videos and their descriptions on the About page.
Follow-up to [48675], [48686], [48721], [48729], [48730], [48736].

Props ryelle, marybaum, estelaris, desrosj, joen, afercia.
Reviewed by jorbin, SergeyBiryukov.
Merges [48761] to the 5.5 branch.
See #50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48763


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 21:02:06 +00:00
whyisjake 931826a203 Docs: Correct usage of the dynamic auto_update_{$type} filter.
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

This brings the changes from [48750] to the 5.5 branch.

Props johnbillion.
Fixes #50868, see [48750].

Built from https://develop.svn.wordpress.org/branches/5.5@48756


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 19:25:02 +00:00
Sergey Biryukov 52b59a5f07 Comments: Update comment cache in the upgrade routine for changing the `comment_type` DB field value in comments table.
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.

Add a unit test for `_wp_batch_update_comment_type()`.

Follow-up to [47597], [47626], [48225], [48227].

Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes #49236.
Built from https://develop.svn.wordpress.org/branches/5.5@48752


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:35:08 +00:00
desrosj 719ef3461b Site Health: Consistently pass an object to the `auto_update_{$type}` filter in Site Health debug data.
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.

Merges [48745] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bpayton, pbiron.
Fixes #50852.
Built from https://develop.svn.wordpress.org/branches/5.5@48747


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:51:02 +00:00
desrosj 081d50e68f Site Health: Check if session_status() exists before calling it.
Merges [48742] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bgermann.
Fixes #50862.
Built from https://develop.svn.wordpress.org/branches/5.5@48746


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:43:05 +00:00